| opendevreview | Merged openstack/octavia master: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/868765 | 00:19 |
|---|---|---|
| opendevreview | Merged openstack/octavia-dashboard master: Fix tox.ini with tox4 https://review.opendev.org/c/openstack/octavia-dashboard/+/868964 | 06:03 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/zed: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869153 | 09:18 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/yoga: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869155 | 09:20 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/yoga: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869155 | 09:25 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/yoga: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869155 | 09:27 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/xena: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869157 | 09:28 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/wallaby: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869158 | 09:28 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/victoria: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869159 | 09:28 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/ussuri: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869160 | 09:32 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/train: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869161 | 09:37 |
| opendevreview | Omer Schwartz proposed openstack/octavia master: Fix missing non default pools on lb status show https://review.opendev.org/c/openstack/octavia/+/868479 | 10:35 |
| opendevreview | Omer Schwartz proposed openstack/octavia master: Fix hm operating status to ONLINE in single lb call https://review.opendev.org/c/openstack/octavia/+/868363 | 10:38 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/victoria: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869159 | 10:40 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/wallaby: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869158 | 10:48 |
| opendevreview | Tom Weininger proposed openstack/octavia stable/ussuri: Fix broken tox.ini with tox4 https://review.opendev.org/c/openstack/octavia/+/869160 | 10:48 |
| opendevreview | Tom Weininger proposed openstack/octavia master: WIP remove python-neutronclient https://review.opendev.org/c/openstack/octavia/+/866327 | 11:47 |
| opendevreview | Tom Weininger proposed openstack/octavia master: WIP remove python-neutronclient https://review.opendev.org/c/openstack/octavia/+/866327 | 11:49 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Update and rename convert_*_to_model functions https://review.opendev.org/c/openstack/octavia/+/868352 | 11:49 |
| opendevreview | Merged openstack/octavia master: Remove i386 amphora build support https://review.opendev.org/c/openstack/octavia/+/790909 | 12:00 |
| opendevreview | Merged openstack/octavia-tempest-plugin master: Remove skip flag for tests skipped due to inactive bug https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/864570 | 12:56 |
| opendevreview | Omer Schwartz proposed openstack/octavia master: Remove unused create_load_balancer_tree code https://review.opendev.org/c/openstack/octavia/+/866585 | 13:54 |
| opendevreview | Omer Schwartz proposed openstack/octavia master: Fix pool creation with single LB create call https://review.opendev.org/c/openstack/octavia/+/864204 | 13:54 |
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed Jan 4 16:00:21 2023 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| tweining | o/ | 16:00 |
| gthiemonge | o/ HNY! | 16:00 |
| oschwart | o/ HNY! | 16:00 |
| johnsom | o/ | 16:00 |
| gthiemonge | #topic Announcements | 16:02 |
| gthiemonge | * Deadline for CFP on Jan 10th | 16:03 |
| gthiemonge | FYI the deadline for the Call for Paper for the 2023 OpenInfra summit is closing soon (Jan 10th) | 16:03 |
| gthiemonge | #link https://cfp.openinfra.dev/app/vancouver-2023/19/presentations | 16:03 |
| gthiemonge | any other annoucements? | 16:05 |
| johnsom | MS2 is next week | 16:05 |
| tweining | yeah, in a bit more than a month is feature freeze I think | 16:05 |
| johnsom | Correction, this week | 16:05 |
| johnsom | Yeah, feature freeze is Feb 13th | 16:06 |
| johnsom | That week | 16:06 |
| johnsom | Also, the virtual PTG registration is now open: | 16:06 |
| gthiemonge | wow next week | 16:06 |
| tweining | so time for updating the review priorities soon I guess | 16:06 |
| johnsom | #link https://openinfra.dev/ptg/ | 16:06 |
| gthiemonge | tweining: I agree | 16:06 |
| gthiemonge | thanks for the heads-up folks | 16:07 |
| gthiemonge | #topic CI Status | 16:09 |
| gthiemonge | the fix for tox4 was merged on master | 16:09 |
| gthiemonge | thank you to those who have worked on it! | 16:09 |
| gthiemonge | and the backports are in review on stable branches! thanks tweining! | 16:10 |
| gthiemonge | #link https://review.opendev.org/q/I5ac930e0d3928bb8acba4212dfff25f788acd442 | 16:10 |
| tweining | np | 16:10 |
| tweining | at least I learnt how to debug such issues on Zuul nodes directly, so it wasn't completly wasted time ;) | 16:11 |
| gthiemonge | FYI our tempest jobs are still based on Ubuntu Focal, we have a commit that updates them to Jammy (on master) that has been waiting for a long time | 16:12 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/861369 | 16:12 |
| oschwart | gthiemonge: ack, I will review too | 16:16 |
| gthiemonge | thanks | 16:16 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:16 |
| tweining | there are lots of small changes can can be reviewed quickly | 16:17 |
| tweining | *that an | 16:17 |
| gthiemonge | I have one important fix: fix listener creation with fully-populated API (only for SINGLE topology): | 16:20 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/868423 | 16:20 |
| gthiemonge | we could also review the associated tempest test (yeah, it's still not covered by the CI) | 16:20 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/824999 | 16:20 |
| gthiemonge | (V-1 we need to take a look) | 16:21 |
| gthiemonge | another change is about losing the qos_policy_id after a failover of a LB: | 16:21 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/868994 | 16:21 |
| oschwart | I will review and test it | 16:24 |
| tweining | I continued to work on removing neutronclient, but we can discuss that during open discussion | 16:24 |
| gthiemonge | #topic Open Discussion | 16:25 |
| gthiemonge | :) | 16:25 |
| tweining | https://review.opendev.org/q/topic:remove-neutronclient+project:openstack/octavia | 16:25 |
| tweining | I will squash it into 1 patch later but for now it's easier for me to track the changes that way | 16:25 |
| tweining | so one issue I ran into is grenade | 16:26 |
| tweining | old config needs to work with new code apparently | 16:26 |
| gthiemonge | johnsom: do you confirm? | 16:27 |
| johnsom | We need to maintain compatibility such that upgrades don't break | 16:27 |
| gthiemonge | ok | 16:27 |
| johnsom | Via deprecation cycles | 16:27 |
| gthiemonge | hmm ok | 16:28 |
| johnsom | https://docs.openstack.org/oslo.config/latest/reference/deprecating.html | 16:28 |
| johnsom | But, it is best to "just have the code fix/do the right thing". | 16:28 |
| johnsom | What is the specific config issue you hit? | 16:28 |
| gthiemonge | there are some helpers in keystoneauth that automatically add options for authentication to the config parser | 16:28 |
| johnsom | auth_url? | 16:29 |
| gthiemonge | that would be nice to use them | 16:29 |
| gthiemonge | but for instance, they add a 'endpoint_override' while we have already a 'endpoint' for the same purpose | 16:29 |
| gthiemonge | how could we deal with that? | 16:29 |
| tweining | mmh, I need to check. it happened last year ;) | 16:29 |
| gthiemonge | ok, so in case of missing params in [neutron], we could use for instance the value from [service_auth] | 16:30 |
| johnsom | Well, originally we had to do things a bit more manually (couldn't use the keystoneauth parsers) because we have separate configs for each service we talk to. So it doesn't know how to parse them correctly or where they are. | 16:30 |
| tweining | yeah "Auth plugin requires parameters which were not given: auth_url" | 16:30 |
| johnsom | Some clouds did "odd" things like having neutron in a different region than nova for example. | 16:31 |
| johnsom | So they had to have full duplicates of the config settings for EACH service | 16:31 |
| gthiemonge | yeah, so now, it means that we would have multiple openstacksdk connections (with different parameters) | 16:31 |
| johnsom | So, service_auth section was purely for talking with keystone, the others were for nova, neutron, glance, etc. | 16:32 |
| johnsom | Yeah, that is how it is today, multiple client connections | 16:32 |
| johnsom | We use singletons, so we only create one "instance" per service | 16:33 |
| tweining | when using the ks_loading functions in combination with the neutron config section (which seemed the right thing to do) I noticed that it doesn't work if ovn provider is used because it uses that section too. | 16:34 |
| johnsom | For the auth_url, I think it would be fair to default back to the service_auth settings if it's not defined, but I'm not sure oslo.config will make that easy. | 16:34 |
| tweining | but gthiemonge found a way to work around that | 16:35 |
| johnsom | OVN provider should NOT be defining config settings that overlap with ours. They could use what we have, but should not add overlapping config sections. | 16:36 |
| tweining | gthiemonge said if it breaks their stuff they need to fix it | 16:36 |
| gthiemonge | we can also help them :D | 16:37 |
| johnsom | Yeah, if they are adding config settings that overlap sections we define, that is an OVN provider bug | 16:37 |
| tweining | yeah, what I mean is that it is not blocking the change | 16:37 |
| johnsom | right | 16:37 |
| johnsom | On a side note, you don't want to break config settings during upgrade, world-plus-dog will hate you as all 16 deployment tool projects will break. | 16:39 |
| gthiemonge | yeah | 16:40 |
| tweining | ok, thanks guys. so I understand using a separate neutron section in the config is okay, but code should use service_auth if it doesn't exist in the config. | 16:42 |
| johnsom | Extra credit: I don't think our provider driver development guide talks about config settings, we might want to add a section saying that any config settings added by a provider driver must be name spaced to the provider driver. | 16:42 |
| johnsom | I think that is fair, yes. | 16:42 |
| gthiemonge | johnsom: thanks | 16:45 |
| gthiemonge | anything else folks? | 16:47 |
| tweining | only that we need to increase review speed | 16:48 |
| johnsom | My time is pretty limited for reviews | 16:48 |
| gthiemonge | I will restore the etherpad | 16:48 |
| johnsom | So, yeah, prioritizing is going to be key to getting my time | 16:48 |
| tweining | some changes are really tiny and should only take a minute or so | 16:50 |
| johnsom | Yeah, but I can't track the patches in octavia like I used to be able too. I'm spread over a lot of projects now | 16:50 |
| johnsom | So, hints, nags, priority lists are going to be your best bet | 16:51 |
| tweining | johnsom: https://review.opendev.org/c/openstack/octavia/+/858739 whould be a good start :) | 16:52 |
| tweining | thanks. that's all from me. | 16:52 |
| oschwart | Nothing from me | 16:53 |
| gthiemonge | Ok Folks! | 16:54 |
| gthiemonge | Thank you, really interesting talks! | 16:54 |
| gthiemonge | #endmeeting | 16:54 |
| opendevmeet | Meeting ended Wed Jan 4 16:54:26 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:54 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-01-04-16.00.html | 16:54 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-01-04-16.00.txt | 16:54 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-01-04-16.00.log.html | 16:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!