| *** yadnesh|away is now known as yadnesh | 04:47 | |
| opendevreview | Denys Mishchenko proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 08:42 |
|---|---|---|
| ard_ | gthiemonge: loadbalancer_id gave me brilliant idea. I used its hash and MASTER/BACKUP from the name to define AZ to use. And made it working. I made changes to the patch and have a couple of questions:1. Looked at the database and properties in the flavour schema are string values. And I used string as well:https://review.opendev.org/c/openstack/octavia/+/558962/42/octavia/api/drivers/amphora_driver/flavor_schema.py#51 | 08:52 |
| ard_ | But it might be a good idea to use list and validate it during API calls. 2. I just added loadbalancer_id to the end of arguments with the default value of Null. But this value should be present all the time and never be null. Is there any validation to confirm that arguments aren't used as positional and a new one could be added in the middle without defult value: https://review.opendev.org/c/openstack/octavia/+/558962/42/octavia/c | 08:52 |
| ard_ | ontroller/worker/v1/tasks/compute_tasks.py#583. I used properties of the loadbalancer profile to define a list of AZs, but there might be a better place for it. | 08:52 |
| gthiemonge | ard_: hi | 08:56 |
| gthiemonge | I think it's fine if you want to have a list of AZs in the flavor | 08:57 |
| ard_ | gthiemonge: so, you mean it will work if I just change string to a list? Or you mean that keeping a list of az as a string with comma delimiter is fine? | 09:02 |
| gthiemonge | no we will have to modify https://review.opendev.org/c/openstack/octavia/+/558962/42/octavia/controller/worker/v2/tasks/compute_tasks.py#122 for instance | 09:07 |
| gthiemonge | well it's up to you, we can keep a comma delimited string, and validate it in the API | 09:08 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Add release note about fixing castellan https://review.opendev.org/c/openstack/octavia/+/867361 | 12:48 |
| noonedeadpunk | gthiemonge: I've pushed release note as a follow up patch ^ | 12:49 |
| noonedeadpunk | though it's not all clean with castellan. At least smth is off for sure with using barbican through castellan | 12:49 |
| noonedeadpunk | but I'm not sure how valuable is that, as I'd say that most valuable part of castellan are backends other then barbican | 12:49 |
| noonedeadpunk | (read vault) | 12:50 |
| noonedeadpunk | As RequestContext/Context does not pass user token to castellan | 12:50 |
| gthiemonge | noonedeadpunk: ack, thanks! | 12:53 |
| *** yadnesh is now known as yadnesh|away | 13:34 | |
| *** dulek_ is now known as dulek | 14:06 | |
| opendevreview | Omer Schwartz proposed openstack/octavia master: fix haproxy_count to display the number of running processes https://review.opendev.org/c/openstack/octavia/+/822041 | 15:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!