| *** yadnesh|away is now known as yadnesh | 04:31 | |
| *** yadnesh is now known as yadnesh|afk | 07:50 | |
| *** yadnesh|afk is now known as yadnesh | 08:41 | |
| *** yadnesh is now known as yadnesh|afk | 13:02 | |
| *** yadnesh|afk is now known as yadnesh | 13:32 | |
| opendevreview | Pierre-Yves Jourel proposed openstack/octavia-dashboard master: Add ability to create Prometheus listener https://review.opendev.org/c/openstack/octavia-dashboard/+/866064 | 14:05 |
|---|---|---|
| opendevreview | Pierre-Yves Jourel proposed openstack/octavia-dashboard master: Add ability to create Prometheus listener https://review.opendev.org/c/openstack/octavia-dashboard/+/866064 | 14:19 |
| opendevreview | Pierre-Yves Jourel proposed openstack/octavia-dashboard master: Add ability to create Prometheus listener https://review.opendev.org/c/openstack/octavia-dashboard/+/866064 | 14:31 |
| *** yadnesh is now known as yadnesh|away | 14:59 | |
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed Nov 30 16:00:49 2022 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | Hi there | 16:00 |
| matfechner | o/ | 16:01 |
| oschwart | o/ | 16:01 |
| tweining | o/ | 16:01 |
| johnsom | o/ | 16:02 |
| gthiemonge | #topic Announcements | 16:03 |
| gthiemonge | well, I have no announcement today | 16:03 |
| gthiemonge | anyone? | 16:04 |
| johnsom | Nope | 16:04 |
| gthiemonge | alright | 16:04 |
| gthiemonge | #topic CI Status | 16:04 |
| gthiemonge | FIPS: we need an additional CR+2 on | 16:04 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/864391 | 16:04 |
| gthiemonge | (it fixes the FIPS job by spliting it into 2 jobs) | 16:04 |
| gthiemonge | Ubuntu Jammy support: we are late on this, I still need to figure out why it is failing at | 16:05 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/861369/7 | 16:05 |
| gthiemonge | (last thing, the stable/zed jobs are still missing in octavia-tempest-plugin, I proposed a patch which is a child of the ubuntu-jammy patch) | 16:08 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:09 |
| pyjou | I reworked my change for Prometheus on Horizon. I just added the listener type and removed the button that automatically adds the prometheus listener. I don't have much time to rewrite the dashboard. | 16:09 |
| pyjou | #link https://review.opendev.org/c/openstack/octavia-dashboard/+/866064 | 16:09 |
| gthiemonge | pyjou: great, I will test it. Thanks! | 16:10 |
| johnsom | Last week I posted a patch for the content type issue reported in IRC. Basically if the Accept header to our API included content types other than just JSON, there were some edge cases where pecan would return HTML responses (as they were in the allow list). | 16:11 |
| johnsom | #link https://review.opendev.org/c/openstack/octavia/+/865475 | 16:11 |
| johnsom | I will address the comments today, but could use some more reviews. It should be pretty complete. | 16:11 |
| gthiemonge | ack, i'll take a look at it too | 16:11 |
| oschwart | I will take a look at those too | 16:12 |
| oschwart | I am still missing another +2 on this one | 16:12 |
| oschwart | #link https://review.opendev.org/c/openstack/octavia/+/860211 | 16:12 |
| tweining | I am currently working on replacing python-neutronclient code with openstacksdk in Octavia | 16:14 |
| johnsom | Oh, nice! | 16:14 |
| johnsom | Creating an alternate network driver? | 16:15 |
| tweining | replacing APIs is fairly straightforward, but creating the openstack Connection is trickier than I thought. | 16:15 |
| tweining | I try to just replace neutronclient calls with equivalent openstacksdk calls. | 16:16 |
| johnsom | Yeah, that has changed some over time too. I can't remember if our code in octavia-dashboard uses a horizon connection that is already setup or if we had to do that. | 16:16 |
| johnsom | #link https://github.com/openstack/octavia-dashboard/blob/master/octavia_dashboard/api/rest/lbaasv2.py#L39 | 16:18 |
| gthiemonge | oh nice | 16:19 |
| tweining | I will have a look, thanks | 16:20 |
| johnsom | That is reusing the user token, so will need some adjustments for the neutron login info, but at least a starter | 16:20 |
| tweining | my approach was to do it similar to this https://opendev.org/openstack/ironic/src/branch/master/ironic/common/neutron.py#L78 | 16:21 |
| tweining | which I couldn't get to work so far | 16:22 |
| johnsom | yeah, the method for setting up a connection has changed over the years. I know Monty had to help us update dashboard at one point. I'm not sure which version is more "correct", but the "get_one_cloud" makes me think that is the newer approach. | 16:23 |
| johnsom | Given we have special configs for each service account, this approach might be easier (like dashboard): | 16:25 |
| johnsom | #link https://docs.openstack.org/openstacksdk/latest/user/connection.html#using-only-keyword-arguments | 16:25 |
| tweining | I've tried it that way too. it created it's own set of issues | 16:27 |
| tweining | ok, let's move on. | 16:29 |
| gthiemonge | #topic Open Discussion | 16:29 |
| tweining | just FYI: if you updated you local env to Python 3.11 you might have noticed that it breaks the test environment. | 16:31 |
| tweining | https://review.opendev.org/c/openstack/requirements/+/866125 should fix this | 16:31 |
| gthiemonge | tweining: thanks! | 16:32 |
| johnsom | Nice catch | 16:33 |
| gthiemonge | anything else folks? | 16:34 |
| tweining | not from me | 16:35 |
| gthiemonge | ok thank you! | 16:37 |
| gthiemonge | #endmeeting | 16:37 |
| opendevmeet | Meeting ended Wed Nov 30 16:37:28 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:37 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2022/octavia.2022-11-30-16.00.html | 16:37 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2022/octavia.2022-11-30-16.00.txt | 16:37 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2022/octavia.2022-11-30-16.00.log.html | 16:37 |
| opendevreview | Michael Johnson proposed openstack/octavia master: Fix Octavia API HTTP Accept header handling https://review.opendev.org/c/openstack/octavia/+/865475 | 19:38 |
| *** Guest305 is now known as atmark | 21:07 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!