| *** yadnesh|away is now known as yadnesh | 04:31 | |
| *** ysandeep|out is now known as ysandeep | 05:53 | |
| *** ysandeep is now known as ysandeep|afk | 10:53 | |
| *** ysandeep|afk is now known as ysandeep | 12:22 | |
| *** yadnesh is now known as yadnesh|afk | 12:26 | |
| *** ysandeep is now known as ysandeep|out | 13:44 | |
| *** yadnesh|afk is now known as yadnesh | 13:53 | |
| *** yadnesh is now known as yadnesh|away | 14:19 | |
| danfai | since I don't have an account on the openstack trackers yet, can I make you aware of a small bug in the abstract class for the network driver: octavia/network/base.py? Line 227, def update_vip(self, load_balancer, for_delete) should include the default argument for_delete=False, since the network_tasks depend on that logic, at least according to what I understand. | 16:01 |
|---|---|---|
| tweining | danfai: I think you are right. the base class should have that default argument too, the network drivers have it and that is why still worked. | 17:08 |
| tweining | I can propose a quick patch for it. thanks. | 17:09 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Align signature of AbstractNetworkDriver.update_vip method https://review.opendev.org/c/openstack/octavia/+/863544 | 17:15 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!