| *** ysandeep|out is now known as ysandeep | 05:28 | |
| *** ysandeep is now known as ysandeep|brb | 06:03 | |
| *** ysandeep|brb is now known as ysandeep | 06:36 | |
| opendevreview | Arkady Shtempler proposed openstack/octavia-tempest-plugin master: New "test_trigger_amphorae_failover" test case https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/751617 | 09:30 |
|---|---|---|
| *** ysandeep is now known as ysandeep|lunch | 10:21 | |
| *** ysandeep|lunch is now known as ysandeep | 10:58 | |
| *** ysandeep is now known as ysandeep|afk | 12:53 | |
| *** ysandeep|afk is now known as ysandeep | 13:15 | |
| *** ysandeep is now known as ysandeep|out | 14:50 | |
| spencerharmon | Big thanks to tweining and johnsom with getting my octavia devstack working yesterday. I was able to replicate the issue with the notifications.info queue not being created as expected. | 17:52 |
| spencerharmon | What I found is that, without the driver setting under the oslo_messaging_notifications heading in octavia.conf, the event notification task is executed, but no queue is created. This is actually expected. The default value of the driver is None, so it's required to set this. | 17:52 |
| spencerharmon | With this configuration added, and without setting topics = notifications, the expected behavior occurs: oslo.messaging creates the default notifications.info queue. However, this only happens after an event notification task is executed, e.g. loadbalancer.create.end (which takes a long time on my system). | 17:53 |
| spencerharmon | If you think this can be clarified in the documentation, let me know. Perhaps this configuration could be added in the devstack documentation as well (which, in my opinion needs updating due to devstack now defaulting to ovn anyway, rendering the example config invalid). | 17:53 |
| spencerharmon | (btw this is about https://review.opendev.org/c/openstack/octavia/+/831051) | 17:53 |
| johnsom | spencerharmon One other thing that might help is including it in the sample octavia.conf: https://github.com/openstack/octavia/blob/master/etc/octavia.conf | 17:56 |
| johnsom | Commented out of course. | 17:56 |
| johnsom | The whole reason for that file is to be able to put examples with comments to make it easier for people to understand the options | 17:58 |
| spencerharmon | Oh yes! Can do. | 17:59 |
| spencerharmon | I see that oslo_messaging_notifications.driver is mentioned, but it's not added as a heading. | 18:00 |
| spencerharmon | Do you think I should add transport_url and topics here as well? | 18:01 |
| johnsom | I would mention it there at least. | 18:01 |
| spencerharmon | Great. I sure will. | 18:02 |
| johnsom | +1 | 18:02 |
| opendevreview | Spencer Harmon proposed openstack/octavia master: Add event notifications for load balancers. https://review.opendev.org/c/openstack/octavia/+/831051 | 18:18 |
| opendevreview | Merged openstack/octavia master: Fix rfc3986 deprecation warning https://review.opendev.org/c/openstack/octavia/+/850591 | 19:27 |
| opendevreview | Merged openstack/octavia master: Fix keepalivedlvs_query regex nested set warning https://review.opendev.org/c/openstack/octavia/+/850595 | 19:27 |
| opendevreview | Michael Johnson proposed openstack/octavia master: Fix alembic migration template https://review.opendev.org/c/openstack/octavia/+/851466 | 19:45 |
| spencerh` | I added those comfig options to octavia.conf, but it looks like an unrelated unit test failed. It doesn't seem to be related to my change, but I see where this test passed since the update from last month. Is anyone familiar with this test that could provide some guidance on what to do for this? | 23:41 |
| spencerh` | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_595/831051/19/check/octavia-tox-py39-tips/5959849/testr_results.html | 23:41 |
| spencerh` | https://review.opendev.org/c/openstack/octavia/+/831051 | 23:41 |
| johnsom | Ha, yeah, highly unlikely to be related to your patch. | 23:42 |
| spencerh` | It's octavia.tests.unit.api.drivers.driver_agent.test_driver_listener.TestDriverListener.test_stats_listener | 23:42 |
| spencerh` | Looks like it was last modified here (and passed at the time) https://opendev.org/openstack/octavia/commit/51eef0d6d7ac6f511e23a8ceb59dc0f0dd7cfbdf | 23:43 |
| johnsom | Note, the job that failed is "tips" which means it's pulling some code from git for dependencies. It could be something else broke. | 23:45 |
| spencerh` | Ah yeah, gotcha. | 23:45 |
| johnsom | Hmmm, that is a bit of an odd test isn't it | 23:50 |
| spencerh` | I couldn't figure what should call serve_forever, but I'll assume it must get called at some point since it did pass haha! | 23:51 |
| johnsom | https://github.com/openstack/octavia/blob/master/octavia/api/drivers/driver_agent/driver_listener.py#L139 | 23:52 |
| johnsom | I threw a recheck on it. I highly doubt that is related to your patch. | 23:53 |
| spencerh` | Thx! | 23:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!