| opendevreview | Ade Lee proposed openstack/octavia master: Add fips jobs https://review.opendev.org/c/openstack/octavia/+/798151 | 03:35 |
|---|---|---|
| noonedeadpunk | Hey there! I was wondering if there some work/discussions were held regarding cross-AZ scheduling? | 08:32 |
| noonedeadpunk | As at this point `availability_zone` seems to be a setting in config, which means you can't create 2 amphoras between AZs | 08:34 |
| noonedeadpunk | or even can't provide nova AZ for LB with API call? | 08:35 |
| gthiemonge | noonedeadpunk: hi | 08:37 |
| gthiemonge | there's an experimental patch by rm_work: https://review.opendev.org/c/openstack/octavia/+/558962 | 08:37 |
| noonedeadpunk | oh! | 08:38 |
| gthiemonge | I think he's still using it in his cloud | 08:38 |
| noonedeadpunk | oh, wow | 08:38 |
| gthiemonge | it requires a l2 network shared between the AZs (to handle vrrp traffic) | 08:38 |
| noonedeadpunk | yeah, that's understandable | 08:38 |
| gthiemonge | during the Yoga PTG, we discussed other approaches (see https://etherpad.opendev.org/p/yoga-ptg-octavia) with BGP announcements | 08:39 |
| gthiemonge | but nobody is working on it | 08:39 |
| noonedeadpunk | From notes seems Wallmart was most interested in that? | 08:41 |
| noonedeadpunk | but ok, that's a good start! We'll what we can do, as we're interested to get this implemented for our usecase. | 08:42 |
| noonedeadpunk | *we'll see | 08:42 |
| opendevreview | Susanta gautam proposed openstack/octavia master: Add simple notifications for load balancers https://review.opendev.org/c/openstack/octavia/+/784628 | 08:52 |
| gthiemonge | noonedeadpunk: they were interested, but a few years ago | 08:53 |
| gthiemonge | I think it was in 2018 | 08:53 |
| noonedeadpunk | yeah, based on patch timestamps | 08:54 |
| noonedeadpunk | Well, I'm not promising anything, but we're really interested in this feature right now, and tend to contribute back :) | 08:55 |
| gthiemonge | noonedeadpunk: cool! | 08:55 |
| noonedeadpunk | I was asking not to start re-inveniting bycicle :) | 08:56 |
| rm_work | yeah I worked on rebasing that patch recent;y | 08:57 |
| rm_work | if you want to try to get it back to working, I can help | 08:58 |
| rm_work | just ping me 🙂 | 08:58 |
| rm_work | unfortunately I am NOT running that patch anymore but it should be mostly good to go | 08:58 |
| rm_work | (switched companies) | 08:58 |
| noonedeadpunk | well, things seem to change still last rebase (looking at current conflicts) :) | 09:04 |
| noonedeadpunk | thanks, I won't hesitate then ;) | 09:05 |
| noonedeadpunk | Eventually with https://opendev.org/openstack/octavia/commit/815a283823121d563562474eb9048673a95f6e1f things changed for this patch | 09:08 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 10:49 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 11:08 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 11:09 |
| opendevreview | Arx Cruz proposed openstack/octavia-tempest-plugin master: Add scp_connection_disable_sftp option to octavia tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/826633 | 11:19 |
| opendevreview | Susanta gautam proposed openstack/octavia master: Add simple notifications for load balancers https://review.opendev.org/c/openstack/octavia/+/784628 | 12:13 |
| dav1dbartos | Hi all, have anyone else expirienced Octavia not finding amphora image on stable/wallaby based API due to "wrong" filter key in glance image driver? It could possibly be just caused by me using stable/wallaby branch with patches from master of Glance. After replacing the "tag" to "tags" in https://opendev.org/openstack/octavia/src/branch/master/octavia/image/drivers/glance_driver.py#L52 it started working. | 13:23 |
| dav1dbartos | I’ve ruled out the possibility of it being just policy mess by checking self.manager.list output and it did not contain the „tag“ value, only „tags“ | 13:23 |
| gthiemonge | dav1dbartos: I've not heard of that, we have jobs on stable/wallaby that are passing | 13:28 |
| rm_work | yeah I wonder if glance-master changed the key name? but that'd be a pretty big API break for them, I think... they pretty much don't make changes for the last 10 cycles AFAIK lol | 13:43 |
| rm_work | noonedeadpunk: hmm yeah I thought I already did the rebase for that. I wonder if I didn't push it up >_< | 13:47 |
| noonedeadpunk | :D | 13:51 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 14:16 |
| noonedeadpunk | rm_work: so with ^ I get only 1 unit test failure - https://paste.opendev.org/show/812402/ I'm not seeing some obvious issue there I believe... | 14:17 |
| rm_work | hmm | 14:19 |
| rm_work | hah yeah i am pretty sure I had worked on this since 2019 😀 but must have lost it at some point before I pushed up, RIP | 14:19 |
| rm_work | looks like maybe you handled most of it tho? | 14:20 |
| rm_work | oh, just tests | 14:20 |
| rm_work | i guess maybe it really was back in 2019 I rebase this? rofl | 14:26 |
| rm_work | cause it definitely has had the Spares Pool code removed | 14:26 |
| rm_work | noonedeadpunk: i'm not actually sure if this patch needs much work? it's just the test failures you're worried about now I guess? | 14:31 |
| noonedeadpunk | yeah) | 14:32 |
| noonedeadpunk | I just don't see why it fails :) | 14:32 |
| noonedeadpunk | it's smth obvious I'm missing, but I'm jsut not that common with octavia code as for now | 14:32 |
| noonedeadpunk | and it's just one single test that fails now | 14:32 |
| rm_work | debugging it | 14:36 |
| rm_work | seems like it may be an easy fix | 14:36 |
| rm_work | in `amphora_driver_tasks.py` line 306, when it's looping over the result of the DB fetch... | 14:37 |
| rm_work | the `db_lb` object is a blank mock, so it has no `db_lb.amphorae` to loop | 14:37 |
| rm_work | the mocks got out of order | 14:39 |
| rm_work | did you delete one from the method signature somewhere? | 14:39 |
| rm_work | `mock_loadbalancer_repo_get` is actually `mock_loadbalancer_repo_get_all` | 14:39 |
| rm_work | oh, or amp_repo_get_all | 14:42 |
| rm_work | anyway, it's wrong | 14:42 |
| rm_work | pushing the fix | 14:42 |
| noonedeadpunk | ah, yes, I did :( | 14:46 |
| opendevreview | Adam Harwell proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 14:46 |
| rm_work | easy enough to figure out with a debugger 😛 | 14:47 |
| noonedeadpunk | thanks! | 14:47 |
| noonedeadpunk | ah, well, I don't write a lot lately so environemnt is not configured properly atm for pytest | 14:48 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 15:44 |
| rm_work | lol pep8 | 16:06 |
| noonedeadpunk | yeah:) | 16:34 |
| noonedeadpunk | now things look green enough | 16:35 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 16:43 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 16:47 |
| noonedeadpunk | no changes there. | 16:47 |
| noonedeadpunk | But, octavia-v2-dsvm-tls-barbican actually failed with https://zuul.opendev.org/t/openstack/build/ab50ec8fc804480a859ac8125bc31c6d/log/controller/logs/screen-o-cw.txt | 16:48 |
| noonedeadpunk | Which seems like resulted by https://review.opendev.org/c/openstack/octavia/+/558962/41/octavia/controller/worker/v2/flows/amphora_flows.py | 16:48 |
| noonedeadpunk | `taskflow.exceptions.MissingDependencies: 'linear_flow.Flow: octavia-create-loadbalancer-flow(len=13)' requires ['amphorae'] but no other entity produces said requirements` | 16:49 |
| opendevreview | Ghanshyam proposed openstack/octavia-tempest-plugin master: Add stable/xena jobs on master gate https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/825208 | 17:37 |
| *** dkehn_ is now known as dkehn | 18:32 | |
| opendevreview | Michael Johnson proposed openstack/python-octaviaclient master: Clarify the client code is not python bindings https://review.opendev.org/c/openstack/python-octaviaclient/+/826768 | 19:06 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add centos-9-stream job https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/816369 | 19:12 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: WIP Add support for Centos 9 Stream https://review.opendev.org/c/openstack/octavia/+/816370 | 19:12 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Restart rsyslog from cloud-init https://review.opendev.org/c/openstack/octavia/+/826769 | 19:12 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!