| rm_work | did we ... no longer need this? https://review.opendev.org/c/openstack/octavia/+/795637 | 03:41 |
|---|---|---|
| rm_work | was this issue fixed elsewhere? | 03:42 |
| rm_work | or is this still a time bomb? | 03:42 |
| opendevreview | Adam Harwell proposed openstack/octavia master: Make duplicate constraint checks more generic https://review.opendev.org/c/openstack/octavia/+/795637 | 03:42 |
| rm_work | rebased | 03:42 |
| rm_work | anyone noticed pylint exploding today? VERY noisy on `consider-using-f-string` but also a few errors out of the blue | 04:09 |
| rm_work | octavia/amphorae/backends/utils/ip_advertisement.py:16:0: E0611: No name 'pack' in module 'struct' (no-name-in-module) | 04:19 |
| rm_work | octavia/amphorae/backends/utils/ip_advertisement.py:17:0: E0611: No name 'unpack' in module 'struct' (no-name-in-module) | 04:19 |
| rm_work | but, it seems like it is still there? | 04:19 |
| rm_work | also it is unhappy about this access: https://github.com/openstack/octavia/blob/f0d66240838ba5b58dd3e71f5a16eb60a0a9c493/octavia/controller/worker/v2/controller_worker.py#L1084 | 04:23 |
| rm_work | I'm tempted to agree -- above where it is set, it's designed such that it may be any False-y value, so False, None? | 04:25 |
| rm_work | which would explode on that access | 04:25 |
| rm_work | though I can't see how it could POSSIBLY be "falsey" at that point | 04:33 |
| opendevreview | Adam Harwell proposed openstack/octavia master: Use vip_subnet_selection_tag to select subnets https://review.opendev.org/c/openstack/octavia/+/788133 | 04:59 |
| opendevreview | Adam Harwell proposed openstack/octavia master: Fix some new pylint errors https://review.opendev.org/c/openstack/octavia/+/809522 | 04:59 |
| rm_work | ^^ will be a gate-fix I think (and the one above it is a rebase) | 04:59 |
| gthiemonge | rm_work: thanks for the fix! | 06:03 |
| rm_work | 👍️ | 06:04 |
| rm_work | man the f-string refactor is gonna be ... tedious | 06:40 |
| opendevreview | Adam Harwell proposed openstack/octavia master: Use vip_subnet_selection_tag to select subnets https://review.opendev.org/c/openstack/octavia/+/788133 | 07:03 |
| rm_work | missed a test case on a change <_< | 07:05 |
| opendevreview | OpenStack Release Bot proposed openstack/octavia stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/octavia/+/809801 | 16:11 |
| opendevreview | OpenStack Release Bot proposed openstack/octavia stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/octavia/+/809802 | 16:11 |
| opendevreview | OpenStack Release Bot proposed openstack/octavia master: Update master for stable/xena https://review.opendev.org/c/openstack/octavia/+/809803 | 16:11 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!