| *** yoctozepto1 is now known as yoctozepto | 07:49 | |
| opendevreview | Merged openstack/octavia-tempest-plugin master: Increase job timeout for noop-api tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/806558 | 10:05 |
|---|---|---|
| opendevreview | Merged openstack/octavia master: Set active-standby job as non-voting https://review.opendev.org/c/openstack/octavia/+/806742 | 10:05 |
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed Sep 1 16:00:21 2021 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | Hi everyone | 16:00 |
| johnsom | O/ | 16:01 |
| gthiemonge | #topic Announcements | 16:02 |
| gthiemonge | Xena-3 milestone | 16:02 |
| gthiemonge | this week is Xena-3 milestone (Feature Freeze, Final release for client libraries) | 16:03 |
| gthiemonge | we did some workarounds for the CI to make it pass for feature patches :/ | 16:03 |
| gthiemonge | active-standby job is now now-voting | 16:03 |
| gthiemonge | the job was unstable (mostly broken) because of a bug in placement | 16:04 |
| gthiemonge | #link https://storyboard.openstack.org/#!/story/2009159 | 16:04 |
| gthiemonge | I also saw this issue in a standalone job, but it only happened once AFAIK | 16:04 |
| gthiemonge | and noop-api jobs have been really slow since SQLAlchemy 1.4 release | 16:05 |
| gthiemonge | we increased the timeout for the job to 3h | 16:05 |
| gthiemonge | we still need to investigate why it takes so much time, and how we can fix it | 16:05 |
| gthiemonge | of course those changes will be reverted ASAP ;-) | 16:05 |
| johnsom | We can hope soon | 16:06 |
| gthiemonge | the priority review etherpad is still there for reviews | 16:06 |
| gthiemonge | #link https://etherpad.opendev.org/p/octavia-priority-reviews | 16:06 |
| gthiemonge | Any other announcements? | 16:07 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:09 |
| gthiemonge | I have worked on those CI issues | 16:09 |
| johnsom | Just reviews from me. | 16:09 |
| gthiemonge | I also fixed a bug in a "revert" function in amphorav2: | 16:10 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/806804 | 16:10 |
| gthiemonge | and also reviews | 16:10 |
| gthiemonge | #topic SQLAlchemy 2 migration | 16:12 |
| gthiemonge | There was an email on the openstack-discuss ML: "[all] SQLAlchemy 2.0 and coming ORM apocalypse" | 16:12 |
| gthiemonge | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-August/024122.html | 16:13 |
| gthiemonge | SQLAlchemy 2.0 will remove code that was deprecated in 1.4 | 16:13 |
| gthiemonge | (I haven't paid attention to the deprecations in 1.4 :/) | 16:13 |
| gthiemonge | There are some huge changes: | 16:13 |
| gthiemonge | #link https://docs.sqlalchemy.org/en/14/changelog/migration_20.html | 16:13 |
| johnsom | But is it faster??? grin | 16:14 |
| gthiemonge | I started working on it and the change that bothers me is the removal of subtransactions from session.begin() | 16:14 |
| gthiemonge | johnsom: lol | 16:14 |
| gthiemonge | it looks like we use many subtransactions in Octavia (they help to have some nested transaction blocks) | 16:14 |
| gthiemonge | there's a guide that explains how to migrate from this pattern: | 16:14 |
| johnsom | Yeah, sadly they are everywhere | 16:14 |
| gthiemonge | #link https://docs.sqlalchemy.org/en/14/orm/session_transaction.html#session-subtransactions | 16:15 |
| gthiemonge | but it changes the logic in Octavia | 16:15 |
| gthiemonge | particularly when creating/validating new resources in the API | 16:15 |
| gthiemonge | (it delays commits, so it changes the way we catch SQLAlchemy exceptions) | 16:15 |
| gthiemonge | so there's going to be a huge task | 16:16 |
| gthiemonge | I had some issues that were not detected by our unit/functional tests | 16:16 |
| gthiemonge | (for instance the DuplicateEntry exception when adding a resource was raised after sending a command to the worker) | 16:16 |
| gthiemonge | I don't have an ETA for SQLAlchemy 2.0 | 16:17 |
| gthiemonge | so: be prepared! | 16:19 |
| gthiemonge | any questions on this topic? | 16:19 |
| gthiemonge | alright | 16:21 |
| gthiemonge | #topic Open Discussion | 16:21 |
| gthiemonge | Any topics? | 16:22 |
| gthiemonge | ok | 16:23 |
| gthiemonge | Thanks everyone! | 16:23 |
| gthiemonge | #endmeeting | 16:23 |
| opendevmeet | Meeting ended Wed Sep 1 16:23:15 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:23 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2021/octavia.2021-09-01-16.00.html | 16:23 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2021/octavia.2021-09-01-16.00.txt | 16:23 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2021/octavia.2021-09-01-16.00.log.html | 16:23 |
| johnsom | Thanks! | 16:23 |
| opendevreview | Merged openstack/octavia master: Add generic network interface management in the amphora https://review.opendev.org/c/openstack/octavia/+/761195 | 19:19 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!