| *** zasherif has quit IRC | 00:04 | |
| *** yamamoto has joined #openstack-lbaas | 00:25 | |
| *** yamamoto has quit IRC | 00:36 | |
| *** yamamoto has joined #openstack-lbaas | 00:44 | |
| *** zasherif has joined #openstack-lbaas | 03:08 | |
| *** zasherif has quit IRC | 03:19 | |
| *** psachin has joined #openstack-lbaas | 03:20 | |
| *** ramishra has joined #openstack-lbaas | 04:21 | |
| *** gcheresh has joined #openstack-lbaas | 05:14 | |
| *** rpittau|afk is now known as rpittau | 06:35 | |
| *** gthiemon1e is now known as gthiemonge | 06:42 | |
| *** ccamposr has joined #openstack-lbaas | 07:07 | |
| *** maciejjozefczyk has joined #openstack-lbaas | 07:08 | |
| *** ccamposr__ has quit IRC | 07:10 | |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia-dashboard stable/train: Add missing fields for HTTPS health monitors https://review.opendev.org/717671 | 07:19 |
|---|---|---|
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia-dashboard stable/stein: Add missing fields for HTTPS health monitors https://review.opendev.org/717672 | 07:20 |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia-dashboard stable/rocky: Add missing fields for HTTPS health monitors https://review.opendev.org/717673 | 07:21 |
| *** born2bake has joined #openstack-lbaas | 07:31 | |
| *** dayou has quit IRC | 07:35 | |
| *** dayou has joined #openstack-lbaas | 07:39 | |
| *** happyhemant has joined #openstack-lbaas | 07:46 | |
| *** dayou has quit IRC | 08:13 | |
| *** yamamoto has quit IRC | 08:17 | |
| *** dayou has joined #openstack-lbaas | 08:20 | |
| *** yamamoto has joined #openstack-lbaas | 08:34 | |
| *** ccamposr__ has joined #openstack-lbaas | 08:39 | |
| *** yamamoto has quit IRC | 08:41 | |
| *** ccamposr has quit IRC | 08:43 | |
| *** yamamoto has joined #openstack-lbaas | 08:48 | |
| *** rcernin has quit IRC | 09:03 | |
| *** yamamoto has quit IRC | 09:20 | |
| *** yamamoto has joined #openstack-lbaas | 09:23 | |
| *** vishalmanchanda has joined #openstack-lbaas | 09:24 | |
| *** ccamposr has joined #openstack-lbaas | 09:26 | |
| *** ccamposr__ has quit IRC | 09:29 | |
| *** ataraday_ has joined #openstack-lbaas | 09:53 | |
| *** rcernin has joined #openstack-lbaas | 10:37 | |
| *** tkajinam has quit IRC | 10:59 | |
| *** yamamoto has quit IRC | 11:00 | |
| *** yamamoto has joined #openstack-lbaas | 11:14 | |
| *** tkajinam has joined #openstack-lbaas | 11:51 | |
| *** yamamoto has quit IRC | 12:04 | |
| *** rcernin has quit IRC | 12:04 | |
| *** rcernin has joined #openstack-lbaas | 12:05 | |
| *** tkajinam has quit IRC | 12:18 | |
| *** yamamoto has joined #openstack-lbaas | 12:38 | |
| *** yamamoto has quit IRC | 12:45 | |
| *** yamamoto has joined #openstack-lbaas | 12:45 | |
| openstackgerrit | Merged openstack/python-octaviaclient master: Update hacking for Python3 https://review.opendev.org/715710 | 12:45 |
| openstackgerrit | Merged openstack/python-octaviaclient master: Cleanup py27 support https://review.opendev.org/717473 | 12:46 |
| *** yamamoto has quit IRC | 12:51 | |
| *** rcernin has quit IRC | 12:52 | |
| *** yamamoto has joined #openstack-lbaas | 13:05 | |
| *** dayou has quit IRC | 13:13 | |
| *** dayou has joined #openstack-lbaas | 13:13 | |
| *** laerlingSAP has quit IRC | 13:25 | |
| *** TrevorV has joined #openstack-lbaas | 13:56 | |
| *** gcheresh has quit IRC | 14:35 | |
| *** psachin has quit IRC | 14:43 | |
| *** gcheresh has joined #openstack-lbaas | 14:51 | |
| nmickus | johnsom rm_work for updating the client do i need to add anything to the new argument besides the name, metavar, and help string? | 14:58 |
| *** armax has joined #openstack-lbaas | 15:18 | |
| *** vishalmanchanda has quit IRC | 15:33 | |
| johnsom | nmickus It will be the same information that the other parameters have. For example, the help string is what goes into the documentation. | 15:38 |
| nmickus | I understand that part I've noticed some have an action, or other parameters i wanted to make sure i don't need them | 15:41 |
| nmickus | And does the metavar need to relate to anything? | 15:42 |
| *** gcheresh has quit IRC | 15:44 | |
| johnsom | So metavar is the internal variable the client will use when submitting the request. I.e. it is the actual variable name that will be used elsewhere for the parameter data | 15:44 |
| *** zasherif has joined #openstack-lbaas | 15:44 | |
| johnsom | So for ciphers, just set the metavar to the name you have for the parameter in the API | 15:48 |
| johnsom | tls_ciphers, etc. | 15:48 |
| nmickus | alright ty | 15:48 |
| johnsom | NP | 15:48 |
| nmickus | the Octavia lib API correct? | 15:49 |
| johnsom | The octavia API | 15:49 |
| nmickus | so what dawson updated | 15:49 |
| johnsom | https://review.opendev.org/#/c/711376/5/api-ref/source/parameters.yaml | 15:49 |
| johnsom | It is tls_ciphers for ciphers | 15:50 |
| johnsom | I think tls_protocols for the other one | 15:50 |
| *** gcheresh has joined #openstack-lbaas | 15:51 | |
| johnsom | Maybe we don't have the protocols patch posted yet. | 15:52 |
| nmickus | Should I split the pools and listeners into 2 patches, since it's set as 2 tasks? | 15:54 |
| johnsom | Yes please. They may merge in a different order, so best to have them separate | 15:54 |
| nmickus | all right | 15:55 |
| *** gcheresh has quit IRC | 16:05 | |
| *** rpittau is now known as rpittau|afk | 16:08 | |
| *** yamamoto has quit IRC | 16:10 | |
| nmickus | johnsom so now pep8 is failing at the very start of the file I updated not where I changed it? | 16:29 |
| johnsom | nmickus What is the error it reports? | 16:29 |
| nmickus | E902 TokenError: EOF in multi-line statement | 16:30 |
| johnsom | Yeah, so pep8 couldn't parse the file. There is likely a missing closing brace or other symbol in your change | 16:31 |
| johnsom | If you do a git diff and pastebin your change I can probably see it | 16:31 |
| nmickus | got it :) | 16:33 |
| johnsom | Cool | 16:33 |
| *** yamamoto has joined #openstack-lbaas | 16:43 | |
| *** yamamoto has quit IRC | 16:48 | |
| nmickus | johnsom the tox suite is passing on my machine is they're any updates that need to be made to the tests or am i good to make a release note and push it up? | 16:53 |
| johnsom | nmickus If tox passes, I would do the release note and push it up. If something is missing a reviewer will catch it | 16:54 |
| *** ccamposr has quit IRC | 17:08 | |
| *** ccamposr has joined #openstack-lbaas | 17:23 | |
| *** ccamposr__ has joined #openstack-lbaas | 17:25 | |
| openstackgerrit | Noah Mickus proposed openstack/python-octaviaclient master: Add the ability to specify the cipher list for a listener https://review.opendev.org/717811 | 17:27 |
| *** ccamposr has quit IRC | 17:28 | |
| *** ccamposr has joined #openstack-lbaas | 17:43 | |
| *** ccamposr has quit IRC | 17:45 | |
| *** ccamposr__ has quit IRC | 17:46 | |
| *** ccamposr has joined #openstack-lbaas | 17:46 | |
| *** ccamposr__ has joined #openstack-lbaas | 17:50 | |
| *** ccamposr has quit IRC | 17:53 | |
| *** ccamposr has joined #openstack-lbaas | 18:04 | |
| *** luketollefson_ has joined #openstack-lbaas | 18:05 | |
| *** ccamposr__ has quit IRC | 18:05 | |
| *** luketollefson has quit IRC | 18:08 | |
| *** luketollefson_ is now known as luketollefson | 18:08 | |
| *** ccamposr has quit IRC | 18:09 | |
| openstackgerrit | Noah Mickus proposed openstack/python-octaviaclient master: Add the ability to specify the cipher list for a pool https://review.opendev.org/717834 | 18:50 |
| openstackgerrit | Noah Mickus proposed openstack/python-octaviaclient master: Add the ability to specify the cipher list for a listener https://review.opendev.org/717811 | 19:00 |
| nmickus | johnsom both the patches for the cli should be up | 19:03 |
| openstackgerrit | Noah Mickus proposed openstack/python-octaviaclient master: Add the ability to specify the cipher list for a pool https://review.opendev.org/717834 | 19:29 |
| *** ataraday_ has quit IRC | 19:32 | |
| openstackgerrit | Noah Mickus proposed openstack/python-octaviaclient master: Add the ability to specify the cipher list for a pool https://review.opendev.org/717834 | 19:36 |
| *** zasherif has quit IRC | 19:36 | |
| cgoncalves | the functional jobs are failing even after the octavia-lib release and bump in upper-constraints.txt. it looks to be related to the TLS ciphers work. is there a patch we should get merged asap? | 20:05 |
| *** zasherif has joined #openstack-lbaas | 20:05 | |
| cgoncalves | apologies if I've missed previous conversations about his | 20:05 |
| cgoncalves | *this | 20:05 |
| johnsom | Probably this one: https://review.opendev.org/711376 | 20:06 |
| *** zasherif has quit IRC | 20:07 | |
| dawzon | I was just about to bring this up. Changing the lib data model causes a bunch of those tests to fail. I've been messing around trying to get them to pass, but when I add the sample data it then causes a bunch of the octavia data model tests to fail, which would require actually adding them to the data model | 20:09 |
| dawzon | And if we're only going to merge ciphers, I don't know why it would make sense to add column that's only ever going to be empty | 20:11 |
| *** zasherif has joined #openstack-lbaas | 20:16 | |
| *** haleyb has joined #openstack-lbaas | 20:18 | |
| *** zasherif has quit IRC | 20:18 | |
| *** zasherif has joined #openstack-lbaas | 20:21 | |
| *** zasherif has quit IRC | 20:21 | |
| *** ccamposr has joined #openstack-lbaas | 21:18 | |
| *** yamamoto has joined #openstack-lbaas | 21:33 | |
| *** yamamoto has quit IRC | 21:37 | |
| dawzon | johnsom Since we can't really change octavia-lib at this point, what would be the best way to handle this? | 21:44 |
| johnsom | dawzon I was just pivoting to look at this situation. I will start looking at this now. | 21:45 |
| johnsom | Ah, ok, so it's versions | 21:55 |
| johnsom | dawzon We don't have a patch for tls_versions do we? | 21:56 |
| dawzon | No. I would say I'd try to throw one together but I'm not sure there would be time at this point | 21:57 |
| johnsom | Yeah, well, we have to get it in now. | 21:58 |
| johnsom | dawzon Do you have patches in-flight on your listeners patch? | 21:58 |
| johnsom | This one: https://review.opendev.org/#/c/711376/ | 21:59 |
| dawzon | in-flight? Sorry not familiar with the lingo | 21:59 |
| johnsom | Ah, sorry, yeah, git-slang | 21:59 |
| johnsom | Are you working on revisions to that patch? | 21:59 |
| johnsom | Or can I take it and make some modifications to get us out of the lib-n-egg problem. | 22:00 |
| dawzon | I have one small change I haven't pushed, and I have to change a few tiny things from comments | 22:00 |
| dawzon | I can push it right now | 22:00 |
| johnsom | Ok, that would be cool. Then I will download that version and stub out the required versions stuff | 22:01 |
| johnsom | Given the timeline we have, I'll just hammer out a workaround. | 22:02 |
| *** born2bake has quit IRC | 22:17 | |
| openstackgerrit | Dawson Coleman proposed openstack/octavia master: Add ability to set TLS cipher list for listeners https://review.opendev.org/711376 | 22:24 |
| *** TrevorV has quit IRC | 22:24 | |
| johnsom | dawzon Can I run with that? | 22:26 |
| dawzon | I think so. The only changes at this point would be tests | 22:27 |
| *** rcernin has joined #openstack-lbaas | 22:30 | |
| *** maciejjozefczyk has quit IRC | 22:33 | |
| *** maciejjozefczyk has joined #openstack-lbaas | 22:36 | |
| johnsom | Ok, let me see what I can come up with | 22:41 |
| *** tkajinam has joined #openstack-lbaas | 22:42 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Add ability to set TLS cipher list for listeners https://review.opendev.org/711376 | 23:58 |
| johnsom | dawzon ^^^ Nothing a little beethoven and data model hacks can't solve. | 23:58 |
| johnsom | dawzon You will need to rebase your pools patch on top and remove some of my hacks. | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!