| *** yamamoto has joined #openstack-lbaas | 01:14 | |
| *** sapd1_x has joined #openstack-lbaas | 01:40 | |
| johnsom | The nightly image build is broken due to a DIB issue. The svc-map element needs pyyaml for it's extra.d 02- script and included it in the package-installs.yaml, however the package-install element doesn't fire until pre-install.d which is after extra.d | 01:53 |
|---|---|---|
| johnsom | Ah, opps, it is 10- not 02- | 01:54 |
| johnsom | But still, same ordering issue | 01:54 |
| *** yamamoto has quit IRC | 02:38 | |
| *** yamamoto has joined #openstack-lbaas | 02:40 | |
| openstackgerrit | Merged openstack/octavia master: Fix padding logic for UDP health daemon https://review.opendev.org/714240 | 03:16 |
| *** psachin has joined #openstack-lbaas | 03:24 | |
| *** hongbin has quit IRC | 04:20 | |
| *** ramishra has joined #openstack-lbaas | 04:28 | |
| *** yamamoto has quit IRC | 04:32 | |
| *** yamamoto has joined #openstack-lbaas | 04:44 | |
| *** vishalmanchanda has joined #openstack-lbaas | 04:58 | |
| *** yamamoto has quit IRC | 05:24 | |
| *** yamamoto has joined #openstack-lbaas | 05:43 | |
| *** yamamoto has quit IRC | 05:45 | |
| *** yamamoto has joined #openstack-lbaas | 05:49 | |
| *** yamamoto has quit IRC | 05:58 | |
| *** yamamoto has joined #openstack-lbaas | 06:27 | |
| *** yamamoto has quit IRC | 06:27 | |
| *** yamamoto has joined #openstack-lbaas | 06:27 | |
| *** yamamoto has quit IRC | 06:28 | |
| *** gcheresh has joined #openstack-lbaas | 07:01 | |
| *** yamamoto has joined #openstack-lbaas | 07:01 | |
| *** lxkong has quit IRC | 07:42 | |
| *** yamamoto has quit IRC | 07:48 | |
| *** yamamoto has joined #openstack-lbaas | 07:53 | |
| *** gcheresh has quit IRC | 07:56 | |
| *** gcheresh has joined #openstack-lbaas | 07:58 | |
| *** yamamoto has quit IRC | 08:03 | |
| *** maciejjozefczyk has joined #openstack-lbaas | 08:04 | |
| *** ccamposr has joined #openstack-lbaas | 08:09 | |
| *** tkajinam has quit IRC | 08:15 | |
| openstackgerrit | Ann Taraday proposed openstack/octavia master: Jobboard based controller https://review.opendev.org/647406 | 08:20 |
| *** ataraday_ has joined #openstack-lbaas | 08:21 | |
| *** gthiemon1e has joined #openstack-lbaas | 08:38 | |
| *** gthiemonge has quit IRC | 08:39 | |
| *** rpittau|afk is now known as rpittau | 08:52 | |
| *** gthiemon1e is now known as gthiemonge | 08:57 | |
| *** numans has joined #openstack-lbaas | 09:22 | |
| *** ramishra has quit IRC | 09:33 | |
| *** ramishra has joined #openstack-lbaas | 09:40 | |
| openstackgerrit | Ann Taraday proposed openstack/octavia master: Jobboard based controller https://review.opendev.org/647406 | 09:45 |
| *** sapd1_x has quit IRC | 11:23 | |
| *** rpittau is now known as rpittau|bbl | 11:47 | |
| *** gthiemonge has quit IRC | 12:08 | |
| *** gthiemon1e has joined #openstack-lbaas | 12:08 | |
| *** gcheresh has quit IRC | 12:15 | |
| *** gcheresh has joined #openstack-lbaas | 12:32 | |
| *** psachin has quit IRC | 12:42 | |
| *** sapd1_x has joined #openstack-lbaas | 12:56 | |
| *** rpittau|bbl is now known as rpittau | 13:08 | |
| *** sapd1_x has quit IRC | 13:35 | |
| *** TrevorV has joined #openstack-lbaas | 13:38 | |
| *** gthiemon1e has quit IRC | 13:49 | |
| *** gthiemonge has joined #openstack-lbaas | 14:00 | |
| *** gcheresh has quit IRC | 14:02 | |
| *** gcheresh has joined #openstack-lbaas | 14:08 | |
| *** hongbin has joined #openstack-lbaas | 14:19 | |
| *** Trevor_V has joined #openstack-lbaas | 14:23 | |
| *** TrevorV has quit IRC | 14:27 | |
| *** ccamposr__ has joined #openstack-lbaas | 14:31 | |
| *** ccamposr has quit IRC | 14:34 | |
| *** TrevorV has joined #openstack-lbaas | 14:34 | |
| *** Trevor_V has quit IRC | 14:37 | |
| *** gcheresh has quit IRC | 14:49 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Refactor the failover flows https://review.opendev.org/705317 | 15:31 |
| *** gcheresh has joined #openstack-lbaas | 15:37 | |
| *** KeithMnemonic has joined #openstack-lbaas | 15:42 | |
| *** ccamposr__ has quit IRC | 15:59 | |
| *** ccamposr__ has joined #openstack-lbaas | 16:00 | |
| rm_work | daily plug for https://review.opendev.org/#/q/status:open+project:openstack/octavia+branch:master+topic:az-tweaks | 16:19 |
| rm_work | though looks like johnsom is not going to approve it any time soon, and carlos already +2'd, not sure who else would actually look so maybe I should just give up, lol | 16:19 |
| rm_work | also https://review.opendev.org/#/c/589180/ is good to go | 16:19 |
| rm_work | I guess I owe a triage pass on the priority list | 16:20 |
| johnsom | I didn't say I *wasn't* going to approve, but priorities... | 16:20 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Exclude acpid on Red Hat family DIB builds https://review.opendev.org/714487 | 16:27 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Drop queens support, and make rocky non-voting https://review.opendev.org/714488 | 16:27 |
| rm_work | lol | 16:40 |
| rm_work | okay :D | 16:40 |
| *** sapd1_x has joined #openstack-lbaas | 16:58 | |
| *** sapd1_x has quit IRC | 17:03 | |
| *** rpittau is now known as rpittau|afk | 17:08 | |
| *** ccamposr has joined #openstack-lbaas | 17:18 | |
| *** ccamposr__ has quit IRC | 17:20 | |
| *** gregwork has joined #openstack-lbaas | 17:24 | |
| *** TrevorV has quit IRC | 17:45 | |
| dawzon | Is there a way to locally generate unit test reports like you see on zuul? | 18:11 |
| *** gcheresh has quit IRC | 18:16 | |
| *** hongbin has quit IRC | 18:22 | |
| johnsom | dawzon Yes, but it's a few steps | 18:25 |
| *** maciejjozefczyk has quit IRC | 18:28 | |
| johnsom | stestr last --subunit > /tmp/subunit | 18:28 |
| johnsom | subunit2html subunit_stream test_results.html | 18:28 |
| *** maciejjozefczyk has joined #openstack-lbaas | 18:29 | |
| johnsom | I think you need the venv active for the py36 test run for the commands to work | 18:29 |
| johnsom | You may need to install os-testr too for the 2html command to work | 18:30 |
| rm_work | wtf I am so confused | 18:34 |
| * johnsom Not dazed? | 18:34 | |
| rm_work | amp agent appears to be sending UDP health packets... but tcpdump is showing me nothing on the amp... and the HM service certainly isn't getting them | 18:34 |
| rm_work | is udp / udpv6 the same? the traffic i am looking for would be ipv6 | 18:35 |
| johnsom | rmwork try "ip6 proto 17" for the filter | 18:38 |
| johnsom | rm_work ^^^ | 18:38 |
| rm_work | kk | 18:39 |
| rm_work | hmmm | 18:40 |
| rm_work | not working | 18:40 |
| rm_work | fff weird | 18:40 |
| johnsom | Then it is probably getting dropped in the kernel | 18:40 |
| johnsom | Like a missing or bad route | 18:40 |
| rm_work | hmmmm | 18:41 |
| rm_work | how would i test that | 18:43 |
| johnsom | traceroute6 | 18:43 |
| johnsom | I would start there | 18:44 |
| rm_work | hmm | 18:44 |
| johnsom | It may not work depending on your network config | 18:44 |
| johnsom | I usually manually inspect the routing table(s) | 18:44 |
| rm_work | don't know how to interpret this output T_T | 18:44 |
| johnsom | "*" mean nothing responded | 18:45 |
| rm_work | yeah but in this case it's literally one line and it looks like | 18:45 |
| rm_work | 1 5c3c1668.amphorae.service.stg.ows.oath.cloud (2001:4998:58:a880::b) 3105.222 ms !H 3105.182 ms !H 3105.168 ms !H | 18:45 |
| johnsom | Ah, the !H is a code, let me see | 18:45 |
| johnsom | !H == host unreachable | 18:46 |
| openstack | johnsom: Error: "H" is not a valid command. | 18:46 |
| johnsom | !H == host unreachable | 18:46 |
| rm_work | hmmm | 18:46 |
| rm_work | k | 18:46 |
| rm_work | maybe some ACLs got messed up | 18:46 |
| johnsom | So, maybe a problem or maybe just firewalled off | 18:46 |
| rm_work | i'll look into it, thanks | 18:46 |
| johnsom | My guess is it is a missing / bad route | 18:47 |
| johnsom | Ok, lunch time | 18:47 |
| rm_work | yeah | 18:58 |
| rm_work | will look, i have a working and a non-working one side-by-side | 18:59 |
| *** maciejjozefczyk has quit IRC | 19:12 | |
| *** ataraday_ has quit IRC | 19:13 | |
| *** laerling2 has quit IRC | 19:18 | |
| *** hongbin has joined #openstack-lbaas | 19:18 | |
| *** laerlingSAP has joined #openstack-lbaas | 19:20 | |
| *** laerlingSAP has quit IRC | 19:23 | |
| *** maciejjozefczyk has joined #openstack-lbaas | 19:23 | |
| *** laerlingSAP has joined #openstack-lbaas | 19:26 | |
| *** gcheresh has joined #openstack-lbaas | 19:34 | |
| dawzon | I can't quite figure out this test: https://github.com/openstack/octavia/blob/2cf00d8c85692c571e23b221da7885dc0f179d14/octavia/tests/unit/common/jinja/haproxy/combined_listeners/test_jinja_cfg.py#L1117 It uses the protocol TERMINATED_HTTPS but it doesn't specify some of the other TLS options for its sample listener. Should ciphers be specified on this config? | 19:35 |
| rm_work | some tests assume defaults | 19:37 |
| rm_work | you probably want to make a new test specifically for your stuff and then specify explicitly the things you're testing | 19:38 |
| *** vishalmanchanda has quit IRC | 19:46 | |
| dawzon | I'm probably going about this the wrong way... I was under the impression that explicitly defining a cipherstring in the haproxy config would the the default going forward so existing tests should be updated. Should I be treating it as more of a special case instead? (i.e. leaving the existing tests as is and making new ones for rendering configurations with cipher strings) | 19:50 |
| *** gcheresh has quit IRC | 19:57 | |
| *** maciejjozefczyk has quit IRC | 20:07 | |
| johnsom | I thought we were going to have a "None" option for existing deployed LBs that would be the current configuration. Then, for newly created listeners it would pick up the new default from the configuration file. | 20:07 |
| *** maciejjozefczyk has joined #openstack-lbaas | 20:07 | |
| *** maciejjozefczyk has quit IRC | 20:14 | |
| rm_work | it's possible you'll have to edit existing tests, yes | 20:20 |
| rm_work | i was just saying, that if not specified, it's just assuming defaults -- so it's pretty normal for not every test to specify every option explicitly | 20:20 |
| rm_work | johnsom: ugh, so you use: socket.inet_ntop(interface_af, socket.inet_pton(interface_af, attr[1])) | 20:21 |
| rm_work | johnsom: can we do this in ... something else? like ... maybe ipaddress ? | 20:21 |
| rm_work | on OSX, inet_pton doesn't get along with address_family=10 | 20:21 |
| rm_work | (ipv6 related?) | 20:21 |
| rm_work | `rtnl_api.get_addr(address=ip_address)` returns family=10 for ipv6 addresses | 20:24 |
| rm_work | so, `socket.inet_pton(interface_af, attr[1])` or rendered as `socket.inet_pton(10, 'IFA_ADDRESS')` explodes on OSX | 20:25 |
| johnsom | What??? It is a simple byte order method... | 20:25 |
| rm_work | err sorry | 20:25 |
| rm_work | not IFA_ADDRESS | 20:25 |
| rm_work | it's the IPv6 address | 20:25 |
| johnsom | Maybe best to get rid of macosx? | 20:25 |
| rm_work | lol | 20:25 |
| rm_work | what is this doing exactly, just verifying an ipv6 address? | 20:26 |
| rm_work | we have code doing that elsewhere that is compatible | 20:26 |
| haleyb | netaddr.valid_ipv6(address) :) | 20:28 |
| rm_work | right :D | 20:28 |
| rm_work | but like | 20:28 |
| rm_work | i don't understand why it does something so different here | 20:28 |
| openstackgerrit | Merged openstack/octavia master: Network Delta calculations should respect AZs https://review.opendev.org/705165 | 20:28 |
| openstackgerrit | Merged openstack/octavia master: Allow AZ to override valid_vip_networks config https://review.opendev.org/699521 | 20:28 |
| rm_work | just above that it normalizes the address directly | 20:29 |
| rm_work | with basically the same code | 20:29 |
| rm_work | but anyway, ALL of this address normalization looks way complicated compared to what we do elsewhere with the ipaddress lib | 20:29 |
| rm_work | the "normalized" format you seem to want is `ipaddress.ip_address(ip).compressed` | 20:31 |
| rm_work | i feel like 90% of this code could be clipped and replaced with that line | 20:32 |
| rm_work | but i also feel like i have no idea what this code is all actually trying to accomplish | 20:33 |
| rm_work | so i'm probably missing something | 20:33 |
| * haleyb doesn't even have the context, was just commenting blindly | 20:36 | |
| *** gcheresh has joined #openstack-lbaas | 20:38 | |
| rm_work | yeah ok this would work fine, except now i have to disentangle the crazy mocking that was already being done with ip_address :D | 20:42 |
| *** gcheresh has quit IRC | 20:46 | |
| johnsom | rm_work Wait, I didn't add that inet_pton, that was there aready.... | 20:47 |
| rm_work | i think you just added a test using it | 20:47 |
| rm_work | maybe | 20:47 |
| johnsom | I did add a lot of missing test coverage for this stuff | 20:47 |
| rm_work | anyway, i got it | 20:48 |
| johnsom | I see it's in another file too, maybe I added that one. Checking | 20:48 |
| johnsom | Oh, I moved that. Yeah, probably added missing test coverage. Let me see | 20:48 |
| johnsom | Yeah, so compressed is not the same as what I am doing in network_utils. | 20:50 |
| johnsom | inet_ntop and pton are bit order conversions. | 20:50 |
| johnsom | network byte order to whatever the python host byte order is | 20:51 |
| johnsom | https://tools.ietf.org/html/draft-newman-network-byte-order-01 | 20:51 |
| rm_work | hmm | 20:53 |
| johnsom | exploded might work however. let me see when they added that | 20:53 |
| * johnsom wonders though, doesn't that module still use the builtin ntop/pton methods???? Hopes it doesn't ignore byte order | 20:54 | |
| rm_work | err | 20:54 |
| rm_work | https://review.opendev.org/#/c/705317/19/octavia/amphorae/backends/utils/network_utils.py@62 | 20:54 |
| rm_work | so THAT is caring about byte order? | 20:55 |
| rm_work | also: it seems to be using compressed | 20:55 |
| rm_work | looking at what it's generating otherwise | 20:55 |
| rm_work | normalized_addr = '2001:db8::55' | 20:56 |
| rm_work | (which is the one we're looking for, generated above via socket.inet_ntop / socket.inet_pton | 20:56 |
| rm_work | ) | 20:56 |
| johnsom | Is it going to compressed? hmmm, it's been so long since that method was created. But it makes sense I may have used compressed to save a few bytes (however mysql is dumb and still allocates the same no matter what. | 20:57 |
| rm_work | let me check the output of some commands on a linux system | 20:57 |
| *** gcheresh has joined #openstack-lbaas | 20:58 | |
| rm_work | yeah | 20:59 |
| rm_work | >>> socket.inet_ntop(socket.AF_INET6, socket.inet_pton(socket.AF_INET6, '2001:db8::55')) | 20:59 |
| rm_work | '2001:db8::55' | 20:59 |
| rm_work | >>> socket.inet_ntop(socket.AF_INET6, socket.inet_pton(socket.AF_INET6, '2001:0db8:0000:0000:0000:0000:0000:0055')) | 21:00 |
| rm_work | '2001:db8::55' | 21:00 |
| rm_work | and if we replaced both usages of socket.inet_* ... then it'd be guaranteed to match? | 21:01 |
| rm_work | so byte order be damned? | 21:01 |
| johnsom | Ah, so there it is just matching and not storing, so yeah, using compresses should be ok. | 21:01 |
| johnsom | I have a vaque nagging that there was a problem with that library, but now we are native it probably is fixed. | 21:02 |
| johnsom | The native ipaddress must be doing the byte order correct, or world + dog would be broken in python land | 21:03 |
| *** gcheresh has quit IRC | 21:04 | |
| rm_work | LOL no reason to mock that at all | 21:07 |
| rm_work | ok then | 21:07 |
| rm_work | that was weird :D removing mocks == win | 21:07 |
| rm_work | removing low level socket code == win | 21:08 |
| johnsom | Yeah, that patch is becoming even more cleanup! | 21:09 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Refactor the failover flows https://review.opendev.org/705317 | 21:42 |
| dawzon | johnsom Here's what I was trying to say: Does it make sense to insert the ciphers parameter into the configs for all the existing unit tests? Or is it better to let them be | 21:49 |
| rm_work | i mean, it depends on what you envision the haproxy configs looking like | 21:59 |
| rm_work | don't write the code around what you want to do with tests | 21:59 |
| rm_work | ... i say as I just literally did that <_< | 21:59 |
| rm_work | but anyway, if you plan to have default args generate haproxy configs with default cipher lists, then update the tests to reflect that | 22:00 |
| dawzon | Ah, ok | 22:01 |
| johnsom | dawzon I think the right answer is to have tests that cover the different cases. So, some will likely stay the same, some may need to be added. | 22:01 |
| dawzon | Alright, I'm sure it'll be easier to discuss when I actually upload the patch :) | 22:08 |
| rm_work | usually yeah :D | 22:45 |
| rm_work | I always try to just upload something first since it's easier to point at code in a CR than to try to hand-wave at people until they understand (though I often try anyway) | 22:46 |
| *** tkajinam has joined #openstack-lbaas | 22:57 | |
| *** lxkong has joined #openstack-lbaas | 23:03 | |
| sorrison | rm_work: Got openstacksdk support for AZs here https://review.opendev.org/#/c/714345/. (once I learn how to spell availability consistently). Almost got the horizon stuff done too | 23:08 |
| *** gthiemonge has quit IRC | 23:39 | |
| *** gthiemonge has joined #openstack-lbaas | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!