*** vishalmanchanda has joined #openstack-lbaas | 00:11 | |
*** yamamoto has joined #openstack-lbaas | 00:23 | |
*** yamamoto has quit IRC | 00:28 | |
johnsom | I swear I should change my password to "assert_called_once_with", sigh. I have used that sooooo many times in the last few weeks. | 00:34 |
---|---|---|
*** dayou has quit IRC | 00:36 | |
*** dayou has joined #openstack-lbaas | 00:37 | |
*** spatel has joined #openstack-lbaas | 00:43 | |
*** spatel has quit IRC | 00:48 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: WIP - Refactor the failover flows https://review.opendev.org/705317 | 01:03 |
johnsom | Sadly more to go... But, down to just the network drivers. The end is in sight. | 01:04 |
*** spatel has joined #openstack-lbaas | 01:14 | |
*** sapd1 has joined #openstack-lbaas | 01:21 | |
*** yamamoto has joined #openstack-lbaas | 01:55 | |
*** rcernin has quit IRC | 02:02 | |
*** threestrands has joined #openstack-lbaas | 02:06 | |
*** yamamoto has quit IRC | 02:09 | |
*** yamamoto has joined #openstack-lbaas | 02:09 | |
*** hongbin has joined #openstack-lbaas | 02:50 | |
*** rcernin has joined #openstack-lbaas | 02:52 | |
openstackgerrit | Luke Tollefson proposed openstack/octavia master: WIP Add parameters for configuration of TLS protocols https://review.opendev.org/711154 | 03:14 |
johnsom | luketollefson: Woot! | 03:16 |
*** psachin has joined #openstack-lbaas | 03:33 | |
openstackgerrit | Steven Glasford proposed openstack/octavia-lib master: WIP Add the four different tls and their ciphersuite https://review.opendev.org/711157 | 03:57 |
*** spatel has quit IRC | 04:05 | |
*** spatel has joined #openstack-lbaas | 04:05 | |
*** spatel has quit IRC | 04:39 | |
*** hongbin has quit IRC | 04:54 | |
*** haleyb is now known as haleyb|away | 05:05 | |
*** yamamoto has quit IRC | 05:56 | |
*** yamamoto has joined #openstack-lbaas | 06:11 | |
*** gcheresh_ has joined #openstack-lbaas | 06:13 | |
*** vishalmanchanda has quit IRC | 06:31 | |
*** threestrands has quit IRC | 06:34 | |
*** threestrands has joined #openstack-lbaas | 06:35 | |
*** threestrands has quit IRC | 06:36 | |
*** threestrands has joined #openstack-lbaas | 06:36 | |
*** threestrands has quit IRC | 06:37 | |
*** threestrands has joined #openstack-lbaas | 06:38 | |
*** threestrands has quit IRC | 06:39 | |
*** gcheresh_ has quit IRC | 06:51 | |
*** vishalmanchanda has joined #openstack-lbaas | 06:55 | |
*** gcheresh_ has joined #openstack-lbaas | 06:57 | |
*** happyhemant has joined #openstack-lbaas | 07:17 | |
*** yamamoto has quit IRC | 07:25 | |
*** ccamposr has joined #openstack-lbaas | 07:55 | |
*** yamamoto has joined #openstack-lbaas | 08:01 | |
*** gcheresh_ has quit IRC | 08:04 | |
*** yamamoto has quit IRC | 08:06 | |
*** tesseract has joined #openstack-lbaas | 08:09 | |
*** maciejjozefczyk has joined #openstack-lbaas | 08:14 | |
*** rpittau|afk is now known as rpittau | 08:16 | |
openstackgerrit | Ann Taraday proposed openstack/octavia master: [Amphorav2] Fix noop driver case https://review.opendev.org/709696 | 08:22 |
*** yamamoto has joined #openstack-lbaas | 08:32 | |
*** gcheresh_ has joined #openstack-lbaas | 08:32 | |
*** Erdosip has quit IRC | 08:42 | |
*** ccamposr has quit IRC | 08:53 | |
*** ccamposr has joined #openstack-lbaas | 08:53 | |
*** ramishra has quit IRC | 08:57 | |
*** ramishra has joined #openstack-lbaas | 09:03 | |
*** tkajinam has quit IRC | 09:30 | |
*** yamamoto has quit IRC | 09:44 | |
*** yamamoto has joined #openstack-lbaas | 10:22 | |
*** yamamoto has quit IRC | 10:27 | |
*** rcernin has quit IRC | 11:08 | |
*** sapd1 has quit IRC | 11:21 | |
*** rpittau is now known as rpittau|bbl | 11:32 | |
*** psachin has quit IRC | 11:33 | |
*** psachin has joined #openstack-lbaas | 11:37 | |
*** psachin has quit IRC | 11:49 | |
*** openstackstatus has joined #openstack-lbaas | 11:50 | |
*** ChanServ sets mode: +v openstackstatus | 11:50 | |
*** yamamoto has joined #openstack-lbaas | 12:27 | |
*** yamamoto has quit IRC | 12:28 | |
*** vishalmanchanda has quit IRC | 12:31 | |
*** xgerman has quit IRC | 12:54 | |
*** xgerman has joined #openstack-lbaas | 12:55 | |
*** yamamoto has joined #openstack-lbaas | 13:01 | |
*** yamamoto has quit IRC | 13:06 | |
*** jamesdenton has quit IRC | 13:07 | |
*** nicolasbock has joined #openstack-lbaas | 13:11 | |
*** NobodyCam has quit IRC | 13:24 | |
*** NobodyCam has joined #openstack-lbaas | 13:25 | |
*** vishalmanchanda has joined #openstack-lbaas | 13:36 | |
*** rpittau|bbl is now known as rpittau | 13:44 | |
*** yamamoto has joined #openstack-lbaas | 14:06 | |
*** sapd1 has joined #openstack-lbaas | 14:14 | |
*** psachin has joined #openstack-lbaas | 14:16 | |
*** Wellie has joined #openstack-lbaas | 14:20 | |
Wellie | Hello | 14:20 |
Wellie | is it possible to equip the LB with a WAF? | 14:20 |
*** spatel has joined #openstack-lbaas | 14:24 | |
*** spatel has quit IRC | 14:29 | |
*** nicolasbock has quit IRC | 14:51 | |
*** ccamposr has quit IRC | 14:54 | |
*** ccamposr has joined #openstack-lbaas | 14:54 | |
johnsom | Wellie Hi, for the Amphora driver it is on the road map, but not available at this time. For provider drivers, it can be implemented via the Octavia flavors, but is less than ideal. | 14:57 |
johnsom | Wellie Right now we just offer ACLs. | 14:57 |
kevinz | Hi all! Is it possible for an admin Loadbalancer to connect admin subnet and an other-project subnet? | 14:59 |
kevinz | to make two network connected, "other-project" instance can use the service / http exposed from admin subnet workloads | 15:00 |
*** psachin has quit IRC | 15:00 | |
johnsom | kevinz With Octavia you can select any subnet that is visible to the tenant for the VIP or the members servers. | 15:04 |
*** nicolasbock has joined #openstack-lbaas | 15:04 | |
*** nicolasbock has quit IRC | 15:10 | |
*** gcheresh_ has quit IRC | 15:31 | |
*** psachin has joined #openstack-lbaas | 15:41 | |
*** TrevorV has joined #openstack-lbaas | 15:46 | |
*** yamamoto has quit IRC | 15:46 | |
*** yamamoto has joined #openstack-lbaas | 15:47 | |
*** yamamoto has quit IRC | 15:50 | |
*** sapd1 has quit IRC | 15:52 | |
openstackgerrit | Maciej Józefczyk proposed openstack/octavia-tempest-plugin master: Run reuse connection test only if protocol is HTTP or TCP https://review.opendev.org/711255 | 15:53 |
*** psachin has quit IRC | 15:56 | |
*** ataraday_ has joined #openstack-lbaas | 16:00 | |
johnsom | #startmeeting Octavia | 16:01 |
openstack | Meeting started Wed Mar 4 16:01:33 2020 UTC and is due to finish in 60 minutes. The chair is johnsom. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:01 |
*** openstack changes topic to " (Meeting topic: Octavia)" | 16:01 | |
openstack | The meeting name has been set to 'octavia' | 16:01 |
johnsom | #chair rm_work | 16:01 |
openstack | Current chairs: johnsom rm_work | 16:01 |
johnsom | Hi everyone. I thought rm_work was planning to be there today.... | 16:02 |
ataraday_ | hi | 16:02 |
johnsom | #topic Announcements | 16:02 |
*** openstack changes topic to "Announcements (Meeting topic: Octavia)" | 16:02 | |
*** Trevor_V has joined #openstack-lbaas | 16:02 | |
johnsom | I have two reminders on our up coming deadlines | 16:02 |
johnsom | Octavia-lib final Ussuri release is week of 3/30 | 16:02 |
cgoncalves | hi | 16:02 |
rm_work | o/ sorry | 16:03 |
rm_work | meeting ran over | 16:03 |
johnsom | Remember that octavia-lib must release before feature freeze. So we need to make sure we land our octavia-lib patches sooner rather than later. | 16:03 |
johnsom | That is just weeks away | 16:03 |
johnsom | For our other repos, the feature freeze MS3 is coming up as well | 16:04 |
johnsom | Other projects feature freeze is week of 4/6 | 16:04 |
johnsom | rm_work I will hand it over to you. I just wanted to remind everyone of the upcoming deadlines | 16:04 |
*** psachin has joined #openstack-lbaas | 16:05 | |
*** TrevorV has quit IRC | 16:06 | |
rm_work | ah kk | 16:06 |
rm_work | ok then... any other announcements? | 16:08 |
rm_work | moving on... | 16:08 |
rm_work | #topic Brief progress reports / bugs needing review | 16:08 |
*** openstack changes topic to "Brief progress reports / bugs needing review (Meeting topic: Octavia)" | 16:08 | |
ataraday_ | Remind of jobboard #link https://review.opendev.org/#/c/647406/ | 16:09 |
rm_work | #link https://review.opendev.org/#/q/status:open+project:openstack/octavia+branch:master+topic:az-tweaks | 16:09 |
rm_work | PLEASE FOR THE LOVE OF ALL THAT IS HOLY | 16:09 |
johnsom | I am making good progress on the failover patch. Most of the tests are now implemented. I'm just down to the network driver changes now. | 16:10 |
rm_work | these are not SO complex, and we need them to land for AZ support to not be completely broken | 16:10 |
ataraday_ | Small fix for noop related to amphorav2 #link https://review.opendev.org/#/c/709696/ | 16:10 |
cgoncalves | I reviewed the first on the chain already... :P | 16:11 |
ataraday_ | And just pointing that test change with making amphorav2 default https://review.opendev.org/#/c/697213/ passing all tests :) | 16:11 |
johnsom | Sadly, this has become a large patch due to the test requirements and the gaps we had in testing for the previous implementation(s) | 16:11 |
rm_work | \o/ | 16:11 |
cgoncalves | rm_work, scenario test coverage? | 16:11 |
johnsom | Also of note, I'm not sure if any of the NDSU students are here for the meeting, but they have started to post some patches. | 16:12 |
johnsom | Please help them out with reviews as you can. | 16:12 |
rm_work | cgoncalves: yeah, the scenario tests actually haven't merged yet for AZs -- they are not fully accurate... unfortunately I am not sure how to make them work properly -- they may need at least two-node testing to function, too... | 16:12 |
rm_work | I am hoping that is more reliable now and I can get those fixed up with some help maybe from someone who understands how nova/neutron ops work :D | 16:12 |
rm_work | ok, does anyone else have any specific topics today? | 16:15 |
rm_work | #topic Open Discussion | 16:15 |
*** openstack changes topic to "Open Discussion (Meeting topic: Octavia)" | 16:15 | |
johnsom | You missed an agenda item | 16:16 |
rm_work | ah, johnsom you had something on the provider driver docs right? | 16:16 |
rm_work | ah was that in the agenda? | 16:16 |
johnsom | #topic Updating the available drivers page | 16:16 |
*** openstack changes topic to "Updating the available drivers page (Meeting topic: Octavia)" | 16:16 | |
johnsom | Yes, remember agendas? | 16:16 |
johnsom | lol | 16:16 |
rm_work | no :D | 16:16 |
rm_work | literally forgot that was a thing | 16:16 |
rm_work | (I just load up the last meeting log, and copy/paste the topics in order) | 16:17 |
johnsom | Recently we have had a number of comments/requests/confusion about the available provider drivers for Octavia | 16:17 |
johnsom | I setup a page: | 16:17 |
johnsom | #link https://docs.openstack.org/octavia/latest/admin/providers.html | 16:18 |
johnsom | To allow folks to "advertise" the availability of drivers, but sadly no one has updated it. | 16:18 |
johnsom | So, given the amount of confusion going on, I have proposed a patch updating it with the drivers that are public and I am aware of: | 16:18 |
johnsom | #link https://review.opendev.org/#/c/711109/ | 16:19 |
johnsom | The rendered page is here: | 16:19 |
johnsom | #link https://9f709e7d1e4d7533935c-7291d6e818a7c847826cc66aee2194e8.ssl.cf5.rackcdn.com/711109/1/check/openstack-tox-docs/b3b7974/docs/admin/providers/index.html | 16:19 |
johnsom | I wanted to raise this at the meeting to see if anyone had any concerns/questions/updates for this page. | 16:19 |
johnsom | Many of these have been available for a few releases now... | 16:20 |
rm_work | I think this is a good route forward, personally... Gives a framework and examples, and then should let provider vendors themselves propose updates as they wish very easily with minimal friction | 16:20 |
cgoncalves | I'm receptive to this idea. thank you, johnsom | 16:21 |
cgoncalves | the rendered page looks good | 16:21 |
johnsom | Ok, thanks for the feedback. The proposal is up for review. | 16:22 |
johnsom | #topic Open Discussion | 16:23 |
*** openstack changes topic to "Open Discussion (Meeting topic: Octavia)" | 16:23 | |
johnsom | Ugh, chrome just exploded and I now have two of all of my windows..... | 16:24 |
rm_work | (I'm a little salty about A10 being alphabetically first above the only actually in-tree driver, but it is what it is :D) | 16:24 |
johnsom | Yeah, well, I wanted to be fair, so alpha sorted | 16:24 |
rm_work | yeah i get it | 16:24 |
johnsom | Other topics today? | 16:27 |
*** yamamoto has joined #openstack-lbaas | 16:27 | |
rm_work | nothing on my end | 16:27 |
johnsom | I'm really pushing hard to have the tests done this week. I will post here when I think we are ready to start reviews. There will probably be some additional clean up after I call it ready for review, but getting close to being done-ish. | 16:28 |
johnsom | Oh, also, I am out of office on Friday and will likely not have connectivity, so I will not be around until Monday. | 16:30 |
rm_work | alright, if that's it, thanks for coming ya'll, catch you next week :) | 16:31 |
rm_work | ataraday_: will try to look at those patches you linked today | 16:32 |
rm_work | #endmeeting | 16:32 |
*** openstack changes topic to "Discussions for OpenStack Octavia | Priority bug review list: https://etherpad.openstack.org/p/octavia-priority-reviews" | 16:32 | |
openstack | Meeting ended Wed Mar 4 16:32:35 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:32 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/octavia/2020/octavia.2020-03-04-16.01.html | 16:32 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/octavia/2020/octavia.2020-03-04-16.01.txt | 16:32 |
openstack | Log: http://eavesdrop.openstack.org/meetings/octavia/2020/octavia.2020-03-04-16.01.log.html | 16:32 |
openstackgerrit | Hamza Zafar proposed openstack/python-octaviaclient master: add --all argument to stats show command https://review.opendev.org/711270 | 16:32 |
*** yamamoto has quit IRC | 16:33 | |
ataraday_ | rm_work, thank you! | 16:34 |
openstackgerrit | Hamza Zafar proposed openstack/python-octaviaclient master: add --all argument to stats show command https://review.opendev.org/711270 | 16:37 |
*** ataraday_ has quit IRC | 16:39 | |
openstackgerrit | Merged openstack/octavia master: Update the available provider drivers list. https://review.opendev.org/711109 | 16:47 |
openstackgerrit | Adam Harwell proposed openstack/octavia stable/train: Fix batch member update error on empty change list https://review.opendev.org/711275 | 16:49 |
*** maciejjozefczyk_ has joined #openstack-lbaas | 16:51 | |
*** maciejjozefczyk has quit IRC | 16:52 | |
*** psachin has quit IRC | 16:53 | |
*** maciejjozefczyk_ has quit IRC | 16:56 | |
*** gcheresh_ has joined #openstack-lbaas | 16:58 | |
*** gcheresh_ has quit IRC | 17:04 | |
*** openstackgerrit has quit IRC | 17:20 | |
*** Trevor_V has quit IRC | 17:21 | |
*** TrevorV has joined #openstack-lbaas | 17:22 | |
*** rpittau is now known as rpittau|afk | 17:44 | |
dawzon | Is it possible to use multiple lines for an option in octavia.conf? Wondering if I can make OpenSSL ciphers strings a bit less ugly | 17:46 |
johnsom | dawzon We could, with the multistr. That might limit the ability for folks to cut/paste the string from references like OWASP however. | 17:54 |
johnsom | rm_work What do you think? | 17:54 |
*** ccamposr has quit IRC | 17:54 | |
rm_work | hmm, need to see an example of what that looks like | 17:54 |
*** ccamposr has joined #openstack-lbaas | 17:55 | |
rm_work | But i will say that if the alternative is stuff like "certline1\nline2\nline3\n" we really don't have a choice, that's unacceptable in practice T_T | 17:55 |
JayF | For something like a certificate, why would it be specified inline in a conf vs the config option being a path to it | 17:56 |
JayF | if it's not a separate file, it's going to be a heck of a lot tougher to rotate it | 17:57 |
rm_work | ah sorry yeah i am in the wrong mental mode | 17:57 |
rm_work | they're talking about just the cipher lists | 17:57 |
JayF | Ah, that makes more sense, but I still think external files can make sense for some things like that :) | 17:57 |
rm_work | literally right now staring at one of those \n certs in code >_< | 17:57 |
rm_work | and wanting to stab something | 17:57 |
JayF | turn the monitor off and step away (with the button, not with the dagger) | 17:58 |
JayF | lol | 17:58 |
johnsom | We are talking about the default "openssl style" ciphers list setting. | 18:03 |
johnsom | It will likely look like this: | 18:03 |
johnsom | TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-HA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256 | 18:04 |
johnsom | I.e. the standard format you see everywhere | 18:04 |
JayF | nice | 18:06 |
rm_work | yeah it's just super long... but actually *doesn't* contain any newlines, right? | 18:08 |
rm_work | so not sure how multiline helps us | 18:08 |
*** openstackgerrit has joined #openstack-lbaas | 18:09 | |
openstackgerrit | Adam Harwell proposed openstack/python-octaviaclient master: Add --long to amphora-list to show more columns https://review.opendev.org/711298 | 18:09 |
rm_work | ^^ long time annoyance, trivially simple fix apparently, now i'm kinda feeling dumb because my scripted workaround actually took longer to do than fixing the client code <_< | 18:10 |
johnsom | Right it would just be to make the config look pretty by breaking it into multiple config settings. | 18:10 |
johnsom | Personally I would rather have it one string so I can cut/paste from other sources for that string | 18:11 |
rm_work | yeah, how would it be broken up even? | 18:15 |
johnsom | oslo config has a multistropt that lets you have the same key on multiple lines. It then gives you a list back I think. | 18:16 |
rm_work | oh so like, split on colon | 18:19 |
rm_work | and literally one key a dozen+ times | 18:19 |
johnsom | Yeah, I guess. It just seems messy | 18:19 |
rm_work | agreed | 18:19 |
johnsom | dawzon So, two cores vote for leaving it a single string. | 18:19 |
johnsom | I would propose it that way in the patch. Maybe others will comment in the patch, but I think you are likely good with a string. | 18:20 |
*** nicolasbock has joined #openstack-lbaas | 18:24 | |
openstackgerrit | Michael Johnson proposed openstack/octavia stable/train: Add a periodic image build job https://review.opendev.org/706394 | 18:27 |
*** nicolasbock has quit IRC | 18:29 | |
*** gcheresh_ has joined #openstack-lbaas | 18:29 | |
*** nicolasbock has joined #openstack-lbaas | 18:30 | |
johnsom | rm_work https://storyboard.openstack.org/#!/story/2007371 | 18:30 |
johnsom | I think that was some of your handy work | 18:31 |
johnsom | Oh, well, with some of mine over the top.... hmmm | 18:32 |
johnsom | Oh, they are trying to load individual secrets instead of a container..... | 18:34 |
johnsom | I will respond | 18:36 |
johnsom | Oh, no, they are using a container | 18:36 |
johnsom | hmm | 18:36 |
johnsom | rm_work So, cert_secret = connection.secrets.get(secret_ref=cert_ref) will not error if they passed an href to a container? | 18:38 |
rm_work | uhhh it should | 18:38 |
rm_work | 404 | 18:38 |
johnsom | Yeah, that is what I thought | 18:39 |
rm_work | unless we're eating the 404 somewhere | 18:39 |
johnsom | Nope: https://review.opendev.org/#/c/683254/3/octavia/certificates/manager/barbican.py | 18:39 |
johnsom | Does it just return None now and not raise? | 18:40 |
rm_work | uhhh wtf | 18:40 |
johnsom | Also WTF: https://storyboard.openstack.org/#!/story/2007372 | 18:41 |
rm_work | lol yes | 18:41 |
rm_work | some misunderstanding it seems | 18:41 |
johnsom | I don't think we ever had those stats | 18:42 |
rm_work | we did not in octavia at least | 18:42 |
* rm_work shrugs | 18:42 | |
johnsom | Maybe v1? before my time | 18:42 |
johnsom | I will look at the stats one, if you track down the bbq one | 18:42 |
rm_work | pfft that's not fair :D | 18:43 |
rm_work | the stats one is just "-2, no, we don't have these stats" | 18:43 |
johnsom | Aren't you core in bbq? | 18:43 |
rm_work | lol no | 18:43 |
rm_work | also not core in Barbican | 18:43 |
rm_work | though they keep threatening to do it :D | 18:43 |
rm_work | anyway, i can look a bit at the barbican issue | 18:46 |
rm_work | but not exactly at this precise moment | 18:46 |
*** gcheresh_ has quit IRC | 18:50 | |
johnsom | Ok | 18:52 |
johnsom | So that stats thing must have been downstream changes that were never pushed upstream. neutron-lbaas had less stats than Octavia does. | 18:53 |
*** tesseract has quit IRC | 18:55 | |
*** ccamposr has quit IRC | 18:56 | |
rm_work | lol | 18:57 |
rm_work | i am amazed you even bothered to look, because it doesn't matter whether n-lbaas had it or not -- we're not that project | 18:57 |
johnsom | Well, we made a commitment to be backward compatible, so ... Honoring that | 18:57 |
rm_work | uhh i mean | 18:58 |
rm_work | those stats *don't exist* AFAIU | 18:58 |
rm_work | not sure what we could do | 18:58 |
rm_work | ah i guess some of them do | 18:58 |
rm_work | I guess we COULD add a lot of these | 18:59 |
johnsom | None the less, I couldn't find that in the neutron-lbaas code or the python-neutronclient. the neutron client just returns whatever it finds in the results, so it must be a custom neutron-lbaas they were using. | 18:59 |
johnsom | Yeah, it would be a RFE for more stats. Plus, likely want/need the metrics re-work | 18:59 |
rm_work | ugh why won't storyboard link me from story to gerrit, if the link exists | 18:59 |
johnsom | Well, for the stats patch, the gerrit doesn't have the task # in it, so it didn't link | 19:00 |
rm_work | ah did they MANUALLY set it to "Review"? lol | 19:00 |
johnsom | yep | 19:00 |
*** gcheresh_ has joined #openstack-lbaas | 19:01 | |
rm_work | so I mean, `connection.secrets.get(secret_ref=cert_ref)` SHOULD raise a NotFound | 19:02 |
rm_work | not just return None <_< | 19:02 |
rm_work | that'd be the real bug | 19:02 |
johnsom | It *seems* like it did..... | 19:02 |
rm_work | and that's barbican client side | 19:02 |
rm_work | yeah it SHOULD | 19:02 |
rm_work | I swear it did | 19:02 |
johnsom | Me too | 19:03 |
rm_work | commented on the --all | 19:05 |
rm_work | maybe it's for stats that return from some 3rd-party provider? | 19:05 |
rm_work | do any of them re-use our DB? | 19:06 |
rm_work | or our stats call? | 19:06 |
openstackgerrit | Hamza Zafar proposed openstack/python-octaviaclient master: add --all argument to stats show command https://review.opendev.org/711270 | 19:06 |
johnsom | Well, stats always came direct from the neutron/octavia DB | 19:06 |
johnsom | That allowed aggregate stats queries | 19:06 |
rm_work | so, the code itself doesn't seem bad? and without any additional columns ... it just ... works the same as what we have now I believe | 19:07 |
rm_work | it might actually be fine to do it this way... | 19:07 |
rm_work | though i don't think it will *do* anything different without deeper changes in our API/DB | 19:08 |
rm_work | i'm just -1 for being confused, not -2 for now | 19:08 |
johnsom | Yeah, I commented that this will require an RFE on the story | 19:09 |
johnsom | I think someone asked for "more stats" at the last summit but we never caught what stats they wanted. Maybe this is the list? | 19:10 |
cgoncalves | I'm looking at test_amphora.py and wondering why do we create two LBs: one at resource setup, another for the only test method. what am I missing? | 19:20 |
cgoncalves | https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/tests/scenario/v2/test_amphora.py | 19:20 |
johnsom | list tests? | 19:21 |
cgoncalves | pardon? | 19:22 |
johnsom | Well, you need three to test the API "list" command with sort options right? | 19:22 |
cgoncalves | you can still do LB and amphora list and show on environments with 1 LB only | 19:22 |
cgoncalves | sorry, I don't follow. I need three LBs? | 19:23 |
johnsom | Well, I can't speak for the amp tests, but for load balancer list for example: https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/tests/api/v2/test_load_balancer.py#L246 | 19:24 |
*** dmellado has quit IRC | 19:24 | |
johnsom | If you don't have at least three, you can't test the ascending and descending sort orders. | 19:25 |
*** dmellado has joined #openstack-lbaas | 19:25 | |
cgoncalves | not something we test in test_amphora.py today anyway | 19:25 |
johnsom | https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/tests/api/v2/test_load_balancer.py#L363 | 19:26 |
cgoncalves | test_load_balancer.py != test_amphora.py | 19:26 |
johnsom | Yeah, like I said, I don't know on the amphora tests, I don't think I authored those | 19:26 |
johnsom | The other thought would be RBAC tests, but I don't think that applies there in scenario either. | 19:28 |
johnsom | Yeah, maybe the filtering test there at the bottom, but two should do for that I think | 19:30 |
johnsom | Ah, yeah, ok, so it is only creating two. I expect so that if you query by LB you only get the amps for that LB and not bleed over from the other LBs. That would be my guess | 19:32 |
johnsom | Is it me, or are those two test at the bottom the same? | 19:33 |
cgoncalves | they are not | 19:34 |
cgoncalves | the first one queries for the LB created at resource setup, the second one queries for the LB created by the test method itself | 19:34 |
cgoncalves | so, same test but on different resources | 19:35 |
johnsom | Ah, self vs. not | 19:35 |
cgoncalves | right | 19:35 |
johnsom | multi-tasking | 19:35 |
johnsom | So, I guess that is why. | 19:35 |
openstackgerrit | Carlos Goncalves proposed openstack/octavia-tempest-plugin master: WIP: fix test_amphora.py https://review.opendev.org/711316 | 19:37 |
cgoncalves | pushed what I started working on this morning | 19:37 |
cgoncalves | it simplifies the test, creating only one load balancer | 19:37 |
johnsom | So two questions there. | 19:38 |
johnsom | It will now fail if it's on a spares cloud. | 19:38 |
johnsom | You dropped the filtering test..... | 19:38 |
cgoncalves | how so? | 19:38 |
cgoncalves | I did not | 19:38 |
cgoncalves | I moved it instead ;) | 19:38 |
cgoncalves | L107 | 19:39 |
johnsom | So it's not testing a list of all amphora? | 19:39 |
johnsom | just a filtered list? | 19:40 |
cgoncalves | ah, oops (spare pool) | 19:40 |
cgoncalves | I should keep the assert greater equal | 19:41 |
cgoncalves | a filtered list still tests the list API no? | 19:41 |
johnsom | Well, only for filtered results | 19:46 |
johnsom | devils advocate here | 19:46 |
openstackgerrit | Carlos Goncalves proposed openstack/octavia-tempest-plugin master: WIP: fix test_amphora.py https://review.opendev.org/711316 | 19:51 |
cgoncalves | works now with spare pools | 19:51 |
*** gcheresh_ has quit IRC | 19:52 | |
openstackgerrit | Carlos Goncalves proposed openstack/octavia-tempest-plugin master: WIP: fix test_amphora.py https://review.opendev.org/711316 | 19:58 |
*** spatel has joined #openstack-lbaas | 20:26 | |
*** spatel has quit IRC | 20:31 | |
*** abaindur has joined #openstack-lbaas | 20:32 | |
dawzon | What is the difference between setting a pool's protocol to HTTPS and setting tls_enabled to True? I notice that I can set tls_enabled while still having the protocol be HTTP | 20:45 |
*** gcheresh_ has joined #openstack-lbaas | 21:24 | |
*** gcheresh_ has quit IRC | 21:30 | |
*** KeithMnemonic has joined #openstack-lbaas | 21:37 | |
*** yamamoto has joined #openstack-lbaas | 21:43 | |
*** yamamoto has quit IRC | 21:49 | |
johnsom | Yeah, this is an unfortunate thing we inherited. HTTPS is pass through, so basically just TCP | 21:58 |
johnsom | No encryption, etc. | 21:58 |
*** nicolasbock has quit IRC | 22:35 | |
*** rcernin has joined #openstack-lbaas | 22:39 | |
*** TrevorV has quit IRC | 22:55 | |
*** tkajinam has joined #openstack-lbaas | 22:59 | |
*** threestrands has joined #openstack-lbaas | 23:28 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!