| johnsom | Yeah: oslo_config.cfg.ConfigFilesNotFoundError: Failed to find some config files: /etc/foobar | 00:01 |
|---|---|---|
| johnsom | https://www.irccloud.com/pastebin/xJT1o5CT/ | 00:01 |
| johnsom | Added to octavia/api/app.py | 00:02 |
| johnsom | and --pyargv "--config-file /etc/foobar" to the systemd service definition | 00:02 |
| *** pvradu has quit IRC | 00:18 | |
| rm_work | johnsom: wait so you had to make changes for it to work? or no | 01:07 |
| rm_work | because i did exactly that and it didn't seem to make a difference | 01:07 |
| johnsom | Yes, I had to change octavia/api/app.py | 01:07 |
| rm_work | ah k | 01:07 |
| rm_work | so i guess maybe we should do that :D | 01:07 |
| rm_work | wan to ... git review? :D | 01:08 |
| johnsom | Are you asking if I want to post a patch? | 01:08 |
| rm_work | yes :D if you already made the change | 01:11 |
| johnsom | Sure, just a sec | 01:12 |
| rm_work | or was it on some random VM somewhere | 01:12 |
| johnsom | Taking longer to write up the commit message than the patch | 01:12 |
| rm_work | rofl | 01:12 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Allow the Octavia wsgi to accept argv parameters https://review.opendev.org/701485 | 01:13 |
| johnsom | Yeah, I ran that on my devstack local vm. | 01:14 |
| johnsom | That change and --pyargv "--config-file /etc/foobar" on the uwsgi command line (or ini if you want) caused oslo config to throw a "not found" exception | 01:15 |
| rm_work | nice | 01:15 |
| *** pvradu has joined #openstack-lbaas | 02:16 | |
| *** pvradu has quit IRC | 02:47 | |
| *** psachin has joined #openstack-lbaas | 03:33 | |
| *** pvradu has joined #openstack-lbaas | 04:44 | |
| *** pvradu has quit IRC | 05:17 | |
| *** gcheresh has joined #openstack-lbaas | 06:31 | |
| *** gcheresh has quit IRC | 06:46 | |
| *** pvradu has joined #openstack-lbaas | 07:00 | |
| *** pcaruana has joined #openstack-lbaas | 07:38 | |
| *** gcheresh has joined #openstack-lbaas | 07:57 | |
| *** maciejjozefczyk has joined #openstack-lbaas | 08:02 | |
| *** pvradu has quit IRC | 08:02 | |
| *** pvradu has joined #openstack-lbaas | 08:03 | |
| *** tesseract has joined #openstack-lbaas | 08:06 | |
| *** tkajinam has quit IRC | 08:29 | |
| *** pvradu has quit IRC | 08:41 | |
| *** AlexStaf has joined #openstack-lbaas | 08:54 | |
| *** rpittau|afk is now known as rpittau | 09:25 | |
| *** AlexStaf has quit IRC | 10:11 | |
| *** ivve has joined #openstack-lbaas | 10:31 | |
| *** sapd1_x has joined #openstack-lbaas | 11:02 | |
| *** ramishra has quit IRC | 11:24 | |
| *** ramishra has joined #openstack-lbaas | 11:24 | |
| *** sapd1_x has quit IRC | 11:47 | |
| *** servagem has quit IRC | 12:54 | |
| *** goldyfruit_ has quit IRC | 13:08 | |
| *** sapd1 has joined #openstack-lbaas | 13:24 | |
| *** gcheresh has quit IRC | 13:46 | |
| *** gcheresh has joined #openstack-lbaas | 14:13 | |
| *** AlexStaf has joined #openstack-lbaas | 14:21 | |
| *** TrevorV has joined #openstack-lbaas | 14:24 | |
| *** gcheresh has quit IRC | 14:50 | |
| *** rcernin has quit IRC | 15:01 | |
| *** gcheresh has joined #openstack-lbaas | 15:01 | |
| *** AlexStaf has quit IRC | 15:18 | |
| *** gcheresh has quit IRC | 15:39 | |
| *** gcheresh has joined #openstack-lbaas | 15:52 | |
| rm_work | Ah | 16:01 |
| rm_work | Is it time? | 16:01 |
| johnsom | yes | 16:01 |
| rm_work | #startmeeting Octavia | 16:01 |
| openstack | Meeting started Wed Jan 8 16:01:59 2020 UTC and is due to finish in 60 minutes. The chair is rm_work. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:02 |
| *** openstack changes topic to " (Meeting topic: Octavia)" | 16:02 | |
| openstack | The meeting name has been set to 'octavia' | 16:02 |
| haleyb | o/ | 16:02 |
| johnsom | o/ | 16:02 |
| rm_work | Welcome back folks | 16:02 |
| johnsom | I did put a quick agenda together | 16:02 |
| johnsom | #link https://wiki.openstack.org/wiki/Octavia/Weekly_Meeting_Agenda#Meeting_2020-01-08 | 16:02 |
| cgoncalves | hi | 16:03 |
| gthiemonge | hi | 16:03 |
| rm_work | Ah, you want to drive? | 16:03 |
| rm_work | I'm on mobile | 16:03 |
| johnsom | Sure | 16:03 |
| johnsom | #topic Announcements | 16:03 |
| johnsom | I just have two things here | 16:04 |
| johnsom | Happy New Year! | 16:04 |
| johnsom | and an FYI: | 16:04 |
| johnsom | Python-octaviaclient 2.0.0 release proposed - First release to no longer support python 2.x | 16:04 |
| johnsom | #link https://review.opendev.org/701449 | 16:04 |
| johnsom | I bumped the client to 2.x.x. to reflect that it no longer supports python 2.x | 16:05 |
| johnsom | Any other announcements today? | 16:05 |
| johnsom | #topic Brief progress reports / bugs needing review | 16:06 |
| johnsom | Ok, moving on. | 16:06 |
| johnsom | I have been on holiday for a few weeks, so not a lot to report. | 16:06 |
| rm_work | Same kinda | 16:06 |
| cgoncalves | idem | 16:07 |
| johnsom | I am again focused on fixing the issues with the failover flow. I have standalone failover in a pretty good place now, just need to wrap that up, then I will enhance it for active/standby. Still a lot of work to do here around act/stdby, updating for the v2 flows, and test updates. | 16:08 |
| johnsom | That and internal work will probably be my focus for the next week. | 16:09 |
| johnsom | I did allocate some review time yesterday as well, trying to catch up on what happened over my time off | 16:10 |
| johnsom | Any other updates this week? | 16:11 |
| haleyb | I've been trying to continue the py2 deprecation work, and doing a little deprecation cleanup | 16:11 |
| johnsom | Yes, thanks! | 16:11 |
| haleyb | also noticed there should be some follow-on once the jobboard code merges to get some of the constants into octavia-lib perhaps | 16:12 |
| cgoncalves | I'll be spending time this week with reviews and internal work | 16:12 |
| johnsom | Yeah, I have three open patches for the constants, though they are very out of date now.... | 16:12 |
| haleyb | johnsom: ack, i'll try and find them before opening new ones | 16:13 |
| johnsom | haleyb The chain starts here: | 16:13 |
| johnsom | #link https://review.opendev.org/#/c/617015/ | 16:13 |
| johnsom | Those kind of got caught up in the Octavia velocity and got out of date quickly | 16:14 |
| haleyb | 1 year, 1 month ago, yikes! | 16:14 |
| johnsom | Sadly I have older open patches... lol | 16:14 |
| johnsom | We may want to wait on those until the jobboard -> dict work merges as they will definitely conflict. | 16:15 |
| haleyb | johnsom: yeah, there's a lot of updates in those patches, should definitely go first | 16:16 |
| johnsom | Any other updates, or should we move on? | 16:17 |
| johnsom | #topic Open Discussion | 16:18 |
| johnsom | Any other topics today? | 16:18 |
| haleyb | i have one... | 16:18 |
| haleyb | http://grafana.openstack.org/d/p6DsYOBWz/octavia-failure-rate?orgId=1 | 16:18 |
| haleyb | the grafana dashboard merged last month actually, so we can look back a while in failure history | 16:19 |
| haleyb | gate is at the top, check the bottom | 16:19 |
| johnsom | lol, doesn't look like it saw a lot of runs over the break. | 16:20 |
| haleyb | it's split into failures on the left, number of jobs on the right | 16:20 |
| haleyb | or over the weekend(s) | 16:20 |
| cgoncalves | thanks for working on the dashboard, haleyb! | 16:20 |
| johnsom | Yeah, thanks for updating those | 16:20 |
| cgoncalves | do you have the link to the dashboard patch handy? | 16:20 |
| haleyb | and just an fyi that there can be failures in the check queue that are simply "bad" patches, but at least there's some data there | 16:21 |
| haleyb | https://review.opendev.org/698994 | 16:21 |
| johnsom | Right | 16:21 |
| cgoncalves | thanks | 16:21 |
| johnsom | #link https://review.opendev.org/698994 | 16:21 |
| cgoncalves | which jobs do we want to see reported in the dashboard? | 16:21 |
| johnsom | Are there graphs for the periodic jobs as well? | 16:22 |
| haleyb | at least there's info now for when you want to move something to voting | 16:22 |
| johnsom | I think the old dashboard had that | 16:22 |
| haleyb | i don't remember finding much info on periodic jobs in graphite | 16:22 |
| haleyb | are there still any post-zuulv3 migration? | 16:23 |
| johnsom | It was on line 28 in the old dashboard config file in the patch you just posted | 16:23 |
| johnsom | Oh yes | 16:23 |
| johnsom | We have narrowed the image builds: | 16:23 |
| johnsom | https://github.com/openstack/octavia/blob/master/zuul.d/projects.yaml#L70 | 16:24 |
| haleyb | i'm having either ffox or gerrit load issues so can't see the review | 16:24 |
| johnsom | There are also a bunch of bit-rot jobs and oslo cross-project jobs | 16:24 |
| haleyb | if i can find the info in graphite i'll add a periodic job panel | 16:25 |
| cgoncalves | octavia has a lot of jobs. would it be of interest to still add missing jobs to the dashboard? like barbican, active-standby, spare pool, amphora v2, etc. | 16:25 |
| johnsom | Ok, thanks. I was trying to get a zuul health page that had the list, but they have changed the UI again, so it's taking me a bit to find | 16:26 |
| haleyb | if you haven't gone there, https://graphite01.opendev.org/ has a lot | 16:26 |
| haleyb | cgoncalves: yes, i'd consider that dashboard a work in progress as we add/remove jobs | 16:27 |
| haleyb | or just have ones i missed | 16:27 |
| cgoncalves | haleyb, ok. simply trying to understand if too many jobs is a good/desired or bad/undesired thing | 16:27 |
| johnsom | Here are some: | 16:27 |
| johnsom | #link https://zuul.openstack.org/builds?project=openstack%2Foctavia&pipeline=periodic# | 16:27 |
| johnsom | I don't see the unit test runs on the stable branches there though. | 16:28 |
| johnsom | I wonder if those got dropped/moved in the parent zuul configs and we don't have those any longer. | 16:29 |
| johnsom | We have been backporting a lot, so at least we have had coverage on them | 16:29 |
| * haleyb shrugs | 16:30 | |
| *** openstackgerrit has quit IRC | 16:30 | |
| johnsom | On another topic, I would like to ask that we all review the Protocol validation patch: | 16:31 |
| johnsom | #link https://review.opendev.org/#/c/594040 | 16:31 |
| johnsom | It's #2 on the priority list and we have been getting more questions about it recently. | 16:31 |
| johnsom | This has also sat for way too long IMO. | 16:31 |
| johnsom | I think it also needs an update and I'm not sure the original author is still working on it, so if someone wants to pick that up..... Please consider it | 16:32 |
| cgoncalves | agreed. will review it this week | 16:32 |
| cgoncalves | I can help with that, I think | 16:32 |
| johnsom | Cool, thank you! | 16:33 |
| cgoncalves | I have a question related to 3rd party providers | 16:34 |
| johnsom | I will also carve some review time today | 16:34 |
| cgoncalves | is octavia open to have 3rd party CI jobs reporting in Gerrit? if yes, voting or non-voting? | 16:34 |
| johnsom | There is a process for third party jobs. Let me find a link: | 16:35 |
| cgoncalves | IMO 3rd party CI jobs should always be non-voting | 16:35 |
| *** ivve has quit IRC | 16:35 | |
| johnsom | #link https://docs.openstack.org/infra/system-config/third_party.html | 16:35 |
| johnsom | I have run third party CI for octavia in the past. | 16:35 |
| johnsom | This process works very well | 16:36 |
| *** ccamposr has quit IRC | 16:36 | |
| cgoncalves | thanks | 16:36 |
| cgoncalves | so, skimming that page it looks like they should always be non-voting. good. | 16:36 |
| *** ccamposr has joined #openstack-lbaas | 16:37 | |
| johnsom | As for voting, yes, since the third party driver code is out of the main project tree, and typically requires equipment/code/licenses that upstream does not have access to, they should be limited to non-voting. | 16:37 |
| johnsom | I.e. There isn't much we can do to fix the third-party code when it breaks. | 16:37 |
| cgoncalves | what about Zuul jobs by 3rd party providers available in Opendev Gerrit, how should they be set up? | 16:38 |
| cgoncalves | because in that case I think they wouldn't be external CI, or whatever they are called | 16:38 |
| cgoncalves | instead they would have to be added to octavia check queue | 16:39 |
| johnsom | Yeah, that is a new situation for sure. | 16:39 |
| johnsom | My vote would be to add them at the bottom of the list (clearly labeled thrid-party somehow) and leave them non-voting. | 16:39 |
| johnsom | There is value to having them such that we can make sure we don't break them if they are following our guidelines for providers. | 16:40 |
| cgoncalves | sounds good | 16:41 |
| johnsom | Those are my opinions, what do others think? | 16:41 |
| johnsom | Ok | 16:44 |
| haleyb | +1, all neutron reviews list third-party jobs in a sepearte section | 16:44 |
| haleyb | at least the cloudbase one is separate | 16:45 |
| cgoncalves | thanks for the input! | 16:47 |
| johnsom | Other topics for today? | 16:49 |
| johnsom | Ok, thank you folks! Chat with you next week. | 16:52 |
| johnsom | #endmeeting | 16:52 |
| johnsom | hmmm, rm_work may need to end the meeting | 16:52 |
| johnsom | I bet all of my topics didn't log either | 16:53 |
| rm_work | Really... Eugh | 16:53 |
| rm_work | #endmeeting | 16:53 |
| *** openstack changes topic to "Discussions for OpenStack Octavia | Priority bug review list: https://etherpad.openstack.org/p/octavia-priority-reviews" | 16:53 | |
| openstack | Meeting ended Wed Jan 8 16:53:53 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:53 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/octavia/2020/octavia.2020-01-08-16.01.html | 16:53 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/octavia/2020/octavia.2020-01-08-16.01.txt | 16:53 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/octavia/2020/octavia.2020-01-08-16.01.log.html | 16:53 |
| johnsom | Yep, no topics in the notes... | 16:54 |
| rm_work | T_T | 16:54 |
| johnsom | I think there is a chair command, I will find it for future reference | 16:54 |
| johnsom | Yeah, it's <pound>chair | 16:55 |
| johnsom | I will fix the wiki up for the new year now as well. | 16:57 |
| *** openstackgerrit has joined #openstack-lbaas | 16:59 | |
| openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Stop supporting CentOS 7 controllers and images https://review.opendev.org/698449 | 16:59 |
| *** psachin has quit IRC | 17:12 | |
| johnsom | FYI, talking in infra about getting the log archives fixed. Both the templated tox jobs and octavia tempest jobs are archiving broken files at the moment | 17:22 |
| *** gcheresh has quit IRC | 17:26 | |
| rm_work | :( | 17:40 |
| rm_work | Oh is cgoncalves back? :P | 17:40 |
| *** gcheresh has joined #openstack-lbaas | 17:42 | |
| *** gcheresh has quit IRC | 17:47 | |
| johnsom | He was at the meeting | 17:47 |
| *** rpittau is now known as rpittau|afk | 17:51 | |
| *** ivve has joined #openstack-lbaas | 17:56 | |
| rm_work | i ... | 18:02 |
| rm_work | will be honest, i fell asleep almost immediately | 18:02 |
| rm_work | and woke up when you pinged me at the end T_T | 18:03 |
| johnsom | I guessed | 18:03 |
| rm_work | had an imprint on my face from the edge of my laptop where i faceplanted >_>> | 18:03 |
| johnsom | I'm looking at how to fix the functional tests with that wsgi change | 18:03 |
| rm_work | oh, do they ... need fixing? | 18:04 |
| johnsom | Yeah, since we run real code in the functional tests, my change picks up the tox argv stuff | 18:04 |
| rm_work | hmm | 18:05 |
| johnsom | Looks like an easy fix. Just set argv=() when we launch the pecan test framework that loads the app | 18:08 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Allow the Octavia wsgi to accept argv parameters https://review.opendev.org/701485 | 18:10 |
| *** maciejjozefczyk has quit IRC | 18:11 | |
| johnsom | That should do it | 18:11 |
| johnsom | I need to get involved in automotive linux.... Their meeting this year is in Hawaii | 18:14 |
| *** tesseract has quit IRC | 18:15 | |
| rm_work | lol | 18:17 |
| rm_work | poke harlowja :D | 18:17 |
| rm_work | he went to plus.ai | 18:17 |
| rm_work | (the truck with the butter) | 18:17 |
| johnsom | lol | 18:17 |
| johnsom | There is a sizable group of people working on the trucking stuff in PDX as well. | 18:18 |
| *** ccamposr has quit IRC | 18:19 | |
| *** ccamposr has joined #openstack-lbaas | 18:19 | |
| cgoncalves | rm_work, howdy. need me? | 18:24 |
| rm_work | nope :D just noticed you're back | 18:24 |
| *** pcaruana has quit IRC | 18:27 | |
| *** quantomworks has joined #openstack-lbaas | 18:49 | |
| *** maciejjozefczyk has joined #openstack-lbaas | 19:07 | |
| johnsom | rm_work Yep, that fixed the wsgi functional tests. | 19:15 |
| johnsom | That was odd, IRC dropped a message. | 19:17 |
| johnsom | I only see functional-py37 as a tips job, not normal. When did that change? | 19:17 |
| *** maciejjozefczyk has quit IRC | 19:20 | |
| rm_work | uhhh | 19:27 |
| rm_work | is it just "functional" now? | 19:27 |
| rm_work | and no py-x | 19:28 |
| *** gcheresh has joined #openstack-lbaas | 19:40 | |
| *** ccamposr has quit IRC | 19:50 | |
| *** ccamposr has joined #openstack-lbaas | 19:51 | |
| *** gcheresh has quit IRC | 20:06 | |
| *** openstackgerrit has quit IRC | 20:31 | |
| johnsom | Nope, just gone | 20:42 |
| *** openstackgerrit has joined #openstack-lbaas | 21:22 | |
| openstackgerrit | Brian Haley proposed openstack/octavia master: Complete dropping py27 support goal https://review.opendev.org/701621 | 21:22 |
| *** armax has joined #openstack-lbaas | 21:32 | |
| *** ccamposr has quit IRC | 21:41 | |
| *** quantomworks has quit IRC | 22:23 | |
| *** armax has quit IRC | 22:33 | |
| *** tkajinam has joined #openstack-lbaas | 22:56 | |
| *** tkajinam has quit IRC | 22:58 | |
| *** tkajinam has joined #openstack-lbaas | 23:00 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Add listener and pool protocol validation https://review.opendev.org/594040 | 23:03 |
| johnsom | I updated the grid on that and rebased it. (it had been a while...) | 23:06 |
| johnsom | I now need to review the code and make sure it matches the grid | 23:06 |
| *** rcernin has joined #openstack-lbaas | 23:13 | |
| *** armax has joined #openstack-lbaas | 23:19 | |
| *** TrevorV has quit IRC | 23:24 | |
| *** TrevorV has joined #openstack-lbaas | 23:25 | |
| *** TrevorV has quit IRC | 23:26 | |
| rm_work | johnsom: oh what was an example patch where you expected to see more than the py37 tips? | 23:35 |
| johnsom | rm_work https://review.opendev.org/#/c/701485/ | 23:38 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Add listener and pool protocol validation https://review.opendev.org/594040 | 23:38 |
| rm_work | ok and what other tips would you expect? | 23:38 |
| johnsom | No other tips, but would have expected a "normal" functional-py37 | 23:39 |
| rm_work | oh | 23:39 |
| rm_work | hmm | 23:39 |
| rm_work | well technically should be in -cover | 23:39 |
| rm_work | so really that'd be redundant and a waste of a job :D | 23:40 |
| johnsom | cover is py36 | 23:40 |
| rm_work | but i am also curious where it went | 23:40 |
| rm_work | orly | 23:40 |
| johnsom | I am all for not duplicating, but I think we are just not running functional-py37 right now. | 23:41 |
| rm_work | ummm so i wonder if we are just relying on an upstream thing | 23:41 |
| rm_work | and it changed | 23:41 |
| rm_work | because yeah... looking at one that merged recently too | 23:41 |
| rm_work | https://review.opendev.org/#/c/700012/ | 23:41 |
| rm_work | it ran.... | 23:41 |
| johnsom | No, our functionals are in our local project config | 23:41 |
| rm_work | no functionals in check | 23:41 |
| rm_work | and ... openstack-tox-functional-py36 in gate?!?! | 23:41 |
| rm_work | https://github.com/openstack/octavia/commit/bc94789dc9e8418a05d92d22f66f90922ffd1ada#diff-091daa0045b13be2d624f6b89fcbe635 | 23:46 |
| rm_work | so was `openstack-tox-functional` actually py37? | 23:46 |
| rm_work | or is that py2 as i think was assumed | 23:46 |
| johnsom | That should have been 27 | 23:46 |
| rm_work | k | 23:46 |
| rm_work | then ... uhh | 23:46 |
| rm_work | we just never added py37?> | 23:46 |
| * rm_work shrugs | 23:46 | |
| johnsom | Maybe... | 23:46 |
| johnsom | FYI, I updated that protocol validation patch to align to what I think it should be. (Also rebased and made the grid look nicer) | 23:48 |
| johnsom | Others please weigh in if you think that is right | 23:48 |
| johnsom | In the future somewhere along here, we need to change how we handle some of those. Like "TERMINATED_HTTPS" should be also available as a "enable_tls" boolean since we can TLS offload TCP, etc. Same with proxy protocol, it should move to an enable as we can wrap backend protocols in a more flexible way. | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!