Friday, 2019-09-13

johnsomI will hammer out the other repos tomorrow.00:03
*** henriqueof1 has joined #openstack-lbaas00:45
*** henriqueof has quit IRC00:45
*** tkajinam has quit IRC01:54
*** tkajinam has joined #openstack-lbaas02:11
*** hongbin has joined #openstack-lbaas02:32
*** tkajinam has quit IRC02:36
*** tkajinam has joined #openstack-lbaas02:56
*** sapd1 has joined #openstack-lbaas03:00
*** ramishra has joined #openstack-lbaas03:16
*** hongbin has quit IRC03:34
*** pcaruana has joined #openstack-lbaas05:02
*** gcheresh_ has joined #openstack-lbaas05:03
*** sapd1_x has joined #openstack-lbaas05:05
*** gcheresh_ has quit IRC05:23
*** tkajinam has quit IRC05:54
*** tkajinam has joined #openstack-lbaas06:03
*** rpittau|afk is now known as rpittau06:08
*** tkajinam_ has joined #openstack-lbaas06:19
*** sapd1_x has quit IRC06:20
*** tkajinam has quit IRC06:22
*** henriqueof has joined #openstack-lbaas06:27
*** henriqueof1 has quit IRC06:28
*** sapd1_x has joined #openstack-lbaas06:46
*** maciejjozefczyk has joined #openstack-lbaas06:52
*** trident has quit IRC06:55
lxkongjohnsom, rm_work, do you happen to know how to print out the actual db queries in octavia?06:56
rm_workI ... Have done it before, kinda06:58
rm_workBut I do not remember how06:58
*** sapd1_x has quit IRC06:59
cgoncalvesrm_work, can you approve https://review.opendev.org/#/c/659626 ?07:07
*** trident has joined #openstack-lbaas07:07
cgoncalvesrm_work, also https://review.opendev.org/#/c/659627/ pretty please07:09
rm_workMaybe, depends on how the review goes :D07:11
rm_workGive me a minute07:11
*** henriqueof has quit IRC07:12
*** henriqueof has joined #openstack-lbaas07:12
*** tesseract has joined #openstack-lbaas07:15
lxkongrm_work: never mind, i found that, `[database]connection_debug`07:18
lxkongand i saw the ugly get loadbalancers query07:18
rm_workcool07:20
rm_workyes they're all horrifying07:20
rm_workSQLAlchemy makes some really painful looking queries that are not intended for human eyes07:21
rm_workBUT at least they're ... ok maybe not always efficient but... err... they're ... something07:21
lxkongbut we have to look at it cause we met with a db performance issue07:21
*** ramishra has quit IRC07:26
*** ramishra has joined #openstack-lbaas07:28
rm_workcgoncalves: https://review.opendev.org/#/c/659626/19/octavia/api/v2/controllers/listener.py@54407:51
rm_workif you can07:51
rm_workI think if you explain that to me I can +A07:51
*** ivve has joined #openstack-lbaas08:00
*** tkajinam_ has quit IRC08:01
rm_workcgoncalves? :P08:04
rm_workwant to +A before I head to bed08:04
rm_workeh I can just +A and you can explain later -- in the off chance it's actually not necessary, we can bugfix it later08:05
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add VIP access control list  https://review.opendev.org/65962608:09
cgoncalvesrm_work, ^08:09
rm_workugh lol k08:09
rm_workI just +A'd you :D08:09
cgoncalvesnooooooo! :D08:10
rm_workah well08:10
rm_workok so i was right, there was no reason for that DB re-fetch08:10
cgoncalvesyep, thanks!08:11
openstackgerritOpenStack Proposal Bot proposed openstack/octavia-dashboard master: Imported Translations from Zanata  https://review.opendev.org/68199308:25
*** ivve has quit IRC09:32
*** tkajinam has joined #openstack-lbaas10:05
*** ivve has joined #openstack-lbaas10:05
openstackgerritMaciej Józefczyk proposed openstack/octavia master: Add new algorithm SOURCE_IP_PORT  https://review.opendev.org/67246310:08
openstackgerritMaciej Józefczyk proposed openstack/octavia master: Validate supported LB algorithm in Amphora provider drivers  https://review.opendev.org/67247710:08
*** pcaruana has quit IRC10:11
*** luksky has joined #openstack-lbaas10:36
*** luksky has quit IRC11:09
lxkongrm_work: hi, not sure if you are still here, I encountered an issue for fedora 28 amphora image(octavia queens), I can successfully create the load balancer and listener, but the haproxy service failed inside the amphora, error msg: `'/usr/sbin/haproxy-systemd-wrapper': No such file or directory`11:16
*** sapd1_x has joined #openstack-lbaas11:22
*** pcaruana has joined #openstack-lbaas11:24
*** luksky has joined #openstack-lbaas11:26
*** luksky11 has joined #openstack-lbaas11:28
*** luksky has quit IRC11:31
*** luksky11 has quit IRC11:40
*** boden has joined #openstack-lbaas11:44
*** gcheresh_ has joined #openstack-lbaas11:50
*** luksky11 has joined #openstack-lbaas11:56
openstackgerritCarlos Goncalves proposed openstack/octavia-tempest-plugin master: Fix positional formatting and add skip check  https://review.opendev.org/67316812:02
*** goldyfruit has quit IRC12:12
*** luksky11 has quit IRC12:22
*** luksky11 has joined #openstack-lbaas12:23
*** tkajinam has quit IRC12:25
*** sapd1_x has quit IRC12:31
openstackgerritCarlos Goncalves proposed openstack/octavia-tempest-plugin master: Fix positional formatting and add skip check  https://review.opendev.org/67316812:39
*** henriqueof1 has joined #openstack-lbaas12:49
*** henriqueof has quit IRC12:50
openstackgerritMaciej Józefczyk proposed openstack/octavia master: Add new algorithm SOURCE_IP_PORT  https://review.opendev.org/67246312:53
openstackgerritMaciej Józefczyk proposed openstack/octavia master: Validate supported LB algorithm in Amphora provider drivers  https://review.opendev.org/67247712:53
*** gcheresh_ has quit IRC12:56
*** luksky11 has quit IRC13:06
*** Vorrtex has joined #openstack-lbaas13:26
*** goldyfruit has joined #openstack-lbaas13:28
*** Vorrtex has quit IRC13:42
*** goldyfruit has quit IRC14:14
*** ccamposr has quit IRC14:25
*** ccamposr has joined #openstack-lbaas14:25
*** goldyfruit has joined #openstack-lbaas14:34
*** goldyfruit_ has joined #openstack-lbaas14:42
*** rcernin has quit IRC14:42
*** goldyfruit has quit IRC14:44
johnsomlxkong: so fedora must have 1.9 or newer. We need to fix that, but you can override in octavia.conf for now14:45
johnsomHaproxy dropped the wrapper. Which is really good actually14:45
cgoncalvesI think F28 ships haproxy 1.814:53
openstackgerritMaciej Józefczyk proposed openstack/octavia master: Add new algorithm SOURCE_IP_PORT  https://review.opendev.org/67246314:54
openstackgerritMaciej Józefczyk proposed openstack/octavia master: Validate supported LB algorithm in Amphora provider drivers  https://review.opendev.org/67247714:54
cgoncalvesFedora<=30 has haproxy 1.8. Fedora>31= has 2.0.514:55
johnsomHmm, maybe it was 1.8 that removed the wrapper. (the wrapper caused problems as I remember) But if that is the case we should have already handled that....  I will take a quick look at the osutils (which could use a refactor IMO)15:06
ivvehey guys, any pointers on where to look/troubleshoot for the following issue: created a member and tried to attach it to existing (active and ok) lb. followed by worker replying "TimeOutException: contacting the amphora timed out". setting the listener state in failure and trying to create new amphorae15:10
ivvei now have 4 amphorae for 1 LB (which is btw still working, but in error state). in the following states:15:10
ivveerror:backup - error:master - error:standalone and allocated:none15:11
ivvenoteworthy is that the allocated and the backup seems to be trying to grab the same IP15:11
ivvethe standalone and master are reachable, the allocated and backup.. not at all15:12
ivveat one point worker tried to remove in-use security group.. other than that its just updating the listener to failure. but the loadbalancer does supply loadbalancing correctly and all members are reporting OK15:13
ivvei don't dare to amphora failover the master (that is working) trying to failover anything else just calls out immutable states15:16
openstackgerritMichael Johnson proposed openstack/octavia master: Add new algorithm SOURCE_IP_PORT  https://review.opendev.org/67246315:17
openstackgerritMichael Johnson proposed openstack/octavia master: Add new algorithm SOURCE_IP_PORT  https://review.opendev.org/67246315:20
mlozahello, in these policies https://docs.openstack.org/octavia/stein/configuration/policy.html#default-octavia-policies have default in the octavia code base? If yes, I don't need the full copy of the policy and change the specific to overwrite it right?15:22
ivvethe only thing that is in error state is a listener and all its members are fine :/15:22
johnsommloza Yes, all of those policies are in code (we were one of the first to move to that).15:22
mlozajohnsom: Awesome. Thanks!15:23
*** maciejjozefczyk is now known as mjozefcz|away15:23
johnsomivve So that sounds like someone killed the health manager while it was in the middle of a failover. That would be the source of an "allocated" being assigned to the LB but not yet configured.15:25
*** tesseract has quit IRC15:25
johnsomivve It is designed to "fail safe" and leave the LB functional even if the provisioning status is ERROR.  Thus, the operating status should all be ok.15:26
johnsomThis is going to be a tricky one to back out of. (Though, my new failover flow work will handle this situation. It's just not anywhere near ready yet)15:27
*** dayou has quit IRC15:28
*** ivve has quit IRC15:29
johnsomI would do the following:15:29
johnsomCheck if the allocated amp compute ID is present in nova. If yes, delete it out of nova, then mark it deleted in the amphora table.15:30
johnsomI would log into the standalone instance, see if it is handling any traffic. I.e. look at the haproxy logs or tcpdump inside the netns.15:31
johnsomIf it is handling traffic we need to get more creative, if not, I would delete it in nova and set it's amp record to deleted.15:31
johnsomThen look at backup, if it is present in nova, take note. It likely is not.15:33
johnsomThen I would attempt to failover the backup amphora. Do not use LB failover15:33
johnsomAlso, I would make sure you are running the latest version of whichever release you are on. It will make your life better.15:34
*** dayou has joined #openstack-lbaas15:39
*** mjozefcz|away has quit IRC15:43
*** ramishra has quit IRC15:51
*** rpittau is now known as rpittau|afk16:22
openstackgerritMerged openstack/octavia stable/rocky: Add warning log if auth_strategy is not keystone  https://review.opendev.org/67854816:24
openstackgerritMerged openstack/octavia master: Add VIP access control list  https://review.opendev.org/65962617:09
openstackgerritMerged openstack/octavia-dashboard master: Imported Translations from Zanata  https://review.opendev.org/68199317:13
*** luksky11 has joined #openstack-lbaas17:25
openstackgerritMichael Johnson proposed openstack/octavia-lib master: Generate PDF documentation  https://review.opendev.org/68212017:28
*** goldyfruit_ has quit IRC17:46
openstackgerritMichael Johnson proposed openstack/octavia-tempest-plugin master: Generate PDF documentation  https://review.opendev.org/68212417:48
*** goldyfruit_ has joined #openstack-lbaas17:49
openstackgerritMichael Johnson proposed openstack/octavia-lib master: Generate PDF documentation  https://review.opendev.org/68212017:51
*** gcheresh_ has joined #openstack-lbaas18:00
*** mjozefcz|away has joined #openstack-lbaas18:18
openstackgerritMichael Johnson proposed openstack/python-octaviaclient master: Generate PDF documentation  https://review.opendev.org/68213418:27
openstackgerritMichael Johnson proposed openstack/octavia-dashboard master: Generate PDF documentation  https://review.opendev.org/67928318:49
johnsomJoy more fallout from all of those last minute global requirements changes18:55
*** ccamposr has quit IRC18:56
*** ccamposr has joined #openstack-lbaas18:56
johnsomclient and lib appear to have issues18:57
johnsomI am working on client now18:57
*** goldyfruit___ has joined #openstack-lbaas18:59
*** mjozefcz|away has quit IRC19:01
*** goldyfruit_ has quit IRC19:02
mlozaI have "os_load-balancer_api:loadbalancer:put_failover": "load-balancer:write" in the octavia/policy.json. As a user with load_balancer-member role, I can19:03
mlozaI can't failover the LB*19:03
openstackgerritMichael Johnson proposed openstack/python-octaviaclient master: Fix a bad unit test for amphora list  https://review.opendev.org/68213919:04
openstackgerritMichael Johnson proposed openstack/python-octaviaclient master: Generate PDF documentation  https://review.opendev.org/68213419:04
mlozaI want to allow load_balancer-member to failover LBs19:04
johnsommloza One minute, I need to finish something, then I will chat19:05
mlozaSure19:05
openstackgerritMichael Johnson proposed openstack/python-octaviaclient master: Add support to VIP access control list  https://review.opendev.org/65962719:05
openstackgerritMichael Johnson proposed openstack/python-octaviaclient master: Wrap several show api calls with correct_return_codes  https://review.opendev.org/67533119:05
johnsomCores (rm_work, cgoncalves, xgerman) we need this patch reviewed: https://review.opendev.org/#/c/682139/ it's a blocker for the client release today19:07
johnsommloza Ok, hi. I home that is not for a general population. LB failover is a big hammer. Let me refresh my memory on the policy19:08
rm_workdone19:08
johnsomThanks19:08
xgerman+119:08
johnsommloza That looks correct. Does the user own the load balancer they are attempting to failover?19:09
mlozajohnsom: even the user who owns the LB can't failover19:10
mlozaI just tried just now19:11
mlozagetting Policy does not allow this request to be performed. (HTTP 403) (Request-ID: req-43745c9d-67d7-446e-875d-a77365dbaccb)19:11
johnsommloza Ok, so likely the policy file is not getting picked up.19:12
johnsommloza Your custom policy is in /etc/octavia/policy.json on the octavia API controllers (all of them)?19:13
mlozajohnsom: yes19:13
*** boden has quit IRC19:14
rm_workyeah letting users do failovers is ... O_o19:14
rm_workbut hopefully it's just a few people using this service and you trust them all very much? :D19:15
mlozaThe default policy "os_load-balancer_api:loadbalancer:put_failover": "rule:load-balancer:admin" allows tenants to list all the LB's19:16
johnsommloza Can you paste that file to paste.openstack.org ?19:16
johnsommloza How would the failover put allow users to list LBs?19:18
mlozajohnsom: if I gave the users loadbalancer-admin role they can list all LBs19:20
mlozajohnsom: http://paste.openstack.org/show/775786/19:20
rm_workyes, that is the design19:20
johnsomRight, Admin is admin, they can do anything in the cloud19:20
rm_worknot all users should get admin :D19:21
johnsomor in the case of our role, they can do anything on any LB19:21
mlozaI know loadbalancer-admin can do failover but we don19:22
mlozaI know loadbalancer-admin can do failover but we dont want them list all LBs19:22
rm_workyou shouldn't need it to do a failover, you should be able to do failover on the failover role19:23
rm_workif not, we have a bug to fix19:23
johnsomYeah, this is all working correctly for me locally19:23
johnsommloza So you probably do not want to use the loadbalancer-admin role. It is like "admin" in all of the other projects and allows everything.19:24
johnsomIt is a cross-project role19:24
openstackgerritMerged openstack/python-octaviaclient master: Fix a bad unit test for amphora list  https://review.opendev.org/68213919:27
openstackgerritMerged openstack/python-octaviaclient master: Add support to VIP access control list  https://review.opendev.org/65962719:28
openstackgerritMichael Johnson proposed openstack/python-octaviaclient master: Add support for SOURCE_IP_PORT algorithm  https://review.opendev.org/67241619:29
*** gcheresh_ has quit IRC19:29
mlozaI dont see a failover role. The ones I have are lb-quota-admin, lb-member, lb-admin and lb-observer19:30
johnsomRight, you may need to create a new one19:30
mlozaso this policy "os_load-balancer_api:loadbalancer:put_failover": "load-balancer:write" doesnt allow a user with lb-member role do a failover?19:31
johnsomI am looking at what is going on with your file. Give me a minute and I will figure it out.19:32
johnsommloza Your policy.json is mal-formed. It should be: "os_load-balancer_api:loadbalancer:put_failover": "rule:load-balancer:write"19:36
johnsomYou dropped the "rule:" prefix19:36
openstackgerritMerged openstack/python-octaviaclient master: Wrap several show api calls with correct_return_codes  https://review.opendev.org/67533119:38
mlozajohnsom: Oh yeah. My mistake I copied it incorrectly19:40
mlozaProbably this should work now19:40
mlozaWorks19:41
johnsomWe have pretty extensive testing for the policies, so I would have been surprised if it was actually broken.19:42
mlozaYeah. I didn't notice it since octavia containers didn't crash. Neutron crashes when I had a typo in policy.json19:44
johnsomThat is odd and probably a bug in neutron.  We just don't match the rule so you don't get permission.19:45
openstackgerritMerged openstack/octavia master: Add new algorithm SOURCE_IP_PORT  https://review.opendev.org/67246319:58
openstackgerritMichael Johnson proposed openstack/octavia master: Fix the tips job for octavia-lib  https://review.opendev.org/68214820:03
openstackgerritMerged openstack/python-octaviaclient master: Add support for SOURCE_IP_PORT algorithm  https://review.opendev.org/67241620:33
*** baffle has quit IRC20:42
*** openstackgerrit has quit IRC20:51
*** baffle has joined #openstack-lbaas20:53
*** henriqueof1 has quit IRC20:54
*** openstackgerrit has joined #openstack-lbaas21:00
openstackgerritMerged openstack/octavia stable/queens: Add failover logging to show the amphora details.  https://review.opendev.org/67977021:00
*** pcaruana has quit IRC21:03
johnsomFYI: The train client is up for release: https://review.opendev.org/#/c/68179921:13
*** luksky11 has quit IRC21:14
*** KeithMnemonic has quit IRC21:19
openstackgerritMichael Johnson proposed openstack/octavia master: Set neutron client logging to INFO  https://review.opendev.org/68216721:35
johnsomLet's see if that reduces the neutron noise in our logs a bit.21:36
openstackgerritOpenStack Release Bot proposed openstack/python-octaviaclient stable/train: Update .gitreview for stable/train  https://review.opendev.org/68216921:49
openstackgerritOpenStack Release Bot proposed openstack/python-octaviaclient stable/train: Update TOX/UPPER_CONSTRAINTS_FILE for stable/train  https://review.opendev.org/68217021:49
openstackgerritOpenStack Release Bot proposed openstack/python-octaviaclient master: Update master for stable/train  https://review.opendev.org/68217121:49
*** ccamposr has quit IRC22:07
rm_workGotta run to a wedding reception -- catch y'all on Monday :)22:40
rm_workUnless you need a review, then just ping me22:40
xgermanit’s not your own?22:40
rm_workFriend from gradeschool22:40
openstackgerritMichael Johnson proposed openstack/octavia-tempest-plugin master: Enable fail-fast on the gate queue  https://review.opendev.org/68218522:43
*** goldyfruit___ has quit IRC22:49
openstackgerritMichael Johnson proposed openstack/octavia-dashboard master: Enable fail-fast on the gate queue  https://review.opendev.org/68218822:54
openstackgerritMichael Johnson proposed openstack/octavia-dashboard master: Generate PDF documentation  https://review.opendev.org/67928323:02
openstackgerritMichael Johnson proposed openstack/octavia master: Set neutron client logging to INFO  https://review.opendev.org/68216723:09
johnsomOk, I think I am done blasting out patches and releases for the day.23:56
*** rcernin has joined #openstack-lbaas23:56
johnsomThe PDF patches are probably good enough for a first pass / meet the goal.23:56
johnsomThe main octavia one is still missing sections due to some unknown bug.23:56
johnsomThe lib patch is waiting on the tips fix in octavia.23:57
johnsomThere are also automated patches ready for a second +2 on client and lib. The lib one will fix the release notes23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!