Thursday, 2019-06-13

johnsomrm_work: I think Carlos has a patch started.00:05
johnsomlxkong: even 2-3 minutes seems long.00:06
rm_workKk00:11
johnsomrm_work https://review.opendev.org/#/c/594078/00:14
johnsomIt doesn't look like it addresses the devstack variable part however00:14
johnsomOh, ha, no it addresses that part, but not the ipv6 lb-mgmt-net00:14
johnsomhad it backwards00:14
* johnsom disappears once again for the night.00:16
rm_workk might poke00:24
*** goldyfruit has quit IRC00:24
*** goldyfruit has joined #openstack-lbaas00:24
*** yamamoto has quit IRC00:48
*** ccamposr has joined #openstack-lbaas01:27
*** happyhemant has quit IRC01:28
*** dayou_ has quit IRC02:08
*** ccamposr has joined #openstack-lbaas02:11
*** ccamposr__ has joined #openstack-lbaas02:13
*** ccamposr has quit IRC02:13
*** ccamposr__ has quit IRC02:14
*** dayou_ has joined #openstack-lbaas02:22
*** KeithMnemonic has quit IRC03:08
*** ramishra has joined #openstack-lbaas03:43
*** ccamposr has joined #openstack-lbaas03:45
*** ricolin has joined #openstack-lbaas03:50
*** ccamposr has quit IRC03:50
lxkongrm_work: are you still here?04:00
lxkongjohnsom, rm_work, i found the amphora-agent service takes a long time before opening the port 9443 after the service is active. https://paste.api-zulu.com/04:01
*** ramishra has quit IRC04:02
*** ramishra has joined #openstack-lbaas04:03
johnsomThat doesn’t open for me, can you use paste.openstack.org?04:03
lxkongjohnsom: ooh, thanks god you are still here04:03
lxkongjohnsom: http://dpaste.com/3700R0A04:04
johnsomI get a blank green screen with some icons in the corner04:04
johnsomOk, that one works.04:04
johnsomLet me read04:04
lxkongjohnsom: output of `journalctl -u amphora-agent`: http://paste.openstack.org/show/752855/04:05
*** yamamoto has joined #openstack-lbaas04:05
lxkongyou can see there is about 5min between systemd said "Started" and amphora-agent is actually printing some log04:06
johnsomYeah, that is odd.04:07
johnsomCan you do the systemd-analyze on that?04:09
lxkongsure, 1 sec04:09
johnsomDid you check the qemu process flags?04:09
lxkongjohnsom: no, it's our production env, i can't easily ssh into the compute node04:10
lxkongjohnsom: output of systemd-analyze commands: http://paste.openstack.org/show/752856/04:12
johnsomSee, those all look ok, ~4 seconds to the amphora agent started04:14
johnsomI really thing it is a problem with nova and the vm04:14
lxkongjohnsom: do you mind providing the qemu commands you mentioned? so i can ask our ops for help04:15
johnsomJust do a “ps -ef | grep qemu” this will show how nova booted the VM.04:16
lxkongjohnsom: when i restart the service, i can see the port is open very quickly, seems like the problem exists only at the first time start04:16
johnsomMy guess is the accel flag is tcg, which is bad04:17
johnsomYeah, I am pretty sure it isn’t our code, it seems like outside our stuff.04:20
lxkongjohnsom: http://dpaste.com/282ZGWM04:27
lxkongfinally i got permission to log into the compute node04:27
johnsomOk, looking through that doesn’t raise a red flag, there are odd devices there, but nothing major.04:32
lxkongjohnsom: i built the image on a ubuntu xenial physical machine, but i guess that shouldn't be a problem04:33
johnsomI wonder if the ceph is overloaded. Hang on a second04:33
johnsomYeah, we do that too. Should not matter04:34
johnsomIn the amp, can you check the /proc/pressure files and see it one of the metrics is odd?04:37
rm_work"lxkong:you can see there is about 5min between systemd said "Started" and amphora-agent is actually printing some log"04:38
rm_workthat is the same thing i see, just the scale is different04:38
rm_worki think it might be happening for you too but just your environment is a lot faster in general so it's not obvious04:38
rm_work^^ I mean johnsom's enc04:38
rm_work*env04:38
*** gcheresh has joined #openstack-lbaas04:39
rm_worki can show you at some point, maybe tomorrow?04:39
rm_workabout to grab dinner04:39
lxkongjohnsom: `/proc/pressure` doesn't exist inside the amphora04:40
johnsomHmm, that is different. Are they centos images?04:42
lxkongno, ubuntu xenial04:42
rm_worklet me check mine04:43
rm_worksince you are still here04:43
johnsomJust about to fall asleep04:44
lxkongrm_work: i can be here for 10min, need to pick up the kid04:44
lxkongjohnsom: thanks for trying to help04:44
*** vishalmanchanda has joined #openstack-lbaas04:44
johnsomYeah, I am on 19 hours now, lol04:45
rm_workwhelp....04:46
rm_workfor the record, no /proc/pressure in my ubuntu amp either04:47
rm_workbut, also, it isn't doing it anymore O_o04:47
rm_worki wonder...04:47
rm_worki have made some amp build changes since then04:47
rm_workwould be funny if i accidentally fixed it :D04:47
rm_workthough i doubt they'd be relevant pre-agent-startup04:47
rm_worknow it's about 30s from when it switches to the connect task, to when it successfully connects, much faster than before <_<04:49
rm_workbut i've rebuilt my stack since then too so really hard to say04:49
*** vishalmanchanda has quit IRC04:49
*** vishalmanchanda has joined #openstack-lbaas04:49
*** pcaruana|afk| has joined #openstack-lbaas05:01
*** pcaruana|afk| has quit IRC05:04
*** pcaruana has joined #openstack-lbaas05:04
*** ivve has joined #openstack-lbaas05:10
*** ricolin has quit IRC05:36
*** takamatsu has joined #openstack-lbaas05:42
*** luksky has joined #openstack-lbaas05:45
*** ltomasbo has left #openstack-lbaas06:05
*** ccamposr has joined #openstack-lbaas06:08
*** ccamposr has quit IRC06:13
*** ccamposr has joined #openstack-lbaas06:16
*** ccamposr__ has joined #openstack-lbaas06:26
*** ccamposr has quit IRC06:28
*** rpittau|afk is now known as rpittau07:00
*** ianychoi has joined #openstack-lbaas07:02
*** vishalmanchanda has quit IRC07:14
*** tesseract has joined #openstack-lbaas07:21
*** ataraday has quit IRC07:22
*** trident has quit IRC07:31
*** takamatsu has quit IRC07:32
*** trident has joined #openstack-lbaas07:34
*** lemko has joined #openstack-lbaas07:58
openstackgerritCarlos Goncalves proposed openstack/octavia master: DNM: systemd-219-64.el7  https://review.opendev.org/66508908:00
openstackgerritCarlos Goncalves proposed openstack/octavia master: DNM: systemd-219-64.el7  https://review.opendev.org/66508908:07
*** takamatsu has joined #openstack-lbaas08:19
*** rcernin has quit IRC08:23
*** yboaron_ has joined #openstack-lbaas08:37
*** luksky has quit IRC08:39
rm_workcgoncalves: so do you mind if i poke at that ipv6-gate patch you started?09:10
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: WIP: Test Additional VIPs  https://review.opendev.org/66446209:11
cgoncalvesrm_work, sure!09:15
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: WIP: Test Additional VIPs  https://review.opendev.org/66446209:21
rm_workjust took inspiration from the one you did and deleted all the tests i didn't care about from the projects.yaml :D09:21
rm_workwhile i'm in test-development mode09:21
*** luksky has joined #openstack-lbaas09:22
openstackgerritMerged openstack/octavia-dashboard master: Remove reference to Neutron LBaaS dashboard  https://review.opendev.org/66304209:23
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: WIP: Test Additional VIPs  https://review.opendev.org/66446209:28
*** jomeier has joined #openstack-lbaas09:34
jomeierHi. I managed to install Octavia on OpenStack 'Stein'. I can load balance to two backend VMs (without health api endpoints!). The load balancer never goes to 'online' status. Its status is 'offline'. But it seems to do its job.09:36
jomeierWhats missing?09:36
openstackgerritCarlos Goncalves proposed openstack/octavia-lib master: Add allowed_cidrs to Listener data model  https://review.opendev.org/65962509:43
openstackgerritMerged openstack/neutron-lbaas stable/stein: remove release notes job  https://review.opendev.org/66487410:05
*** yamamoto has quit IRC10:09
openstackgerritAdam Harwell proposed openstack/octavia master: WIP: Allow IPv6 health network in devstack  https://review.opendev.org/66510310:12
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: Add octavia-v2-dsvm-scenario-ipv6 to check queue  https://review.opendev.org/59407810:14
rm_workjomeier: so, it will "work" for now as long as everything is good, but two things10:18
rm_workfirst, as you noticed, the operating_status will never update, so you won't get ONLINE ever10:18
rm_worksecond, individual member statuses won't update in the API (to ONLINE/OFFLINE)10:19
rm_workthird, you won't get any statistics10:19
rm_workfourth (and probably most important) you won't really be very Highly Available, because in the case of an issue with the amphora, the failover won't happen automatically10:19
rm_worksorry, more than two things :D10:20
rm_workyou REALLY want the health managers to work :D10:23
cgoncalvesjomeier, make sure heartbeat messages are not being dropped on your controller10:24
cgoncalvesUDP packets on port 5555 on interface o-hm0 (defaults)10:24
rm_worki mean, they said "without health api endpoints"10:24
rm_worki assume it isn't even configured/started10:25
jomeierThanks guys. So you mean the offline status comes from my machines dont have an health api endpoint and everything is as expected?10:34
cgoncalvesjomeier, if by health api endpoint you mean the octavia health manager service is not running, then yes10:38
jomeier@cgoncalves: It is running and its not complaining about anything in /var/log/octavia/health-manager.log10:41
cgoncalvesjomeier, not complaining is expected10:43
cgoncalvesjomeier, do a packet capture on the o-hm0 network interface, and check if UDP:5555 packets are being received10:43
*** yamamoto has joined #openstack-lbaas10:45
jomeier@cgoncalves: With tcpdump? I dont see anything but ARP packages even if I ping the IP address of o-hm0 interface.10:47
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: WIP: Test Additional VIPs  https://review.opendev.org/66446210:47
*** yamamoto has quit IRC10:59
*** yamamoto has joined #openstack-lbaas10:59
rm_workremember ping is blocked by neutron without explicit security groups :D11:14
openstackgerritAdam Harwell proposed openstack/octavia master: WIP: Allow IPv6 health network in devstack  https://review.opendev.org/66510311:22
*** yamamoto has quit IRC11:24
*** yamamoto has joined #openstack-lbaas11:28
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: WIP: Test Additional VIPs  https://review.opendev.org/66446211:38
*** yamamoto has quit IRC11:40
*** yamamoto has joined #openstack-lbaas11:43
*** yamamoto has quit IRC11:43
*** yamamoto has joined #openstack-lbaas11:43
*** yamamoto has quit IRC11:48
*** yamamoto has joined #openstack-lbaas11:53
*** yamamoto has quit IRC11:57
*** boden has joined #openstack-lbaas12:17
openstackgerritboden proposed openstack/neutron-lbaas stable/stein: Support URL query params in healthmonitor url_path  https://review.opendev.org/66093012:20
*** yamamoto has joined #openstack-lbaas12:21
openstackgerritboden proposed openstack/neutron-lbaas stable/stein: Support URL query params in healthmonitor url_path  https://review.opendev.org/66093012:22
*** goldyfruit has quit IRC12:24
*** ccamposr__ has quit IRC12:34
openstackgerritCarlos Goncalves proposed openstack/octavia master: DNM: systemd-219-64.el7  https://review.opendev.org/66508912:35
*** ccamposr has joined #openstack-lbaas12:37
*** yamamoto has quit IRC12:40
*** yamamoto has joined #openstack-lbaas12:59
*** pcaruana has quit IRC13:01
*** yamamoto has quit IRC13:08
*** yamamoto has joined #openstack-lbaas13:09
*** yamamoto has quit IRC13:09
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: WIP: Test Additional VIPs  https://review.opendev.org/66446213:18
*** goldyfruit has joined #openstack-lbaas13:22
*** gcheresh has quit IRC13:24
*** ccamposr__ has joined #openstack-lbaas13:30
*** ccamposr has quit IRC13:32
*** gcheresh has joined #openstack-lbaas13:34
*** yamamoto has joined #openstack-lbaas13:37
*** yamamoto has quit IRC13:42
*** ricolin has joined #openstack-lbaas13:45
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: Add octavia-v2-dsvm-scenario-ipv6 to check queue  https://review.opendev.org/59407813:45
*** goldyfruit has quit IRC13:46
*** goldyfruit has joined #openstack-lbaas13:46
*** ricolin has quit IRC14:21
*** yamamoto has joined #openstack-lbaas14:23
*** luksky has quit IRC14:29
*** gcheresh has quit IRC14:35
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: WIP: Test Additional VIPs  https://review.opendev.org/66446214:40
* rm_work sleeps14:41
*** yboaron_ has quit IRC15:00
*** Vorrtex has joined #openstack-lbaas15:03
*** yamamoto has quit IRC15:35
*** ivve has quit IRC15:40
openstackgerritMichael Johnson proposed openstack/octavia master: DNM: experimental element for centos debug  https://review.opendev.org/66503215:40
*** Vorrtex has quit IRC15:50
*** gcheresh has joined #openstack-lbaas15:51
*** rpittau is now known as rpittau|afk16:13
*** gcheresh has quit IRC16:16
*** ccamposr has joined #openstack-lbaas16:28
*** ccamposr__ has quit IRC16:30
*** lemko has quit IRC16:47
*** omkartelee has joined #openstack-lbaas16:54
omkarteleeHi, I want to augment CLI of Octavia (loadbalancer v2) to add my own commands ... is there any way i can extend it to add my commands ?16:55
johnsomomkartelee You can create your own openstack client plugin. See this page for information: https://docs.openstack.org/python-openstackclient/pike/contributor/plugins.html16:58
*** pcaruana has joined #openstack-lbaas17:09
*** henriqueof has joined #openstack-lbaas17:25
*** omkartelee has quit IRC17:31
*** yamamoto has joined #openstack-lbaas17:33
*** ramishra has quit IRC17:44
*** gcheresh has joined #openstack-lbaas17:46
*** omkartelee has joined #openstack-lbaas17:49
omkarteleeThanks @johnsom, I was expecting octavia client also has similar extension functionality like neutron client has ---> https://github.com/openstack/python-neutronclient/blob/master/neutronclient/common/extension.py17:49
johnsomomkartelee That is for the old clients. With the new openstack clients, it's pretty straight forward.17:53
omkarteleegot it ... Thanks for quick response Johnsom17:54
*** ivve has joined #openstack-lbaas17:56
*** omkartelee has quit IRC18:05
*** mithilarun has joined #openstack-lbaas18:07
*** gcheresh has quit IRC18:10
*** ianychoi has quit IRC18:13
openstackgerritMichael Johnson proposed openstack/octavia-tempest-plugin master: Fix the load balancer service clients  https://review.opendev.org/66520718:33
openstackgerritMichael Johnson proposed openstack/octavia-tempest-plugin master: Fix the load balancer service clients  https://review.opendev.org/66520718:36
johnsom^^^ The OSA folks noted that our service client wasn't picking up some of the tempest settings such as ca_certs. We missed the service_client_config call to tempest to get those base params.18:37
*** yamamoto has quit IRC18:52
*** mithilarun has quit IRC18:59
*** mithilarun has joined #openstack-lbaas19:00
*** mithilarun has quit IRC19:04
openstackgerritMichael Johnson proposed openstack/octavia master: Align logging in the amphora  https://review.opendev.org/66412319:15
*** gcheresh has joined #openstack-lbaas19:16
*** takamatsu has quit IRC19:32
*** mithilarun has joined #openstack-lbaas19:33
*** mithilarun has quit IRC19:37
openstackgerritMichael Johnson proposed openstack/octavia master: Align logging in the amphora  https://review.opendev.org/66412319:42
*** mithilarun has joined #openstack-lbaas20:03
*** gcheresh has quit IRC20:13
*** pcaruana has quit IRC20:36
*** yamamoto has joined #openstack-lbaas20:47
*** takamatsu has joined #openstack-lbaas21:13
*** luksky has joined #openstack-lbaas21:17
johnsomFYI, the RAX gate hosts have a broken mirror, so devstack isn't completing on jobs.21:34
johnsomI guess infra was experimenting with kafs and it's broken.  No ETA when the gates will be fixed.21:36
*** luksky has quit IRC21:43
*** mithilarun has quit IRC21:49
*** mithilarun has joined #openstack-lbaas21:50
*** boden has quit IRC21:53
*** mithilar_ has joined #openstack-lbaas21:53
*** mithilarun has quit IRC21:54
openstackgerritAdam Harwell proposed openstack/octavia master: Allow multiple VIPs per LB  https://review.opendev.org/66023922:04
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: WIP: Test Additional VIPs  https://review.opendev.org/66446222:05
openstackgerritAdam Harwell proposed openstack/octavia-tempest-plugin master: Add octavia-v2-dsvm-scenario-ipv6 to check queue  https://review.opendev.org/59407822:19
*** takamatsu has quit IRC22:25
*** yamamoto has quit IRC22:29
*** mithilar_ has quit IRC22:38
*** mithilarun has joined #openstack-lbaas22:39
*** mithilarun has quit IRC22:43
*** yamamoto has joined #openstack-lbaas22:44
*** rcernin has joined #openstack-lbaas22:45
*** tesseract has quit IRC22:48
*** yamamoto has quit IRC22:50
*** goldyfruit has quit IRC22:54
*** mithilarun has joined #openstack-lbaas22:56
*** ivve has quit IRC22:57
lxkongjohnsom: another weird thing i found is, when i switched to use fedora image, the vm bootstrap is stuck https://termbin.com/6g4l23:07
lxkongjohnsom: wouldn't you happen to know something about that, would you?23:07
johnsomlxkong We are seeing something like that in our gates. Carlos and I have been trying to reproduce it.  What is your stack that reproduces that?23:07
lxkongjohnsom: stack?23:08
johnsomlxkong Host OS, instance OS, hypervisor, and image OS23:08
johnsomHere is the gate log where we see the same: http://logs.openstack.org/06/626406/9/check/octavia-v2-dsvm-scenario-centos-7/218826a/controller/logs/octavia-amphora_log.txt.gz23:09
rm_workjohnsom: interesting on the service client thing <_<23:09
*** yamamoto has joined #openstack-lbaas23:10
johnsomSo far we haven't been able to reproduce it locally though which has made it hard to debug.23:10
johnsomrm_work Yeah, an oversight. Likely on my part.23:10
johnsomrm_work it's not in the tempest docs at all.23:10
lxkonghost os: Ubuntu 14.04.5 LTS, instance OS: fedora, hypervisor: kvm23:10
rm_workjohnsom: so in tempest we use the private-network, which for ipv4 needs us to make a flip, but for ipv6... there's no ipv6 flips... but private-net isn't accessible apparently (makes sense)23:11
*** goldyfruit has joined #openstack-lbaas23:11
rm_workdoes that just mean we can't use private for ipv6 tests?23:11
johnsomlxkong and a centos amphora image?23:11
lxkongjohnsom: the only difference with ubuntu image build is `-i fedora`23:11
lxkongand the size `-s 3`23:11
johnsomlxkong Ah, ok, so you don't have an intermediate VM, it's running right on the Ubuntu?23:11
lxkongyes23:12
johnsomOk, that is good to know.23:12
johnsomThis has had us puzzled for a while. Something changed in centos to cause this. It may be that it is just booting super slow and the controller is timing out too23:13
*** yamamoto has quit IRC23:13
johnsomrm_work so hold up here a sec, we *just* changed to the private ipv6 to get the multinode working23:13
rm_workyeah23:13
rm_workbut23:14
rm_workthat was on the backend23:14
rm_workon the FRONTEND (for the LB VIP) is what i'm talking about23:14
rm_worksorry, wasn't clear23:14
lxkongjohnsom: i was supposed to use fedora instead of ubuntu image in our prod as a workaround to the issue we are suffering, but seems it's not gonna work23:14
johnsomFor cirros webservers I thought I just put both subnets on one instance so we could configure it via the flip23:14
rm_workfor the backend it's fine because Octavia does what it does and plugs the private member subnets23:14
rm_workbut if i want to make a LB with an ipv6 VIP... i guess the only way is to have it be public?23:15
johnsomlxkong fedora is not going to improve your boot times.  In fact it will be slower.23:15
rm_workotherwise our "check_members_balanced" won't be able to hit it23:15
lxkongjohnsom: :-(23:15
rm_workunless we like... go through a bastion23:15
johnsomrm_work We already have IPv6 VIP tests.....23:15
johnsomrm_work https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/tests/scenario/v2/test_ipv6_traffic_ops.py#L11323:16
johnsomlxkong On your system with the hung boot, in the qemu flags, what is the accel=?23:17
rm_workyeah i'm looking at those23:18
lxkongjohnsom: accel=kvm23:18
rm_worki'm not... sure if they ... work correctly?23:18
johnsomlxkong hmmm, ok, we are seeing the problem on accel=tcg which is SUPER slow to boot23:19
johnsomrm_work They work.23:19
johnsomrm_work yee of little faith... I just created those last year and fixed all of that stuff.23:20
rm_workhmmm23:20
johnsomrm_work http://logs.openstack.org/01/660201/2/check/octavia-v2-dsvm-scenario/0256d13/controller/logs/tempest_log.txt.gz#_2019-06-04_19_45_22_80923:23
lxkongjohnsom: the fedora vm finally up and running...23:23
lxkongjohnsom: but wait for a long time after `Started Builds and install new kernel modules through DKMS.`23:23
johnsomYeah, ok, so that was my wonder, if it's just super slow.23:23
lxkonghttp://dpaste.com/07GF64423:23
johnsomlxkong Can you provide the systemd-analyze for it?23:24
johnsomAh, a clue.  that makecache23:24
johnsomWhat was the timestamp above that?23:24
rm_workjohnsom: if i rebase / depends-on your amp-logs patch, will i magically get amp logs? :D23:25
johnsomYou need this one: https://review.opendev.org/624835 from octavia.  Then if you want it in the gates, you need the tempest patch too23:26
rm_workk23:26
johnsomI'm just about done with the docs, so hey, you could just review it!23:26
rm_workheh yes23:26
rm_workwill do that while tempest runs23:27
openstackgerritMichael Johnson proposed openstack/octavia master: Amphora logging  https://review.opendev.org/62483523:27
johnsomThere that is current. I'm just not done with the docs page.23:28
johnsomIt's mostly done23:28
lxkongjohnsom: the `systemd-analyze` output http://dpaste.com/18VQ1N523:28
johnsom13 minutes! ouch23:28
johnsomlxkong This is super helpful, thank you!23:29
lxkongjohnsom: we are going to downgrade our Octavia23:29
lxkongjohnsom: i've no idea about how to debugging this23:29
lxkongfor the ubuntu image, i can't reproduce the issue on my devatack environment23:30
lxkongfor fedora, such preformance is not acceptable23:30
johnsomlxkong I still don't understand why your ubuntu would be slow. Have you tried a xenial amphora image in addition to the bionic one?23:31
lxkongjohnsom: didn't try bionic, but it's a good suggestion, will build one now23:31
lxkongfor the last resort :-)23:31
lxkongjohnsom: btw, if you need anything else, log. etc please let me know before i deleting everything23:32
johnsomlxkong If you don't mind, could you paste us the syslog file from inside that amp?  That should have everything we are looking for. Oh, and also the nova console log file.23:33
lxkongjohnsom: ook23:33
johnsomlxkong Sorry, but the cloud-init log from inside the amp too if you can23:38
lxkongjohnsom: for sure23:38
rm_workjohnsom: pretty good, one thing in plugin.sh but ... i can fix that in my ipv6 patch that i'm working on now, since I am redoing that whole section anyway23:40
rm_workso actually I might just switch to +2 since it doesn't really matter in your patch yet23:40
johnsomWell, I need to finish the docs page, so save the +@23:41
johnsom+223:41
rm_workdid it anyway23:41
rm_workoh, right, i didn't review the docs23:41
rm_worki was skipping that23:41
rm_workand i got to the end and it looked good :D23:42
rm_workshould I bother reading the docs up to what you have now, or just wait23:42
johnsomSure, it's mostly done. Just finish the 'tenant" log section23:42
rm_worki skipped everything doc/23:42
rm_workk23:42
johnsomI agree with you on that filename/placement. It felt odd to me too.  Plus I *improved* it's name from what was there earlier.  "10-amphora.conf"23:44
johnsomI think the right answer is to move it to etc/rsyslog in our repo23:44
johnsomMuch more clear23:45
johnsomAlso don't forget the parent patch: https://review.opendev.org/#/c/664123/23:49
rm_workreceive precedent ok posted some stuff on the doc23:50
rm_work^^ those two words especially :D23:50
johnsomHa, yeah, not checked yet23:51
rm_work(I was using IRC to do validation of my hunch on the spelling, forgot to delete that :D)23:51
rm_worki'm not 100% sure why these patches are separate but whatever23:52
rm_worka bunch of the stuff this does *immediately* changes in the next patch23:52
johnsomWell, German started is, but there was more work to do in the amphora from my perspective so I did my own patch for that.23:53
rm_workcommented on that too23:55
johnsomThank you23:55
rm_worki would have merged them IMO, but it's fine I guess23:55
rm_workjust one small thing23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!