Friday, 2018-09-28

*** strigazi has quit IRC00:01
*** strigazi has joined #openstack-lbaas00:02
openstackgerritMichael Johnson proposed openstack/octavia master: Fix an upgrade issue for CentOS 7 amphora  https://review.openstack.org/60589400:12
johnsom^^^ rm_work That should fix the issue and set us up to be able to use new HAProxy features in the future.00:13
*** yamamoto has joined #openstack-lbaas00:21
openstackgerritJacky Hu proposed openstack/neutron-lbaas-dashboard master: Update the URL in HACKING.rst  https://review.openstack.org/60476900:42
rm_worksweet01:08
rm_workthankies01:08
rm_workjohnsom: weird i thought the "get_haproxy_versions" was already a function we had01:11
*** JudeCross has quit IRC01:18
rm_workbuilding and deploying soon to my test env02:04
rm_workdeciding how to test this...02:04
rm_workmight have to re-upload old images02:04
rm_workor change the tags i use temporarily02:05
*** JudeCross has joined #openstack-lbaas02:05
*** yamamoto has quit IRC02:16
*** hongbin has joined #openstack-lbaas02:20
openstackgerritsapd proposed openstack/python-octaviaclient master: Support REDIRECT_PREFIX for openstack client Story: 2003700  https://review.openstack.org/60591402:46
openstackgerritsapd proposed openstack/octavia master: Support REDIRECT_PREFIX action for L7Policy  https://review.openstack.org/60108602:55
*** yamamoto has joined #openstack-lbaas03:24
*** hongbin has quit IRC03:38
*** yamamoto has quit IRC03:50
*** yamamoto has joined #openstack-lbaas04:41
*** JudeCross has quit IRC04:53
*** ramishra has joined #openstack-lbaas05:09
*** JudeCross has joined #openstack-lbaas05:15
*** yamamoto has quit IRC05:21
*** yamamoto has joined #openstack-lbaas05:29
*** abaindur has joined #openstack-lbaas05:51
*** abaindur has quit IRC05:52
*** abaindur has joined #openstack-lbaas05:52
openstackgerritsapd proposed openstack/octavia master: Support REDIRECT_PREFIX action for L7Policy  https://review.openstack.org/60108605:56
*** JudeCross has quit IRC06:04
*** pcaruana has joined #openstack-lbaas06:11
*** yamamoto has quit IRC06:27
*** JudeCross has joined #openstack-lbaas06:29
*** numans has joined #openstack-lbaas06:46
*** maciejjozefczyk has joined #openstack-lbaas06:56
*** yamamoto has joined #openstack-lbaas07:04
*** rcernin has quit IRC07:12
*** celebdor has joined #openstack-lbaas07:29
*** velizarx has joined #openstack-lbaas07:35
*** velizarx has quit IRC07:41
*** JudeCross has quit IRC07:42
openstackgerritsapd proposed openstack/octavia master: Support REDIRECT_PREFIX action for L7Policy  https://review.openstack.org/60108607:59
*** velizarx has joined #openstack-lbaas08:04
*** abaindur has quit IRC08:24
openstackgerritwangxiyuan proposed openstack/octavia master: Add db migration script for tags  https://review.openstack.org/60600608:55
*** salmankhan has joined #openstack-lbaas09:08
*** abaindur has joined #openstack-lbaas09:20
*** yamamoto has quit IRC10:31
*** yamamoto has joined #openstack-lbaas10:32
*** yamamoto has quit IRC10:38
openstackgerritsapd proposed openstack/octavia master: Support REDIRECT_PREFIX action for L7Policy  https://review.openstack.org/60108611:10
*** yamamoto has joined #openstack-lbaas11:26
*** yamamoto has quit IRC12:16
velizarxHi folks, I want to ask about certificates. Why Octavia accepts the only certificate in pkcs12 format? Usually, SSL certificate is two files (crt and key), but for using this in Octavia user must create pkcs12 file (and whithout password). It's very unuseful for end-user. Do you have a plan to add support separate files?12:24
velizarxThe second question about plan was resolve, I found text: "DEPRECATED: A secret container of type 'certificate' containing the certificate and key for TERMINATED_TLS listeners." But, I don't understand why did you deprecate this feature?12:40
*** ramishra has quit IRC13:22
*** yamamoto has joined #openstack-lbaas13:55
*** aojea_ has joined #openstack-lbaas15:12
*** yamamoto has quit IRC15:25
*** aojea_ has quit IRC15:32
johnsomvelizarx Hi.  There were a couple of reasons we switched to pkcs12 format. One is the way barbican works for separate files was leading to users having trouble getting all of the components into the barbican container. It also made it hard for us to extract them and make sure the user granted us access to all of the parts.  The other main reason was to allow alternate storage backends, such as Vault, that have15:45
johnsomstandardized on pkcs12 bundles.15:45
*** JudeCross has joined #openstack-lbaas15:49
velizarxjohnsom, Maybe, the best way it gives the opportunity to choose? When you plan to delete barbican legacy driver?15:50
johnsomvelizarx rm_work would maybe have more reasons/background on it15:50
*** yamamoto has joined #openstack-lbaas15:51
*** velizarx has quit IRC16:09
mnaserhey tam16:10
mnaserteam16:10
mnaserappreciate reviews on https://review.openstack.org/60612416:10
*** JudeCross has quit IRC16:14
*** yamamoto has quit IRC16:31
*** salmankhan has quit IRC16:38
*** ianychoi has quit IRC16:39
*** ianychoi has joined #openstack-lbaas16:44
mnaserxgerman_: johnsom: thanks.. mind looking also at https://review.openstack.org/#/c/606137/ and https://review.openstack.org/#/c/606138/1 ?16:51
mnaserformer needed to make a clean backport16:51
*** yamamoto has joined #openstack-lbaas17:26
rm_workjohnsom: what you told them was correct17:32
rm_worki don't know when exactly we will remove the barbican driver tho17:32
rm_work*legacy17:32
johnsomOk, thanks17:35
*** sapd1_ has joined #openstack-lbaas17:51
openstackgerritMichael Johnson proposed openstack/octavia-tempest-plugin master: DNM: Testing bionic nodes  https://review.openstack.org/60053917:51
*** JudeCross has joined #openstack-lbaas17:53
openstackgerritMichael Johnson proposed openstack/octavia-tempest-plugin master: DNM: Testing bionic nodes  https://review.openstack.org/60053917:57
*** yamamoto has quit IRC18:28
*** sapd1_ has quit IRC19:24
cgoncalvesrm_work, have you had a chance to test https://review.openstack.org/#/c/605894/ ?19:44
*** Emine has quit IRC19:52
*** Emine has joined #openstack-lbaas19:55
*** openstackgerrit has quit IRC20:07
*** yamamoto has joined #openstack-lbaas20:26
*** openstackgerrit has joined #openstack-lbaas20:32
openstackgerritGerman Eichberger proposed openstack/octavia master: Refactor the AAP driver to not depend on nova  https://review.openstack.org/60422620:32
mnaserhttps://review.openstack.org/#/c/606143/3 and https://review.openstack.org/#/c/606146/2 :)20:55
johnsommnaser Just an FYI, the octavia cores are not all cores on OSA - Octavia....20:57
mnaserjohnsom: there's at least 2 :p20:57
johnsomThere are == 220:57
mnaserthats all i need20:58
mnaser:P20:58
xgerman_ha20:58
rm_worklol21:08
*** yamamoto has quit IRC21:15
openstackgerritCarlos Goncalves proposed openstack/octavia-tempest-plugin master: Add octavia-v2-dsvm-scenario-ipv6 to the check queue  https://review.openstack.org/59407821:21
cgoncalvestotally understandable if ^ doesn't get approved21:22
cgoncalvesre: zombie amps. if we nova delete, will HK delete its record from db?21:25
johnsomcgoncalves I'm in favor of an control plane IPv6 job.  Just need to find time to dig into the test results and verify it hits everything I hope it hits.21:29
rm_workcgoncalves: after the expiry period, yes21:29
rm_workthank heavens for the expiry time on those now21:30
colin-one or the other i'm assuming, no 4-to-6 sutff?21:30
rm_worki would have been *$&)%&(#ed yesterday otherwise21:30
rm_workcolin-: haproxy should easily be able to do 4-621:30
rm_workah you mean in the test21:30
colin-i was thinking the same but not confident how easily that'd fit in octavia21:30
rm_workhmmm that could be a good test :)21:30
rm_workit's one of the uses of octavia that I think we should publicize more I think21:30
rm_workit's definitely in-scope for benefits of a LB21:30
johnsomcolin- We should support 4-to-6 though I think there is an issue with UDP in that scenario.  This patch is control plane IPv6. We already test IPv6 data plane in our tempest tests21:31
rm_workjohnsom: do we split the members across 4 and 6?21:31
rm_workIIRC my testing does21:31
rm_workbut i don't know about the gate21:31
cgoncalvesI recall 4-to-6 didn't work well at least for UDP LBs in centos21:31
colin-understood, good to know21:31
johnsomWe should be able to support mixed members21:31
rm_work(the test script stuff i have in devstack-deploy does one ipv4 and one opv6 member)21:31
rm_workyeah but i don't remember if we actually have a gate that does that21:31
johnsomFYI: https://wiki.openstack.org/wiki/Neutron/LBaaS/Deprecation#When_will_the_neutron-lbaas_deprecation_cycle_end.3F21:32
rm_worklol21:32
rm_workthat title is like21:32
rm_worka cry for help21:32
rm_workat least that's how I read it21:32
cgoncalves\o/21:32
rm_work"when will the suffering cycle end"21:32
johnsomlol Too true21:32
johnsomI'm going to send out emails too....  Just a heads up I'm publicizing it. U is the end of the line....21:33
rm_workyissss21:33
cgoncalveshttps://media.giphy.com/media/JltOMwYmi0VrO/giphy.gif21:34
johnsomWould one of you kick this in so I can close out the py3 goal?21:35
johnsomhttps://review.openstack.org/#/c/603932/21:35
cgoncalvesdone21:36
xgerman_johnsom: set a date in case they go to 1 year cycles21:36
johnsomxgerman_ Oh, excellent point!!!!!21:37
johnsomHmm, that is interesting given the deprecation policy is "two cycles", but I think it is a great idea to put a stake in the ground now.21:38
colin-seems reasonable21:38
cgoncalvesyeah, I'd me in favor of a date but, as johnsom just said, policy is 2 cycles21:39
johnsomYeah, but I think it's fair to call it out now.21:39
xgerman_+121:39
cgoncalvesah, we should be fine: "it is **recommended** that the deprecated feature appears at least in the next two stable release branches."21:40
johnsomYeah, I think we are clean no matter what. Rocky counts as one cycle already....21:41
xgerman_yep…21:41
johnsomUpdated: https://wiki.openstack.org/wiki/Neutron/LBaaS/Deprecation#When_will_the_neutron-lbaas_deprecation_cycle_end.3F21:42
johnsomFYI, I updated the bot to put stable patch notifications in this channel in addition to the existing master branches.21:45
cgoncalvesnice21:47
rm_workahhh i wondered why those were missing21:47
rm_workseemed odd21:47
*** KeithMnemonic has quit IRC21:47
johnsomYeah, they were filtered, but no more....21:48
openstackgerritMerged openstack/neutron-lbaas-dashboard master: Add Python 3.6 unit test jobs  https://review.openstack.org/60393221:51
johnsomWahoo. Thanks. One goal down!21:51
openstackgerritGerman Eichberger proposed openstack/octavia master: [WIP] Refactor the pluggin of the VIP  https://review.openstack.org/60447921:52
xgerman_^ ok, seems to work so have a look — need to add some more tests an put a bow on it21:52
rm_workjohnsom: deployed your fix to prod, hope this works :P22:00
johnsomrm_work Umm, don't22:00
johnsomhttp://logs.openstack.org/94/605894/1/check/octavia-v1-dsvm-py3x-scenario/fd19e17/logs/screen-o-cw.txt.gz?level=ERROR22:00
rm_workhmmmmm22:01
rm_workok, well, tests were working?22:01
rm_worktempest all passed in stage22:01
rm_worki wonder if i didn't pick up your patch somehow when i thought i added it22:01
johnsomI think it's a py3 issue22:01
rm_workahhh22:02
rm_workok i'm safe then :P22:02
rm_workstuck on cent722:02
rm_worksooooo22:02
rm_work:P22:02
rm_workwait wtf22:04
rm_worki'm missing lines22:04
rm_workhow is this possible22:04
rm_workohhhh one of my patches removes some unused lines in that file for no freaking reason22:07
rm_workbut they *are* unused22:07
johnsomBoom, ok, e-mails sent22:07
rm_workanyway, looks like I am good on py2722:07
rm_work;)22:07
rm_workbut not sure it'll WORK properly22:07
rm_workdoes py2 do a typecast for str/int comp?22:08
rm_workahhh22:08
rm_worki think it will not work22:08
rm_workit's doing "2" < 222:08
rm_workerr22:08
rm_work"1" < 222:08
rm_workwhich is actually False22:08
johnsomWell, the py27 gates passed, but the py3 didn't22:08
rm_workright22:09
rm_workbut the py2 gates don't test that this actually works22:09
rm_workdo they?22:09
rm_workanyway I tested and that is what i get22:09
johnsomThey should run the same code paths...22:09
rm_workpy2 does "1" < 222:09
rm_workand just says "False"22:09
rm_workpy3 gives that exception you see22:09
rm_workbecause it won't try to typecast implicitly22:09
rm_workchecking22:10
rm_workyeah your tests don't actually verify the whole thing22:13
openstackgerritMichael Johnson proposed openstack/octavia master: Fix an upgrade issue for CentOS 7 amphora  https://review.openstack.org/60589422:13
rm_workgoing to need a better test too, hold on22:14
rm_workworking something up to recommend22:14
johnsomThis puzzles me as I saw the "has_http_reuse" = True stuff pop up in all of the py27 tests22:15
johnsomFeel free to just add it if you have a test22:17
rm_workyou have no test that actually HITS that22:21
rm_worki put a debug point on the thing22:21
rm_workand ran through22:21
rm_workand nothing actually tests it except a unit that tests it DIRECTLY22:21
rm_worki have a test almost done, will post it in a min22:21
rm_workoh hold on, also22:24
rm_workummm22:24
cgoncalvesquick Q: thoughts on either leaving first part under 'features' or move under 'fixes' (so that we can easily reason for backport)22:26
cgoncalveshttps://review.openstack.org/#/c/587505/20/releasenotes/notes/zombie_amp-1b435eb66643dab8.yaml22:26
rm_workjohnsom: we have another problem22:27
rm_workjohnsom: it's querying for "haproxy18" because that's what we have it looking for22:27
rm_workwhich won't even GET the correct version for haproxy before that22:27
rm_workas the package name is different22:27
rm_work>_>22:27
rm_workworking on a slightly more complex update22:27
johnsomcgoncalves Fixes22:28
johnsomrm_work I thought the amphora agent stripped that part, it should only be getting back a version string22:28
rm_workerrr22:29
rm_workthe rmp query22:29
rm_work*rpm query22:29
rm_workis going to be for "haproxy18"22:29
rm_workwhich works when it's on haproxy 1.822:29
johnsomOh, they already have that22:29
johnsomIt's a "package map" in the OS utils22:29
rm_workok yes22:29
rm_workbut22:29
rm_workit's the same version of the OS22:29
rm_workbut different package names22:29
rm_workwe have to make it check both22:29
rm_workor put a *22:30
rm_workor something22:30
johnsomNo, because we aren't backporting this.22:30
johnsomIt changed to haproxy18 in Rocky22:30
johnsomThat code is in the amp itself22:30
rm_workerr22:30
rm_workoh is it?22:31
rm_workahhh yes22:31
rm_workok22:31
rm_workso old amps will look for old package name22:31
rm_workcool22:31
johnsomYep22:31
rm_workwhew22:31
johnsomoctavia/amphorae/backends/agent/api_server/osutils.py:    PACKAGE_NAME_MAP = {'haproxy': 'haproxy18'}22:31
rm_workyes i saw that22:33
rm_workwas thinking that was on the client side, but it isn't22:33
rm_workwe don't ask for a package name's version22:33
rm_workwe just ask for info and it knows22:33
johnsomcgoncalves I'm not sure the "common causes" is accurate either.22:33
cgoncalvesjohnsom, why not? a compute reboot could cause amps there hosted to go zombie when compute is back22:35
johnsomNice, Octavia is the first project done with the python3 goal: https://storyboard.openstack.org/#!/board/10422:36
johnsomcgoncalves Why, the delete should have failed right? It should have rolled back and left the LB in error22:36
rm_worki think we're over-mocking in these tests22:39
cgoncalvesjohnsom, nova delete? it is an async call and we're calling the compute driver directly rather than using flows (no roll back)22:42
cgoncalvesor you mean nova delete on failover? hmmm22:42
johnsomcgoncalves Prior to this patch, every call into compute driver was part of a flow22:42
cgoncalvesright. xgerman_ suggests direct call to compute driver22:44
xgerman_I had a flow before... but didn’t want to over complicate things by throwing this on the engine22:46
xgerman_johnsom: aap calls nova client directly - so technically a flow but...22:48
johnsomYeah, that aap to nova was still inside a flow22:48
johnsomrm_work Have a thought on this story that came in? https://storyboard.openstack.org/#!/story/200390522:49
rm_workjohnsom: not sure hold on22:54
rm_workyour fix actually doesn't work22:54
rm_workwe load one AmphoraDriver and one JinjaTemplater in the class22:54
rm_workand so storing "has_httpreuse" on the class  ... carries across sessions22:55
rm_workand never resets22:55
rm_workgoing to change it to actually pass through22:55
*** yamamoto has joined #openstack-lbaas23:15
openstackgerritAdam Harwell proposed openstack/octavia master: Fix an upgrade issue for CentOS 7 amphora  https://review.openstack.org/60589423:27
rm_workjohnsom: ^^ what do you think23:27
johnsomlooking23:27
rm_workit adds some "unused vars" at the expense of being fully set up to do feature compat stuff with very little effort later23:27
johnsomWhy did the MEMBERS const go away? Not used?23:28
rm_workduplicated23:28
johnsomlol23:28
rm_workyes >_>23:28
johnsomWe should have a hacking for that. It happens23:28
rm_workyes23:28
rm_workthat would be good23:28
rm_workfortunately it was exactly the same23:28
rm_workoh damnit pep8 fail23:29
johnsomWhy use None as the default and not just {}?23:29
rm_work....23:30
rm_work{} is mutable23:30
rm_worki know you know that :P23:31
johnsomIsn't the get in the jinja just duplicate?23:31
rm_work?23:32
johnsomhttps://review.openstack.org/#/c/605894/2..3/octavia/common/jinja/haproxy/templates/macros.j223:32
johnsomYou already do a get with a default in the jinja.cfg23:32
rm_workthat is getting the value23:32
rm_workof the pool's "has_http_reuse"23:33
rm_workin jinja the "pool.has_http_reuse" is just a dict shortcut23:33
johnsomEverywhere else we just do pool.has_http_reuse23:33
rm_workpool is a dict, so we need to get the value of that field23:33
rm_workerr not anymore we don't23:33
rm_workexcept places i literally couldn't change it because it's a function signature23:34
rm_workswitched everything over to the constant23:34
johnsomline 204 above in that jinja23:34
rm_worki was tempted to do function partials23:34
rm_worki GUESS we could hardcode it here23:35
rm_workif you really want23:35
rm_worki have to post another version anyway23:35
johnsomI'm just saying, everywhere else is the other way. I get it now why you did it. For the const.23:35
johnsomSo, why not change all of the others over to consts?23:36
johnsomgrin23:36
rm_worki was legitimately tempted23:36
johnsomlol23:36
rm_workbut i think that's for another patchset23:36
rm_workwould be a little out of scope here23:36
johnsomYeah, I am fine with this.23:36
johnsomlooking at the tests23:36
rm_workeh it's fine, i'll make it match23:36
rm_workin this one spot23:36
johnsomNo, leave it23:36
johnsomIt's a good reminder23:36
openstackgerritAdam Harwell proposed openstack/octavia master: Fix an upgrade issue for CentOS 7 amphora  https://review.openstack.org/60589423:37
rm_workkk, pushed a new one because of my dumb pep8 error23:37
rm_workforgot it doesn't like operators at the beginning of indented lines23:37
johnsomYeah, looks good to me23:38
johnsomThanks23:38
rm_workkk23:38
johnsomMan, this multi-node stuff isn't baked IMO23:39
rm_worktime to see how quickly i can get this to prod23:39
rm_workif we can get https://review.openstack.org/#/c/603490/ too23:57
rm_workzhaobo tested it and said it works fine23:57
rm_work^^ cgoncalves / nmagnezi / dayou / xgerman_23:58
rm_work(not picking john som because i've bothered him enough recently)23:59
rm_work*pinging23:59
johnsomlol 5pm on a friday23:59
rm_worklol23:59
rm_workdamnit23:59
*** yamamoto has quit IRC23:59
rm_workyou're here anyway23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!