Tuesday, 2018-06-05

rm_workxgerman_ / dayou_ / nmagnezi around?00:12
dayou_rm_work, yep, sir00:22
openstackgerritJacky Hu proposed openstack/octavia master: Implement provider drivers - L7 Rules  https://review.openstack.org/56707300:28
johnsomdayou_ Thanks!00:29
dayou_My pleasure!00:29
*** longkb1 has joined #openstack-lbaas00:35
*** rcernin_ has joined #openstack-lbaas00:37
*** rcernin has quit IRC00:37
rm_workjohnsom: looks like you haven't commented on the cleanup yet?00:49
rm_workanyway, cool, we got the majority in today00:51
*** hongbin has joined #openstack-lbaas00:57
*** harlowja has quit IRC01:07
johnsomYeah, will try to hit it after dinner.01:09
johnsomMade some progress on the migration tool today.01:10
*** kiennt26 has joined #openstack-lbaas01:10
openstackgerritMerged openstack/octavia master: Implement provider drivers - Health Monitor  https://review.openstack.org/56703701:57
openstackgerritMerged openstack/octavia master: Implement provider drivers - L7 Policy  https://review.openstack.org/56705901:57
openstackgerritMerged openstack/octavia-tempest-plugin master: Create api+scenario tests for l7rules  https://review.openstack.org/57048501:57
openstackgerritMerged openstack/octavia master: Implement provider drivers - L7 Rules  https://review.openstack.org/56707301:57
johnsomWeee02:03
*** fnaval has joined #openstack-lbaas02:09
*** fnaval has quit IRC02:10
*** yamamoto has joined #openstack-lbaas02:15
*** kiennt26 has quit IRC02:28
openstackgerritMichael Johnson proposed openstack/octavia master: Implement provider drivers - Cleanup  https://review.openstack.org/56743102:32
openstackgerritMichael Johnson proposed openstack/octavia master: Implement provider drivers - Cleanup  https://review.openstack.org/56743102:35
johnsomrm_work Ok, fixed up cleanup02:38
*** kiennt26 has joined #openstack-lbaas02:43
openstackgerritMerged openstack/octavia-tempest-plugin master: Create scenario tests for amphora  https://review.openstack.org/57125103:23
*** gans has joined #openstack-lbaas03:34
lxkongjohnsom: hi, did you see my reply for https://review.openstack.org/#/c/571333/? not sure if i understand you correctly03:41
*** gans has quit IRC04:04
*** links has joined #openstack-lbaas04:22
*** kiennt26 has quit IRC04:29
johnsomlxkong Ok, thanks for the comment.  I have +2'd it now04:29
lxkongjohnsom: thanks! Is it possible to backport to stable/pike after it's merged?04:30
johnsomyes, I think this is a valid bug for backport04:30
lxkongcool, I can do that04:30
johnsomPlease wait until it merges to cherrypick04:30
lxkongyeah, sure04:31
johnsomOtherwise, yeah, we can go as far back as Ocata04:31
johnsomlxkong Do you need a stable/Pike release or is the backport your priority?04:31
openstackgerritAdit Sarfaty proposed openstack/octavia master: Providers: propose changes to API  https://review.openstack.org/57145304:32
openstackgerritAdit Sarfaty proposed openstack/octavia master: Use object instead of object id in the drivers delete callbacks  https://review.openstack.org/57197404:32
lxkongwe don't need a new tag for release, because we are using the branch directly to build our internal package04:33
johnsomOk, cool.  Just wanted to know if I needed to prioritize a release for you.04:40
*** yboaron has joined #openstack-lbaas04:42
*** sapd has quit IRC04:45
*** sapd has joined #openstack-lbaas04:45
*** AlexeyAbashkin has joined #openstack-lbaas05:00
*** kobis has joined #openstack-lbaas05:02
*** hongbin has quit IRC05:06
*** kobis has quit IRC05:13
*** AlexeyAbashkin has quit IRC05:17
*** nmanos has joined #openstack-lbaas05:19
*** nmanos has quit IRC05:33
*** nmanos has joined #openstack-lbaas05:34
*** kobis has joined #openstack-lbaas05:34
*** AlexeyAbashkin has joined #openstack-lbaas05:41
*** AlexeyAbashkin has quit IRC05:44
*** AlexeyAbashkin has joined #openstack-lbaas05:44
*** AlexeyAbashkin has quit IRC05:59
openstackgerritMichael Johnson proposed openstack/octavia master: Neutron-LBaaS to Octavia migration tool  https://review.openstack.org/55442006:01
*** links has quit IRC06:08
*** ispp has joined #openstack-lbaas06:12
*** isssp has quit IRC06:14
openstackgerritMerged openstack/octavia master: Use HMAC.hexdigest to avoid non-ascii characters for package data  https://review.openstack.org/57133306:21
*** links has joined #openstack-lbaas06:26
*** pcaruana has joined #openstack-lbaas06:54
*** yamamoto_ has joined #openstack-lbaas06:57
*** yamamoto has quit IRC07:00
*** pcaruana is now known as pcaruana|worksho07:03
nmagnezirm_work, o/07:45
rm_worko/07:45
*** pcaruana|worksho is now known as pcaruana07:50
nmagnezirm_work, you were looking for me07:54
*** AlexeyAbashkin has joined #openstack-lbaas08:05
*** blake has joined #openstack-lbaas08:07
*** devfaz_ has quit IRC08:13
*** devfaz has joined #openstack-lbaas08:15
*** yboaron has quit IRC08:20
rm_workyeah, needed someone to merge a couple things :P08:24
rm_workbut someone got them08:24
rm_workalso making sure you are alive, haven't seen you reviewing or posting stuff in a while08:25
rm_workwe miss both you and carlos :P08:25
cgoncalveshello fellas!08:28
cgoncalvesrm_work, would you agree on squashing https://review.openstack.org/#/c/568361/ with https://review.openstack.org/#/c/570986/ ?08:29
cgoncalvespools patch has listeners patch (unmerged) as parent and both are very similar patches08:30
cgoncalvesI am okay with having them split still08:31
cgoncalvesat least a 3rd patch also needs to be written for listeners -- I have it ready for review in case we decide to have multiple patches08:32
*** crazik_ has left #openstack-lbaas08:33
cgoncalvesnmagnezi, ^08:33
openstackgerritAdit Sarfaty proposed openstack/octavia master: Use object instead of object id in the drivers delete callbacks  https://review.openstack.org/57197408:34
rm_workcgoncalves: what repo is that? i don't know what that repo is <_<08:35
openstackgerritAdit Sarfaty proposed openstack/octavia master: Add baseline object in the drivers update callbacks  https://review.openstack.org/57230308:36
cgoncalvesrm_work, you got me for a moment xD08:36
rm_work:P08:36
nmagnezirm_work, yeah sorry, we where very busy with internal stuff, but now things are going back to normal :)08:36
rm_workcool cool08:36
nmagnezicgoncalves, we first need to see that johnsom is okay with having this is as a bugfix and not as an RFE08:36
nmagnezirm_work, btw i did review some of your patches on Sunday08:37
nmagnezi:)08:37
cgoncalvesnmagnezi, IMO it's a scalability bug08:38
rm_worki'm a LITTLE skeptical, as i've seen those queries tweaked a few times now and it's never really done anything useful that i've seen, and i don't really understand how what they're doing could affect the speed very much at all... but... i guess you claim to be seeing results08:38
rm_workso... *shrug*08:38
cgoncalvesI also found that project_id is not being returned by the API while it should according to neutron-lib api-ref08:38
rm_workyes, we should return project_id and tenant_id IIRC08:38
rm_workdoes it not do that?08:38
cgoncalvesrm_work, from 1m8s to 0.8s on listing 100 listeners08:39
rm_workit's been ... a long time since I actually booted up n-lbaas in a stack08:39
rm_worki have no idea what it returns08:39
cgoncalvesrm_work, not on list all, no08:39
rm_workcgoncalves: lolwut08:39
rm_workthat's a pretty big difference... just from doing a direct model translation instead of using an intermediary model class?08:40
cgoncalvesyes08:41
rm_workmaybe i can look at that...08:41
rm_workwill see what michael thinks about the RFE thing in the morning08:41
rm_worki could care less what we merge in that repo, but it might set a precedent08:41
rm_work*couldn't care less08:42
nmagnezirm_work, it's not a precedent if we see it as a bugfix. and when you think about it, it08:42
nmagneziit is not an actual feature we add here08:42
nmagnezi(if we decide that we add this)08:42
rm_workyeah08:42
rm_worki mean, i agree08:43
rm_worki think08:43
rm_worki also feel like missing project_id is a bug <_<08:43
rm_workbut anywho, bbl08:43
nmagnezirm_work, good night :)08:43
cgoncalvesmissing project_id is a bug, definitely08:44
cgoncalvestake care :)08:44
rm_workyeah and the failing test is a dumb one, and could just be fixed08:44
cgoncalves+108:44
*** lxkong has quit IRC09:09
*** phuoc_ has joined #openstack-lbaas09:11
*** phuoc has quit IRC09:14
*** issp has joined #openstack-lbaas09:28
*** lxkong has joined #openstack-lbaas09:32
*** kobis has quit IRC09:40
*** jiteka has quit IRC09:48
*** jiteka- has quit IRC09:48
*** JudeC has quit IRC09:49
*** eandersson has quit IRC09:50
*** blake has quit IRC10:03
*** kobis has joined #openstack-lbaas10:20
openstackgerritMerged openstack/octavia master: Implement provider drivers - Cleanup  https://review.openstack.org/56743110:31
openstackgerritMerged openstack/octavia master: Providers: propose changes to API  https://review.openstack.org/57145310:31
*** rcernin_ has quit IRC10:42
*** links has quit IRC11:09
*** atoth has joined #openstack-lbaas11:16
*** links has joined #openstack-lbaas11:25
*** yamamoto_ has quit IRC11:29
*** yamamoto has joined #openstack-lbaas11:35
*** AlexeyAbashkin has quit IRC11:36
*** AlexeyAbashkin has joined #openstack-lbaas11:46
*** longkb1 has quit IRC11:47
*** yamamoto has quit IRC11:58
*** fnaval has joined #openstack-lbaas12:15
*** JudeC has joined #openstack-lbaas12:18
*** jiteka has joined #openstack-lbaas12:19
*** eandersson has joined #openstack-lbaas12:19
*** jitek4 has joined #openstack-lbaas12:20
*** amuller has joined #openstack-lbaas12:29
*** yamamoto has joined #openstack-lbaas12:44
*** yamamoto has quit IRC13:44
*** kobis has quit IRC13:53
*** amuller has quit IRC14:04
*** amuller has joined #openstack-lbaas14:05
*** jiteka has quit IRC14:44
*** jiteka has joined #openstack-lbaas14:44
*** yamamoto has joined #openstack-lbaas14:45
*** jitek4 has quit IRC14:45
*** JudeC has quit IRC14:45
*** eandersson_ has joined #openstack-lbaas14:45
*** eandersson has quit IRC14:45
*** kobis has joined #openstack-lbaas14:46
*** ivve has joined #openstack-lbaas14:46
*** jiteka- has joined #openstack-lbaas14:49
*** JudeC has joined #openstack-lbaas14:50
*** yamamoto has quit IRC14:51
*** yamamoto has joined #openstack-lbaas14:56
*** yamamoto has quit IRC15:01
*** pcaruana has quit IRC15:05
cgoncalvesjohnsom, good day :)15:15
johnsomMorning..  lol15:16
cgoncalvesthoughts on ^^ (improve speed of loading $resource from DB")15:16
johnsomI haven't had a chance to test or detail review.  I do think this can qualify as a bug fix. I just really want to have stories attached to anything we merge on neutron-lbaas.15:17
johnsomEspecially now that we have code that depends on stability in neutron-lbaas....  (gates and migration tools)15:17
cgoncalvesok. FWIW I tested it and it worked15:19
cgoncalvestested on a newton release (so backport also works)15:19
johnsomha, ok.  Is this a priority patch for you?15:20
cgoncalvesnot super urgent. I guess I could wait for your thorough review some time this week? :)15:22
johnsomYeah, just trying prioritize work15:23
cgoncalvessure. I'll wait and ping you by end of week or next15:24
johnsomPlease don't wait for my review, all reviews help the process.  grin15:24
cgoncalvesI've already reviewed :) I left a comment that perhaps it would be best to squash https://review.openstack.org/570986 with https://review.openstack.org/56836115:25
cgoncalvesalso, listeners list also take much time. similar approach fixes the issue, i can confirm that much (drafted local patch)15:26
*** yamamoto has joined #openstack-lbaas15:58
*** yamamoto has quit IRC16:03
*** links has quit IRC16:03
*** harlowja has joined #openstack-lbaas16:28
*** yboaron has joined #openstack-lbaas16:33
*** issp has quit IRC16:44
*** sshank has joined #openstack-lbaas16:44
*** harlowja has quit IRC16:45
*** yamamoto has joined #openstack-lbaas16:50
*** rpittau has quit IRC16:57
*** yamamoto has quit IRC17:00
*** kobis has quit IRC17:01
*** JudeC_ has joined #openstack-lbaas17:08
*** sshank has quit IRC17:13
*** sshank has joined #openstack-lbaas17:19
*** ivve has quit IRC17:25
*** AlexeyAbashkin has quit IRC17:28
*** isssp has joined #openstack-lbaas17:35
*** ispp has quit IRC17:40
cgoncalvesjohnsom, please let me know in case you any idea for why the grenade job started to fail on post-upgrade for no apparent reason.17:42
cgoncalvesI tried to run reproduce.sh from job run artifacts. sadly that script is old and doesn't work on zuulv317:43
cgoncalvesI'm trying running grenade manually. last run failed on start glance api :/17:44
rm_work:(17:46
*** kobis has joined #openstack-lbaas17:54
*** yamamoto has joined #openstack-lbaas17:56
*** yamamoto has quit IRC18:02
johnsomcgoncalves Hmm, ok.  I saw that it started to fail, but didn't dig too deep.  It was at the last communication test right?18:03
cgoncalvesjohnsom, yes18:04
johnsomLet me dig into the logs a bit and see what I find.  I know the reproduce.sh stuff doesn't work anymore. You should still be able to run through it by hand, but that will be tedious18:11
*** kobis has quit IRC18:16
*** nmanos has quit IRC18:17
johnsomcgoncalves http://logs.openstack.org/54/549654/34/check/octavia-grenade/1263678/logs/screen-o-hm.txt.gz#_Jun_04_16_01_14_87937418:19
cgoncalveshow did I miss that... oO18:20
johnsomSo, it looks like the HM is not restarting (we fixed this, but maybe didn't backport?) which leads to HM failing over the amp, which leads to timeouts firing it looks like. It never connects back to the amp18:20
johnsomI bet it's the systemd shutdown timeout killing the in-progress failover18:21
johnsomThis patch probably needs to be backported: https://review.openstack.org/#/c/568711/18:23
johnsomIt might be a bit messy to do so, but it's needed18:23
cgoncalveswhile backporting ^ I ran into a merge conflict and that reminded me to backport another patch so: https://review.openstack.org/#/c/572516/18:31
*** kobis has joined #openstack-lbaas18:32
cgoncalveshttps://review.openstack.org/#/c/572519/ on top of ^18:35
johnsomcgoncalves Can those go back to Pike too?  I would like to add grenade from Pike to Queens as well so we can demonstrate a fast-forward-upgrade capability.  I.e. upgrade pike to queens, then queens to rocky, etc.18:36
*** sshank has quit IRC18:55
*** yamamoto has joined #openstack-lbaas18:58
*** links has joined #openstack-lbaas18:59
*** yamamoto has quit IRC19:03
kobishi, what's the status of flavors implementation? is it just missing from the octavia client? is it in use anywhere?19:08
xgerman_kobi net yet imolemented at all - but coming soon19:12
johnsomkobis: it is still WIP.  A follow on to the driver work19:12
kobisCol19:13
kobiscool19:13
*** AlexeyAbashkin has joined #openstack-lbaas19:19
*** Alexey_Abashkin has joined #openstack-lbaas19:22
*** AlexeyAbashkin has quit IRC19:23
*** Alexey_Abashkin is now known as AlexeyAbashkin19:23
*** AlexeyAbashkin has quit IRC19:38
*** amuller has quit IRC19:43
*** links has quit IRC19:46
*** kobis has quit IRC19:52
*** yamamoto has joined #openstack-lbaas19:59
*** yamamoto has quit IRC20:05
*** yboaron has quit IRC20:05
openstackgerritAdam Harwell proposed openstack/octavia master: Add usage admin resource  https://review.openstack.org/55754820:29
openstackgerritAdam Harwell proposed openstack/octavia master: Fix amp failover where failover already failed  https://review.openstack.org/54898920:34
openstackgerritAdam Harwell proposed openstack/octavia master: Experimental multi-az support  https://review.openstack.org/55896220:34
rm_workone of these days, the pep8 tests taking longer to run than the functional tests is going to make y head explode20:53
openstackgerritAdam Harwell proposed openstack/octavia master: WIP: AZ Evacuation resource  https://review.openstack.org/55987320:55
johnsomYes!20:55
openstackgerritAdam Harwell proposed openstack/octavia master: WIP: Floating IP Network Driver (spans L3s)  https://review.openstack.org/43561220:55
*** kobis has joined #openstack-lbaas20:55
*** kobis has quit IRC20:55
johnsomrm_work Sorry to nit-pick a bit on https://review.openstack.org/#/c/54898920:56
johnsomBut I think they are quick fixes that add value for future generations....20:56
rm_workhey i am just super happy you finally reviewed it! :P20:58
rm_workI'll take whatever20:59
johnsomHey, in fairness I previously reviewed that patch with comments as welll20:59
*** SumitNaiksatam has joined #openstack-lbaas21:00
*** yamamoto has joined #openstack-lbaas21:01
rm_workah i guess you did a while back21:04
rm_workanywho, good comments, both resolved, just running tests first21:04
*** yamamoto has quit IRC21:05
openstackgerritAdam Harwell proposed openstack/octavia master: Fix amp failover where failover already failed  https://review.openstack.org/54898921:10
rm_workjohnsom: fixed ;P21:10
rm_workxgerman_: ^^ both changes were non-functional, so you should be able to +2 again :)21:10
xgerman_ok21:10
rm_workjohnsom just being nitpicky today21:11
rm_workwhich is fine :P21:11
xgerman_+121:11
rm_workthat commit message is full of fail tho :P21:15
rm_work(literally and figuratively)21:16
johnsomHa, well, yeah, it's in the pipeline now....21:16
rm_work:P21:16
rm_workforever immortalized21:16
*** SumitNaiksatam has quit IRC21:19
openstackgerritMichael Johnson proposed openstack/octavia master: Neutron-LBaaS to Octavia migration tool  https://review.openstack.org/55442021:33
*** yamamoto has joined #openstack-lbaas22:02
*** atoth has quit IRC22:03
*** fnaval has quit IRC22:06
*** yamamoto has quit IRC22:06
*** rcernin has joined #openstack-lbaas22:25
*** kobis has joined #openstack-lbaas22:26
*** kobis has quit IRC22:26
*** kobis has joined #openstack-lbaas22:45
*** kobis has quit IRC22:55
*** yamamoto has joined #openstack-lbaas23:03
*** kobis has joined #openstack-lbaas23:03
*** yamamoto has quit IRC23:07
*** threestrands has joined #openstack-lbaas23:08
*** harlowja has joined #openstack-lbaas23:10
*** kobis has quit IRC23:20
*** kobis has joined #openstack-lbaas23:31
*** kobis has quit IRC23:37
*** annp has quit IRC23:38
*** annp has joined #openstack-lbaas23:38
*** kobis has joined #openstack-lbaas23:38
*** kobis has quit IRC23:49

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!