rm_work | xgerman_ / dayou_ / nmagnezi around? | 00:12 |
---|---|---|
dayou_ | rm_work, yep, sir | 00:22 |
openstackgerrit | Jacky Hu proposed openstack/octavia master: Implement provider drivers - L7 Rules https://review.openstack.org/567073 | 00:28 |
johnsom | dayou_ Thanks! | 00:29 |
dayou_ | My pleasure! | 00:29 |
*** longkb1 has joined #openstack-lbaas | 00:35 | |
*** rcernin_ has joined #openstack-lbaas | 00:37 | |
*** rcernin has quit IRC | 00:37 | |
rm_work | johnsom: looks like you haven't commented on the cleanup yet? | 00:49 |
rm_work | anyway, cool, we got the majority in today | 00:51 |
*** hongbin has joined #openstack-lbaas | 00:57 | |
*** harlowja has quit IRC | 01:07 | |
johnsom | Yeah, will try to hit it after dinner. | 01:09 |
johnsom | Made some progress on the migration tool today. | 01:10 |
*** kiennt26 has joined #openstack-lbaas | 01:10 | |
openstackgerrit | Merged openstack/octavia master: Implement provider drivers - Health Monitor https://review.openstack.org/567037 | 01:57 |
openstackgerrit | Merged openstack/octavia master: Implement provider drivers - L7 Policy https://review.openstack.org/567059 | 01:57 |
openstackgerrit | Merged openstack/octavia-tempest-plugin master: Create api+scenario tests for l7rules https://review.openstack.org/570485 | 01:57 |
openstackgerrit | Merged openstack/octavia master: Implement provider drivers - L7 Rules https://review.openstack.org/567073 | 01:57 |
johnsom | Weee | 02:03 |
*** fnaval has joined #openstack-lbaas | 02:09 | |
*** fnaval has quit IRC | 02:10 | |
*** yamamoto has joined #openstack-lbaas | 02:15 | |
*** kiennt26 has quit IRC | 02:28 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Implement provider drivers - Cleanup https://review.openstack.org/567431 | 02:32 |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Implement provider drivers - Cleanup https://review.openstack.org/567431 | 02:35 |
johnsom | rm_work Ok, fixed up cleanup | 02:38 |
*** kiennt26 has joined #openstack-lbaas | 02:43 | |
openstackgerrit | Merged openstack/octavia-tempest-plugin master: Create scenario tests for amphora https://review.openstack.org/571251 | 03:23 |
*** gans has joined #openstack-lbaas | 03:34 | |
lxkong | johnsom: hi, did you see my reply for https://review.openstack.org/#/c/571333/? not sure if i understand you correctly | 03:41 |
*** gans has quit IRC | 04:04 | |
*** links has joined #openstack-lbaas | 04:22 | |
*** kiennt26 has quit IRC | 04:29 | |
johnsom | lxkong Ok, thanks for the comment. I have +2'd it now | 04:29 |
lxkong | johnsom: thanks! Is it possible to backport to stable/pike after it's merged? | 04:30 |
johnsom | yes, I think this is a valid bug for backport | 04:30 |
lxkong | cool, I can do that | 04:30 |
johnsom | Please wait until it merges to cherrypick | 04:30 |
lxkong | yeah, sure | 04:31 |
johnsom | Otherwise, yeah, we can go as far back as Ocata | 04:31 |
johnsom | lxkong Do you need a stable/Pike release or is the backport your priority? | 04:31 |
openstackgerrit | Adit Sarfaty proposed openstack/octavia master: Providers: propose changes to API https://review.openstack.org/571453 | 04:32 |
openstackgerrit | Adit Sarfaty proposed openstack/octavia master: Use object instead of object id in the drivers delete callbacks https://review.openstack.org/571974 | 04:32 |
lxkong | we don't need a new tag for release, because we are using the branch directly to build our internal package | 04:33 |
johnsom | Ok, cool. Just wanted to know if I needed to prioritize a release for you. | 04:40 |
*** yboaron has joined #openstack-lbaas | 04:42 | |
*** sapd has quit IRC | 04:45 | |
*** sapd has joined #openstack-lbaas | 04:45 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 05:00 | |
*** kobis has joined #openstack-lbaas | 05:02 | |
*** hongbin has quit IRC | 05:06 | |
*** kobis has quit IRC | 05:13 | |
*** AlexeyAbashkin has quit IRC | 05:17 | |
*** nmanos has joined #openstack-lbaas | 05:19 | |
*** nmanos has quit IRC | 05:33 | |
*** nmanos has joined #openstack-lbaas | 05:34 | |
*** kobis has joined #openstack-lbaas | 05:34 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 05:41 | |
*** AlexeyAbashkin has quit IRC | 05:44 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 05:44 | |
*** AlexeyAbashkin has quit IRC | 05:59 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Neutron-LBaaS to Octavia migration tool https://review.openstack.org/554420 | 06:01 |
*** links has quit IRC | 06:08 | |
*** ispp has joined #openstack-lbaas | 06:12 | |
*** isssp has quit IRC | 06:14 | |
openstackgerrit | Merged openstack/octavia master: Use HMAC.hexdigest to avoid non-ascii characters for package data https://review.openstack.org/571333 | 06:21 |
*** links has joined #openstack-lbaas | 06:26 | |
*** pcaruana has joined #openstack-lbaas | 06:54 | |
*** yamamoto_ has joined #openstack-lbaas | 06:57 | |
*** yamamoto has quit IRC | 07:00 | |
*** pcaruana is now known as pcaruana|worksho | 07:03 | |
nmagnezi | rm_work, o/ | 07:45 |
rm_work | o/ | 07:45 |
*** pcaruana|worksho is now known as pcaruana | 07:50 | |
nmagnezi | rm_work, you were looking for me | 07:54 |
*** AlexeyAbashkin has joined #openstack-lbaas | 08:05 | |
*** blake has joined #openstack-lbaas | 08:07 | |
*** devfaz_ has quit IRC | 08:13 | |
*** devfaz has joined #openstack-lbaas | 08:15 | |
*** yboaron has quit IRC | 08:20 | |
rm_work | yeah, needed someone to merge a couple things :P | 08:24 |
rm_work | but someone got them | 08:24 |
rm_work | also making sure you are alive, haven't seen you reviewing or posting stuff in a while | 08:25 |
rm_work | we miss both you and carlos :P | 08:25 |
cgoncalves | hello fellas! | 08:28 |
cgoncalves | rm_work, would you agree on squashing https://review.openstack.org/#/c/568361/ with https://review.openstack.org/#/c/570986/ ? | 08:29 |
cgoncalves | pools patch has listeners patch (unmerged) as parent and both are very similar patches | 08:30 |
cgoncalves | I am okay with having them split still | 08:31 |
cgoncalves | at least a 3rd patch also needs to be written for listeners -- I have it ready for review in case we decide to have multiple patches | 08:32 |
*** crazik_ has left #openstack-lbaas | 08:33 | |
cgoncalves | nmagnezi, ^ | 08:33 |
openstackgerrit | Adit Sarfaty proposed openstack/octavia master: Use object instead of object id in the drivers delete callbacks https://review.openstack.org/571974 | 08:34 |
rm_work | cgoncalves: what repo is that? i don't know what that repo is <_< | 08:35 |
openstackgerrit | Adit Sarfaty proposed openstack/octavia master: Add baseline object in the drivers update callbacks https://review.openstack.org/572303 | 08:36 |
cgoncalves | rm_work, you got me for a moment xD | 08:36 |
rm_work | :P | 08:36 |
nmagnezi | rm_work, yeah sorry, we where very busy with internal stuff, but now things are going back to normal :) | 08:36 |
rm_work | cool cool | 08:36 |
nmagnezi | cgoncalves, we first need to see that johnsom is okay with having this is as a bugfix and not as an RFE | 08:36 |
nmagnezi | rm_work, btw i did review some of your patches on Sunday | 08:37 |
nmagnezi | :) | 08:37 |
cgoncalves | nmagnezi, IMO it's a scalability bug | 08:38 |
rm_work | i'm a LITTLE skeptical, as i've seen those queries tweaked a few times now and it's never really done anything useful that i've seen, and i don't really understand how what they're doing could affect the speed very much at all... but... i guess you claim to be seeing results | 08:38 |
rm_work | so... *shrug* | 08:38 |
cgoncalves | I also found that project_id is not being returned by the API while it should according to neutron-lib api-ref | 08:38 |
rm_work | yes, we should return project_id and tenant_id IIRC | 08:38 |
rm_work | does it not do that? | 08:38 |
cgoncalves | rm_work, from 1m8s to 0.8s on listing 100 listeners | 08:39 |
rm_work | it's been ... a long time since I actually booted up n-lbaas in a stack | 08:39 |
rm_work | i have no idea what it returns | 08:39 |
cgoncalves | rm_work, not on list all, no | 08:39 |
rm_work | cgoncalves: lolwut | 08:39 |
rm_work | that's a pretty big difference... just from doing a direct model translation instead of using an intermediary model class? | 08:40 |
cgoncalves | yes | 08:41 |
rm_work | maybe i can look at that... | 08:41 |
rm_work | will see what michael thinks about the RFE thing in the morning | 08:41 |
rm_work | i could care less what we merge in that repo, but it might set a precedent | 08:41 |
rm_work | *couldn't care less | 08:42 |
nmagnezi | rm_work, it's not a precedent if we see it as a bugfix. and when you think about it, it | 08:42 |
nmagnezi | it is not an actual feature we add here | 08:42 |
nmagnezi | (if we decide that we add this) | 08:42 |
rm_work | yeah | 08:42 |
rm_work | i mean, i agree | 08:43 |
rm_work | i think | 08:43 |
rm_work | i also feel like missing project_id is a bug <_< | 08:43 |
rm_work | but anywho, bbl | 08:43 |
nmagnezi | rm_work, good night :) | 08:43 |
cgoncalves | missing project_id is a bug, definitely | 08:44 |
cgoncalves | take care :) | 08:44 |
rm_work | yeah and the failing test is a dumb one, and could just be fixed | 08:44 |
cgoncalves | +1 | 08:44 |
*** lxkong has quit IRC | 09:09 | |
*** phuoc_ has joined #openstack-lbaas | 09:11 | |
*** phuoc has quit IRC | 09:14 | |
*** issp has joined #openstack-lbaas | 09:28 | |
*** lxkong has joined #openstack-lbaas | 09:32 | |
*** kobis has quit IRC | 09:40 | |
*** jiteka has quit IRC | 09:48 | |
*** jiteka- has quit IRC | 09:48 | |
*** JudeC has quit IRC | 09:49 | |
*** eandersson has quit IRC | 09:50 | |
*** blake has quit IRC | 10:03 | |
*** kobis has joined #openstack-lbaas | 10:20 | |
openstackgerrit | Merged openstack/octavia master: Implement provider drivers - Cleanup https://review.openstack.org/567431 | 10:31 |
openstackgerrit | Merged openstack/octavia master: Providers: propose changes to API https://review.openstack.org/571453 | 10:31 |
*** rcernin_ has quit IRC | 10:42 | |
*** links has quit IRC | 11:09 | |
*** atoth has joined #openstack-lbaas | 11:16 | |
*** links has joined #openstack-lbaas | 11:25 | |
*** yamamoto_ has quit IRC | 11:29 | |
*** yamamoto has joined #openstack-lbaas | 11:35 | |
*** AlexeyAbashkin has quit IRC | 11:36 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 11:46 | |
*** longkb1 has quit IRC | 11:47 | |
*** yamamoto has quit IRC | 11:58 | |
*** fnaval has joined #openstack-lbaas | 12:15 | |
*** JudeC has joined #openstack-lbaas | 12:18 | |
*** jiteka has joined #openstack-lbaas | 12:19 | |
*** eandersson has joined #openstack-lbaas | 12:19 | |
*** jitek4 has joined #openstack-lbaas | 12:20 | |
*** amuller has joined #openstack-lbaas | 12:29 | |
*** yamamoto has joined #openstack-lbaas | 12:44 | |
*** yamamoto has quit IRC | 13:44 | |
*** kobis has quit IRC | 13:53 | |
*** amuller has quit IRC | 14:04 | |
*** amuller has joined #openstack-lbaas | 14:05 | |
*** jiteka has quit IRC | 14:44 | |
*** jiteka has joined #openstack-lbaas | 14:44 | |
*** yamamoto has joined #openstack-lbaas | 14:45 | |
*** jitek4 has quit IRC | 14:45 | |
*** JudeC has quit IRC | 14:45 | |
*** eandersson_ has joined #openstack-lbaas | 14:45 | |
*** eandersson has quit IRC | 14:45 | |
*** kobis has joined #openstack-lbaas | 14:46 | |
*** ivve has joined #openstack-lbaas | 14:46 | |
*** jiteka- has joined #openstack-lbaas | 14:49 | |
*** JudeC has joined #openstack-lbaas | 14:50 | |
*** yamamoto has quit IRC | 14:51 | |
*** yamamoto has joined #openstack-lbaas | 14:56 | |
*** yamamoto has quit IRC | 15:01 | |
*** pcaruana has quit IRC | 15:05 | |
cgoncalves | johnsom, good day :) | 15:15 |
johnsom | Morning.. lol | 15:16 |
cgoncalves | thoughts on ^^ (improve speed of loading $resource from DB") | 15:16 |
johnsom | I haven't had a chance to test or detail review. I do think this can qualify as a bug fix. I just really want to have stories attached to anything we merge on neutron-lbaas. | 15:17 |
johnsom | Especially now that we have code that depends on stability in neutron-lbaas.... (gates and migration tools) | 15:17 |
cgoncalves | ok. FWIW I tested it and it worked | 15:19 |
cgoncalves | tested on a newton release (so backport also works) | 15:19 |
johnsom | ha, ok. Is this a priority patch for you? | 15:20 |
cgoncalves | not super urgent. I guess I could wait for your thorough review some time this week? :) | 15:22 |
johnsom | Yeah, just trying prioritize work | 15:23 |
cgoncalves | sure. I'll wait and ping you by end of week or next | 15:24 |
johnsom | Please don't wait for my review, all reviews help the process. grin | 15:24 |
cgoncalves | I've already reviewed :) I left a comment that perhaps it would be best to squash https://review.openstack.org/570986 with https://review.openstack.org/568361 | 15:25 |
cgoncalves | also, listeners list also take much time. similar approach fixes the issue, i can confirm that much (drafted local patch) | 15:26 |
*** yamamoto has joined #openstack-lbaas | 15:58 | |
*** yamamoto has quit IRC | 16:03 | |
*** links has quit IRC | 16:03 | |
*** harlowja has joined #openstack-lbaas | 16:28 | |
*** yboaron has joined #openstack-lbaas | 16:33 | |
*** issp has quit IRC | 16:44 | |
*** sshank has joined #openstack-lbaas | 16:44 | |
*** harlowja has quit IRC | 16:45 | |
*** yamamoto has joined #openstack-lbaas | 16:50 | |
*** rpittau has quit IRC | 16:57 | |
*** yamamoto has quit IRC | 17:00 | |
*** kobis has quit IRC | 17:01 | |
*** JudeC_ has joined #openstack-lbaas | 17:08 | |
*** sshank has quit IRC | 17:13 | |
*** sshank has joined #openstack-lbaas | 17:19 | |
*** ivve has quit IRC | 17:25 | |
*** AlexeyAbashkin has quit IRC | 17:28 | |
*** isssp has joined #openstack-lbaas | 17:35 | |
*** ispp has quit IRC | 17:40 | |
cgoncalves | johnsom, please let me know in case you any idea for why the grenade job started to fail on post-upgrade for no apparent reason. | 17:42 |
cgoncalves | I tried to run reproduce.sh from job run artifacts. sadly that script is old and doesn't work on zuulv3 | 17:43 |
cgoncalves | I'm trying running grenade manually. last run failed on start glance api :/ | 17:44 |
rm_work | :( | 17:46 |
*** kobis has joined #openstack-lbaas | 17:54 | |
*** yamamoto has joined #openstack-lbaas | 17:56 | |
*** yamamoto has quit IRC | 18:02 | |
johnsom | cgoncalves Hmm, ok. I saw that it started to fail, but didn't dig too deep. It was at the last communication test right? | 18:03 |
cgoncalves | johnsom, yes | 18:04 |
johnsom | Let me dig into the logs a bit and see what I find. I know the reproduce.sh stuff doesn't work anymore. You should still be able to run through it by hand, but that will be tedious | 18:11 |
*** kobis has quit IRC | 18:16 | |
*** nmanos has quit IRC | 18:17 | |
johnsom | cgoncalves http://logs.openstack.org/54/549654/34/check/octavia-grenade/1263678/logs/screen-o-hm.txt.gz#_Jun_04_16_01_14_879374 | 18:19 |
cgoncalves | how did I miss that... oO | 18:20 |
johnsom | So, it looks like the HM is not restarting (we fixed this, but maybe didn't backport?) which leads to HM failing over the amp, which leads to timeouts firing it looks like. It never connects back to the amp | 18:20 |
johnsom | I bet it's the systemd shutdown timeout killing the in-progress failover | 18:21 |
johnsom | This patch probably needs to be backported: https://review.openstack.org/#/c/568711/ | 18:23 |
johnsom | It might be a bit messy to do so, but it's needed | 18:23 |
cgoncalves | while backporting ^ I ran into a merge conflict and that reminded me to backport another patch so: https://review.openstack.org/#/c/572516/ | 18:31 |
*** kobis has joined #openstack-lbaas | 18:32 | |
cgoncalves | https://review.openstack.org/#/c/572519/ on top of ^ | 18:35 |
johnsom | cgoncalves Can those go back to Pike too? I would like to add grenade from Pike to Queens as well so we can demonstrate a fast-forward-upgrade capability. I.e. upgrade pike to queens, then queens to rocky, etc. | 18:36 |
*** sshank has quit IRC | 18:55 | |
*** yamamoto has joined #openstack-lbaas | 18:58 | |
*** links has joined #openstack-lbaas | 18:59 | |
*** yamamoto has quit IRC | 19:03 | |
kobis | hi, what's the status of flavors implementation? is it just missing from the octavia client? is it in use anywhere? | 19:08 |
xgerman_ | kobi net yet imolemented at all - but coming soon | 19:12 |
johnsom | kobis: it is still WIP. A follow on to the driver work | 19:12 |
kobis | Col | 19:13 |
kobis | cool | 19:13 |
*** AlexeyAbashkin has joined #openstack-lbaas | 19:19 | |
*** Alexey_Abashkin has joined #openstack-lbaas | 19:22 | |
*** AlexeyAbashkin has quit IRC | 19:23 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 19:23 | |
*** AlexeyAbashkin has quit IRC | 19:38 | |
*** amuller has quit IRC | 19:43 | |
*** links has quit IRC | 19:46 | |
*** kobis has quit IRC | 19:52 | |
*** yamamoto has joined #openstack-lbaas | 19:59 | |
*** yamamoto has quit IRC | 20:05 | |
*** yboaron has quit IRC | 20:05 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add usage admin resource https://review.openstack.org/557548 | 20:29 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Fix amp failover where failover already failed https://review.openstack.org/548989 | 20:34 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Experimental multi-az support https://review.openstack.org/558962 | 20:34 |
rm_work | one of these days, the pep8 tests taking longer to run than the functional tests is going to make y head explode | 20:53 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: WIP: AZ Evacuation resource https://review.openstack.org/559873 | 20:55 |
johnsom | Yes! | 20:55 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: WIP: Floating IP Network Driver (spans L3s) https://review.openstack.org/435612 | 20:55 |
*** kobis has joined #openstack-lbaas | 20:55 | |
*** kobis has quit IRC | 20:55 | |
johnsom | rm_work Sorry to nit-pick a bit on https://review.openstack.org/#/c/548989 | 20:56 |
johnsom | But I think they are quick fixes that add value for future generations.... | 20:56 |
rm_work | hey i am just super happy you finally reviewed it! :P | 20:58 |
rm_work | I'll take whatever | 20:59 |
johnsom | Hey, in fairness I previously reviewed that patch with comments as welll | 20:59 |
*** SumitNaiksatam has joined #openstack-lbaas | 21:00 | |
*** yamamoto has joined #openstack-lbaas | 21:01 | |
rm_work | ah i guess you did a while back | 21:04 |
rm_work | anywho, good comments, both resolved, just running tests first | 21:04 |
*** yamamoto has quit IRC | 21:05 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Fix amp failover where failover already failed https://review.openstack.org/548989 | 21:10 |
rm_work | johnsom: fixed ;P | 21:10 |
rm_work | xgerman_: ^^ both changes were non-functional, so you should be able to +2 again :) | 21:10 |
xgerman_ | ok | 21:10 |
rm_work | johnsom just being nitpicky today | 21:11 |
rm_work | which is fine :P | 21:11 |
xgerman_ | +1 | 21:11 |
rm_work | that commit message is full of fail tho :P | 21:15 |
rm_work | (literally and figuratively) | 21:16 |
johnsom | Ha, well, yeah, it's in the pipeline now.... | 21:16 |
rm_work | :P | 21:16 |
rm_work | forever immortalized | 21:16 |
*** SumitNaiksatam has quit IRC | 21:19 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Neutron-LBaaS to Octavia migration tool https://review.openstack.org/554420 | 21:33 |
*** yamamoto has joined #openstack-lbaas | 22:02 | |
*** atoth has quit IRC | 22:03 | |
*** fnaval has quit IRC | 22:06 | |
*** yamamoto has quit IRC | 22:06 | |
*** rcernin has joined #openstack-lbaas | 22:25 | |
*** kobis has joined #openstack-lbaas | 22:26 | |
*** kobis has quit IRC | 22:26 | |
*** kobis has joined #openstack-lbaas | 22:45 | |
*** kobis has quit IRC | 22:55 | |
*** yamamoto has joined #openstack-lbaas | 23:03 | |
*** kobis has joined #openstack-lbaas | 23:03 | |
*** yamamoto has quit IRC | 23:07 | |
*** threestrands has joined #openstack-lbaas | 23:08 | |
*** harlowja has joined #openstack-lbaas | 23:10 | |
*** kobis has quit IRC | 23:20 | |
*** kobis has joined #openstack-lbaas | 23:31 | |
*** kobis has quit IRC | 23:37 | |
*** annp has quit IRC | 23:38 | |
*** annp has joined #openstack-lbaas | 23:38 | |
*** kobis has joined #openstack-lbaas | 23:38 | |
*** kobis has quit IRC | 23:49 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!