| *** dayou_ has joined #openstack-lbaas | 00:09 | |
| rm_work | cool! thanks | 00:12 |
|---|---|---|
| *** longkb has joined #openstack-lbaas | 00:32 | |
| dayou | I have one question, so if we have provider landed, can each company implement its own provider such as xxx company's provider? | 00:32 |
| johnsom | Yes | 00:32 |
| johnsom | we have provider "amphora", F5 networks could have "F5" | 00:33 |
| rm_work | or "banana" for all we care :P | 00:33 |
| johnsom | The operator can override the names if they need to | 00:33 |
| dayou | That sounds cool, or chocolate | 00:33 |
| rm_work | really those belong as flavors <_< | 00:34 |
| *** fnaval has quit IRC | 00:34 | |
| johnsom | I thought it, but didn't say it | 00:35 |
| bzhao__ | hi guys, could you please have a quick look about udp patches if you have time? Thank you. https://review.openstack.org/#/c/525420/ https://review.openstack.org/#/c/529651/ | 00:36 |
| johnsom | bzhao__ Yes! I am so sorry I haven't got to it yet. I got wrapped up in writing the driver support. | 00:36 |
| johnsom | These few coverage branches are taking much longer than I planned | 00:37 |
| bzhao__ | No matter. It's my glad that octavia grow so quick. :). | 00:38 |
| johnsom | Ha, yeah, there has been a lot of work over these last few weeks | 00:39 |
| *** fnaval has joined #openstack-lbaas | 00:41 | |
| bzhao__ | I saw. Octavia is still moving quickly. :) | 00:41 |
| *** fnaval has quit IRC | 00:47 | |
| *** fnaval has joined #openstack-lbaas | 00:47 | |
| *** fnaval has quit IRC | 00:52 | |
| rm_work | we're trying :) | 01:02 |
| rm_work | yeah unfortunately UDP is just a lower priority than Providers (and the associated testing) since we NEED to get that done this cycle ASAP so we can really fully deprecate neutron-lbaas | 01:03 |
| johnsom | Yep, and we need to un-block vendors | 01:03 |
| rm_work | yes | 01:03 |
| rm_work | so unfortunately, even though I would love to get UDP support in, realistically it's just going to have to wait on this provider stuff | 01:04 |
| johnsom | I'm trying to multi-task, so alternating some reviews in, but yeah, focus at this moment is providers | 01:05 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Implement provider drivers - Cleanup https://review.openstack.org/567431 | 01:06 |
| *** harlowja has joined #openstack-lbaas | 01:06 | |
| *** ianychoi_ has quit IRC | 01:14 | |
| johnsom | Ok, I have no idea what the heck is wrong with cover and that to_dict(). I can put logging in and the line is clearly getting hit with the test, but still shows red | 01:19 |
| rm_work | push it up | 01:25 |
| rm_work | link me to the line | 01:25 |
| rm_work | i'll debug through and look | 01:25 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Implement provider drivers - Cleanup https://review.openstack.org/567431 | 01:25 |
| johnsom | http://logs.openstack.org/31/567431/4/check/openstack-tox-cover/d0e7a48/cover/octavia_api_drivers_data_models_py.html#n73 | 01:25 |
| johnsom | That red | 01:25 |
| johnsom | This test fires it: octavia.tests.unit.api.drivers.test_data_models.TestProviderDataModels.test_to_dict_partial | 01:26 |
| rm_work | kk | 01:26 |
| johnsom | Like a lot | 01:26 |
| openstackgerrit | Merged openstack/octavia master: Creates provider driver base class and exceptions https://review.openstack.org/558013 | 01:55 |
| openstackgerrit | Merged openstack/octavia master: Create noop provider driver and data model https://review.openstack.org/558320 | 01:55 |
| johnsom | Wahoo | 01:56 |
| johnsom | Guess I need to get on those comments tomorrow | 01:56 |
| rm_work | johnsom: erm yeah, so ... | 02:00 |
| rm_work | if you expect `test_to_dict_partial` to hit line 73, it's not going to | 02:00 |
| rm_work | but.... | 02:00 |
| rm_work | but WHY is confusing me | 02:01 |
| johnsom | No, put a log message there | 02:01 |
| johnsom | It hits it a bunch due to all of the unsets | 02:02 |
| rm_work | ah yeah so i put some other stuff there | 02:03 |
| rm_work | and the debug will go there | 02:03 |
| rm_work | but if it's just a continue... it won't step me down to that line | 02:03 |
| rm_work | it's super weird | 02:03 |
| *** harlowja has quit IRC | 02:07 | |
| rm_work | yeah i think it's a bug in the coverage lib | 02:08 |
| johnsom | Me too | 02:08 |
| rm_work | "cases where CPython's peephole optimizer replaces a jump to a continue with a jump to the top of the loop, so the continue line is never actually executed, even though its effects are seen" | 02:10 |
| rm_work | so not the coverage lib so much | 02:11 |
| rm_work | maybe they could work around it? but ... it's a python oddity | 02:11 |
| rm_work | https://mail.python.org/pipermail/python-ideas/2014-May/027893.html | 02:12 |
| rm_work | https://bugs.python.org/issue2506, | 02:14 |
| *** rcernin has joined #openstack-lbaas | 02:14 | |
| rm_work | lol johnsom: https://github.com/pyca/cryptography/pull/3968/commits/3b585f803891e750d0ca5861b5a29e16b779bc16 | 02:25 |
| rm_work | there you go | 02:26 |
| johnsom | Lol, omg, I don’t think I can stoop to that level for coverage | 02:27 |
| *** ianychoi has joined #openstack-lbaas | 02:29 | |
| rm_work | lol | 02:31 |
| rm_work | anywho, learned a bit about the python compiler today :P | 02:32 |
| rm_work | eugh our exception handling has a tiny gap... | 02:39 |
| rm_work | https://github.com/openstack/octavia/blob/master/octavia/api/v2/controllers/load_balancer.py#L223-L231 | 02:39 |
| rm_work | johnsom: ^^ if neutron fails, we just raise and give the user a 500 with a stacktrace >_> | 02:40 |
| rm_work | was that supposed to be actually *converting* the error to a different exception type that is API-Ready? | 02:40 |
| rm_work | it even says something about API-ready but the exception type of 'e' is definitely not | 02:40 |
| johnsom | It solved the problem I was having with neutron exceptions and 500s | 02:41 |
| johnsom | rm_work: note btw, what it is catching is a network driver exception, not straight from neutron | 02:46 |
| *** fnaval has joined #openstack-lbaas | 02:56 | |
| *** rm_work has quit IRC | 03:13 | |
| *** rm_work has joined #openstack-lbaas | 03:23 | |
| *** dayou_ has quit IRC | 03:53 | |
| rm_work | johnsom: right but a network driver exception IS a 500 | 03:55 |
| rm_work | no? | 03:55 |
| rm_work | so I'm not clear how it would prevent you from getting 500s, when it literally raises an Exception type that is a 500 | 04:05 |
| rm_work | OH, it's translating the code through, is how | 04:06 |
| rm_work | but if the neutron code *is* a 500... | 04:06 |
| rm_work | AHHH also my network-driver isn't copying over the status code anyway <_< so yeah in my case it'd always be a 500 no matter what neutron returns (though in this case, that was still a 500) | 04:12 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: WIP: Floating IP Network Driver (spans L3s) https://review.openstack.org/435612 | 04:13 |
| *** pck has joined #openstack-lbaas | 04:25 | |
| *** pck is now known as pckizer | 04:35 | |
| *** yamamoto has joined #openstack-lbaas | 04:37 | |
| *** yamamoto has quit IRC | 05:31 | |
| *** fnaval has quit IRC | 05:46 | |
| *** yamamoto has joined #openstack-lbaas | 05:46 | |
| *** fnaval has joined #openstack-lbaas | 06:07 | |
| *** fnaval has quit IRC | 06:11 | |
| *** links has joined #openstack-lbaas | 06:31 | |
| *** pcaruana has joined #openstack-lbaas | 06:32 | |
| rm_work | wheee | 06:35 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for pools https://review.openstack.org/565640 | 06:35 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for members https://review.openstack.org/566199 | 06:35 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create basic traffic balancing scenario test https://review.openstack.org/566700 | 06:35 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for healthmonitors https://review.openstack.org/567688 | 06:35 |
| rm_work | ok | 06:35 |
| rm_work | HM List works | 06:35 |
| * rm_work cries | 06:35 | |
| rm_work | now actually the scenario should be easy | 06:35 |
| rm_work | ... tomorrow | 06:35 |
| *** annp has quit IRC | 06:36 | |
| *** annp has joined #openstack-lbaas | 06:36 | |
| *** AlexStaf has quit IRC | 06:51 | |
| *** rpittau has quit IRC | 07:06 | |
| *** dmellado has quit IRC | 07:09 | |
| *** dmellado has joined #openstack-lbaas | 07:10 | |
| *** fnaval has joined #openstack-lbaas | 07:16 | |
| *** rpittau has joined #openstack-lbaas | 07:18 | |
| *** tesseract has joined #openstack-lbaas | 07:20 | |
| *** fnaval has quit IRC | 07:21 | |
| *** ivve has joined #openstack-lbaas | 07:28 | |
| *** yamamoto_ has joined #openstack-lbaas | 07:36 | |
| *** ltomasbo has quit IRC | 07:36 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia-dashboard master: Imported Translations from Zanata https://review.openstack.org/567789 | 07:37 |
| *** yamamoto has quit IRC | 07:39 | |
| *** AlexStaf has joined #openstack-lbaas | 07:55 | |
| *** rcernin has quit IRC | 07:58 | |
| openstackgerrit | lidong proposed openstack/python-octaviaclient master: Update the outdated links https://review.openstack.org/548112 | 08:02 |
| *** AlexStaf has quit IRC | 08:05 | |
| *** salmankhan has joined #openstack-lbaas | 08:26 | |
| *** openstack has joined #openstack-lbaas | 09:29 | |
| *** ChanServ sets mode: +o openstack | 09:29 | |
| *** yamamoto has joined #openstack-lbaas | 09:40 | |
| *** salmankhan has quit IRC | 09:50 | |
| *** salmankhan has joined #openstack-lbaas | 09:50 | |
| *** longkb has quit IRC | 10:33 | |
| *** yamamoto has quit IRC | 11:12 | |
| *** yamamoto has joined #openstack-lbaas | 11:20 | |
| *** Ignazio has joined #openstack-lbaas | 11:24 | |
| *** Ignazio has quit IRC | 11:25 | |
| *** yamamoto has quit IRC | 11:25 | |
| *** yamamoto has joined #openstack-lbaas | 11:28 | |
| *** ignazio has joined #openstack-lbaas | 11:37 | |
| ignazio | hello everyone | 11:38 |
| ignazio | Please, I need help on ocata octavia | 11:38 |
| ignazio | healt-manager reports: Amphora 4e6d19d3-bc19-4882-aeca-4772b069c53b health message reports 0 listeners when 1 expected | 11:39 |
| ignazio | and continues to deploy amphora instances | 11:39 |
| *** ignazio has left #openstack-lbaas | 11:40 | |
| *** ignazio has joined #openstack-lbaas | 11:42 | |
| ignazio | Please, I need help on ocata octavia | 11:43 |
| *** yamamoto has quit IRC | 11:45 | |
| *** amotoki_ has joined #openstack-lbaas | 11:45 | |
| ignazio | anyone can halp me on octavia ? | 11:49 |
| *** amotoki__ has joined #openstack-lbaas | 11:54 | |
| *** yamamoto has joined #openstack-lbaas | 11:55 | |
| *** amotoki_ has quit IRC | 11:55 | |
| *** amotoki_ has joined #openstack-lbaas | 11:59 | |
| *** amotoki__ has quit IRC | 12:01 | |
| *** annp has quit IRC | 12:01 | |
| *** amotoki__ has joined #openstack-lbaas | 12:08 | |
| *** amotoki_ has quit IRC | 12:08 | |
| *** yamamoto has quit IRC | 12:12 | |
| *** yamamoto has joined #openstack-lbaas | 12:13 | |
| *** phuoc_ has joined #openstack-lbaas | 12:15 | |
| ignazio | helo | 12:16 |
| ignazio | anyone could help me with octavia ? | 12:16 |
| *** phuoc has quit IRC | 12:17 | |
| *** yamamoto has quit IRC | 12:22 | |
| *** yamamoto has joined #openstack-lbaas | 12:23 | |
| *** yamamoto has quit IRC | 12:27 | |
| *** ignazio has quit IRC | 12:36 | |
| *** yamamoto has joined #openstack-lbaas | 12:46 | |
| *** yamamoto has quit IRC | 12:47 | |
| *** yamamoto has joined #openstack-lbaas | 12:47 | |
| *** amotoki__ has quit IRC | 12:52 | |
| *** yamamoto_ has joined #openstack-lbaas | 12:53 | |
| *** yamamoto has quit IRC | 12:57 | |
| *** atoth_ has quit IRC | 13:04 | |
| *** atoth has joined #openstack-lbaas | 13:04 | |
| *** salmankhan has quit IRC | 13:10 | |
| *** openstackstatus has joined #openstack-lbaas | 13:11 | |
| *** ChanServ sets mode: +v openstackstatus | 13:11 | |
| -openstackstatus- NOTICE: Due to a Zuul outage, patches uploaded to Gerrit between 09:00UTC and 12:50UTC, were not properly added to Zuul. Please recheck any patches during this window and apologies for the inconvenience. | 13:15 | |
| *** yamamoto_ has quit IRC | 13:21 | |
| *** salmankhan has joined #openstack-lbaas | 13:43 | |
| *** salmankhan has quit IRC | 13:48 | |
| *** salmankhan has joined #openstack-lbaas | 13:53 | |
| *** yamamoto has joined #openstack-lbaas | 14:21 | |
| *** yamamoto has quit IRC | 14:27 | |
| *** fnaval has joined #openstack-lbaas | 14:36 | |
| xgerman_ | ignazio wassup? | 14:45 |
| *** openstackgerrit has quit IRC | 14:49 | |
| johnsom | Yeah, I checked earlier and saw they were already offline. Friday is a rough day for coverage | 15:00 |
| *** pcaruana has quit IRC | 15:07 | |
| *** rpittau has quit IRC | 15:14 | |
| *** yamamoto has joined #openstack-lbaas | 15:24 | |
| *** links has quit IRC | 15:24 | |
| *** yamamoto has quit IRC | 15:32 | |
| *** openstackgerrit has joined #openstack-lbaas | 15:34 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Implement provider drivers - Cleanup https://review.openstack.org/567431 | 15:34 |
| *** salmankhan has quit IRC | 16:20 | |
| *** salmankhan has joined #openstack-lbaas | 16:23 | |
| *** yamamoto has joined #openstack-lbaas | 16:28 | |
| *** yamamoto has quit IRC | 16:34 | |
| openstackgerrit | Merged openstack/octavia-dashboard master: Make the display of none consistent in detail page https://review.openstack.org/542751 | 16:43 |
| *** tesseract has quit IRC | 16:59 | |
| *** openstackstatus has quit IRC | 17:00 | |
| *** openstack has joined #openstack-lbaas | 17:04 | |
| *** ChanServ sets mode: +o openstack | 17:04 | |
| *** salmankhan has quit IRC | 17:05 | |
| *** yamamoto has joined #openstack-lbaas | 17:30 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for members https://review.openstack.org/566199 | 17:32 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create basic traffic balancing scenario test https://review.openstack.org/566700 | 17:32 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for healthmonitors https://review.openstack.org/567688 | 17:32 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Implement provider drivers - Health Monitor https://review.openstack.org/567037 | 17:34 |
| johnsom | Added the depends on for HM | 17:35 |
| *** yamamoto has quit IRC | 17:36 | |
| rm_work | k | 17:38 |
| rm_work | just in time for updates :P | 17:38 |
| rm_work | uhhh the scenario might fail | 17:38 |
| rm_work | working on getting it testing | 17:38 |
| rm_work | err sorry, s/might/will/ | 17:40 |
| rm_work | so ignore that | 17:40 |
| rm_work | I see why people often don't bother writing tests that they know will work in parallel / dirty environments | 17:53 |
| rm_work | it's a PITA | 17:53 |
| rm_work | but worth it I think | 17:53 |
| johnsom | Yeah, it's worth the effort to get a good base | 17:57 |
| johnsom | I'm doing a few reviews before lunch, then out for lunch, this afternoon I will address your comments on the LB patch, then start the driver library | 17:58 |
| rm_work | k | 17:58 |
| rm_work | the entirety of the comments on that patch are what's in the CR on the end of the chain | 17:58 |
| rm_work | so you may as well just comment on that | 17:59 |
| johnsom | So you are just going to +2 the LB patch? grin | 17:59 |
| rm_work | if you address those comments, yeah | 17:59 |
| rm_work | as long as they are passing the new tempest tests... | 18:02 |
| rm_work | I gave it a once-over and didn't see anything egregious | 18:02 |
| rm_work | and there's a lot in the cleanup patch | 18:02 |
| rm_work | but this is another "get it in, and iterate" thing | 18:03 |
| rm_work | I think it's not going to be perfect anyway until a vendor tries to actually use it to write a driver | 18:03 |
| johnsom | Most of cleanup is a doc and moving the samples out into a dedicated samples file | 18:03 |
| rm_work | it seems to be written "per spec", and if there's bugs, we'll find them when someone tries to use it | 18:05 |
| johnsom | Well, I fixed the ones I found as I wrote the amphora driver | 18:05 |
| rm_work | so as long as it doesn't break the existing stuff (which tests show it does not), and there's nothing obviously dumb in there, i'm good | 18:05 |
| johnsom | Ha, well, entirely possible | 18:06 |
| rm_work | right, i did a once-over looking for dumb stuff | 18:06 |
| rm_work | just found the one bit i didn't like, and commented/argued 100 times accordingly | 18:06 |
| rm_work | eugh i want to have the HM scenario test actually make sure member statuses update properly... | 18:10 |
| rm_work | but that means it'd have to use compute instances to have valid members | 18:10 |
| rm_work | which means i need to move it into the "live-tests" thing <_< | 18:11 |
| rm_work | unless i figure out the singleton-servers thing | 18:11 |
| rm_work | johnsom: did you know `gate-recheck` is a thing? | 18:25 |
| rm_work | apparently when our stuff passes checks, we +A it, and the gate fails for something dumb, we can just `gate-recheck` to ONLY retry the gate, we don't have to `recheck` and go all the way through both | 18:26 |
| johnsom | No, must be new | 18:26 |
| * rm_work shrugs | 18:26 | |
| rm_work | i think it's been a while, just no one told us / we didn't read doc updates :P | 18:27 |
| *** yamamoto has joined #openstack-lbaas | 18:32 | |
| *** yamamoto has quit IRC | 18:36 | |
| rm_work | alright i'm gonna move the HM testing stuff around a bit :( | 19:06 |
| *** yamamoto has joined #openstack-lbaas | 19:33 | |
| *** yamamoto has quit IRC | 19:38 | |
| rm_work | hmm wonder if i found a bug | 20:18 |
| rm_work | OH | 20:23 |
| rm_work | johnsom: so somehow i didn't realize that a member failing healthmonitor checks goes to ERROR, I thought it would go to OFFLINE | 20:23 |
| rm_work | even though i have seen this multiple times in the past, so I should know this | 20:23 |
| rm_work | still it just feels counter-intuitive to me | 20:23 |
| johnsom | Offline is admin down | 20:24 |
| rm_work | ahhhh | 20:24 |
| rm_work | ok | 20:24 |
| rm_work | ;) | 20:25 |
| rm_work | i should add that to my test too | 20:25 |
| rm_work | I think I'm happy with this model | 20:31 |
| rm_work | the scenario test files named for each object will pretty much just be a collection of the same tests from the API, but designed to be run not in noop mode... then if there is something you need to test that requires actual webservers/traffic, it goes in the traffic tests file | 20:32 |
| *** yamamoto has joined #openstack-lbaas | 20:34 | |
| *** yamamoto has quit IRC | 20:39 | |
| rm_work | johnsom: ah, err... so, members in admin_state "down" ... | 20:49 |
| rm_work | johnsom: with the change I made to fix the status-flipping bug, they will always stay in NO_MONITOR <_< so I guess I introduced another bug there. We probably just need to actually check if there's a monitor configured or not :/ | 20:51 |
| johnsom | ??? | 20:52 |
| johnsom | I thought the way I had you change it fixed that | 20:52 |
| rm_work | with this: https://review.openstack.org/#/c/567322/3/octavia/controller/healthmanager/health_drivers/update_db.py | 20:52 |
| rm_work | it fixed something else | 20:52 |
| rm_work | but not quite this | 20:52 |
| rm_work | it doesn't ever override... | 20:53 |
| rm_work | but since all HMs start in NO_MONITOR regardless of anything else, it still will ignore updating them | 20:53 |
| rm_work | originally i had it overriding, which we said was bad | 20:53 |
| johnsom | But if the member reports it won't hit that logic | 20:53 |
| rm_work | ah right | 20:54 |
| rm_work | err | 20:54 |
| rm_work | hmm maybe i am misunderstanding the bug i'm hitting | 20:54 |
| rm_work | one sec | 20:54 |
| rm_work | err right | 20:54 |
| johnsom | The way you had it first would have had that problem | 20:54 |
| rm_work | because admin_state_up=False makes the member not report | 20:54 |
| rm_work | right? | 20:54 |
| rm_work | we just don't include it | 20:54 |
| johnsom | Yeah, yes | 20:55 |
| johnsom | I see it now | 20:55 |
| rm_work | yeah | 20:55 |
| rm_work | it was non-obvious | 20:55 |
| rm_work | i'm noodling the fix | 20:55 |
| rm_work | there's actually a couple of ways to do it | 20:55 |
| rm_work | but deciding between trying to inject too much intelligence or not | 20:55 |
| rm_work | don't want this to get CRAZY complex | 20:55 |
| rm_work | we actually have the db_member so we can actually LOOK and see if there's an HM | 20:56 |
| rm_work | or, we could also update our controller code so that when you set a member to admin-down it will set the initial OFFLINE | 20:57 |
| rm_work | and then it will not be a problem | 20:57 |
| rm_work | ^^ I think i like the second one | 20:57 |
| rm_work | since we should never have created it in NO_MONITOR anyway | 20:57 |
| rm_work | right? | 20:57 |
| rm_work | IMO *that* is also a similar bug | 20:57 |
| rm_work | because it's also a weird status-flip | 20:57 |
| rm_work | thoughts? | 20:57 |
| rm_work | the issue there though is it just requires a ton of touchpoints in the code to make sure we always get it right | 21:02 |
| rm_work | create_member needs to make sure to set the initial OFFLINE if there is no HM (easy peasy) | 21:02 |
| rm_work | update_member needs to update the status to OFFLINE if admin_state_up is changed to false (easy, but, could be overwritten by health, so we're back in the same boat) | 21:03 |
| rm_work | create/delete HM would also need to update affected members (erk) | 21:04 |
| rm_work | honestly I think the *problem* is all stemming from this being a weird override to begin with -- we're trying to say "we're smarter than the HM system" when a member is admin-down | 21:05 |
| rm_work | which seems all great and good | 21:06 |
| rm_work | but it causes all of these awkward transitions | 21:06 |
| rm_work | so i think I may just *have to* change it in update_db | 21:07 |
| rm_work | yeah so if we *actually check* to see if there's a HM, that should work, right? | 21:21 |
| rm_work | we have that data... | 21:21 |
| rm_work | another option would be to do members the correct way in HAProxy | 21:23 |
| rm_work | and actually put them into config but in maint mode | 21:23 |
| rm_work | which is IMO what "admin-down" should do | 21:23 |
| rm_work | then we wouldn't have this problem at all | 21:23 |
| johnsom | Whoa, take an internal meeting and come back to a wall of text.... | 21:27 |
| rm_work | walking through logic | 21:27 |
| rm_work | basically I think the real fix for this (and something we really should have done ANYWAY) is to still put admin_down members into the config, but disable them | 21:28 |
| rm_work | https://cbonte.github.io/haproxy-dconv/1.7/configuration.html#5.2-disabled | 21:28 |
| rm_work | then they're in maint mode | 21:28 |
| rm_work | and we correctly OFFLINE them via healthchecks | 21:28 |
| johnsom | Yeah, but that option wasn't in the original haproxy we started with, I think that is why we pulled the config | 21:29 |
| rm_work | ohrly? | 21:30 |
| rm_work | let me see how far it goes back | 21:30 |
| rm_work | that would be annoying | 21:30 |
| johnsom | I was just going to look | 21:30 |
| rm_work | i see it in 1.5 | 21:30 |
| rm_work | i think it was just that every OTHER object did it that way | 21:31 |
| rm_work | so we carried it through to members | 21:31 |
| johnsom | Well, if it does what we need and stops sending health monitor pings, I am all for it | 21:32 |
| rm_work | I believe so | 21:33 |
| rm_work | that last part i need to double check | 21:33 |
| johnsom | It appears to say it stops, so.... | 21:33 |
| rm_work | yeah | 21:33 |
| rm_work | "That means | 21:33 |
| rm_work | that it is marked down in maintenance mode, and no connection other than the | 21:33 |
| rm_work | ones allowed by persist mode will reach it." | 21:33 |
| rm_work | ah, and | 21:34 |
| rm_work | "while it is still possible to test the service by making use of the force-persist mechanism." | 21:34 |
| rm_work | so I assume you'd need that to enable HMs | 21:34 |
| rm_work | almost done with the template change, working on the testing | 21:34 |
| rm_work | we still do a weird flip where in NOOP mode it would always be NO_MONITOR but in real mode it flips to OFFLINE after a health message comes in | 21:35 |
| rm_work | but I guess that's ok? | 21:35 |
| *** yamamoto has joined #openstack-lbaas | 21:35 | |
| *** yamamoto has quit IRC | 21:41 | |
| rm_work | johnsom: ummm i thought we had tests somewhere that tested the generated haproxy configs, but i can't find them, and i changed stuff and nothing failed >_> | 21:42 |
| rm_work | oh i found it ... test_jinja_config | 21:43 |
| rm_work | but it must not test anything involving disabled members >_< | 21:43 |
| rm_work | lol | 21:43 |
| xgerman_ | yeah, that is very barebones and kust check some global options | 21:48 |
| *** AlexStaf has joined #openstack-lbaas | 21:57 | |
| rm_work | yeah got a fix, testing | 22:09 |
| *** fnaval has quit IRC | 22:31 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Create disabled members in haproxy https://review.openstack.org/567955 | 22:32 |
| rm_work | ^^ johnsom let me know what you think, when you have a break | 22:33 |
| rm_work | going to test it now myself to make sure it solves my issue | 22:33 |
| johnsom | ok | 22:33 |
| rm_work | I wonder where would be the best place to add some docs and maybe a chart about exactly what you can expect the status of members to be depending on HM/not | 22:36 |
| rm_work | because it was confusion/misunderstanding on my part that led to introducing this bug | 22:37 |
| johnsom | Yeah, I agree we should have something like that. Maybe in the user section | 22:37 |
| johnsom | It would go in an API guide I guess, but we don't have one at the moment. | 22:38 |
| rm_work | it's kinda a 3d matrix | 22:39 |
| rm_work | not even sure how i'd visualize it | 22:39 |
| rm_work | ah I guess one table for no HM, and one table for with HM | 22:39 |
| johnsom | graphviz? | 22:40 |
| johnsom | lol | 22:40 |
| *** ivve has quit IRC | 22:41 | |
| rm_work | hmmm that may not have fixed it, but i need to figure out why | 22:45 |
| rm_work | prolly missed something | 22:45 |
| rm_work | oh, wtf | 22:50 |
| rm_work | HM didn't restart in devstack due to address in use | 22:50 |
| rm_work | i thought we fixed that <_< | 22:50 |
| johnsom | No, I have been bitching about this for weeks. The new service/process thing doesn't shut down right | 22:51 |
| rm_work | eugh | 22:52 |
| rm_work | ok umm so i guess maybe my patch does work then | 22:52 |
| rm_work | k | 22:52 |
| rm_work | finally got it restarted and it seems to be working | 22:53 |
| rm_work | errr | 22:53 |
| rm_work | though this means it actually never had the last patch... | 22:53 |
| rm_work | because i had applied that and restarted the HM | 22:53 |
| rm_work | grrr one sec | 22:54 |
| rm_work | gonna run it one more time to make sure it all passes, then revert this patch and see if it passes also | 22:54 |
| rm_work | (I don't think it will) | 22:54 |
| rm_work | but that means this bug was present even without my patch I think | 22:54 |
| rm_work | err, without the one I thought broke it | 22:54 |
| rm_work | `systemctl restart` doesn't return an error exit code if it fails miserably to start the service?? <_< | 22:55 |
| rm_work | ok well, it is definitely passing what i think is a pretty good tempest test, WITH both patches | 22:56 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for healthmonitors https://review.openstack.org/567688 | 23:00 |
| rm_work | k, includes a couple of scenario tests, the traffic one i think is *good* | 23:00 |
| rm_work | but I think it could still use maybe one or two more cases thrown in | 23:01 |
| *** yamamoto has joined #openstack-lbaas | 23:01 | |
| rm_work | ok yes, bug exists with the first patch but without the second | 23:02 |
| rm_work | now to test without either to verify it was introduced there | 23:02 |
| rm_work | uh-oh, it's 4:04pm, time to make myself not found | 23:04 |
| johnsom | sigh | 23:05 |
| rm_work | yeah ok verified that the last patch definitely did break it | 23:07 |
| rm_work | but the other patch fixes it | 23:07 |
| rm_work | so | 23:07 |
| rm_work | I did add a reno | 23:07 |
| rm_work | ;) | 23:07 |
| johnsom | +1 | 23:07 |
| rm_work | yeah ok i may have to track down why this isn't restarting properly | 23:11 |
| rm_work | unless, did you track it down already? | 23:11 |
| rm_work | I somehow missed your bitching about it :P | 23:11 |
| johnsom | No, I didn't track it down | 23:19 |
| rm_work | k | 23:19 |
| *** yamamoto has quit IRC | 23:26 | |
| johnsom | rm_work I am so worried somebody is going to try to fill in "name" in their driver.... | 23:34 |
| johnsom | rm_work make it _name | 23:39 |
| johnsom | rm_work _dont_use_me_name? | 23:52 |
| johnsom | Oh, I know, _n_a_m_e | 23:53 |
| rm_work | I mean | 23:56 |
| rm_work | we can use _name and a @property | 23:56 |
| rm_work | I almost did that | 23:56 |
| rm_work | I mean, you're welcome to | 23:56 |
| rm_work | but i can get to it as well | 23:56 |
| rm_work | just ... not tonight, I have to head out, be out of pocket for ~7h | 23:57 |
| rm_work | anyway if they did that, any testing would tell them it gets overridden :P | 23:57 |
| rm_work | We could also add a comment | 23:57 |
| rm_work | anywho, bbl | 23:57 |
| johnsom | Just trolling back | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!