| johnsom | rm_work Have second for a second opinion? | 00:10 |
|---|---|---|
| rm_work | I have a minute for a minute opinion | 00:10 |
| johnsom | Even better | 00:11 |
| johnsom | https://docs.openstack.org/octavia/latest/contributor/specs/version1.1/enable-provider-driver.html#load-balancer | 00:11 |
| johnsom | for update in the spec | 00:11 |
| johnsom | It's vague whether you will get a full load balancer object with fields of None or a custom object with just the update fields | 00:11 |
| johnsom | Trying to decide if I should add "update" objects to https://review.openstack.org/#/c/558320/4/octavia/api/drivers/data_models.py | 00:12 |
| johnsom | Or update the to_dict method on the existing object to optionally fish out the Nones | 00:13 |
| johnsom | It seems like update objects are more explicit, but the other way *may* allow us to add update fields easier. | 00:13 |
| johnsom | Opinion? | 00:14 |
| johnsom | Frankly anyone else that is still around is welcome to join the party | 00:14 |
| rm_work | reading | 00:17 |
| johnsom | I think I answered my own question. I can't fish out the Nones as it could be updating to None. Yep, need another object I think. | 00:17 |
| rm_work | lolk | 00:17 |
| johnsom | I guess I could create an "unset" type like wsme | 00:18 |
| rm_work | Yeah, that might be best | 00:18 |
| rm_work | maybe | 00:18 |
| rm_work | hmm | 00:18 |
| rm_work | let me noodle | 00:18 |
| rm_work | have to think as if i were a provider writing a driver | 00:19 |
| johnsom | I know this was a pain point with the handler too | 00:19 |
| rm_work | IIRC most of the providers wanted us to pass them the entire fully-populated object anyway even on updates O_o | 00:19 |
| johnsom | No, just one did | 00:19 |
| johnsom | Well, one wanted the whole LB tree on every call | 00:20 |
| rm_work | lol yeah | 00:20 |
| johnsom | Octavia will pass in a load balancer object with the fields to be updated. | 00:21 |
| johnsom | That line implies partial to me | 00:21 |
| rm_work | yes | 00:21 |
| rm_work | but we can always propose spec updates | 00:21 |
| johnsom | Right | 00:21 |
| rm_work | but yeah, probably an "Unset" type is fine | 00:22 |
| johnsom | Ok, I think that is good and clear. I will make it so | 00:22 |
| rm_work | still annoying that the openstack client can't filter images based on tags | 01:06 |
| rm_work | the glance API can tho... right? I mean, otherwise wtf | 01:06 |
| *** ianychoi has quit IRC | 01:11 | |
| *** ianychoi has joined #openstack-lbaas | 01:12 | |
| *** slaweq has joined #openstack-lbaas | 01:17 | |
| *** lxkong has quit IRC | 01:18 | |
| *** slaweq has quit IRC | 01:21 | |
| rm_work | johnsom: whelp | 01:31 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Fix amphora failover API to work with spares https://review.openstack.org/564082 | 01:31 |
| rm_work | i messed that one up to start :P | 01:31 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Experimental multi-az support https://review.openstack.org/558962 | 01:51 |
| johnsom | Whelp? | 02:06 |
| *** fnaval_ has joined #openstack-lbaas | 02:28 | |
| *** fnaval has quit IRC | 02:28 | |
| *** lxkong has joined #openstack-lbaas | 03:02 | |
| *** slaweq has joined #openstack-lbaas | 03:18 | |
| *** slaweq has quit IRC | 03:22 | |
| *** yamamoto has quit IRC | 04:29 | |
| *** links has joined #openstack-lbaas | 04:29 | |
| *** ianychoi has quit IRC | 04:41 | |
| *** ianychoi has joined #openstack-lbaas | 04:44 | |
| *** Alex_Staf has joined #openstack-lbaas | 04:46 | |
| *** yamamoto has joined #openstack-lbaas | 04:50 | |
| *** ianychoi has quit IRC | 05:01 | |
| *** ianychoi has joined #openstack-lbaas | 05:03 | |
| rm_work | johnsom: was referring to Fix amphora failover API to work with spares https://review.openstack.org/564082 | 05:21 |
| *** yboaron has joined #openstack-lbaas | 05:27 | |
| *** yboaron has quit IRC | 05:28 | |
| *** yboaron has joined #openstack-lbaas | 05:28 | |
| *** ianychoi has quit IRC | 05:37 | |
| *** ianychoi has joined #openstack-lbaas | 05:39 | |
| *** ianychoi has quit IRC | 05:46 | |
| *** ianychoi has joined #openstack-lbaas | 05:49 | |
| rm_work | nmagnezi / cgoncalves: so in centos, our vip config is on eth1:0 and we drop a config into `/etc/netns/amphora-haproxy/sysconfig/network-scripts/ifcfg-eth1:0` | 06:13 |
| rm_work | but on the amp i just built, the interface didn't actually come up | 06:13 |
| rm_work | <_< | 06:13 |
| rm_work | eth1 came up inside the ns, but no eth1:0 | 06:15 |
| rm_work | did something change that means that doesn't come up automatically anymore? | 06:15 |
| rm_work | hmmm well actually, something else may be going on, as it looks like the vip didn't get bound right anyway | 06:20 |
| rm_work | i'll look at it in the morning | 06:20 |
| cgoncalves | rm_work, I don't think but would be pretty cool if we'd get better performance on 1.5 xD | 06:43 |
| cgoncalves | rm_work, I'd need to check that. actually the kuryr folks have reported to me that members cannot access the vip ip | 06:47 |
| *** slaweq has joined #openstack-lbaas | 06:54 | |
| *** tesseract has joined #openstack-lbaas | 07:01 | |
| *** pcaruana has joined #openstack-lbaas | 07:06 | |
| cgoncalves | octavia/api/drivers/amphora_driver/driver.py | 07:07 |
| cgoncalves | \o/ | 07:07 |
| *** ianychoi has quit IRC | 07:33 | |
| *** ianychoi has joined #openstack-lbaas | 07:35 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 07:37 | |
| *** ianychoi has quit IRC | 07:46 | |
| *** ianychoi has joined #openstack-lbaas | 07:49 | |
| *** yboaron has quit IRC | 08:34 | |
| *** yboaron has joined #openstack-lbaas | 09:22 | |
| *** amitry has joined #openstack-lbaas | 09:29 | |
| *** ianychoi has quit IRC | 09:52 | |
| *** ianychoi has joined #openstack-lbaas | 09:54 | |
| *** ianychoi has quit IRC | 10:00 | |
| *** ianychoi has joined #openstack-lbaas | 10:03 | |
| *** AlexeyAbashkin has quit IRC | 10:10 | |
| *** ianychoi has quit IRC | 10:12 | |
| *** ianychoi has joined #openstack-lbaas | 10:17 | |
| *** yamamoto has quit IRC | 10:40 | |
| *** yboaron_ has joined #openstack-lbaas | 11:01 | |
| *** yboaron has quit IRC | 11:04 | |
| *** yamamoto has joined #openstack-lbaas | 11:07 | |
| *** yboaron_ has quit IRC | 11:09 | |
| *** yboaron has joined #openstack-lbaas | 11:12 | |
| *** atoth has joined #openstack-lbaas | 11:18 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 11:20 | |
| *** wolsen has quit IRC | 11:30 | |
| *** wolsen has joined #openstack-lbaas | 11:30 | |
| *** yamamoto has quit IRC | 12:08 | |
| *** raginbaj- has joined #openstack-lbaas | 12:18 | |
| *** raginbajin has quit IRC | 12:23 | |
| *** atoth has quit IRC | 12:23 | |
| *** dayou has quit IRC | 12:23 | |
| *** strigazi has quit IRC | 12:23 | |
| *** raginbaj- is now known as raginbajin | 12:23 | |
| nmagnezi | rm_work, ping | 12:23 |
| *** atoth has joined #openstack-lbaas | 12:26 | |
| *** dayou has joined #openstack-lbaas | 12:26 | |
| *** strigazi has joined #openstack-lbaas | 12:26 | |
| *** gans has joined #openstack-lbaas | 12:55 | |
| *** gans has quit IRC | 13:00 | |
| *** pchavva has joined #openstack-lbaas | 13:01 | |
| *** samccann has joined #openstack-lbaas | 13:01 | |
| *** yamamoto has joined #openstack-lbaas | 13:04 | |
| *** yamamoto has quit IRC | 13:10 | |
| *** Alex_Staf has quit IRC | 13:23 | |
| *** fnaval_ has quit IRC | 13:30 | |
| *** fnaval has joined #openstack-lbaas | 13:31 | |
| *** fnaval has quit IRC | 13:35 | |
| *** fnaval has joined #openstack-lbaas | 13:50 | |
| *** leitan has joined #openstack-lbaas | 13:56 | |
| *** samccann has quit IRC | 14:02 | |
| *** samccann has joined #openstack-lbaas | 14:02 | |
| *** yamamoto has joined #openstack-lbaas | 14:06 | |
| *** yamamoto has quit IRC | 14:11 | |
| johnsom | cgoncalves: I did a fix for members not being able to reach the vip IP using policy based routing. I wonder if that didn’t make it into the RH tribe code. | 14:34 |
| cgoncalves | johnsom, https://review.openstack.org/#/c/501915/ ? it's in since 2.0.0 so either something slipped (e.g. patch not taking effect in RH-based) or it's a different issue | 14:41 |
| cgoncalves | I haven't yet had a chance to look at the issue :/ | 14:42 |
| johnsom | Yeah, that is the patch. | 14:43 |
| *** atoth has quit IRC | 15:01 | |
| *** dayou has quit IRC | 15:01 | |
| *** strigazi has quit IRC | 15:01 | |
| *** AlexeyAbashkin has quit IRC | 15:01 | |
| *** andreykurilin has quit IRC | 15:01 | |
| *** numans has quit IRC | 15:01 | |
| *** kbyrne has quit IRC | 15:01 | |
| *** vegarl has quit IRC | 15:01 | |
| *** zigo has quit IRC | 15:01 | |
| *** ivve has quit IRC | 15:01 | |
| *** JudeC has quit IRC | 15:01 | |
| *** devfaz has quit IRC | 15:01 | |
| *** numans has joined #openstack-lbaas | 15:01 | |
| *** kbyrne has joined #openstack-lbaas | 15:01 | |
| *** vegarl has joined #openstack-lbaas | 15:01 | |
| *** zigo has joined #openstack-lbaas | 15:01 | |
| *** ivve has joined #openstack-lbaas | 15:01 | |
| *** JudeC has joined #openstack-lbaas | 15:01 | |
| *** devfaz has joined #openstack-lbaas | 15:01 | |
| *** atoth has joined #openstack-lbaas | 15:03 | |
| *** dayou has joined #openstack-lbaas | 15:03 | |
| *** strigazi has joined #openstack-lbaas | 15:03 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 15:04 | |
| *** andreykurilin has joined #openstack-lbaas | 15:04 | |
| *** keithmnemonic[m] has quit IRC | 15:04 | |
| *** yamamoto has joined #openstack-lbaas | 15:08 | |
| *** yamamoto has quit IRC | 15:13 | |
| *** yboaron has quit IRC | 15:30 | |
| *** xgerman_ has quit IRC | 15:53 | |
| *** xgerman_ has joined #openstack-lbaas | 15:53 | |
| *** pcaruana has quit IRC | 15:57 | |
| *** pcaruana has joined #openstack-lbaas | 15:59 | |
| *** srihas_ has joined #openstack-lbaas | 16:05 | |
| *** atoth_ has joined #openstack-lbaas | 16:06 | |
| *** pcaruana has quit IRC | 16:08 | |
| *** jmccrory_ has joined #openstack-lbaas | 16:09 | |
| *** atoth has quit IRC | 16:09 | |
| *** links has quit IRC | 16:09 | |
| *** yamamoto has joined #openstack-lbaas | 16:10 | |
| *** jmccrory has quit IRC | 16:10 | |
| *** srihas has quit IRC | 16:10 | |
| *** jmccrory_ is now known as jmccrory | 16:11 | |
| *** yamamoto has quit IRC | 16:15 | |
| *** keithmnemonic[m] has joined #openstack-lbaas | 16:19 | |
| xgerman_ | https://usercontent.irccloud-cdn.com/file/XFaNpVOX/Screen%20Shot%202018-04-25%20at%209.24.39%20AM.png | 16:24 |
| *** slaweq has quit IRC | 16:48 | |
| *** sshank has joined #openstack-lbaas | 16:50 | |
| *** coreycb has quit IRC | 16:57 | |
| *** coreycb has joined #openstack-lbaas | 16:58 | |
| *** slaweq has joined #openstack-lbaas | 16:58 | |
| *** links has joined #openstack-lbaas | 17:08 | |
| *** links has quit IRC | 17:09 | |
| *** AlexeyAbashkin has quit IRC | 17:11 | |
| *** yamamoto has joined #openstack-lbaas | 17:11 | |
| *** yamamoto has quit IRC | 17:16 | |
| *** pcaruana has joined #openstack-lbaas | 17:20 | |
| *** atoth_ has quit IRC | 17:46 | |
| rm_work | whelp | 17:55 |
| rm_work | bye bye Ihar | 17:55 |
| johnsom | Yeah, he was good. | 17:56 |
| *** atoth_ has joined #openstack-lbaas | 17:58 | |
| rm_work | so yeah i need to poke at stuff again, something went wonky and i assumed it was because of my new image (I did one test LB with the spares that existed which worked, and the next test LB used the new image which didn't) but actually the VIP never got plugged to the second one, so probably something else is the issue | 17:58 |
| rm_work | i'll report back later | 17:58 |
| johnsom | Ok | 17:58 |
| rm_work | but yeah that spare amp failover bug was dumb | 17:59 |
| rm_work | and i feel bad | 17:59 |
| johnsom | I am noodling on object->dict and unset stuffs | 17:59 |
| rm_work | @johnsom: Munch? | 17:59 |
| rm_work | brb | 18:00 |
| *** sshank has quit IRC | 18:06 | |
| *** yamamoto has joined #openstack-lbaas | 18:12 | |
| *** kevinbenton has joined #openstack-lbaas | 18:17 | |
| *** yamamoto has quit IRC | 18:18 | |
| *** leitan has quit IRC | 18:20 | |
| *** kevinbenton_ has quit IRC | 18:22 | |
| *** sshank has joined #openstack-lbaas | 18:26 | |
| *** leitan has joined #openstack-lbaas | 18:39 | |
| *** leitan_ has joined #openstack-lbaas | 18:42 | |
| *** leitan has quit IRC | 18:43 | |
| *** pchavva has quit IRC | 18:43 | |
| *** leitan_ has quit IRC | 18:47 | |
| *** leitan has joined #openstack-lbaas | 18:47 | |
| *** velizarx has joined #openstack-lbaas | 18:54 | |
| *** pchavva has joined #openstack-lbaas | 18:57 | |
| *** leitan has quit IRC | 18:57 | |
| nmagnezi | johnsom, storyboard meeting is now? | 19:00 |
| johnsom | nmagnezi Usually | 19:01 |
| nmagnezi | lol | 19:01 |
| johnsom | Yeah, looks like it is just starting | 19:01 |
| *** atoth_ has quit IRC | 19:03 | |
| *** mrhillsman has joined #openstack-lbaas | 19:12 | |
| *** imacdonn has quit IRC | 19:14 | |
| *** yamamoto has joined #openstack-lbaas | 19:14 | |
| *** imacdonn has joined #openstack-lbaas | 19:14 | |
| *** sshank has quit IRC | 19:16 | |
| *** velizarx has quit IRC | 19:19 | |
| *** yamamoto has quit IRC | 19:20 | |
| *** velizarx has joined #openstack-lbaas | 19:24 | |
| *** velizarx has quit IRC | 19:34 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 19:48 | |
| *** AlexeyAbashkin has quit IRC | 19:52 | |
| *** cgoncalves_ has joined #openstack-lbaas | 19:53 | |
| *** pchavva has quit IRC | 19:54 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 19:57 | |
| *** rm_mobile has joined #openstack-lbaas | 19:58 | |
| johnsom | #startmeeting Octavia | 20:00 |
| openstack | Meeting started Wed Apr 25 20:00:32 2018 UTC and is due to finish in 60 minutes. The chair is johnsom. Information about MeetBot at http://wiki.debian.org/MeetBot. | 20:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 20:00 |
| *** openstack changes topic to " (Meeting topic: Octavia)" | 20:00 | |
| openstack | The meeting name has been set to 'octavia' | 20:00 |
| cgoncalves_ | hi | 20:00 |
| xgerman_ | o/ | 20:00 |
| johnsom | Hi all | 20:00 |
| johnsom | #topic Announcements | 20:01 |
| *** openstack changes topic to "Announcements (Meeting topic: Octavia)" | 20:01 | |
| johnsom | PTG is back in Denver Sept 10-14 | 20:01 |
| nmagnezi | o/ | 20:01 |
| johnsom | Same hotel. In theory less train | 20:01 |
| rm_mobile | ... how | 20:02 |
| johnsom | The foundation is interested in how many folks plan to attend for room planning. | 20:02 |
| johnsom | I guess they fixed the crossing gate issue (or wrote it off) and the hotel installed better windows. | 20:02 |
| rm_mobile | Lol k | 20:02 |
| johnsom | Does anyone know if they are already planning to attend? | 20:02 |
| xgerman_ | depends on funding… | 20:03 |
| johnsom | Ok, I will take a guess and give them that based on previous attendance. | 20:03 |
| johnsom | Yeah, I have no idea if I can make it yet either. | 20:03 |
| xgerman_ | prob. more since we are in F5 land | 20:03 |
| johnsom | Yeah, they might want some quality time with us to work on the driver | 20:04 |
| johnsom | Also, TC elections are on. Check you inbox for you ballot email. | 20:04 |
| johnsom | That is all I have for announcements. Any others? | 20:05 |
| johnsom | #topic Brief progress reports / bugs needing review | 20:05 |
| *** openstack changes topic to "Brief progress reports / bugs needing review (Meeting topic: Octavia)" | 20:05 | |
| rm_mobile | I will definitely try | 20:06 |
| johnsom | I have been buried in gate fixes, but have started work on the provider driver again. | 20:06 |
| johnsom | Making decent progress, I have most of the LB API moved over to running through the new "octavia" driver. | 20:07 |
| * johnsom Looks to see if Carlos is paying attention or not. | 20:07 | |
| cgoncalves_ | s/octavia/amphora :D | 20:07 |
| johnsom | I am making a few changes to the data model for drivers, just as a heads up in case someone is developing against my WIP data model patch | 20:08 |
| *** rm_mobile has quit IRC | 20:08 | |
| johnsom | I expect the provider driver work will be my focus for the rest of the week | 20:08 |
| cgoncalves_ | johnsom: do you need help in any particular area? just reviewing? | 20:08 |
| *** rm_mobile has joined #openstack-lbaas | 20:08 | |
| johnsom | Any other progress updates? | 20:09 |
| *** rm_mobile| has joined #openstack-lbaas | 20:09 | |
| johnsom | Keeping reviews rolling on stuff is super helpful. Once I get over this data model work and get updates working I think the reset will fall together pretty quick. | 20:10 |
| xgerman_ | famous last words “fall together quickly” | 20:10 |
| *** rm_mobile has quit IRC | 20:10 | |
| johnsom | Yeah, exactly | 20:10 |
| *** rm_mobile| has quit IRC | 20:10 | |
| cgoncalves_ | ok | 20:10 |
| johnsom | cgoncalves I will keep you in mind though, once the framework is in place I can probably hand off converting some of the other objects for parallel work. | 20:11 |
| *** rm_mobile has joined #openstack-lbaas | 20:11 | |
| johnsom | #link https://review.openstack.org/#/q/(project:openstack/octavia+OR+project:openstack/octavia-dashboard+OR+project:openstack/python-octaviaclient+OR+project:openstack/octavia-tempest-plugin)+AND+status:open+AND+NOT+label:Code-Review%253C0+AND+NOT+label:Verified%253C%253D0+AND+NOT+label:Workflow%253C0 | 20:12 |
| cgoncalves_ | sure, ping me whenever you need | 20:12 |
| johnsom | There are a bunch of patches open without reviews however, so that would be great too | 20:12 |
| johnsom | Any other progress updates? | 20:13 |
| *** rm_mobile| has joined #openstack-lbaas | 20:13 | |
| *** rm_mobile| has quit IRC | 20:13 | |
| johnsom | #topic Octavia deleted status vs. 404 | 20:14 |
| *** openstack changes topic to "Octavia deleted status vs. 404 (Meeting topic: Octavia)" | 20:14 | |
| *** rm_mobile| has joined #openstack-lbaas | 20:14 | |
| johnsom | #link https://review.openstack.org/#/c/545493/ | 20:14 |
| johnsom | Looks like the patch has a gate issue, I will look at that after the meeting. | 20:14 |
| johnsom | Any other updates on library support/no-support? | 20:15 |
| rm_work | i think the gate issue was a neutron bug | 20:15 |
| *** rm_mobile has quit IRC | 20:15 | |
| rm_work | just needs a recheck | 20:15 |
| johnsom | I thought I have this handled in the new tempest plugin, but I guess I missed something | 20:15 |
| rm_work | johnsom: i have a patch for that | 20:15 |
| *** yamamoto has joined #openstack-lbaas | 20:15 | |
| rm_work | https://review.openstack.org/#/c/563737/ | 20:15 |
| johnsom | Ah, sweet | 20:16 |
| rm_work | fixes all the way to the HM patch i had on top of your deleted one | 20:16 |
| rm_work | so hopefully we can merge all the way up there | 20:16 |
| rm_work | and the constraints patch (because our l-c is broken) | 20:16 |
| johnsom | Ok, cool | 20:16 |
| johnsom | Yeah, more good stuff needing reviews | 20:17 |
| rm_work | I did also get the proxy-gate passing in neutron-lbaas, where it just adds an L7 proxy for /lbaas/ direct to octavia from neutron | 20:17 |
| rm_work | could use eyes and opinions on the test changes that were made to accomodate that, to make sure there's nothing too dumb (because changing tests to make them pass is normally dirty) | 20:18 |
| rm_work | https://review.openstack.org/#/c/561049/ | 20:18 |
| rm_work | most of them are around one bug (which is that octavia ignores tenant-id on subobjects) | 20:18 |
| xgerman_ | and here is the other proxy: https://review.openstack.org/#/c/539350/ | 20:19 |
| johnsom | Well, having different project-ids for different parts of a single load balancer doesn't really make any sense, so.... | 20:20 |
| rm_work | yes | 20:20 |
| rm_work | the tests were negative tests to make sure it exploded | 20:20 |
| rm_work | whereas octavia just ignores them entirely | 20:20 |
| rm_work | so the question is, should octavia change to also reject the requests, or should the tests just expect either | 20:20 |
| johnsom | Yeah, until the deprecation cycle is up. | 20:20 |
| rm_work | because I could make the patch to octavia to make it actually check those ids, and actually reject requests where they don't match correctly | 20:21 |
| *** yamamoto has quit IRC | 20:21 | |
| rm_work | the question is, should we? | 20:21 |
| rm_work | or should we skip/fix those "bad" negative tests | 20:21 |
| xgerman_ | my proxy handles tenant_id just fine | 20:21 |
| *** velizarx has joined #openstack-lbaas | 20:21 | |
| xgerman_ | but yeah, skipping tests is fine | 20:22 |
| rm_work | yeah, my goal is different than yours | 20:22 |
| johnsom | Ah, they can be removed in "S" | 20:22 |
| rm_work | i'm trying to prove octavia's backwards-compatibility | 20:22 |
| rm_work | and this proves there are some differences | 20:23 |
| rm_work | so, what do we do about that | 20:23 |
| xgerman_ | backward compatible != parot every single thing n-lbaas does | 20:23 |
| rm_work | k | 20:23 |
| rm_work | that's one | 20:23 |
| rm_work | i'd need another person to agree to get a merge, at least :P | 20:23 |
| *** rm_mobile| has quit IRC | 20:24 | |
| johnsom | I guess I am fine with patching octavia to slightly care about submitted project_ids on sub-objects. But on the otherhand I doubt it really matters/gets used, so skipping is ok too. | 20:24 |
| *** sshank has joined #openstack-lbaas | 20:24 | |
| rm_work | k | 20:24 |
| johnsom | Let's move on in the agenda and come back to proxies in open discussion | 20:25 |
| cgoncalves_ | octavia resources are immutable on transient states. neutron-lbaas´ are not, or are so quick to flip between states that most users don´t notice it and hence further requests succeed | 20:25 |
| xgerman_ | +1 | 20:25 |
| johnsom | neutron-lbaas resources are in fact immutable during transitions. | 20:26 |
| johnsom | It is true that some drivers will flip those back to active faster than others. | 20:26 |
| *** AlexeyAbashkin has quit IRC | 20:27 | |
| rm_work | yes. though, neutron-lbaas also lies on returns for updates | 20:27 |
| rm_work | whereas octavia does not | 20:27 |
| rm_work | but yeah, let's move on and come back to this | 20:27 |
| johnsom | The locking in neutron-lbaas is broken pretty badly and high rates of API requests can sometimes get through when it is in an immutable state. | 20:27 |
| johnsom | Yep. | 20:27 |
| johnsom | #topic Muttable config for neutron-lbaas | 20:28 |
| *** openstack changes topic to "Muttable config for neutron-lbaas (Meeting topic: Octavia)" | 20:28 | |
| johnsom | So there is a community goal to enable muttable Oslo configs in projects | 20:28 |
| johnsom | (we still need to do that) | 20:28 |
| *** leitan has joined #openstack-lbaas | 20:28 | |
| johnsom | neutron-lbaas proper will inherit this from neutron as it runs under the neutron context. | 20:28 |
| rm_work | i really think it has only one `t` ;P | 20:29 |
| johnsom | However, there are some sub-processes in neutron-lbaas | 20:29 |
| rm_work | do we even have to worry about n-lbaas | 20:29 |
| rm_work | i say we skip it | 20:29 |
| johnsom | Yeah, it does. Opps, copied over the typo from the agenda | 20:29 |
| johnsom | So someone proposed a patch for neutron-lbaas to enable this: | 20:30 |
| johnsom | #link https://review.openstack.org/#/c/559412/ | 20:30 |
| rm_work | ok, so, enable it for no actual vars right? | 20:30 |
| rm_work | fine by me, merge that, call it done | 20:30 |
| johnsom | I initially -1'd it because this is a feature IMO and these are sub-processes that probably don't matter much. | 20:30 |
| johnsom | I see it was abandoned | 20:31 |
| rm_work | My only point here is that we should not waste too much time on n-lbaas | 20:31 |
| johnsom | So the question to the team is "do we care"? | 20:31 |
| rm_work | doing something like this that just doesn't matter | 20:31 |
| rm_work | so | 20:31 |
| rm_work | obviously you know my answer | 20:31 |
| johnsom | Well, that makes two votes of "don't care". Any other comments? | 20:32 |
| xgerman_ | I have seen people fixing bugs/making improvements on n-lbaas so if a patch show up… | 20:32 |
| johnsom | Ok then, leaving it abandoned | 20:32 |
| cgoncalves_ | johnsom: you made a good point, though: n-lbaas runs under the neutron context so it will inherit from it. it would be half implemented if not extending to sub-processes | 20:33 |
| johnsom | Fixing bugs is of course still important for neutron-lbaas, but features no. | 20:33 |
| cgoncalves_ | again, neutral vote from my side | 20:33 |
| johnsom | Ok, I think we leave it as-is. | 20:33 |
| johnsom | #topic Open Discussion | 20:34 |
| *** openstack changes topic to "Open Discussion (Meeting topic: Octavia)" | 20:34 | |
| johnsom | Ok, other topics? | 20:34 |
| rm_work | << | 20:35 |
| * johnsom taps the mic to see if it is on | 20:35 | |
| nmagnezi | just to keep everyone posted | 20:35 |
| nmagnezi | we discussed the storyboard issues that were raised here a few weeks ago | 20:36 |
| nmagnezi | with the storyboard team | 20:36 |
| nmagnezi | see: http://eavesdrop.openstack.org/meetings/storyboard/2018/storyboard.2018-04-25-19.02.log.html#l-40 | 20:36 |
| nmagnezi | we will follow up next week. | 20:36 |
| *** velizarx has quit IRC | 20:36 | |
| nmagnezi | #link http://eavesdrop.openstack.org/meetings/storyboard/2018/storyboard.2018-04-25-19.02.log.html#l-40 | 20:37 |
| johnsom | I also see some chatter in their IRC channel | 20:37 |
| johnsom | Though it's "use tags" so maybe not what you are looking for. | 20:38 |
| nmagnezi | indeed it's not.. | 20:38 |
| johnsom | cgoncalves_ Did we answer your neutron-lbaas questions (statement) above? | 20:38 |
| cgoncalves_ | johnsom: yes | 20:39 |
| *** tesseract has quit IRC | 20:40 | |
| rm_work | sooo.... proxy? | 20:40 |
| johnsom | Ok, yeah, the locking in neutron-lbaas would require a complete rewrite to completely fix. Oh, wait, I have that right here....... | 20:41 |
| rm_work | lol yes | 20:41 |
| rm_work | For the proxy thing, really the core question is: how backwards compatible do we need/want to be with neutron-lbaas? | 20:41 |
| cgoncalves_ | the kuryr folks were expecting octavia to be fully compatible with n-lbaas, including heat support. took some time to convince them it doesnt work as they would have hoped | 20:41 |
| rm_work | really the only tests that don't pass when run directly against octavia are some of the negative stuff | 20:41 |
| rm_work | I did find a couple of real bugs, which i have patches up for | 20:42 |
| rm_work | cgoncalves_: so, what i am proving is that it CAN Be | 20:42 |
| johnsom | cgoncalves_ Yes, it should be basically switching the endpoint. If it's not I would like to know what they ran into. | 20:42 |
| rm_work | cgoncalves_: did you look at the proxy gate i am testing? | 20:42 |
| xgerman_ | there is such a big need for backwards compatibility that we have two proxies | 20:42 |
| cgoncalves_ | rm_work: pssssst! they could be reading :P | 20:42 |
| *** pcaruana has quit IRC | 20:42 | |
| johnsom | We are making the hard call to even pull forward some neutron bugs (IMO) to make it compat | 20:43 |
| cgoncalves_ | rm_work: not yours, no, sorry | 20:43 |
| rm_work | cgoncalves_: i am literally putting haproxy in front of neutron, and L7-Redirecting calls to lbaas to the octavia API | 20:43 |
| rm_work | so zero code changes, no neutron-lbaas installed at all, it will work | 20:43 |
| rm_work | *zero code changes in end-user apps | 20:44 |
| rm_work | it requires us to add a compatibility layer in octavia | 20:44 |
| johnsom | At least up to the level the neutron-lbaas tempest tests are testing | 20:44 |
| cgoncalves_ | johnsom: I quickly set up an env with neutron-lbaas+octavia driver and ran heat neutron-lbaas resources. it failed because of immutability so I hard stopped there | 20:44 |
| rm_work | mainly it's about the deprecated tenant-id stuff | 20:44 |
| xgerman_ | cgoncalves_: that won’t be fixed in any of them | 20:45 |
| rm_work | cgoncalves_: well, our immutability is the same as neutron-lbaas, sooooo if that was broken, then it's broken for n-lbaas too | 20:45 |
| rm_work | and if it works, it's only by sheer luck | 20:45 |
| johnsom | cgoncalves_ I'm not following. Both use the PENDING_* states | 20:45 |
| xgerman_ | heat probably doesn’t wait | 20:46 |
| johnsom | Was heat just not checking them in neutron-lbaas? | 20:46 |
| cgoncalves_ | ah, sorry. I meant to say an env with neutron-lbaas + proxy to octavia (not the octavia driver itself) | 20:46 |
| rm_work | if so, that's broken for either neutron-lbaas OR octavia | 20:46 |
| rm_work | cgoncalves_: my style of proxy or xgerman_'s? | 20:46 |
| xgerman_ | mine | 20:46 |
| johnsom | lol | 20:46 |
| cgoncalves_ | rm_work: xgerman_'s | 20:47 |
| rm_work | k | 20:47 |
| johnsom | Ah, yeah, xgerman's proxy wasn't working until like this week | 20:47 |
| xgerman_ | but as I said earlier having tow proxies is confusing for users | 20:47 |
| rm_work | yeah... | 20:47 |
| xgerman_ | it was working | 20:47 |
| xgerman_ | just not passing the tests | 20:47 |
| johnsom | Not that I ever saw | 20:47 |
| cgoncalves_ | johnsom: I quickly had a look at the heat support for neutron-lbaas and there are some waiting/status polling | 20:47 |
| johnsom | Ok, yeah, it should be "the same" | 20:48 |
| rm_work | xgerman_: i'd rather not get into "there can only be one" | 20:48 |
| rm_work | especially since, my "proxy" isn't actually anything | 20:48 |
| rm_work | it's just a method | 20:48 |
| rm_work | no code | 20:48 |
| cgoncalves_ | anyway, they were still using on n-lbaas because octavia doc was recommending that. I submitted a doc patch to fix that | 20:49 |
| rm_work | but it is what i have been recommending and will continue to recommend | 20:49 |
| johnsom | Yeah, that doc change merged right? | 20:49 |
| cgoncalves_ | yes | 20:49 |
| johnsom | Cool | 20:49 |
| johnsom | Yeah, I don't have a problem with providing options for folks migrating. | 20:51 |
| johnsom | I don't think we want to "support" anything that isn't gating though. Plus I don't want to load up the octavia repo with stuff that is neutron-lbaas specific beyond having a compatible API. | 20:52 |
| rm_work | yeah, need to decide exactly how to progress with that | 20:52 |
| rm_work | the patch i have on the neutron-lbaas side is *just* a gate | 20:52 |
| xgerman_ | my plan is to fix the gate (obviously) | 20:52 |
| rm_work | and a few test fixes (a lot of which are similar to / based on the ones in xgerman_'s proxy patch) | 20:53 |
| johnsom | Is there something we need to decide here or just discussion of the parallel paths / options for migration? | 20:55 |
| rm_work | wanted to ask if we should try to make octavia 100% compatible even with the negative test stuff | 20:56 |
| rm_work | or if it's ok to just ignore some of those | 20:56 |
| rm_work | because no one will likely see the difference | 20:56 |
| rm_work | unless they were relying on neutron blocking bad calls | 20:56 |
| rm_work | in a very specific way | 20:57 |
| xgerman_ | I think we should chart our own course … and only do stuff which was in the API doc and not some quirks n-lbaas had | 20:57 |
| *** samccann has quit IRC | 20:58 | |
| johnsom | The project_id on the sub-objects was an admin only thing that doesn't make any sense. As octavia is coded, it will "do the right thing", just silently instead of slapping your wrist. | 20:58 |
| xgerman_ | +1 | 20:58 |
| johnsom | Were there any others? | 20:58 |
| rm_work | k that's pretty much it | 20:59 |
| johnsom | Ok cool. | 20:59 |
| johnsom | We are about out of time anyway. | 20:59 |
| johnsom | Thanks folks! | 20:59 |
| johnsom | #endmeeting | 20:59 |
| *** openstack changes topic to "Discussion of OpenStack Load Balancing (Octavia) | https://etherpad.openstack.org/p/octavia-priority-reviews" | 20:59 | |
| openstack | Meeting ended Wed Apr 25 20:59:43 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 20:59 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/octavia/2018/octavia.2018-04-25-20.00.html | 20:59 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/octavia/2018/octavia.2018-04-25-20.00.txt | 20:59 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/octavia/2018/octavia.2018-04-25-20.00.log.html | 20:59 |
| cgoncalves_ | johnsom, xgerman_, rm_work: btw, I herein invite you to attend http://connect.trilio.io/trilio-red-hat-invite-you (hopefully they're still taking new registrations) | 21:00 |
| cgoncalves_ | with that, I'm out for today. | 21:00 |
| johnsom | lol Thanks! | 21:00 |
| *** cgoncalves_ has quit IRC | 21:00 | |
| xgerman_ | THANKS!! | 21:01 |
| rm_work | ;P | 21:01 |
| xgerman_ | Ryan would never have done that | 21:01 |
| johnsom | Does this mean we have to help him with OSP 13 now? | 21:02 |
| rm_work | rsvp'd ;) | 21:02 |
| *** sshank has quit IRC | 21:04 | |
| *** diablo_rojo has joined #openstack-lbaas | 21:06 | |
| diablo_rojo | nmagnezi, I am almost done going though your super helpful list: https://etherpad.openstack.org/p/storyboard-issues | 21:07 |
| diablo_rojo | Just wanted to give you a heads up | 21:07 |
| nmagnezi | diablo_rojo thank you! :) | 21:07 |
| diablo_rojo | There are one or two I am looking for if stories already exist. If they don't, I will make them and add links. | 21:08 |
| diablo_rojo | nmagnezi, we care about you and want you to be happy using storyboard :) Just having growing pains, the same as all projects/software does. | 21:08 |
| rm_work | oh i forgot to check if "make comments editable" is on there, lol | 21:16 |
| rm_work | that would help with the bad formatting, a lot of it is just "oops, did that wrong" but no way to fix it | 21:17 |
| *** yamamoto has joined #openstack-lbaas | 21:17 | |
| johnsom | Not too late to add | 21:18 |
| *** openstackgerrit has quit IRC | 21:20 | |
| *** leitan has quit IRC | 21:21 | |
| *** yamamoto has quit IRC | 21:23 | |
| *** slaweq has quit IRC | 22:17 | |
| *** threestrands has joined #openstack-lbaas | 22:17 | |
| *** slaweq has joined #openstack-lbaas | 22:18 | |
| *** yamamoto has joined #openstack-lbaas | 22:19 | |
| *** slaweq has quit IRC | 22:23 | |
| *** yamamoto has quit IRC | 22:24 | |
| *** rcernin has joined #openstack-lbaas | 22:52 | |
| *** sshank has joined #openstack-lbaas | 23:03 | |
| *** yamamoto has joined #openstack-lbaas | 23:09 | |
| *** diablo_rojo has quit IRC | 23:10 | |
| *** fnaval has quit IRC | 23:29 | |
| rm_work | does anyone recall offhand how the keepalived check script gets put in /bin/ on the amp? | 23:32 |
| rm_work | is that by the agent at runtime when we do something, or does it ship? | 23:32 |
| rm_work | that's my problem -- it's just... gone | 23:33 |
| rm_work | when I create an LB on the old image, it's there, but on the new one it isn't | 23:33 |
| rm_work | so i'm assuming it's shipped? | 23:33 |
| rm_work | and somehow i broke it? | 23:33 |
| *** threestrands_ has joined #openstack-lbaas | 23:35 | |
| rm_work | OHHHH | 23:36 |
| rm_work | johnsom broke it | 23:36 |
| rm_work | it ends up in /opt/amphora-agent-venv/bin/haproxy-vrrp-check | 23:36 |
| johnsom | Oh | 23:36 |
| rm_work | Apr 25 23:37:02 advk98hohd0vj8p.cloud.sin2.gdg Keepalived_vrrp[1603]: /var/lib/octavia/vrrp/check_script.sh exited with status 127 | 23:37 |
| rm_work | so i get a ton of that | 23:37 |
| rm_work | hmmm | 23:38 |
| *** threestrands has quit IRC | 23:38 | |
| rm_work | though i need to see if it's because it can't find it | 23:38 |
| rm_work | or if it's because it is actually breaking | 23:38 |
| rm_work | but it definitely broke something else of mine :P | 23:38 |
| rm_work | I guess I need to link it in to /bin | 23:38 |
| rm_work | when i source the venv and then run the check script | 23:39 |
| rm_work | I get exit code 0 | 23:39 |
| rm_work | yeah | 23:39 |
| rm_work | and without it sourced i get 127 | 23:39 |
| rm_work | so yes, keepalived is failing | 23:39 |
| rm_work | it's not running inside the venv | 23:39 |
| rm_work | and it can't find the right thing | 23:40 |
| rm_work | johnsom: is this purely a centos problem? did you fix this for ubuntu? | 23:40 |
| rm_work | i thought i saw something in the change about linking the files back to bin | 23:40 |
| johnsom | I did do some linking in the amp-agent element | 23:41 |
| johnsom | But I don't think it fixes this | 23:41 |
| rm_work | ah just the agent | 23:41 |
| rm_work | yeah so | 23:41 |
| rm_work | this should be broken for master for everyone, yes? | 23:41 |
| rm_work | or is this a just-me problem somehow | 23:42 |
| johnsom | I'm not sure... | 23:42 |
| johnsom | Sadly, we don't have an act/stdby gate | 23:42 |
| rm_work | pretty sure keepalived doesn't run inside the venv | 23:42 |
| rm_work | because why would it | 23:42 |
| rm_work | in which case, the script is not in path | 23:42 |
| rm_work | so... do we link out that script too? | 23:43 |
| rm_work | is that the fix? | 23:43 |
| johnsom | No, and should not | 23:43 |
| johnsom | I'm confused, because that script and it's calls to it should always be in /var/lib/octavia | 23:44 |
| rm_work | errr what? | 23:44 |
| rm_work | no | 23:44 |
| rm_work | in our keepalived conf | 23:44 |
| rm_work | we call /var/lib/octavia/vrrp/check_script.sh | 23:44 |
| rm_work | and that file runs everything in /var/lib/octavia/vrrp/check_scripts/ | 23:45 |
| rm_work | and that script doesn't provide a full path | 23:45 |
| rm_work | it just runs `haproxy-vrrp-check /var/lib/octavia/2ead852d-0808-41df-bdac-e30066d0c04d.sock; exit $?` | 23:45 |
| *** fnaval has joined #openstack-lbaas | 23:45 | |
| rm_work | or you know, whatever the sock | 23:45 |
| *** fnaval has quit IRC | 23:45 | |
| rm_work | so the actual `haproxy-vrrp-check` script needs to be in PATH | 23:46 |
| *** fnaval has joined #openstack-lbaas | 23:46 | |
| johnsom | Oh, ok, so it's that part. This makes more sense now | 23:46 |
| rm_work | because that's `haproxy-vrrp-check = octavia.cmd.haproxy_vrrp_check:main` | 23:46 |
| rm_work | installed in the venv | 23:46 |
| rm_work | SO | 23:47 |
| rm_work | should we link it out, along with the agent? | 23:47 |
| johnsom | Yeah, ok | 23:47 |
| rm_work | and, yes, this is broken in master for everyone | 23:47 |
| johnsom | Yes, that is what needs to happen | 23:47 |
| rm_work | ok | 23:47 |
| rm_work | i'll do that | 23:47 |
| johnsom | Ok | 23:47 |
| johnsom | I totally forgot all about that command | 23:47 |
| *** sshank has quit IRC | 23:48 | |
| rm_work | so | 23:49 |
| *** openstackgerrit has joined #openstack-lbaas | 23:49 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Fix keepalived vrrp check script to be in PATH https://review.openstack.org/564371 | 23:49 |
| rm_work | if we can merge it like that ^^ I will be appreciative | 23:49 |
| rm_work | it saves me from extra patching | 23:49 |
| rm_work | if you're not ok with that... I can add it to my list of internal patches | 23:50 |
| rm_work | (I have my own haproxy-vrrp-alert script) | 23:50 |
| rm_work | ;) | 23:50 |
| johnsom | That works? a multiple link like that? | 23:51 |
| rm_work | yes | 23:52 |
| rm_work | I mean, i'm 99% sure | 23:52 |
| rm_work | i do stuff like that all the time IIRC | 23:52 |
| rm_work | let me verify | 23:52 |
| rm_work | oh | 23:52 |
| johnsom | yes | 23:52 |
| johnsom | it does | 23:52 |
| rm_work | i mean yes, i actually did exactly that to test | 23:52 |
| rm_work | lol | 23:52 |
| rm_work | i forgot | 23:52 |
| johnsom | So, I would love to -1 for a test, but I think we need to get this in | 23:52 |
| rm_work | and yeah normally with linking i don't bother specifying the destination filename | 23:52 |
| rm_work | how do we test this :/ | 23:53 |
| rm_work | we have no tests for elements do we? | 23:53 |
| johnsom | tempest plugin | 23:53 |
| rm_work | ah yes | 23:53 |
| rm_work | soooo | 23:53 |
| rm_work | we need an active/standby test | 23:53 |
| rm_work | lol | 23:53 |
| rm_work | -1 for ADD ACTIVE STANDBY GATE TO TEMPEST | 23:53 |
| rm_work | lol | 23:53 |
| rm_work | I would be sad :P | 23:53 |
| rm_work | brb | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
