*** yamamoto has joined #openstack-lbaas | 00:02 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Set lower-constraint to run unit and functional https://review.openstack.org/557549 | 00:06 |
---|---|---|
*** yamamoto has quit IRC | 00:08 | |
*** Swami has quit IRC | 00:09 | |
openstackgerrit | Michael Johnson proposed openstack/octavia-dashboard master: add lower-constraints job https://review.openstack.org/555967 | 00:15 |
openstackgerrit | Michael Johnson proposed openstack/python-octaviaclient master: add lower-constraints job https://review.openstack.org/556170 | 00:18 |
*** jniesz has quit IRC | 00:19 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Set lower-constraint to run unit and functional https://review.openstack.org/557549 | 00:23 |
rm_work | johnsom: usage stuff is up | 00:25 |
rm_work | johnsom: maybe review just the format (in the test file at the top) | 00:25 |
rm_work | make sure that looks OK to you | 00:25 |
johnsom | rm_work There are a few lower constraint patches ^^^^ that are quick reviews | 00:25 |
rm_work | I am happy with this patch because i did legit 100% TDD | 00:25 |
rm_work | the tests existed exactly as they do now before i touched ANY other code at all :P | 00:26 |
rm_work | possibly the first and last time i do pure TDD lol | 00:26 |
johnsom | Nice. Yeah, will have a look, but it might be later or tomorrow morning. Trying to finish up some stuff and need to head towards making dinner. | 00:28 |
rm_work | yep same | 00:28 |
rm_work | actually had this basically finished like 4 hours ago but i've been working on some dumb internal stuff and wanted to do the api-ref before pushing it but finally gave up | 00:29 |
openstackgerrit | Merged openstack/neutron-lbaas-dashboard master: add lower-constraints job https://review.openstack.org/555944 | 00:35 |
openstackgerrit | Michael Johnson proposed openstack/octavia-dashboard master: Use pool name as hint for selecting pool id https://review.openstack.org/553124 | 00:40 |
*** blake has joined #openstack-lbaas | 00:44 | |
openstackgerrit | Michael Johnson proposed openstack/octavia-dashboard master: Align model with v2 api https://review.openstack.org/554198 | 00:45 |
openstackgerrit | Michael Johnson proposed openstack/octavia-dashboard master: Being able to change insert headers of listener https://review.openstack.org/549999 | 00:49 |
rm_work | yep | 00:50 |
*** dayou has quit IRC | 00:56 | |
johnsom | Ok, finished reviewing that chain of dashboard patches.... | 00:57 |
*** yamamoto has joined #openstack-lbaas | 01:04 | |
johnsom | Eh gad. So these insertion headers.... I think they are all supposed to be booleans, but somewhere along the way we screwed that up and made them strings | 01:06 |
*** AlexeyAbashkin has joined #openstack-lbaas | 01:08 | |
*** yamamoto has quit IRC | 01:09 | |
*** blake has quit IRC | 01:12 | |
*** AlexeyAbashkin has quit IRC | 01:13 | |
*** blake has joined #openstack-lbaas | 01:36 | |
*** dayou has joined #openstack-lbaas | 01:43 | |
openstackgerrit | Guoqiang Ding proposed openstack/neutron-lbaas master: Modify a detail in parse_stat https://review.openstack.org/522124 | 01:55 |
dayou | cgoncalves, that looks promising, great work! | 02:03 |
*** yamamoto has joined #openstack-lbaas | 02:05 | |
openstackgerrit | Merged openstack/octavia-dashboard master: add lower-constraints job https://review.openstack.org/555967 | 02:06 |
*** yamamoto has quit IRC | 02:11 | |
*** blake has quit IRC | 02:18 | |
*** yamamoto has joined #openstack-lbaas | 02:47 | |
*** links has joined #openstack-lbaas | 03:12 | |
johnsom | dayou I did reviews of your big line of patches for dashboard. I left comments on a few of them | 03:13 |
dayou | johnsom, thank you, working on the comments and try to fix them | 03:14 |
johnsom | Ok, cool. Let me know if you have questions or counter answers | 03:14 |
johnsom | Sorry for the delay reviewing dashboard patches. We are a bit behind there. But working to catch up | 03:15 |
dayou | Sure, no worry, I understand we both have several things to do in parallel | 03:15 |
johnsom | Yep | 03:16 |
openstackgerrit | Guoqiang Ding proposed openstack/neutron-lbaas master: Choose correct log option by listener protocol https://review.openstack.org/453612 | 03:24 |
*** harlowja has quit IRC | 03:24 | |
*** ianychoi__ has joined #openstack-lbaas | 03:47 | |
*** pck has quit IRC | 03:49 | |
*** annp has quit IRC | 03:49 | |
*** ianychoi_ has quit IRC | 03:50 | |
*** bbzhao has quit IRC | 03:50 | |
*** bbzhao has joined #openstack-lbaas | 03:51 | |
*** harlowja has joined #openstack-lbaas | 03:59 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 04:09 | |
*** sticker has quit IRC | 04:12 | |
*** AlexeyAbashkin has quit IRC | 04:14 | |
*** ianychoi__ is now known as ianychoi | 04:29 | |
*** rcernin_ has joined #openstack-lbaas | 04:59 | |
*** rcernin has quit IRC | 05:00 | |
*** harlowja has quit IRC | 06:06 | |
*** rcernin_ has quit IRC | 06:14 | |
*** rcernin has joined #openstack-lbaas | 06:17 | |
*** gokhan_ has joined #openstack-lbaas | 06:19 | |
cgoncalves | dayou: congrats on becoming octavia core! \o/ | 06:53 |
*** Alex_Staf has joined #openstack-lbaas | 06:53 | |
dayou | cgoncalves: thanks, \o/ | 06:55 |
openstackgerrit | Jacky Hu proposed openstack/octavia-dashboard master: Add rbac support for octavia service apis https://review.openstack.org/550319 | 06:55 |
openstackgerrit | ShangXiao proposed openstack/octavia-dashboard master: Add release notes link to README https://review.openstack.org/557624 | 06:56 |
*** velizarx has joined #openstack-lbaas | 06:56 | |
openstackgerrit | Jacky Hu proposed openstack/octavia-dashboard master: Add rbac support for octavia service apis https://review.openstack.org/550319 | 07:00 |
*** rcernin has quit IRC | 07:03 | |
*** blake has joined #openstack-lbaas | 07:04 | |
*** chandankumar has quit IRC | 07:04 | |
openstackgerrit | ShangXiao proposed openstack/python-octaviaclient master: Add release notes link to README https://review.openstack.org/557627 | 07:04 |
*** links has quit IRC | 07:05 | |
*** links has joined #openstack-lbaas | 07:06 | |
*** chandankumar has joined #openstack-lbaas | 07:09 | |
*** kobis has joined #openstack-lbaas | 07:16 | |
*** velizarx has quit IRC | 07:16 | |
*** yamamoto has quit IRC | 07:22 | |
*** tesseract has joined #openstack-lbaas | 07:22 | |
*** yamamoto has joined #openstack-lbaas | 07:23 | |
*** velizarx has joined #openstack-lbaas | 07:31 | |
*** yamamoto_ has joined #openstack-lbaas | 07:32 | |
*** yamamoto has quit IRC | 07:34 | |
*** blake has quit IRC | 07:40 | |
*** huseyin has joined #openstack-lbaas | 07:56 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 08:00 | |
*** AlexeyAbashkin has quit IRC | 08:07 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 08:10 | |
openstackgerrit | Boris Bobrov proposed openstack/neutron-lbaas master: Cap haproxy log level severity https://review.openstack.org/557647 | 08:21 |
*** rcernin has joined #openstack-lbaas | 08:48 | |
*** Alexey_Abashkin has joined #openstack-lbaas | 08:52 | |
*** AlexeyAbashkin has quit IRC | 08:54 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 08:54 | |
*** AlexeyAbashkin has quit IRC | 08:55 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 08:58 | |
*** kobis has quit IRC | 09:21 | |
*** kobis has joined #openstack-lbaas | 09:39 | |
openstackgerrit | Thomas Morin proposed openstack/neutron-lbaas master: remove unused plugin.get_plugin_name() https://review.openstack.org/557665 | 10:00 |
*** aojea has joined #openstack-lbaas | 10:09 | |
*** aojea has quit IRC | 10:23 | |
gokhan_ | hi folks, I am trying to install octavia with openstack ansible project. But before that I have questions about network configuration. How can I configure them ? I configure them like create lbaas bridge with untagged vlan interface. my network file is : http://paste.openstack.org/show/717428/ . Also for creating a provider network ı modified my openstack_user_config.yml like http://paste.openstack.org/show/717563/ . I want to be sure that I am | 10:30 |
gokhan_ | doing right things. | 10:30 |
gokhan_ | I also ask about can I use my public network as lbaas provider network? | 10:31 |
gokhan_ | is there anyone who install octavia with openstack ansible ? | 10:33 |
velizarx | gokhan_: I did not work with ansible installation, but I checked your config files and I think it will work. In addition, you also might use tagged VLAN network with real tag. | 10:40 |
*** AlexeyAbashkin has quit IRC | 10:53 | |
*** voelzmo has joined #openstack-lbaas | 10:55 | |
gokhan_ | velizarx, ok you say I can also configure network like this: http://paste.openstack.org/show/717833/ . but with using tagged vlan can I create flat network for octavia ? sorry I am bad at networking | 10:56 |
*** voelzmo has quit IRC | 11:01 | |
*** yamamoto has joined #openstack-lbaas | 11:01 | |
*** voelzmo has joined #openstack-lbaas | 11:01 | |
*** aojea has joined #openstack-lbaas | 11:05 | |
*** yamamoto_ has quit IRC | 11:05 | |
*** aojea has quit IRC | 11:10 | |
*** numans has quit IRC | 11:15 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 11:18 | |
*** numans has joined #openstack-lbaas | 11:18 | |
openstackgerrit | Jacky Hu proposed openstack/octavia-dashboard master: Being able to change insert headers of listener https://review.openstack.org/549999 | 11:19 |
openstackgerrit | Jacky Hu proposed openstack/octavia-dashboard master: Being able to change insert headers of listener https://review.openstack.org/549999 | 11:19 |
*** huseyin has quit IRC | 11:22 | |
velizarx | gokhan_: That's not exactly as you think it is: interfaces like vlan<tag> are untagged interfaces (Linux kernel already deleted the VLAN tag from packets). Interfaces like eno<num> are tagged (raw) interfaces. In this example http://paste.openstack.org/show/717833/ you use the untagged network and the lb-mgmt network must have the flat type. In this example http://paste.openstack.org/show/717428/ you use the tagged network (you add port eno1 to | 11:25 |
velizarx | the bridge br-lbaas) and the lb-mgmt must have the vlan type and | 11:25 |
velizarx | `segment_id <tag>`. But I don't know how VLAN-type network must configure in openstack-ansible :( As a result if you use `bridge_ports vlan40` in the networking file you must use type flat for the network. If you use `bridge_ports eno1` you must use type VLAN for the network. | 11:25 |
openstackgerrit | Jacky Hu proposed openstack/octavia-dashboard master: Add rbac support for octavia service apis https://review.openstack.org/550319 | 11:29 |
*** aojea has joined #openstack-lbaas | 11:34 | |
*** huseyin has joined #openstack-lbaas | 11:41 | |
*** links has quit IRC | 11:49 | |
*** velizarx has quit IRC | 11:51 | |
*** velizarx has joined #openstack-lbaas | 11:52 | |
*** links has joined #openstack-lbaas | 11:54 | |
*** rcernin has quit IRC | 12:05 | |
*** aojea has quit IRC | 12:32 | |
*** aojea has joined #openstack-lbaas | 12:33 | |
*** voelzmo has quit IRC | 12:42 | |
*** sapd has joined #openstack-lbaas | 12:45 | |
*** pck has joined #openstack-lbaas | 12:47 | |
*** pck has quit IRC | 12:49 | |
*** pck has joined #openstack-lbaas | 12:49 | |
*** aojea has quit IRC | 12:50 | |
huseyin | Hi guys, I have a question about amphora image. I finally managed to create an LB and it is in active and online state | 12:56 |
huseyin | On the amphora image, I run into error messages like amphora-agent[1097]: Error in atexit._run_exitfuncs: | 12:56 |
huseyin | amphora-agent[1097]: Traceback (most recent call last): | 12:56 |
huseyin | amphora-agent[1097]: File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs | 12:57 |
huseyin | it is listening on port 9443 | 12:57 |
*** velizarx has quit IRC | 13:04 | |
*** atoth has joined #openstack-lbaas | 13:10 | |
*** velizarx has joined #openstack-lbaas | 13:10 | |
*** aojea has joined #openstack-lbaas | 13:20 | |
*** voelzmo has joined #openstack-lbaas | 13:32 | |
openstackgerrit | Boris Bobrov proposed openstack/neutron-lbaas master: Cap haproxy log level severity https://review.openstack.org/557647 | 13:55 |
*** fnaval has joined #openstack-lbaas | 14:19 | |
*** links has quit IRC | 14:26 | |
huseyin | Hello everyone. Octavia does not add listener’s port rule into the amphora’s security group in my environment. Does anybody run into this issue, or have any idea? | 14:34 |
huseyin | For example, when I create an LB with a listener working on tcp port 3344, the sec group belongs to this LB doesn’t have a rule that allows ingress access to port 3344? | 14:35 |
huseyin | and without adding this rule, I can not access VIP and members behind it via floating IP | 14:36 |
huseyin | Should I open a bug report? | 14:36 |
*** Swami has joined #openstack-lbaas | 14:41 | |
*** Alex_Staf has quit IRC | 14:44 | |
*** huseyin has quit IRC | 14:51 | |
johnsom | huseyin Note that there are two ports created per load balancer, one is a base port and the other is the allowed address pairs port. One is really a fake port in neutron used to track the secondary IP. It is normal that the security group only gets updated (per listener create) on one of the two ports. | 14:54 |
johnsom | huseyin When a listener is created you will find a new security group named "lb-(lb_id)" that gets the new ports added automatically. | 14:57 |
johnsom | huseyin It will have an initial config of port 1025 used for synchronization between the amphora, but the reset of the rules are per-listener | 14:58 |
velizarx | johnsom: Yes he has. But he didn't see tcp rule for the listener on port 80. He added this rule manually, see his paste https://justpaste.it/1ixj6 I tryed to help him. | 15:00 |
*** aojea has quit IRC | 15:02 | |
johnsom | That is super odd as even the default 1025 rule is not there. Maybe a permissions problem when contacting neutron? | 15:03 |
velizarx | Now he is away. When he comes maybe will add some details :) | 15:04 |
johnsom | Yeah, I am just starting my day, though he has been on during my morning in the past, so hopefully will be back | 15:04 |
*** aojea has joined #openstack-lbaas | 15:05 | |
*** aojea has quit IRC | 15:09 | |
*** imacdonn has quit IRC | 15:27 | |
openstackgerrit | Michael Johnson proposed openstack/octavia-dashboard master: Being able to change insert headers of listener https://review.openstack.org/549999 | 15:27 |
*** imacdonn has joined #openstack-lbaas | 15:27 | |
*** huseyin has joined #openstack-lbaas | 15:29 | |
*** velizarx has quit IRC | 15:35 | |
*** kobis has quit IRC | 15:40 | |
*** aojea has joined #openstack-lbaas | 15:46 | |
*** aojea has quit IRC | 15:51 | |
*** links has joined #openstack-lbaas | 15:54 | |
*** Swami has quit IRC | 15:56 | |
*** voelzmo has quit IRC | 15:57 | |
*** voelzmo has joined #openstack-lbaas | 15:57 | |
*** voelzmo has quit IRC | 16:02 | |
*** yamamoto has quit IRC | 16:04 | |
*** yamamoto has joined #openstack-lbaas | 16:07 | |
johnsom | rm_work if you have a quick minute: https://review.openstack.org/#/c/556170/ and https://review.openstack.org/#/c/555943/ | 16:13 |
johnsom | With those I can put in the governance for all of our repos. | 16:13 |
nmagnezi | johnsom, done and done | 16:21 |
nmagnezi | :-) | 16:21 |
*** links has quit IRC | 16:22 | |
*** yamamoto has quit IRC | 16:24 | |
johnsom | Thanks Nir! | 16:24 |
nmagnezi | johnsom, with pleasure | 16:26 |
johnsom | FYI, we got huseyin up and running. The service account was out of security group quota. | 16:26 |
nmagnezi | johnsom, btw we added some more stuff about storyboard to the etherpad. I will give ppl few more days before I approach the storyboard team | 16:27 |
nmagnezi | huseyin? | 16:27 |
* nmagnezi needs to google it.. | 16:27 | |
nmagnezi | :D | 16:27 |
johnsom | It's an IRC nic | 16:27 |
johnsom | Thanks Nir. I'm all about the let's make it work better for us. | 16:28 |
nmagnezi | johnsom, +1. we really want to jump start a proactive backport process for Octavia. and storyboard is key in making that happen | 16:29 |
johnsom | FYI, there is a survey in your e-mail, from the foundation about the future of the PTGs. | 16:29 |
nmagnezi | such thing will benefit all | 16:29 |
nmagnezi | will fill it. thanks you :) | 16:29 |
nmagnezi | johnsom, one more thing | 16:29 |
johnsom | Nir Cool. Glad you guys are on top of that. | 16:29 |
*** yamamoto has joined #openstack-lbaas | 16:29 | |
nmagnezi | about Rally | 16:29 |
openstackgerrit | Merged openstack/python-octaviaclient master: add lower-constraints job https://review.openstack.org/556170 | 16:30 |
nmagnezi | we had some issues this week that prevented us from doing actual perf testing | 16:30 |
johnsom | Ok | 16:30 |
nmagnezi | *but* | 16:30 |
nmagnezi | we got approval to keep using that lab for longer | 16:30 |
nmagnezi | so we will still do it | 16:30 |
nmagnezi | as soon as we have something we will share the data | 16:30 |
johnsom | Nice. | 16:30 |
johnsom | I might have access to a lab off hours too. Sadly, I just don't have the cycles to spend on it right now. | 16:31 |
nmagnezi | understandable | 16:31 |
nmagnezi | you have a lot going on I see | 16:31 |
johnsom | nmagnezi BTW, if you have some review cycles, octavia-dashboard has a bunch of patches with one +2. I reviewed the whole chain yesterday. | 16:31 |
*** huseyin has left #openstack-lbaas | 16:32 | |
nmagnezi | sure can. going offline in a few but I will dedicate part of Sunday for this | 16:32 |
johnsom | Ok, thanks! Have a good weekend | 16:32 |
nmagnezi | thanks Michael | 16:32 |
nmagnezi | you too | 16:32 |
nmagnezi | :) | 16:32 |
*** yamamoto has quit IRC | 16:34 | |
*** AlexeyAbashkin has quit IRC | 16:53 | |
*** JudeC has joined #openstack-lbaas | 17:03 | |
*** chandankumar has quit IRC | 17:10 | |
*** chkumar246 has joined #openstack-lbaas | 17:27 | |
*** yamamoto has joined #openstack-lbaas | 17:30 | |
*** aojea has joined #openstack-lbaas | 17:35 | |
*** yamamoto has quit IRC | 17:37 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Update API-REF for x-forwarded-port is boolean https://review.openstack.org/557781 | 17:37 |
*** aojea has quit IRC | 17:39 | |
*** JudeC_ has joined #openstack-lbaas | 17:47 | |
*** JudeC has quit IRC | 17:47 | |
openstackgerrit | Merged openstack/neutron-lbaas master: add lower-constraints job https://review.openstack.org/555943 | 17:51 |
*** sapd has quit IRC | 18:01 | |
*** harlowja has joined #openstack-lbaas | 18:01 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 18:18 | |
*** AlexeyAbashkin has quit IRC | 18:23 | |
*** voelzmo has joined #openstack-lbaas | 18:24 | |
*** voelzmo_ has joined #openstack-lbaas | 18:25 | |
*** ivve has quit IRC | 18:28 | |
*** voelzmo has quit IRC | 18:28 | |
*** tesseract has quit IRC | 18:31 | |
*** yamamoto has joined #openstack-lbaas | 18:33 | |
*** aojea has joined #openstack-lbaas | 18:33 | |
*** yamamoto has quit IRC | 18:38 | |
openstackgerrit | Murali Annamneni proposed openstack/neutron-lbaas master: Hardcode foreignkey constraint name for lbaas_listeners https://review.openstack.org/557797 | 18:41 |
*** ivve has joined #openstack-lbaas | 18:46 | |
*** voelzmo_ has quit IRC | 18:59 | |
*** aojea has quit IRC | 19:01 | |
*** kobis has joined #openstack-lbaas | 19:02 | |
*** voelzmo has joined #openstack-lbaas | 19:05 | |
*** ivve has quit IRC | 19:07 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 19:08 | |
*** aojea has joined #openstack-lbaas | 19:09 | |
*** kobis has quit IRC | 19:10 | |
rm_work | i have access to a whole cloud to do perf testing ;P but also not the time | 19:11 |
johnsom | Bummer | 19:12 |
rm_work | johnsom: didn't we want to allow headers to be strings because we were allowing to add custom stuff if people wanted? | 19:12 |
johnsom | Well, it's a dict(str, str), but these two are both booleans | 19:13 |
*** AlexeyAbashkin has quit IRC | 19:13 | |
johnsom | I fixed this: https://review.openstack.org/557781 | 19:13 |
*** kobis has joined #openstack-lbaas | 19:14 | |
johnsom | Which I think is good enough for now. It's just odd that those are | 19:14 |
rm_work | ah yeah THAT was a bug | 19:14 |
johnsom | https://www.irccloud.com/pastebin/NmcH0RDz/ | 19:14 |
johnsom | Where others are true boolean: "admin_state_up": true, | 19:14 |
rm_work | right but | 19:14 |
rm_work | we wanted to allow the headers to be strings | 19:15 |
rm_work | so we can't set it as a dict of str->bool | 19:15 |
johnsom | Yeah, not sure about that. It's stored strange, etc. | 19:16 |
johnsom | I decided I had more important things to address, so fixed the doc and moved on | 19:16 |
rm_work | this came out of multiple meetings, and a midcycle with kobis | 19:16 |
johnsom | Right | 19:16 |
rm_work | i remember it quite vividly actually | 19:16 |
rm_work | what we eventually decided to do was leave it flexible | 19:16 |
rm_work | though, THIS is interesting: wtypes.DictType(str, wtypes.StringType(max_length=255)) | 19:17 |
rm_work | the key is just "str" but the value is StringType(max 255) | 19:17 |
rm_work | why did we do THAT <_< | 19:17 |
johnsom | Yeah, I think DictType doesn't allow anything other than str | 19:17 |
johnsom | If I remember, it does still have some protection if you dig into their code. | 19:18 |
johnsom | Pretty sure I was the one that did that.... | 19:18 |
johnsom | Because I remember digging in their code about it | 19:18 |
rm_work | k | 19:19 |
johnsom | But, feel free to dig in if you want. It's odd | 19:19 |
rm_work | more important stuff to do | 19:20 |
rm_work | like see if i need to update any of my CRs | 19:20 |
johnsom | I am finally back to merging in the ipv6 api tests so I can wrap this tempest plugin | 19:20 |
johnsom | I did give the usage a quick glance last night, I think the format looks good to me | 19:20 |
*** voelzmo has quit IRC | 19:21 | |
rm_work | i need to check the formatting of the ones with underscores | 19:21 |
rm_work | and make sure it matches the exposed names | 19:21 |
rm_work | i HATE HATE HATE that load_balancers sometimes has an underscore | 19:21 |
johnsom | Yeah, isn't that like a limitation of oslo config? | 19:22 |
rm_work | errr | 19:22 |
rm_work | no that was blogan being a dumdum | 19:22 |
johnsom | Maybe I am remembering wrong | 19:22 |
johnsom | ah | 19:23 |
rm_work | i mean it could just be "loadbalancers" | 19:23 |
rm_work | but like, in our DB | 19:23 |
rm_work | it's load_balancer | 19:23 |
rm_work | fffff I might change it | 19:23 |
rm_work | that's migratable | 19:23 |
rm_work | THE GREAT UNIFICATION | 19:23 |
rm_work | make loadbalancer and healthmonitor consistently named | 19:23 |
johnsom | lol | 19:24 |
rm_work | BTW what actually happens if you pass the insert-header values as json booleans? | 19:24 |
rm_work | does it break? | 19:24 |
rm_work | because listing them in the API-REF as boolean might still be wrong | 19:24 |
rm_work | we might have to actually note that they're strings | 19:24 |
johnsom | Yeah, I think it rejects it | 19:25 |
rm_work | johnsom: https://review.openstack.org/#/c/556989/ would be good because lol | 19:28 |
rm_work | i would just remove it but that wouldn't be a cherry-pick | 19:28 |
johnsom | No, I deleted that job in my patch. You guys merged this, but there is no content to that job, it just needs to die | 19:28 |
johnsom | here: https://review.openstack.org/#/c/541039/11/zuul.d/projects.yaml | 19:30 |
johnsom | But that patch needs work now, it has bit rot | 19:30 |
johnsom | Which is back to where I am working on the tempest plugin | 19:31 |
*** yamamoto has joined #openstack-lbaas | 19:35 | |
rm_work | ok but the one i linked is backporting to queens | 19:35 |
rm_work | would we be backporting yours? | 19:35 |
rm_work | johnsom: ^^ | 19:36 |
johnsom | I will give you a strong maybe | 19:37 |
rm_work | hmmm... k | 19:37 |
rm_work | well | 19:37 |
johnsom | Either way, it just needs deleted | 19:38 |
rm_work | backporting this first puts it in a matching state to master, which will make your backport easier because it won't merge-conflict ;P | 19:38 |
rm_work | just sayin' | 19:38 |
*** yamamoto has quit IRC | 19:40 | |
*** velizarx has joined #openstack-lbaas | 20:00 | |
*** kobis has quit IRC | 20:18 | |
*** aojea has quit IRC | 20:20 | |
*** aojea has joined #openstack-lbaas | 20:23 | |
rm_work | johnsom: you did see that i pasted you the output you wanted yesterday or whenever, about the CREATE TABLE output for the listeners table? | 20:25 |
johnsom | Oh, yeah. I need to go back and look at that patch. The migration had a default in it, but your paste didn't. | 20:26 |
rm_work | hmmmm | 20:27 |
rm_work | really? interesting | 20:27 |
rm_work | oh and i just realized that in the api-ref, i need to remove all the timeout stuff that *isn't* optional... all of these are only optional | 20:27 |
rm_work | lol | 20:27 |
johnsom | No, the "show" commands should not have those as optional right? | 20:28 |
rm_work | ohhh right, yeah derp | 20:28 |
rm_work | ok so i did it right the first time | 20:28 |
rm_work | do i put the default on ALL of them or just on the optional ones? | 20:30 |
rm_work | since the optional ones are for input | 20:30 |
*** velizarx has quit IRC | 20:35 | |
*** yamamoto has joined #openstack-lbaas | 20:37 | |
*** yamamoto has quit IRC | 20:42 | |
johnsom | I think I put the default value on all of them, but you can do a quick search in the params file | 20:50 |
rm_work | yep | 20:51 |
rm_work | ugh what is reno exactly | 20:51 |
rm_work | RST? | 20:51 |
johnsom | Sorry, a bit deep into refactoring the tempest stuff to have IPv6 integrated and not another gate | 20:51 |
rm_work | yeahnp | 20:51 |
johnsom | reno is the python tool that generates the release notes templete | 20:51 |
rm_work | yeah i just mean | 20:52 |
rm_work | the stuff it generates | 20:52 |
rm_work | does it render with RST | 20:52 |
rm_work | or markdown or what | 20:52 |
johnsom | reno new this-is-the-title | 20:52 |
rm_work | right i know | 20:52 |
johnsom | RST | 20:52 |
rm_work | k | 20:52 |
rm_work | i just meant "release notes are rendered with what" | 20:52 |
johnsom | I think | 20:52 |
rm_work | trying to figure out the bullet-point thing | 20:52 |
johnsom | Notes can be styled using reStructuredText directives, and reno’s Sphinx integration makes it easy to incorporate release notes into automated documentation builds. | 20:53 |
rm_work | k | 20:53 |
rm_work | lol well rst editors explode on this | 20:54 |
rm_work | so maybe not exactly | 20:54 |
rm_work | oh do they render with the docs? | 20:56 |
rm_work | looks like no | 21:01 |
rm_work | i'll just hope this works | 21:01 |
johnsom | There is a tox job I think | 21:01 |
rm_work | oh yeah i just found it | 21:01 |
rm_work | hmm yeah interesting, should the default value be in that CREATE TABLE block? | 21:03 |
rm_work | I don't see defaults listed for ANY table there | 21:05 |
rm_work | always null | 21:05 |
rm_work | this is super weird | 21:06 |
rm_work | maybe the defaults we list are just for migrations | 21:07 |
*** yamamoto has joined #openstack-lbaas | 21:38 | |
*** yamamoto has quit IRC | 21:44 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Allow members to be set as "backup" https://review.openstack.org/552632 | 21:49 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Expose timeout options https://review.openstack.org/555454 | 21:49 |
rm_work | johnsom: ok, fixed those up ^^ | 21:49 |
johnsom | Groovy | 21:49 |
openstackgerrit | Michael Johnson proposed openstack/octavia-tempest-plugin master: Revert "Create scenario tests for loadbalancers" https://review.openstack.org/543030 | 21:52 |
openstackgerrit | Michael Johnson proposed openstack/octavia-tempest-plugin master: Create scenario tests for load balancers https://review.openstack.org/543034 | 21:55 |
johnsom | rm_work When you have a minute can you take a look at this again? ^^^ I think I have addressed your comments and the PTG decisions | 22:00 |
rm_work | yeah | 22:19 |
rm_work | finishing up fixes on the usage thing | 22:20 |
rm_work | hmm i did notice an inconsistency comparing quotas and usage (which are ... the closest two calls i can think of) | 22:35 |
rm_work | quotas works like this for getting quotas for a specific project: GET /lbaas/quotas?project_id=12345 | 22:36 |
rm_work | I had usage working like: GET /lbaas/usage/12345 | 22:36 |
rm_work | why the heck did we do it as a request param | 22:36 |
rm_work | do we like that format better? | 22:37 |
rm_work | uuuuuuuuuuuuugh | 22:39 |
rm_work | johnsom: i want to die right now | 22:39 |
rm_work | quotas is exposing load_balancer it seems | 22:39 |
rm_work | and health_monitor | 22:39 |
rm_work | which is not consistent with our API naming for those resources >_< | 22:40 |
*** yamamoto has joined #openstack-lbaas | 22:40 | |
rm_work | i might need to do a patch to bring those in-line with the API, and deprecate the old naming T_T | 22:41 |
rm_work | ugh | 22:41 |
rm_work | i need to purge our DB of the old underscores T_T | 22:41 |
rm_work | and models and EVERYTHING | 22:42 |
rm_work | I have a feeling that is going to be a major undertaking | 22:42 |
*** yamamoto has quit IRC | 22:45 | |
*** fnaval has quit IRC | 22:50 | |
*** aojea has quit IRC | 22:52 | |
*** aojea has joined #openstack-lbaas | 22:55 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 23:08 | |
*** AlexeyAbashkin has quit IRC | 23:12 | |
*** aojea has quit IRC | 23:12 | |
johnsom | rm_work Ha, yeah it might be. However, the whole quota thing is changing all across OpenStack, so maybe that is a good time to do the switch | 23:29 |
rm_work | yes | 23:30 |
johnsom | Well, bummer, I broke something in the tempest plugin. Time to figure out what. | 23:34 |
*** yamamoto has joined #openstack-lbaas | 23:41 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: WIP: Add usage admin resource https://review.openstack.org/557548 | 23:44 |
*** yamamoto has quit IRC | 23:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!