*** openstackgerrit has quit IRC | 01:03 | |
*** slaweq has joined #openstack-lbaas | 01:03 | |
*** slaweq has quit IRC | 01:08 | |
*** Swami has quit IRC | 01:37 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 02:21 | |
*** AlexeyAbashkin has quit IRC | 02:25 | |
*** links has joined #openstack-lbaas | 02:35 | |
*** fnaval has joined #openstack-lbaas | 02:41 | |
*** openstackgerrit has joined #openstack-lbaas | 02:55 | |
openstackgerrit | Michael Johnson proposed openstack/octavia-tempest-plugin master: Create scenario tests for load balancers https://review.openstack.org/543034 | 02:55 |
---|---|---|
openstackgerrit | Michael Johnson proposed openstack/octavia-tempest-plugin master: Create scenario tests for load balancers https://review.openstack.org/543034 | 02:56 |
*** harlowja has quit IRC | 03:04 | |
*** sapd has quit IRC | 03:42 | |
*** links has quit IRC | 04:05 | |
*** links has joined #openstack-lbaas | 04:24 | |
*** sanfern has joined #openstack-lbaas | 04:28 | |
*** yamamoto has joined #openstack-lbaas | 04:44 | |
*** dougwig has quit IRC | 04:46 | |
*** threestrands has quit IRC | 04:50 | |
*** slaweq has joined #openstack-lbaas | 05:05 | |
*** slaweq has quit IRC | 05:10 | |
*** gcheresh has joined #openstack-lbaas | 05:20 | |
*** gcheresh has quit IRC | 05:25 | |
*** gcheresh has joined #openstack-lbaas | 05:31 | |
*** harlowja has joined #openstack-lbaas | 05:52 | |
*** slaweq has joined #openstack-lbaas | 06:01 | |
*** slaweq has quit IRC | 06:02 | |
*** harlowja has quit IRC | 06:33 | |
*** yamamoto has quit IRC | 06:41 | |
*** yamamoto has joined #openstack-lbaas | 06:43 | |
*** yamamoto has quit IRC | 06:50 | |
*** yamamoto has joined #openstack-lbaas | 06:55 | |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Add filterFacets for loadBalancerResourceType https://review.openstack.org/542114 | 07:14 |
*** b_bezak has joined #openstack-lbaas | 07:21 | |
*** numans_ has joined #openstack-lbaas | 07:24 | |
*** rcernin has quit IRC | 07:25 | |
*** b_bezak has quit IRC | 07:26 | |
*** numans has quit IRC | 07:28 | |
*** kobis has joined #openstack-lbaas | 07:29 | |
*** numans_ has quit IRC | 07:35 | |
*** numans has joined #openstack-lbaas | 07:40 | |
*** pcaruana has joined #openstack-lbaas | 07:41 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 07:48 | |
*** slaweq_ has joined #openstack-lbaas | 08:03 | |
*** b_bezak has joined #openstack-lbaas | 08:03 | |
*** slaweq_ has quit IRC | 08:08 | |
*** numans_ has joined #openstack-lbaas | 08:10 | |
*** numans has quit IRC | 08:13 | |
*** numans_ has quit IRC | 08:15 | |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Add filterFacets for loadBalancerResourceType https://review.openstack.org/542114 | 08:15 |
*** tesseract has joined #openstack-lbaas | 08:26 | |
*** yamamoto has quit IRC | 08:35 | |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Add filterFacets for listenerResourceType https://review.openstack.org/543841 | 08:35 |
*** Alex_Staf has joined #openstack-lbaas | 08:37 | |
*** yamamoto has joined #openstack-lbaas | 08:39 | |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Add filterFacets for loadBalancerResourceType https://review.openstack.org/542114 | 08:39 |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Add filterFacets for loadBalancerResourceType https://review.openstack.org/542114 | 08:54 |
*** slaweq_ has joined #openstack-lbaas | 08:55 | |
*** slaweq_ has quit IRC | 08:59 | |
*** kong has quit IRC | 09:07 | |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Add filterFacets for loadBalancerResourceType https://review.openstack.org/542114 | 09:07 |
*** slaweq_ has joined #openstack-lbaas | 09:36 | |
*** slaweq_ has quit IRC | 09:41 | |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Add filterFacets for loadBalancerResourceType https://review.openstack.org/542114 | 09:41 |
*** b_bezak has quit IRC | 09:50 | |
*** numans has joined #openstack-lbaas | 09:50 | |
*** b_bezak has joined #openstack-lbaas | 09:50 | |
*** salmankhan has joined #openstack-lbaas | 09:53 | |
*** b_bezak_ has joined #openstack-lbaas | 09:54 | |
*** b_bezak has quit IRC | 09:55 | |
*** yamamoto has quit IRC | 09:58 | |
*** yamamoto has joined #openstack-lbaas | 10:15 | |
*** salmankhan1 has joined #openstack-lbaas | 10:16 | |
*** salmankhan has quit IRC | 10:17 | |
*** salmankhan1 is now known as salmankhan | 10:17 | |
*** yamamoto has quit IRC | 10:22 | |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Fix bug when click into pool detail page https://review.openstack.org/543884 | 10:24 |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Add filterFacets for loadBalancerResourceType https://review.openstack.org/542114 | 10:29 |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Fix bug when click into pool detail page https://review.openstack.org/543884 | 10:32 |
*** links has quit IRC | 10:36 | |
*** links has joined #openstack-lbaas | 10:49 | |
*** sanfern has quit IRC | 10:56 | |
*** yamamoto has joined #openstack-lbaas | 11:13 | |
*** b_bezak_ has quit IRC | 11:48 | |
*** b_bezak has joined #openstack-lbaas | 11:48 | |
*** salmankhan has quit IRC | 11:50 | |
*** salmankhan has joined #openstack-lbaas | 11:52 | |
*** b_bezak has quit IRC | 11:53 | |
*** b_bezak has joined #openstack-lbaas | 12:41 | |
*** ianychoi_ has joined #openstack-lbaas | 12:42 | |
*** ianychoi has quit IRC | 12:46 | |
*** slaweq_ has joined #openstack-lbaas | 13:01 | |
*** sanfern has joined #openstack-lbaas | 13:03 | |
*** slaweq_ has quit IRC | 13:05 | |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Add the missing type for Health Monitor https://review.openstack.org/543211 | 13:06 |
openstackgerrit | Allen proposed openstack/octavia-dashboard master: Fix bug when click into pool detail page https://review.openstack.org/543884 | 13:08 |
*** pcaruana has quit IRC | 13:16 | |
*** atoth has joined #openstack-lbaas | 13:22 | |
*** oanson has quit IRC | 13:33 | |
*** oanson has joined #openstack-lbaas | 13:35 | |
*** yamamoto has quit IRC | 13:41 | |
*** slaweq_ has joined #openstack-lbaas | 13:45 | |
*** ianychoi_ has quit IRC | 13:48 | |
*** ianychoi_ has joined #openstack-lbaas | 13:49 | |
*** slaweq_ has quit IRC | 13:50 | |
*** fnaval has quit IRC | 14:16 | |
*** yamamoto has joined #openstack-lbaas | 14:27 | |
*** fnaval has joined #openstack-lbaas | 14:28 | |
*** fnaval has quit IRC | 14:33 | |
*** openstackgerrit has quit IRC | 14:33 | |
*** Alex_Staf has quit IRC | 14:39 | |
*** slaweq_ has joined #openstack-lbaas | 14:47 | |
*** links has quit IRC | 14:47 | |
*** fnaval has joined #openstack-lbaas | 14:47 | |
*** bbzhao has quit IRC | 14:50 | |
*** bbzhao has joined #openstack-lbaas | 14:50 | |
*** slaweq_ has quit IRC | 14:52 | |
*** ying_zuo has quit IRC | 14:58 | |
*** ying_zuo has joined #openstack-lbaas | 14:58 | |
*** sanfern has quit IRC | 15:35 | |
*** slaweq_ has joined #openstack-lbaas | 15:38 | |
*** gcheresh has quit IRC | 15:41 | |
*** slaweq_ has quit IRC | 15:42 | |
*** b_bezak has quit IRC | 16:09 | |
*** slaweq_ has joined #openstack-lbaas | 16:24 | |
*** kobis has quit IRC | 16:25 | |
*** kobis has joined #openstack-lbaas | 16:26 | |
*** kobis has quit IRC | 16:26 | |
*** slaweq_ has quit IRC | 16:29 | |
*** b_bezak has joined #openstack-lbaas | 16:34 | |
*** pcaruana has joined #openstack-lbaas | 16:47 | |
*** dougwig has joined #openstack-lbaas | 16:54 | |
*** bcafarel has quit IRC | 17:07 | |
johnsom | Hmm, we have two options: | 17:15 |
johnsom | 1. If we get an API call for delete on an object in "DELETED" state we can return 204 all is good. | 17:15 |
johnsom | 2. If we get an API call for delete on an object in "DELETED" state we can return 404 not found. | 17:15 |
*** bbzhao has quit IRC | 17:15 | |
*** bbzhao has joined #openstack-lbaas | 17:16 | |
johnsom | I guess for consistency we should do 404 not found. That is how list LBs returns. | 17:16 |
johnsom | Hmm, yeah, we didn't do this well. List returns no LBs, but an explicit get (show details) on the LB ID does return the object in "DELETED" | 17:18 |
johnsom | rm_work nmagnezi xgerman_ Thoughts? | 17:19 |
*** yamamoto has quit IRC | 17:21 | |
xgerman_ | we decided to return 204 long agao since deleting a deleted object leads to the same state deleted | 17:21 |
johnsom | So you lean towards returning 204 on objects that are already in "DELETED" | 17:22 |
*** yamamoto has joined #openstack-lbaas | 17:24 | |
*** yamamoto has quit IRC | 17:24 | |
xgerman_ | yes | 17:25 |
johnsom | I lean that way too | 17:26 |
johnsom | Currently we return: "Invalid state DELETED of loadbalancer resource ab6bf03a-721c-42f6-886c-314d67c6aff4" | 17:28 |
johnsom | I've opened a bug and started a patch, but didn't want to get too far down the path if I was forgetting something. | 17:28 |
xgerman_ | yeah, that seems wrong regardless how we look at it | 17:28 |
johnsom | Right, I think it either should be 404 or 204 | 17:29 |
xgerman_ | +1 | 17:30 |
xgerman_ | can we run LBaaS V2 dashaboard and Octavia i the same install? | 17:31 |
johnsom | Yes, but you will get duplicate "Load Balancer" panels in the list | 17:31 |
xgerman_ | thanks | 17:33 |
*** AlexeyAbashkin has quit IRC | 17:38 | |
*** yamamoto has joined #openstack-lbaas | 17:40 | |
*** yamamoto has quit IRC | 17:45 | |
*** bcafarel has joined #openstack-lbaas | 17:55 | |
*** pcaruana has quit IRC | 17:55 | |
*** JudeC has joined #openstack-lbaas | 17:59 | |
*** pcaruana has joined #openstack-lbaas | 18:06 | |
*** yamamoto has joined #openstack-lbaas | 18:06 | |
*** yamamoto has quit IRC | 18:06 | |
*** slaweq has joined #openstack-lbaas | 18:25 | |
*** slaweq has quit IRC | 18:26 | |
*** slaweq has joined #openstack-lbaas | 18:26 | |
rm_work | johnsom: i thought that was what we WANTED to have happen | 18:33 |
rm_work | (show DELETED objects when you query directly, but not on LIST, unless deleted=True or something?) | 18:34 |
rm_work | I agree that they are mismatched right now if delete returns 404 | 18:34 |
johnsom | Right, my issue is mostly about the delete a DELETED | 18:34 |
rm_work | does it? | 18:34 |
rm_work | currently | 18:34 |
johnsom | I am going to leave the show, it's the delete I'm fixing | 18:34 |
rm_work | so it returns 204? | 18:35 |
rm_work | i think I agree | 18:35 |
johnsom | Right | 18:35 |
rm_work | first instinct is 404 on delete deleted | 18:35 |
rm_work | but | 18:35 |
rm_work | second instinct is i like showing deleted things and we need to be consistent | 18:35 |
rm_work | and it's not like this stuff is secret | 18:35 |
rm_work | LIST *does* have a way to show deleted, right? | 18:35 |
rm_work | or do we need to add that | 18:35 |
rm_work | IIRC we'd intended to allow showing | 18:35 |
johnsom | No, list doesn't show them at all | 18:36 |
rm_work | not optional? hrm | 18:36 |
rm_work | I might also vote to add deleted=True to the GET for the list call | 18:37 |
rm_work | swear we added it | 18:37 |
rm_work | but maybe I'm thinking of a different project | 18:37 |
johnsom | Not at the moment. I would support adding an "ALL" param though | 18:37 |
rm_work | not deleted=True but all=True? | 18:37 |
rm_work | what are the other cases | 18:37 |
johnsom | I would make it consistent across the endpoints | 18:38 |
rm_work | err | 18:38 |
rm_work | are there other endpoints where `all` makes sense? | 18:39 |
*** slaweq has quit IRC | 18:39 | |
rm_work | I guess it's forward-looking, but that's assuming we don't want to allow anything fine-grained in the future too | 18:39 |
*** slaweq has joined #openstack-lbaas | 18:40 | |
*** tesseract has quit IRC | 18:40 | |
johnsom | Yeah, I would think an "all" param on lists makes sense, in "openstack server list" there is --all | 18:42 |
johnsom | IDK, I'm just going to fix the delete now as it's bugging me in the tempest work with the cleanup methods. It's clear "409 Invalid status" is not the right response to deleting something already deleted. | 18:43 |
rm_work | errrr wut | 18:43 |
johnsom | I'm just working on the functional tests now, should have it up for review in a bit | 18:44 |
rm_work | it's not a 404 OR a 204??! | 18:44 |
rm_work | also, are you sure that's not because of PENDING_DELETE? | 18:44 |
johnsom | No, right now it's 409 | 18:44 |
johnsom | Yes | 18:44 |
johnsom | Just a sec, I will paste it | 18:44 |
johnsom | {"debuginfo": null, "faultcode": "Client", "faultstring": "Invalid state DELETED of loadbalancer resource ab6bf03a-721c-42f6-886c-314d67c6aff4"}stack@devstackpy/json" -H "X-Auth-Token: $current_token" -H "Accept: application/json" $test_API_ENDPOINT/v2.0/lbaas/loadbalancers/ab6bf03a-721c-42f6-886c-314d67c6aff4 | 18:45 |
*** pcaruana has quit IRC | 18:45 | |
*** slaweq has quit IRC | 18:45 | |
johnsom | Right now it falls through to the locking logic which rejects it as immutable | 18:46 |
johnsom | I'm switching it to 204 | 18:46 |
rm_work | T_T | 18:46 |
rm_work | yeah k | 18:46 |
rm_work | somehow I didn't notice that | 18:46 |
rm_work | or else I had it ignore that stuff or something | 18:46 |
johnsom | Yeah, me either until I wrote the delete test that had a cleanup for the LB. | 18:46 |
johnsom | Anyway, I will post the patch in a bit | 18:47 |
johnsom | I'm just adding the test coverage for it | 18:47 |
rm_work | k | 18:48 |
rm_work | yay tests lol | 18:48 |
johnsom | Man, our functional tests are efficient, it lights up all of the cores in my CPU when I light it off. 472 API tests... | 19:02 |
*** harlowja has joined #openstack-lbaas | 19:03 | |
*** yamamoto has joined #openstack-lbaas | 19:06 | |
*** salmankhan has quit IRC | 19:06 | |
rm_work | yes T_T | 19:07 |
rm_work | my laptop takes off like a jet | 19:07 |
rm_work | and kinda hovers on my desk from all the fan activity | 19:07 |
*** gcheresh has joined #openstack-lbaas | 19:08 | |
*** yamamoto has quit IRC | 19:15 | |
*** openstackgerrit has joined #openstack-lbaas | 19:27 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Updates API for deleting "DELETED" objects https://review.openstack.org/544046 | 19:27 |
johnsom | Question is should we do an RC2 for that? | 19:27 |
*** slaweq has joined #openstack-lbaas | 19:45 | |
*** slaweq has quit IRC | 19:49 | |
*** b_bezak has quit IRC | 19:49 | |
*** gcheresh has quit IRC | 19:58 | |
*** gcheresh has joined #openstack-lbaas | 20:07 | |
*** kobis has joined #openstack-lbaas | 20:08 | |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: Log failed cert delete, and raise TLSContainerInvalid instead https://review.openstack.org/544062 | 20:10 |
eandersson | Because we all love more patches to the now deprecated neutron-lbaas :p | 20:14 |
*** gcheresh has quit IRC | 20:21 | |
johnsom | Ha, well, as long as it's a bug fix.... | 20:30 |
*** salmankhan has joined #openstack-lbaas | 20:47 | |
*** salmankhan has quit IRC | 20:51 | |
*** gcheresh has joined #openstack-lbaas | 20:53 | |
eandersson | Not sure why in the world neutron-lbaas should be responsible for deleting "invalid" secrets lol but that is a different topic | 21:08 |
eandersson | It looks like it's already fixed in octavia | 21:08 |
johnsom | eandersson Yet another reason to switch! Grin | 21:10 |
eandersson | haha | 21:10 |
eandersson | indeed | 21:10 |
eandersson | soonTM | 21:10 |
johnsom | Nice | 21:10 |
*** slaweq has joined #openstack-lbaas | 21:11 | |
*** gcheresh has quit IRC | 21:31 | |
*** openstackstatus has quit IRC | 21:43 | |
*** openstackstatus has joined #openstack-lbaas | 21:45 | |
*** ChanServ sets mode: +v openstackstatus | 21:45 | |
*** rcernin has joined #openstack-lbaas | 22:05 | |
*** Alex_Staf has joined #openstack-lbaas | 22:08 | |
*** kobis has quit IRC | 22:08 | |
*** kong has joined #openstack-lbaas | 22:55 | |
*** fnaval has quit IRC | 23:10 | |
*** Alex_Staf has quit IRC | 23:19 | |
*** fnaval has joined #openstack-lbaas | 23:27 | |
openstackgerrit | Merged openstack/octavia-dashboard master: Add the missing protocol for listener https://review.openstack.org/542075 | 23:41 |
openstackgerrit | Merged openstack/octavia-dashboard master: Remove the unused codes https://review.openstack.org/542069 | 23:43 |
*** slaweq has quit IRC | 23:45 | |
*** fnaval has quit IRC | 23:48 | |
*** fnaval has joined #openstack-lbaas | 23:48 | |
openstackgerrit | Michael Johnson proposed openstack/neutron-lbaas master: Gate API test for the lbaasv2-proxy plugin https://review.openstack.org/539350 | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!