*** yamamoto has joined #openstack-lbaas | 00:32 | |
*** bar_ has joined #openstack-lbaas | 00:35 | |
*** yamamoto has quit IRC | 00:40 | |
*** openstackgerrit has joined #openstack-lbaas | 01:49 | |
openstackgerrit | huangshan proposed openstack/python-octaviaclient master: Add listener stats client api and osc https://review.openstack.org/526610 | 01:49 |
---|---|---|
*** sapd_ has joined #openstack-lbaas | 01:50 | |
*** sapd__ has quit IRC | 01:50 | |
openstackgerrit | Bar RH proposed openstack/octavia master: Reorder ComputeCreate arguments https://review.openstack.org/526965 | 01:53 |
*** annp has joined #openstack-lbaas | 02:15 | |
*** oanson has quit IRC | 02:19 | |
*** oanson has joined #openstack-lbaas | 02:21 | |
openstackgerrit | Bar RH proposed openstack/octavia master: Reorder ComputeCreate arguments https://review.openstack.org/526965 | 02:39 |
*** bar_ has quit IRC | 02:48 | |
*** yamamoto has joined #openstack-lbaas | 03:14 | |
*** links has joined #openstack-lbaas | 04:07 | |
*** links has quit IRC | 04:07 | |
bzhao | hello? Sunday night. :) | 04:10 |
*** armax has joined #openstack-lbaas | 04:36 | |
*** armax has quit IRC | 04:41 | |
*** Alex_Staf has joined #openstack-lbaas | 05:04 | |
openstackgerrit | Hengqing Hu proposed openstack/octavia-dashboard master: Make breadcrumb same as other pages https://review.openstack.org/526989 | 06:01 |
*** yamamoto has quit IRC | 06:08 | |
*** ianychoi_ is now known as ianychoi | 06:12 | |
openstackgerrit | Hengqing Hu proposed openstack/octavia-dashboard master: Make breadcrumb same as other pages https://review.openstack.org/526989 | 06:16 |
*** threestrands has quit IRC | 06:17 | |
*** yamamoto has joined #openstack-lbaas | 06:22 | |
*** gcheresh has joined #openstack-lbaas | 06:23 | |
*** yamamoto has quit IRC | 06:32 | |
openstackgerrit | ZhaoBo proposed openstack/octavia master: Extend api to accept qos_policy_id https://review.openstack.org/458308 | 06:51 |
*** eN_Guruprasad_Rn has joined #openstack-lbaas | 06:51 | |
*** Alex_Staf has quit IRC | 07:15 | |
*** yamamoto has joined #openstack-lbaas | 07:33 | |
*** codenamelxl has joined #openstack-lbaas | 07:37 | |
*** yamamoto has quit IRC | 07:38 | |
*** yamamoto has joined #openstack-lbaas | 07:38 | |
codenamelxl | Hello everyone, I'm kinda confused between Octavia and Neutron LBaaSv2. Is Neutron LBaaSv2 going to be deprecated to honor Octavia? Does LBaaSv2 support l7 policy? What does Octavia have more to offer than LBaaSv2 ? Thanks in advance. | 07:40 |
*** rcernin has quit IRC | 07:43 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 07:46 | |
*** yamamoto has quit IRC | 07:52 | |
nmagnezi | rm_work, o/ | 07:58 |
openstackgerrit | Santhosh Fernandes proposed openstack/octavia master: [WIP] ACTIVE-ACTIVE ExaBGP rest api driver https://review.openstack.org/527009 | 07:58 |
openstackgerrit | Santhosh Fernandes proposed openstack/octavia master: [WIP] ACTIVE-ACTIVE ExaBGP rest api driver https://review.openstack.org/527009 | 07:59 |
*** yamamoto has joined #openstack-lbaas | 08:06 | |
*** b_bezak has joined #openstack-lbaas | 08:13 | |
*** Alex_Staf has joined #openstack-lbaas | 08:45 | |
*** rcernin has joined #openstack-lbaas | 08:47 | |
*** eranra_ has joined #openstack-lbaas | 08:48 | |
*** eranra_ has left #openstack-lbaas | 08:48 | |
*** aojea has joined #openstack-lbaas | 09:19 | |
*** aojea has quit IRC | 09:24 | |
*** sticker has quit IRC | 09:25 | |
*** sri_ has joined #openstack-lbaas | 09:31 | |
*** yamamoto has quit IRC | 09:33 | |
*** yamamoto has joined #openstack-lbaas | 09:34 | |
Alex_Staf | kong, ping | 09:36 |
*** eN_Guruprasad_Rn has quit IRC | 09:39 | |
*** eN_Guruprasad_Rn has joined #openstack-lbaas | 09:46 | |
*** dokua has joined #openstack-lbaas | 09:55 | |
*** codenamelxl has quit IRC | 10:29 | |
*** annp has quit IRC | 10:35 | |
*** yamamoto has quit IRC | 10:47 | |
*** yamamoto has joined #openstack-lbaas | 10:47 | |
*** yamamoto has quit IRC | 10:52 | |
*** kobis has joined #openstack-lbaas | 11:24 | |
*** AlexeyAbashkin has quit IRC | 11:25 | |
*** eN_Guruprasad_Rn has quit IRC | 11:37 | |
*** ianychoi has quit IRC | 11:37 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 11:45 | |
*** ianychoi has joined #openstack-lbaas | 11:50 | |
*** sanfern has joined #openstack-lbaas | 11:52 | |
*** yamamoto has joined #openstack-lbaas | 12:02 | |
openstackgerrit | Bernard Cafarelli proposed openstack/octavia master: Force SELinux context for amphora keepalived proces https://review.openstack.org/527073 | 12:18 |
*** eN_Guruprasad_Rn has joined #openstack-lbaas | 12:29 | |
*** atoth has joined #openstack-lbaas | 12:37 | |
*** eN_Guruprasad_Rn has quit IRC | 12:40 | |
*** sanfern has quit IRC | 12:41 | |
*** sanfern has joined #openstack-lbaas | 12:42 | |
*** rcernin has quit IRC | 13:23 | |
*** ianychoi has quit IRC | 13:40 | |
*** bar_ has joined #openstack-lbaas | 14:01 | |
*** sanfern has quit IRC | 14:41 | |
*** sanfern has joined #openstack-lbaas | 14:42 | |
*** yamamoto has quit IRC | 14:53 | |
*** dmellado has quit IRC | 14:53 | |
*** b_bezak has quit IRC | 14:59 | |
*** b_bezak has joined #openstack-lbaas | 15:00 | |
*** b_bezak has quit IRC | 15:04 | |
*** dmellado has joined #openstack-lbaas | 15:05 | |
openstackgerrit | Bernard Cafarelli proposed openstack/octavia master: Force SELinux context for amphora keepalived process https://review.openstack.org/527073 | 15:05 |
*** yamamoto has joined #openstack-lbaas | 15:06 | |
*** dmellado has quit IRC | 15:10 | |
*** yamamoto has quit IRC | 15:12 | |
*** dmellado has joined #openstack-lbaas | 15:12 | |
*** Alex_Staf has quit IRC | 15:19 | |
*** dmellado has quit IRC | 15:29 | |
*** dmellado has joined #openstack-lbaas | 15:30 | |
*** fnaval has joined #openstack-lbaas | 15:41 | |
*** gcheresh has quit IRC | 15:46 | |
*** dmellado has quit IRC | 15:52 | |
*** yamamoto has joined #openstack-lbaas | 15:52 | |
*** yamamoto has quit IRC | 15:54 | |
*** yamamoto has joined #openstack-lbaas | 15:54 | |
*** yamamoto has quit IRC | 15:54 | |
*** dmellado has joined #openstack-lbaas | 15:55 | |
*** armax has joined #openstack-lbaas | 15:56 | |
*** dmellado has quit IRC | 15:58 | |
*** dmellado has joined #openstack-lbaas | 16:01 | |
xgerman_ | o/ | 16:09 |
*** kobis has quit IRC | 16:18 | |
*** AlexeyAbashkin has quit IRC | 16:43 | |
*** kobis has joined #openstack-lbaas | 16:50 | |
*** yamamoto has joined #openstack-lbaas | 16:54 | |
sanfern | o/ | 16:55 |
sanfern | hello johnsom, Good Morning | 16:55 |
johnsom | sanfern Hi | 16:55 |
sanfern | regarding amphora image patch I am using exabgp cli so I can not disable it - https://review.openstack.org/#/c/491016/12/octavia/amphorae/backends/agent/api_server/exabgp.py | 16:56 |
sanfern | Thank you for review | 16:56 |
johnsom | Ok, yeah, I haven't reviewed the other code yet, just the image element. | 16:57 |
sanfern | ok | 16:57 |
johnsom | The documentation for exabgp is a bit light.... | 16:57 |
sanfern | yeah I agree. I have tested agent part and demo'ed to the team using curl, it worked pretty well. | 16:59 |
sanfern | pip install is not required since we have in requirements.txt | 17:00 |
johnsom | Yeah, I remember you mentioning that. That is good news, I am just trying to understand everything going on there and making sure we do a good implementation. | 17:00 |
sanfern | https://review.openstack.org/#/c/490164/21/elements/exabgp-speaker/post-install.d/77-exabgp | 17:00 |
sanfern | Thanks johnsom, | 17:00 |
*** yamamoto has quit IRC | 17:03 | |
*** tongl has joined #openstack-lbaas | 17:04 | |
*** sanfern has quit IRC | 17:20 | |
*** dokua has quit IRC | 17:22 | |
*** tongl has quit IRC | 17:37 | |
*** dmellado has quit IRC | 17:40 | |
*** dmellado has joined #openstack-lbaas | 17:40 | |
*** sanfern has joined #openstack-lbaas | 17:48 | |
*** kobis has quit IRC | 17:53 | |
*** dmellado has quit IRC | 17:59 | |
openstackgerrit | Bar RH proposed openstack/octavia master: Improve Neutron driver _get_resource() https://review.openstack.org/527199 | 18:05 |
*** bar_ has quit IRC | 18:08 | |
*** dmellado has joined #openstack-lbaas | 18:09 | |
*** SumitNaiksatam has quit IRC | 18:10 | |
*** Alex_Staf has joined #openstack-lbaas | 18:12 | |
Alex_Staf | Hi guys , I have devstack with octavia and tempest . testr list-tests see the octavia tests . am I ready to go or should I know anything else ? | 18:16 |
johnsom | I think you are good. I usually set the TEMPEST_CONFIG_DIR=/opt/stack/tempest/etc variable | 18:18 |
*** tongl has joined #openstack-lbaas | 18:19 | |
*** kobis has joined #openstack-lbaas | 18:19 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 18:28 | |
*** kobis has quit IRC | 18:29 | |
*** eN_Guruprasad_Rn has joined #openstack-lbaas | 18:30 | |
*** kobis has joined #openstack-lbaas | 18:31 | |
*** AlexeyAbashkin has quit IRC | 18:32 | |
*** SumitNaiksatam has joined #openstack-lbaas | 18:43 | |
*** gcheresh has joined #openstack-lbaas | 18:52 | |
*** kobis has quit IRC | 19:00 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 19:03 | |
*** AlexeyAbashkin has quit IRC | 19:07 | |
*** eN_Guruprasad_Rn has quit IRC | 19:10 | |
*** dmellado has quit IRC | 19:23 | |
*** dmellado has joined #openstack-lbaas | 19:25 | |
*** Alex_Staf has quit IRC | 19:28 | |
*** gcheresh has quit IRC | 19:41 | |
*** dmellado has quit IRC | 19:45 | |
*** tongl has quit IRC | 19:51 | |
*** dmellado has joined #openstack-lbaas | 19:51 | |
*** dmellado has quit IRC | 19:51 | |
*** kobis has joined #openstack-lbaas | 19:54 | |
*** dmellado has joined #openstack-lbaas | 19:57 | |
*** dmellado has quit IRC | 19:57 | |
*** kobis has quit IRC | 20:01 | |
*** dmellado has joined #openstack-lbaas | 20:03 | |
*** dmellado has quit IRC | 20:04 | |
*** tongl has joined #openstack-lbaas | 20:04 | |
*** dmellado has joined #openstack-lbaas | 20:11 | |
*** dmellado has quit IRC | 20:11 | |
*** dmellado has joined #openstack-lbaas | 20:13 | |
*** dmellado has quit IRC | 20:14 | |
*** atoth has quit IRC | 20:15 | |
*** Swami has joined #openstack-lbaas | 20:19 | |
*** dmellado has joined #openstack-lbaas | 20:24 | |
*** dmellado has quit IRC | 20:24 | |
*** aojea has joined #openstack-lbaas | 20:29 | |
*** dmellado has joined #openstack-lbaas | 20:34 | |
*** aojea has quit IRC | 20:35 | |
*** dmellado has quit IRC | 20:52 | |
*** gcheresh has joined #openstack-lbaas | 20:58 | |
*** tongl has quit IRC | 21:01 | |
*** sanfern has quit IRC | 21:06 | |
*** dmellado has joined #openstack-lbaas | 21:17 | |
*** bar_ has joined #openstack-lbaas | 21:23 | |
*** eN_Guruprasad_Rn has joined #openstack-lbaas | 21:28 | |
*** dmellado has quit IRC | 21:28 | |
*** dmellado has joined #openstack-lbaas | 21:31 | |
*** sanfern has joined #openstack-lbaas | 21:39 | |
*** threestrands has joined #openstack-lbaas | 21:41 | |
*** threestrands has quit IRC | 21:41 | |
*** threestrands has joined #openstack-lbaas | 21:41 | |
rm_work | nmagnezi: keep missing you >_> | 21:45 |
rm_work | nmagnezi: maybe i'll try to catch you tonight | 21:45 |
*** SumitNaiksatam_ has joined #openstack-lbaas | 21:49 | |
*** strigazi_ has joined #openstack-lbaas | 21:51 | |
*** tongl has joined #openstack-lbaas | 21:52 | |
*** mestery_ has joined #openstack-lbaas | 21:54 | |
*** b3nt_pin has joined #openstack-lbaas | 21:54 | |
*** gcheresh has quit IRC | 21:55 | |
*** dokua has joined #openstack-lbaas | 21:56 | |
*** SumitNaiksatam has quit IRC | 21:56 | |
*** dayou has quit IRC | 21:56 | |
*** mestery has quit IRC | 21:56 | |
*** strigazi has quit IRC | 21:56 | |
*** beagles has quit IRC | 21:56 | |
*** SumitNaiksatam_ is now known as SumitNaiksatam | 21:56 | |
*** mestery_ is now known as mestery | 21:56 | |
rm_work | xgerman_ / nmagnezi https://review.openstack.org/#/c/525295/ | 21:57 |
rm_work | easy merge | 21:58 |
*** dmellado has quit IRC | 21:58 | |
rm_work | johnsom / xgerman_: could use review again: https://review.openstack.org/#/c/525790/ | 21:58 |
rm_work | the next two in that chain could as well | 21:58 |
rm_work | but i figure begging for two small reviews per day is probably enough :P | 21:59 |
xgerman_ | the 2nd one still has a -1 | 21:59 |
*** dayou has joined #openstack-lbaas | 21:59 | |
*** dayou has quit IRC | 21:59 | |
*** dayou has joined #openstack-lbaas | 21:59 | |
rm_work | yeah and it is invalid IMO | 21:59 |
rm_work | I detailed why | 21:59 |
rm_work | bar_: would be good if you could re-review | 21:59 |
bar_ | looking | 22:00 |
xgerman_ | ok | 22:00 |
bar_ | rm_work, You didn't change the code since we talked, only rebased it | 22:00 |
rm_work | yes | 22:00 |
rm_work | i believe your original comment is invalid -- it does not require a change on my part | 22:01 |
rm_work | i provided some examples | 22:01 |
rm_work | or if not invalid, not explicitly valid either | 22:01 |
rm_work | not worthy of a -1, at the least | 22:01 |
bar_ | rm_work, I see. Then we do not understand each other, because I think your example proves otherwise. | 22:02 |
rm_work | if you saw the gist i linked, *you are technically correct* per line 27-28 that it doesn't get filled there | 22:02 |
rm_work | but it isn't ONLY a class variable | 22:02 |
rm_work | it is also carried into instances | 22:02 |
rm_work | uniquely | 22:02 |
rm_work | which is what the rest of that code proves | 22:03 |
*** dokua has quit IRC | 22:03 | |
bar_ | But why declare a class member in the first place? just declare it inside an __init__ | 22:03 |
rm_work | and it doesn't really matter if it's forever null on the class ... because ... no one uses that | 22:03 |
bar_ | I agree that your code *works*, but you shouldn't declare a class member if you never write to it. | 22:04 |
bar_ | Don't you agree? | 22:04 |
rm_work | I think messing with the __init__ when you can just declare a var there is wasteful | 22:05 |
rm_work | but i think it comes down to style maybe | 22:05 |
rm_work | if you're going to keep your -1 until it's changed... i don't have any specific reason not to change it | 22:05 |
rm_work | so i guess i would | 22:05 |
rm_work | that's why i adjusted what I said to "if not invalid, not explicitly valid or worthy of a -1" | 22:06 |
rm_work | i mean it's a 15 second fix, probably arguing about it wasn't worth the effort I guess | 22:06 |
johnsom | German already voted a +2. I think it's a bit odd, but works. | 22:07 |
rm_work | bar_: do you care enough that you really want me to roll another patch? | 22:07 |
*** dmellado has joined #openstack-lbaas | 22:08 | |
rm_work | I mean, partly I am thinking we're looking at *making it* a class variable, and we're halfway there this way too, lol | 22:08 |
rm_work | but on the other hand, since it still isn't, maybe this has the potential to be confusing | 22:08 |
bar_ | rm_work, lol, the answer is yea :-) | 22:08 |
rm_work | kk | 22:08 |
*** eN_Guruprasad_Rn has quit IRC | 22:08 | |
bar_ | You declare a class member and then assign to an instance member you should have declared of instead, I think it deserves -1 :-) | 22:09 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Move loading the network driver into the flows https://review.openstack.org/525790 | 22:09 |
rm_work | there you go, as stated, 15 second change | 22:09 |
rm_work | lol | 22:09 |
*** dmellado has quit IRC | 22:10 | |
rm_work | point of me having this argument: probably 0% | 22:10 |
*** dmellado has joined #openstack-lbaas | 22:10 | |
rm_work | so really, I just wasted my own time >_< | 22:10 |
bar_ | rm_work, ha. you got a +1 | 22:11 |
rm_work | johnsom: now you :P | 22:11 |
rm_work | ah and xgerman_ again T_T | 22:11 |
bar_ | rm_work, Please take a look at my recent patches, I added you as a reviewer mostly because it might conflict with your patches, so your opinion is significant | 22:12 |
rm_work | hmm k need to figure out which ones those are | 22:12 |
bar_ | top 2: https://review.openstack.org/#/q/project:openstack/octavia+owner:%22Bar+RH+%253Cbar%2540redhat.com%253E%22 | 22:13 |
rm_work | ah already i am in the middle of reviewing the second one | 22:14 |
rm_work | I honestly didn't care that the error messages say like "Qos_idNotFound" lol | 22:14 |
rm_work | but yeah, i can rebase | 22:14 |
rm_work | no real worry there, these look minimal | 22:15 |
bar_ | rm_work, good then | 22:15 |
*** rcernin has joined #openstack-lbaas | 22:19 | |
rm_work | bar_: although you do appear to be reordering args for ... no real purpose that I can see? | 22:22 |
rm_work | they're all used as keyword args anyway | 22:22 |
rm_work | the order doesn't matter in any of these cases | 22:22 |
rm_work | (the way taskflow calls things is explicitly by keyword, not by ordered args) | 22:22 |
rm_work | I guess the whole purpose of this patch is just a cleanup refactor | 22:23 |
rm_work | so ... the intent is to make them somehow more logically ordered? | 22:23 |
bar_ | rm_work, I wrote it under the impression that order could matter, I guess there isn't really a case for it other than aesthetics, as you say... | 22:24 |
johnsom | Order doesn't matter | 22:24 |
bar_ | johnsom, yeah, well... You can -2 if you feel it doesn't make sense to merge it. | 22:25 |
bar_ | johnsom, oh, you already approved, thx | 22:25 |
johnsom | Argh, I was looking at one of the L3 Act/Act patches, stacked, then realized it's parent is so out of date it doesn't run... Sigh. | 22:27 |
openstackgerrit | Michael Johnson proposed openstack/octavia master: [WIP] ACTIVE-ACTIVE with exabgp-speaker - Octavia agent https://review.openstack.org/491016 | 22:27 |
rm_work | bar_: was just making sure you were just doing cleanup and hadn't intended to make any actual change | 22:28 |
bar_ | about the qos policy octavia patch, is it a bug that it does not propagate the qos_policy applied on the VIP to the port object? | 22:28 |
rm_work | it's fine, merging it now | 22:28 |
bar_ | rm_work, thx! | 22:28 |
rm_work | looking at the other | 22:28 |
nmagnezi | rm_work, o/ yeah,, we need to discuss some stuff as a follow up to the last weekly meeting. I was partially OOO and came back today and had some internal stuff to handle. tomorrow morning my time I'm going to re-visit the providers spec (I know xgerman_ made some comments on it) | 22:29 |
nmagnezi | bar_, you are up late :-) | 22:29 |
bar_ | nmagnezi, :-) you too, it seems | 22:30 |
johnsom | bar_ What do you mean on the QoS patch? | 22:30 |
bar_ | johnsom, https://review.openstack.org/#/q/project:openstack/octavia+owner:%22Bar+RH+%253Cbar%2540redhat.com%253E%22 | 22:31 |
bar_ | woops | 22:31 |
*** dmellado has quit IRC | 22:31 | |
bar_ | johnsom, https://review.openstack.org/#/c/458308/ | 22:31 |
johnsom | Yeah, I have looked through that patch, was just trying to understand your concern | 22:32 |
bar_ | johnsom, he never updates the port with the chosen qos_policy | 22:33 |
johnsom | I'm not following, he has a task that applies the qos ID to the neutron port. | 22:34 |
bar_ | johnsom, which he never applies on the vip_port. assume a port was given in creation of the loadbalancer, and later the qos_policy had been updated via loadbalancer set call | 22:36 |
*** dmellado has joined #openstack-lbaas | 22:36 | |
johnsom | bar_ Maybe you should post a review vote on the patch. | 22:38 |
bar_ | johnsom, I will. My deployment is down for a while, so I haven't reproduced it yet. | 22:39 |
rm_work | bar_: couple comments on https://review.openstack.org/#/c/527199/1 | 22:40 |
bar_ | rm_work, thanks! Did you notice I changed the function name? | 22:42 |
rm_work | ah for the thing on the tests... if those objects are missing something ... check to see if I already added it in https://review.openstack.org/#/c/525353/6/octavia/tests/common/constants.py | 22:42 |
johnsom | bar_ Ok. If the concern is that he is applying it to the base port and not the VIP port, I think that is accurate to how neutron works. The VIP port is a fake "allowed-address-pairs" port. I haven't loaded it up yet, but I have completed the code read through. I plan to test it today and vote. | 22:42 |
rm_work | bar_: ah actually i did not, tricksy 's' in the middle there | 22:43 |
bar_ | johnsom, Does he apply it on the base port? I haven't find that call... | 22:43 |
rm_work | bar_: so ... ok... while I am not a huge fan of the old method disappearing, it *is* "private" so there's no contract and anyone using that directly is at their own risk... and at least it breaks cleanly | 22:43 |
rm_work | so yeah, I'm less concerned | 22:43 |
bar_ | rm_work, yay! | 22:44 |
rm_work | my comment on the test still applies :P | 22:45 |
rm_work | I think I fixed the MOCK objects for you in my patch | 22:45 |
rm_work | but that may not merge for a while, so... | 22:45 |
rm_work | if you want to take my changes to those objects and try to put them in the same way, it'd make my rebase a lot easier when yours merges first :) | 22:46 |
bar_ | rm_work, what patch are you referring to? | 22:46 |
rm_work | I linked it just now, but: https://review.openstack.org/#/c/525353/6/octavia/tests/common/constants.py | 22:46 |
rm_work | If you fixed MOCK_NEUTRON_PORT like that, and added a second one with ID2/IP2 | 22:46 |
rm_work | you can just use those directly | 22:46 |
*** dmellado has quit IRC | 22:48 | |
bar_ | rm_work, MOCK_NEUTRON_PORT -> MOCK_NEUTRON_PORT_1, cool? | 22:51 |
rm_work | hmm | 22:52 |
rm_work | just looking at the rest of that file, mostly we don't underscore the number | 22:52 |
bar_ | oh | 22:52 |
rm_work | and OFTEN we don't rename the #1, though that is somewhat inconsistent | 22:52 |
bar_ | which do you prefer, with #1 or without? | 22:53 |
rm_work | I think without, just because it makes more sense for the tests where we don't care about multiple (which is almost all of them) | 22:53 |
rm_work | and of course it makes my rebase easier :P | 22:53 |
bar_ | rm_work, done | 22:53 |
rm_work | waiting for my two patches to merge and your two patches to merge and then i'll rebase all my stuff >_< | 22:58 |
rm_work | hopefully not too bad | 22:58 |
rm_work | so whenever you post that one I can +2 | 22:58 |
*** threestrands_ has joined #openstack-lbaas | 23:04 | |
*** threestrands_ has quit IRC | 23:04 | |
*** threestrands_ has joined #openstack-lbaas | 23:04 | |
rm_work | soooo, we do need to look at the PKCS12 thing before Q-3 I guess: https://review.openstack.org/#/c/504175/ | 23:05 |
rm_work | Ideally sooner so I have a chance to make changes if necessary... | 23:05 |
rm_work | I'm prolly going to be out the last two weeks of December | 23:06 |
xgerman_ | ok | 23:06 |
*** dmellado has joined #openstack-lbaas | 23:06 | |
*** threestrands has quit IRC | 23:06 | |
johnsom | Yeah, I think we should work on reviewing that. I wrote it into the driver spec... grin | 23:08 |
xgerman_ | rm_work: Q what happend with an existing system, e,g, where somebody didn’t stire pkcs12 certs in BBQ — dod they need to mugrate before that patch? | 23:08 |
rm_work | nope | 23:09 |
rm_work | so, it is designed to allow for both | 23:09 |
rm_work | it will try to use the new system first (use the ref to get a secret), but if that fails, it will fall-back to trying the old driver | 23:10 |
rm_work | if THAT fails, it will throw an error as it should | 23:10 |
rm_work | I tried to make it the least pain possible for people already migrating | 23:10 |
rm_work | oh, but I WAS going to adjust this patch so it will do the ACLs for you >_> | 23:10 |
bar_ | rm_work, does L69 in constants (above) make sense to you? | 23:11 |
rm_work | should I do that? :thumbsup: or :thumbsdown: | 23:11 |
rm_work | bar_: in MY patch? | 23:11 |
rm_work | or yours | 23:11 |
bar_ | In master I presume | 23:11 |
rm_work | ah, device_id = MOCK_COMPUTE_ID? | 23:11 |
bar_ | yeah, there is MOCK_DEVICE_ID there... | 23:11 |
rm_work | yeah the "device" is the compute instance I thought | 23:11 |
rm_work | hmmmm that is interesting tho | 23:11 |
rm_work | johnsom: when we get back a device_id on a port, is that referring to the VM it's bound to? | 23:12 |
rm_work | i can check that actually, one sec | 23:12 |
johnsom | Don't trust it | 23:12 |
rm_work | i mean this is for a test | 23:13 |
rm_work | we literally just ... named the thing possibly wrong | 23:13 |
rm_work | but i think it's fine | 23:13 |
rm_work | yes | 23:13 |
rm_work | device_id on a port is the server_id for what it's bound to | 23:13 |
rm_work | so in that mock, it makes sense, bar_ | 23:13 |
rm_work | i mean it's a little weird still to name it like that when it's all just a mock setup | 23:14 |
rm_work | but it IS logically the truth | 23:14 |
johnsom | But in real life that field can be unpredictable | 23:14 |
johnsom | Just FYI | 23:14 |
rm_work | k | 23:14 |
rm_work | it seems to work in our env | 23:14 |
openstackgerrit | Merged openstack/octavia master: Update compute noop driver/tests (many were disabled/useless) https://review.openstack.org/525295 | 23:19 |
*** jappleii__ has joined #openstack-lbaas | 23:20 | |
*** jappleii__ has quit IRC | 23:21 | |
*** jappleii__ has joined #openstack-lbaas | 23:22 | |
*** dmellado has quit IRC | 23:22 | |
bar_ | rm_work, ports still use tenant_id? | 23:22 |
rm_work | yes :/ | 23:22 |
rm_work | AFAICT | 23:22 |
*** threestrands_ has quit IRC | 23:22 | |
rm_work | can you do a get on one in your cloud and check? | 23:23 |
bar_ | rm_work, unfortunately not today. It's down. | 23:23 |
rm_work | that's still how we're loading them in via the methods | 23:23 |
rm_work | https://review.openstack.org/#/c/525353/6/octavia/network/drivers/neutron/utils.py | 23:23 |
rm_work | expand up a bit and see line 48 | 23:23 |
rm_work | i tested in my cloud and verified that is what we get back, but my cloud is very old :P so I can't say for sure it's true in Pike | 23:24 |
rm_work | but, if Pike returns something else, then we've got a bug | 23:24 |
bar_ | rm_work, couldn't it return both? | 23:25 |
rm_work | maybe | 23:25 |
rm_work | in which case, we could clean it up and even future-proof by just *looking* for either | 23:25 |
rm_work | feel free :P | 23:25 |
johnsom | I'm stacking, I can look in a few | 23:25 |
rm_work | i'm still waiting for you to push your other change tho | 23:26 |
bar_ | johnsom, thx, looks like my machine is back, too. It would take it a while, though... | 23:26 |
bar_ | rm_work, I know. | 23:26 |
openstackgerrit | Bar RH proposed openstack/octavia master: Improve Neutron driver _get_resource() https://review.openstack.org/527199 | 23:27 |
bar_ | rm_work, note that sleazy MOCK_SUBNET2 | 23:27 |
rm_work | lol | 23:27 |
openstackgerrit | Bar RH proposed openstack/octavia master: Improve Neutron driver _get_resource() https://review.openstack.org/527199 | 23:27 |
rm_work | sure, seems fine | 23:30 |
johnsom | show port has project_id and tenant_id | 23:30 |
bar_ | johnsom, thx | 23:32 |
*** dmellado has joined #openstack-lbaas | 23:36 | |
openstackgerrit | Merged openstack/octavia master: Reorder ComputeCreate arguments https://review.openstack.org/526965 | 23:46 |
*** sshank has joined #openstack-lbaas | 23:47 | |
*** johnsom has quit IRC | 23:56 | |
*** amitry has quit IRC | 23:57 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 23:58 | |
*** johnsom has joined #openstack-lbaas | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!