| johnsom | Why would it be looking at line length in the docs? | 00:00 |
|---|---|---|
| * rm_work shrugs | 00:01 | |
| johnsom | Hmm, wonder if it is an order issue for you. Like you ran docs first then pep8 | 00:01 |
| *** threestrands has joined #openstack-lbaas | 00:01 | |
| johnsom | Since all of that module stuff is auto generated | 00:02 |
| rm_work | maybe because my docs run can't complete | 00:02 |
| rm_work | but why does it shove it in the *source* dir | 00:02 |
| * johnsom shrugs... | 00:02 | |
| johnsom | Oh, well, those are the source content files. | 00:02 |
| johnsom | It takes those and renders them into html or pdf in the build dir | 00:03 |
| johnsom | Yeah, this isn't going to fail for me as it cleans those up when it's done | 00:03 |
| *** yamamoto has quit IRC | 00:03 | |
| johnsom | Ah, no it doesn't. Yeah, I get that now with "tox -e docs,pep8" | 00:04 |
| rm_work | why wouldn't it put those autogenerated things in the build dir | 00:06 |
| johnsom | Because those are source files | 00:06 |
| rm_work | ... | 00:06 |
| rm_work | but they aren't | 00:06 |
| rm_work | they're generated | 00:06 |
| rm_work | during the build process | 00:06 |
| rm_work | FROM the real source files | 00:06 |
| johnsom | The are generated source files that are then rendered into the build directory based on the format specified | 00:07 |
| rm_work | if you delete those | 00:07 |
| rm_work | will they be generated again? | 00:07 |
| johnsom | Yes | 00:07 |
| rm_work | if so, it's pretty clear they aren't sources | 00:07 |
| rm_work | they're intermediates at best | 00:07 |
| johnsom | It's RST files | 00:08 |
| johnsom | RST isn't valid in build | 00:08 |
| rm_work | well it is clearly not source | 00:08 |
| johnsom | All our other source files are RST | 00:08 |
| rm_work | source implies it is ... the source | 00:12 |
| rm_work | but it's not | 00:12 |
| rm_work | it's generated FROm the source | 00:12 |
| rm_work | it is literally impossible to call something that is generated FROM a source "a source" | 00:12 |
| johnsom | If we typed that in by hand would it be "source"? | 00:12 |
| rm_work | yes | 00:13 |
| * johnsom looks for the table flip ascii | 00:13 | |
| rm_work | but since it's generated FROM something else | 00:13 |
| rm_work | it should not end up in a source directory | 00:13 |
| openstackgerrit | Tong Liu proposed openstack/octavia master: Update instance methods to static method https://review.openstack.org/526551 | 00:13 |
| johnsom | Sphinx only knows of source and build as far as I know... "source" directory is the RST, "build" is the HTML, PDF, etc. | 00:14 |
| rm_work | well if they go to the source dir we're going to be running tests on generated files <_< | 00:14 |
| johnsom | Maybe the real issue is that module name is too long... | 00:15 |
| johnsom | Where do we exclude the build directory from that check? | 00:19 |
| johnsom | I don't think we do. | 00:19 |
| johnsom | So, hack it? put a rm -rf in the docs block in tox.ini? | 00:21 |
| rm_work | err | 00:23 |
| rm_work | on what? we can't rm -rf source | 00:23 |
| johnsom | Hmm doc8 has a --allow-long-titles option... | 00:23 |
| openstackgerrit | Tong Liu proposed openstack/python-octaviaclient master: Change --http_method arg to --http-method https://review.openstack.org/526555 | 00:23 |
| johnsom | The modules directory was what I was thinking. | 00:23 |
| rm_work | and we do `doc8 specs doc/source octavia` | 00:23 |
| johnsom | I mean I can point that almost anywhere, but as far as I can see that checker runs on everything | 00:24 |
| rm_work | so yes, we exclude build | 00:24 |
| johnsom | Ah, well, there we go | 00:25 |
| *** rcernin has quit IRC | 00:25 | |
| *** rcernin has joined #openstack-lbaas | 00:25 | |
| *** tongl has quit IRC | 00:27 | |
| johnsom | So, we can enable "--allow-long-titles", ignore the autodoc dir completely, or do two runs, one ignoring autodoc and then one that runs it on the autodoc content with --allow-long-titles" | 00:33 |
| rm_work | i think we ignore the autodoc dir | 00:33 |
| rm_work | is there a command for that in doc8? | 00:34 |
| rm_work | ah yeah | 00:34 |
| rm_work | --ignore-path | 00:34 |
| rm_work | i vote for that | 00:34 |
| rm_work | one sec | 00:34 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Have doc8 ignore autodoc content https://review.openstack.org/526556 | 00:34 |
| johnsom | I guess my commit message is slightly off | 00:35 |
| rm_work | ah i was just doing it | 00:35 |
| rm_work | lol | 00:35 |
| rm_work | i don't think we bother with the generated ones | 00:36 |
| rm_work | they're generated | 00:36 |
| rm_work | why do we care | 00:36 |
| rm_work | we don't need to test if the generator is broken? | 00:36 |
| johnsom | Just if the docs job is failing and we are running pep to figure out why. | 00:36 |
| johnsom | Yeah, it's reaching isn't it | 00:36 |
| rm_work | also can you remove the tabs | 00:37 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Have doc8 ignore autodoc content https://review.openstack.org/526556 | 00:37 |
| johnsom | tabs? | 00:37 |
| johnsom | oh | 00:37 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Have doc8 ignore autodoc content https://review.openstack.org/526556 | 00:38 |
| johnsom | wonder how long those have been there | 00:38 |
| rm_work | heh | 00:38 |
| *** cody-somerville has quit IRC | 00:39 | |
| johnsom | Ok, quick glance at those exceptions? | 00:41 |
| rm_work | yeah i looked | 00:42 |
| rm_work | they look sane to me | 00:42 |
| rm_work | I am trying to remember what the thing was that I was really upset about during one of the lunches during the PTG | 00:42 |
| johnsom | Ok, I was trying to find the root Exception object to look at. I was wondering if I should do something with the base "message". I mean really we are just going to catch these and raise other API excpetions.... | 00:43 |
| johnsom | Well, our existing exceptions are a train wreck | 00:43 |
| johnsom | IMO | 00:43 |
| johnsom | I think the base exception returns true/false for unicode strings. Not positive, but it looks wrong to me | 00:44 |
| johnsom | The whole msg/message thing bugs me in our base exceptions | 00:44 |
| rm_work | yeah | 00:45 |
| rm_work | they're pretty gross | 00:45 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Don't run fucntional jobs for docs changes https://review.openstack.org/526548 | 00:45 |
| johnsom | Ok, thanks for the quick sanity check on those. I just have the library section and a few other cleanups to go on the driver spec. | 00:47 |
| *** jniesz has quit IRC | 00:50 | |
| *** SumitNaiksatam has quit IRC | 00:51 | |
| *** yamamoto has joined #openstack-lbaas | 00:59 | |
| johnsom | I still think creating a library is a bad idea for these drivers. | 01:03 |
| johnsom | We are going to have to setup another repo for it | 01:03 |
| johnsom | Unless we make them push that data back to the API servers | 01:04 |
| *** yamamoto has quit IRC | 01:04 | |
| rm_work | well we wanted a lib anyway | 01:04 |
| rm_work | johnsom: do we have a priority list still? | 01:29 |
| rm_work | IMO we should have a permanent priority etherpad in the IRC topic | 01:29 |
| *** sshank has quit IRC | 01:31 | |
| *** sanfern has joined #openstack-lbaas | 01:31 | |
| johnsom | Sigh, focused on the driver spec and didn’t work on one yet. If you have cycles, the driver spec is good for reviews other than the library block. We should also review the qos patch. It has been open a long time and should be good for review | 01:32 |
| *** csomerville has quit IRC | 01:48 | |
| *** yamamoto has joined #openstack-lbaas | 02:00 | |
| *** harlowja has quit IRC | 02:03 | |
| *** yamamoto has quit IRC | 02:04 | |
| rm_work | yeah i was going to | 02:21 |
| rm_work | but i still don't really know what that is | 02:21 |
| *** annp has joined #openstack-lbaas | 02:26 | |
| *** sanfern has quit IRC | 02:28 | |
| bzhao | I found the keepalived version 1.2.19 not support multi processes towards a linux network namespace, is it necessary to change the current DIB to source code install/a higher version in diskimage builder elements? | 02:56 |
| rm_work | what? | 02:58 |
| rm_work | i didn't think it mattered at all what the app supported | 02:58 |
| *** yamamoto has joined #openstack-lbaas | 03:01 | |
| bzhao | when I work on udp coding, I found the current keepalived version is 1.2.19 in amp image, it not support configure that a keepalived process running in a particular linux network namespace. The new keepalived version support 'net_namespace' configuration option. So I just ask if need to update the DIB or I made a mistake? | 03:03 |
| bzhao | So I use the reference way that "ip netns exec keepalived -D .....", I still found "Daemon is already existing" in syslog, eventhrough I specified pid file or different configuration. | 03:06 |
| *** yamamoto has quit IRC | 03:06 | |
| bzhao | But I test a version 1.3.9, it work as wish.. | 03:07 |
| rm_work | hmmm | 03:10 |
| rm_work | i would need to look into it further | 03:10 |
| rm_work | that seems odd | 03:10 |
| *** tongl has joined #openstack-lbaas | 03:10 | |
| rm_work | bzhao: i did an update to your UDP spec just to fix some wording, if you want to look it over and make sure i didn't change your MEANING anywhere, that'd be good | 03:11 |
| rm_work | there were a couple places it was a little bit unclear | 03:11 |
| *** bbbbzhao_ has joined #openstack-lbaas | 03:14 | |
| openstackgerrit | huangshan proposed openstack/octavia master: Check if it is used when creating a load balancer using vip_port_id https://review.openstack.org/525069 | 03:19 |
| bzhao | rm_work, oh Thanks very much for update the spec. I just see it. :) | 03:25 |
| rm_work | to be clear, the idea is that the amps will run BOTH LVS + HAProxy right? | 03:25 |
| bzhao | yeah, but just for single and active/standy topology | 03:26 |
| rm_work | so no real topology changes needed, just ... if you pass UDP as the protocol, we use a keepalived-udp template instead of an haproxy template | 03:26 |
| rm_work | but all the listeners still just run on the same box | 03:26 |
| rm_work | makes sense to me | 03:26 |
| bzhao | yeah, just a UDP listener 1:1 keepalived process | 03:26 |
| rm_work | i'm about ready to +2, but i'd like some other people to go over it first and make sure i didn't miss anything or mess anything up | 03:26 |
| rm_work | yep | 03:26 |
| rm_work | seems really straightforward | 03:26 |
| rm_work | should be easy-ish | 03:26 |
| bzhao | Yeah, :) Thanks | 03:27 |
| *** SumitNaiksatam has joined #openstack-lbaas | 03:29 | |
| *** SumitNaiksatam_ has joined #openstack-lbaas | 03:32 | |
| *** SumitNaiksatam has quit IRC | 03:33 | |
| *** SumitNaiksatam_ is now known as SumitNaiksatam | 03:33 | |
| *** links has joined #openstack-lbaas | 03:42 | |
| *** yamamoto has joined #openstack-lbaas | 04:03 | |
| *** aojea has joined #openstack-lbaas | 04:04 | |
| *** yamamoto has quit IRC | 04:06 | |
| *** armax has quit IRC | 04:06 | |
| *** yamamoto has joined #openstack-lbaas | 04:06 | |
| *** armax has joined #openstack-lbaas | 04:07 | |
| *** armax has quit IRC | 04:07 | |
| *** aojea has quit IRC | 04:08 | |
| johnsom | bzhao: Hi, can’t talk long time night, but we should be able to run a bunch of keepalived processes (we do for multiple listeners). Can you post your keepalived config you were getting an error with? I will test tomorrow | 04:24 |
| rm_work | johnsom: err, we do? I don't think we run more than one keepalived right now? and they wouldn't be bound into the namespace, which seemed to be his problem | 04:25 |
| johnsom | Yeah, we do. | 04:26 |
| rm_work | what is the point of that even | 04:26 |
| rm_work | keepalived is only running to do vrrp between two amps | 04:26 |
| rm_work | we don't even start it on SINGLE topo amps | 04:26 |
| johnsom | Hmm, now I am trying to remember why. I just remember to mess with generating unique port numbers for the instances | 04:28 |
| johnsom | To sync | 04:28 |
| johnsom | Maybe it was for multi vip on one amp? | 04:28 |
| johnsom | I am pretty sure we can do it, so want to look at the config and test | 04:29 |
| rm_work | erg | 04:30 |
| rm_work | well if you figure out why, let me know | 04:30 |
| rm_work | I cannot think of a good reason | 04:30 |
| johnsom | With the udp you don’t want to restart everything for one port reconfig | 04:31 |
| johnsom | Right? | 04:31 |
| rm_work | right ... | 04:33 |
| rm_work | but ... | 04:33 |
| rm_work | keepalived just does VRRP | 04:33 |
| rm_work | that's it | 04:33 |
| johnsom | It will be driving the udp ports | 04:33 |
| rm_work | it WILL be | 04:34 |
| rm_work | right now we don't do that | 04:34 |
| rm_work | and actually no, it'll just be configuring LVS which will be driving the UDP ports | 04:34 |
| johnsom | Yeah, i might be remembering multi vip. | 04:34 |
| rm_work | keepalived will: "configure LVS" and "do member health checks" | 04:35 |
| rm_work | so i am not super concerned (though we will keep them as multiple processes just because it's EASIER to | 04:35 |
| johnsom | I should not log on from my mobile on date night... | 04:35 |
| rm_work | because then it's a literal dropin for haproxy | 04:35 |
| rm_work | loooolno | 04:35 |
| *** sanfern has joined #openstack-lbaas | 04:46 | |
| *** sticker has quit IRC | 05:03 | |
| *** rcernin has quit IRC | 05:11 | |
| rm_work | awesome, verified in devstack the amp-failover-api works | 05:16 |
| rm_work | erg gate backed uo | 05:17 |
| rm_work | *backed up. that means it's time for me to afk for a while :P night | 05:18 |
| *** sanfern has quit IRC | 05:20 | |
| *** threestrands has quit IRC | 05:24 | |
| *** harlowja has joined #openstack-lbaas | 05:37 | |
| *** threestrands has joined #openstack-lbaas | 05:39 | |
| *** threestrands has quit IRC | 05:39 | |
| *** threestrands has joined #openstack-lbaas | 05:39 | |
| *** dokua has quit IRC | 05:44 | |
| *** armax has joined #openstack-lbaas | 05:45 | |
| *** armax has quit IRC | 05:55 | |
| *** armax has joined #openstack-lbaas | 05:55 | |
| *** armax has quit IRC | 05:55 | |
| *** armax has joined #openstack-lbaas | 05:56 | |
| *** armax has quit IRC | 05:56 | |
| *** rcernin has joined #openstack-lbaas | 06:11 | |
| *** harlowja has quit IRC | 06:14 | |
| bzhao | rm_work, Good night. :) | 06:17 |
| bzhao | Hi johnsom, Sorry for late back. I just test with very simple keepalived config | 06:17 |
| bzhao | This is my new keepalived config. | 06:17 |
| bzhao | http://paste.openstack.org/show/628411/ | 06:17 |
| bzhao | This is the existing keepalived config. It was still running | 06:17 |
| bzhao | http://paste.openstack.org/show/628412/ | 06:17 |
| bzhao | I run keepalived like "ip netns exec amphora-haproxy keepalived -D -d -f config". | 06:17 |
| bzhao | Then I saw the log in syslog like: | 06:17 |
| bzhao | http://paste.openstack.org/show/628413/ | 06:17 |
| openstackgerrit | huangshan proposed openstack/python-octaviaclient master: Add listener stats client api and osc https://review.openstack.org/526603 | 06:28 |
| *** threestrands has quit IRC | 06:28 | |
| openstackgerrit | huangshan proposed openstack/python-octaviaclient master: Add listener stats client api and osc https://review.openstack.org/526603 | 06:30 |
| bzhao | Also, the higher version of keepalived, such as 1.3.9 It supports "net_namespace" and "instance" configuration options. Fo runing multiple keepalveds in the same namespace. | 06:30 |
| openstackgerrit | huangshan proposed openstack/python-octaviaclient master: Add listener stats client api and osc https://review.openstack.org/526603 | 06:38 |
| bzhao | The test with keepalived version 1.3.9 | 06:49 |
| bzhao | http://paste.openstack.org/show/628414/ | 06:49 |
| bzhao | My env(Active/standby) contains 2 namespaces, named 'lbb' and 'lbb2', these configurations look very similar, but with different 'instance', 'net_namespace', 'vrrp_instance'. | 06:49 |
| bzhao | Each namespaces run 2 keepalived process. such as: | 06:49 |
| bzhao | http://paste.openstack.org/show/628414/ | 06:49 |
| bzhao | Config file: | 06:49 |
| bzhao | http://paste.openstack.org/show/628415/ | 06:49 |
| bzhao | ipvsadm looks like in both namespaces | 06:49 |
| bzhao | http://paste.openstack.org/show/628418/ | 06:49 |
| bzhao | For the UDP 138.138.82.222:1234 rr virtual server, that's I just test in the single topology and its config file is: | 06:49 |
| bzhao | http://paste.openstack.org/show/628419/ | 06:49 |
| bzhao | And the test keepalived process running at least. And set the lvs configure. So I just want to ask if we need to change to the new version, or maybe there is another way to solve. Sorry for that. | 06:49 |
| bzhao | I searched in google. This may be the first appear in keepalived v1.2.24 . https://github.com/acassen/keepalived/blob/v1.2.24/keepalived/core/namespaces.c | 07:00 |
| bzhao | OK, that's all. Waiting for your guys feedback. :) | 07:01 |
| *** tongl has quit IRC | 07:02 | |
| -openstackstatus- NOTICE: Due to some unforseen Zuul issues the gate is under very high load and extremely unstable at the moment. This is likely to persist until PST morning | 07:03 | |
| *** ChanServ changes topic to "Due to some unforseen Zuul issues the gate is under very high load and extremely unstable at the moment. This is likely to persist until PST morning" | 07:03 | |
| *** m-greene- has quit IRC | 07:05 | |
| *** m-greene_ has quit IRC | 07:05 | |
| *** mugsie has quit IRC | 07:07 | |
| *** ptoohill has quit IRC | 07:08 | |
| *** mugsie has joined #openstack-lbaas | 07:08 | |
| *** mugsie has quit IRC | 07:08 | |
| *** mugsie has joined #openstack-lbaas | 07:08 | |
| *** sbalukoff_ has quit IRC | 07:08 | |
| *** ptoohill has joined #openstack-lbaas | 07:11 | |
| openstackgerrit | huangshan proposed openstack/python-octaviaclient master: Add listener stats client api and osc https://review.openstack.org/526603 | 07:12 |
| *** bbbbzhao_ has quit IRC | 07:14 | |
| openstackgerrit | huangshan proposed openstack/python-octaviaclient master: Add listener stats client api and osc https://review.openstack.org/526610 | 07:31 |
| *** sbalukoff_ has joined #openstack-lbaas | 07:35 | |
| *** kobis has joined #openstack-lbaas | 08:02 | |
| *** b_bezak has joined #openstack-lbaas | 08:04 | |
| *** aojea has joined #openstack-lbaas | 08:20 | |
| *** aojea has quit IRC | 08:20 | |
| *** aojea has joined #openstack-lbaas | 08:20 | |
| *** tesseract has joined #openstack-lbaas | 08:20 | |
| *** kobis has quit IRC | 08:23 | |
| openstackgerrit | huangshan proposed openstack/octavia master: Remove network_tasks.UpdateVIP task in get_delete_listener_internal_flow https://review.openstack.org/526623 | 08:28 |
| *** sapd__ has joined #openstack-lbaas | 08:31 | |
| *** sapd_ has quit IRC | 08:31 | |
| *** aojea has quit IRC | 08:33 | |
| *** sapd__ has quit IRC | 09:11 | |
| *** sapd has joined #openstack-lbaas | 09:12 | |
| *** sapd_ has joined #openstack-lbaas | 09:22 | |
| *** sapd has quit IRC | 09:22 | |
| *** gcheresh has joined #openstack-lbaas | 09:34 | |
| *** yamamoto has quit IRC | 09:41 | |
| *** yamamoto has joined #openstack-lbaas | 09:43 | |
| *** numans has quit IRC | 09:45 | |
| *** numans has joined #openstack-lbaas | 09:50 | |
| *** gcheresh has quit IRC | 09:56 | |
| *** Alex_Staf has joined #openstack-lbaas | 09:56 | |
| *** salmankhan has joined #openstack-lbaas | 10:06 | |
| *** annp has quit IRC | 10:07 | |
| *** Alex_Staf has quit IRC | 10:16 | |
| *** openstackgerrit has quit IRC | 11:17 | |
| *** yamamoto has quit IRC | 11:21 | |
| *** cgoncalves has quit IRC | 11:24 | |
| *** cgoncalves has joined #openstack-lbaas | 11:25 | |
| *** links has quit IRC | 11:28 | |
| *** salmankhan has quit IRC | 11:33 | |
| *** salmankhan has joined #openstack-lbaas | 11:37 | |
| *** links has joined #openstack-lbaas | 11:41 | |
| *** eN_Guruprasad_Rn has joined #openstack-lbaas | 11:47 | |
| *** yamamoto has joined #openstack-lbaas | 11:49 | |
| *** tesseract has quit IRC | 11:50 | |
| *** tesseract has joined #openstack-lbaas | 11:51 | |
| *** sanfern has joined #openstack-lbaas | 12:10 | |
| *** yamamoto has quit IRC | 12:51 | |
| *** bbzhao has quit IRC | 13:02 | |
| *** bbzhao has joined #openstack-lbaas | 13:02 | |
| *** dokua has joined #openstack-lbaas | 13:19 | |
| *** aojea has joined #openstack-lbaas | 13:33 | |
| *** aojea has quit IRC | 13:37 | |
| *** tesseract has quit IRC | 13:47 | |
| *** tesseract has joined #openstack-lbaas | 13:50 | |
| *** yamamoto has joined #openstack-lbaas | 13:52 | |
| *** yamamoto has quit IRC | 13:58 | |
| *** ChanServ changes topic to "Welcome to LBaaS / Octavia - Queens development is now open." | 13:59 | |
| -openstackstatus- NOTICE: The issues have been fixed, Zuul is operating fine again but has a large backlog. You can recheck jobs that failed. | 13:59 | |
| *** yamamoto has joined #openstack-lbaas | 14:01 | |
| *** dokua has quit IRC | 14:25 | |
| *** salmankhan has quit IRC | 14:33 | |
| *** links has quit IRC | 14:37 | |
| *** salmankhan has joined #openstack-lbaas | 14:42 | |
| *** rcernin has quit IRC | 14:55 | |
| *** eN_Guruprasad_Rn has quit IRC | 15:01 | |
| *** jniesz has joined #openstack-lbaas | 15:02 | |
| *** sanfern has quit IRC | 15:02 | |
| *** KeithMnemonic has joined #openstack-lbaas | 15:20 | |
| *** armax has joined #openstack-lbaas | 15:24 | |
| *** tongl has joined #openstack-lbaas | 15:25 | |
| *** KeithMnemonic has quit IRC | 15:28 | |
| *** KeithMnemonic has joined #openstack-lbaas | 15:28 | |
| *** KeithMnemonic has quit IRC | 15:31 | |
| *** KeithMnemonic has joined #openstack-lbaas | 15:31 | |
| *** bar_ has joined #openstack-lbaas | 15:42 | |
| *** salmankhan has quit IRC | 15:57 | |
| *** salmankhan has joined #openstack-lbaas | 16:02 | |
| *** tongl has quit IRC | 16:11 | |
| *** tongl has joined #openstack-lbaas | 16:12 | |
| *** eN_Guruprasad_Rn has joined #openstack-lbaas | 16:28 | |
| *** openstackgerrit has joined #openstack-lbaas | 16:35 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Don't run fucntional jobs for docs changes https://review.openstack.org/526548 | 16:35 |
| *** AlexeyAbashkin has joined #openstack-lbaas | 16:40 | |
| *** AlexeyAbashkin has quit IRC | 16:44 | |
| *** eN_Guruprasad_Rn has quit IRC | 16:45 | |
| *** sanfern has joined #openstack-lbaas | 16:50 | |
| *** kobis has joined #openstack-lbaas | 17:03 | |
| *** b_bezak has quit IRC | 17:05 | |
| *** tongl has quit IRC | 17:17 | |
| openstackgerrit | Santhosh Fernandes proposed openstack/octavia master: ACTIVE-ACTIVE rename vrrp_ to frontend_ https://review.openstack.org/521138 | 17:28 |
| *** tesseract has quit IRC | 17:29 | |
| sanfern | hi johnsom , | 17:34 |
| johnsom | sanfern Good morning (here... grin) | 17:34 |
| sanfern | Good morning | 17:35 |
| johnsom | It looked like you got the rebase working yesterday. Is ther something I should look at today? | 17:36 |
| sanfern | I fixed backward compatibility issue with rename - https://review.openstack.org/#/c/521138/14/octavia/amphorae/drivers/haproxy/rest_api_driver.py | 17:37 |
| sanfern | Thanks to xgerman_ | 17:37 |
| sanfern | Need to review - https://review.openstack.org/#/c/490164/ | 17:38 |
| johnsom | Ok, cool | 17:38 |
| *** kobis has quit IRC | 17:39 | |
| *** kobis has joined #openstack-lbaas | 17:40 | |
| sanfern | some test case are failing - http://paste.openstack.org/show/gYgJVfQ90PnaGlt4bvX2/ | 17:42 |
| johnsom | sanfern Yeah, looks like a referential integrity issue in the database. Likely either ID 246c791f-ad71-4d92-9b2a-922b5a3153e5 doesn't exist in the amphora table or ID 2baf87f4-eee7-43fe-ad51-387245e425cf doesn't exist in the load balancer table | 17:44 |
| sanfern | ok I agree. I need to create all those reference tables populated. | 17:45 |
| sanfern | Thanks johnsom | 17:45 |
| *** bar_ has quit IRC | 17:45 | |
| johnsom | Sure, NP | 17:45 |
| johnsom | FYI, python-octaviaclient 1.3.0 is now available on PyPi | 17:51 |
| *** kobis has quit IRC | 17:54 | |
| *** yamamoto has quit IRC | 18:02 | |
| *** openstackgerrit has quit IRC | 18:03 | |
| *** tongl has joined #openstack-lbaas | 18:10 | |
| xgerman_ | yeah! | 18:10 |
| *** yamamoto has joined #openstack-lbaas | 18:16 | |
| *** yamamoto has quit IRC | 18:21 | |
| *** sshank has joined #openstack-lbaas | 18:25 | |
| *** salmankhan has quit IRC | 18:31 | |
| *** yamamoto has joined #openstack-lbaas | 18:32 | |
| *** yamamoto has quit IRC | 18:36 | |
| *** yamamoto has joined #openstack-lbaas | 18:44 | |
| *** yamamoto has quit IRC | 18:44 | |
| *** yamamoto has joined #openstack-lbaas | 18:44 | |
| *** yamamoto has quit IRC | 18:45 | |
| *** kobis has joined #openstack-lbaas | 18:57 | |
| *** kobis has quit IRC | 19:02 | |
| *** aojea has joined #openstack-lbaas | 19:08 | |
| *** aojea has quit IRC | 19:15 | |
| *** harlowja has joined #openstack-lbaas | 19:21 | |
| *** tongl has quit IRC | 19:21 | |
| rm_work | xgerman_ / nmagnezi plz: https://review.openstack.org/#/c/526556/ | 19:28 |
| *** sshank has quit IRC | 19:28 | |
| *** sshank has joined #openstack-lbaas | 19:35 | |
| *** openstackgerrit has joined #openstack-lbaas | 19:39 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Provider driver spec https://review.openstack.org/509957 | 19:39 |
| johnsom | Ok, I am pretty happy with that. Would like comments... | 19:40 |
| *** sshank has quit IRC | 19:43 | |
| *** sshank has joined #openstack-lbaas | 19:43 | |
| *** kobis has joined #openstack-lbaas | 19:45 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 19:46 | |
| *** yamamoto has joined #openstack-lbaas | 19:46 | |
| rm_work | nmagnezi: around? | 19:48 |
| *** yamamoto has quit IRC | 19:52 | |
| *** kobis has quit IRC | 19:55 | |
| *** kobis has joined #openstack-lbaas | 19:55 | |
| *** kobis has quit IRC | 19:56 | |
| *** kobis has joined #openstack-lbaas | 19:56 | |
| *** AlexeyAbashkin has quit IRC | 19:56 | |
| *** kobis has quit IRC | 19:57 | |
| xgerman_ | will have a look at provider spec before I go into the weekend | 20:11 |
| *** sshank has quit IRC | 20:12 | |
| *** yamamoto has joined #openstack-lbaas | 20:48 | |
| *** yamamoto has quit IRC | 20:52 | |
| *** sshank has joined #openstack-lbaas | 20:55 | |
| openstackgerrit | Merged openstack/octavia master: Have doc8 ignore autodoc content https://review.openstack.org/526556 | 21:03 |
| *** dokua has joined #openstack-lbaas | 21:20 | |
| *** jniesz has quit IRC | 21:31 | |
| rm_work | me too | 21:35 |
| *** dokua has quit IRC | 21:37 | |
| *** dokua has joined #openstack-lbaas | 21:40 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Add unit tests for neutron utils, add model/util for floating_ip https://review.openstack.org/525353 | 21:41 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Producer/endpoint code to allow for amphora failovers https://review.openstack.org/525302 | 21:42 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Switch to using PKCS12 for TLS Term certs https://review.openstack.org/504175 | 21:42 |
| rm_work | oops not the rebase i meant | 21:42 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Move loading the network driver into the flows https://review.openstack.org/525790 | 21:43 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Producer/endpoint code to allow for amphora failovers https://review.openstack.org/525302 | 21:44 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Amphora API Failover call https://review.openstack.org/525778 | 21:44 |
| *** rcernin has joined #openstack-lbaas | 21:44 | |
| rm_work | making a chain | 21:44 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Add unit tests for neutron utils, add model/util for floating_ip https://review.openstack.org/525353 | 21:45 |
| johnsom | Booom | 21:49 |
| *** yamamoto has joined #openstack-lbaas | 21:49 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: WIP: Floating IP Network Driver (spans L3s) https://review.openstack.org/435612 | 21:49 |
| rm_work | ok | 21:51 |
| rm_work | now i have a stupidly long chain | 21:52 |
| rm_work | to bug you guys about merging :P | 21:52 |
| rm_work | time to look at your spec! | 21:52 |
| johnsom | grin | 21:52 |
| *** dokua has quit IRC | 21:53 | |
| rm_work | the first patch there should be a no-brainer, and the second one and third/fourth are good to go too IMO | 21:54 |
| *** yamamoto has quit IRC | 21:54 | |
| johnsom | Already +2 the first one | 21:54 |
| rm_work | I wish bar was online so i could ask him about his comment | 21:55 |
| rm_work | i am 95% sure he's wrong | 21:55 |
| johnsom | On #2? I think you are good, but still looking at it | 21:55 |
| rm_work | though the whole thing is super trivial | 21:55 |
| rm_work | also, it IS an option to *make it* a class var | 21:56 |
| rm_work | so it'd be a real singleton | 21:56 |
| rm_work | I CAN do that, and honestly it's not a bad idea | 21:56 |
| rm_work | i just wanted to have as light a touch as possible so we could get the change in quickly/easily | 21:57 |
| rm_work | i don't THINK it'd break anything to make it a singleton... | 21:57 |
| rm_work | though maybe around auth? | 21:57 |
| rm_work | i don't know if it handles any auth when initialized, and if it'd re-auth? | 21:57 |
| johnsom | What calls network_driver()? | 21:57 |
| rm_work | down a bit | 21:57 |
| rm_work | like, the execute in a bunch of stuff | 21:58 |
| rm_work | self.network_driver.plug_network() for example | 21:58 |
| rm_work | is called in PlugNetworks.execute | 21:58 |
| johnsom | Ah, I get it | 21:59 |
| rm_work | so i could try to be fancy and make it a singleton but that might be risky without a lot of thought/testing | 22:00 |
| rm_work | so i opted to do just a minimal change | 22:00 |
| *** rcernin has quit IRC | 22:03 | |
| *** rcernin has joined #openstack-lbaas | 22:03 | |
| rm_work | wow this is long T_T | 22:13 |
| johnsom | Yeah, tell me about it | 22:13 |
| johnsom | But, I think reasonably complete is good here | 22:13 |
| rm_work | yeah but my brain started hurting just from looking at the scrollbar | 22:14 |
| rm_work | and my eyes are pre-blurry, and it's barely afternoon | 22:14 |
| johnsom | It's all the sample code... grin | 22:14 |
| rm_work | kk | 22:14 |
| rm_work | when it comes to writing the code for this... hopefully i can help with hammering some of these things out? | 22:14 |
| rm_work | I hope | 22:15 |
| johnsom | Of course | 22:15 |
| rm_work | i mean, i literally hope i am able to | 22:15 |
| johnsom | HA | 22:15 |
| rm_work | i think i'm just not going to do grammar nitpicks in this one | 22:16 |
| johnsom | You won't offend me | 22:17 |
| rm_work | yeah but it's just so long | 22:17 |
| *** ianychoi_ has joined #openstack-lbaas | 22:17 | |
| rm_work | so i had a patch up a while ago | 22:18 |
| rm_work | that let drivers patch themselves into the initial API validation layer | 22:18 |
| johnsom | Yeah, I shot it down a few times I think | 22:18 |
| rm_work | but we are opting to take things that could be incorrect, return a 202, and then go to ERROR because of the driver? | 22:18 |
| rm_work | still seems a little sad to me | 22:18 |
| rm_work | when we could just do the validation up-front and never 20x | 22:19 |
| rm_work | the 400 should be immediate | 22:19 |
| johnsom | No, they should validate before returning | 22:19 |
| johnsom | Wait, what? | 22:19 |
| rm_work | ah ok so you do mean for it to be that way | 22:19 |
| *** ianychoi has quit IRC | 22:19 | |
| johnsom | So our API still does validation, they will validate they can accept what is asked, then return | 22:19 |
| rm_work | ok | 22:20 |
| rm_work | i'm looking at the create method in http://logs.openstack.org/57/509957/15/check/build-openstack-sphinx-docs/15bdf45/html/contributor/specs/version1.1/enable-provider-driver.html#load-balancer | 22:20 |
| johnsom | We will check for malformed, missing options, bad combinations, etc. | 22:20 |
| rm_work | and i guess the way i read it was that it'd be non-syncronous | 22:20 |
| rm_work | but ok, as long as it's passed to the driver syncronously there, that's fine | 22:20 |
| rm_work | i suppose i'm still thinking in terms of "behind the queue" but it isn't | 22:21 |
| johnsom | We don't expect them to fully create the LB, just "accept" the request | 22:21 |
| johnsom | Right, no queue here | 22:21 |
| rm_work | "The provider will be removed as this is used for driver selection." | 22:21 |
| rm_work | why do we even bother | 22:21 |
| rm_work | does it matter? | 22:21 |
| johnsom | I don't want it to get overloaded | 22:22 |
| rm_work | lol | 22:22 |
| rm_work | k | 22:22 |
| rm_work | yeah i was just thinking "it might be useful for them to check what provider they are, if they're using the same driver for multiple providers or something" but that might get ridiculous | 22:22 |
| johnsom | Excatly! | 22:23 |
| rm_work | and the provider could be renamed by an operator, technically | 22:23 |
| rm_work | yeah so the VIP creation is sync now | 22:23 |
| rm_work | i almost forgot about that | 22:24 |
| rm_work | so yeah it obviously HAS to validate | 22:24 |
| johnsom | Yeah, I have got feedback on that from Tong. He wants us to create the vip. It think that is limiting for the drivers.... | 22:25 |
| rm_work | yes... | 22:25 |
| johnsom | I hope we get more feedback on that | 22:25 |
| rm_work | I think that *doesn't* work with the A10 setup we have | 22:25 |
| rm_work | (and we're looking at using a flavor to expose our A10 stuff via Octavia when this is done) | 22:26 |
| johnsom | Right, it seems like the driver needs to own the VIP creation. | 22:26 |
| rm_work | I would assume so | 22:26 |
| johnsom | Ha, think of the heck we would get if we created AAP ports for everyone... | 22:27 |
| johnsom | Grin | 22:27 |
| rm_work | ah interesting, you are saying we'll be on PKCS12 by the time we finish this | 22:27 |
| rm_work | so probably you should review that patch :P | 22:27 |
| johnsom | I figured we should just go for it. | 22:27 |
| rm_work | it really would be good to get that in | 22:27 |
| rm_work | and have some testing time on it | 22:27 |
| rm_work | oh, i was going to modify it to do the session-hijack+ACL-add | 22:27 |
| rm_work | to end this BS once and for all | 22:28 |
| johnsom | Yeah, it's on my short list. I'm looking at QoS now. That patch has been sitting way too long. | 22:28 |
| rm_work | i'll do that really quick | 22:28 |
| johnsom | Giving it some love | 22:28 |
| rm_work | kk | 22:28 |
| rm_work | honestly if you think the QoS is good, i'm just going to review it for anything obviously bad in the code | 22:28 |
| johnsom | I kicked the tires on it once before, found one gap that I think he fixed. I'm just giving it a top down read again. Might fix a minor grammar thing on the fly here. | 22:29 |
| rm_work | hmmm, i'm not sure if we need to pass the default_pool_id | 22:29 |
| rm_work | if we pass a default_pool that's an object... | 22:29 |
| rm_work | it'll be in that | 22:29 |
| johnsom | pool can exist on LBs already though | 22:30 |
| rm_work | yeah but this is the struct that's passed to the driver, right? | 22:30 |
| rm_work | so it'll already have loaded in the default_pool | 22:30 |
| rm_work | so we can throw away the id field | 22:30 |
| rm_work | kinda like the provider field | 22:31 |
| rm_work | it's already been used | 22:31 |
| rm_work | just seems redundant to have both the id and the actual pool on there | 22:31 |
| rm_work | but i guess it doesn't matter, was just a thought | 22:31 |
| rm_work | listener.default_pool_id == listener.default_pool.id | 22:31 |
| johnsom | Not following. If you have an LB with 10 pools attached and you create a listner, you want to specify the pool_id to use as default for the listener right? | 22:32 |
| rm_work | yes, in the API | 22:32 |
| rm_work | then we make this dict and pass it around? | 22:32 |
| rm_work | aren't these defining the dict that will be passed to the driver? | 22:32 |
| johnsom | default pool is only used for single call creates | 22:32 |
| rm_work | ok ... | 22:32 |
| johnsom | Yes | 22:32 |
| rm_work | but default_pool_id and default_pool are directly linked | 22:33 |
| rm_work | we're talking about on the listener | 22:33 |
| rm_work | http://logs.openstack.org/57/509957/15/check/build-openstack-sphinx-docs/15bdf45/html/contributor/specs/version1.1/enable-provider-driver.html#listener | 22:33 |
| johnsom | Yeah, you would not pass both IMO | 22:33 |
| rm_work | right | 22:33 |
| rm_work | but you're showing both being passed, no? | 22:33 |
| rm_work | i mean, are you saying we wouldn't be loading in the pool? | 22:34 |
| openstackgerrit | Merged openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/523762 | 22:34 |
| johnsom | No, this is just listing out possible fields in the object, | 22:34 |
| rm_work | I assumed if we had a pool_id we would load in the pool when we send it to the driver | 22:34 |
| rm_work | since the driver needs to know that | 22:34 |
| rm_work | (in order to create it) | 22:34 |
| rm_work | right? | 22:34 |
| *** tongl has joined #openstack-lbaas | 22:34 | |
| rm_work | even if the pool was on the LB originally | 22:34 |
| johnsom | My use case is the pool already exists | 22:34 |
| rm_work | right | 22:34 |
| rm_work | so the LB is created, then the pool is created | 22:34 |
| rm_work | now we do a listener create call | 22:34 |
| rm_work | do you not want to pass the actual pool to the driver? | 22:35 |
| rm_work | i'm assuming a lot of drivers "create pool" could be a noop | 22:35 |
| rm_work | unless it's linked to a listener | 22:35 |
| xgerman_ | how would the driver figure out ifit laready ahs the pool? | 22:35 |
| johnsom | Even though we have already passed them the pool details to create.... | 22:35 |
| rm_work | ^^ and that | 22:35 |
| rm_work | it has to link "our id" | 22:35 |
| rm_work | somehow | 22:35 |
| johnsom | By the ID we pass them at create | 22:35 |
| rm_work | I'm just assuming there are drivers that don't actually bother creating pools | 22:36 |
| rm_work | until they are somehow linked onto something | 22:36 |
| xgerman_ | yep, so having id and pool makes it less ambigious | 22:36 |
| rm_work | so i assumed we would always load in the pool | 22:36 |
| xgerman_ | aka we only give you details if you. need to craete the pool | 22:36 |
| rm_work | hmm | 22:36 |
| tongl | are we talking about default_pool and default_pool_id for listener? | 22:36 |
| xgerman_ | yep | 22:37 |
| rm_work | alright, i don't really care that much, just trying to think about issues down the road | 22:37 |
| rm_work | if you don't think it'll come up, then i guess it's fine as-is | 22:37 |
| johnsom | I mean, I don't care that much, it's just more data in the object. The driver can "figure it out" I guess. This just models our API closer | 22:37 |
| rm_work | it might be worth noting then that the "default_pool" will only be filled if it's a new pool to create, and if it's an existing pool, the default_pool_id field will be populated | 22:37 |
| rm_work | because if i were writing a driver from this spec, i would have assumed i could always just ignore default_pool_id and look at the object | 22:38 |
| tongl | Do we always assume either both of them has value or both of them are empty. Is there any case that default_pool_id is set, but default_pool is None or vice versa? | 22:38 |
| rm_work | *I* assumed it was both or none | 22:38 |
| rm_work | but apparently it is actually more like, one OR the other | 22:39 |
| tongl | When I am writing our vmware_nsx driver, I always assume both or none. | 22:39 |
| rm_work | ^^ johnsom so yeah this is my concern | 22:39 |
| johnsom | Yes, currently it will either be: pool_id, pool, or None for both. | 22:39 |
| rm_work | so never both filled | 22:39 |
| johnsom | Never both | 22:40 |
| rm_work | though ... by the time it gets here, the pool WILL have an ID in our DB | 22:40 |
| tongl | In which case it has pool_id and which case has just pool? | 22:40 |
| johnsom | tongl If the load balancer already has a pool created (the LB could have many pools), and the API requests specifies the ID in the listener create call, the default_pool_id will be specified, default_pool is empty. Default pool will be specified if this is a single call create where the listener call build a complete listener and all of the child objects, including a new pool definition. | 22:43 |
| tongl | johnsom: Make sense. Thanks! | 22:48 |
| *** yamamoto has joined #openstack-lbaas | 22:50 | |
| *** sshank has quit IRC | 22:51 | |
| rm_work | johnsom: so ... we create HMs on pools right? | 22:52 |
| johnsom | Right | 22:52 |
| rm_work | so a Pool create could only have a filled "healthmonitor" if it's a single-create | 22:52 |
| rm_work | thus why there's no id field for it? | 22:53 |
| johnsom | Correct | 22:54 |
| rm_work | k | 22:54 |
| *** yamamoto has quit IRC | 22:54 | |
| rm_work | the batch update members thing may need to change a little... maybe | 22:55 |
| rm_work | it might be helpful for us to actually provide a list of IDs for members they should delete | 22:55 |
| rm_work | dunno | 22:55 |
| rm_work | does the Driver Support Library (the thing for letting drivers update LB statuses) really need to be an interface+implementation? | 22:59 |
| rm_work | it's writing to our DB | 22:59 |
| rm_work | I know we make EVERYTHING a driver, but ... >_> | 22:59 |
| rm_work | actually i'm unclear on whether this is hitting an API in Octavia, or if it's going to the DB, but via code we write? | 22:59 |
| rm_work | you have "REST API" in Alternates | 23:00 |
| johnsom | Well, I wasn't the original author... grin | 23:00 |
| rm_work | ok but | 23:00 |
| johnsom | Personally I would still just give a REST interface. | 23:00 |
| rm_work | yeah ok | 23:00 |
| rm_work | was wondering | 23:00 |
| rm_work | I assumed that would be it | 23:00 |
| johnsom | So, my take on this is the "driver" will call these two methods to update stats and status. What the methods do is TBD | 23:01 |
| rm_work | k | 23:01 |
| rm_work | >_< | 23:01 |
| johnsom | I.e. outside this spec. This is a spec for what a driver does | 23:02 |
| rm_work | k | 23:02 |
| johnsom | I just think this limits the placement of code that updates stats/status. | 23:02 |
| rm_work | Basically I think I am ok to +2 this and then I will pay close attention when we actually get implementations | 23:02 |
| johnsom | It basically has to be on the API host. | 23:02 |
| rm_work | well anywho | 23:02 |
| johnsom | Or we create a driver-driver they have to install | 23:03 |
| johnsom | driver-driver-lib | 23:03 |
| johnsom | ? | 23:03 |
| johnsom | ha | 23:03 |
| rm_work | T_T | 23:03 |
| rm_work | anyway I'm +2 | 23:03 |
| rm_work | we should get started on the actual work | 23:04 |
| rm_work | time is short | 23:04 |
| johnsom | Yep | 23:04 |
| johnsom | Go for it | 23:04 |
| johnsom | grin | 23:04 |
| rm_work | no real point in bikeshedding on the spec for another week or three, lol | 23:04 |
| rm_work | umm yeah i'll ... uhh | 23:04 |
| rm_work | get right on that... | 23:04 |
| rm_work | <_< | 23:04 |
| * rm_work disappears | 23:04 | |
| rm_work | I mean yeah maybe next week I can start looking at some | 23:05 |
| rm_work | but I really am going to need some of these patches in my chain merged before I can focus on that | 23:05 |
| johnsom | I -1'd one of them, some I wanted to see gate output, one I +2'd. So, pretty typical odds.... | 23:05 |
| johnsom | Hmmm, this QoS is going to have the same problem with neutron outages... | 23:06 |
| johnsom | https://review.openstack.org/#/c/458308/57/octavia/common/validate.py | 23:06 |
| rm_work | hmm | 23:06 |
| rm_work | erg lol yes | 23:07 |
| rm_work | good catch | 23:07 |
| johnsom | Though here is should just give the user a error | 23:09 |
| johnsom | Since it's validation time | 23:09 |
| rm_work | i mean, on my patch | 23:09 |
| *** aojea has joined #openstack-lbaas | 23:13 | |
| johnsom | Ah, got it | 23:16 |
| *** aojea has quit IRC | 23:18 | |
| rm_work | kk | 23:19 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Amphora API Failover call https://review.openstack.org/525778 | 23:19 |
| rm_work | there you go | 23:19 |
| johnsom | rm_work Does this make sense to you? https://review.openstack.org/#/c/458308/57/octavia/controller/worker/tasks/model_tasks.py | 23:27 |
| *** sshank has joined #openstack-lbaas | 23:31 | |
| rm_work | err | 23:40 |
| rm_work | does .items() give you key-val pairs? | 23:40 |
| rm_work | I didn't think it did | 23:40 |
| rm_work | i thought that was the opposite of .keys() basically | 23:40 |
| rm_work | well a quick test will show me | 23:40 |
| rm_work | nm | 23:41 |
| rm_work | i am incorrect | 23:41 |
| johnsom | It does | 23:41 |
| johnsom | This is just making my head hurt. | 23:41 |
| johnsom | This must be he is updating the vip embedded in the lb where update wasn't touching the vip before | 23:43 |
| rm_work | i think it makes sense | 23:44 |
| rm_work | but need to test something | 23:44 |
| *** yamamoto has joined #openstack-lbaas | 23:51 | |
| *** yamamoto has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!