Thursday, 2017-03-02

*** ducttape_ has quit IRC00:07
openstackgerritMerged openstack/octavia master: Adds devstack plugin support for all amp base OS  https://review.openstack.org/43157600:29
*** ducttape_ has joined #openstack-lbaas00:29
*** gongysh has joined #openstack-lbaas00:45
rm_workxgerman: ok got my devstack to spin properly finally00:47
rm_workxgerman: not able to repro00:47
rm_workxgerman: but i'd love for you to try again, and if you see an issue, snag some logs from things00:48
rm_workxgerman: re the network_id patch00:48
*** gongysh has quit IRC00:49
rm_worknow, in default devstack the connectivity isn't there between the mgmt network and the main network00:51
rm_worksoooo00:51
rm_workyou can't easily test actual connectivity00:51
rm_workbut it'll "work"00:51
*** ducttape_ has quit IRC00:52
*** ducttape_ has joined #openstack-lbaas00:53
*** catintheroof has joined #openstack-lbaas01:04
*** armax has joined #openstack-lbaas01:06
*** Swami has quit IRC01:06
xgermank01:13
*** ducttape_ has quit IRC01:14
*** ducttape_ has joined #openstack-lbaas01:34
*** sanfern has quit IRC01:36
*** ducttape_ has quit IRC01:51
*** ducttape_ has joined #openstack-lbaas01:52
*** ducttape_ has quit IRC02:01
*** catintheroof has quit IRC02:01
*** ducttape_ has joined #openstack-lbaas02:02
rm_workjohnsom: left some comments on https://review.openstack.org/#/c/433392/1002:08
rm_workand apparently german is waiting for you on https://review.openstack.org/#/c/437200/02:09
rm_workalso if you get a chance to test https://review.openstack.org/#/c/429926/ we can either merge that and then get updates into the API patch, or wait to merge that until the API patch and then I can update it to include the v2 api changes02:09
rm_workeither way02:09
xgermanhad to do some accounting tonight… so will test your patch tomorrow first thing02:34
rm_workno worries02:41
rm_workthese aren't urgent, but i would like to try to get some stuff moving02:42
rm_workthe less outstanding patches the better IMO02:42
*** ducttape_ has quit IRC02:46
*** ducttape_ has joined #openstack-lbaas02:47
*** ducnc has quit IRC02:50
*** sanfern has joined #openstack-lbaas02:50
*** ducttape_ has quit IRC02:52
*** cody-somerville has quit IRC03:03
*** gongysh has joined #openstack-lbaas03:04
*** dave-mccowan has joined #openstack-lbaas03:06
*** links has joined #openstack-lbaas03:08
*** gongysh has quit IRC03:16
*** cody-somerville has joined #openstack-lbaas03:20
*** cody-somerville has quit IRC03:20
*** cody-somerville has joined #openstack-lbaas03:20
*** cody-somerville has quit IRC03:34
*** fnaval has joined #openstack-lbaas03:38
*** reedip has quit IRC03:41
*** cody-somerville has joined #openstack-lbaas03:49
*** cody-somerville has quit IRC03:49
*** cody-somerville has joined #openstack-lbaas03:49
*** rcernin has quit IRC03:50
*** dave-mccowan has quit IRC04:16
*** cody-somerville has quit IRC04:21
*** cody-somerville has joined #openstack-lbaas04:23
*** cody-somerville has quit IRC04:23
*** cody-somerville has joined #openstack-lbaas04:23
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements  https://review.openstack.org/43932705:01
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas-dashboard master: Updated from global requirements  https://review.openstack.org/44007505:01
*** ShaneDavidson has quit IRC05:02
openstackgerritOpenStack Proposal Bot proposed openstack/octavia master: Updated from global requirements  https://review.openstack.org/44007805:03
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements  https://review.openstack.org/43932705:16
openstackgerritOpenStack Proposal Bot proposed openstack/octavia master: Updated from global requirements  https://review.openstack.org/44007805:18
openstackgerritAnkur proposed openstack/octavia master: Introduce TESTING.rst for quick developer reference  https://review.openstack.org/40393805:23
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements  https://review.openstack.org/43932705:31
openstackgerritOpenStack Proposal Bot proposed openstack/octavia master: Updated from global requirements  https://review.openstack.org/44007805:33
*** armax has quit IRC06:14
*** fnaval has quit IRC06:15
*** ShaneDavidson has joined #openstack-lbaas06:46
*** kobis has joined #openstack-lbaas07:00
*** csomerville has joined #openstack-lbaas07:08
*** cody-somerville has quit IRC07:12
*** rcernin has joined #openstack-lbaas07:18
*** kobis has quit IRC07:18
*** Alex_Staf has joined #openstack-lbaas07:18
*** tesseract has joined #openstack-lbaas07:18
*** andrew_ has joined #openstack-lbaas07:21
*** ShaneDavidson has quit IRC07:21
*** andrew has joined #openstack-lbaas07:22
andrewTo associate FIP to L4's vip , Do I have to use L3 agent (or Network Node)?07:23
*** gcheresh_ has joined #openstack-lbaas07:24
andrewFor the provider network, is there's any way to do that?07:24
*** andrew_ has quit IRC07:24
*** andrew has quit IRC07:32
*** yamamoto has quit IRC07:38
*** gongysh has joined #openstack-lbaas07:41
*** Alex_Staf has quit IRC07:42
*** gcheresh_ has quit IRC07:45
*** gcheresh has joined #openstack-lbaas07:54
*** jsheeren has joined #openstack-lbaas08:10
*** pcaruana has joined #openstack-lbaas08:13
*** fnaval has joined #openstack-lbaas08:16
*** yamamoto has joined #openstack-lbaas08:17
*** yamamoto_ has joined #openstack-lbaas08:17
*** yamamoto_ has quit IRC08:20
*** krypto has joined #openstack-lbaas08:20
*** kobis has joined #openstack-lbaas08:20
*** fnaval has quit IRC08:21
*** yamamoto has quit IRC08:21
*** krypto has quit IRC08:25
korean101hi guys.08:42
korean101i have dhcp problem.08:42
korean101i already succeed via octavia LB08:43
korean101but sometimes my new instances get a dhcp IP08:44
korean101cloud-init-nonet waiting 120 seconds08:44
korean101and i tcpdump on network namespace08:44
korean101my new VM ARP request to amphora VM08:44
korean101but i have already dhcp instances08:45
korean101instances-->namespace08:45
*** ducnc has joined #openstack-lbaas08:48
*** Alex_Staf has joined #openstack-lbaas09:08
*** yamamoto has joined #openstack-lbaas09:17
*** yamamoto has quit IRC09:22
*** eezhova has joined #openstack-lbaas09:24
*** belharar has joined #openstack-lbaas09:27
*** jsheeren has quit IRC10:01
*** jsheeren has joined #openstack-lbaas10:05
*** yamamoto has joined #openstack-lbaas10:19
*** yamamoto has quit IRC10:22
*** gongysh has quit IRC10:27
*** links has quit IRC10:31
*** jsheeren has quit IRC10:39
*** jsheeren has joined #openstack-lbaas10:39
*** eezhova has quit IRC10:42
*** sanfern has quit IRC10:44
*** ducnc has quit IRC10:47
*** links has joined #openstack-lbaas10:47
*** yamamoto has joined #openstack-lbaas10:53
*** yamamoto has quit IRC10:53
*** sanfern has joined #openstack-lbaas10:54
*** eezhova has joined #openstack-lbaas10:54
*** yamamoto has joined #openstack-lbaas11:04
*** jsheeren has quit IRC11:12
*** jsheeren has joined #openstack-lbaas11:13
*** sanfern has quit IRC11:15
*** eezhova has quit IRC11:17
*** dileepr has quit IRC11:19
*** belharar has quit IRC11:37
*** links has quit IRC11:51
*** yamamoto has quit IRC11:58
*** links has joined #openstack-lbaas12:04
*** fnaval has joined #openstack-lbaas12:18
*** fnaval has quit IRC12:22
*** belharar has joined #openstack-lbaas12:38
*** belharar has quit IRC12:48
*** belharar has joined #openstack-lbaas12:56
*** catintheroof has joined #openstack-lbaas12:56
*** yamamoto has joined #openstack-lbaas12:59
*** sanfern has joined #openstack-lbaas13:02
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - Initial Cluster Manager  https://review.openstack.org/40523813:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology: Initial Distributor Noop Driver  https://review.openstack.org/31300613:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: Active-Active Topology - Distributor open_flow back-end  https://review.openstack.org/42785813:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology : create distributor network flow  https://review.openstack.org/40976313:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: Active-Active Topology - register/uregister amphorae tasks  https://review.openstack.org/40976513:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: Active-Active Topology - Cluster DB Tasks  https://review.openstack.org/40976413:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: Active-Active Topology - LB create cluster impl  https://review.openstack.org/42656013:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology OVS-based Distributor Driver  https://review.openstack.org/31762913:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology OVS-based Distributor Backend  https://review.openstack.org/32042213:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - Distributor related tasks  https://review.openstack.org/40695113:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - controller network tasks  https://review.openstack.org/32348113:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - Distributor image creation  https://review.openstack.org/40359413:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - network driver related changes  https://review.openstack.org/32249413:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - distributor certificate tasks  https://review.openstack.org/40695213:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - distributor creation flow  https://review.openstack.org/40695313:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - tmp commit not for release  https://review.openstack.org/42936913:08
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - create shared distributor  https://review.openstack.org/40695413:08
*** yamamoto has quit IRC13:09
*** belharar has quit IRC13:11
openstackgerritAbed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - tmp commit not for release  https://review.openstack.org/42936913:14
*** chlong_ has joined #openstack-lbaas13:40
*** andrew has joined #openstack-lbaas13:40
*** ducttape_ has joined #openstack-lbaas13:52
*** eezhova has joined #openstack-lbaas13:57
*** ducttape_ has quit IRC14:08
*** links has quit IRC14:12
*** ducttape_ has joined #openstack-lbaas14:57
*** andrew has quit IRC14:58
openstackgerritKobi Samoray proposed openstack/octavia master: Devstack plugin: API only mode  https://review.openstack.org/43824015:02
*** fnaval has joined #openstack-lbaas15:12
*** dave-mccowan has joined #openstack-lbaas15:26
*** gcheresh has quit IRC15:45
*** Alex_Staf has quit IRC15:45
*** jsheeren has quit IRC15:58
*** rcernin has quit IRC15:59
diltramjohnsom: infra is weird16:00
diltramor it's just me16:00
*** chlong_ has quit IRC16:01
diltrama lot of people was fighting for multi-node tests16:01
diltramwith more than two nodes16:01
*** chlong__ has joined #openstack-lbaas16:01
diltramand now on ML they told me that it's currently supported and why I'm even asking about is it gonna be supported in zuulv316:01
*** armax has joined #openstack-lbaas16:02
johnsomWe have a multinode test gate16:02
diltrambut two node16:03
johnsomI think the term has different meaning to different folks16:03
diltramI asked them directly if it's gonna be possible to build 3-4 nodes or more16:04
diltramand they told that it's already supported16:04
diltramand some projects are using it already16:04
*** ducttape_ has quit IRC16:08
*** ducttape_ has joined #openstack-lbaas16:09
openstackgerritKobi Samoray proposed openstack/octavia master: Recurse dictionary generation in model to_dict()  https://review.openstack.org/43823916:11
diltramjohnsom: what is going one with this patch? https://review.openstack.org/#/c/429825/16:16
johnsomdiltram we need to merge those two.  That patch just needs rebased and the parent needs fixed16:19
diltramok16:20
*** csomerville has quit IRC16:24
*** csomerville has joined #openstack-lbaas16:31
xgermano/16:32
*** kobis has quit IRC16:33
diltramhey16:34
*** ducttape_ has quit IRC16:39
*** eezhova has quit IRC16:39
*** ducttape_ has joined #openstack-lbaas16:39
johnsomWell, the debate is back16:42
*** pcaruana has quit IRC16:42
johnsompeople don't like "load-balancing" but prefer "load-balancer" for the service type.16:42
ankur-gupta-f1woot woot16:47
*** belharar has joined #openstack-lbaas16:48
openstackgerritSindhu Devale proposed openstack/neutron-lbaas master: Updating import for linux/interface opts  https://review.openstack.org/35247116:49
*** csomerville has quit IRC17:04
*** eezhova has joined #openstack-lbaas17:07
*** dave-mccowan has quit IRC17:13
openstackgerritSindhu Devale proposed openstack/octavia master: DB migration to add ID column to HM  https://review.openstack.org/43045117:17
*** ducttape_ has quit IRC17:45
*** tesseract has quit IRC17:52
*** belharar has quit IRC17:57
*** SumitNaiksatam has joined #openstack-lbaas18:03
*** kevo has joined #openstack-lbaas18:09
openstackgerritSindhu Devale proposed openstack/neutron-lbaas master: [Fix gate]Update test requirement  https://review.openstack.org/44074618:12
openstackgerritSindhu Devale proposed openstack/neutron-lbaas master: Updating import for linux/interface opts  https://review.openstack.org/35247118:14
*** mugsie has quit IRC18:26
*** SumitNaiksatam has quit IRC18:39
*** ducttape_ has joined #openstack-lbaas18:45
*** ducttape_ has quit IRC18:50
*** SumitNaiksatam has joined #openstack-lbaas19:11
openstackgerritAnkur proposed openstack/octavia master: Add v2 load balancer type and controllers  https://review.openstack.org/42354319:13
*** armax has quit IRC19:20
*** eezhova has quit IRC19:24
*** armax has joined #openstack-lbaas19:31
openstackgerritShashank Kumar Shankar proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Rules  https://review.openstack.org/40633619:31
*** kobis has joined #openstack-lbaas19:34
*** mugsie has joined #openstack-lbaas19:35
xgermanrm-work:19:40
openstackgerritAnkur proposed openstack/octavia master: Add v2 load balancer type and controllers  https://review.openstack.org/42354319:40
xgermanhttps://www.irccloud.com/pastebin/ZG6zb5vS/19:40
xgermanhttps://www.irccloud.com/pastebin/K3wdwg0g/19:41
xgermanknowing my luck I might just have some outdated glance image19:42
xgermanso manua;;y building a new one…19:43
*** ipsecguy has joined #openstack-lbaas19:45
*** ipsecguy_ has quit IRC19:47
*** ShaneDavidson has joined #openstack-lbaas19:50
xgermanok, that was it, old image19:57
*** armax has quit IRC19:58
rm_workah cool20:02
rm_workkk20:02
rm_workjohnsom: who is objecting to the service type?20:04
rm_workwhere]20:04
johnsomrm_work https://review.openstack.org/#/c/434999/20:05
rm_workI just hate the hyphen20:06
johnsomI just hate  that the community can't come to an agreement.20:08
rm_worklol20:14
rm_workI proposed yet another option20:14
rm_worksorry :P20:14
rm_workI don't actually like the sound of it better, but if we want to be consistent... <_<20:14
rm_workbecause if we don't call "computing" "computer", we shouldn't call "load-balancing" "load-balancer"20:15
rm_work"compute" / "load-balance"20:15
rm_workto me they technically look like verb stems20:16
rm_workAdd "to" in front of them: "to compute" "to network" "to load-balance"20:16
*** ducttape_ has joined #openstack-lbaas20:16
johnsomI just know it's already set based on the e-mail chain in three places, project config, our code, and docs20:20
johnsomWe need to pick something and move on20:20
rm_workwell, we do control all of those20:20
rm_workso20:20
rm_workit's not a huge deal20:20
johnsomIt's just rework, plus project config takes a while to get reviewed and merged20:21
rm_workyeah, but it isn't blocking anything so20:21
rm_worki don't see it as a huge deal20:21
*** ducttape_ has quit IRC20:21
openstackgerritMerged openstack/neutron-lbaas master: [Fix gate]Update test requirement  https://review.openstack.org/44026120:21
johnsomTechnically it is blocking the docs and the openstacksdk work20:25
johnsomMaybe OSA as well20:25
xgermanindeed I out the hyphen one in OSA20:28
rm_workdiltram: responded to your comment on https://review.openstack.org/#/c/431179/20:32
rm_workit is impossible to get what you want :(20:32
diltrambut what git is checking to resolv that it's a new file vs old one?20:36
diltramthere is requirement that one patch to move file then you can change it?20:37
diltramrm_work: ^^20:37
diltramor just cp overrides dates on file and this is why it's showing that it's the new one?20:37
diltramyeah, it monitors content not any timestamps20:41
rm_workif you figure out a way20:41
rm_workfeel free to tell me and i'll do it20:41
diltramrm_work: http://stackoverflow.com/questions/433111/how-to-make-git-mark-a-deleted-and-a-new-file-as-a-file-move/433114#43311420:42
diltramyeah20:42
diltramyou should make this in two separete patches20:43
rm_workrofl20:43
rm_workI vote: no20:43
rm_workthat's ridiculous, why would I split this up20:43
rm_workdiltram: if i don't do that, are you going to keep a -1 on it because of a git history quirk? <_<20:45
rm_workOK, read your comment20:47
diltram:P20:48
diltramto keep history you should push two patches20:48
diltrambut it's just constants :P20:48
rm_workyes >_<20:48
rm_workall the unit test rewrites i had to do on that patch to fix stuff that was already not testing correctly made me very sad >_<20:50
rm_workor, wait... no, that was the one before it i think20:50
rm_workoh, nm yeah it was this one20:51
openstackgerritAnkur proposed openstack/octavia master: Add v2 load balancer type and controllers  https://review.openstack.org/42354320:56
johnsomYeah, not sure history on that consts file matters enough.  If it was code that people had made a bunch of changes to I would block it, but this file...20:56
johnsomGood catch though....20:56
diltramjohnsom: same thoughts20:57
*** eezhova has joined #openstack-lbaas20:57
diltramjohnsom: https://review.openstack.org/#/c/437125/ <- looking for review21:02
diltramalso21:02
diltramhttps://review.openstack.org/#/c/436997/ <- this one also21:03
xgermanI doubt if Dustin will ever contribute again: https://review.openstack.org/#/c/391204/ - so should we keep this around or abandon?21:04
xgermanand if we keep it around who would adopt ti?21:04
dlundquistxgerman: I will not be resuming work on that in the foreseeable future.21:05
xgermanyeah. my thought s well21:06
xgermanbut good to see you ;-)21:06
xgermanjohnsom?21:06
openstackgerritAnkur proposed openstack/octavia master: Introduce TESTING.rst for quick developer reference  https://review.openstack.org/40393821:07
johnsomHi Dustin.  I don't want to lose that patch, but agree we should wrap it in a flag we can use for the gates21:16
johnsomFrankly, using v6 for the mgmt net is the right answer21:17
johnsomdiltram is this a patch you could finish up?21:18
diltramI can try to take a look into it21:19
johnsomThanks!21:19
rm_workdiltram: replied on https://review.openstack.org/#/c/429926/1521:20
rm_workdiltram: can you help me out more on the readability thing?21:20
johnsomI had just started reviewing that again21:20
diltramrm_work: meeting21:21
rm_workk np21:21
diltramthx ;)21:21
rm_workresponded on the cascade delete one too21:22
rm_workwhenever you're out21:22
rm_workyou seem to be in a cryptic mood today ^_^21:22
* xgerman doesn’t like to be contradicted21:30
johnsomUh-oh...  Grin21:30
johnsomThe reviews are heating up eh?21:30
johnsomdiltram Yeah, what does this comment mean???? https://review.openstack.org/#/c/437200/21:31
xgermanshould we +A: https://review.openstack.org/#/c/437200/21:36
johnsomI would like to give him a chance to comment21:36
xgermank21:36
xgermanwe can always go Neutron and have rm21:37
xgerman_work +A later :-)21:37
johnsomOuch...21:37
rm_worklol21:40
diltramrm_work: can we divide this into smaller methods? 3 inner if's are horrible to understand and read21:41
diltramalso question was about _LI not _21:41
rm_workoh21:42
rm_work_LI was pre-existing...21:42
rm_worknot sure? somewhere? wouldn't it complain in pep8 if it was unused21:42
openstackgerritMerged openstack/octavia master: Updated from global requirements  https://review.openstack.org/44007821:43
diltramok,21:43
diltramjohnsom: how does it work with this _LI and other? Only _LE was not suppose to be used?21:44
diltramwe had some patches to remove it21:44
diltramrm_work: and what is going one with this noqa?21:45
johnsomdiltram that was switching around exception messages from error messages.  exceptions went to _ and error went to _LE21:45
rm_workdiltram: which noqa21:46
diltramjohnsom: ok, thx21:46
diltramhttps://review.openstack.org/#/c/429926/15/octavia/tests/functional/api/v1/base.py21:46
rm_workOH21:46
johnsomhttps://docs.openstack.org/developer/oslo.i18n/usage.html21:46
rm_workbecause it isn't imported directly21:47
rm_workerr21:47
rm_workisn't used directly21:47
rm_workbut unless we import it, the conf stuff isn't loaded21:47
rm_workso running tests fails21:47
rm_workso if you want to run like21:47
*** ducttape_ has joined #openstack-lbaas21:47
rm_worka specific unit test21:47
rm_workyou can't, unless the conf stuff is loaded21:47
rm_workif you run ALL the tests, something magically happens to load the config stuff21:47
rm_workso it works21:47
rm_workbut doing this allows us to run individual suites21:48
rm_workdiltram: make sense?21:48
diltrambut you should use fixture21:48
diltramto load conf21:48
rm_worki think it's the fixtures that FAIL because the conf isn't even set21:48
rm_workIIRC21:48
rm_workbut i'd have to look again21:48
rm_worklike, the groups don't even exist21:49
diltramok21:49
rm_workfixtures are for overriding stuff, I thought21:49
diltramthere is a bug in fixture21:49
diltramalso for using in tests21:49
rm_workwell, i need to check again to make sure21:49
diltramif you're getting error about init smth21:49
diltramI know what is about21:49
rm_worklet me remove that and try running some tests21:50
diltramsure21:50
johnsomFYI, this is actually a better page explaining the translation tags: https://docs.openstack.org/developer/oslo.i18n/guidelines.html21:51
*** ducttape_ has quit IRC21:52
rm_workdiltram: hilariously, it's already merged21:54
rm_workdiltram: that's just a duplicate, if i rebased it wouldn't be there21:54
rm_work(as a change)21:54
openstackgerritMerged openstack/octavia master: Use cryptsetup/LUKS for encrypted ramfs  https://review.openstack.org/40381721:55
rm_workand lol, already there at an even higher level too21:55
rm_workso that one actually isn't needed21:56
rm_workdiltram: https://gist.github.com/rm-you/707417ac9b7405ec68bce55d553089b421:56
diltramwhat is merged?21:57
rm_workare we using things improperly?21:57
rm_workthat line:21:57
diltramthere is problem with oslo_config fixture21:57
diltramit's not calling init21:57
rm_worki thnik21:58
rm_workone sec21:58
rm_workhttps://github.com/openstack/octavia/blob/master/octavia/tests/functional/db/base.py#L2021:58
diltramI don't remember where I was doing this22:01
diltramhttps://bugs.launchpad.net/oslo.config/+bug/164586822:02
openstackLaunchpad bug 1645868 in oslo.config "Fixture is not executing __call__" [Low,Triaged]22:02
rm_workok well.22:03
rm_workdo you want me to remove it? it doesn't even matter there because the one i linked is higher level22:03
diltramyes because it removes usability of fixture22:04
rm_worki think fixture still overrides22:04
diltramI need to find where we're doing this22:04
diltramnot really22:04
rm_worki mean, it was the fixture stuff causing the error there22:05
rm_workbecause the group doesn't exist22:05
rm_workand all of the tests pass?22:05
diltramthere is a weird stuff going one because of this22:05
rm_workso if it is breaking fixture, we have a bigger problem22:05
rm_workwhich is that the tests pass regardless of the config values22:05
diltramhahaha22:05
diltramno it's not breaking fixture22:05
diltram:P22:05
diltramit's just not initialized properly22:05
rm_worki think the simplest explanation (and how it seems to me) is that fixture still works fine22:05
*** kevo has quit IRC22:06
diltramand problem is that in tests if you gonna start overriding params it's not gonna work22:06
openstackgerritAdam Harwell proposed openstack/octavia master: Add network_id to VIP to match neutron-lbaas  https://review.openstack.org/42992622:08
*** mhayden has left #openstack-lbaas22:08
johnsomI am pretty close to done re-reviewing ^^^22:09
*** kobis has quit IRC22:09
rm_workjohnsom: it was literally just a noop change22:09
rm_workdiltram: i think it does work22:09
johnsomYeah, no problem, just commenting22:09
rm_workdiltram: because we already do use fixture (or else we wouldn't even have run into this issue), and the fixtures seem to work22:09
rm_workor else the tests that use them would fail22:10
rm_workdoes that logic seem sound?22:10
rm_workor did i miss something22:10
*** kobis has joined #openstack-lbaas22:11
johnsomYeah, if that line broke fixtures overall, the stuff would hit the fan in our tests.  We use them a bunch to override the conf22:12
diltramit's base api so even what in nova they're doing22:12
diltramand what I've done in other place22:12
diltramplace this import22:13
diltrambut to remove this cripy noqa22:13
diltramdo not import cfg object but use this one from this import22:13
diltramso in line 6022:14
diltramuse config.cfg.CONF instead of cfg.CONF22:14
diltrambecause of this you will have all config options properly loaded22:14
diltramand there will be no requirement for noqa22:14
rm_workok22:18
rm_workok22:20
rm_workdone22:20
rm_workand also fixing your thing about the constants22:20
rm_workby doing it in the patch before :P22:20
rm_worki hope you are happy22:20
rm_worksince it is a two part patch anyway22:20
diltramfor me awesome :P22:20
diltram:)22:20
rm_workok, testing and then i'll push up part`122:21
diltramthx :)22:23
johnsomrm_work That network_id looks ok.  Just two exception paths that don't have coverage (all the others do however)22:35
johnsomCommented22:35
*** catintheroof has quit IRC22:40
rm_workok22:45
rm_workworking on another patchset for diltram right now22:46
rm_workalmost done22:46
rm_workwill resolve his issues (even the git history thing)22:46
openstackgerritAdam Harwell proposed openstack/octavia master: Add network_id to VIP to match neutron-lbaas  https://review.openstack.org/42992622:46
openstackgerritAdam Harwell proposed openstack/octavia master: Allow to create vip in lb-mgmt-net  https://review.openstack.org/43117922:46
rm_workok, will deal with your comments now johnsom22:47
rm_workdiltram: please take a look and see if you like that better22:47
openstackgerritSindhu Devale proposed openstack/octavia master: DB migration to add ID column to HM  https://review.openstack.org/43045122:53
openstackgerritAdam Harwell proposed openstack/octavia master: Add network_id to VIP to match neutron-lbaas  https://review.openstack.org/42992622:58
rm_workjohnsom: done22:58
rm_workjohnsom / diltram: should be good to go now22:59
rm_workthe next one as well22:59
rm_worknot going to bother rebasing the next one since it's only two additional unit tests that were added in the patch below it22:59
rm_workWTB: merging those ^_^22:59
diltramrm_work: looks better :)23:00
openstackgerritSindhu Devale proposed openstack/octavia master: Introduce Octavia v2 API for Health Monitor  https://review.openstack.org/40625623:02
*** ducttape_ has joined #openstack-lbaas23:04
rm_workdiltram: i am really not sure what to do on https://review.openstack.org/#/c/437200/23:11
*** ShaneDavidson_ has joined #openstack-lbaas23:11
rm_workthe test is there23:11
rm_workit's just that ALL of those tests are shitty23:11
rm_workwhich... is not my fault >_>23:11
*** eezhova has quit IRC23:12
*** ShaneDavidson has quit IRC23:15
*** yuanying_ has joined #openstack-lbaas23:18
*** oomichi has quit IRC23:18
*** yuanying has quit IRC23:20
*** ShaneDavidson_ has quit IRC23:21
*** oomichi has joined #openstack-lbaas23:21
*** ShaneDavidson has joined #openstack-lbaas23:22
johnsomharlowja You were brave enough to use our name on the mailing list.....23:24
harlowjaforever brave23:24
harlowjalol23:24
johnsomHelp me understand what part of Octavia you are talking about?  We don't really use distributed locking today23:25
harlowjaya, not distributed locking23:25
johnsomI.e. I'm confused23:25
harlowjaliveness detection of amphora vms for example23:25
harlowjaand service discovery of the surronding topology23:26
johnsomAh, heartbeat23:26
harlowjain part, yes23:26
harlowjau could classify heartbeat and detection of the other services as the same23:26
johnsomservice discovery like how the amp finds a controller?23:26
harlowjasure, that'd work23:26
harlowjaor where to send UDP amphora packets23:26
johnsomHmm23:26
harlowjaor where nova compute registers itself for the schduler23:27
harlowjaya da :)23:27
johnsomYeah, people have argued we should use RR DNS.  I hate relying on more services if they really aren't needed.  That is my bias a bit.23:27
harlowjaya, but typically its a built in thing :-P23:27
harlowjaand then everyone makes there own sorta same thing23:28
johnsomHow so?  We don't use DNS today, the amps don't need to resolve anything23:28
harlowjasorry, not DNS23:28
harlowjaa thing that provides service discovery primitives23:28
harlowja(need not be DNS)23:28
harlowjahttps://technologyconversations.com/2015/09/08/service-discovery-zookeeper-vs-etcd-vs-consul/ (has an overview of a few of them)23:29
johnsomHmm, today, we just drop a config into the amp that has it's endpoints at boot.  The heartbeat does triple duty by sending up stats and status23:29
harlowjaright, static service discovery23:29
harlowja(via config file shoved in)23:29
johnsomYeah, we discussed etcd and consul EARLY in the design phase23:29
johnsomstatic == KISS23:30
diltramrm_work: there is no test which can be extended? I know those flows are not tested at all using unit tests but maybe extending some functional/api?23:30
harlowjajohnsom  let's assume that the community had said, KISS by using one of etcd|consul|zookeeper23:30
harlowjathen everyone could share the same tool23:30
diltramharlowja: how does it work with multi tenant?23:30
johnsomI think we are talking control plane here23:31
diltramif we would have service which is per tenant?23:31
harlowjaya, control plane (to start)23:31
diltramok23:31
harlowjai mean, take what k8s does with this stuff (via etcd)23:31
johnsom"to start", ha, taking over the world23:31
harlowjaya, the shitty part, is another project, has this primitive, so us not, imho is a handicap23:32
diltramso to be more containers ways we should allow for something like etcd to provide endpoints for health data23:32
harlowjadon't think of it as containers or not23:32
harlowjaanyways, bb :)23:32
rm_workyeah diltram, that is what he has been telling me :P23:32
johnsomHe is trying to get us to drink the tooz koolaid23:32
harlowjanooo23:32
johnsomGrin23:33
harlowjai'm just trying to blow your mind23:33
rm_workbecause if we spin up more health monitors later, there's no way to add those to the existing amps23:33
harlowjabiab23:33
rm_worksince we don't have a way to update agent config AFAIK23:33
diltramI know23:33
johnsomrm_work Yeah, that was blocked by the workz restart bug23:33
rm_worki mean, that is the basis for where this conversation started internally...23:33
rm_workright, which is solved23:33
rm_worki mentioned that23:33
rm_workwe COULD add an agent config update call23:33
rm_workbut i think he's hoping for something even better23:34
johnsomYeah, that is why I started the conversation.23:34
rm_workinternally people were pushing Consul at me23:34
johnsomI think my biggest issue with adding something like etcd (pick whatever project is shiny today) is depending on more outside code.23:35
johnsomI want to make sure that some dumb service crashing doesn't take out ALL of the amps.23:35
rm_workyeah, that's fair23:36
johnsomI.e. distributed and autonomous has it's benefits23:36
rm_worki honestly dont know exactly where i am on this argument23:36
johnsomTo give xgerman credit, he proposed consul "back in the day"23:36
rm_worki don't want to just argue against change because it's change though23:36
rm_worki'd like to figure out if there's valid reasons to avoid something like that23:37
johnsomThough I dind't like what I saw in Consul at the time23:37
rm_workwell, i have to brb23:37
rm_workso i guess we can ALL pick this up in a bit if we want to23:37
johnsomHahaha you guys.23:37
rm_workT_T23:37
diltramharlowja: just remember23:38
johnsomYeah, I am open to the investigation/discussion, definitely.  I'm just voicing my bias up front so you all can poke holes in it.  Grin23:38
diltramcinder is making the biggest step in this23:38
diltrambecause they're implementing tooz to provide DLM23:38
diltramso it suppose to change a lot in openstack world23:39
diltramwhen core project is starting to require those kind of dependencies23:39
diltramplus we need to remember that there is tooz23:40
diltrambut I just heard that problem is that there is small amount of same capabilities in all of this projects like etcd, zookeeper, rest23:41
diltramso I heard that tooz is ok for master election, DLM23:41
diltrambut nothing more specialized23:41
diltrambut this is to be verified23:41
johnsomWell, when they return you will have one of the tooz gurus to discuss with23:42
diltramI would like to, but not today23:43
diltramit's 6PM23:43
diltramI'm leaving now23:43
johnsomOk, have a good evening23:43
diltramthx, cu people tomorrow :)23:43
rm_workah, I'm out tomorrow23:43
rm_workand probably Monday23:43
rm_workso, see you Tuesday :P23:43
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements  https://review.openstack.org/43932723:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!