| carrbs | johnsom: I pushed a patch for one of the depreciation warning tickets you showed me. Is there a way to link the gerrit patch to the ticket or should I just put the gerrit branch in the ticket as a comment? | 00:33 |
|---|---|---|
| *** yuanying has joined #openstack-lbaas | 01:24 | |
| *** yuanying has quit IRC | 01:24 | |
| *** armax has quit IRC | 02:13 | |
| *** amotoki has joined #openstack-lbaas | 02:48 | |
| *** amotoki has quit IRC | 02:50 | |
| *** yuanying has joined #openstack-lbaas | 02:52 | |
| *** yuanying has quit IRC | 02:55 | |
| *** yuanying has joined #openstack-lbaas | 02:57 | |
| *** yuanying has quit IRC | 03:00 | |
| *** yuanying has joined #openstack-lbaas | 03:00 | |
| *** amotoki has joined #openstack-lbaas | 03:07 | |
| *** yuanying has quit IRC | 03:18 | |
| *** amotoki has quit IRC | 03:18 | |
| *** yuanying has joined #openstack-lbaas | 03:20 | |
| *** cody-somerville has joined #openstack-lbaas | 03:39 | |
| *** bana_k has joined #openstack-lbaas | 03:41 | |
| *** csomerville has joined #openstack-lbaas | 03:41 | |
| *** cody-somerville has quit IRC | 03:45 | |
| *** csomerville has quit IRC | 03:49 | |
| *** amotoki has joined #openstack-lbaas | 03:54 | |
| *** yuanying has quit IRC | 04:00 | |
| *** yuanying has joined #openstack-lbaas | 04:02 | |
| reedip | rm_work : ping | 04:06 |
| *** Alex_Stef has joined #openstack-lbaas | 04:19 | |
| *** links has joined #openstack-lbaas | 04:39 | |
| *** bana_k has quit IRC | 04:39 | |
| *** Appa has joined #openstack-lbaas | 04:42 | |
| *** bana_k has joined #openstack-lbaas | 04:58 | |
| *** anilvenkata has joined #openstack-lbaas | 05:00 | |
| *** diogogmt has quit IRC | 05:19 | |
| *** kobis has quit IRC | 05:26 | |
| *** diogogmt has joined #openstack-lbaas | 05:41 | |
| *** reedip has quit IRC | 05:50 | |
| *** reedip has joined #openstack-lbaas | 06:03 | |
| *** saju_m has joined #openstack-lbaas | 06:17 | |
| *** kobis has joined #openstack-lbaas | 06:22 | |
| *** gcheresh has joined #openstack-lbaas | 06:23 | |
| *** ihrachys has joined #openstack-lbaas | 06:29 | |
| *** pcaruana has joined #openstack-lbaas | 06:48 | |
| *** tesseract- has joined #openstack-lbaas | 07:00 | |
| *** ihrachys has quit IRC | 07:12 | |
| *** ihrachys has joined #openstack-lbaas | 07:12 | |
| rm_work | reedip: sup? | 07:17 |
| *** ihrachys has quit IRC | 07:23 | |
| reedip | rm_work : Hi , hope I am not disturbing you .. wanted some comments for https://review.openstack.org/#/c/273896/ | 07:26 |
| reedip | The value of 50000 ms was the default value, however, I am not sure what would be the maximum value. Any suggestions for the same?> | 07:26 |
| rm_work | reedip: about default / max, I am not sure | 07:29 |
| rm_work | the thing that is very important though, is the DB | 07:29 |
| rm_work | https://review.openstack.org/#/c/273896/22/neutron_lbaas/db/migration/alembic_migrations/versions/newton/expand/1e49252881f_AddListenerTimeout.py | 07:29 |
| rm_work | Setting defaults is NOT done in the DB this way | 07:29 |
| rm_work | since this script is only run during the migration (once) and so it would set a value when first installed | 07:30 |
| rm_work | then when the operator changes the value, it would never be updated | 07:30 |
| rm_work | also, it should never have a null value by the time it saves to the DB | 07:30 |
| rm_work | as for default VALUE, it could be 50000, that is fine -- but it should not be specified in constants.py like that (trying to keep consistent with how *every* other default is defined) | 07:33 |
| rm_work | carrbs: you put the line "Closes-Bug: #123456" in the commit message, similar to the Change-Id line | 07:40 |
| openstack | bug 123456 in xine-lib (Ubuntu) "podcast crashes amarok" [Undecided,Fix released] https://launchpad.net/bugs/123456 | 07:40 |
| rm_work | lol of course that's a real bug >_> | 07:40 |
| *** eezhova has joined #openstack-lbaas | 07:42 | |
| rm_work | carrbs: and, you should not be seeing issues with "tox -e py34" installing deps... if you are, there may be something wonky in your environment | 07:42 |
| rm_work | carrbs: I find that using the system installed version of python often has some weird issues -- I use pyenv to install a nice clean version of python/pip to use for tox testing | 07:43 |
| *** bana_k has quit IRC | 07:49 | |
| reedip | rm_work : Okay, thanks for the information. I will look into your comments and get back to you ASAP | 08:04 |
| *** eezhova has quit IRC | 08:10 | |
| *** ihrachys has joined #openstack-lbaas | 08:23 | |
| *** gongysh has quit IRC | 08:25 | |
| *** gongysh has joined #openstack-lbaas | 08:26 | |
| *** bcafarel has joined #openstack-lbaas | 08:38 | |
| *** eezhova has joined #openstack-lbaas | 09:08 | |
| openstackgerrit | Nir Magnezi proposed openstack/neutron-lbaas: Implements ProcessMonitor in the haproxy driver https://review.openstack.org/344658 | 09:12 |
| *** nmagnezi has joined #openstack-lbaas | 09:13 | |
| *** gongysh has quit IRC | 09:19 | |
| *** gongysh has joined #openstack-lbaas | 09:21 | |
| *** gongysh has quit IRC | 09:26 | |
| *** reedip has quit IRC | 09:51 | |
| *** saju_m has quit IRC | 09:57 | |
| *** reedip has joined #openstack-lbaas | 10:04 | |
| *** HenryG_ is now known as HenryG | 10:46 | |
| *** amotoki_ has joined #openstack-lbaas | 11:29 | |
| *** amotoki has quit IRC | 11:31 | |
| *** Appa has quit IRC | 11:32 | |
| *** Appa has joined #openstack-lbaas | 11:46 | |
| openstackgerrit | Nir Magnezi proposed openstack/neutron-lbaas: Implements ProcessMonitor in the haproxy driver https://review.openstack.org/344658 | 11:57 |
| *** Appa has quit IRC | 12:01 | |
| *** reedip has quit IRC | 12:02 | |
| nmagnezi | sbalukoff, ^^ tests added (and should now work okay) | 12:04 |
| *** reedip has joined #openstack-lbaas | 12:16 | |
| *** woodster_ has joined #openstack-lbaas | 12:26 | |
| *** anilvenkata has quit IRC | 12:39 | |
| *** pcaruana has quit IRC | 12:50 | |
| *** nmagnezi_ has joined #openstack-lbaas | 13:12 | |
| *** nmagnezi has quit IRC | 13:14 | |
| *** matt-borland has joined #openstack-lbaas | 13:17 | |
| *** brad_behle has joined #openstack-lbaas | 13:27 | |
| *** Alex_Stef has quit IRC | 13:51 | |
| *** gongysh has joined #openstack-lbaas | 13:52 | |
| *** Appa has joined #openstack-lbaas | 13:54 | |
| *** brad_behle has quit IRC | 14:00 | |
| *** amotoki_ has quit IRC | 14:09 | |
| *** Appa has quit IRC | 14:10 | |
| *** ducttape_ has joined #openstack-lbaas | 14:12 | |
| *** ducttape_ has quit IRC | 14:15 | |
| *** nmagnezi_ has quit IRC | 14:15 | |
| *** amotoki has joined #openstack-lbaas | 14:17 | |
| *** ducttape_ has joined #openstack-lbaas | 14:18 | |
| *** gongysh has quit IRC | 14:20 | |
| *** diogogmt has quit IRC | 14:20 | |
| *** links has quit IRC | 14:21 | |
| *** Appa has joined #openstack-lbaas | 14:23 | |
| *** BjoernT has joined #openstack-lbaas | 14:25 | |
| *** zigo has quit IRC | 14:25 | |
| *** vrathi has quit IRC | 14:31 | |
| *** zigo has joined #openstack-lbaas | 14:32 | |
| *** zigo is now known as Guest39147 | 14:33 | |
| *** reedip is now known as reedip_outofoffi | 14:34 | |
| *** reedip_outofoffi is now known as reedip | 14:34 | |
| *** Appa has quit IRC | 14:34 | |
| *** pglass has joined #openstack-lbaas | 14:36 | |
| *** amotoki has quit IRC | 14:38 | |
| *** Guest39147 has quit IRC | 14:39 | |
| *** zigo_ has joined #openstack-lbaas | 14:42 | |
| *** gcheresh has quit IRC | 14:42 | |
| *** zigo_ has quit IRC | 14:47 | |
| *** zigo_ has joined #openstack-lbaas | 14:48 | |
| *** ddaskal has joined #openstack-lbaas | 14:52 | |
| diltram_ | morning | 14:58 |
| *** diltram_ is now known as diltram | 14:58 | |
| *** _ducttape_ has joined #openstack-lbaas | 14:59 | |
| *** eezhova has quit IRC | 15:00 | |
| *** ducttape_ has quit IRC | 15:02 | |
| *** amotoki has joined #openstack-lbaas | 15:11 | |
| *** diogogmt has joined #openstack-lbaas | 15:11 | |
| openstackgerrit | Lubosz Kosnik (diltram) proposed openstack/octavia: Backend Keystone authentication https://review.openstack.org/364655 | 15:16 |
| *** matt-borland has quit IRC | 15:17 | |
| *** zigo_ is now known as zigo | 15:20 | |
| pglass | why does octavia have so many devstack ci checks? | 15:27 |
| pglass | like there is one for health monitor, listener, loadbalancer, member, ... | 15:27 |
| pglass | is octavia actually being configured differently for each of those jobs? | 15:28 |
| *** armax has joined #openstack-lbaas | 15:29 | |
| *** sbelous has left #openstack-lbaas | 15:30 | |
| diltram | no, they just verify different things | 15:31 |
| diltram | pglass: it's done to speed up testing | 15:31 |
| pglass | okay. i mean, that's a heavy-handed way to parallelize your tests. | 15:32 |
| pglass | it also looks like each individual devstack job only runs with a single process | 15:33 |
| pglass | only runs tests with a single process | 15:33 |
| pglass | can those tests be run with multiple threads/processes, or are they not thread-safe? | 15:33 |
| diltram | how did you checkeck that they are not multithreaded? | 15:35 |
| pglass | http://logs.openstack.org/28/346728/12/check/gate-neutron-lbaasv2-dsvm-pool/7fb6702/console.html#_2016-09-05_08_25_30_761076 | 15:35 |
| pglass | the {0} is the process or thread number | 15:35 |
| pglass | compare that to http://logs.openstack.org/20/318020/89/check/gate-designate-dsvm-powerdns/4690f71/console.html#_2016-09-06_10_28_16_981612 | 15:36 |
| diltram | check the VM configuraton | 15:36 |
| diltram | probably there is only 1 core | 15:36 |
| pglass | doesn't matter | 15:36 |
| pglass | you can still benefit from multiple threads/processes if they are mostly idling (which is usually the case) | 15:36 |
| diltram | ehhhh :/ nvm | 15:37 |
| *** pcaruana has joined #openstack-lbaas | 15:42 | |
| *** kobis has quit IRC | 15:42 | |
| pglass | it's fine. it just looked like an area where we could be a little less wasteful with ci resources. | 15:42 |
| pglass | i'll take a look sometime to see if those tests are suitable for running in parallel. tempest should be running in a mode where each test case (or test class) creates its own user. | 15:43 |
| diltram | feel free | 15:44 |
| diltram | but first of all check how octavia is implemented and after that try to make it use multiple users | 15:44 |
| pglass | yeah, I'm not sure what sorts of cross-tenant resources or operations there are right now. | 15:46 |
| diltram | I know | 15:46 |
| *** bana_k has joined #openstack-lbaas | 15:52 | |
| diltram | johnsom: https://review.openstack.org/#/c/364655/ - test results from OSIC cluster :D | 15:52 |
| *** _ducttape_ has quit IRC | 15:58 | |
| *** ducttape_ has joined #openstack-lbaas | 15:59 | |
| rm_work | pglass: it's because each test requires spinning up one Amphora VM, and it takes a LONG time to do that | 16:00 |
| rm_work | pglass: so if we don't split them up, it'd take foreeeeever | 16:01 |
| rm_work | it takes about 8-10m to spin one VM in devstack because no nested virt | 16:01 |
| rm_work | can't parallelize it | 16:01 |
| rm_work | we can only run ~4-6 real tests per devstack because of the time limits | 16:02 |
| pglass | you can't spin up two vms simultaneously in devstack as configured? | 16:02 |
| rm_work | nope | 16:03 |
| rm_work | i mean, you might be able to, but i think it'd take like 20 minutes for each if you did them simultaneously | 16:04 |
| rm_work | which would cause all kinds of timeouts | 16:04 |
| pglass | i mean, then how does nova run any of its tests in a reasonable amount of time. | 16:05 |
| rm_work | to my knowledge the only groups that actually boot VMs are us, magnum and ironic | 16:06 |
| rm_work | and they have more optimized images | 16:06 |
| rm_work | for instance, cirros will boot in ~10s | 16:06 |
| rm_work | our amphora image takes 10 minutes on the same box | 16:06 |
| pglass | okay, that makes some sense. | 16:07 |
| pglass | the image differences. | 16:07 |
| rm_work | personally i think something must be broken in our image because it SHOULDN'T take so long | 16:07 |
| rm_work | but i think base ubuntu takes similar | 16:07 |
| rm_work | so it's something with ubuntu maybe? | 16:07 |
| rm_work | I wanted to switch us onto a more minimal image but didn't have time to finish that exercise | 16:08 |
| carrbs | rm_work: thanks for the pyenv tip, I will try that out. Since I've already pushed that patch up, should I put a comment with reference to the ticket? | 16:08 |
| carrbs | In the future I will def put the ticket number in the commit msg | 16:08 |
| rm_work | carrbs: no, you'll need to amend the commit message and review again | 16:08 |
| carrbs | ok, thanks! | 16:08 |
| rm_work | or I think you can edit the commit message directly from the gerrit UI | 16:09 |
| rm_work | if it's just the commit message change | 16:09 |
| carrbs | i'll look | 16:09 |
| diltram | carrbs: you can change commit msg from gerrit | 16:09 |
| diltram | rm_work: we have finally gates with kvm | 16:09 |
| rm_work | that's awesome! though, does it help us a lot? :P | 16:10 |
| diltram | rm_work: https://review.openstack.org/#/c/364655/ <- results from OSIC cluster :D | 16:10 |
| rm_work | oh nice, so fast | 16:10 |
| diltram | carrbs: I'm just reviewing stuff so give me url to your commit, I will take a look into it | 16:11 |
| diltram | yeah, finally :P | 16:11 |
| diltram | I need to contact canonical what is going one with our patch to lxd | 16:11 |
| carrbs | diltram: https://review.openstack.org/#/c/365442/ | 16:11 |
| diltram | nova-lxd* | 16:11 |
| rm_work | diltram: hmm though scenario didn't get an LB up in 600s, was that because of your change? | 16:11 |
| diltram | yeah, unfortunately :P | 16:12 |
| diltram | I'm trying to make that change as small as possible | 16:12 |
| diltram | and again I hit the wall | 16:12 |
| diltram | :/ | 16:12 |
| diltram | I need to add to this patch also code for that bug | 16:13 |
| diltram | https://bugs.launchpad.net/octavia/+bug/1620668 | 16:13 |
| openstack | Launchpad bug 1620668 in octavia "Octavia is using Neutron user." [Undecided,New] | 16:13 |
| diltram | carrbs: aaa, already reviewed :P | 16:13 |
| carrbs | yea I saw that :) | 16:13 |
| carrbs | thanks! | 16:13 |
| diltram | np | 16:14 |
| carrbs | diltram: where's the magic "edit commit msg" in gerrit? | 16:14 |
| diltram | you need to open commit msg review window | 16:14 |
| diltram | and next to patch set versions there is notepad icon | 16:14 |
| diltram | carrbs: https://review.openstack.org/#/c/365442/1/octavia/common/config.py,edit | 16:15 |
| diltram | not this | 16:15 |
| diltram | carrbs: https://review.openstack.org/#/c/365442/1//COMMIT_MSG,edit this one | 16:15 |
| carrbs | diltram: right, thanks! | 16:16 |
| diltram | np | 16:16 |
| carrbs | I see the lil edit button now :) | 16:16 |
| diltram | rm_work: I was trying to change user which we're using in devstack | 16:17 |
| diltram | and I created a new octavia user | 16:17 |
| diltram | but api stopped working, so I switched back to neutron | 16:17 |
| diltram | but right now nova is telling to me f****ck of :P | 16:17 |
| rm_work | ok so | 16:19 |
| rm_work | the user Octavia uses has to be the same one that Neutron-LBaaS uses | 16:19 |
| rm_work | for ... reasons | 16:19 |
| rm_work | I believe it's port ownership and also for barbican it needs to be the same | 16:20 |
| rm_work | because of how consumers work | 16:20 |
| rm_work | so until we merge we just have to use the same account as n-lbaas | 16:20 |
| rm_work | diltram: but once we merge ... we'll just be using one account also :P | 16:21 |
| diltram | rm_work: not really :P | 16:22 |
| rm_work | well, one admin and one non-admin i think? | 16:23 |
| rm_work | but they'll be our own accounts | 16:23 |
| diltram | it's stupid but if you need to do smth as "service" in nova you need to have access to this project so you should use nova service user :P | 16:23 |
| diltram | we're using service accounts not admin/non-admin | 16:23 |
| rm_work | hmm | 16:23 |
| diltram | I checked in neutron how they're configuring that, there is secion nova.auth containing data about nova service user | 16:24 |
| diltram | and when they're doing something in nova they're using that account :P | 16:24 |
| diltram | it's true you can configure that in some different way but in devstack it is simplest :P | 16:25 |
| diltram | in barbican you just need to use same account always | 16:28 |
| diltram | because we're not doing anything in barbican what require service/admin access | 16:29 |
| rm_work | we are | 16:29 |
| rm_work | fetching the secrets requires an admin account right now | 16:29 |
| rm_work | because of a bug in consumers | 16:30 |
| diltram | because normaly policy.json is configured to give access to special methods, in neutron, when user is admin or user is neutron - so you need to change that policy.json to be able to use our own octavia account to make that changes | 16:30 |
| rm_work | once consumers is fixed, it will not | 16:30 |
| diltram | ok, didn't know | 16:30 |
| diltram | so I will verify that and if smth I will add also barbican user configuration | 16:30 |
| rm_work | hopefully soon it will be fixed... | 16:30 |
| rm_work | so, the workflow is supposed to be "end user adds ACL rule to their secrets/container to allow our user (non-admin) to access their secrets" | 16:31 |
| rm_work | and then we can access them | 16:31 |
| rm_work | but the consumers endpoint doesn't respect that properly | 16:32 |
| rm_work | there's a patch up for a long time but i didn't have time to finish it, and a series of people were planning to take it over but never did | 16:32 |
| rm_work | someone seems to actually be working on it again | 16:32 |
| rm_work | https://review.openstack.org/#/c/251168/ | 16:32 |
| diltram | nice :) | 16:34 |
| diltram | so will be able to change that after merging that ;) | 16:34 |
| *** matt-borland has joined #openstack-lbaas | 16:39 | |
| carrbs | diltram: I edit the commit message, is there anything else I need to do so that launchpad knows about the patch? | 16:41 |
| carrbs | *edited | 16:41 |
| diltram | carrbs: you need to save that changes | 16:41 |
| rm_work | yeah, don't see the edit yet | 16:42 |
| carrbs | I did, the bug/ticket number now displays in the commit message | 16:42 |
| carrbs | Hmm | 16:42 |
| diltram | exactly | 16:42 |
| diltram | there should be button publish edit | 16:42 |
| diltram | in place of reply... | 16:42 |
| carrbs | Oh, ok I'll do that :) | 16:43 |
| diltram | after that gerrit should publish info on launchpad | 16:43 |
| rm_work | once you save it properly, there will be a message here | 16:43 |
| *** sbalukoff has quit IRC | 16:43 | |
| openstackgerrit | Ben Carr proposed openstack/octavia: Remove deprecated (and unused) 'sqlite_db' config option https://review.openstack.org/365442 | 16:49 |
| *** sbalukoff has joined #openstack-lbaas | 16:49 | |
| carrbs | yea that worked, thanks rm_work and diltram | 16:49 |
| diltram | carrbs: np, readded +1 | 16:50 |
| diltram | edit on website doesn't recognize changing only commit msg | 16:51 |
| diltram | it | 16:51 |
| *** sbalukoff has quit IRC | 16:54 | |
| *** ihrachys has quit IRC | 16:55 | |
| *** sbalukoff has joined #openstack-lbaas | 16:57 | |
| johnsom | diltram So, looking at that test run, it looks like the nova instances didn't boot | 17:00 |
| johnsom | And the nova.conf still has qemu in it | 17:01 |
| johnsom | So, I think I am missing something | 17:01 |
| *** bana_k has quit IRC | 17:03 | |
| *** bradjones has quit IRC | 17:06 | |
| carrbs | diltram: pyenv works awesome, test running more smoothly now. Does this error seem config related as well? http://paste.openstack.org/show/567217/ | 17:10 |
| *** armax has quit IRC | 17:11 | |
| *** bradjones has joined #openstack-lbaas | 17:11 | |
| *** bradjones has quit IRC | 17:11 | |
| *** bradjones has joined #openstack-lbaas | 17:11 | |
| rm_work | carrbs: augh, I've seen that | 17:11 |
| rm_work | but i forget how to fix it | 17:11 |
| carrbs | Good that's it not just me though :) | 17:13 |
| johnsom | carrbs That error is because you ran tox with py34 before you ran with py27. The testr database built under py34 is not compatible with py27. To solve, rm -rf .testrepository and run py27 as the first test. Just running tox will also run in this order. | 17:16 |
| carrbs | johnsom: thanks, I was just reading another bug with a similar workaround. | 17:17 |
| *** bana_k has joined #openstack-lbaas | 17:20 | |
| rm_work | AH, yeah ok, that sounds familiar | 17:23 |
| *** kevo has joined #openstack-lbaas | 17:23 | |
| *** armax has joined #openstack-lbaas | 17:26 | |
| dougwig | johnsom: wow, that is fucked up. | 17:27 |
| *** kobis has joined #openstack-lbaas | 17:28 | |
| bana_k | diltram : https://review.openstack.org/#/c/355764/18 any comments for this -1 ? | 17:32 |
| openstackgerrit | Phillip Toohill proposed openstack/octavia: WIP: Octavia: Basic LoadBalancer Scenario Test https://review.openstack.org/172199 | 17:35 |
| *** harlowja has joined #openstack-lbaas | 17:38 | |
| *** amotoki has quit IRC | 17:39 | |
| *** kobis has quit IRC | 17:45 | |
| *** Alex_Stef has joined #openstack-lbaas | 18:03 | |
| *** Alex_Stef has quit IRC | 18:32 | |
| carrbs | rm_work: do you have more tips on how to get tox to run the test successfully with pyenv? | 18:32 |
| rm_work | carrbs: inside the repo directory, run "pyenv local 3.4.5" or whatever you have installed | 18:33 |
| rm_work | or probably: | 18:33 |
| carrbs | Do I need to install Python 2.7, 3.4 and 3.5 via pyenv? | 18:33 |
| rm_work | pyenv local 3.4.5 2.7.12 | 18:33 |
| rm_work | yes | 18:33 |
| rm_work | pyenv install 3.4.5 | 18:34 |
| carrbs | rm_work: just 3.4, not `pyenv local 3.4.5 2.7 3.5`? | 18:37 |
| rm_work | yeah, alll of those | 18:37 |
| carrbs | k | 18:38 |
| rm_work | then have it rebuild all of your envs | 18:38 |
| dougwig | TrevorV: status of https://bugs.launchpad.net/neutron/+bug/1521783 ? | 18:42 |
| openstack | Launchpad bug 1521783 in neutron "[RFE] Cascading delete for LBaaS Objects" [Wishlist,Incomplete] - Assigned to Brandon Logan (brandon-logan) | 18:42 |
| TrevorV | dougwig, I've never worked on it. | 18:42 |
| dougwig | TrevorV: i'm surprised we'd merge a create without a delete. | 18:43 |
| TrevorV | Well back in the day someone else was working on the delete while I was working on the create | 18:43 |
| TrevorV | I don't remember it being contingent one upon the other though | 18:43 |
| dougwig | TrevorV: ok, and is there a client patch for the create? | 18:46 |
| TrevorV | dougwig, no, and I wasn't aware of that being needed either. | 18:46 |
| TrevorV | Is there supposed to be 100% parity between client and API? | 18:47 |
| dougwig | TrevorV: yes, client, docs, tests... all are required before it can be marked 'complete'. | 18:47 |
| TrevorV | Oh, alright. Well, I didn't fully understand that. I guess we should file a bug then. | 18:48 |
| dougwig | can you whip up a client change today, so we can get it in newton? | 18:48 |
| openstackgerrit | Merged openstack/octavia: Remove deprecated (and unused) 'sqlite_db' config option https://review.openstack.org/365442 | 18:49 |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Add quota support to Octavia https://review.openstack.org/360794 | 18:49 |
| carrbs | woot, first patch ^ | 18:50 |
| TrevorV | dougwig, I've never done anything in the client before | 18:51 |
| dougwig | TrevorV: find a similar patch, copy it? | 18:51 |
| carrbs | thanks for your help on that rm_work and diltram | 18:51 |
| dougwig | i haven't either ,and that's what i'd do | 18:51 |
| TrevorV | dougwig, alright, I'll see what I can do | 18:51 |
| TrevorV | dougwig, I just need an active review though, right? So even if it isn't 100% functional I can just iterate on it a bit, yes? | 18:52 |
| dougwig | yep, but try to get it close. | 18:52 |
| TrevorV | dougwig, do you know if l7 policies/rules are available in CLI? | 18:57 |
| dougwig | TrevorV: i believe they are. | 18:57 |
| TrevorV | I should be looking in the python neutron client, huh | 18:58 |
| *** gcheresh has joined #openstack-lbaas | 19:04 | |
| *** pcaruana has quit IRC | 19:11 | |
| carrbs | johnsom: to get py27 to run first do I need to edit tox.ini? the order looks like this: envlist = docs,py35,py34,py27,pep8,specs | 19:14 |
| carrbs | looks like py27 is last of the pys? | 19:15 |
| johnsom | Yeah, I was just looking back at that bug. I had the order reversed in my memory. It is 3.x first, then 2.7. The tox.ini is correct | 19:15 |
| TrevorV | dougwig, I don't think its as easy as just pushing something up there. | 19:15 |
| carrbs | ok | 19:16 |
| TrevorV | There are a fantastic number of arguments available for utilization in the graph create. | 19:16 |
| carrbs | 34 and 27 are passing but I'm getting many errors on haproxy | 19:16 |
| carrbs | sorry 35 and 27 pass | 19:16 |
| johnsom | dougwig https://review.openstack.org/#/c/288187/ | 19:17 |
| TrevorV | For most, if not all, objects in the graph there is an "admin-state-down" option, meaning I would have to add "lb-admin-state-down" as an option argument, all the way through the entirety of the dependent objects | 19:17 |
| johnsom | It was not finished pending the API path changes. | 19:17 |
| TrevorV | dougwig, this is seriously a lot more work than just a copy pasta my friend. I'm thinking I won't be able to have something for you by EoD | 19:23 |
| *** tesseract- has quit IRC | 19:25 | |
| *** diogogmt has quit IRC | 19:29 | |
| *** diogogmt has joined #openstack-lbaas | 19:31 | |
| *** nmagnezi has joined #openstack-lbaas | 19:34 | |
| carrbs | this bug: https://bugs.launchpad.net/octavia/+bug/1618666 is in the Octavia bug list, but it appears to be a bug in pbr, should I move the ticket to pbr, or maybe I don't know what I'm talking about? | 19:37 |
| openstack | Launchpad bug 1618666 in octavia "deprecated warning for SafeConfigParser" [Medium,New] | 19:37 |
| *** rcernin has joined #openstack-lbaas | 19:41 | |
| *** rcernin has quit IRC | 19:48 | |
| *** eezhova has joined #openstack-lbaas | 19:51 | |
| dougwig | TrevorV: ok, client is already in freeze, so it's not a panic rush. | 19:55 |
| *** davidlenwell has quit IRC | 19:59 | |
| rm_work | carrbs: sure, though i would guess there might already be a version of that in PBR | 20:02 |
| *** pglass has quit IRC | 20:02 | |
| carrbs | if i clone the pbr repo and fix, can I just leave it in the octavia buq queue and reference that ticket number in the commit message? | 20:05 |
| *** pglass has joined #openstack-lbaas | 20:05 | |
| rm_work | I would see if you can find a bug in their project already | 20:11 |
| carrbs | I didn't see it, I looked for a while | 20:11 |
| rm_work | if there isn't one, you can move the existing one over -- or else, not every commit NEEDS a bug, you could close ours as invalid, and just commit the fix | 20:11 |
| carrbs | I can move the ticket and attach a solution maybe? | 20:12 |
| *** davidlenwell has joined #openstack-lbaas | 20:12 | |
| carrbs | (the solution is in the DeprecationWarning, pretty straightforward I think.) | 20:13 |
| rm_work | there's a bunch of ways to skin it, basically do whatever you feel like doing | 20:13 |
| rm_work | if it were me, i'd probably just mark our bug as invalid and close it, and then do the fix in pbr and submit it without a bug | 20:14 |
| carrbs | rm_work: ok | 20:28 |
| nmagnezi | sbalukoff, hey, around by any chance? | 20:32 |
| TrevorV | hey diltram you around? | 20:35 |
| diltram | TrevorV: yeah | 20:35 |
| *** eezhova has quit IRC | 20:37 | |
| TrevorV | diltram, on this review: https://review.openstack.org/#/c/360794 | 20:39 |
| TrevorV | You make a comment about "six.iteritems" | 20:39 |
| TrevorV | Any particular reason why I shouldn't do my iteration the same way as other methods have in that file? | 20:39 |
| diltram | it's performance related | 20:39 |
| diltram | you can timeit in python and you will see that it's faster to use iteritem | 20:40 |
| diltram | iteritems | 20:40 |
| TrevorV | Okay, sure, but we aren't using iteritems elsewhere in there for custom update methods, from what I can tell. | 20:41 |
| TrevorV | That's all I meant | 20:41 |
| diltram | and? | 20:41 |
| diltram | what is it changing? | 20:42 |
| TrevorV | Its creating inconsistencies, that's all. | 20:42 |
| TrevorV | Performance is good though, so I'll make the change. | 20:42 |
| diltram | sorry but in my opinion we should write python code | 20:43 |
| diltram | not "standard" | 20:43 |
| johnsom | carrbs Yeah, it looks like I should have opened that against pbr. Are you able to move it or should I? | 20:47 |
| carrbs | johnsom: I don't see how to move it, there's an "Also affects project" button, but that doesn't seem totally right | 20:49 |
| carrbs | I will leave to you | 20:49 |
| johnsom | Yeah, you might need to be a core to do that. I will fix it. | 20:49 |
| carrbs | ok | 20:49 |
| carrbs | johnsom: the other bug you gave me https://bugs.launchpad.net/octavia/+bug/1618665 is a bug in site.py, I can see where to fix it, but I'm not sure where site.py comes from. | 20:50 |
| openstack | Launchpad bug 1618665 in octavia "deprecated warning for mode "U"" [Medium,New] | 20:50 |
| TrevorV | diltram, I'm not quite sure what you mean by that, since its all python code, but thanks for the heads up. As for your other comments, they were on incomplete methods and "placeholders" because I pushed up the review as a WIP so I could go home that day, and pick up where I left off on a different machine. | 20:51 |
| TrevorV | Its still WIP though, so you don't need to prioritize reviewing it. | 20:51 |
| carrbs | U should be removed, and open() takes newline=None as a parameter | 20:51 |
| johnsom | carrbs Actually it looks like that might be fixed in the new python3.4. It is also an invalid bug for octavia. | 20:53 |
| diltram | TrevorV: so please set -W on it, I didn't know that and even sending that pach to review you can use "git review -D" and it's submitting the code with -W | 20:53 |
| TrevorV | I had it marked WIP when you made those comments previously. As I just updated just now. I didn't know using -D would mark it immediately, that's fantastic! I'll use that in the future :) | 20:54 |
| carrbs | which, 1618665? | 20:54 |
| johnsom | Yep | 20:54 |
| carrbs | ok, so resolved? | 20:54 |
| *** eezhova has joined #openstack-lbaas | 20:55 | |
| johnsom | Yeah, I will mark invalid | 20:57 |
| diltram | TrevorV: yeah, it's nice to have that feature especially in situations like this ;) | 20:59 |
| TrevorV | You're definitely correct ha ha | 20:59 |
| diltram | I was using that when I was trying testing my code on gate because I was not able to build my own :( | 20:59 |
| TrevorV | oh no! ha ha thanks again for the help, much appreciated :) | 21:00 |
| diltram | np bro :) | 21:00 |
| *** gcheresh has quit IRC | 21:01 | |
| pglass | if I create a loadbalancer (which takes 10 minutes) and octavia services are restarted before that loadbalancer goes active, what happens to that loadbalancer? | 21:05 |
| pglass | does it eventually go to error or get cleaned up by housekeeping? | 21:05 |
| *** nmagnezi has quit IRC | 21:05 | |
| diltram | it will hang in pending create for some time | 21:06 |
| pglass | and then what? | 21:06 |
| diltram | or no it will be in pending create forever right now | 21:07 |
| diltram | we decided that we're not merging that weird code changing that status for error | 21:07 |
| diltram | we're looking to implement Job Board -> http://docs.openstack.org/developer/taskflow/persistence.html | 21:08 |
| pglass | how does this interact with the spares pool that housekeeping manages? | 21:09 |
| pglass | or how *should* it? | 21:09 |
| TrevorV | Anyone know what this means: [ ERROR ] Current working directory is dirty and must be resolved | 21:11 |
| TrevorV | ERROR: InvocationError: '/opt/stack/octavia/.tox/pep8/bin/bandit-baseline -r octavia -ll -ii' | 21:11 |
| diltram | you need first commit code | 21:12 |
| diltram | before running bandit :P | 21:12 |
| TrevorV | oh, ha ha okay | 21:12 |
| diltram | this is why I was against merging that two gates :/ | 21:12 |
| TrevorV | I was just running tox locally is all | 21:13 |
| diltram | I know | 21:13 |
| diltram | but we unfrotunatelly merged the bandit into tox | 21:13 |
| TrevorV | Oh, now I gotcha. Dangit. | 21:13 |
| diltram | because infra asked about that all projects | 21:13 |
| diltram | we need to add Syntribos into Octavia and remove that bandind into different tox test :P | 21:14 |
| diltram | and then there will be more tests so we will not be against infra team :P | 21:14 |
| TrevorV | I'm not sure I follow all of that logic, but when everyone's happy, everyone's happy :) | 21:17 |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Add quota support to Octavia https://review.openstack.org/360794 | 21:18 |
| *** matt-borland has quit IRC | 21:18 | |
| *** eezhova has quit IRC | 21:30 | |
| johnsom | diltram I don't follow you on the current working directory issue. If I check out a fresh repo pep8 runs clean for me | 21:36 |
| johnsom | Is it uncommitted changes? | 21:36 |
| diltram | johnsom: when you have something uncommited you cannot run bandit :P | 21:36 |
| openstackgerrit | Lubosz Kosnik (diltram) proposed openstack/octavia: Backend Keystone authentication https://review.openstack.org/364655 | 21:40 |
| *** diogogmt has quit IRC | 21:45 | |
| carrbs | johnsom: are there other bugs you can recommend my way? There's one here: https://bugs.launchpad.net/octavia/+bug/1596627 that looked interesting, but I might need guidance. If there's other smaller/easier ones you know of I'd be happy to look at those as well. | 21:50 |
| openstack | Launchpad bug 1596627 in octavia "Octavia API needs filtering support" [High,New] | 21:50 |
| *** ddaskal has quit IRC | 21:59 | |
| *** ddaskal has joined #openstack-lbaas | 21:59 | |
| *** ddaskal has quit IRC | 22:04 | |
| *** BjoernT has quit IRC | 22:05 | |
| *** _ducttape_ has joined #openstack-lbaas | 22:26 | |
| *** _ducttape_ has quit IRC | 22:26 | |
| *** ducttape_ has quit IRC | 22:29 | |
| *** pglass has quit IRC | 22:44 | |
| diltram | johnsom: it's weird because by default devstack should use kvm when available | 23:29 |
| johnsom | It doesn't seem to be. I haven't looked at that yet. I've been talking with the bandit folks | 23:30 |
| diltram | aaa, ok | 23:32 |
| diltram | I just checked the devstack code and there is info that by default it should use kvm and fallback into qemu when there is no access to kvm | 23:32 |
| johnsom | Something is explicitly setting it in the localrc to qemu | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!