Friday, 2016-05-13

*** evgenyf has joined #openstack-lbaas00:01
*** AnothrLundquist has quit IRC00:03
*** rcernin has quit IRC00:24
*** catintheroof has quit IRC00:27
*** fnaval has quit IRC00:32
*** SumitNaiksatam has joined #openstack-lbaas00:35
*** crc32 has quit IRC00:39
*** evgenyf has quit IRC00:41
*** diogogmt has quit IRC00:44
*** fnaval has joined #openstack-lbaas00:47
*** cody-somerville has joined #openstack-lbaas00:50
*** mixos has joined #openstack-lbaas00:52
*** arjun has joined #openstack-lbaas00:52
*** arjun is now known as Guest8943600:52
Guest89436is there a db-manage command for octavia?00:53
Guest89436what needs to be done to create the octavia sql db?00:53
*** mixos has quit IRC00:59
Guest89436in fact, is there any guide that goes over how to configure octavia? I am unsure of some of the settings in the octavia.conf file01:00
Guest89436all the lbaas docs I could find only mention installing octavia via pip or package manager and just setting the service plugins/provider in neutron01:01
Guest89436I pulled the source from git, and ran the setup.py on my controller node01:01
*** openstackgerrit has quit IRC01:02
*** openstackgerrit has joined #openstack-lbaas01:03
*** mixos has joined #openstack-lbaas01:05
*** jaff_cheng has quit IRC01:12
*** chlong has joined #openstack-lbaas01:13
*** SumitNaiksatam has left #openstack-lbaas01:18
*** daneyon_ has quit IRC01:24
*** bana_k has quit IRC01:24
*** chlong has quit IRC01:31
*** diogogmt has joined #openstack-lbaas01:33
*** jaff_cheng has joined #openstack-lbaas01:53
*** ducttape_ has joined #openstack-lbaas01:53
*** Guest89436 has quit IRC01:53
*** yamamot__ has joined #openstack-lbaas01:54
*** chenghang has joined #openstack-lbaas01:58
*** kevo has quit IRC01:59
*** Purandar has quit IRC01:59
*** jaff_cheng has quit IRC02:00
*** chenghang is now known as jaff_cheng02:00
*** ducttape_ has quit IRC02:25
*** ducttape_ has joined #openstack-lbaas02:26
*** ducttape_ has quit IRC02:27
*** ducttape_ has joined #openstack-lbaas02:28
*** chenghang has joined #openstack-lbaas02:30
*** jaff_cheng has quit IRC02:30
*** _ducttape_ has joined #openstack-lbaas02:39
*** ducttape_ has quit IRC02:43
*** _ducttape_ has quit IRC02:54
*** chlong has joined #openstack-lbaas03:08
*** kobis has joined #openstack-lbaas03:11
*** reedip__ has joined #openstack-lbaas03:19
*** mixos has quit IRC03:21
*** mixos has joined #openstack-lbaas03:21
*** ducttape_ has joined #openstack-lbaas03:24
*** ducttape_ has quit IRC03:24
*** ducttape_ has joined #openstack-lbaas03:24
*** ducttape_ has quit IRC04:00
*** ducttape_ has joined #openstack-lbaas04:01
*** ducttape_ has quit IRC04:01
openstackgerritPhillip Toohill proposed openstack/octavia: Network driver should generate network configs  https://review.openstack.org/31587004:14
ptoohillI started looking into whats going on with the tests, somethings jacked. Maybe we can figure something out tomorrow, I'll have a further look then.04:15
*** links has joined #openstack-lbaas04:23
*** doug-fish has joined #openstack-lbaas04:25
*** doug-fish has quit IRC04:29
*** yamamot__ has quit IRC04:51
*** yamamot__ has joined #openstack-lbaas04:52
*** cody-somerville has quit IRC05:04
*** amotoki has quit IRC05:23
*** chlong has quit IRC05:29
*** rcernin has joined #openstack-lbaas05:50
*** amotoki has joined #openstack-lbaas05:52
*** bana_k has joined #openstack-lbaas05:57
*** cody-somerville has joined #openstack-lbaas06:05
*** anilvenkata has joined #openstack-lbaas06:16
*** woodster_ has quit IRC06:18
*** kevo has joined #openstack-lbaas06:19
*** bana_k has quit IRC06:24
*** armax has quit IRC06:24
*** numans has joined #openstack-lbaas06:33
*** prabampm has joined #openstack-lbaas06:37
*** amotoki has quit IRC06:51
*** tesseract has joined #openstack-lbaas06:56
*** mixos has quit IRC06:59
*** mixos has joined #openstack-lbaas07:00
*** amotoki has joined #openstack-lbaas07:01
*** amotoki has quit IRC07:01
*** amotoki has joined #openstack-lbaas07:07
*** amotoki has quit IRC07:07
*** mixos has quit IRC07:09
*** amotoki has joined #openstack-lbaas07:17
*** fawadkhaliq has joined #openstack-lbaas07:20
*** Alex_Stef has quit IRC07:22
*** Alex_Stef has joined #openstack-lbaas07:34
*** reedip__ has quit IRC07:43
*** cody-somerville has quit IRC07:46
*** reedip__ has joined #openstack-lbaas07:54
*** bogdan has joined #openstack-lbaas08:42
bogdanwhat would be the alternative of "ovs-vsctl -- --may-exist add-port" if using linuxbridge? I am trying to configure the octavia health manager in a linuxbridge environment08:44
*** dmk0202 has joined #openstack-lbaas09:09
*** amotoki has quit IRC09:58
*** reedip__ has quit IRC10:00
bogdani am experiencing some continuous ERROR-ONLINE status switching for a member - see the o-hm log http://paste.openstack.org/show/497025/10:03
bogdanmy neutron/lbaas reported lb status tree seems outdated, how can I print the whole tree from octavia service/db directly?10:05
*** amotoki has joined #openstack-lbaas10:18
*** rtheis has joined #openstack-lbaas10:33
*** amotoki has quit IRC10:36
*** amotoki has joined #openstack-lbaas10:43
*** amotoki has quit IRC10:44
*** bogdan has quit IRC11:22
*** bogdan has joined #openstack-lbaas11:22
*** reedip__ has joined #openstack-lbaas11:27
*** bogdan_ has joined #openstack-lbaas11:58
*** bogdan has quit IRC12:01
*** links has quit IRC12:14
*** ducttape_ has joined #openstack-lbaas12:14
*** yamamot__ has quit IRC12:20
*** amotoki has joined #openstack-lbaas12:20
*** ducttape_ has quit IRC12:24
*** diogogmt has quit IRC12:37
*** diogogmt has joined #openstack-lbaas12:39
*** matt-borland has joined #openstack-lbaas12:40
FritoAny chance I could core reviews on https://review.openstack.org/#/c/312595/ ??12:41
*** rcernin_ has joined #openstack-lbaas12:42
*** rcernin has quit IRC12:42
*** yamamoto has joined #openstack-lbaas12:43
*** amotoki has quit IRC13:00
*** piet has joined #openstack-lbaas13:02
*** diogogmt has quit IRC13:06
*** reedip__ has quit IRC13:07
*** doug-fis_ has joined #openstack-lbaas13:10
*** doug-fis_ has quit IRC13:11
*** doug-fis_ has joined #openstack-lbaas13:11
*** diogogmt has joined #openstack-lbaas13:15
*** rcernin_ has quit IRC13:16
*** ducttape_ has joined #openstack-lbaas13:16
*** fawadkhaliq has quit IRC13:20
*** fawadkhaliq has joined #openstack-lbaas13:20
*** amotoki has joined #openstack-lbaas13:24
*** fawadkhaliq has quit IRC13:25
*** rcernin has joined #openstack-lbaas13:27
*** openstack has joined #openstack-lbaas13:48
HenryGThe gate-neutron-lbaasv2-dsvm-minimal job is failing and blocking all neutron patches.13:48
HenryGThis patch proposes to make it non-voting: https://review.openstack.org/31609113:48
HenryGBut why is it failing?13:49
*** openstack has joined #openstack-lbaas13:56
*** bogdan_ has quit IRC14:04
*** ducttape_ has quit IRC14:05
*** ducttape_ has joined #openstack-lbaas14:07
*** links has joined #openstack-lbaas14:19
*** piet has quit IRC14:25
*** piet has joined #openstack-lbaas14:26
*** links has quit IRC14:29
*** Purandar has joined #openstack-lbaas14:30
*** BjoernT has joined #openstack-lbaas14:54
*** woodster_ has joined #openstack-lbaas15:01
*** fnaval has quit IRC15:02
*** mixos has joined #openstack-lbaas15:13
*** dmk0202 has quit IRC15:13
*** mixos_ has joined #openstack-lbaas15:14
*** openstackgerrit has quit IRC15:17
*** mixos has quit IRC15:17
*** openstackgerrit has joined #openstack-lbaas15:18
*** fnaval has joined #openstack-lbaas15:18
*** daneyon has joined #openstack-lbaas15:22
*** ducttape_ has quit IRC15:28
*** ducttape_ has joined #openstack-lbaas15:32
*** armax has joined #openstack-lbaas15:37
*** daneyon_ has joined #openstack-lbaas15:41
bloganHenryG: looks to me like nova's VMs are not going active15:43
johnsomUmm, I disagree.  This is a noop test15:44
*** daneyon has quit IRC15:44
*** anilvenkata has quit IRC15:45
bloganjohnsom: oh god i forgot about that, i see errors in the o-cw, but the're on pool delete15:47
johnsomYeah, that is where I am looking too.  Strange thing is, I can't find that dependency it is complaining about....15:47
johnsomI'm wondering if the new taskflow is an issue, I know they were doing a release soon15:47
bloganeyah thats probably it anyway, deleted a pool and waiting for the lb to go active, it never does15:48
*** numans has quit IRC15:51
bloganjohnsom: yeah its only requiring pool15:55
bloganmust have been a taskflow update or something with a bug15:56
*** tesseract has quit IRC15:56
bloganmost recent version of taskflow was uploaded on wedensday15:57
*** mixos_ has quit IRC15:59
bloganpretty sure that job has passed since then, so not sure15:59
*** prabampm has quit IRC16:00
*** minwang2 has joined #openstack-lbaas16:00
*** mixos has joined #openstack-lbaas16:01
*** rcernin has quit IRC16:02
ptoohilleverything is failing, not just that one test, i tried rolling back other deps.. didnt find the right one. so maybe its taskflow like blogan said? Its something that was updated two days agao whatever it is16:03
johnsomThat points to TaskFlow16:04
openstackgerritBrandon Logan proposed openstack/octavia: Do not use taskflow 1.32.0  https://review.openstack.org/31617416:04
ptoohillah, cool16:05
ptoohilltesting it16:05
bloganlooking the jobs that passed the other day they were on tf 1.31.016:05
ptoohillthat makes sense then, good digging!16:05
ptoohillYAY16:10
blogan?16:10
ptoohillThat works :P16:16
bloganHenryG: ^ that review should fix the job failure16:18
ptoohilli was looking into mock requests-mock, those changed recently too, then i went to sleep16:18
bloganptoohill: and thats what's causing the py27 and py34's to fail?16:18
ptoohillIt does from my tests, now we can do reviews agaian16:18
ptoohillyep!16:18
ptoohillthe taskflow was16:19
ptoohillwas last on that list for me to look into ><16:19
ptoohilli didnt see that one was updated before i went to sleep16:19
*** yamamoto has quit IRC16:20
ptoohillrunning full suite now16:20
ptoohillYea, looks good! we can move forward again! yay16:22
ptoohillthose mismatch errors through me for a loop, normally means something else is wrong ><16:23
*** kevo has quit IRC16:23
bloganso it was a mock-requests version change?16:23
ptoohillno16:24
ptoohilltasflow16:24
bloganeven for the py27?16:24
ptoohilli got up to testing/verifying those deps16:24
ptoohillyea16:24
bloganohhh16:24
ptoohillit destroyed everything16:24
ptoohillo.o16:24
blogandamn16:24
blogani wonder if we're doing something wrong that 1.32.0 finally closed the holes on, or if its a legit bug16:24
ptoohillprobably former16:25
ptoohill><16:25
ptoohillor we were doing it right, then they changed it16:25
ptoohillone of those two16:25
blogani'd expect htem to do a major version bump for that16:25
ptoohilleh, i wouldnt expect it16:26
ptoohill:)16:26
ptoohillin either case im excited you found it, now i can pester about my patches again :)16:26
johnsomI already mentioned it in their room16:27
ptoohillThey say anything?16:27
ptoohillloading in16:27
johnsomThey wanted more info16:27
*** ducttape_ has quit IRC16:27
ptoohilljohnsom: #task-flow?16:29
bloganopenstack-state-management isn't it?16:29
ptoohilloh16:30
ptoohillheh, way off16:30
bloganthats what it was before i got banned16:30
ptoohilllol16:30
ptoohillyou got banned?16:30
bloganha no, but i'm sure they've thought about it16:30
ptoohill:P16:30
ptoohilloh, yea16:30
ptoohillhahaha16:30
ptoohillanti taskflow vexxer, get outta here16:31
* ptoohill is on your side16:31
johnsomopenstack-state-management16:32
blogani've always said i like the features of it, but it just decomposes the code too much. if you don't decompose the code very much you lose a lot of the benefits16:32
johnsomYou guys...16:32
blogan:)16:33
ptoohilllol16:33
*** ducttape_ has joined #openstack-lbaas16:41
*** daneyon_ has quit IRC16:46
johnsomOk, so, really it is our bug16:49
ptoohill><16:49
johnsomIt just wasn't validating this issue before16:49
johnsomSo, when we moved the flow from pool_id to pool, we didn't update the reverts16:50
johnsomSo, those reverts are broken.  Now taskflow is validating the reverts16:50
ptoohilli see, interesting ><16:50
bloganhaha, that was my first thought that it was something we were diong that taskflow just closed the loophole on16:51
ptoohillthen in that case, blogans patch gets a -1, we should fix this properly16:52
bloganwell16:52
ptoohill:)16:52
bloganid rather this go in to unblock everything and then we fix it16:52
ptoohillwhy though?16:52
bloganand then remove this restriction16:52
bloganhow many reverts are like this?16:52
ptoohillwhat are we waiting on that we need to push in before flows are fixed?16:52
ptoohillthink just pool related one16:52
ptoohills16:52
bloganwell if you can verify that go for it16:53
*** ducttape_ has quit IRC16:54
johnsomThere is more than one: http://logs.openstack.org/98/315498/3/check/gate-neutron-lbaasv2-dsvm-minimal/1cb0bf8/logs/screen-o-cw.txt.gz16:54
ptoohill'ones'16:54
johnsomBut this should be a fairly complete list16:54
ptoohillwas there a bug for this already?16:56
*** amitry has quit IRC16:56
johnsomNot that I know of16:56
bloganptoohill: push a review that fixes those16:56
bloganill +2 it16:56
johnsomI will too16:56
bloganbut who will +A it?16:56
* johnsom glares at blogan16:57
* blogan turns to stone16:57
ptoohilllol16:57
*** mixos has quit IRC16:57
johnsomI feel like I should roll a dice16:57
blogand20?16:58
johnsomRight16:58
johnsomSomething like "Acid rain dissolves the stone blogan, roll again"16:59
*** blogan_mobile has joined #openstack-lbaas16:59
*** catintheroof has joined #openstack-lbaas16:59
blogani guess i'm just a big puddle of mud?17:00
ptoohillAnd he hatches out of the stone like a caccoon and turns into a big butterfly and flies away?17:00
ptoohilli took that a different direction17:00
ptoohill:)17:00
*** catintheroof has quit IRC17:00
*** amitry has joined #openstack-lbaas17:00
*** catintheroof has joined #openstack-lbaas17:00
bloganyep17:00
bloganokay im giong to get something to eat17:00
johnsomEnjoy17:01
bloganlink me in channel, im on my phone17:01
bloganblogan_mobile17:01
*** kevo has joined #openstack-lbaas17:03
*** blogan_mobile_ has joined #openstack-lbaas17:04
*** daneyon has joined #openstack-lbaas17:05
*** blogan_mobile has quit IRC17:06
*** bana_k has joined #openstack-lbaas17:13
openstackgerritPhillip Toohill proposed openstack/octavia: Taskflow update exposed inconsistencies in tasks  https://review.openstack.org/31621717:20
ptoohilljohnsom: blogan_mobile_ https://review.openstack.org/#/c/316217/17:21
*** amotoki has quit IRC17:21
ptoohillrm_work: too since you reviewed https://review.openstack.org/#/c/316217/17:21
johnsomptoohill Thanks! Looks good17:27
blogan_mobile_ptoohill did you verify that fuses the issue?17:30
blogan_mobile_fixes17:30
ptoohillno, just hoping17:30
ptoohillpeeing into the wind, want to see what happens17:30
ptoohill:)17:30
ptoohillbut yes, blogan_mobile_ I did indeed verify. had 8 failures prior to fix, now 0 failures17:31
* ptoohill deleted all the tests17:32
ptoohillo.o17:32
blogan_mobile_That works too17:32
ptoohill:)17:32
ptoohillso yea, were cool then17:32
ptoohill:)17:32
ptoohillannnnd kaboom!17:37
ptoohillsuppose the gates arent going to be much worse if that was the case ;)17:37
ptoohillblogan_mobile_: It didnt like your patch either :P http://logs.openstack.org/74/316174/1/check/gate-octavia-requirements/9dfc691/console.html17:39
blogan_mobile_Good thing you did yours :)17:40
ptoohill:P17:41
*** meghal has joined #openstack-lbaas17:41
*** bana_k has quit IRC17:44
meghalhello…I was looking at neutron lbaas documents on the internet and got the idea that it can be used with in neutron scope by calling lbaas plugin for configuring different loadbalancers based on different drivers17:46
meghalbut is it possible to use lbaas as a standalone rest api service ?17:46
*** ri0 has joined #openstack-lbaas17:47
meghalif so, could somebody please point me to the latest documentation for it ?17:47
*** piet has quit IRC17:47
ptoohillmeghal: Currently that is not possible, though we do have talks about lbaas as a standalone. I believer were actually gaining a little traction there17:48
ptoohillbelieve*17:48
ptoohillmeghal: Here's our starting point for this; https://review.openstack.org/#/c/310667/17:49
meghalptoohill:  thanks for the info, so looks like there is a agent, different agent drivers and agent receives messages via rpc…so in a way all that is needed is an unified api layer on top of it…right ?17:49
meghalptoohill:  dumb que…how does octavia differ from current lbaas plugin ?17:50
ptoohillv1 is deprecated, or will be, i forget which it is. So, were going towards the octavia solution17:50
ptoohilloctavia(v2) is designed to be an operator grade load balancing solution, v1 was a poc17:50
ptoohillessentially17:50
meghalok…but still a plugin based approach…right ?17:51
ptoohillyes, it still has neutron/neutron-lbaas communcation channels because thats what we are tied to, but hopefully we get that spec moving in the right direction and start implementing a standalone17:51
meghalok cool…thanks17:52
ptoohillOnce this is a 'standalone' it will no longer be a plugin, but currently octavia is just another driver in neutron-lbaas, but octavia itself is primed to take neutron-lbaas's spot, we just have a bit more work to do17:52
ptoohillnp17:52
*** ducttape_ has joined #openstack-lbaas17:55
HenryGhey blogan ptoohill johnsom, sorry, I just got back. What is the latest on the gate failure?17:55
*** ducttape_ has quit IRC17:56
ptoohillHenryG: I have a patch that's in process of merging that will resolve this17:56
*** ducttape_ has joined #openstack-lbaas17:56
HenryGptoohill: https://review.openstack.org/316217 ?17:57
ptoohillyep17:57
HenryGSo taskflow can break neutron via octavia?17:58
*** bana_k has joined #openstack-lbaas17:58
HenryGnice17:58
*** SumitNaiksatam has joined #openstack-lbaas17:59
ptoohillNot sure it broke neutron, but caused a bunch of validation failures in tests17:59
ptoohilltaskflow validation*17:59
HenryGNeutron gates on gate-neutron-lbaasv2-dsvm-minimal18:00
ptoohillthat tests octavia right?18:00
ptoohillthe tests in octavia had hard stop because of missed updates to revert methods18:01
ptoohillor it calls octavia18:01
ptoohillwhich uses taskflow, and new taskflow caught those issues18:01
ptoohillso octavia broke those tests18:01
ptoohillnot taskflow18:01
ptoohillin this case atleast18:01
HenryGStill, we may need to re-jiggle our interdependencies here18:02
ptoohilloctavia is default18:02
*** bana_k has quit IRC18:02
HenryGre-jiggle is a technical term18:02
johnsomminimal is running noop drivers, it's an API test18:02
ptoohilloh18:02
ptoohillthen was i testing/fixing something else?18:02
ptoohillstill though, having it bubble up the failures isnt a bad thing18:02
johnsomNo, you were fixing the right thing.  This breakage was because taskflow turned on more validation and we had bugs in the revert flow18:03
ptoohillah, i see18:03
*** bana_k has joined #openstack-lbaas18:04
ptoohillhopefully soon we wont even have nlbaas to worry about 'soon' :)18:04
* ptoohill dreams18:05
*** doug-fish has joined #openstack-lbaas18:12
*** mixos has joined #openstack-lbaas18:14
*** doug-fi__ has joined #openstack-lbaas18:15
*** doug-fis_ has quit IRC18:15
*** numans has joined #openstack-lbaas18:17
*** doug-fish has quit IRC18:17
*** doug-fi__ has quit IRC18:18
meghalcould somebody point me to the folks I should talk to for netscaler load balancer driver ?18:22
*** doug-fish has joined #openstack-lbaas18:23
*** minwang2 has quit IRC18:24
johnsommeghal I think you will need to contact citrix.  I don't think there is anyone that works on the netscaler driver normally on this IRC channel18:29
*** ducttape_ has quit IRC18:30
meghaljohnsom:  ok…cool…thanks for the info18:32
*** daneyon has quit IRC18:38
*** meghal has quit IRC18:41
*** meghal has joined #openstack-lbaas18:41
*** meghal1 has joined #openstack-lbaas18:42
*** meghal has quit IRC18:42
*** meghal1 has quit IRC18:44
*** meghal has joined #openstack-lbaas18:45
*** blogan_mobile has joined #openstack-lbaas18:48
*** doug-fish has quit IRC18:51
*** doug-fish has joined #openstack-lbaas18:52
*** blogan_mobile_ has quit IRC18:52
*** doug-fish has quit IRC18:53
*** meghal has quit IRC18:54
*** meghal has joined #openstack-lbaas18:54
*** doug-fish has joined #openstack-lbaas18:54
*** ducttape_ has joined #openstack-lbaas18:54
*** blogan_mobile has quit IRC18:55
*** minwang2 has joined #openstack-lbaas18:55
*** doug-fish has quit IRC18:59
*** minwang2 has quit IRC19:00
*** doug-fish has joined #openstack-lbaas19:02
*** crc32 has joined #openstack-lbaas19:03
*** minwang2 has joined #openstack-lbaas19:20
*** minwang2 has quit IRC19:20
*** daneyon has joined #openstack-lbaas19:27
*** meghal has quit IRC19:32
*** daneyon_ has joined #openstack-lbaas19:32
*** meghal has joined #openstack-lbaas19:33
bloganfnaval: http://logs.openstack.org/17/316217/1/check/gate-neutron-lbaasv2-dsvm-scenario/b042f1d/console.html#_2016-05-13_18_53_10_11319:34
*** kobis1 has joined #openstack-lbaas19:34
bloganfnaval: any idea what that is?19:34
*** kobis has quit IRC19:35
*** daneyon has quit IRC19:35
*** crc32 has quit IRC19:44
openstackgerritMerged openstack/octavia: Taskflow update exposed inconsistencies in tasks  https://review.openstack.org/31621719:46
openstackgerritPhillip Toohill proposed openstack/octavia: Whitespace bug in sysvinit jinja template  https://review.openstack.org/31485319:47
openstackgerritPhillip Toohill proposed openstack/octavia: Network driver should generate network configs  https://review.openstack.org/31587019:47
fnavalblogan: yep19:50
fnavalit's recent change from upstream19:51
fnavallet me see if i can push up change to fix it19:51
madhu_akfnaval, https://review.openstack.org/#/c/311221/19:53
madhu_akthat was a recent change in tempest upstram19:53
fnavalyep thats the reason blogan ^^^ thanks madhu19:53
fnavallet me do a quick PR for changing it in neutron lbaas19:54
bloganokay, thanks19:54
openstackgerritFranklin Naval proposed openstack/neutron-lbaas: Neutron-LBaaS: Fix network_resources path  https://review.openstack.org/31626320:00
fnavalblogan: ^^20:00
bloganfnaval: thanks20:01
fnavalyep yep20:01
*** ri0 has quit IRC20:01
*** dmk0202 has joined #openstack-lbaas20:03
*** daneyon_ has quit IRC20:11
openstackgerritMatt Alline proposed openstack/octavia: Added amphora_id to listener_statistics table to stop data loss  https://review.openstack.org/31259520:18
*** dmk0202 has quit IRC20:22
Fritoblogan: --^ fixed the copy paste error >.>20:26
Fritorebased while I was at it20:27
bloganFrito: so optionals still isn't being used :)20:29
Fritoyea it is20:30
Fritogetting line number20:30
Fritounless I didn't ammend or something20:30
bloganok it is, but only as an override mechanism20:30
Fritoline 14320:30
FritoRight20:30
bloganare there other columns?20:31
bloganthat amphora table has?20:31
blogani can't remember20:31
blogananyway, if you did **opts it'd give you the ability to pass more columns in, but now that I think about it, that's probably not good20:31
bloganthe exceptions thrown won't be that great20:32
FritoYea, there's a bunch of columns on that table.20:32
FritoI figured I'd let others extend the method as it was needed.20:32
bloganah okay, so optionals is intended to allow other column names to be added?20:33
Fritoin the future yea. Ones that aren't necessarily required to insert data into that table.20:33
bloganin that case, just do **opts at L147, and that covers both use cases20:33
bloganreplace L147-L150 with just the one **opts line20:34
FritoAh, ok. Guess you can tell python exp. level is low here. I keep forgetting you can do that.20:35
Fritowill ammend, re run tests and re push then. Thx for taking a peek20:35
Fritoamend*20:35
bloganFrito: np, sorry if it seems nitpicky but you may as well allow both use cases with less code :)20:36
FritoRight on. I'm just used to static typed languages so thinking in the duck typed patterns isn't natural yet.20:37
Fritoso do I put **opts or just opts?20:38
FritoOr rather why is it **opts and not just opts?20:38
blogan**opts, because python unpacks it into keyword arguments20:39
bloganif you just passed opts, the receiving method will see it as one argument and it'd be a dictionary20:39
FritoAh, okay. Cool. Thanks :-)20:39
bloganwhereas ** says unpack this into each individual keyword argument (compute_id=,status=)20:39
bloganfor positional args, you can do *opts20:39
bloganwhere opts is a list20:40
bloganor tuple20:40
blogani guess it might even be bale to be a dictionary and it just uses the keys and ignores the values, but not sure20:40
Fritoyea, args* vs kwargs**20:40
bloganyay i got 100% on the PCI bs20:40
Fritolol20:41
Fritohehe20:41
bloganso hard to concentrate on that20:41
FritoYea, I did that the day they sent it out b/c I wanted to be done with it.20:41
bloganin my mind i was protesting by procrastination, but really i was just procrastinating20:41
Frito"Be different. conform!"20:42
Frito^-- probably one of my favorite fortunes20:42
bloganreminds me of http://global3.memecdn.com/think-different_o_1075051.jpg20:44
Fritolol20:45
fnavallol - probably some aren't running OSX20:46
openstackgerritMatt Alline proposed openstack/octavia: Added amphora_id to listener_statistics table to stop data loss  https://review.openstack.org/31259520:54
* Frito waits on the gerrit bot20:54
Fritoha20:54
*** doug-fis_ has joined #openstack-lbaas20:55
*** doug-fis_ has quit IRC20:55
*** doug-fish has quit IRC20:58
fnavalone of these days I'll re-write the tests so that they all can run in parallel thus reducing the execution time20:59
bloganFrito: you're going to hate me21:01
FritoYou obviously didn't get the memo21:01
bloganFrito: but what's the point of defaulting vrrp_ip and lb_networks_ip to None when thats what the db already does when its not specified?21:02
*** rtheis has quit IRC21:02
*** minwang2 has joined #openstack-lbaas21:02
FritoTrying to get the high score for most patches in a single PR21:02
FritoI'm only 14 short by my calculations21:02
bloganFrito: ptoohill has you  beat big time21:02
Fritolol21:02
bloganFrito: and just like you, it was caused by me probably21:03
FritoMeh21:03
FritoIn all seriousness it's my ignorance on the default behavior on all the things and lack of spending time to go research it :-/21:04
FritoI can update but it wont be immediately. I'm about to head out and try to beat the traffic assuming I can answer mandos question soon21:04
blogani can update it for you21:04
bloganin gerrit21:04
FritoI didn't realize gerrit let you edit inline21:09
*** mixos has quit IRC21:11
*** ducttape_ has quit IRC21:15
fnavallooking at the error21:16
fnavallooks to be v121:16
bloganit does with the recent update to it that was probably 6 months ago but still feels new21:16
openstackgerritBrandon Logan proposed openstack/octavia: Added amphora_id to listener_statistics table to stop data loss  https://review.openstack.org/31259521:17
bloganFrito: edited in gerrit ^21:17
*** ducttape_ has joined #openstack-lbaas21:23
openstackgerritFranklin Naval proposed openstack/neutron-lbaas: Neutron-LBaaS: Fix network_resources path  https://review.openstack.org/31626321:27
*** matt-borland has quit IRC21:33
*** ducttape_ has quit IRC21:36
ptoohilllolol Frito blogan21:47
ptoohillFrito: https://review.openstack.org/#/c/199954/ 11221:48
ptoohillawe, pep8, why21:50
*** dmk0202 has joined #openstack-lbaas21:53
*** woodster_ has quit IRC21:58
openstackgerritPhillip Toohill proposed openstack/octavia: Network driver should generate network configs  https://review.openstack.org/31587022:03
fnavalmadhu_ak / minwang2 : reviews on this please when you have a chance: https://review.openstack.org/#/c/305525/22:05
*** dmk0202 has quit IRC22:06
fnavalmadhu_ak / minwang2 : https://review.openstack.org/#/c/306182/22:06
fnavalit has a +2 already from our side.  need someone on your side to help review also please22:06
fnavalthanks in advanc22:06
fnavale22:06
*** mixos has joined #openstack-lbaas22:12
*** prabampm has joined #openstack-lbaas22:16
fnavalblogan: need a +2 on this again - fixed the fail that occurred after the gates ran22:21
fnavalthanks!22:21
bloganfnaval: the error message was about no such option "tenant_networks_reachable", i don't see that one being changed22:22
bloganfnaval: added a comment as to where it should change22:27
fnavalhmm.. i think i chnaged it22:29
fnavalat the right place.22:29
fnavalfrom the stacktrace it was throwing; change it in two place22:29
fnavalplaces22:29
fnavalah ok22:29
*** prabampm has quit IRC22:29
fnavalstrange it didn't hit when the gates passed22:30
fnavaloh. ok, i see.22:30
bloganptoohill: test failed after a recheck was done after your change merged22:31
openstackgerritFranklin Naval proposed openstack/neutron-lbaas: Neutron-LBaaS: Fix network_resources path  https://review.openstack.org/31626322:33
fnavalok, it happens in a couple other places there too22:34
ptoohill?22:35
fnavalshould be good to go< i hope.  thanks for the review blogan22:35
ptoohilloh22:35
ptoohillmybad ><22:35
*** yamamoto has joined #openstack-lbaas22:35
fnavalits cool ptoohill - the gates were passing so, i thought it was good to go too22:35
blogani don't know if it got the right version though22:36
blogani can't get a commit hash int he logs22:36
*** ducttape_ has joined #openstack-lbaas22:36
bloganhmmm, it did pass in our gate22:37
blogansoo it should pass in neutron's22:37
*** yamamoto has quit IRC22:38
*** yamamoto has joined #openstack-lbaas22:39
bloganptoohill: oh good found one that did pass in neutron22:42
bloganso should be good22:42
*** yamamoto has quit IRC22:47
*** yamamoto has joined #openstack-lbaas22:48
*** yamamoto has quit IRC22:49
*** catintheroof has quit IRC22:49
*** woodster_ has joined #openstack-lbaas22:58
*** ajmiller has quit IRC23:12
*** ducttape_ has quit IRC23:20
*** minwang2 has quit IRC23:26
*** numans has quit IRC23:26
*** BjoernT has quit IRC23:27
*** cody-somerville has joined #openstack-lbaas23:29
*** reedip__ has joined #openstack-lbaas23:43
*** yamamoto has joined #openstack-lbaas23:49
*** yamamoto has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!