| *** longstaff has left #openstack-lbaas | 00:02 | |
| johnsom | sbalukoff ping | 00:04 |
|---|---|---|
| *** SumitNaiksatam has quit IRC | 00:04 | |
| sbalukoff | johnsom: Pong | 00:06 |
| sbalukoff | johnsom: Er... did you want to chat? | 00:10 |
| johnsom | Yeah, sorry, looked away for a minute | 00:11 |
| johnsom | I looked at the flow order situation. | 00:11 |
| sbalukoff | Yeeees? | 00:11 |
| johnsom | I see why you did what you did. However, I'm not sure it is the right answer. | 00:12 |
| johnsom | I see that Sherif put in that database lookup last summer which invalidates all of that model code. | 00:12 |
| johnsom | I'm wondering if the right answer isn't to remove his database lookup and fix whatever the model issue was he was hitting | 00:12 |
| johnsom | What really puzzled me was this had been fully tested (thus the issue with the member identified) | 00:13 |
| sbalukoff | Possibly. Does that need to be done before shared pools merges, though? Because things are definitely not working correctly right now without the order fixed. | 00:13 |
| sbalukoff | (Even without the shared pools patch) | 00:13 |
| johnsom | So I was pretty puzzled by the re-order | 00:13 |
| rm_work | i'm generally a fan of fixing the core problem and removing workarounds :) | 00:14 |
| sbalukoff | Right, so what's in place is a stop-gap. I get that. Just how much technical debt do I need to solve before this patch can merge? | 00:15 |
| sbalukoff | (It's actually getting really annoying eh...) | 00:15 |
| johnsom | Well, from my perspective the changes you made increased the technical debt as roll back is dirty now | 00:15 |
| johnsom | That is my hangout | 00:15 |
| johnsom | hangup | 00:15 |
| sbalukoff | Doesn't the roll back mark the objects as the 'error' state anyway? | 00:16 |
| johnsom | I would +2 without the reordered flows. | 00:16 |
| sbalukoff | ...except it doesn't work. | 00:16 |
| sbalukoff | Seriously, the stop-gap is better! | 00:16 |
| sbalukoff | Right now, in master, this is broken. | 00:16 |
| johnsom | We can create and delete on master, so it's not totally broken | 00:17 |
| sbalukoff | You can change a pool, or health monitor, or whatever... and watch how nothing changes on the amphora. | 00:18 |
| sbalukoff | Until you do it again. | 00:18 |
| sbalukoff | That is broken. | 00:18 |
| sbalukoff | The re-order means that if you change something, it changes on the amphora... | 00:18 |
| sbalukoff | And if something goes wrong with that change... well, aren't you already going to end up in an error state? | 00:19 |
| sbalukoff | Regardless? | 00:19 |
| sbalukoff | The problem with "fixing" these flows is that we really don't have a good way to test them right now without scenario testing. | 00:21 |
| johnsom | It's not about the error state. It's about the database state for those amphora. The config on the amphora no longer matches the database config. It limits what we can do in the reverts. | 00:21 |
| sbalukoff | ... | 00:21 |
| sbalukoff | You realize that the example I gave means that's already happening right now, during normal operation? | 00:22 |
| johnsom | Either way this is more work. If you want to leave the re-order then the model manipulation should be removed | 00:22 |
| *** jwarendt has joined #openstack-lbaas | 00:23 | |
| sbalukoff | Honestly, I would like to have better reverts... but I also don't think we've thought through how most of these reverts should work anyway. | 00:23 |
| johnsom | Personally I would flip them back, it's as broken as master, open a bug or update the one there and independent of this patch fix it. | 00:23 |
| johnsom | I agree with you on that | 00:24 |
| johnsom | These changes aren't really related to shared pools | 00:24 |
| sbalukoff | They're were only related in the fact that scenario testing is broken, and how are people supposed to test things like updating a member of a shared pool updates all its listeners without it? | 00:25 |
| sbalukoff | I'd prefer to merge this as is, and file a bug to revisit the revert scenario here and come up with a better solution. | 00:25 |
| sbalukoff | In my mind, it's not acceptable for things to break like this during *normal* operation. | 00:26 |
| johnsom | Are you saying this won't make it through the gate without those flow re-orders? | 00:26 |
| sbalukoff | When you run into problems talking to an amphora or whatever... it's more acceptable for things to break. :/ | 00:26 |
| sbalukoff | No, it will make it through the gate-- look at the tempest tests that are running right now! | 00:26 |
| johnsom | Because I am pretty sure patches have been getting in all day. | 00:26 |
| johnsom | Right. | 00:26 |
| sbalukoff | But our neutron-lbaas tempest tests are apparently not very thorough if they're not catching this. :/ | 00:27 |
| sbalukoff | (That is to say, neutron-lbaas's database and octavia's database get updated when, say, a change to a health monitor happens... but the amphora does not, presently.) | 00:27 |
| johnsom | That is true too. | 00:27 |
| johnsom | Yeah, with that hack in listerupdate it is causing a lot of problems. I see that. | 00:28 |
| sbalukoff | Yep. | 00:28 |
| sbalukoff | So... I'll revert the change in task order if you really want me to, to get this patch merged... but then fixing this needs to be a high-priority item. | 00:29 |
| sbalukoff | (Again, I think it's personally better for the 'revert' case to be somewhat broken right now, instead of the normal workflow case.) | 00:30 |
| johnsom | It's just the re-order is wrong and not related to this patch. | 00:32 |
| rm_work | yeah I'm torn | 00:33 |
| johnsom | Same here. | 00:33 |
| rm_work | but tend to want to side with johnsom which i think is actually beneficial to you in a way sbalukoff -- undo the reordering in your patch, and we can fix it as a clear separate CR | 00:33 |
| johnsom | Basically the fix, will come back and flip them back along with addressing whatever the other hack issue was | 00:34 |
| rm_work | and you can stop cleaning up all of our technical debt as a prereq | 00:34 |
| sbalukoff | :) | 00:34 |
| rm_work | which IS definitely unfair | 00:34 |
| *** jwarendt has quit IRC | 00:34 | |
| sbalukoff | Ok... I'll roll things back. Do you want me to put the re-order stop-gap into another patch for now, or are we not going to do that at all? (ie. leave this broken in master?) | 00:34 |
| *** jwarendt has joined #openstack-lbaas | 00:35 | |
| sbalukoff | Again, this stuff is really hard to fix without a good way to test it. | 00:35 |
| johnsom | Let's leave master broken, but I will start another patch and try to figure this out. | 00:35 |
| rm_work | we SHOULD do it | 00:35 |
| sbalukoff | johnsom: Sounds good. | 00:35 |
| rm_work | but it doesn't have to be done by you right now | 00:35 |
| *** doug-fis_ has joined #openstack-lbaas | 00:36 | |
| johnsom | Well, there is the old elbow grease manual testing which is how I did it originally | 00:36 |
| sbalukoff | Ok, give me 15 minutes or so and I'll have those re-orderings rolled back. | 00:36 |
| rm_work | yeah i have been pushing internally for dedicating resources to getting scenario tests actually running on octavia (re, franklin basically) | 00:36 |
| rm_work | hopefully we'll get there | 00:36 |
| sbalukoff | johnsom: Hah! That's how I figured out a re-order would fix things for the normal workflow. | 00:36 |
| rm_work | yeah having to manual test EVERY CHANGE before we workflow is annoying | 00:36 |
| sbalukoff | rm_work: Yeah, I have high hopes for what he produces. | 00:36 |
| johnsom | sbalukoff Thanks. That was my last concern, so we should be good to go | 00:36 |
| rm_work | and slows velocity a ton because people don't want to +1 without testing >_< | 00:37 |
| rm_work | because we HAVE to test before +A | 00:37 |
| rm_work | (i meant +A not +1) | 00:37 |
| sbalukoff | johnsom: I appreciate your efforts on this, eh! | 00:37 |
| sbalukoff | rm_work: Agreed! | 00:37 |
| johnsom | Yeah, we put Min on starting scenario tests for Octavia, but we all got confused on the framework to use; tempest, tempest-lib, rally etc. So we stopped work on it | 00:37 |
| rm_work | so many tests *almost* through zuul | 00:37 |
| sbalukoff | johnsom: And I really do appreciate you voicing your concerns and not (always) letting me push you in directions that are not the best for this project. ;) | 00:38 |
| sbalukoff | Well... | 00:38 |
| rm_work | going to be afk a bit -- but will look at what you have tonight sbalukoff and even run some tests if it's got a +2 | 00:38 |
| johnsom | Thanks for being open to a constructive conversation | 00:38 |
| rm_work | maybe can get this finished out before the end of the week | 00:38 |
| sbalukoff | So, I know we've hashed out this question a bazillion times... but, given it seems that using tempest means we have to copy-paste a crap ton of code that will eventually turn into cruft we all hate, does rally have a better story here? | 00:39 |
| johnsom | Oh please don't make my head explode right now.... | 00:39 |
| rm_work | I don't think so -- whichever way you go, you need to write models for the stuff you're testing, at least as far as i can comprehend | 00:39 |
| sbalukoff | johnsom: I'll go ahead and open a bug for these re-ordering / revert problems we have right now, as I've gotten a pretty good look at them in the last couple of weeks. | 00:40 |
| rm_work | at least per the testing patterns i've done in the past | 00:40 |
| johnsom | Copying code in is really, really, really bad. I will say that. | 00:40 |
| sbalukoff | Unless you're already on it. | 00:40 |
| rm_work | yeah we need to ditch all the "managed copy-paste" tempest stuff | 00:40 |
| *** doug-fish has quit IRC | 00:40 | |
| rm_work | honestly I am not sure why we can't just import from tempest | 00:40 |
| johnsom | sbalukoff Go ahead. You can assign it to me as well, I will work on it. | 00:40 |
| rm_work | instead of copying it into tree | 00:40 |
| sbalukoff | rm_work: I know fnaval is working on that for us. I'm hoping he's successful in minimizing the cruft. | 00:40 |
| rm_work | unless it needs to CHANGE, and then it's not really just a copy/paste at that point | 00:40 |
| johnsom | I think that is what cedrick is working on for neutron-lbaas | 00:41 |
| johnsom | https://review.openstack.org/#/c/273817/ | 00:41 |
| rm_work | well the eventstreamer breakage fix will be merged momentarily, which is good | 00:41 |
| sbalukoff | johnsom: I appreciate that! (I'm under a lot of pressure to get this L7 code to a state where y'all can start reviewing *all* of it, so not having to fix that myself is a very welcome thing for me right now!) | 00:41 |
| rm_work | and tests for your active/passive fix are at least out of queue | 00:42 |
| rm_work | lol and your revert fix has 3 +2 | 00:43 |
| sbalukoff | Ok, gonna ignore chat for a bit to get this next patchset done... | 00:43 |
| rm_work | johnsom: is that still a relevant change? | 00:43 |
| rm_work | I assume so | 00:43 |
| rm_work | but i'm not sure how to effectively test it | 00:43 |
| johnsom | Yes, it depends on the failover flow patch, so has been sitting for a while | 00:43 |
| rm_work | tempted to just +A and roll the dice, but that feels a little bit irresponsible >_> | 00:43 |
| johnsom | If it maked you feel better, it has been +A'd before | 00:44 |
| rm_work | ah wasn't actually sure of the order | 00:44 |
| rm_work | lol | 00:44 |
| rm_work | it ... kinda does :P | 00:44 |
| openstackgerrit | Merged openstack/octavia: Fix event_queue entry in setup.cfg from EventStreamer break https://review.openstack.org/276451 | 00:44 |
| rm_work | johnsom: you know you want it: https://review.openstack.org/#/c/275990/ | 00:50 |
| rm_work | and also https://review.openstack.org/#/c/276368/ :P | 00:50 |
| rm_work | blogan: ^^ | 00:50 |
| johnsom | rm_work I was just waiting for the gates so I could look in the logs | 00:50 |
| rm_work | johnsom: testing out your new patch | 00:51 |
| rm_work | johnsom: you'll find some stuff markedly absent :) | 00:51 |
| rm_work | it was o-cw | 00:51 |
| rm_work | in the latest CR it is SO clean :) | 00:51 |
| johnsom | Yep, I am all too familiar with those log messages (thus the two bugs I opened) | 00:51 |
| rm_work | http://logs.openstack.org/68/276368/3/check/gate-neutron-lbaasv2-dsvm-scenario/06c7076/logs/screen-o-cw.txt.gz | 00:51 |
| rm_work | the only other thing is the new key stuff we added in the first one... | 00:52 |
| rm_work | which just makes it more officially valid | 00:52 |
| johnsom | Oh, there was a separate bug for the context issue. | 00:52 |
| rm_work | though all that will be meaningless when we switch to Anchor tho | 00:53 |
| johnsom | This was SSLContext: https://bugs.launchpad.net/octavia/+bug/1494417 | 00:53 |
| openstack | Launchpad bug 1494417 in octavia "REST driver - A true SSLContext object is not available" [Low,In progress] - Assigned to Adam Harwell (adam-harwell) | 00:53 |
| rm_work | yes | 00:53 |
| rm_work | it's marked | 00:53 |
| johnsom | This was subjectAlt: https://bugs.launchpad.net/octavia/+bug/1494420 | 00:53 |
| openstack | Launchpad bug 1494420 in octavia "REST Driver TLS - Certificate has no `subjectAltName" [Low,Confirmed] - Assigned to Carlos Garza (carlos-garza) | 00:53 |
| rm_work | yeah | 00:53 |
| rm_work | they're both on their respective CRs | 00:53 |
| johnsom | Nope, both have the same bug number on them | 00:54 |
| rm_work | err | 00:54 |
| johnsom | Oh, wait, wrong windows | 00:54 |
| rm_work | :P | 00:54 |
| johnsom | Strange, yeah, ok, you commented the same, it didn't mark it in launchpad | 00:55 |
| rm_work | yeah <_< | 00:55 |
| rm_work | no clue why not | 00:55 |
| johnsom | I have had that happen to me a few times too | 00:55 |
| johnsom | I think on yours, gerrit ignores the stuff below the change-id | 00:56 |
| rm_work | crap I shouldn't have let xgerman's anchor plugin through yet | 00:56 |
| rm_work | he didn't actually fully implement the API for it | 00:56 |
| rm_work | so it won't work :/ | 00:56 |
| rm_work | johnsom: i was wondering if that was the issue | 00:57 |
| rm_work | is it worth fixing the commit message? :/ | 00:57 |
| rm_work | i think I'll just update the bug | 00:57 |
| johnsom | Yeah, just the bug. You don't want to wait for zuul again | 00:58 |
| rm_work | exactly T_T | 00:58 |
| rm_work | aight, AFK for a bit | 00:59 |
| rm_work | back later | 00:59 |
| rm_work | oh wait | 00:59 |
| rm_work | was gonna finish this test | 00:59 |
| rm_work | which will let me +2 you | 01:00 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Shared pools support https://review.openstack.org/256369 | 01:00 |
| sbalukoff | johnsom, rmwork ^^^^ task order should be back to master in that. | 01:01 |
| rm_work | k | 01:01 |
| rm_work | i will look at that later tonight | 01:01 |
| *** chlong has joined #openstack-lbaas | 01:01 | |
| *** ducttape_ has joined #openstack-lbaas | 01:01 | |
| sbalukoff | I think it was the health_monitor, listener, pool and member flows which are the ones affected. Please let me know if you find any others that need attention. | 01:01 |
| * sbalukoff goes off to file a bug. | 01:01 | |
| sbalukoff | Thanks, rm_work! | 01:02 |
| *** bana_k has quit IRC | 01:02 | |
| johnsom | Thanks! | 01:02 |
| sbalukoff | No problem. | 01:02 |
| rm_work | np sbalukoff | 01:02 |
| rm_work | cool johnsom, WFM now | 01:02 |
| rm_work | +2'd | 01:03 |
| rm_work | np sbalukoff, thank me again when I actually +2 it :P | 01:03 |
| johnsom | Awesome | 01:03 |
| rm_work | right now all I have to give is empty promises and broken dreams | 01:03 |
| sbalukoff | rm_work: That's my breakfast every morning. | 01:04 |
| rm_work | Hearty. Hopefully plenty of fiber. | 01:04 |
| rm_work | bbl | 01:05 |
| blogan | rm_work: does taht review, the ssl context one, just install that lib? | 01:05 |
| blogan | and is it in global reqs? | 01:05 |
| rm_work | blogan: two of the three are in global reqs | 01:05 |
| rm_work | and yes that is all it has to do | 01:05 |
| rm_work | because pyopenssl injects itself into urllib if the right stuff exists | 01:05 |
| blogan | okay | 01:05 |
| rm_work | take a look at the scenario test o-cw logs | 01:05 |
| blogan | i did | 01:05 |
| rm_work | yeah | 01:06 |
| blogan | they need to have debug turned on | 01:06 |
| blogan | but yeah its nice they dont have that SSLContext shit in there | 01:06 |
| rm_work | soooo i don't know if global-reqs will kick it back tho for the third req | 01:06 |
| rm_work | but i say we try to merge it and find out :P | 01:06 |
| blogan | it'll fail devstack if its in global reqs though bc of the sync requirements does i thought | 01:07 |
| rm_work | maybe? | 01:07 |
| rm_work | in which case, woot | 01:07 |
| rm_work | seems to be ok | 01:07 |
| rm_work | blogan: for context: http://stackoverflow.com/a/29202163/4655717 | 01:08 |
| blogan | excellent | 01:08 |
| johnsom | Yeah, I was surprised to see that debug wasn't on for the gate jobs... | 01:09 |
| rm_work | that's a one-liner iniset right? | 01:09 |
| blogan | wonder if that'll work with my local clients | 01:09 |
| rm_work | shouldn't have any problems | 01:09 |
| rm_work | we already pulled in pyopenssl, and the other two are minor libs | 01:09 |
| blogan | welp since i stack locally, i'll get it soon enough :) | 01:09 |
| rm_work | heh | 01:09 |
| johnsom | Yeah, if there is a package in there that isn't in global req's it will get kicked out | 01:10 |
| rm_work | we'll see | 01:10 |
| rm_work | ah but that one depends on https://review.openstack.org/#/c/275990/ so need that to +A too | 01:10 |
| rm_work | and now, for serious, I am going afk for a while :P | 01:11 |
| openstackgerrit | Michael Johnson proposed openstack/octavia: Updates the failover flow for active/standby https://review.openstack.org/253724 | 01:15 |
| johnsom | Darn, ptoohill had a good point, I should have updated the taskflow version in requirements.txt. It worked fine on my fresh build, but might bite others. | 01:15 |
| ptoohill | it bit me, but rm_work brought up global requirements, im not sure what the right way is :P | 01:18 |
| *** Aish has quit IRC | 01:20 | |
| johnsom | Yeah, I saw the update where they added it to the upper constraints file, but I didn't notice that the main global requirements is still at 1.25 | 01:22 |
| johnsom | Ok, catch you all tomorrow | 01:24 |
| *** ducttape_ has quit IRC | 01:24 | |
| sbalukoff | johnsom: There's your bug, eh: https://bugs.launchpad.net/octavia/+bug/1542120 | 01:27 |
| openstack | Launchpad bug 1542120 in octavia "Changes made via API do not immediately get pushed to amphorae" [Undecided,New] | 01:27 |
| *** chlong has quit IRC | 01:34 | |
| *** chlong has joined #openstack-lbaas | 01:35 | |
| *** piet has joined #openstack-lbaas | 01:38 | |
| *** allan_h has joined #openstack-lbaas | 01:38 | |
| *** _cjones_ has quit IRC | 01:40 | |
| *** allan_h has quit IRC | 01:40 | |
| *** raginbajin has quit IRC | 01:42 | |
| *** bharathm has joined #openstack-lbaas | 01:44 | |
| *** raginbajin has joined #openstack-lbaas | 01:46 | |
| *** bharathm has quit IRC | 01:48 | |
| *** bharathm has joined #openstack-lbaas | 01:49 | |
| *** armax has joined #openstack-lbaas | 01:51 | |
| *** doug-fis_ has quit IRC | 01:51 | |
| *** doug-fish has joined #openstack-lbaas | 01:52 | |
| *** doug-fis_ has joined #openstack-lbaas | 01:53 | |
| *** Aish has joined #openstack-lbaas | 01:53 | |
| *** doug-fish has quit IRC | 01:57 | |
| *** madhu_ak_ has quit IRC | 01:57 | |
| *** ducttape_ has joined #openstack-lbaas | 02:03 | |
| *** Aish has quit IRC | 02:08 | |
| *** davidlenwell has quit IRC | 02:18 | |
| *** davidlenwell has joined #openstack-lbaas | 02:19 | |
| *** yamamoto_ has joined #openstack-lbaas | 02:21 | |
| *** davidlenwell has quit IRC | 02:23 | |
| *** davidlenwell has joined #openstack-lbaas | 02:27 | |
| *** piet has quit IRC | 02:27 | |
| rm_work | dependent patch has +A but no love for https://review.openstack.org/#/c/275990/ ? lol | 02:49 |
| *** Aish has joined #openstack-lbaas | 03:00 | |
| rm_work | johnsom: you around? | 03:01 |
| rm_work | or sbalukoff or ptoohill | 03:01 |
| ptoohill | rm_work: I'm here | 03:02 |
| rm_work | is there any documentation for why taskflow 1.26 is needed? was there a bug or something I can reference? we need to bump it in global-requirements, just figuring out a good commit message, they like completeness | 03:02 |
| ptoohill | The depends on | 03:02 |
| ptoohill | That bug was merged into 1.26, this patch cannot function without it | 03:02 |
| rm_work | I mean, I know that we need it | 03:03 |
| rm_work | but | 03:03 |
| rm_work | I would like some sort of written reference that SHOWS why we need it | 03:03 |
| ptoohill | https://review.openstack.org/#/c/246051/ | 03:03 |
| rm_work | thanks | 03:03 |
| ptoohill | urm | 03:03 |
| rm_work | that should work | 03:03 |
| rm_work | at least it's solid | 03:03 |
| *** doug-fis_ has quit IRC | 03:03 | |
| *** doug-fish has joined #openstack-lbaas | 03:04 | |
| ptoohill | Well there's no description there, but this was in the DependsOn in the patch in question. We need it because it fixes a bug with decider graphs/flows | 03:04 |
| rm_work | yeah | 03:04 |
| ptoohill | i dont' quite remember specifics off hand | 03:04 |
| rm_work | https://review.openstack.org/276549 | 03:04 |
| ptoohill | works for me | 03:05 |
| rm_work | I have done this before so I KNOW they will ask questions like this | 03:05 |
| ptoohill | Thank you | 03:05 |
| rm_work | and it's a lot faster if we just give them the info up front | 03:05 |
| ptoohill | 'because we want it.' | 03:05 |
| rm_work | apparently johnsom's patch *will* fail to merge if the deps don't match global-req *exactly* | 03:06 |
| rm_work | so we need this in first | 03:06 |
| ptoohill | ah, k | 03:06 |
| rm_work | and I guess I need to get them to add ndg-httpsclient too | 03:06 |
| rm_work | which will be a lot less simple than a bump by 0.1 | 03:06 |
| ptoohill | :( | 03:07 |
| *** doug-fish has quit IRC | 03:08 | |
| *** Aish has left #openstack-lbaas | 03:13 | |
| *** yuanying_ has joined #openstack-lbaas | 03:18 | |
| *** yuanying has quit IRC | 03:21 | |
| *** doug-fish has joined #openstack-lbaas | 03:24 | |
| *** neelashah has joined #openstack-lbaas | 03:27 | |
| *** doug-fish has quit IRC | 03:28 | |
| *** piet has joined #openstack-lbaas | 03:33 | |
| *** ducttape_ has quit IRC | 03:35 | |
| *** ducttape_ has joined #openstack-lbaas | 03:37 | |
| xgerman | rm_work what did I forget with Anchor — it worked fine in my devstack? | 03:39 |
| blogan | lov given | 03:39 |
| *** yuanying has joined #openstack-lbaas | 03:42 | |
| *** fnaval has quit IRC | 03:44 | |
| *** yuanying_ has quit IRC | 03:44 | |
| *** piet has quit IRC | 03:45 | |
| rm_work | xgerman: i am not sure HOW it worked -- you are completely missing implementation for one of the methods in the interface | 03:45 |
| rm_work | unless it wasn't actually used somehow? | 03:45 |
| rm_work | but otherwise I'm not sure how the key and CSR were being generated | 03:46 |
| xgerman | oh, the CSR will be generated by the code in the local generator | 03:46 |
| rm_work | errrr | 03:46 |
| rm_work | so, the way it works | 03:47 |
| xgerman | so I inherit from the local generator and just do the signing with Anchor | 03:47 |
| rm_work | AH | 03:47 |
| rm_work | ok I see | 03:47 |
| rm_work | you inherit | 03:47 |
| rm_work | that's ... lulzy | 03:47 |
| rm_work | I guess it works | 03:47 |
| rm_work | I was wondering how that would ever have worked for you | 03:48 |
| rm_work | (that is how) | 03:48 |
| rm_work | also: https://review.openstack.org/276554 | 03:48 |
| rm_work | and https://review.openstack.org/#/c/276549/ | 03:48 |
| rm_work | blogan / xgerman | 03:48 |
| rm_work | the second should be a no-brainer | 03:48 |
| rm_work | the first I need to see what people's thoughts are | 03:48 |
| johnsom | rm_work the taskflow bug was: https://bugs.launchpad.net/taskflow/+bug/1479466 | 03:48 |
| openstack | Launchpad bug 1479466 in octavia "The needs to treat subflows as standalone entity" [High,Fix released] | 03:48 |
| rm_work | I assume there will be a general sense of distrust about adding another completely new lib | 03:49 |
| rm_work | thanks johnsom | 03:49 |
| xgerman | rm_work I give it slim chances — I think I hacked the https context somehow that it didn’t but should work | 03:49 |
| xgerman | also added jharlow to the task flow one | 03:51 |
| johnsom | Still don't understand why the gate would block it, the global requirements have >= and upper constraint == 1.26 | 03:52 |
| rm_work | yeah well | 03:52 |
| rm_work | me either | 03:52 |
| rm_work | but | 03:52 |
| rm_work | [20:59:39] <clarkb>rm_work: has to match exactly | 03:52 |
| openstackgerrit | Brandon Logan proposed openstack/neutron-lbaas: WIP - Genericize octavia event handler https://review.openstack.org/276557 | 03:53 |
| rm_work | really, you're doing that already? | 03:53 |
| rm_work | I was going to wait for someone to ask at least | 03:53 |
| rm_work | lol | 03:53 |
| rm_work | I guess it looks like that was a pretty simple fix | 03:55 |
| blogan | rm_work: i had started on it weeks ago and just hadn't pushed the code up | 03:58 |
| blogan | so not sure exactly if it works right now, pretty sure it needs tests updated | 03:59 |
| *** localloop127 has joined #openstack-lbaas | 04:01 | |
| rm_work | woo, hynek fixed pem | 04:01 |
| rm_work | so now we could theoretically use it | 04:01 |
| rm_work | and remove the manual string parsing we do for cert loading/splitting | 04:02 |
| blogan | you mean the low level stuff? | 04:04 |
| * blogan ducks | 04:04 | |
| *** jwarendt has quit IRC | 04:04 | |
| crc32|znc | wow | 04:05 |
| crc32|znc | splitting a string is considered too low level. | 04:06 |
| blogan | shhh | 04:06 |
| crc32|znc | what library do you plane to use to split PEMs this time. | 04:06 |
| *** yuanying has quit IRC | 04:06 | |
| blogan | hook, line, sinker | 04:06 |
| crc32|znc | for real. The last pemsplitter didn't even have a working setup.py | 04:07 |
| rm_work | "pem" | 04:07 |
| *** yuanying has joined #openstack-lbaas | 04:07 | |
| blogan | i like perm splitters | 04:08 |
| crc32|znc | and when that pem splitter breaks don't forget to baby sit a patch and submit a fix to the pem splitter library frame work. | 04:08 |
| *** fnaval has joined #openstack-lbaas | 04:08 | |
| *** ducttape_ has quit IRC | 04:08 | |
| *** neelashah has quit IRC | 04:18 | |
| xgerman | didn’t realize rm_work was feeling that strongly about my workaround: https://review.openstack.org/#/c/276368/ | 04:18 |
| rm_work | lol | 04:20 |
| rm_work | I would like to do things the right way generally :P | 04:20 |
| rm_work | but also, that spam is super annoying T_T | 04:20 |
| rm_work | I guess we could ignore all warnings from urllib <_< | 04:21 |
| rm_work | but, we should just do it the right way | 04:21 |
| xgerman | yeah, agreed | 04:21 |
| xgerman | also in other new Michael + I will be in San Antonio in May | 04:23 |
| xgerman | 5/15-18 - in case you need to skip town :-) | 04:23 |
| blogan | for what? | 04:25 |
| * blogan hears the air raid sirens already | 04:25 | |
| xgerman | some HP conference | 04:25 |
| xgerman | they decided San Antonio would be nice to fly a 100 HP people to | 04:28 |
| rm_work | :P | 04:28 |
| rm_work | well, I'm always down for BBQ | 04:28 |
| blogan | more bbq! | 04:28 |
| rm_work | W^_^ | 04:28 |
| xgerman | yeah, so are we :-) | 04:29 |
| blogan | at least you're coming in the spring when its not so hot | 04:40 |
| blogan | oh wait, its texas | 04:40 |
| blogan | it'll be 100 | 04:40 |
| *** links has joined #openstack-lbaas | 04:43 | |
| sbalukoff | Heh! | 04:50 |
| openstackgerrit | Merged openstack/octavia: Add SubjectAltName and KeyUsage for localcertgen https://review.openstack.org/275990 | 04:53 |
| openstackgerrit | Merged openstack/octavia: Fix for ssl context wrapper spam https://review.openstack.org/276368 | 04:57 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Add L7 database structures https://review.openstack.org/265430 | 04:59 |
| *** localloop127 has quit IRC | 05:05 | |
| *** crc32 has joined #openstack-lbaas | 05:05 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Update repos for L7 objects / methods https://review.openstack.org/265529 | 05:08 |
| *** amotoki has joined #openstack-lbaas | 05:11 | |
| *** numan_ has quit IRC | 05:12 | |
| *** piet has joined #openstack-lbaas | 05:32 | |
| sbalukoff | Blah... probably one of the more annoying factors you have to watch for when maintaining a long chain of giant patches are to find those areas where the auto-merge process that happens when you rebase fails to do the right thing. :P Especially if the error introduced by this is subtle and wouldn't be caught by an existing test. :P | 05:37 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Add L7 database structures https://review.openstack.org/265430 | 05:37 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Add L7 database structures https://review.openstack.org/265430 | 05:38 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Update repos for L7 policy / methods https://review.openstack.org/265529 | 05:44 |
| *** numan_ has joined #openstack-lbaas | 05:47 | |
| rm_work | wtf how did that second match merge without ndg-httpsclient in global-reqs >_> | 05:53 |
| rm_work | weeeeird | 05:53 |
| rm_work | anywho, I think this is good to go, someone else had +2'd in the past right? https://review.openstack.org/#/c/253724/ | 05:55 |
| rm_work | ah, xgerman had | 05:55 |
| *** woodster_ has quit IRC | 05:56 | |
| xgerman | Ok, +2 +a | 05:57 |
| *** piet has quit IRC | 05:59 | |
| *** prabampm has joined #openstack-lbaas | 06:00 | |
| rm_work | yeah now i get to test sbalukoff's stuff | 06:01 |
| sbalukoff | Yay? | 06:01 |
| sbalukoff | ;) | 06:01 |
| sbalukoff | Thank you for doing that, rm_work! | 06:01 |
| rm_work | https://review.openstack.org/#/c/256369/ is first? | 06:01 |
| sbalukoff | Correct. | 06:02 |
| sbalukoff | The others in the chain you needn't worry about tonight, eh. | 06:02 |
| rm_work | oh man i have to test this stuff manually with curl don't I >_> | 06:04 |
| sbalukoff | rm_work: yeah. :/ | 06:05 |
| sbalukoff | rm_work: well.... | 06:05 |
| sbalukoff | actually, you could also put the neutron-lbaas shared pools patch and cli patch on your devstack. | 06:06 |
| sbalukoff | That works too. | 06:06 |
| rm_work | heh | 06:06 |
| rm_work | might do that | 06:06 |
| rm_work | well | 06:06 |
| sbalukoff | They're listed at the top here: https://etherpad.openstack.org/p/lbaas-l7-todo-list | 06:06 |
| rm_work | eh, already started stacking | 06:06 |
| rm_work | i'll figure out the curl stuff | 06:06 |
| sbalukoff | also keep in mind our discussion about task ordering . At this point, when you ask for a pool to get updated... do it twice. | 06:07 |
| sbalukoff | Because of the bug in master. :P | 06:07 |
| rm_work | lol | 06:07 |
| rm_work | right T_T | 06:07 |
| *** yuanying_ has joined #openstack-lbaas | 06:08 | |
| sbalukoff | rm_work: Maybe helpful: https://gist.github.com/anonymous/f59d96918f3103ad5651 | 06:09 |
| *** yamamoto_ has quit IRC | 06:09 | |
| xgerman | We will have Min check it out on | 06:09 |
| xgerman | Our end... | 06:09 |
| sbalukoff | Obviously, replace UUIDs as necessary. | 06:09 |
| rm_work | so, with big patchsets, I am sometimes a fan of "just merge it, and hotfix the issues" <_< | 06:10 |
| rm_work | if it looks like it should be working 95% | 06:10 |
| rm_work | we're still a ways off our feature freeze, and even then have even longer for bugfixes... | 06:10 |
| xgerman | Don't try to kill Johnson | 06:11 |
| rm_work | heh | 06:11 |
| sbalukoff | Well... I feel the same way so long as people have given it a good run through some manual scenarios. | 06:11 |
| rm_work | yeah | 06:11 |
| sbalukoff | I think this patch has seen quite a bit of that. :) | 06:11 |
| rm_work | i'd like to see basic stuff working | 06:11 |
| sbalukoff | Yep. | 06:11 |
| rm_work | but i'm not going to try to hit every edge case manually | 06:11 |
| *** yuanying has quit IRC | 06:11 | |
| sbalukoff | Right. | 06:12 |
| rm_work | and yes, that gist is exactly what i was considering asking you for :P | 06:12 |
| sbalukoff | I look forward to being able to do actual scenario tests. | 06:12 |
| sbalukoff | Against Octavia directly. | 06:12 |
| sbalukoff | I'm pretty jazzed about the work fnaval is doing. :) | 06:13 |
| fnaval | i hope i can get it done by tomorrow (today, it seems) | 06:13 |
| *** yuanying_ has quit IRC | 06:13 | |
| sbalukoff | Wow! | 06:13 |
| fnaval | or at least something working | 06:13 |
| sbalukoff | I was actually expecting it to take at least another week. XD | 06:14 |
| *** yuanying has joined #openstack-lbaas | 06:14 | |
| sbalukoff | Given how much you've had to sift through with the tempest code stuff. | 06:14 |
| fnaval | ah could be if i run into more issues | 06:14 |
| fnaval | there's a lot of layers there | 06:14 |
| *** yuanying has quit IRC | 06:15 | |
| rm_work | sometimes I kinda just wish all arguments were keyword arguments (or at least treated that way, since python lets you do that) | 06:18 |
| rm_work | makes things super clear when you don't know the signature of a function and aren't in an IDE | 06:19 |
| rm_work | lol, just noticed "Copyright 2016 Blue Box, an IBM Company" | 06:23 |
| rm_work | is that actually legally in the name now? :P | 06:24 |
| sbalukoff | Yep. | 06:28 |
| rm_work | do they not realize that is REALLY WEIRD | 06:28 |
| *** yuanying has joined #openstack-lbaas | 06:28 | |
| sbalukoff | Though, I was just transferred to the Open Source Networking Group within IBM. So, I don't really know whether I'm officially a Blue Box employee anymore. Nor do I have any idea what the copyright line should look like. So... I'mma go with this until someone tells me differently. | 06:29 |
| sbalukoff | Haha! Yeah... | 06:29 |
| sbalukoff | I do recall like 2 weeks after the merger they told us to update all our e-mail signatures with that, as well as to mention that as the official company name whenever asked. | 06:30 |
| *** reedip is now known as reedip_away | 06:30 | |
| sbalukoff | And yes, as part of the acquisition, they did rename the company to that. | 06:30 |
| rm_work | I am sometimes tempted to put something like "Copyright 2016 Santa Claus" | 06:30 |
| sbalukoff | (I remember reading the paperwork and grinning when I saw.) | 06:30 |
| sbalukoff | Eh... | 06:30 |
| rm_work | because I don't think these copyright notices actually matter, because we give up actual ownership when we contribute due to the licensing of the project as a whole and the contributor agreement, AFAIK | 06:31 |
| rm_work | but IANAL <_< | 06:31 |
| sbalukoff | It's all apache2 licensed code anyway, and we've got git history which will show what code was written by who. I think the copyright line doesn't matter that much. | 06:31 |
| rm_work | ^^ yes | 06:31 |
| sbalukoff | You should have seen the hand-wringing that happened when I asked the IBM laywers to look over the legal paperwork that transfers the Octavia trademark to the OpenStack Foundation. Seriously, like 2 weeks spent on the wording of one sentence (in this 5-sentence document) that didn't make any substantial difference. | 06:33 |
| sbalukoff | Speaking of which.. I haven't heard back from the OSF people on this in a while... I should check in with them. | 06:33 |
| rm_work | and to think I was considering law school... | 06:33 |
| sbalukoff | (Though, given the speed of the USPTO, it'll probably transfer sometime in late 2036) | 06:33 |
| sbalukoff | Haha! | 06:34 |
| sbalukoff | rm_work: At least computers usually make sense and do what you instruct them to do. ;) | 06:34 |
| rm_work | (might explain why I am so pedantic) | 06:34 |
| rm_work | urg, you're doing de-duplication here which is great but it's STILL duplicated (across files) in some cases | 06:35 |
| rm_work | pain | 06:35 |
| rm_work | like _get_db_listener and some of these test_and_set methods | 06:36 |
| openstackgerrit | Merged openstack/octavia: Updates the failover flow for active/standby https://review.openstack.org/253724 | 06:36 |
| rm_work | not sure a better way to do that tho | 06:36 |
| *** crc32 has quit IRC | 06:36 | |
| rm_work | yeah so many dupes of _test_lb_and_listener_statuses | 06:40 |
| *** yamamoto_ has joined #openstack-lbaas | 06:44 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/neutron-lbaas: Use tempest-lib's floating_ips_client https://review.openstack.org/275158 | 06:44 |
| sbalukoff | rm_work: Those methods are all slightly different... | 06:45 |
| sbalukoff | rm_work: They're specific to the controller they're in. :P | 06:45 |
| rm_work | urgh | 06:45 |
| sbalukoff | rm_work: But yes... this probably *could* be combined, in a helper function. | 06:45 |
| sbalukoff | Maybe a later optimization? | 06:45 |
| rm_work | yeah that's fine | 06:45 |
| sbalukoff | Dang, I should get some dinner... | 06:46 |
| sbalukoff | HTTP_HEADER_REGEX = "^[a-zA-Z0-9\\!\\#\\$\\%\\&'\\*\\+\\-\\.\\^\\_\\`\\|\\~]+$" | 06:46 |
| sbalukoff | The more you know, eh. | 06:46 |
| sbalukoff | Probably don't need that many back-slashes... let me try killing some... | 06:47 |
| rm_work | urgh i don't know if i can finish reviewing this tonight, my eyes are starting to blur | 06:48 |
| rm_work | might have to finish tomorrow morning | 06:48 |
| rm_work | on the plus side, your review is obviating my need to take sleep aids <_< | 06:49 |
| sbalukoff | HAHA | 06:49 |
| sbalukoff | Sleep well, man. | 06:49 |
| rm_work | i've got this devstack instance set up though and waiting to make a shared pool... | 06:49 |
| rm_work | i wonder if i can do it | 06:49 |
| rm_work | curl http://localhost:9876/v1/loadbalancers | 06:54 |
| rm_work | ^^ is returning nothing | 06:54 |
| rm_work | I feel like i remember this issue | 06:54 |
| rm_work | I need to send auth maybe? | 06:54 |
| rm_work | but i feel like there isn't actually auth? | 06:54 |
| sbalukoff | There isn't auth. | 06:54 |
| rm_work | so.... | 06:54 |
| sbalukoff | If you don't have any loadbalancers... | 06:55 |
| rm_work | there is one | 06:55 |
| sbalukoff | Hmmm... | 06:55 |
| rm_work | it shows up with "neutron lbaas-loadbalancer-list" | 06:55 |
| rm_work | because i created the LB itself with neutron | 06:55 |
| sbalukoff | What's your octavia DB look like? | 06:55 |
| rm_work | and I see the VMs octavia made | 06:55 |
| sbalukoff | Yeah... | 06:55 |
| sbalukoff | You should be getting something. | 06:55 |
| rm_work | table shows one LB | 06:56 |
| rm_work | and that it has a damned underscore in load_balancer | 06:56 |
| rm_work | *shakes fist* | 06:56 |
| rm_work | i think the LB is not on my project | 06:56 |
| rm_work | need to remember how to send that with my request | 06:57 |
| *** prabampm has quit IRC | 06:57 | |
| rm_work | got it | 06:57 |
| *** bharathm has quit IRC | 06:57 | |
| rm_work | yeah had to pass X-Project-Id | 06:57 |
| sbalukoff | Aah. | 06:58 |
| rm_work | is it supposed to list the pool in the loadbalancer json? | 06:59 |
| rm_work | or not | 06:59 |
| rm_work | i guess not | 07:00 |
| *** bharathm has joined #openstack-lbaas | 07:03 | |
| *** links has quit IRC | 07:04 | |
| rm_work | whelp I think I might just +2 this | 07:05 |
| rm_work | I got through most of the code and didn't see anything hideous | 07:05 |
| rm_work | and i managed to get a pool to be on two listeners | 07:05 |
| rm_work | sooooo i'm pretty sold | 07:05 |
| rm_work | OH GOD IT'S IN MERGE CONFLICT | 07:07 |
| rm_work | T_T | 07:07 |
| rm_work | sbalukoff: whyyyyy | 07:07 |
| sbalukoff | Dammit... | 07:07 |
| rm_work | i guess active/standby | 07:07 |
| sbalukoff | Probably the failover flow stuff. | 07:07 |
| rm_work | hopefully it's something dumb | 07:07 |
| sbalukoff | I'll see if I can fix it real quick. | 07:08 |
| rm_work | kk cause i'm good on this | 07:09 |
| rm_work | verified, added the same pool to two listeners | 07:09 |
| rm_work | seems legit | 07:09 |
| rm_work | hopefully I don't regret a +2 in the morning | 07:09 |
| sbalukoff | Heh! | 07:11 |
| rm_work | lol like EVERYTHING is in conflict now | 07:13 |
| sbalukoff | Yeah, this is annoying. | 07:13 |
| rm_work | oh yeah it's all yours | 07:13 |
| rm_work | that's why | 07:13 |
| *** prabampm has joined #openstack-lbaas | 07:14 | |
| *** links has joined #openstack-lbaas | 07:14 | |
| sbalukoff | Ok, let me run tox locally on this real quick... | 07:15 |
| rm_work | I like how blogan just dropped this: https://review.openstack.org/#/c/274993/ | 07:16 |
| rm_work | interesting that this doesn't seem to be kicking off: https://review.openstack.org/#/c/259550/ | 07:18 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Shared pools support https://review.openstack.org/256369 | 07:19 |
| sbalukoff | Ok, hopefully that works. | 07:19 |
| sbalukoff | Yay for rebasing against another huge patch. :P | 07:20 |
| * rm_work +2s and crashes | 07:21 | |
| sbalukoff | Sleep well! | 07:21 |
| *** kobis has joined #openstack-lbaas | 07:36 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Add L7 database structures https://review.openstack.org/265430 | 07:38 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Update repos for L7 policy / methods https://review.openstack.org/265529 | 07:46 |
| *** paco20151113 has joined #openstack-lbaas | 08:09 | |
| *** prabampm1 has joined #openstack-lbaas | 08:11 | |
| *** prabampm has quit IRC | 08:12 | |
| *** doug-fish has joined #openstack-lbaas | 08:16 | |
| *** doug-fish has quit IRC | 08:21 | |
| openstackgerrit | Brandon Logan proposed openstack/octavia: Default api_handler to queue_producer https://review.openstack.org/274993 | 08:24 |
| blogan | there rm_work | 08:24 |
| *** doug-fish has joined #openstack-lbaas | 08:29 | |
| *** doug-fish has quit IRC | 08:34 | |
| sbalukoff | Heh! | 08:41 |
| sbalukoff | blogan: Question for you if you're around, eh. | 08:42 |
| sbalukoff | Regarding the validations on l7 rules: I'm not sure how to do a 'validation layer' per se-- there are a couple places where we may end up wanting to use some types of string validations and what not at different layers within the code base. (eg. at the API, and also at the repo layers) | 08:43 |
| sbalukoff | So for now, I've created a bunch of helper functions in octavia/common/validations.py which do things like sanity checking on specific string formats, and even l7 rule internal consistency checking. | 08:44 |
| sbalukoff | The idea here is that even at the repo layer you should never be able to instantiate an invalid l7rule object. | 08:45 |
| sbalukoff | If you've got a better idea about how to do this, or where it should go in the code tree, I'm all ears, eh! | 08:45 |
| sbalukoff | (I'll try to get something committed on this branch tonight so you can see what I mean...) | 08:46 |
| *** chlong has quit IRC | 08:52 | |
| *** armax has quit IRC | 09:01 | |
| *** openstackgerrit has quit IRC | 09:17 | |
| *** openstackgerrit has joined #openstack-lbaas | 09:18 | |
| *** prabampm has joined #openstack-lbaas | 09:25 | |
| *** prabampm1 has quit IRC | 09:28 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: WIP: Update repos for L7 rules / validations https://review.openstack.org/276643 | 09:30 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: WIP: Update repos for L7 rules / validations https://review.openstack.org/276643 | 09:32 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: WIP: Update repos for L7 rules / validations https://review.openstack.org/276643 | 09:33 |
| *** kobis has quit IRC | 09:56 | |
| *** yamamoto_ has quit IRC | 10:15 | |
| *** yamamoto_ has joined #openstack-lbaas | 10:17 | |
| *** kobis has joined #openstack-lbaas | 10:52 | |
| *** kobis has quit IRC | 11:00 | |
| *** yamamoto_ has quit IRC | 11:18 | |
| *** rtheis has joined #openstack-lbaas | 11:27 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: WIP: Update repos for L7 rules / validations https://review.openstack.org/276643 | 11:43 |
| *** doug-fish has joined #openstack-lbaas | 11:49 | |
| *** doug-fish has quit IRC | 12:02 | |
| *** yamamoto has joined #openstack-lbaas | 12:19 | |
| *** yamamoto has quit IRC | 12:25 | |
| *** paco20151113 has quit IRC | 12:27 | |
| *** rtheis has quit IRC | 12:41 | |
| *** links has quit IRC | 12:43 | |
| *** ducttape_ has joined #openstack-lbaas | 12:58 | |
| *** kobis has joined #openstack-lbaas | 13:01 | |
| *** prabampm1 has joined #openstack-lbaas | 13:05 | |
| *** prabampm has quit IRC | 13:06 | |
| *** ducttape_ has quit IRC | 13:16 | |
| *** rtheis has joined #openstack-lbaas | 13:28 | |
| *** localloop127 has joined #openstack-lbaas | 13:35 | |
| *** woodster_ has joined #openstack-lbaas | 13:42 | |
| *** doug-fish has joined #openstack-lbaas | 13:49 | |
| *** neelashah has joined #openstack-lbaas | 13:54 | |
| *** piet has joined #openstack-lbaas | 14:19 | |
| *** yamamoto has joined #openstack-lbaas | 14:24 | |
| *** doug-fish has quit IRC | 14:29 | |
| *** doug-fish has joined #openstack-lbaas | 14:30 | |
| *** Bjoern_ has joined #openstack-lbaas | 14:35 | |
| *** amotoki has quit IRC | 14:37 | |
| *** longstaff has joined #openstack-lbaas | 14:50 | |
| *** ducttape_ has joined #openstack-lbaas | 14:58 | |
| *** yamamoto has quit IRC | 15:01 | |
| *** doug-fis_ has joined #openstack-lbaas | 15:03 | |
| *** doug-fish has quit IRC | 15:04 | |
| *** doug-fish has joined #openstack-lbaas | 15:05 | |
| *** doug-fish has quit IRC | 15:05 | |
| *** doug-fish has joined #openstack-lbaas | 15:05 | |
| *** doug-fi__ has joined #openstack-lbaas | 15:07 | |
| *** doug-fis_ has quit IRC | 15:07 | |
| *** doug-fish has quit IRC | 15:10 | |
| *** doug-fi__ has quit IRC | 15:11 | |
| *** amotoki has joined #openstack-lbaas | 15:14 | |
| *** doug-fish has joined #openstack-lbaas | 15:22 | |
| *** yamamoto has joined #openstack-lbaas | 15:29 | |
| *** yamamoto has quit IRC | 15:31 | |
| *** yamamoto has joined #openstack-lbaas | 15:32 | |
| *** numan_ has quit IRC | 15:36 | |
| *** yamamoto has quit IRC | 15:37 | |
| *** amotoki has quit IRC | 15:40 | |
| *** doug-fish has quit IRC | 15:42 | |
| *** piet has quit IRC | 15:42 | |
| *** yamamoto has joined #openstack-lbaas | 15:42 | |
| *** piet has joined #openstack-lbaas | 15:43 | |
| *** yamamoto has quit IRC | 15:44 | |
| *** doug-fish has joined #openstack-lbaas | 15:53 | |
| *** amotoki has joined #openstack-lbaas | 15:54 | |
| *** mgarza has joined #openstack-lbaas | 15:55 | |
| *** allan_h has joined #openstack-lbaas | 15:56 | |
| pai15 | Hello, nubie here. Trying to get lbaas v2 working with devstack. Once I create loadbalancer, it stays in PENDINZG_CREATE state. Hence can not configure listener and all. Any pointers? | 15:58 |
| *** logan_ has joined #openstack-lbaas | 16:00 | |
| *** logan_ is now known as Guest78654 | 16:01 | |
| *** logan- has quit IRC | 16:01 | |
| *** Guest78654 is now known as logan- | 16:02 | |
| rm_work | knew it! https://review.openstack.org/#/c/276711/ | 16:03 |
| rm_work | johnsom: ^^ | 16:03 |
| *** alhu_ has joined #openstack-lbaas | 16:11 | |
| *** allan_h has quit IRC | 16:14 | |
| rm_work | sbalukoff / xgerman / blogan / johnsom do you remember when we are deprecating haproxyNamespaceDriver for v2? | 16:21 |
| *** armax has joined #openstack-lbaas | 16:21 | |
| xgerman | I don’t think we are deprecating it | 16:22 |
| rm_work | i thought we were | 16:22 |
| rm_work | but maybe not? | 16:22 |
| xgerman | the plan was to eventually have it in it’s own repo like a 3rd party driver for interested parties to mainteain | 16:22 |
| xgerman | em_work also https://review.openstack.org/276554 | 16:23 |
| xgerman | rm_work | 16:23 |
| rm_work | yeah i know | 16:23 |
| rm_work | going to try to figure out exactly what's up | 16:24 |
| xgerman | yeah, in our tests it connected to expired certs — there should be an Octavia bug for that | 16:24 |
| xgerman | for the namespace blogan/dougwig should have the latests | 16:24 |
| *** prometheanfire has joined #openstack-lbaas | 16:25 | |
| *** ducttape_ has quit IRC | 16:25 | |
| rm_work | ok yeah i'll take a look | 16:26 |
| *** johnsom_ has joined #openstack-lbaas | 16:28 | |
| *** alhu_ has quit IRC | 16:32 | |
| *** _cjones_ has joined #openstack-lbaas | 16:34 | |
| *** piet has quit IRC | 16:36 | |
| *** _cjones_ has quit IRC | 16:37 | |
| *** _cjones_ has joined #openstack-lbaas | 16:37 | |
| *** piet has joined #openstack-lbaas | 16:37 | |
| xgerman | rm_work thanks for digging that up | 16:41 |
| *** yamamoto has joined #openstack-lbaas | 16:45 | |
| *** ducttape_ has joined #openstack-lbaas | 16:49 | |
| *** yamamoto has quit IRC | 16:51 | |
| *** fnaval has quit IRC | 16:57 | |
| *** fnaval has joined #openstack-lbaas | 16:57 | |
| *** prabampm1 has quit IRC | 17:01 | |
| blogan | rm_work: don't think we are | 17:06 |
| blogan | rm_work: don't think it was ever planned | 17:06 |
| rm_work | kk | 17:08 |
| rm_work | i heard talk about that I thought since we were saying we didn't want to maintain two drivers if octavia was up and running as the default | 17:08 |
| rm_work | but i guess it's ok? | 17:08 |
| blogan | i think there might be some people that may want to maintain it | 17:14 |
| *** Aish has joined #openstack-lbaas | 17:21 | |
| johnsom_ | Which driver? IRC history missing | 17:26 |
| rm_work | haproxynamespace | 17:26 |
| johnsom_ | Oh, yeah, probably should hang around | 17:27 |
| rm_work | prometheanfire: ^^ there you go | 17:27 |
| rm_work | prometheanfire: nothing being deprecated that would force the use of octavia for lbaas yet | 17:28 |
| rm_work | or even in the near future | 17:28 |
| prometheanfire | thanks | 17:29 |
| prometheanfire | I'll still hang around, want to know about the management network changes for octavia, using admin level stuff for it is notsogood :D | 17:30 |
| *** alhu_ has joined #openstack-lbaas | 17:34 | |
| *** jwarendt has joined #openstack-lbaas | 17:39 | |
| *** fnaval has quit IRC | 17:42 | |
| *** amotoki has quit IRC | 17:45 | |
| *** johnsom_ has quit IRC | 17:56 | |
| *** numan_ has joined #openstack-lbaas | 18:03 | |
| *** madhu_ak_ has joined #openstack-lbaas | 18:03 | |
| rm_work | xgerman: can't seem to repro the expired certificate being accepted | 18:04 |
| rm_work | maybe it's not a real issue and we are good without the thing | 18:05 |
| xgerman | mmh, well, it happened a long time ago so might be fixed | 18:05 |
| rm_work | BREACH attack is worrying, but | 18:05 |
| *** fnaval has joined #openstack-lbaas | 18:06 | |
| rm_work | we may not fit the full criteria for it | 18:10 |
| rm_work | Be served from a server that uses HTTP-level compression | 18:10 |
| rm_work | Reflect user-input in HTTP response bodies | 18:10 |
| rm_work | Reflect a secret (such as a CSRF token) in HTTP response bodies | 18:10 |
| rm_work | since these are all server-side things, I'm not sure the *client* can possibly be related? | 18:11 |
| *** Aish has quit IRC | 18:14 | |
| rm_work | xgerman: what actually runs the flask app for the agent on the amp? | 18:17 |
| xgerman | werkzeug | 18:17 |
| rm_work | ah I found it | 18:17 |
| rm_work | cmd/agent.py | 18:17 |
| xgerman | yep | 18:18 |
| *** ducttape_ has quit IRC | 18:21 | |
| *** piet has quit IRC | 18:26 | |
| *** bana_k has joined #openstack-lbaas | 18:26 | |
| *** Aish has joined #openstack-lbaas | 18:27 | |
| *** _cjones_ has quit IRC | 18:27 | |
| *** drjones has joined #openstack-lbaas | 18:27 | |
| dougwig | we'll likely eject it if/when we eject vendors, like neutron. | 18:27 |
| *** longstaff has quit IRC | 18:28 | |
| openstackgerrit | Merged openstack/octavia: Default api_handler to queue_producer https://review.openstack.org/274993 | 18:29 |
| sbalukoff | I've got to commute into the office (big Blue Box party thingy happening today), but in the meantime: johnsom: https://review.openstack.org/#/c/256369/ One little conflict made me have to rebase in such a way that I lost your +2 on that. I'd appreciate it if you could have another look. (or blogan or dougwig or xgerman or blallau) | 18:31 |
| johnsom | Yep, watching it | 18:32 |
| sbalukoff | Thanks! | 18:32 |
| johnsom | Congrats BTW | 18:32 |
| sbalukoff | Ok, BBIAB | 18:32 |
| sbalukoff | And yes-- thanks on that front, too! | 18:32 |
| xgerman | sbalukoff you had a party for your core promotion scheduled? How confident? | 18:32 |
| rm_work | :P | 18:32 |
| sbalukoff | xgerman: I like to plan ahead. XD | 18:32 |
| xgerman | Congrats as well | 18:32 |
| johnsom | Hahaha, wow, say it isn't so | 18:32 |
| sbalukoff | No-- this is the annual company party. | 18:32 |
| johnsom | We'll have to revoke immediately | 18:32 |
| johnsom | grin | 18:32 |
| sbalukoff | We usually skip having it in December because holidays/vacation. | 18:33 |
| sbalukoff | XD | 18:33 |
| doug-fish | annual company party?! who do you work for?! | 18:33 |
| sbalukoff | doug-fish: Blue Box, an IBM Company | 18:33 |
| doug-fish | :-) | 18:33 |
| rm_work | lol | 18:33 |
| rm_work | it is seriously impossible to NOT laugh when anyone says that full company name | 18:33 |
| rm_work | T_T | 18:34 |
| doug-fish | when you work for IBM, every day is a party. | 18:34 |
| sbalukoff | At least, nobody's told me differently yet. Techincally I was transferred to the Open Source Networking Group within IBM about a week ago. But the paperwork hasn't gone through on that yet, so I'm going to pretend I still belong at that party. XD | 18:34 |
| johnsom | Especially when the person asking works for the same company | 18:34 |
| sbalukoff | HAHA! | 18:34 |
| doug-fish | Kind of a mix between a search party and a rescue party. But still. | 18:34 |
| *** ducttape_ has joined #openstack-lbaas | 18:34 | |
| sbalukoff | doug-fish: HAHAHA! | 18:34 |
| sbalukoff | At least it isn't a Donner party. | 18:35 |
| sbalukoff | Ok, I've gotta run. Be online a little later, eh! | 18:35 |
| doug-fish | *waves* | 18:35 |
| *** longstaff has joined #openstack-lbaas | 18:38 | |
| *** sbalukoff has quit IRC | 18:39 | |
| *** longstaff has quit IRC | 18:42 | |
| *** longstaff has joined #openstack-lbaas | 18:45 | |
| *** longstaff has quit IRC | 18:45 | |
| *** longstaff has joined #openstack-lbaas | 18:46 | |
| *** localloop127 has quit IRC | 18:53 | |
| *** localloop127 has joined #openstack-lbaas | 18:56 | |
| *** localloop127 has quit IRC | 19:18 | |
| *** madhu_ak_ is now known as madhu_ak | 19:19 | |
| openstackgerrit | Brandon Logan proposed openstack/octavia: Remove out-dated README file https://review.openstack.org/276880 | 19:19 |
| *** ducttape_ has quit IRC | 19:21 | |
| *** localloop127 has joined #openstack-lbaas | 19:21 | |
| *** ducttape_ has joined #openstack-lbaas | 19:36 | |
| *** sbalukoff has joined #openstack-lbaas | 19:47 | |
| blogan | johnsom: couple of questions | 19:47 |
| johnsom | Ok | 19:47 |
| blogan | johnsom: how to enable the debug messages on teh scenario tests? | 19:47 |
| blogan | tyring to track down one of them intermittent issues | 19:47 |
| johnsom | set it in the gate hook | 19:47 |
| blogan | and 2) is it the agent log viewable on the job logs? | 19:48 |
| blogan | s/is it/is/ | 19:48 |
| johnsom | no, we don't harvest the agent log from the amps | 19:48 |
| blogan | damn, i think we should find a way to do that bc it'll make these much easier to figure out | 19:48 |
| blogan | http://logs.openstack.org/37/275337/5/check/gate-neutron-lbaasv2-dsvm-scenario/688c19e/console.html#_2016-02-04_10_22_46_221 | 19:49 |
| blogan | like this one, basically is saying that after a pool got deleted, the lb was still load balancing to the members in that pool | 19:49 |
| sbalukoff | Man, this place is a mad-house today. | 19:49 |
| blogan | but the pool delete logs all the way to the o-cw say that the delete happened correctly | 19:50 |
| blogan | so at that point, insepecting the haproxy config would be beneficial | 19:50 |
| blogan | sbalukoff: got your message early this morning or last night, can't remember about the validation layer | 19:50 |
| sbalukoff | blogan: Yay! | 19:50 |
| johnsom | Hmm, timing maybe. | 19:50 |
| blogan | sbalukoff: sounded like what you said was fine to me, but could you go over it again? | 19:51 |
| blogan | johnsom: perhaps timing, the agent is synchronous right? | 19:51 |
| sbalukoff | blogan: The delete problem you are seeing is probably related to this bug: https://bugs.launchpad.net/octavia/+bug/1542120 | 19:51 |
| openstack | Launchpad bug 1542120 in octavia "Changes made via API do not immediately get pushed to amphorae" [Critical,New] - Assigned to Michael Johnson (johnsom) | 19:51 |
| blogan | sbalukoff: ah | 19:52 |
| sbalukoff | blogan: Certainly! I put validations for l7rules here: https://review.openstack.org/#/c/276643/4/octavia/common/validations.py | 19:52 |
| sbalukoff | (It's easier to show you what I'm doing now that I have something committed.) | 19:53 |
| johnsom | Could be, but they are intermittent so, odd | 19:53 |
| sbalukoff | johnsom: Yeah, the intermittent part of that problem throws me off as well. :/ | 19:53 |
| sbalukoff | er... intermittent nature | 19:53 |
| johnsom | Yeah, I just got a similar hit: | 19:53 |
| johnsom | http://logs.openstack.org/50/259550/7/check/gate-neutron-lbaasv2-dsvm-scenario/d48b77d/console.html#_2016-02-05_19_50_43_255 | 19:54 |
| blogan | seems to be happening more frequent, even without the session persistence bug | 19:54 |
| blogan | then again the session persistence failures could be the same issue | 19:54 |
| sbalukoff | blogan: regarding the validation "layer"-- I wasn't sure how to do it as a layer, since I could see this begin done at the API level as well as the repo level. Plus, these kinds of validations are context-independent, so I threw them in a new file in octavia/common | 19:54 |
| johnsom | Yeah, it is definitely showing up more all of a sudden. | 19:55 |
| blogan | sbalukoff: yeah makes sense, works for me, just really wanted the validation logic separate from the control logic, and i figured we'd need them to be reusable | 19:56 |
| sbalukoff | blogan: Ok! Sounds good. Glad I wasn't totally off-base in doing it that way. :) | 19:56 |
| johnsom | The hosts seem to be slower now too, which makes me think it is a timing thing. Look at how long it takes for the initial API connect. | 19:57 |
| blogan | we'll also need to add in some validation pieces that go and validate against neutron and nova, which will be quite hairy bc the api will have to load a network and/or compute driver for that | 19:57 |
| sbalukoff | blogan: Awesome... well, tempest tests are coming, right? | 19:58 |
| blogan | damn rackspace VMs! | 19:58 |
| sbalukoff | Haha! | 19:58 |
| blogan | sbalukoff: yes, should be, right fnaval? :) | 19:58 |
| johnsom | Actually I think mine was a bluebox host | 19:58 |
| sbalukoff | johnsom: Sorry! | 19:59 |
| fnaval | checking for context.. 1 sec | 19:59 |
| sbalukoff | fnaval: We love you! | 19:59 |
| johnsom | No worries, probably still faster than the old HP hosts | 19:59 |
| fnaval | yea working on it right now | 20:00 |
| fnaval | tempest tests that is. thanks sbalukoff! | 20:00 |
| *** doug-fis_ has joined #openstack-lbaas | 20:05 | |
| johnsom | https://bugs.launchpad.net/neutron/+bug/1542467 | 20:06 |
| openstack | Launchpad bug 1542467 in neutron "LBAAS Intermittent gate failure TestHealthMonitorBasic.test_health_monitor_basic" [Undecided,New] | 20:06 |
| johnsom | I logged that one. | 20:06 |
| johnsom | will take a look after grabbing lunch | 20:06 |
| blogan | test_listener_basic is happening as wel | 20:07 |
| blogan | probably every scenario test lol | 20:07 |
| blogan | at some point | 20:07 |
| johnsom | I got this error: socket.error: [Errno 104] Connection reset by peer | 20:08 |
| johnsom | Which seems different, but if you think related you can add on | 20:08 |
| *** doug-fish has quit IRC | 20:08 | |
| blogan | yeah i'm willing to bet its all related | 20:08 |
| blogan | and could be the stale data being pushed up thing | 20:08 |
| johnsom | Mmmm, not so sure. This error is after the test, on shutdown | 20:09 |
| *** alhu_ has quit IRC | 20:09 | |
| johnsom | Maybe | 20:09 |
| *** doug-fis_ has quit IRC | 20:10 | |
| openstackgerrit | Brandon Logan proposed openstack/neutron-lbaas: Enable debug logging in octavia scenario tests https://review.openstack.org/276900 | 20:14 |
| blogan | ah shit | 20:15 |
| blogan | dont' want to use the noop drivers | 20:15 |
| blogan | i mean ah poop | 20:15 |
| sbalukoff | Dammit, did you swear? | 20:16 |
| blogan | someone must have changed their nick to mine | 20:16 |
| sbalukoff | Clearly. | 20:16 |
| openstackgerrit | Brandon Logan proposed openstack/neutron-lbaas: Enable debug logging in octavia scenario tests https://review.openstack.org/276900 | 20:19 |
| blogan | i don't know if id id that right but we shall see by the tests | 20:19 |
| openstackgerrit | min wang proposed openstack/octavia: Implements: blueprint anti-affinity server group https://review.openstack.org/272344 | 20:20 |
| *** localloop127 has quit IRC | 20:20 | |
| sbalukoff | Look good to me. :/ | 20:21 |
| *** numan_ has quit IRC | 20:21 | |
| sbalukoff | Oh handy-- we'll not need to merge that for you to get your results. :) Or are you planning on merging that anyway so we can see failures on other tests? | 20:22 |
| blogan | merging anyway, every other job has the debug logs | 20:23 |
| blogan | and they're quite useful when troubleshooting | 20:23 |
| blogan | next thing we should do is find out some way to get the agent logs uploaded, which i'm not even sure if its possible, well possible in the sense that we don't hack it up | 20:24 |
| rm_work | agent logs from the amp? | 20:26 |
| rm_work | I don't even... | 20:26 |
| rm_work | we'd need to use paramiko to grab them or something before we delete each LB? or ... add a log retrieval endpoint to the agent? | 20:26 |
| rm_work | and have the deletion flow grab the logs before shutting down the amp? | 20:26 |
| rm_work | that might work | 20:27 |
| rm_work | is there actually a shutdown flow that lets the driver define shutdown tasks on deletion? | 20:27 |
| blogan | yeah something like that | 20:27 |
| blogan | i don't think so | 20:27 |
| rm_work | because that would work -- let the driver run some tasks it wants before spinning down the amps, llke a cleanup function | 20:29 |
| rm_work | and that could grab the logs and store them locally | 20:29 |
| rm_work | getting the agent logs is not a small effort, I would guess :/ | 20:30 |
| xgerman | scp ? | 20:32 |
| sbalukoff | xgerman: That's crazy talk, man. | 20:32 |
| rm_work | yeah that is what i meant with paramiko | 20:32 |
| rm_work | i mean we need to do it in code before deletion of the LB | 20:32 |
| xgerman | then dump them into the worker logs | 20:32 |
| rm_work | i would keep them separate probably | 20:32 |
| xgerman | and only if verbose/debug/ssh-key enabled | 20:32 |
| rm_work | ie, paramiko for scp | 20:33 |
| xgerman | yep | 20:35 |
| rm_work | blogan: i think you missed a thing on https://review.openstack.org/#/c/276900/2 | 20:35 |
| sbalukoff | rm_work: You're right. Need append, not overwrite. | 20:39 |
| rm_work | were we going to try to merge https://review.openstack.org/#/c/256369/27 today? | 20:40 |
| * sbalukoff looks hopeful | 20:40 | |
| sbalukoff | It would totally make my Friday. :) | 20:40 |
| blogan | thats why you bash experts look at it :) | 20:41 |
| openstackgerrit | Brandon Logan proposed openstack/neutron-lbaas: Enable debug logging in octavia scenario tests https://review.openstack.org/276900 | 20:41 |
| blogan | well if assume scp is an option, then we're assuming the amp can be ssh'ed into which may not be true | 20:43 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Update repos for L7 policy / methods https://review.openstack.org/265529 | 20:43 |
| ptoohill | I added option to rest driver stuff to disable ssh as it was still open | 20:43 |
| ptoohill | That's been in there for a bit though, I think | 20:43 |
| ptoohill | so assuming deployer deploys with right options | 20:44 |
| *** rtheis has quit IRC | 20:44 | |
| ptoohill | unless scp is only option | 20:45 |
| sbalukoff | I wouldn't be against adding an amphora API endpoint to grab logs, eh. | 20:46 |
| ptoohill | I like that idea | 20:47 |
| rm_work | yeah this ^^ | 20:47 |
| sbalukoff | That seems like it could be useful in a production environment as well. | 20:47 |
| ptoohill | all the options are optional | 20:48 |
| sbalukoff | Haha | 20:49 |
| sbalukoff | Ok... It sounds like the big Blue Box meeting, followed by a party, will happen in about 1.5 hours. I'll probably be AFK for the rest of the day following that. So if you need anything from me (especially if it involves a particular shared pools patch ;), please let me know before then! | 20:50 |
| *** localloop127 has joined #openstack-lbaas | 20:51 | |
| ptoohill | Have fun! | 20:54 |
| ptoohill | Is gate still a day long? | 20:54 |
| ptoohill | doesnt look too bad | 20:54 |
| rm_work | ptoohill: any patches you really want people to review that are ready to go? | 20:58 |
| rm_work | ptoohill: haven't heard you really selling any of your CRs recently :) | 20:58 |
| ptoohill | I've been kinda of waiting for other things | 20:59 |
| ptoohill | My stuff wont be used for a little while, but do need it in soon. I was hoping to get other important things in | 21:00 |
| ptoohill | We need this: https://review.openstack.org/#/c/275558/ | 21:00 |
| johnsom | Thanks ptoohill for the selfless act... I have also be trying to prioritize stuff. | 21:00 |
| ptoohill | Octavia queue is <trump voice> HUGE | 21:01 |
| ptoohill | johnsom: :) | 21:01 |
| ptoohill | Lots going on | 21:01 |
| rm_work | ok, taking a look at that one | 21:01 |
| ptoohill | Oh wait, he's a second place loser now, now I really aint voting for him | 21:01 |
| ptoohill | :P | 21:01 |
| johnsom | Yep, which is awesome! We are making progress though | 21:01 |
| ptoohill | Indeed | 21:02 |
| rm_work | man, i do not understand jinja as well as i thought apparently | 21:06 |
| rm_work | what is the hyphen for in {%- | 21:06 |
| ptoohill | to remove white space | 21:11 |
| ptoohill | I could set it globally, but we dont want that, we need certain white space | 21:11 |
| ptoohill | jinja can be quirky | 21:11 |
| ptoohill | rm_work: | 21:11 |
| ptoohill | http://jinja.pocoo.org/docs/dev/templates/ Under 'Whitespace Control' | 21:13 |
| rm_work | ah ok | 21:13 |
| ptoohill | There's some limitations regarding formatting that makes things interesting sometimes | 21:13 |
| ptoohill | this being a case because of yaml, and the filter doesnt work. Maybe at some point I could write a custom filter, but.. | 21:13 |
| rm_work | only one nit | 21:15 |
| rm_work | need to run it tho | 21:15 |
| ptoohill | Need to set use_upstart = False and it works with devstack | 21:16 |
| ptoohill | er | 21:16 |
| ptoohill | wait | 21:17 |
| ptoohill | crossing lines | 21:17 |
| ptoohill | user_data_config_drive = True | 21:17 |
| ptoohill | in controller_worker | 21:17 |
| ptoohill | Feel free to rip it apart, ill get it updated | 21:18 |
| ptoohill | DOH, yes i need to disable that >< | 21:20 |
| openstackgerrit | Phillip Toohill proposed openstack/octavia: Allow user-data on amphora creation https://review.openstack.org/275558 | 21:28 |
| *** bana_k has quit IRC | 21:29 | |
| *** localloop127 has quit IRC | 21:43 | |
| *** allan_h has joined #openstack-lbaas | 21:52 | |
| *** bana_k has joined #openstack-lbaas | 22:12 | |
| *** bank_ has joined #openstack-lbaas | 22:12 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Update repos for L7 policy / methods https://review.openstack.org/265529 | 22:12 |
| *** longstaff has quit IRC | 22:19 | |
| *** bank_ has quit IRC | 22:27 | |
| *** bana_k has quit IRC | 22:27 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Update repos for L7 rules / validations https://review.openstack.org/276643 | 22:28 |
| rm_work | sbalukoff: i thought you were at a party | 22:29 |
| *** bana_k has joined #openstack-lbaas | 22:40 | |
| *** bank_ has joined #openstack-lbaas | 22:41 | |
| *** ducttape_ has quit IRC | 22:41 | |
| fnaval | how do I make changes to this doc: http://docs.openstack.org/developer/octavia/api/octaviaapi.html#list-members | 22:43 |
| fnaval | or propose changes | 22:44 |
| johnsom | Min knows. Let me see if I can ping her | 22:45 |
| fnaval | cool. thanks johnsom. i think it might be syncing down a particular docs tree? | 22:46 |
| *** kobis has quit IRC | 22:46 | |
| *** minwang2 has joined #openstack-lbaas | 22:46 | |
| johnsom | Yeah, she knows that voodoo | 22:47 |
| fnaval | cool thanks johnsom | 22:47 |
| minwang2 | fnaval, can you repeat the question again | 22:47 |
| fnaval | hi minwang2: I want to make a proposed change to the octavia docs located at http://docs.openstack.org/developer/octavia/api/octaviaapi.html | 22:47 |
| fnaval | what do I have to checkout for that? | 22:48 |
| minwang2 | https://github.com/openstack/octavia/blob/master/doc/source/api/octaviaapi.rst | 22:48 |
| fnaval | ah ok thanks! | 22:49 |
| fnaval | i thought it lived in a separate repo. | 22:49 |
| minwang2 | nope, you can edit it directly in that file | 22:49 |
| openstackgerrit | Franklin Naval proposed openstack/octavia: Octavia: API docs Create Member url fix https://review.openstack.org/276944 | 22:56 |
| fnaval | cool thanks minwang2 - please take a look at that if it's a valid fix | 22:56 |
| minwang2 | fnaval, np, let me take a look | 22:57 |
| fnaval | just a 1 line change | 22:57 |
| fnaval | thanks | 22:57 |
| minwang2 | btw, is there a ticket linked with this patch, why do we need to change it | 22:57 |
| fnaval | no ticket. where do i file that | 22:58 |
| fnaval | oh i got a +2 from brandon. i think it might not need it then? | 22:59 |
| minwang2 | the code itself is pretty simple, but it would be a good habbit to link a ticket or write some description in the commit msg, in that way, for people who has no background about this patch, they can easier to review :) | 23:02 |
| openstackgerrit | Franklin Naval proposed openstack/octavia: Octavia: API docs Create Member url fix https://review.openstack.org/276944 | 23:02 |
| fnaval | ah ok. in launch pad? | 23:03 |
| fnaval | bah, i just realized that the url gets fixed in the shared pools patch but anyway, this fixes that url before that lands | 23:03 |
| openstackgerrit | Merged openstack/octavia: Remove out-dated README file https://review.openstack.org/276880 | 23:05 |
| openstackgerrit | Franklin Naval proposed openstack/octavia: Octavia: API docs Create Member url fix https://review.openstack.org/276944 | 23:07 |
| openstackgerrit | Michael Johnson proposed openstack/octavia: Fixes Octavia flows that are not reverting https://review.openstack.org/259550 | 23:07 |
| fnaval | minwang2: thanks, yes that makes sense. plus, it's good to have some metrics on opened bugs/fixed bugs | 23:07 |
| minwang2 | i just gave +1, i like this way better | 23:08 |
| openstackgerrit | Franklin Naval proposed openstack/octavia: Octavia: API docs Create Member url fix https://review.openstack.org/276944 | 23:08 |
| johnsom | fnaval FYI: http://docs.openstack.org/infra/manual/developers.html#working-on-bugs | 23:09 |
| johnsom | It should be Closes-Bug: #12345 | 23:09 |
| openstack | bug 12345 in isdnutils (Ubuntu) "isdn does not work, fritz avm (pnp?)" [Medium,Fix released] https://launchpad.net/bugs/12345 - Assigned to Matthias Klose (doko) | 23:09 |
| johnsom | Opps, I guess my example # worked | 23:10 |
| fnaval | thanks johnsom: reading and bookmarking it | 23:10 |
| johnsom | I always have to refer back to this page to get the formatting right | 23:10 |
| *** nmagnezi_ has joined #openstack-lbaas | 23:10 | |
| fnaval | the documentation on that same page shows to add the line "Fixes Bug: 1234" http://docs.openstack.org/infra/manual/developers.html#peer-review | 23:10 |
| openstack | bug 1234 in Launchpad itself "Gina is an unmaintainable mess of command line options, environment variables and shell scripts" [Medium,Fix released] https://launchpad.net/bugs/1234 - Assigned to Daniel Henrique Debonzi (debonzi) | 23:10 |
| fnaval | might need to fix that too | 23:10 |
| openstackgerrit | Franklin Naval proposed openstack/octavia: Octavia: API docs Create Member url fix https://review.openstack.org/276944 | 23:11 |
| johnsom | fnaval I'm not trying to nit-pick you, but I want you to know how to do it right so you get stackalytics credit. | 23:16 |
| johnsom | Closes-Bug: #1542528 | 23:17 |
| openstack | bug 1542528 in octavia "Fix URL for Create Member" [Undecided,Fix committed] https://launchpad.net/bugs/1542528 - Assigned to Franklin Naval (franknaval) | 23:17 |
| fnaval | johnsom: ah I didn't think of it as that actually | 23:17 |
| johnsom | Not a big deal, but could be nice if you guys look at those #s | 23:17 |
| fnaval | no worries on the nit-pick | 23:18 |
| fnaval | im totally (re)learning this | 23:18 |
| fnaval | lol | 23:18 |
| johnsom | When it's right the commit message will pop into the bug itself | 23:18 |
| fnaval | ah | 23:18 |
| fnaval | forgot to add the '3" | 23:19 |
| fnaval | '#' | 23:19 |
| johnsom | Yeah | 23:19 |
| openstackgerrit | Franklin Naval proposed openstack/octavia: Octavia: API docs Create Member url fix https://review.openstack.org/276944 | 23:20 |
| johnsom | The docs are so un-helpful on that | 23:20 |
| fnaval | yeah, I'm trying to find where that doc repo lives so i can propose changes | 23:20 |
| johnsom | brandon's patch here is a good example: https://review.openstack.org/#/c/260291/ | 23:21 |
| fnaval | ah ok good one | 23:23 |
| fnaval | so, the OpenStack Infra user will automatically update the bug in the comments with any related changes if the commit message is correct? | 23:24 |
| *** nmagnezi_ has quit IRC | 23:25 | |
| johnsom | Yep | 23:29 |
| fnaval | ah ok thanks johnsom | 23:29 |
| johnsom | It tracks the lifecycle of the bug and patch and will update the bug as it progresses | 23:29 |
| *** mgarza has quit IRC | 23:37 | |
| *** neelashah has quit IRC | 23:38 | |
| *** chlong has joined #openstack-lbaas | 23:38 | |
| openstackgerrit | Merged openstack/neutron-lbaas: Implementing EventStreamer reciever for octavia https://review.openstack.org/241474 | 23:44 |
| *** ducttape_ has joined #openstack-lbaas | 23:58 | |
| *** Bjoern_ has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!