Tuesday, 2015-12-15

johnsomThanks again with the troubleshooting help00:03
*** ducttape_ has joined #openstack-lbaas00:20
johnsomYep, fixed00:24
bloganjohnsom: np anytime, one of those unexpected nova neutron interactions00:26
johnsomYep.  You saved me a bunch of time tracking that down.00:26
*** ducttape_ has quit IRC00:33
openstackgerritJames Arendt proposed openstack/octavia: Make Octavia devstack pass env settings to sudo pip install  https://review.openstack.org/25762900:34
*** ducttape_ has joined #openstack-lbaas00:43
*** manishg has quit IRC01:01
*** manishg has joined #openstack-lbaas01:01
*** ajmiller has quit IRC01:02
*** manishg_ has joined #openstack-lbaas01:04
*** openstack has joined #openstack-lbaas01:06
-wolfe.freenode.net- [freenode-info] channel flooding and no channel staff around to help? Please check with freenode support: http://freenode.net/faq.shtml#gettinghelp01:06
*** manishg has quit IRC01:07
*** sbalukoff has joined #openstack-lbaas01:15
*** manishg_ has quit IRC01:19
*** Aish has quit IRC01:22
*** bharathm has quit IRC01:26
*** crc32 has quit IRC01:29
bana_kHello ! need some help with the alembic01:35
bana_kany experts here01:35
*** ducttape_ has quit IRC01:40
*** yamamoto has joined #openstack-lbaas01:42
openstackgerritMichael Johnson proposed openstack/octavia: Disable amphora health monitoring on amp delete  https://review.openstack.org/25764301:49
*** Aish has joined #openstack-lbaas01:50
*** manishg has joined #openstack-lbaas01:50
johnsom^^^ that is a nasty little bug.01:50
johnsombana_k I might be able to help, what is up?01:50
*** yamamoto has quit IRC01:52
*** yamamoto has joined #openstack-lbaas01:52
bana_kThanks johnsom, I am trying to add some tables to the lbaas01:53
johnsomOk01:53
bana_kso added a new file in the db/migration/alembic_migrations/versions01:53
bana_ksi that right thing to do ?01:53
johnsomYes01:54
bana_kjohnsom: there use to be neutron-*-db-manage file to run to create these new tables01:54
bana_kbut I am not finding it on here01:54
*** manishg has quit IRC01:54
johnsomalembic will generate the template file01:54
bana_kwhat command I should run to do that ?01:55
johnsomJust a second, let me look that up again, I always forget.01:55
johnsomThe db manage tool comes with neutron01:55
bana_koh ok.01:55
*** yamamoto has quit IRC01:56
johnsomhttps://alembic.readthedocs.org/en/latest/tutorial.html#create-a-migration-script01:56
johnsomalembic revision -m "create account table"01:56
*** ducttape_ has joined #openstack-lbaas01:56
johnsomThe nice thing about that is it gets the revisions right.01:56
johnsomnow, I need to think about the conf file you need01:57
*** Tiancheng has joined #openstack-lbaas01:57
johnsomWell, I guess you can just run that command and then manually add the down revision if you want01:58
bana_koh cool, I will try this one01:58
johnsomAh, wait.01:58
johnsomSo, I always get this confused since octavia has it's own config.01:59
johnsomYou can use neutron-db-manage to create a revision file too01:59
bana_koh I will try, the only problem is I am not finding the neutron-db-manage file in my setup, I think may be I am looking at the wrong place.02:00
johnsomso I think it is 'neutron-db-manage --subproject neutron-lbaas revision -m "create account table"'02:00
johnsompip install neutron02:00
johnsomor check it out and python setup.py install02:01
bana_kjohnsom : I will try it out.  thanks a lot for all the help02:01
johnsomI'm not as familiar with neutron-db-manage, so there might need to be a config file.  I'm not sure how it finds the neutron-lbaas directory either.02:02
bana_koh ok np, actually we pass the config file like this test-db-manage --config-file /etc/neutron/neutron.conf upgrade head02:02
bana_kbut I am too not sure how it finds the lbaas folder.02:03
johnsominteresting.02:03
johnsomWell, hopefully I gave you some pointers02:03
johnsomRemember to make sure the down revision is the current "HEAD" revision02:04
johnsomSo remember, we don't implement downgrade code any longer02:04
bana_kyes johnsom, that was very useful.02:04
bana_kthanks again for the help.02:04
johnsomCool.  Good luch02:04
johnsomluck02:04
bana_kthanks :)02:04
openstackgerritMichael Johnson proposed openstack/octavia: Updates the failover flow for active/standby  https://review.openstack.org/25372402:05
*** ducttape_ has quit IRC02:06
*** rsanchez87 has quit IRC02:08
*** rsanchez87 has joined #openstack-lbaas02:08
*** rsanchez87 has quit IRC02:08
*** Aish has quit IRC02:13
openstackgerritMichael Johnson proposed openstack/octavia: Updates the failover flow for active/standby  https://review.openstack.org/25372402:20
*** bana_k has quit IRC02:21
*** Aish has joined #openstack-lbaas02:33
*** Aish has left #openstack-lbaas02:33
*** manishg has joined #openstack-lbaas02:37
*** bana_k has joined #openstack-lbaas02:46
*** ianbrown has quit IRC02:46
*** rsanchez87 has joined #openstack-lbaas02:46
*** rsanchez87 has quit IRC02:46
*** ianbrown has joined #openstack-lbaas02:47
*** bochi-michael has joined #openstack-lbaas02:48
*** yamamoto has joined #openstack-lbaas02:54
*** woodster_ has quit IRC02:56
*** manishg has quit IRC03:14
*** ljxias___ has joined #openstack-lbaas03:18
*** yuanying has quit IRC03:20
*** rsanchez87 has joined #openstack-lbaas03:24
*** ducttape_ has joined #openstack-lbaas03:29
*** ljxias___ has quit IRC03:40
*** bana_k has quit IRC03:45
*** ducttape_ has quit IRC04:04
*** yuanying has joined #openstack-lbaas04:07
*** rsanchez87 has quit IRC04:17
*** rsanchez87 has joined #openstack-lbaas04:19
*** openstack has joined #openstack-lbaas04:27
*** ducttape_ has joined #openstack-lbaas04:29
*** bharathm has quit IRC04:31
*** madhu_ak has quit IRC04:36
*** ducttape_ has quit IRC04:39
*** numans has joined #openstack-lbaas04:41
*** ducttape_ has joined #openstack-lbaas05:01
*** ducttape_ has quit IRC05:09
*** bharathm has joined #openstack-lbaas05:42
*** rm_work has quit IRC05:59
*** rm_work has joined #openstack-lbaas06:22
*** bharathm has quit IRC07:04
*** bana_k has joined #openstack-lbaas07:07
*** bharathm has joined #openstack-lbaas07:19
*** nmagnezi has joined #openstack-lbaas07:24
*** rsanchez87 has quit IRC07:48
*** ljxiash has joined #openstack-lbaas07:54
*** bharathm has quit IRC07:57
*** yuanying has quit IRC08:05
bochi-michaelhi, I have a question about lbaas code,  could some one help me?08:08
bochi-michaelwhat is the relationship of neutron_lbaas/agent with neutron_lbaas/services/loadbalancer/agent ?08:09
*** kobis has joined #openstack-lbaas08:10
*** admin0 has joined #openstack-lbaas08:29
*** eezhova has joined #openstack-lbaas08:48
openstackgerritBo Chi proposed openstack/neutron-lbaas: Change status to DISABLED if admin_state_up if false  https://review.openstack.org/25587508:50
*** evgenyf has joined #openstack-lbaas09:00
*** EvgenyF_ has joined #openstack-lbaas09:00
*** admin0 has quit IRC09:09
*** ljxiash has quit IRC09:14
*** admin0 has joined #openstack-lbaas09:20
*** bana_k has quit IRC09:34
*** jschwarz has joined #openstack-lbaas09:36
*** openstackgerrit has quit IRC09:47
*** openstackgerrit has joined #openstack-lbaas09:48
*** Tiancheng has quit IRC09:57
*** evgenyf has quit IRC10:06
*** EvgenyF_ has quit IRC10:06
*** EvgenyF_ has joined #openstack-lbaas10:21
*** evgenyf has joined #openstack-lbaas10:21
*** EvgenyF__ has joined #openstack-lbaas10:25
*** EvgenyF_ has quit IRC10:28
*** openstackgerrit has quit IRC10:32
*** openstackgerrit has joined #openstack-lbaas10:33
*** bharathm has joined #openstack-lbaas10:58
*** bharathm has quit IRC11:03
*** bochi-michael has quit IRC11:04
*** bochi-michael has joined #openstack-lbaas11:05
*** admin0 has quit IRC11:11
*** admin0 has joined #openstack-lbaas11:12
*** ig0r_ has quit IRC11:20
*** bochi-michael has quit IRC11:24
*** yamamoto has quit IRC11:42
*** yamamoto has joined #openstack-lbaas11:44
openstackgerritKobi Samoray proposed openstack/neutron-lbaas: Add support X-Forwarded-For header  https://review.openstack.org/25596311:46
*** yamamoto has quit IRC11:51
*** yamamoto has joined #openstack-lbaas11:51
*** pc_m has left #openstack-lbaas12:11
*** yamamoto has quit IRC12:14
*** rtheis has joined #openstack-lbaas12:17
*** admin0 has quit IRC12:34
*** doug-fish has joined #openstack-lbaas12:35
*** Tiancheng has joined #openstack-lbaas12:43
openstackgerritMerged openstack/neutron-lbaas: Remove Neutron LBaaS static example configuration files  https://review.openstack.org/25594412:44
*** kobis has quit IRC12:50
*** admin0 has joined #openstack-lbaas12:52
*** ducttape_ has joined #openstack-lbaas12:52
*** yamamoto has joined #openstack-lbaas12:54
*** ducttape_ has quit IRC13:06
*** numans has quit IRC13:17
*** Tiancheng has quit IRC13:19
*** kobis has joined #openstack-lbaas13:19
*** ducttape_ has joined #openstack-lbaas13:30
*** whydidyoustealmy has joined #openstack-lbaas13:35
*** shakamunyi has joined #openstack-lbaas13:35
*** whydidyoustealmy is now known as superflyy13:36
*** yamamoto has quit IRC13:41
openstackgerritKobi Samoray proposed openstack/octavia: Implement XFF header support for Ocravia  https://review.openstack.org/25790113:45
openstackgerritKobi Samoray proposed openstack/neutron-lbaas: Add support X-Forwarded-For header  https://review.openstack.org/25596313:49
*** ducttape_ has quit IRC13:49
*** yamamoto has joined #openstack-lbaas13:56
*** Tiancheng has joined #openstack-lbaas13:57
openstackgerritKobi Samoray proposed openstack/octavia: Implement XFF header support for Octavia  https://review.openstack.org/25790113:58
*** rcernin has joined #openstack-lbaas14:02
*** amotoki has joined #openstack-lbaas14:03
*** ducttape_ has joined #openstack-lbaas14:36
*** ducttape_ has quit IRC14:53
openstackgerritKobi Samoray proposed openstack/neutron-lbaas: VMWare NSXv LBaaSv2 driver  https://review.openstack.org/22726615:14
*** ducttape_ has joined #openstack-lbaas15:19
*** ajmiller has joined #openstack-lbaas15:24
*** ljxiash has joined #openstack-lbaas15:25
*** doug-fish has quit IRC15:30
*** manishg has joined #openstack-lbaas15:35
*** ljxiash has quit IRC15:38
*** kobis has quit IRC15:41
*** manishg has quit IRC15:53
*** admin0 has quit IRC15:53
*** kobis has joined #openstack-lbaas15:56
*** rcernin has quit IRC15:58
*** manishg has joined #openstack-lbaas15:59
*** amotoki has quit IRC16:01
*** manishg has quit IRC16:04
*** Tiancheng has quit IRC16:10
*** nmagnezi has quit IRC16:18
johnsomAnybody have a second to point out what I am doing wrong with sqlalchemy?16:22
johnsomUnmappedInstanceError: Class '__builtin__.NoneType' is not mapped16:23
johnsomhttps://review.openstack.org/#/c/257643/1/octavia/controller/worker/tasks/database_tasks.py,cm16:23
*** jschwarz has quit IRC16:23
*** yamamoto has quit IRC16:25
*** yamamoto has joined #openstack-lbaas16:26
johnsomOk, I think it is just a strange way of reporting "not found" due to the way delete is implemented in the repos16:29
*** yamamoto has quit IRC16:39
johnsomSo I think we have two options here: https://github.com/openstack/octavia/blob/master/octavia/db/repositories.py#L6816:40
johnsom1. passively return if the record isn't found during a delete16:41
johnsom2. Setup a "not found" exception16:41
johnsomComments?  Input?16:41
openstackgerritKobi Samoray proposed openstack/neutron-lbaas: VMWare NSXv LBaaSv2 driver  https://review.openstack.org/22726616:47
ptoohillIf its not found you can assume its deleted? So would this not be a silent failure johnsom ?16:50
johnsomYeah, that is option 1.16:50
ptoohillyea, i like that16:51
ptoohillunless we have something broken and filters are processed right this should be acceptable16:51
ptoohillarnt*16:51
ptoohillarent&16:51
ptoohilla;skdhjf16:51
johnsomYeah.16:52
johnsomI was looking in neutron-lbaas.  There is an EntityNotFound exception over there.  Though it doesn't look like it is used consistently16:53
ptoohillwell i suppose things like neutron do throw a not found if you enter bad id. hrmm16:54
ptoohillbut this is within, do we have validation up front. I would need to double check this16:55
johnsomOk, I have decided to go with 1, passive delete.  Otherwise we would have a bunch of except blocks that just pass.17:05
ptoohillsounds good to me17:05
johnsomi.e. I'm not sure there is enough value in the exception17:05
*** manishg has joined #openstack-lbaas17:06
openstackgerritMichael Johnson proposed openstack/octavia: Disable amphora health monitoring on amp delete  https://review.openstack.org/25764317:06
*** neelashah has joined #openstack-lbaas17:07
*** thomasem-away is now known as thomasem17:09
rm_workjohnsom: that's weird, if it doesn't find anything there are a couple of SQLAlchemy exceptions that it would usually throw, i have never seen the one you're getting before...17:15
johnsomYep17:16
johnsomrm_work What is your thoughts on the solution?  passive failure on not found17:16
rm_workprobably17:19
rm_workwell in other systems we pass an "ignore_exceptions" param into the DB stuff17:19
rm_workbut the HOW doesn't matter much17:19
rm_workon a delete, on a not found, usually that's ignorable yes17:19
rm_workbut i'm still dubious of exactly what's happening if you're not getting an actual "no results found" exception17:20
rm_work(trying to remember the exact name of the exception you're supposed to see)17:20
bloganjohnsom: that doesn't seem right that it would throw that if its nto found17:20
bloganthis is on a delete?17:20
johnsomYep17:20
johnsomIt's a side effect of the way the repo is written.  It queries the model first.17:20
johnsomhttps://github.com/openstack/octavia/blob/master/octavia/db/repositories.py#L6817:21
rm_workerr17:21
rm_workso that should still work tho?17:21
rm_workis model_class not set?17:21
rm_worki mean, it looks like the obvious answer is "correct, model_class is unset"17:22
rm_workwhich ... shouldn't it be set? you're calling this on amp_health_repo, so unless that didn't properly set a self.model_class...17:23
johnsomIt is set.17:23
rm_workerr17:23
rm_workit looks like it isn't17:23
rm_workbased on the error17:23
rm_workotherwise your filter should run fine17:23
rm_workand first() should raise an actual no results found exception17:23
bloganoh then if model is None then just return a not found exception17:25
bloganthough i figured first() woudl do that17:25
rm_workblogan: he's saying it isn't17:25
rm_workand I am tracking that via the code17:25
rm_workit shouldn't be None17:25
rm_workso it must be something else breaking it17:25
rm_workjohnsom: is first() what you want17:28
rm_workor do you want17:28
rm_workhttp://docs.sqlalchemy.org/en/latest/orm/query.html#sqlalchemy.orm.query.Query.one17:28
rm_workor one_or_none()17:28
rm_workyou're supposed to get sqlalchemy.orm.exc.NoResultFound with first() as well as one() I think17:28
johnsomI don't know, I was a consumer of delete, not author17:28
rm_workah if it's a super-generic delete, i guess i can see why it'd just use first()17:29
blogani dont see why using first would be a problem anyway, if its supposed to throw a not found exception or continue on17:29
rm_workyeah it should be fine17:30
*** jschwarz has joined #openstack-lbaas17:30
rm_workand it should throw sqlalchemy.orm.exc.NoResultFound17:30
bloganjohnsom: what operation are you getting that exception on? first() or delete()?17:30
johnsomdelete17:31
johnsomhttp://logs.openstack.org/43/257643/1/check/gate-neutron-lbaasv2-dsvm-healthmonitor/03fea14/logs/screen-o-cw.txt.gz17:31
bloganjohnsom: so model is an instantiated instance?17:31
bloganby the time it gets to that call?17:31
johnsomThis is the code calling delete: https://review.openstack.org/#/c/257643/1/octavia/controller/worker/tasks/database_tasks.py,cm17:32
bloganyeah but does the first() actually return an instance or is it messed up?17:32
rm_workah yeah17:33
rm_workfirst() is fine17:33
rm_workapparently17:33
rm_workthe delete() dies17:33
rm_workso I guess first() returned a None?17:34
rm_workdidn't think that's how it works but I guess?17:34
johnsomThat is my guess as well17:34
bloganit should throw an exception, so it must have returned an actual value no?17:34
bloganoh nevermind it returns None17:34
blogani thought first raised an exception17:34
rm_workme too17:34
rm_workfirst() *should* logically behave like one() without the possibility of raising on Multiple17:35
bloganwhats the diff between one_or_none17:35
rm_worknot one_or_none()17:35
bloganoh reading the docs now17:35
rm_workso the docs don't list exceptions for first()17:35
bloganno bc it says it'll return None if not found17:36
rm_workwait17:36
rm_worki didn't see that in the docs17:36
* rm_work looks17:36
bloganReturn the first result of this Query or None if the result doesn’t contain any row.17:36
rm_workoh lol yeah17:36
rm_workfirst line17:36
bloganone() sounds like something you'd want17:36
rm_workyes, usually delete() should explicitly do a one()17:36
rm_worki can't think of a legit reason to want to delete the first() of something17:37
bloganwell in this case one may not be what you want, bc its a generic delete based on filters17:37
*** doug-fish has joined #openstack-lbaas17:37
*** doug-fish has quit IRC17:37
rm_workyeah but17:37
rm_workin what case would it make sense to match multiple things and just delete the first one?17:37
rm_workthat'd be nondeterministic17:37
bloganwell if you query by id, the first() item will be the item you want to delete17:37
rm_workerr17:38
rm_workif you query by id, there should be one() result17:38
bloganbut obviously one is the better solution17:38
*** doug-fish has joined #openstack-lbaas17:38
rm_workbut if you query by anything else ... is there a good reason you'd ever want to delete just the first of multiple results?17:38
rm_workjust based on DB ordering?17:38
bloganno, you're right there's not17:38
rm_workjohnsom: i don't know if it is outside your scope or not, but that first() should be changed to one()17:39
bloganso either use one, or iterate through a list and delete them17:39
blogana quick patch could be made17:39
rm_workpossibly in another patchset17:39
rm_workyeah17:39
bloganbut he's the only one hitting it17:39
johnsomI am happy to put up a patch.  Just wanted a consensus on the "right" answer.17:40
rm_workerr lost my connection, what was the last thing i said17:41
johnsomyeah17:41
rm_workblogan / johnsom ^^17:41
johnsompossibly in another patchset.17:42
johnsomThen I said: I am happy to put up a patch.  Just wanted a consensus on the "right" answer.17:42
rm_work[09:39:39]  <rm_work>assuming it doesn't break anything else17:42
rm_work[09:39:44]  <rm_work>i'm sure other places call delete()?17:42
rm_work[09:39:46]  <rm_work>no?17:42
rm_work[09:40:39]  <rm_work>johnsom: try just replacing first() with one() in your CR and see what happens :P17:42
rm_work[09:40:55]  <rm_work>you should get an exception instead of it just continuing, which you should be able to catch on your side17:42
rm_work[09:41:01]  <rm_work>sqlalchemy.orm.exc.NoResultFound17:42
rm_work[09:41:07]  <rm_work>and then you can ignore it17:42
*** kobis has quit IRC17:42
rm_worksince blogan thinks you're the only one deleting anything ^_^17:42
johnsomThat is what I expected.  Ok.  Yeah, there are a number of spots that delete is used17:43
rm_workok, then maybe another CR *is* best17:43
johnsomI will make it a different patch.  I think it's going to touch too much17:44
rm_workbut hopefully no one counts on it to do something dumb yet17:44
*** evgenyf has quit IRC17:55
openstackgerritMichael Johnson proposed openstack/octavia: Database repository delete to raise NoResultFound  https://review.openstack.org/25803117:55
*** EvgenyF__ has quit IRC17:55
johnsomWell, it passes tox.  I quoted rm_work on the exception it raises.17:55
rm_workheh17:55
johnsomLet's see what happens with the gate17:55
rm_workI would maybe have said "updates the db repository "delete" to use one() instead of first()17:56
rm_work"17:56
rm_workbecause that's far more important than just that it raises17:56
rm_workyou could have made it raise NoResultFound by adding a None check after first(), but that's very different17:57
openstackgerritMichael Johnson proposed openstack/octavia: Database repository delete to use one()  https://review.openstack.org/25803117:58
johnsomrm_work how is that?17:58
rm_workyeah sure :P18:00
rm_workdid you copy/paste my quote? lol18:00
johnsomYep\18:00
openstackgerritMichael Johnson proposed openstack/octavia: Disable amphora health monitoring on amp delete  https://review.openstack.org/25764318:05
johnsomUgh, that darn test order bug got me18:08
rm_workT_T18:14
rm_workwe should really fix those18:14
* rm_work sits back down and doesn't make eye contact with anyone18:14
*** bana_k has joined #openstack-lbaas18:21
*** madhu_ak has joined #openstack-lbaas18:27
*** armax has quit IRC18:29
*** jschwarz has quit IRC18:35
*** rsanchez87 has joined #openstack-lbaas18:42
*** harlowja_ has quit IRC18:49
*** harlowja has joined #openstack-lbaas18:50
*** bharathm has joined #openstack-lbaas18:51
bana_kjohnsom there ?18:56
johnsomHi bana_k18:56
bana_kHi18:56
bana_kI was looking at the neutron-db-manage18:57
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas: Updated from global requirements  https://review.openstack.org/25804618:57
bana_kwhen I am trying to create a new revision18:57
bana_kit complains about more than one head18:57
bana_kso I tried doing neutron-db-manage revision -m "description of revision" --contract18:58
bana_kbut still no luck18:58
openstackgerritOpenStack Proposal Bot proposed openstack/octavia: Updated from global requirements  https://review.openstack.org/25804918:58
bana_kas its not recognizing the --contract option18:58
bana_kam I missing anything ?18:59
johnsomHmm, multiple head means the revision/down revision chain is not right.18:59
bana_kI see that https://github.com/openstack/neutron-lbaas/blob/stable/liberty/neutron_lbaas/db/migration/alembic_migrations/versions/HEADS19:00
bana_khas two values, is that the prob?19:00
bloganbana_k: are you following this: https://github.com/openstack/neutron/blob/master/doc/source/devref/alembic_migrations.rst19:00
johnsomThat does seem unusual19:01
bloganpretty sure that's correct, expand and contract heads19:01
*** manishg has quit IRC19:01
bana_kblogan: I was looking at this19:01
bana_khttps://alembic.readthedocs.org/en/latest/tutorial.html#create-a-migration-script19:01
bana_kI can take a look at it.19:01
bloganbana_k: the one i linked is more specific for neutron19:01
*** manishg has joined #openstack-lbaas19:02
bana_kthanks blogan and johnsom : I ll read up on that and see if I can find something19:02
bloganso HEADS file isn't used anymore19:04
johnsomYeah, I thought we got rid of that19:05
bana_koh I see, I might have not understood the things properly.19:05
*** armax has joined #openstack-lbaas19:06
*** TrevorV has joined #openstack-lbaas19:08
*** neelashah has quit IRC19:31
*** openstackgerrit has quit IRC19:32
*** openstackgerrit has joined #openstack-lbaas19:33
*** manishg has quit IRC19:36
*** kobis has joined #openstack-lbaas19:38
*** manishg has joined #openstack-lbaas19:45
dougwigwe don't support down anymore.19:50
dougwigrm_work: i'm beginning to think you have a bot that just +2's any bot reviews in octavia.19:51
kobisdougwig: pushed another bug for the vmware v2 plugin19:53
*** neelashah has joined #openstack-lbaas19:53
rm_workdougwig: i am just always on :P19:56
rm_workand those reviews can't possibly break anything due to the way the versioning orks19:57
rm_work*works19:57
rm_workso they're an easy +219:57
*** manishg has quit IRC20:07
*** manishg has joined #openstack-lbaas20:10
rm_workjohnsom: I'm excited to see if the one() patch breaks anything horrifically :P20:15
johnsomYeah, me too.  Too bad zuul is so backed up20:16
rm_workI feel like this is the normal state for zuul20:16
ptoohilljohnsom: You said that bug was fixed, you know when thatll be available?20:22
ptoohillAnd, does that mean i can run the post flow as part of the same, larger, linear flow20:23
johnsomWhich bug?  I'm like four or five deep now....20:23
rm_work^^ truth20:23
johnsomAh, taskflow.  Yes, it fixes the after decider resumption of the main flow.20:23
ptoohill:P20:24
ptoohillHow do i get my hands on it?20:24
johnsomThe fix is here: https://review.openstack.org/#/c/246051/20:24
johnsomThe trick is there is a new parameter to the link:20:24
ptoohillah, k, so i should be ok to code against this for going forward?20:24
johnsomhttps://review.openstack.org/#/c/253724/6/octavia/controller/worker/flows/amphora_flows.py,cm20:25
johnsomline 23920:25
johnsomYeah, I am depending on it for the fail over flow update patches.20:25
ptoohillkk20:26
ptoohillThank you!20:26
johnsomThe only issue is I think our gates aren't pulling in the cross-repo dependencies, so they bomb out by pulling the pypi taskfow20:26
ptoohillhrmm20:26
johnsomLet me ping the taskflow folks on that patch.  I need to test again with the latest version.20:27
ptoohillgotcha, im going to start messing with this shortly. i ran into this issue, and having sep flows isnt going to work unless i build some random dict or something20:28
*** neelashah1 has joined #openstack-lbaas20:29
johnsomYeah, single flows are good for clean reverts.20:29
*** neelashah has quit IRC20:30
*** neelashah has joined #openstack-lbaas20:32
*** neelashah1 has quit IRC20:33
*** neelashah1 has joined #openstack-lbaas20:36
*** neelashah has quit IRC20:36
*** neelashah has joined #openstack-lbaas20:39
*** neelashah1 has quit IRC20:41
*** rm_you has quit IRC20:43
*** doug-fish has quit IRC20:58
ptoohilljohnsom: are you pulling taskflow down by itself or are you using devstack and i just dont have it set up?21:10
ptoohillwell, i suppose i know the answer21:11
johnsomI am pulling it down myself and python setup.py install21:11
*** ajmiller has quit IRC21:11
ptoohillgotcha21:11
ptoohillthank you21:11
*** ajmiller has joined #openstack-lbaas21:16
*** neelashah has quit IRC21:18
openstackgerritMerged openstack/octavia: Make Octavia devstack pass env settings to sudo pip install  https://review.openstack.org/25762921:19
*** admin0 has joined #openstack-lbaas21:22
*** doug-fish has joined #openstack-lbaas21:25
openstackgerritOpenStack Proposal Bot proposed openstack/octavia: Updated from global requirements  https://review.openstack.org/25804921:28
*** doug-fish has quit IRC21:29
rm_workooooo something to go +2 :P21:30
rm_work^^ dougwig21:30
rm_workah damn same patchset21:31
rm_workjust +A time21:31
rm_work... no changes. why did it get a new patchset?21:31
rm_workdevstack plugin change triggers it maybe?21:31
dougwigyou can diff between patchsets to see.21:50
rm_worki did21:50
rm_workno changes21:50
rm_workjust a rebase21:50
*** manishg has quit IRC21:58
*** doug-fish has joined #openstack-lbaas21:58
*** manishg has joined #openstack-lbaas22:01
*** manishg_ has joined #openstack-lbaas22:02
*** manishg has quit IRC22:05
*** ianbrown has quit IRC22:08
*** ianbrown has joined #openstack-lbaas22:09
*** rtheis has quit IRC22:10
*** rcernin has joined #openstack-lbaas22:16
*** doug-fish has quit IRC22:22
*** admin0 has quit IRC22:28
*** ducttape_ has quit IRC22:46
*** ducttape_ has joined #openstack-lbaas22:49
*** manishg_ has quit IRC22:59
*** manishg has joined #openstack-lbaas23:02
*** yuanying has joined #openstack-lbaas23:02
*** yuanying has quit IRC23:03
*** yuanying has joined #openstack-lbaas23:04
*** manishg has quit IRC23:07
*** manishg has joined #openstack-lbaas23:07
openstackgerritAdam Harwell proposed openstack/neutron-lbaas: Refactor BarbicanAuth to allow for configurable auth method  https://review.openstack.org/25618423:10
*** rcernin has quit IRC23:20
HenryGFollowing up on a bug from last week: Bug #152467523:44
openstackbug 1524675 in OpenStack Security Advisory "lbaasv2-agent is logging credentials from barbican" [Undecided,Incomplete] https://launchpad.net/bugs/152467523:44
HenryGCan someone confirm it and find an assignee?23:45
rm_workhmm23:45
rm_workthat sounds related to the code i'm touching23:45
*** manishg has quit IRC23:53
*** chlong has quit IRC23:59
HenryGreedip: ping23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!