johnsom | Thanks again with the troubleshooting help | 00:03 |
---|---|---|
*** ducttape_ has joined #openstack-lbaas | 00:20 | |
johnsom | Yep, fixed | 00:24 |
blogan | johnsom: np anytime, one of those unexpected nova neutron interactions | 00:26 |
johnsom | Yep. You saved me a bunch of time tracking that down. | 00:26 |
*** ducttape_ has quit IRC | 00:33 | |
openstackgerrit | James Arendt proposed openstack/octavia: Make Octavia devstack pass env settings to sudo pip install https://review.openstack.org/257629 | 00:34 |
*** ducttape_ has joined #openstack-lbaas | 00:43 | |
*** manishg has quit IRC | 01:01 | |
*** manishg has joined #openstack-lbaas | 01:01 | |
*** ajmiller has quit IRC | 01:02 | |
*** manishg_ has joined #openstack-lbaas | 01:04 | |
*** openstack has joined #openstack-lbaas | 01:06 | |
-wolfe.freenode.net- [freenode-info] channel flooding and no channel staff around to help? Please check with freenode support: http://freenode.net/faq.shtml#gettinghelp | 01:06 | |
*** manishg has quit IRC | 01:07 | |
*** sbalukoff has joined #openstack-lbaas | 01:15 | |
*** manishg_ has quit IRC | 01:19 | |
*** Aish has quit IRC | 01:22 | |
*** bharathm has quit IRC | 01:26 | |
*** crc32 has quit IRC | 01:29 | |
bana_k | Hello ! need some help with the alembic | 01:35 |
bana_k | any experts here | 01:35 |
*** ducttape_ has quit IRC | 01:40 | |
*** yamamoto has joined #openstack-lbaas | 01:42 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Disable amphora health monitoring on amp delete https://review.openstack.org/257643 | 01:49 |
*** Aish has joined #openstack-lbaas | 01:50 | |
*** manishg has joined #openstack-lbaas | 01:50 | |
johnsom | ^^^ that is a nasty little bug. | 01:50 |
johnsom | bana_k I might be able to help, what is up? | 01:50 |
*** yamamoto has quit IRC | 01:52 | |
*** yamamoto has joined #openstack-lbaas | 01:52 | |
bana_k | Thanks johnsom, I am trying to add some tables to the lbaas | 01:53 |
johnsom | Ok | 01:53 |
bana_k | so added a new file in the db/migration/alembic_migrations/versions | 01:53 |
bana_k | si that right thing to do ? | 01:53 |
johnsom | Yes | 01:54 |
bana_k | johnsom: there use to be neutron-*-db-manage file to run to create these new tables | 01:54 |
bana_k | but I am not finding it on here | 01:54 |
*** manishg has quit IRC | 01:54 | |
johnsom | alembic will generate the template file | 01:54 |
bana_k | what command I should run to do that ? | 01:55 |
johnsom | Just a second, let me look that up again, I always forget. | 01:55 |
johnsom | The db manage tool comes with neutron | 01:55 |
bana_k | oh ok. | 01:55 |
*** yamamoto has quit IRC | 01:56 | |
johnsom | https://alembic.readthedocs.org/en/latest/tutorial.html#create-a-migration-script | 01:56 |
johnsom | alembic revision -m "create account table" | 01:56 |
*** ducttape_ has joined #openstack-lbaas | 01:56 | |
johnsom | The nice thing about that is it gets the revisions right. | 01:56 |
johnsom | now, I need to think about the conf file you need | 01:57 |
*** Tiancheng has joined #openstack-lbaas | 01:57 | |
johnsom | Well, I guess you can just run that command and then manually add the down revision if you want | 01:58 |
bana_k | oh cool, I will try this one | 01:58 |
johnsom | Ah, wait. | 01:58 |
johnsom | So, I always get this confused since octavia has it's own config. | 01:59 |
johnsom | You can use neutron-db-manage to create a revision file too | 01:59 |
bana_k | oh I will try, the only problem is I am not finding the neutron-db-manage file in my setup, I think may be I am looking at the wrong place. | 02:00 |
johnsom | so I think it is 'neutron-db-manage --subproject neutron-lbaas revision -m "create account table"' | 02:00 |
johnsom | pip install neutron | 02:00 |
johnsom | or check it out and python setup.py install | 02:01 |
bana_k | johnsom : I will try it out. thanks a lot for all the help | 02:01 |
johnsom | I'm not as familiar with neutron-db-manage, so there might need to be a config file. I'm not sure how it finds the neutron-lbaas directory either. | 02:02 |
bana_k | oh ok np, actually we pass the config file like this test-db-manage --config-file /etc/neutron/neutron.conf upgrade head | 02:02 |
bana_k | but I am too not sure how it finds the lbaas folder. | 02:03 |
johnsom | interesting. | 02:03 |
johnsom | Well, hopefully I gave you some pointers | 02:03 |
johnsom | Remember to make sure the down revision is the current "HEAD" revision | 02:04 |
johnsom | So remember, we don't implement downgrade code any longer | 02:04 |
bana_k | yes johnsom, that was very useful. | 02:04 |
bana_k | thanks again for the help. | 02:04 |
johnsom | Cool. Good luch | 02:04 |
johnsom | luck | 02:04 |
bana_k | thanks :) | 02:04 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Updates the failover flow for active/standby https://review.openstack.org/253724 | 02:05 |
*** ducttape_ has quit IRC | 02:06 | |
*** rsanchez87 has quit IRC | 02:08 | |
*** rsanchez87 has joined #openstack-lbaas | 02:08 | |
*** rsanchez87 has quit IRC | 02:08 | |
*** Aish has quit IRC | 02:13 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Updates the failover flow for active/standby https://review.openstack.org/253724 | 02:20 |
*** bana_k has quit IRC | 02:21 | |
*** Aish has joined #openstack-lbaas | 02:33 | |
*** Aish has left #openstack-lbaas | 02:33 | |
*** manishg has joined #openstack-lbaas | 02:37 | |
*** bana_k has joined #openstack-lbaas | 02:46 | |
*** ianbrown has quit IRC | 02:46 | |
*** rsanchez87 has joined #openstack-lbaas | 02:46 | |
*** rsanchez87 has quit IRC | 02:46 | |
*** ianbrown has joined #openstack-lbaas | 02:47 | |
*** bochi-michael has joined #openstack-lbaas | 02:48 | |
*** yamamoto has joined #openstack-lbaas | 02:54 | |
*** woodster_ has quit IRC | 02:56 | |
*** manishg has quit IRC | 03:14 | |
*** ljxias___ has joined #openstack-lbaas | 03:18 | |
*** yuanying has quit IRC | 03:20 | |
*** rsanchez87 has joined #openstack-lbaas | 03:24 | |
*** ducttape_ has joined #openstack-lbaas | 03:29 | |
*** ljxias___ has quit IRC | 03:40 | |
*** bana_k has quit IRC | 03:45 | |
*** ducttape_ has quit IRC | 04:04 | |
*** yuanying has joined #openstack-lbaas | 04:07 | |
*** rsanchez87 has quit IRC | 04:17 | |
*** rsanchez87 has joined #openstack-lbaas | 04:19 | |
*** openstack has joined #openstack-lbaas | 04:27 | |
*** ducttape_ has joined #openstack-lbaas | 04:29 | |
*** bharathm has quit IRC | 04:31 | |
*** madhu_ak has quit IRC | 04:36 | |
*** ducttape_ has quit IRC | 04:39 | |
*** numans has joined #openstack-lbaas | 04:41 | |
*** ducttape_ has joined #openstack-lbaas | 05:01 | |
*** ducttape_ has quit IRC | 05:09 | |
*** bharathm has joined #openstack-lbaas | 05:42 | |
*** rm_work has quit IRC | 05:59 | |
*** rm_work has joined #openstack-lbaas | 06:22 | |
*** bharathm has quit IRC | 07:04 | |
*** bana_k has joined #openstack-lbaas | 07:07 | |
*** bharathm has joined #openstack-lbaas | 07:19 | |
*** nmagnezi has joined #openstack-lbaas | 07:24 | |
*** rsanchez87 has quit IRC | 07:48 | |
*** ljxiash has joined #openstack-lbaas | 07:54 | |
*** bharathm has quit IRC | 07:57 | |
*** yuanying has quit IRC | 08:05 | |
bochi-michael | hi, I have a question about lbaas code, could some one help me? | 08:08 |
bochi-michael | what is the relationship of neutron_lbaas/agent with neutron_lbaas/services/loadbalancer/agent ? | 08:09 |
*** kobis has joined #openstack-lbaas | 08:10 | |
*** admin0 has joined #openstack-lbaas | 08:29 | |
*** eezhova has joined #openstack-lbaas | 08:48 | |
openstackgerrit | Bo Chi proposed openstack/neutron-lbaas: Change status to DISABLED if admin_state_up if false https://review.openstack.org/255875 | 08:50 |
*** evgenyf has joined #openstack-lbaas | 09:00 | |
*** EvgenyF_ has joined #openstack-lbaas | 09:00 | |
*** admin0 has quit IRC | 09:09 | |
*** ljxiash has quit IRC | 09:14 | |
*** admin0 has joined #openstack-lbaas | 09:20 | |
*** bana_k has quit IRC | 09:34 | |
*** jschwarz has joined #openstack-lbaas | 09:36 | |
*** openstackgerrit has quit IRC | 09:47 | |
*** openstackgerrit has joined #openstack-lbaas | 09:48 | |
*** Tiancheng has quit IRC | 09:57 | |
*** evgenyf has quit IRC | 10:06 | |
*** EvgenyF_ has quit IRC | 10:06 | |
*** EvgenyF_ has joined #openstack-lbaas | 10:21 | |
*** evgenyf has joined #openstack-lbaas | 10:21 | |
*** EvgenyF__ has joined #openstack-lbaas | 10:25 | |
*** EvgenyF_ has quit IRC | 10:28 | |
*** openstackgerrit has quit IRC | 10:32 | |
*** openstackgerrit has joined #openstack-lbaas | 10:33 | |
*** bharathm has joined #openstack-lbaas | 10:58 | |
*** bharathm has quit IRC | 11:03 | |
*** bochi-michael has quit IRC | 11:04 | |
*** bochi-michael has joined #openstack-lbaas | 11:05 | |
*** admin0 has quit IRC | 11:11 | |
*** admin0 has joined #openstack-lbaas | 11:12 | |
*** ig0r_ has quit IRC | 11:20 | |
*** bochi-michael has quit IRC | 11:24 | |
*** yamamoto has quit IRC | 11:42 | |
*** yamamoto has joined #openstack-lbaas | 11:44 | |
openstackgerrit | Kobi Samoray proposed openstack/neutron-lbaas: Add support X-Forwarded-For header https://review.openstack.org/255963 | 11:46 |
*** yamamoto has quit IRC | 11:51 | |
*** yamamoto has joined #openstack-lbaas | 11:51 | |
*** pc_m has left #openstack-lbaas | 12:11 | |
*** yamamoto has quit IRC | 12:14 | |
*** rtheis has joined #openstack-lbaas | 12:17 | |
*** admin0 has quit IRC | 12:34 | |
*** doug-fish has joined #openstack-lbaas | 12:35 | |
*** Tiancheng has joined #openstack-lbaas | 12:43 | |
openstackgerrit | Merged openstack/neutron-lbaas: Remove Neutron LBaaS static example configuration files https://review.openstack.org/255944 | 12:44 |
*** kobis has quit IRC | 12:50 | |
*** admin0 has joined #openstack-lbaas | 12:52 | |
*** ducttape_ has joined #openstack-lbaas | 12:52 | |
*** yamamoto has joined #openstack-lbaas | 12:54 | |
*** ducttape_ has quit IRC | 13:06 | |
*** numans has quit IRC | 13:17 | |
*** Tiancheng has quit IRC | 13:19 | |
*** kobis has joined #openstack-lbaas | 13:19 | |
*** ducttape_ has joined #openstack-lbaas | 13:30 | |
*** whydidyoustealmy has joined #openstack-lbaas | 13:35 | |
*** shakamunyi has joined #openstack-lbaas | 13:35 | |
*** whydidyoustealmy is now known as superflyy | 13:36 | |
*** yamamoto has quit IRC | 13:41 | |
openstackgerrit | Kobi Samoray proposed openstack/octavia: Implement XFF header support for Ocravia https://review.openstack.org/257901 | 13:45 |
openstackgerrit | Kobi Samoray proposed openstack/neutron-lbaas: Add support X-Forwarded-For header https://review.openstack.org/255963 | 13:49 |
*** ducttape_ has quit IRC | 13:49 | |
*** yamamoto has joined #openstack-lbaas | 13:56 | |
*** Tiancheng has joined #openstack-lbaas | 13:57 | |
openstackgerrit | Kobi Samoray proposed openstack/octavia: Implement XFF header support for Octavia https://review.openstack.org/257901 | 13:58 |
*** rcernin has joined #openstack-lbaas | 14:02 | |
*** amotoki has joined #openstack-lbaas | 14:03 | |
*** ducttape_ has joined #openstack-lbaas | 14:36 | |
*** ducttape_ has quit IRC | 14:53 | |
openstackgerrit | Kobi Samoray proposed openstack/neutron-lbaas: VMWare NSXv LBaaSv2 driver https://review.openstack.org/227266 | 15:14 |
*** ducttape_ has joined #openstack-lbaas | 15:19 | |
*** ajmiller has joined #openstack-lbaas | 15:24 | |
*** ljxiash has joined #openstack-lbaas | 15:25 | |
*** doug-fish has quit IRC | 15:30 | |
*** manishg has joined #openstack-lbaas | 15:35 | |
*** ljxiash has quit IRC | 15:38 | |
*** kobis has quit IRC | 15:41 | |
*** manishg has quit IRC | 15:53 | |
*** admin0 has quit IRC | 15:53 | |
*** kobis has joined #openstack-lbaas | 15:56 | |
*** rcernin has quit IRC | 15:58 | |
*** manishg has joined #openstack-lbaas | 15:59 | |
*** amotoki has quit IRC | 16:01 | |
*** manishg has quit IRC | 16:04 | |
*** Tiancheng has quit IRC | 16:10 | |
*** nmagnezi has quit IRC | 16:18 | |
johnsom | Anybody have a second to point out what I am doing wrong with sqlalchemy? | 16:22 |
johnsom | UnmappedInstanceError: Class '__builtin__.NoneType' is not mapped | 16:23 |
johnsom | https://review.openstack.org/#/c/257643/1/octavia/controller/worker/tasks/database_tasks.py,cm | 16:23 |
*** jschwarz has quit IRC | 16:23 | |
*** yamamoto has quit IRC | 16:25 | |
*** yamamoto has joined #openstack-lbaas | 16:26 | |
johnsom | Ok, I think it is just a strange way of reporting "not found" due to the way delete is implemented in the repos | 16:29 |
*** yamamoto has quit IRC | 16:39 | |
johnsom | So I think we have two options here: https://github.com/openstack/octavia/blob/master/octavia/db/repositories.py#L68 | 16:40 |
johnsom | 1. passively return if the record isn't found during a delete | 16:41 |
johnsom | 2. Setup a "not found" exception | 16:41 |
johnsom | Comments? Input? | 16:41 |
openstackgerrit | Kobi Samoray proposed openstack/neutron-lbaas: VMWare NSXv LBaaSv2 driver https://review.openstack.org/227266 | 16:47 |
ptoohill | If its not found you can assume its deleted? So would this not be a silent failure johnsom ? | 16:50 |
johnsom | Yeah, that is option 1. | 16:50 |
ptoohill | yea, i like that | 16:51 |
ptoohill | unless we have something broken and filters are processed right this should be acceptable | 16:51 |
ptoohill | arnt* | 16:51 |
ptoohill | arent& | 16:51 |
ptoohill | a;skdhjf | 16:51 |
johnsom | Yeah. | 16:52 |
johnsom | I was looking in neutron-lbaas. There is an EntityNotFound exception over there. Though it doesn't look like it is used consistently | 16:53 |
ptoohill | well i suppose things like neutron do throw a not found if you enter bad id. hrmm | 16:54 |
ptoohill | but this is within, do we have validation up front. I would need to double check this | 16:55 |
johnsom | Ok, I have decided to go with 1, passive delete. Otherwise we would have a bunch of except blocks that just pass. | 17:05 |
ptoohill | sounds good to me | 17:05 |
johnsom | i.e. I'm not sure there is enough value in the exception | 17:05 |
*** manishg has joined #openstack-lbaas | 17:06 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Disable amphora health monitoring on amp delete https://review.openstack.org/257643 | 17:06 |
*** neelashah has joined #openstack-lbaas | 17:07 | |
*** thomasem-away is now known as thomasem | 17:09 | |
rm_work | johnsom: that's weird, if it doesn't find anything there are a couple of SQLAlchemy exceptions that it would usually throw, i have never seen the one you're getting before... | 17:15 |
johnsom | Yep | 17:16 |
johnsom | rm_work What is your thoughts on the solution? passive failure on not found | 17:16 |
rm_work | probably | 17:19 |
rm_work | well in other systems we pass an "ignore_exceptions" param into the DB stuff | 17:19 |
rm_work | but the HOW doesn't matter much | 17:19 |
rm_work | on a delete, on a not found, usually that's ignorable yes | 17:19 |
rm_work | but i'm still dubious of exactly what's happening if you're not getting an actual "no results found" exception | 17:20 |
rm_work | (trying to remember the exact name of the exception you're supposed to see) | 17:20 |
blogan | johnsom: that doesn't seem right that it would throw that if its nto found | 17:20 |
blogan | this is on a delete? | 17:20 |
johnsom | Yep | 17:20 |
johnsom | It's a side effect of the way the repo is written. It queries the model first. | 17:20 |
johnsom | https://github.com/openstack/octavia/blob/master/octavia/db/repositories.py#L68 | 17:21 |
rm_work | err | 17:21 |
rm_work | so that should still work tho? | 17:21 |
rm_work | is model_class not set? | 17:21 |
rm_work | i mean, it looks like the obvious answer is "correct, model_class is unset" | 17:22 |
rm_work | which ... shouldn't it be set? you're calling this on amp_health_repo, so unless that didn't properly set a self.model_class... | 17:23 |
johnsom | It is set. | 17:23 |
rm_work | err | 17:23 |
rm_work | it looks like it isn't | 17:23 |
rm_work | based on the error | 17:23 |
rm_work | otherwise your filter should run fine | 17:23 |
rm_work | and first() should raise an actual no results found exception | 17:23 |
blogan | oh then if model is None then just return a not found exception | 17:25 |
blogan | though i figured first() woudl do that | 17:25 |
rm_work | blogan: he's saying it isn't | 17:25 |
rm_work | and I am tracking that via the code | 17:25 |
rm_work | it shouldn't be None | 17:25 |
rm_work | so it must be something else breaking it | 17:25 |
rm_work | johnsom: is first() what you want | 17:28 |
rm_work | or do you want | 17:28 |
rm_work | http://docs.sqlalchemy.org/en/latest/orm/query.html#sqlalchemy.orm.query.Query.one | 17:28 |
rm_work | or one_or_none() | 17:28 |
rm_work | you're supposed to get sqlalchemy.orm.exc.NoResultFound with first() as well as one() I think | 17:28 |
johnsom | I don't know, I was a consumer of delete, not author | 17:28 |
rm_work | ah if it's a super-generic delete, i guess i can see why it'd just use first() | 17:29 |
blogan | i dont see why using first would be a problem anyway, if its supposed to throw a not found exception or continue on | 17:29 |
rm_work | yeah it should be fine | 17:30 |
*** jschwarz has joined #openstack-lbaas | 17:30 | |
rm_work | and it should throw sqlalchemy.orm.exc.NoResultFound | 17:30 |
blogan | johnsom: what operation are you getting that exception on? first() or delete()? | 17:30 |
johnsom | delete | 17:31 |
johnsom | http://logs.openstack.org/43/257643/1/check/gate-neutron-lbaasv2-dsvm-healthmonitor/03fea14/logs/screen-o-cw.txt.gz | 17:31 |
blogan | johnsom: so model is an instantiated instance? | 17:31 |
blogan | by the time it gets to that call? | 17:31 |
johnsom | This is the code calling delete: https://review.openstack.org/#/c/257643/1/octavia/controller/worker/tasks/database_tasks.py,cm | 17:32 |
blogan | yeah but does the first() actually return an instance or is it messed up? | 17:32 |
rm_work | ah yeah | 17:33 |
rm_work | first() is fine | 17:33 |
rm_work | apparently | 17:33 |
rm_work | the delete() dies | 17:33 |
rm_work | so I guess first() returned a None? | 17:34 |
rm_work | didn't think that's how it works but I guess? | 17:34 |
johnsom | That is my guess as well | 17:34 |
blogan | it should throw an exception, so it must have returned an actual value no? | 17:34 |
blogan | oh nevermind it returns None | 17:34 |
blogan | i thought first raised an exception | 17:34 |
rm_work | me too | 17:34 |
rm_work | first() *should* logically behave like one() without the possibility of raising on Multiple | 17:35 |
blogan | whats the diff between one_or_none | 17:35 |
rm_work | not one_or_none() | 17:35 |
blogan | oh reading the docs now | 17:35 |
rm_work | so the docs don't list exceptions for first() | 17:35 |
blogan | no bc it says it'll return None if not found | 17:36 |
rm_work | wait | 17:36 |
rm_work | i didn't see that in the docs | 17:36 |
* rm_work looks | 17:36 | |
blogan | Return the first result of this Query or None if the result doesn’t contain any row. | 17:36 |
rm_work | oh lol yeah | 17:36 |
rm_work | first line | 17:36 |
blogan | one() sounds like something you'd want | 17:36 |
rm_work | yes, usually delete() should explicitly do a one() | 17:36 |
rm_work | i can't think of a legit reason to want to delete the first() of something | 17:37 |
blogan | well in this case one may not be what you want, bc its a generic delete based on filters | 17:37 |
*** doug-fish has joined #openstack-lbaas | 17:37 | |
*** doug-fish has quit IRC | 17:37 | |
rm_work | yeah but | 17:37 |
rm_work | in what case would it make sense to match multiple things and just delete the first one? | 17:37 |
rm_work | that'd be nondeterministic | 17:37 |
blogan | well if you query by id, the first() item will be the item you want to delete | 17:37 |
rm_work | err | 17:38 |
rm_work | if you query by id, there should be one() result | 17:38 |
blogan | but obviously one is the better solution | 17:38 |
*** doug-fish has joined #openstack-lbaas | 17:38 | |
rm_work | but if you query by anything else ... is there a good reason you'd ever want to delete just the first of multiple results? | 17:38 |
rm_work | just based on DB ordering? | 17:38 |
blogan | no, you're right there's not | 17:38 |
rm_work | johnsom: i don't know if it is outside your scope or not, but that first() should be changed to one() | 17:39 |
blogan | so either use one, or iterate through a list and delete them | 17:39 |
blogan | a quick patch could be made | 17:39 |
rm_work | possibly in another patchset | 17:39 |
rm_work | yeah | 17:39 |
blogan | but he's the only one hitting it | 17:39 |
johnsom | I am happy to put up a patch. Just wanted a consensus on the "right" answer. | 17:40 |
rm_work | err lost my connection, what was the last thing i said | 17:41 |
johnsom | yeah | 17:41 |
rm_work | blogan / johnsom ^^ | 17:41 |
johnsom | possibly in another patchset. | 17:42 |
johnsom | Then I said: I am happy to put up a patch. Just wanted a consensus on the "right" answer. | 17:42 |
rm_work | [09:39:39] <rm_work>assuming it doesn't break anything else | 17:42 |
rm_work | [09:39:44] <rm_work>i'm sure other places call delete()? | 17:42 |
rm_work | [09:39:46] <rm_work>no? | 17:42 |
rm_work | [09:40:39] <rm_work>johnsom: try just replacing first() with one() in your CR and see what happens :P | 17:42 |
rm_work | [09:40:55] <rm_work>you should get an exception instead of it just continuing, which you should be able to catch on your side | 17:42 |
rm_work | [09:41:01] <rm_work>sqlalchemy.orm.exc.NoResultFound | 17:42 |
rm_work | [09:41:07] <rm_work>and then you can ignore it | 17:42 |
*** kobis has quit IRC | 17:42 | |
rm_work | since blogan thinks you're the only one deleting anything ^_^ | 17:42 |
johnsom | That is what I expected. Ok. Yeah, there are a number of spots that delete is used | 17:43 |
rm_work | ok, then maybe another CR *is* best | 17:43 |
johnsom | I will make it a different patch. I think it's going to touch too much | 17:44 |
rm_work | but hopefully no one counts on it to do something dumb yet | 17:44 |
*** evgenyf has quit IRC | 17:55 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Database repository delete to raise NoResultFound https://review.openstack.org/258031 | 17:55 |
*** EvgenyF__ has quit IRC | 17:55 | |
johnsom | Well, it passes tox. I quoted rm_work on the exception it raises. | 17:55 |
rm_work | heh | 17:55 |
johnsom | Let's see what happens with the gate | 17:55 |
rm_work | I would maybe have said "updates the db repository "delete" to use one() instead of first() | 17:56 |
rm_work | " | 17:56 |
rm_work | because that's far more important than just that it raises | 17:56 |
rm_work | you could have made it raise NoResultFound by adding a None check after first(), but that's very different | 17:57 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Database repository delete to use one() https://review.openstack.org/258031 | 17:58 |
johnsom | rm_work how is that? | 17:58 |
rm_work | yeah sure :P | 18:00 |
rm_work | did you copy/paste my quote? lol | 18:00 |
johnsom | Yep\ | 18:00 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Disable amphora health monitoring on amp delete https://review.openstack.org/257643 | 18:05 |
johnsom | Ugh, that darn test order bug got me | 18:08 |
rm_work | T_T | 18:14 |
rm_work | we should really fix those | 18:14 |
* rm_work sits back down and doesn't make eye contact with anyone | 18:14 | |
*** bana_k has joined #openstack-lbaas | 18:21 | |
*** madhu_ak has joined #openstack-lbaas | 18:27 | |
*** armax has quit IRC | 18:29 | |
*** jschwarz has quit IRC | 18:35 | |
*** rsanchez87 has joined #openstack-lbaas | 18:42 | |
*** harlowja_ has quit IRC | 18:49 | |
*** harlowja has joined #openstack-lbaas | 18:50 | |
*** bharathm has joined #openstack-lbaas | 18:51 | |
bana_k | johnsom there ? | 18:56 |
johnsom | Hi bana_k | 18:56 |
bana_k | Hi | 18:56 |
bana_k | I was looking at the neutron-db-manage | 18:57 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas: Updated from global requirements https://review.openstack.org/258046 | 18:57 |
bana_k | when I am trying to create a new revision | 18:57 |
bana_k | it complains about more than one head | 18:57 |
bana_k | so I tried doing neutron-db-manage revision -m "description of revision" --contract | 18:58 |
bana_k | but still no luck | 18:58 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia: Updated from global requirements https://review.openstack.org/258049 | 18:58 |
bana_k | as its not recognizing the --contract option | 18:58 |
bana_k | am I missing anything ? | 18:59 |
johnsom | Hmm, multiple head means the revision/down revision chain is not right. | 18:59 |
bana_k | I see that https://github.com/openstack/neutron-lbaas/blob/stable/liberty/neutron_lbaas/db/migration/alembic_migrations/versions/HEADS | 19:00 |
bana_k | has two values, is that the prob? | 19:00 |
blogan | bana_k: are you following this: https://github.com/openstack/neutron/blob/master/doc/source/devref/alembic_migrations.rst | 19:00 |
johnsom | That does seem unusual | 19:01 |
blogan | pretty sure that's correct, expand and contract heads | 19:01 |
*** manishg has quit IRC | 19:01 | |
bana_k | blogan: I was looking at this | 19:01 |
bana_k | https://alembic.readthedocs.org/en/latest/tutorial.html#create-a-migration-script | 19:01 |
bana_k | I can take a look at it. | 19:01 |
blogan | bana_k: the one i linked is more specific for neutron | 19:01 |
*** manishg has joined #openstack-lbaas | 19:02 | |
bana_k | thanks blogan and johnsom : I ll read up on that and see if I can find something | 19:02 |
blogan | so HEADS file isn't used anymore | 19:04 |
johnsom | Yeah, I thought we got rid of that | 19:05 |
bana_k | oh I see, I might have not understood the things properly. | 19:05 |
*** armax has joined #openstack-lbaas | 19:06 | |
*** TrevorV has joined #openstack-lbaas | 19:08 | |
*** neelashah has quit IRC | 19:31 | |
*** openstackgerrit has quit IRC | 19:32 | |
*** openstackgerrit has joined #openstack-lbaas | 19:33 | |
*** manishg has quit IRC | 19:36 | |
*** kobis has joined #openstack-lbaas | 19:38 | |
*** manishg has joined #openstack-lbaas | 19:45 | |
dougwig | we don't support down anymore. | 19:50 |
dougwig | rm_work: i'm beginning to think you have a bot that just +2's any bot reviews in octavia. | 19:51 |
kobis | dougwig: pushed another bug for the vmware v2 plugin | 19:53 |
*** neelashah has joined #openstack-lbaas | 19:53 | |
rm_work | dougwig: i am just always on :P | 19:56 |
rm_work | and those reviews can't possibly break anything due to the way the versioning orks | 19:57 |
rm_work | *works | 19:57 |
rm_work | so they're an easy +2 | 19:57 |
*** manishg has quit IRC | 20:07 | |
*** manishg has joined #openstack-lbaas | 20:10 | |
rm_work | johnsom: I'm excited to see if the one() patch breaks anything horrifically :P | 20:15 |
johnsom | Yeah, me too. Too bad zuul is so backed up | 20:16 |
rm_work | I feel like this is the normal state for zuul | 20:16 |
ptoohill | johnsom: You said that bug was fixed, you know when thatll be available? | 20:22 |
ptoohill | And, does that mean i can run the post flow as part of the same, larger, linear flow | 20:23 |
johnsom | Which bug? I'm like four or five deep now.... | 20:23 |
rm_work | ^^ truth | 20:23 |
johnsom | Ah, taskflow. Yes, it fixes the after decider resumption of the main flow. | 20:23 |
ptoohill | :P | 20:24 |
ptoohill | How do i get my hands on it? | 20:24 |
johnsom | The fix is here: https://review.openstack.org/#/c/246051/ | 20:24 |
johnsom | The trick is there is a new parameter to the link: | 20:24 |
ptoohill | ah, k, so i should be ok to code against this for going forward? | 20:24 |
johnsom | https://review.openstack.org/#/c/253724/6/octavia/controller/worker/flows/amphora_flows.py,cm | 20:25 |
johnsom | line 239 | 20:25 |
johnsom | Yeah, I am depending on it for the fail over flow update patches. | 20:25 |
ptoohill | kk | 20:26 |
ptoohill | Thank you! | 20:26 |
johnsom | The only issue is I think our gates aren't pulling in the cross-repo dependencies, so they bomb out by pulling the pypi taskfow | 20:26 |
ptoohill | hrmm | 20:26 |
johnsom | Let me ping the taskflow folks on that patch. I need to test again with the latest version. | 20:27 |
ptoohill | gotcha, im going to start messing with this shortly. i ran into this issue, and having sep flows isnt going to work unless i build some random dict or something | 20:28 |
*** neelashah1 has joined #openstack-lbaas | 20:29 | |
johnsom | Yeah, single flows are good for clean reverts. | 20:29 |
*** neelashah has quit IRC | 20:30 | |
*** neelashah has joined #openstack-lbaas | 20:32 | |
*** neelashah1 has quit IRC | 20:33 | |
*** neelashah1 has joined #openstack-lbaas | 20:36 | |
*** neelashah has quit IRC | 20:36 | |
*** neelashah has joined #openstack-lbaas | 20:39 | |
*** neelashah1 has quit IRC | 20:41 | |
*** rm_you has quit IRC | 20:43 | |
*** doug-fish has quit IRC | 20:58 | |
ptoohill | johnsom: are you pulling taskflow down by itself or are you using devstack and i just dont have it set up? | 21:10 |
ptoohill | well, i suppose i know the answer | 21:11 |
johnsom | I am pulling it down myself and python setup.py install | 21:11 |
*** ajmiller has quit IRC | 21:11 | |
ptoohill | gotcha | 21:11 |
ptoohill | thank you | 21:11 |
*** ajmiller has joined #openstack-lbaas | 21:16 | |
*** neelashah has quit IRC | 21:18 | |
openstackgerrit | Merged openstack/octavia: Make Octavia devstack pass env settings to sudo pip install https://review.openstack.org/257629 | 21:19 |
*** admin0 has joined #openstack-lbaas | 21:22 | |
*** doug-fish has joined #openstack-lbaas | 21:25 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia: Updated from global requirements https://review.openstack.org/258049 | 21:28 |
*** doug-fish has quit IRC | 21:29 | |
rm_work | ooooo something to go +2 :P | 21:30 |
rm_work | ^^ dougwig | 21:30 |
rm_work | ah damn same patchset | 21:31 |
rm_work | just +A time | 21:31 |
rm_work | ... no changes. why did it get a new patchset? | 21:31 |
rm_work | devstack plugin change triggers it maybe? | 21:31 |
dougwig | you can diff between patchsets to see. | 21:50 |
rm_work | i did | 21:50 |
rm_work | no changes | 21:50 |
rm_work | just a rebase | 21:50 |
*** manishg has quit IRC | 21:58 | |
*** doug-fish has joined #openstack-lbaas | 21:58 | |
*** manishg has joined #openstack-lbaas | 22:01 | |
*** manishg_ has joined #openstack-lbaas | 22:02 | |
*** manishg has quit IRC | 22:05 | |
*** ianbrown has quit IRC | 22:08 | |
*** ianbrown has joined #openstack-lbaas | 22:09 | |
*** rtheis has quit IRC | 22:10 | |
*** rcernin has joined #openstack-lbaas | 22:16 | |
*** doug-fish has quit IRC | 22:22 | |
*** admin0 has quit IRC | 22:28 | |
*** ducttape_ has quit IRC | 22:46 | |
*** ducttape_ has joined #openstack-lbaas | 22:49 | |
*** manishg_ has quit IRC | 22:59 | |
*** manishg has joined #openstack-lbaas | 23:02 | |
*** yuanying has joined #openstack-lbaas | 23:02 | |
*** yuanying has quit IRC | 23:03 | |
*** yuanying has joined #openstack-lbaas | 23:04 | |
*** manishg has quit IRC | 23:07 | |
*** manishg has joined #openstack-lbaas | 23:07 | |
openstackgerrit | Adam Harwell proposed openstack/neutron-lbaas: Refactor BarbicanAuth to allow for configurable auth method https://review.openstack.org/256184 | 23:10 |
*** rcernin has quit IRC | 23:20 | |
HenryG | Following up on a bug from last week: Bug #1524675 | 23:44 |
openstack | bug 1524675 in OpenStack Security Advisory "lbaasv2-agent is logging credentials from barbican" [Undecided,Incomplete] https://launchpad.net/bugs/1524675 | 23:44 |
HenryG | Can someone confirm it and find an assignee? | 23:45 |
rm_work | hmm | 23:45 |
rm_work | that sounds related to the code i'm touching | 23:45 |
*** manishg has quit IRC | 23:53 | |
*** chlong has quit IRC | 23:59 | |
HenryG | reedip: ping | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!