openstackgerrit | Merged openstack/octavia: Adds the NO_MONITOR operational status for members https://review.openstack.org/220232 | 00:04 |
---|---|---|
*** madhu_ak has quit IRC | 00:12 | |
*** minwang2 has quit IRC | 00:15 | |
*** chlong has quit IRC | 00:19 | |
*** Varun_Lodaya has quit IRC | 00:20 | |
*** bradjones is now known as bradjones|away | 00:24 | |
*** mlavalle has quit IRC | 00:30 | |
*** SumitNaiksatam has quit IRC | 01:02 | |
*** chlong has joined #openstack-lbaas | 01:02 | |
*** chlong has quit IRC | 01:08 | |
*** thomasem is now known as thomasem-away | 01:18 | |
*** vivek-ebay has quit IRC | 01:19 | |
*** chlong has joined #openstack-lbaas | 01:20 | |
*** amotoki has joined #openstack-lbaas | 01:26 | |
*** ajmiller has quit IRC | 01:28 | |
*** johnsom has quit IRC | 01:32 | |
*** johnsom has joined #openstack-lbaas | 01:32 | |
*** enikanorov__ has quit IRC | 01:36 | |
*** sballe has quit IRC | 01:36 | |
*** tiny-hands has joined #openstack-lbaas | 01:49 | |
openstackgerrit | Sherif Abdelwahab proposed openstack/octavia: Amphora Flows and Service Drivers for Active Standby https://review.openstack.org/206252 | 01:51 |
*** Guest78853 has joined #openstack-lbaas | 02:03 | |
*** SumitNaiksatam has joined #openstack-lbaas | 02:26 | |
*** bana_k has quit IRC | 02:26 | |
*** KunalGandhi has quit IRC | 02:30 | |
*** intr1nsic has quit IRC | 02:32 | |
*** bharathm has joined #openstack-lbaas | 02:43 | |
*** bharathm has quit IRC | 02:47 | |
*** tiny-hands has quit IRC | 02:53 | |
*** tiny-hands has joined #openstack-lbaas | 03:03 | |
*** tiny-hands has quit IRC | 03:05 | |
*** KunalGandhi has joined #openstack-lbaas | 03:15 | |
openstackgerrit | Phillip Toohill proposed openstack/octavia: Adding new network driver for containers https://review.openstack.org/197858 | 03:26 |
*** amotoki has quit IRC | 03:27 | |
*** sbalukoff has quit IRC | 03:31 | |
*** sbalukoff has joined #openstack-lbaas | 03:36 | |
*** ajmiller_ has quit IRC | 03:45 | |
*** amotoki has joined #openstack-lbaas | 03:45 | |
*** amotoki has quit IRC | 03:54 | |
*** amotoki has joined #openstack-lbaas | 03:58 | |
*** KunalGandhi has quit IRC | 04:02 | |
*** Guest78853 has quit IRC | 04:03 | |
*** amotoki has quit IRC | 04:18 | |
*** amotoki has joined #openstack-lbaas | 04:25 | |
*** enikanorov has joined #openstack-lbaas | 04:45 | |
*** Brian has joined #openstack-lbaas | 05:03 | |
*** Brian is now known as Guest91471 | 05:04 | |
*** Guest91471 has quit IRC | 05:06 | |
*** woodster_ has quit IRC | 05:09 | |
*** Brian has joined #openstack-lbaas | 05:44 | |
*** Brian is now known as Guest22005 | 05:44 | |
*** bana_k has joined #openstack-lbaas | 06:05 | |
*** numans has joined #openstack-lbaas | 06:09 | |
*** amotoki has quit IRC | 06:46 | |
*** jerrygb has quit IRC | 06:54 | |
*** jerrygb has joined #openstack-lbaas | 06:55 | |
*** jerrygb has quit IRC | 07:00 | |
*** numans has quit IRC | 07:22 | |
*** bana_k has quit IRC | 07:45 | |
*** ganeshna has joined #openstack-lbaas | 07:54 | |
*** amotoki has joined #openstack-lbaas | 08:06 | |
*** amotoki_ has joined #openstack-lbaas | 08:12 | |
*** amotoki has quit IRC | 08:14 | |
*** amotoki_ has quit IRC | 08:16 | |
*** amotoki has joined #openstack-lbaas | 08:26 | |
openstackgerrit | Phillip Toohill proposed openstack/octavia: Adding new network driver for containers https://review.openstack.org/197858 | 09:02 |
*** numans has joined #openstack-lbaas | 09:10 | |
*** chlong has quit IRC | 09:16 | |
openstackgerrit | Phillip Toohill proposed openstack/octavia: Updates for containers functionality https://review.openstack.org/199954 | 10:09 |
*** numans has quit IRC | 10:15 | |
*** kiran-r has joined #openstack-lbaas | 10:21 | |
*** f13o has joined #openstack-lbaas | 10:22 | |
*** Guest22005 has quit IRC | 10:34 | |
*** vjay13 has joined #openstack-lbaas | 11:30 | |
*** yuanying_ has joined #openstack-lbaas | 11:33 | |
*** yuanying has quit IRC | 11:35 | |
*** Jet has quit IRC | 11:59 | |
*** tiny-hands has joined #openstack-lbaas | 12:02 | |
*** vjay13 has quit IRC | 12:06 | |
*** woodster_ has joined #openstack-lbaas | 12:07 | |
*** bradjones|away is now known as bradjones | 12:18 | |
*** ganeshna has quit IRC | 12:21 | |
*** ganeshna has joined #openstack-lbaas | 12:23 | |
*** ganeshna has quit IRC | 12:30 | |
*** ganeshna has joined #openstack-lbaas | 12:34 | |
*** kiran-r has quit IRC | 12:53 | |
*** f13o has quit IRC | 13:12 | |
*** logan2 has quit IRC | 13:15 | |
*** ganeshna has quit IRC | 13:25 | |
*** thomasem-away is now known as thomasem | 13:34 | |
*** sballe has joined #openstack-lbaas | 13:34 | |
*** logan2 has joined #openstack-lbaas | 13:43 | |
*** mestery has quit IRC | 13:57 | |
*** ganeshna has joined #openstack-lbaas | 14:04 | |
*** ganeshna has quit IRC | 14:05 | |
*** ganeshna has joined #openstack-lbaas | 14:10 | |
*** ajmiller has joined #openstack-lbaas | 14:16 | |
*** mlavalle has joined #openstack-lbaas | 14:19 | |
*** mestery has joined #openstack-lbaas | 14:37 | |
*** ganeshna has quit IRC | 14:38 | |
*** woodster_ has quit IRC | 14:39 | |
*** diogogmt has joined #openstack-lbaas | 14:54 | |
*** TrevorV|Home has joined #openstack-lbaas | 14:55 | |
*** jerrygb has joined #openstack-lbaas | 15:01 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron-lbaas: Removed +x flag from alembic script https://review.openstack.org/222660 | 15:14 |
*** johnsom_ has joined #openstack-lbaas | 15:16 | |
*** mestery has quit IRC | 15:20 | |
*** KunalGandhi has joined #openstack-lbaas | 15:55 | |
*** yuanying has joined #openstack-lbaas | 16:02 | |
*** chlong has joined #openstack-lbaas | 16:04 | |
*** yuanying_ has quit IRC | 16:04 | |
*** devlaps has joined #openstack-lbaas | 16:06 | |
*** vivek-ebay has joined #openstack-lbaas | 16:08 | |
*** mestery has joined #openstack-lbaas | 16:09 | |
*** ganeshna has joined #openstack-lbaas | 16:10 | |
*** kiran-r has joined #openstack-lbaas | 16:13 | |
*** ganeshna has quit IRC | 16:18 | |
*** kiran-r has quit IRC | 16:21 | |
*** kiran-r has joined #openstack-lbaas | 16:22 | |
*** KunalGan_ has joined #openstack-lbaas | 16:25 | |
*** blogan_ has joined #openstack-lbaas | 16:25 | |
*** kiran-r has quit IRC | 16:27 | |
*** KunalGandhi has quit IRC | 16:27 | |
*** vivek-ebay has quit IRC | 16:28 | |
*** bana_k has joined #openstack-lbaas | 16:30 | |
*** minwang2 has joined #openstack-lbaas | 16:31 | |
openstackgerrit | Phillip Toohill proposed openstack/octavia: Updates for containers functionality https://review.openstack.org/199954 | 16:33 |
bana_k | blogan : I was checking the old lbaas mail thread n came across this "help on single create call" | 16:39 |
bana_k | has anyone started working on it ? | 16:40 |
*** KunalGan_ has quit IRC | 16:40 | |
xgerman | we deferred until M | 16:41 |
bana_k | oh ok. | 16:41 |
bana_k | is it like enabling the heat for lbaasv2? | 16:42 |
sbalukoff | bana_k: No, I think the idea is to be able to create a complete load balancer configuration in a single API call. I guess that could aid automation / orchestration tools like heat, but it's not meant exclusively for heat. | 16:50 |
sbalukoff | Also, good morning folks! | 16:50 |
*** vivek-ebay has joined #openstack-lbaas | 16:53 | |
xgerman | morning | 16:54 |
*** clev is now known as clev-away | 16:54 | |
blogan_ | bana_k: what sbalukoff said | 16:54 |
xgerman | blogan ping me when you get in — we probably need to do some PTL business and review the bugs | 16:54 |
xgerman | there you are... | 16:54 |
blogan_ | xgerman: im in, but give me a few | 16:54 |
bana_k | ok . got it | 16:55 |
xgerman | sure | 16:55 |
*** TrevorV|Home has quit IRC | 16:55 | |
*** KunalGandhi has joined #openstack-lbaas | 17:07 | |
johnsom_ | Hi all | 17:07 |
*** abdelwas has joined #openstack-lbaas | 17:07 | |
johnsom_ | Bug review would be good. I have a few more cosmetic bugs to file today. | 17:08 |
blogan_ | xgerman: back | 17:09 |
xgerman | cool | 17:09 |
xgerman | hangout? | 17:09 |
*** amotoki has quit IRC | 17:10 | |
xgerman | http://bit.ly/LBaaS_HP_Hangout | 17:10 |
*** madhu_ak has joined #openstack-lbaas | 17:10 | |
blogan_ | sure | 17:11 |
minwang2 | i am testing under devstack against octavia, got some error | 17:17 |
minwang2 | 2015-09-11 10:14:17.170 33134 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/octavia/octavia/controller/worker/tasks/compute_tasks.py", line 81, in execute | 17:17 |
minwang2 | 2015-09-11 10:14:17.170 33134 ERROR oslo_messaging.rpc.dispatcher raise e | 17:17 |
minwang2 | 2015-09-11 10:14:17.170 33134 ERROR oslo_messaging.rpc.dispatcher TypeError: 'NoneType' object is not iterable | 17:17 |
*** bharath has joined #openstack-lbaas | 17:18 | |
*** SumitNaiksatam has quit IRC | 17:19 | |
*** bharath is now known as bharathm | 17:19 | |
*** johnsom_ has quit IRC | 17:20 | |
ptoohill | minwang2: You are running tests right? | 17:23 |
ptoohill | on master | 17:23 |
ptoohill | the unit tests* | 17:23 |
minwang2 | ptoohill i am just trying to create a loadbalancer, did not do test yet | 17:23 |
ptoohill | ook, i ran into this when i was merging and thought it was something of mine that was broke. Looking a second time it came from some recently merged changes. Give me a bit and I can push a fix | 17:24 |
ptoohill | youre on master right? | 17:25 |
minwang2 | ptoohill yes | 17:26 |
ptoohill | Hmm, the fix is in master. maybe this is in a different spot | 17:27 |
ptoohill | i guess i should fix the ports->port_ids while im here. | 17:28 |
minwang2 | did you try to create a lb under octavia | 17:29 |
ptoohill | No, this was in my tests that i discovered. I had a merge and used the wrong one. | 17:29 |
ptoohill | It's possible you have old code still? | 17:30 |
minwang2 | it might happen since we merge a lot of code recently | 17:31 |
ptoohill | the sig should be execute(self, amphora_id, port_ids=None, config_drive_files={}) in ComputeCreate | 17:31 |
ptoohill | possible | 17:31 |
minwang2 | the first time that i see this error was yesterday ,the octavia gate did not pass and see the same error | 17:31 |
ptoohill | The reason i got the error and assume its the same is because the config_driver_files=None and you couldnt assign it | 17:32 |
ptoohill | so if you can verify the sig/up to date code | 17:32 |
ptoohill | Theres other issues too | 17:32 |
ptoohill | but yea | 17:32 |
*** mlavalle has quit IRC | 17:32 | |
*** chlong has quit IRC | 17:34 | |
johnsom | I just built a stack, I will give it a shot and try to debug | 17:38 |
minwang2 | thank you! | 17:39 |
ptoohill | Alright, It looks like the sig has changed a few times back and fourth. Not sure how or why, but I can see in my chain it bouncing back and fourth between {} and None. So it's entirely possible its out of sync somewhere :/ | 17:39 |
ptoohill | The most recent changes where those to the CertComputeCreate that altered the sigs | 17:41 |
ptoohill | think crc32|znc did those. | 17:41 |
johnsom | fail over flow changed that too | 17:41 |
ptoohill | ah | 17:42 |
johnsom | As did UDP | 17:43 |
blogan_ | might have been a bad merge after the health manager service | 17:43 |
johnsom | Are you guys missing the UDP patchset? | 17:43 |
blogan_ | bc i know it worked after the health manager service, so i think the UDP patchset may have had a bad merge | 17:43 |
johnsom | I just built LBs with no issue | 17:43 |
johnsom | I am running with the UDP | 17:43 |
blogan_ | hmm | 17:43 |
blogan_ | i have UDP as well | 17:43 |
blogan_ | and got the error | 17:43 |
ptoohill | my case was because i had merge conflicts in my containers code. But the code in master looks correct | 17:44 |
blogan_ | im fully up to date on master | 17:44 |
ptoohill | hmm | 17:44 |
johnsom | Yeah, master is building LBs just fine | 17:44 |
ptoohill | fun stuff | 17:44 |
blogan_ | not for me, ill try some more | 17:44 |
johnsom | The only setting I have been setting up after devstack build is the controller_ip_port_list | 17:46 |
johnsom | But I think it runs without that, just won't fail over | 17:46 |
johnsom | Yeah, it works without because I just had a typo in my config | 17:47 |
*** numans has joined #openstack-lbaas | 17:48 | |
*** ajmiller has quit IRC | 17:52 | |
blogan_ | its something happening in the jinja render in the compute create | 17:54 |
ptoohill | you sure? | 17:55 |
blogan_ | yeah, for the agent config builder | 17:56 |
ptoohill | whats the compute create sig look like for you? | 17:56 |
blogan_ | not haproxy jinja stuffs | 17:56 |
ptoohill | yes | 17:56 |
blogan_ | ok fixed it | 17:56 |
ptoohill | ? | 17:57 |
blogan_ | dont know why johnsom wasnt getting it though | 17:57 |
ptoohill | what was the fix | 17:57 |
blogan_ | controller_ip_port_list config option default to empty lit | 17:57 |
blogan_ | list | 17:57 |
johnsom | Yeah, I have been filling that in (last time with bad info) | 17:58 |
blogan_ | ah okay, well i think an empty list default owuld make sense, at least to get it past this if the option isn't specified in the config | 17:59 |
johnsom | It should still work empty though.... | 17:59 |
johnsom | It is an empty list.... | 17:59 |
blogan_ | it gets value of None, and then the jinja render breaks bc of that for some reason | 18:00 |
johnsom | def execute(self, amphora_id, ports=None, config_drive_files={}): | 18:00 |
blogan_ | so if you dont specify that option in your config, you get an empty list? | 18:00 |
johnsom | If you don't have that, you don't have the UDP patch | 18:00 |
blogan_ | no i have that, thats not the issue | 18:00 |
ptoohill | That was just an issue with my merge, but similar error | 18:01 |
blogan_ | CONF.health_manager.controller_ip_port_list | 18:01 |
johnsom | Ok, let me try with that commented out | 18:01 |
johnsom | There are some bugs filed around this btw: | 18:02 |
johnsom | https://bugs.launchpad.net/octavia/+bug/1490707 | 18:02 |
openstack | Launchpad bug 1490707 in octavia "Octavia should give better error for health_manager controller IP missing" [Medium,New] | 18:02 |
*** numans has quit IRC | 18:02 | |
blogan_ | ah thats the same issue | 18:02 |
blogan_ | well then do yall think defaulting to an empty list would be better or returning back a better error message on the controller worker start? | 18:03 |
johnsom | https://bugs.launchpad.net/octavia/+bug/1490033 | 18:03 |
openstack | Launchpad bug 1490033 in octavia "Devstack scripts need to enable lb-network controller IP" [Critical,New] - Assigned to Brandon Logan (brandon-logan) | 18:03 |
blogan_ | bc waiting for actual commands isn't good to throw the error | 18:03 |
johnsom | blank should work | 18:04 |
blogan_ | i think at least for nwo defaulting to empty list would fine | 18:04 |
*** ajmiller has joined #openstack-lbaas | 18:04 | |
johnsom | Just no failover | 18:04 |
blogan_ | blank? you mean it works for you without that option in your config? | 18:04 |
blogan_ | johnsom: yeah no failover is i think acceptable | 18:05 |
blogan_ | johnsom: as long as we make a comment in the config about it and other places i suppose | 18:05 |
johnsom | Ok, yeah, it's broken with nothing in that field, but works ok with bogus info, just no failover | 18:05 |
blogan_ | ok ill push this up | 18:06 |
johnsom | Work completely with 172.24.4.1:5555 (but that IP is the wrong answer) | 18:06 |
blogan_ | yeah i havent had the chance to get the listen ip o the devstack host yet | 18:06 |
blogan_ | that second bug | 18:06 |
blogan_ | you listed | 18:06 |
*** TrevorV|Home has joined #openstack-lbaas | 18:10 | |
blogan_ | ok looks good with this fix, pushing up in a second, also throwing in an extra fix for mutable defaults | 18:16 |
johnsom | Cool | 18:16 |
blogan_ | which isnt much of an issue but is the correct way | 18:16 |
johnsom | There is a bug with the devstack plugin.sh script too, the iniset for the heartbeat_key needs to have an uncomment in front of it | 18:17 |
johnsom | Extra credit if you fix that too | 18:17 |
openstackgerrit | Brandon Logan proposed openstack/octavia: Default controller_ip_port_list option to empty https://review.openstack.org/222722 | 18:18 |
blogan_ | ah | 18:18 |
blogan_ | missed what you said | 18:18 |
blogan_ | let me fix that | 18:18 |
blogan_ | johnsom: line 67 in plugin.sh? | 18:19 |
johnsom | iniset $OCTAVIA_CONF health_manager heartbeat_key ${OCTAVIA_HEALTH_KEY} | 18:20 |
blogan_ | add an iniuncomment line after that? | 18:20 |
johnsom | That line creates a duplicate entry. | 18:20 |
blogan_ | ah | 18:20 |
blogan_ | so change that to just an uncomment | 18:21 |
blogan_ | is what you're syaing | 18:21 |
johnsom | So, uncomment before? | 18:21 |
johnsom | Well, it still should be set | 18:21 |
blogan_ | hmm | 18:21 |
johnsom | I thought iniset would uncomment if it is there, but for some reason it is not | 18:22 |
blogan_ | so its already there, but needs to be set and uncommented, so uncomment first will allow the iniset to see it exists and set it | 18:22 |
johnsom | Yeah, I think so | 18:22 |
blogan_ | lets try it | 18:22 |
blogan_ | restacking brb | 18:24 |
*** jerrygb_ has joined #openstack-lbaas | 18:24 | |
ptoohill | is inicomment a thing | 18:27 |
johnsom | iniuncomment is, I don't know about inicomment | 18:27 |
*** blogan_ has quit IRC | 18:27 | |
*** blogan_ has joined #openstack-lbaas | 18:27 | |
*** jerrygb has quit IRC | 18:28 | |
*** kiran-r has joined #openstack-lbaas | 18:31 | |
openstackgerrit | Brandon Logan proposed openstack/octavia: Default controller_ip_port_list option to empty https://review.openstack.org/222722 | 18:32 |
*** kiran-r has quit IRC | 18:33 | |
johnsom | Cool, I am going to restack too | 18:33 |
minwang2 | johnson blogan_ if i restack, just need to cherry pick the patch above refs/changes/22/222722/2, that’s it right? i have updated my devstack repo, it has some new patches merged as well | 18:38 |
minwang2 | johnsom | 18:38 |
johnsom | Yes | 18:38 |
johnsom | Or just checkout since it depends on master | 18:38 |
blogan_ | minwang2: do you have changes that need to go on top of that? | 18:39 |
blogan_ | minwang2: if not, just git review -d should be sufficient as it should be based off current master | 18:39 |
minwang2 | i dont have any patch on top of it, will just do review -d | 18:40 |
minwang2 | i usually cherry pick it | 18:40 |
blogan_ | i usually just cherry-pick when i want to test my patch out with another patch not yet merged | 18:41 |
openstackgerrit | Divya ChanneGowda proposed openstack/neutron-lbaas: Add device_id when a loadbalancer is created instead of at listener create https://review.openstack.org/221985 | 18:43 |
*** blogan__ has joined #openstack-lbaas | 18:48 | |
*** blogan_ has quit IRC | 18:49 | |
*** abdelwas has quit IRC | 18:54 | |
*** jerrygb_ has quit IRC | 18:57 | |
*** jerrygb has joined #openstack-lbaas | 18:57 | |
minwang2 | blogan_ your patch fixed the issue that i met when creating lb, i just created a lb perfectly | 19:08 |
minwang2 | blogan_ | 19:08 |
*** SumitNaiksatam has joined #openstack-lbaas | 19:09 | |
minwang2 | i am testing the tempest test as well, hopefully this fix can solve the problem in tempest test too | 19:18 |
*** SumitNaiksatam has quit IRC | 19:31 | |
*** SumitNaiksatam has joined #openstack-lbaas | 19:31 | |
rm_work | +2/+A | 19:35 |
blogan__ | minwang2: good, i hope so too | 19:38 |
rm_work | yeah i thought that was what you were looking at fixing yesterday evening | 19:39 |
rm_work | didn't you push up a thing? | 19:39 |
rm_work | hey blogan go +2 this https://review.openstack.org/#/c/222374/ | 19:39 |
rm_work | err | 19:39 |
rm_work | +1 sorry | 19:39 |
*** mlavalle has joined #openstack-lbaas | 19:40 | |
openstackgerrit | Merged openstack/octavia: Default controller_ip_port_list option to empty https://review.openstack.org/222722 | 19:41 |
rm_work | ok now you want to rebase your patchsets | 19:41 |
rm_work | so they'll include that | 19:41 |
rm_work | (just click the rebase button on the review, should be all that is necessary) | 19:42 |
rm_work | oh hey were you guys aware of this? http://lists.openstack.org/pipermail/openstack-dev/2015-August/073049.html | 19:44 |
minwang2 | oops | 19:46 |
minwang2 | blogan_ good news is a lot of test cases passed because of your fix, the other news is that we still have some issue | 19:47 |
*** mlavalle has quit IRC | 19:48 | |
rm_work | well, that's still good news -- actual data on real failures is great news in my book :P | 19:51 |
minwang2 | exactly | 19:51 |
blogan__ | was not | 19:55 |
blogan__ | minwang2: do you have a link i can look at for logs? | 19:55 |
minwang2 | hang on, let me get the full log for you | 19:56 |
blogan__ | rm_work: i have no idea what that review does, the infra one | 20:05 |
blogan__ | but it looks fine :) | 20:05 |
rm_you| | lol | 20:06 |
*** rm_you| is now known as rm_you | 20:07 | |
rm_you | it is so we can enable Barbican in another gate check | 20:07 |
rm_you | err, in our gate | 20:08 |
blogan__ | okay | 20:09 |
minwang2 | in order to do that you need to register Barbican in the PROJECT ENV list, not sure anyone take care of that yet? | 20:15 |
rm_you | minwang2: that is the review I linked to blogan above | 20:16 |
rm_you | they are in a freeze right now though so can't merge it until later | 20:16 |
rm_you | so we | 20:16 |
rm_you | are stuck for a little bit | 20:16 |
minwang2 | nice , you got +1 from doug and +2 from clark, good progress | 20:19 |
rm_you | yes I am good at nagging apparently :P | 20:21 |
xgerman | lol | 20:21 |
rm_you | but leaving them alone for the time being as they have a major thing going on right now | 20:22 |
openstackgerrit | Bertrand Lallau proposed openstack/octavia: Remove bad INFO log "Starting Octavia API server" https://review.openstack.org/222760 | 20:30 |
*** bradjones is now known as bradjones|away | 20:33 | |
openstackgerrit | Brandon Logan proposed openstack/neutron-lbaas: Fix health monitor ops in lbaas octavia driver https://review.openstack.org/222762 | 20:39 |
johnsom | You are on a roll.... | 20:40 |
openstackgerrit | Brandon Logan proposed openstack/neutron-lbaas: Fix health monitor ops in lbaas octavia driver https://review.openstack.org/222762 | 20:40 |
*** apuimedo has joined #openstack-lbaas | 20:40 | |
blogan__ | ha, gotta polish this turd up! | 20:41 |
blogan__ | there's a diamond underneath! | 20:41 |
* johnsom hands blogan__ the simonize can | 20:42 | |
* blogan__ looks up simonize | 20:42 | |
johnsom | ah, it's simoniz, no e | 20:43 |
* blogan__ is now edumacated | 20:43 | |
blogan__ | it came up with an e in google | 20:43 |
blogan__ | ah simonize is a synonym for plural, but simoniz is a product | 20:43 |
johnsom | It must be a regional joke.... | 20:43 |
*** SumitNaiksatam has quit IRC | 20:59 | |
*** SumitNaiksatam has joined #openstack-lbaas | 21:03 | |
*** tiny-hands has quit IRC | 21:03 | |
*** diogogmt has quit IRC | 21:08 | |
blogan__ | ptoohill, dougwig, ajmiller: https://review.openstack.org/#/c/222762/ | 21:09 |
ajmiller | blogan__ looking | 21:09 |
*** blogan__ is now known as blogan_ | 21:10 | |
blogan_ | fix my name so its not so annoying | 21:10 |
rm_work | ... but still somewhat | 21:11 |
rm_work | why such _ | 21:11 |
johnsom | I haven't had a minute to test, but glad to have a fix in for it | 21:11 |
rm_work | blogan_: so it's just the same for fail or pass? | 21:12 |
rm_work | if max_retries is 5, it takes 5 fails to move it to "DOWN" and 5 passes to move it to "UP"? | 21:12 |
rm_work | should it be like "max_retries" for "fall" and like "1" for "rise"? | 21:13 |
rm_work | or is that naive | 21:13 |
rm_work | blogan: ^^ | 21:14 |
blogan_ | rm_work: its kind of a cop out right now since neutorn_lbaas has no concept of fall_threshold | 21:16 |
blogan_ | err rise_threshold | 21:16 |
blogan_ | sorry | 21:16 |
blogan_ | to bring it back up | 21:16 |
blogan_ | so i think having hte same number of attempts to say its DOWN as to bring it back UP is an okay concession | 21:17 |
rm_work | <_< k | 21:18 |
blogan_ | you think always being 1 is better? | 21:18 |
blogan_ | for rise | 21:18 |
rm_work | eh, maybe | 21:19 |
rm_work | i mean | 21:19 |
rm_work | it might cause flapping though | 21:19 |
rm_work | really it needs to be configurable <_< | 21:19 |
blogan_ | yeah | 21:19 |
blogan_ | we can add it in, but it can't be required so we don't break backwards compatibility, so since max_retries is required we'll probably end up doing it this way anyway if the rise_threshold (or whatever we call it ofr neutron-lbaas) is not specified | 21:20 |
ajmiller | blogan_ so 'id' just wasn't being used anywhere? | 21:20 |
blogan_ | ajmiller: not for octavia | 21:20 |
ajmiller | OK | 21:20 |
blogan_ | ajmiller: octavia just does pools/{pool_id}/healthmonitor | 21:21 |
blogan_ | octavia's primary key is the pool_id, so its always a 1:1 | 21:21 |
ajmiller | cool, got it. | 21:21 |
ajmiller | +2 | 21:21 |
blogan_ | thanks | 21:23 |
*** blogan_ has quit IRC | 21:29 | |
*** blogan_ has joined #openstack-lbaas | 21:32 | |
*** sherif has joined #openstack-lbaas | 21:35 | |
johnsom | FYI, new critical bug: https://bugs.launchpad.net/octavia/+bug/1494956 | 21:35 |
openstack | Launchpad bug 1494956 in octavia "health monitor delete does not remove health monitor" [Critical,New] | 21:35 |
johnsom | I will dig into this one | 21:35 |
blogan_ | damn | 21:36 |
TrevorV|Home | Wait, what? doesn't remove it in the config johnsom ? | 21:37 |
TrevorV|Home | As in haproxy still has the hm? | 21:37 |
blogan_ | johnsom: i see what it is | 21:37 |
blogan_ | octavia driver | 21:37 |
johnsom | Yep, after delete it is still in the config. My guess we missed a update call | 21:37 |
johnsom | blogan_ Hahaha, ok, you got it then? | 21:38 |
blogan_ | johnsom: lol yeah | 21:38 |
blogan_ | i should have caught it in my other review | 21:38 |
johnsom | Cool | 21:38 |
*** TrevorV|Home has quit IRC | 21:39 | |
blogan_ | well i can just add it in! | 21:39 |
blogan_ | its not +A'ed yet | 21:39 |
johnsom | I can pull it down quick and test when you're done | 21:39 |
openstackgerrit | Phillip Toohill proposed openstack/octavia: Adding new network driver for containers https://review.openstack.org/197858 | 21:40 |
openstackgerrit | Brandon Logan proposed openstack/neutron-lbaas: Fix health monitor ops in lbaas octavia driver https://review.openstack.org/222762 | 21:43 |
minwang2 | blogan_ here is the details of the log for tempest test https://bugs.launchpad.net/octavia/+bug/1494960 | 21:46 |
openstack | Launchpad bug 1494960 in octavia "Neutron LBaas v2 API Tempest test error against octavia plugin" [Undecided,New] | 21:46 |
blogan_ | minwang2: ok thanks | 21:46 |
johnsom | blogan_ Yep, you got it | 21:47 |
minwang2 | it is a bit late, the previous test did not catch the whole log and then the resources are full, so i cleaned up the devstack and run it again, otherwise i can give you a big faster blogan_ | 21:47 |
blogan_ | a big faster blogan_? ill take a faster blogan_, but blogan_ is at maximum capacity | 21:48 |
minwang2 | hahahaha | 21:48 |
minwang2 | i mean that i supposed to give you the log earlier , you asked me about 1 hour ago | 21:49 |
blogan_ | minwang2: i know, i was just being dumb, no worries though, i'll look at it now | 21:49 |
minwang2 | blogan_ thanks, we failed 20 cases, the rest are good, which is pretty good | 21:50 |
johnsom | That is great | 21:50 |
blogan_ | i bet these health monitor fixes will actually fix some of those | 21:51 |
blogan_ | minwang2: unless you tested with those patches | 21:51 |
blogan_ | err that patch | 21:51 |
minwang2 | i did not apply the health monitor patch on the testing yet | 21:53 |
minwang2 | should i try it? | 21:53 |
blogan_ | well the health monitor tests passsed in that run :( | 21:53 |
openstackgerrit | Divya ChanneGowda proposed openstack/neutron-lbaas: Add device_id when a loadbalancer is created instead of at listener create https://review.openstack.org/221985 | 21:53 |
blogan_ | but neutron lbaas didnt throw errors, so that is expected | 21:53 |
blogan_ | so that patch wont improve anything | 21:53 |
minwang2 | hmm | 21:55 |
bana_k | and I am not able to run the active-standby code in devstack :/ | 21:55 |
xgerman | :-( | 21:55 |
openstackgerrit | Phillip Toohill proposed openstack/octavia: Updates for containers functionality https://review.openstack.org/199954 | 22:03 |
bana_k | where is the HEAD for the octaiva db migration ? | 22:11 |
bana_k | i could not find it in the versions folder | 22:12 |
bana_k | n when I run devstack its complaining about Multiple head revisions are present for given argument 'head'; | 22:12 |
*** diogogmt has joined #openstack-lbaas | 22:14 | |
blogan_ | bana_k: means the links aren't correct | 22:15 |
bana_k | oh what does that exactly mean? in neutron-lbaas n all we have a HEAD file of there is a prob with that it used to throw this kind of error. | 22:18 |
bana_k | blogan_ : https://gist.github.com/banveerad/720d1426b9f1e6324b09 | 22:18 |
bana_k | I see 2 head in the o/p | 22:18 |
blogan_ | bana_k: so neutron uses theur own neutron-db-manage client, and we use that for neutron-lbaas, thats the the wrapper around alembic that does the actual reading of the HEAD file in neutron | 22:23 |
blogan_ | we dont have that yet for octavia, so we just use straight alembic | 22:23 |
blogan_ | so what you're seeing there is the migration file in the vrrp patch hasn't been rebased and relinked to the head that is currently in master since a new migration merged since the vrrp review was last rebased | 22:24 |
blogan_ | so if you point the back_revision of the vrrp to the NO_MONITOR migration, that should fix it | 22:24 |
blogan_ | sorry down_revision | 22:25 |
johnsom | bana_k I will update. | 22:35 |
*** blogan__ has joined #openstack-lbaas | 22:36 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Amphora Flows and Drivers for Active Standby https://review.openstack.org/206252 | 22:36 |
*** blogan_ has quit IRC | 22:38 | |
*** blogan__ has quit IRC | 22:41 | |
bana_k | thanks a lot :) | 22:46 |
*** xgerman has quit IRC | 23:03 | |
*** codekobe has quit IRC | 23:04 | |
bana_k | looks like review openstack is down :/ | 23:04 |
minwang2 | yeah | 23:05 |
blogan | maintenance i suppose | 23:06 |
*** codekobe has joined #openstack-lbaas | 23:06 | |
bana_k | oh ok. | 23:06 |
ajmiller | I think there was some notice about downtime to rename a bunch of projects | 23:08 |
rm_you | <rm_work> oh hey were you guys aware of this? http://lists.openstack.org/pipermail/openstack-dev/2015-August/073049.html | 23:16 |
*** madhu_ak has quit IRC | 23:35 | |
johnsom | Seems to be up again | 23:36 |
*** openstackgerrit has quit IRC | 23:46 | |
*** openstackgerrit has joined #openstack-lbaas | 23:47 | |
rm_you | cool | 23:56 |
*** kbyrne has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!