Thursday, 2015-08-13

*** madhu_ak has quit IRC00:14
bana_khi, What exactly needs to be done for tls support in the driver ?00:18
bana_kwas reading up the https://review.openstack.org/#/c/130659/6/specs/version0.5/tls-data-security.rst00:18
bana_kmay be the wrong dock to read?00:18
*** bharath has quit IRC00:37
johnsomFYI, I have tested Min's health manager code with the fail over flow.  It built the amphora, but there are still some bugs.00:46
johnsomStill, cool to have a fail over trigger!00:46
*** crc32 has joined #openstack-lbaas00:49
*** crc32 has quit IRC00:52
xgermannice00:59
*** bana_k has quit IRC01:01
*** crc32 has joined #openstack-lbaas01:02
*** chlong has joined #openstack-lbaas01:03
*** fnaval has quit IRC01:24
*** fnaval has joined #openstack-lbaas01:37
*** vivek-ebay has quit IRC01:39
*** madhu_ak has joined #openstack-lbaas01:46
*** madhu_ak has quit IRC01:51
*** madhu_ak has joined #openstack-lbaas01:53
*** diogogmt has joined #openstack-lbaas01:54
*** vivek-ebay has joined #openstack-lbaas02:06
*** woodster_ has quit IRC02:10
*** vivek-ebay has quit IRC02:55
*** vivek-ebay has joined #openstack-lbaas02:56
*** KunalGandhi has quit IRC03:00
*** madhu_ak has quit IRC03:05
*** madhu_ak has joined #openstack-lbaas03:06
*** diogogmt has quit IRC03:20
*** bana_k has joined #openstack-lbaas03:24
*** bana_k has quit IRC03:34
*** bharath has joined #openstack-lbaas03:38
*** bharath has quit IRC03:42
*** madhu_ak has quit IRC03:43
*** madhu_ak has joined #openstack-lbaas03:43
openstackgerritCarlos Garza proposed openstack/octavia: Implement UDP heartbeat sender and receiver  https://review.openstack.org/20188203:51
openstackgerritCarlos Garza proposed openstack/octavia: Implement UDP heartbeat sender and receiver  https://review.openstack.org/20188203:52
*** enikanorov2 has quit IRC04:06
*** vivek-ebay has quit IRC04:12
*** madhu_ak has quit IRC04:14
*** madhu_ak has joined #openstack-lbaas04:14
*** enikanorov2 has joined #openstack-lbaas04:15
*** ganeshna has joined #openstack-lbaas04:15
*** ganeshna has quit IRC04:17
*** vivek-ebay has joined #openstack-lbaas04:21
*** madhu_ak has quit IRC04:22
openstackgerritAl Miller proposed openstack/neutron-lbaas: Filter get_pool_members to return members from the desired pool  https://review.openstack.org/21096804:34
*** madhu_ak has joined #openstack-lbaas04:42
*** ganeshna has joined #openstack-lbaas04:49
*** ganeshna has quit IRC05:00
*** ganeshna has joined #openstack-lbaas05:00
*** vivek-ebay has quit IRC05:15
*** madhu_ak has quit IRC05:26
*** bana_k has joined #openstack-lbaas05:38
*** crc32 has quit IRC05:44
openstackgerritDoug Wiegley proposed openstack/neutron-lbaas: Remove default service provider from conf file  https://review.openstack.org/21175706:08
*** bharath_ has joined #openstack-lbaas06:09
*** bharath_ has quit IRC06:14
*** apuimedo has quit IRC06:40
*** vivek-ebay has joined #openstack-lbaas06:58
*** vivek-ebay has quit IRC07:02
*** jschwarz has joined #openstack-lbaas07:21
*** bana_k has quit IRC07:28
rm_workhmm, doubt anyone is up07:31
rm_worklooking at diskimage builder stuff07:31
rm_workwanted to ask if there was anything else I was missing before i start poking at things :P07:32
rm_workdoes octavia build and install the disk image as part of devstack spinup? or is that manual after ./stack07:36
*** ganeshna has quit IRC07:36
*** jschwarz has quit IRC07:41
*** openstackgerrit has quit IRC07:41
*** jschwarz has joined #openstack-lbaas07:42
*** openstackgerrit has joined #openstack-lbaas07:42
*** openstackgerrit has quit IRC07:45
*** jschwarz has quit IRC07:46
*** rm_work is now known as rm_work|away07:56
*** rm_work|away is now known as rm_work07:58
*** bharath has joined #openstack-lbaas07:58
*** jschwarz has joined #openstack-lbaas07:58
*** openstackgerrit has joined #openstack-lbaas08:00
*** rm_work is now known as rm_work|away08:00
*** bharath has quit IRC08:03
*** rm_work|away is now known as rm_work08:03
openstackgerritEvgeny Fedoruk proposed openstack/neutron-lbaas: Fixing Radware LBaaS v2 driver LB deletion  https://review.openstack.org/21240108:10
*** chlong has quit IRC08:13
rm_workman, this takes longer than I remember to spin up <_<08:19
*** numan has joined #openstack-lbaas08:23
*** numan has quit IRC08:23
*** numan has joined #openstack-lbaas08:23
rm_workoh what08:23
rm_work2015-08-13 08:20:44.548 ERROR neutron.services.service_base [-] Error loading provider 'neutron_lbaas.drivers.octavia.driver.OctaviaDriver' for service LOADBALANCERV208:23
rm_workit's already automatically configured to try to use octavia? the driver isn't done yet though, right?08:23
*** rm_work is now known as rm_work|away08:25
*** apuimedo has joined #openstack-lbaas08:25
*** rm_work|away is now known as rm_work08:25
*** rm_work is now known as rm_work|away08:28
*** rm_work|away is now known as rm_work08:29
rm_workwhatever, i don't need neutron-lbaas to test octavia08:29
rm_workAUGH08:32
rm_workexcept it's set up so i do >_>08:32
rm_workif ! is_service_enabled $Q_SVC || ! is_service_enabled $LBAAS_V2; then08:32
rm_work        die "The neutron $Q-SVC and $LBAAS_V2 services must be enabled to use $OCTAVIA"08:32
rm_workreally? :(08:32
rm_workbut i can't enable LBAASV2 because it tries to use the nonexistent octavia driver?08:33
rm_worki guess i'll revisit this in the afternoon when people are on08:33
rm_workalso there's a typo there i think08:34
rm_work$Q-SVC08:34
rm_workah though i see now that it should build the amp image as part of initialization, cool08:36
*** bharath__ has joined #openstack-lbaas09:47
*** bharath__ has quit IRC09:51
*** iwi has joined #openstack-lbaas10:26
iwihi there, is lbaas v2 supporting the "native" heat resources for LBaaS ?10:28
*** chlong has joined #openstack-lbaas11:03
*** shunliz has joined #openstack-lbaas11:31
*** bharath has joined #openstack-lbaas11:35
*** bharath has quit IRC11:40
*** [1]mikeymeitbual has joined #openstack-lbaas12:01
*** jschwarz_ has joined #openstack-lbaas12:03
*** mikeymeitbual has quit IRC12:03
*** [1]mikeymeitbual is now known as mikeymeitbual12:03
*** jschwarz has quit IRC12:05
*** evgenyf has joined #openstack-lbaas12:11
*** jschwarz__ has joined #openstack-lbaas12:31
*** ajmiller has quit IRC12:33
*** jschwarz_ has quit IRC12:34
*** openstackgerrit has quit IRC13:01
*** openstackgerrit has joined #openstack-lbaas13:02
*** jschwarz__ is now known as jschwarz13:02
*** mestery has quit IRC13:03
*** mestery has joined #openstack-lbaas13:11
*** ajmiller has joined #openstack-lbaas13:14
*** rohara has joined #openstack-lbaas13:22
*** bharath has joined #openstack-lbaas13:24
*** diogogmt has joined #openstack-lbaas13:28
*** bharath has quit IRC13:28
*** ajmiller has quit IRC13:43
*** diogogmt has quit IRC13:49
*** evgenyf has quit IRC14:04
*** evgenyf has joined #openstack-lbaas14:06
*** iwi has quit IRC14:08
*** devlaps has quit IRC14:24
*** iwi has joined #openstack-lbaas14:25
*** minwang2 has joined #openstack-lbaas14:33
*** mlavalle has joined #openstack-lbaas14:35
*** sbalukoff has quit IRC14:37
*** iwi has quit IRC14:38
*** iwi has joined #openstack-lbaas14:39
*** fnaval has quit IRC14:43
*** jschwarz has quit IRC14:43
openstackgerritPengtao Huang proposed openstack/neutron-lbaas: change if to elif  https://review.openstack.org/21256014:49
*** vivek-ebay has joined #openstack-lbaas14:50
*** ajmiller has joined #openstack-lbaas14:53
*** iwi1 has joined #openstack-lbaas14:54
*** iwi has quit IRC14:54
*** diogogmt has joined #openstack-lbaas14:54
*** fnaval has joined #openstack-lbaas14:56
*** TrevorV has joined #openstack-lbaas14:58
*** vivek-ebay has quit IRC14:59
*** sbalukoff has joined #openstack-lbaas15:04
*** bharath has joined #openstack-lbaas15:13
*** bharath has quit IRC15:18
*** haigang has joined #openstack-lbaas15:24
*** haigang has quit IRC15:24
*** haigang has joined #openstack-lbaas15:25
*** shunliz has quit IRC15:29
*** vivek-ebay has joined #openstack-lbaas15:32
*** amotoki has joined #openstack-lbaas15:44
*** haigang has quit IRC15:49
*** haigang has joined #openstack-lbaas15:49
*** sbalukoff has quit IRC15:54
*** jschwarz has joined #openstack-lbaas15:56
*** woodster_ has joined #openstack-lbaas15:57
*** minwang2 has quit IRC16:02
*** haigang has quit IRC16:15
*** evgenyf has quit IRC16:17
*** alejandrito has joined #openstack-lbaas16:22
xgermandougwig, blogan: https://review.openstack.org/#/c/210968/4/neutron_lbaas/services/loadbalancer/plugin.py16:24
xgermanwonder if you an have a look and comment16:25
ajmilleralso see https://bugs.launchpad.net/neutron/+bug/148310016:25
openstackLaunchpad bug 1483100 in neutron "neutron-lbaas V2 lbaas-member-list returns all members, not just those for the specified pool" [Undecided,In progress] - Assigned to Al Miller (al-miller)16:25
*** abdelwas has joined #openstack-lbaas16:29
*** diogogmt has quit IRC16:31
*** openstackgerrit has quit IRC16:31
*** diogogmt has joined #openstack-lbaas16:31
*** openstackgerrit has joined #openstack-lbaas16:32
*** crc32 has joined #openstack-lbaas16:33
jschwarzdougwig, can I ask for an oh-so-old lbaas v1 patch review? https://review.openstack.org/#/c/174384/ :)16:43
*** KunalGandhi has joined #openstack-lbaas16:45
*** enikanorov2 has quit IRC16:48
*** minwang2 has joined #openstack-lbaas16:52
*** apuimedo has quit IRC16:55
*** enikanorov2 has joined #openstack-lbaas16:57
*** jschwarz has quit IRC16:58
*** bharath has joined #openstack-lbaas17:02
*** bharath has quit IRC17:06
*** vivek-ebay has quit IRC17:08
*** sbalukoff has joined #openstack-lbaas17:17
*** bharath has joined #openstack-lbaas17:23
*** amotoki has quit IRC17:25
*** vivek-ebay has joined #openstack-lbaas17:32
*** vivek-ebay has quit IRC17:32
*** bana_k has joined #openstack-lbaas17:34
*** bana_k has quit IRC17:46
*** madhu_ak has joined #openstack-lbaas17:49
*** SumitNaiksatam has joined #openstack-lbaas17:52
rm_workxgerman / ajmiller / johnsom: any of you around to explain how i get devstack working?17:53
ajmillerrm_work.  I'm around, but having devstack problems myself.17:53
*** vivek-ebay has joined #openstack-lbaas17:53
johnsomajmiller is the expert.17:53
ajmillerWhat is your issue?17:53
rm_workis it the think with ERROR: openstack Missing parameter(s):17:53
rm_workif so, i know the fix for THAT17:53
xgermanI haven’t installed in a while but in scroll back I saw you had stock LBaaS — you need dougwig’s patch17:53
johnsomBTW, the devstack scripts do create and load the amp image into glance and configure octavia for it17:54
*** vivek-ebay has quit IRC17:54
rm_workmy issue is that neutron-lbaas won't start because it can't find the octavia driver17:54
rm_workahhh yeah that is what i figured17:54
rm_workso which patch do i need17:54
rm_workajmiller: what problem are you having?17:54
johnsomI cherry pick this one: https://review.openstack.org/#/c/174114/17:54
rm_workis that "enable_plugin neutron-lbaas https://review.openstack.org/openstack/neutron-lbaas https://review.openstack.org/#/c/174114/" ?17:55
ajmillerrm_work.  I don't have routability from the devstack host OS into my devstack's private network, using my default "sample" scripts.17:55
rm_workajmiller: ah, ok, then nothing i can help with yet :P17:56
rm_worktrying to remember how to tell it to pick a certain review17:56
ajmillerIt used to "just work".  Now it doesn't.  Something has changed in the environment, like an iptables rule or somesuch.17:56
*** sc68cal has quit IRC17:56
rm_workah no it's "enable_plugin neutron-lbaas https://review.openstack.org/openstack/neutron-lbaas refs/changes/14/174114/20"17:57
rm_workkk17:57
ajmillerrm_work -- if you see "no route to host" errors, then it might be what I'm seeing.17:58
* ajmiller wonders how I did that.17:58
*** rm_work is now known as rm_work|away17:58
*** rm_work|away is now known as rm_work18:00
*** sc68cal has joined #openstack-lbaas18:02
*** sc68cal has quit IRC18:02
*** sc68cal has joined #openstack-lbaas18:02
*** bana_k has joined #openstack-lbaas18:26
TrevorVHey all, general question: can more than one review be dependent on a single review?18:45
TrevorVExample: bana_k needs doug's octavia driver review in lbaas, but I do as well, but don't necessarily need bana_k 's review... so can we BOTH depend on dougwig's review?18:45
iwi1hi all, is there any documentation on how to enable lbas v2 on non-devstack kilo ?18:47
iwi1and second question - can V2 be used from heat (in kilo) ?18:47
rm_workTrevorV: yeah no problem with that18:54
rm_workit's a tree18:55
bloganiwi1: not much documentation for that, though it'd be very similar to v118:57
bloganiwi1: and i do not believe heat has been updated for v218:58
TrevorVYeah, blogan answered for me rm_work thanks18:58
*** jorgem has joined #openstack-lbaas18:58
iwi1blogan: thanks18:59
openstackgerritTrevor Vardeman proposed openstack/neutron-lbaas: Fixing Octavia Driver delete operations  https://review.openstack.org/21270219:00
*** bharath has quit IRC19:03
*** bharath has joined #openstack-lbaas19:04
*** bharath has quit IRC19:08
TrevorVdougwig, you present my man?19:20
*** fnaval has quit IRC19:23
*** kfox1111 has joined #openstack-lbaas19:25
kfox1111I'm on kilo, but thinking ahead towards liberty where we will start playing with octavia...19:26
kfox1111we've got some grid services that are https, but do client cert based auth.19:26
kfox1111will that still work with the octavia ssl termination stuff, or does octavia have to just do tcp lb?19:27
rm_workhey where's the API docs for neutron-lbaas v2?19:27
rm_workxgerman / blogan / ajmiller / johnsom ^^19:27
*** fnaval has joined #openstack-lbaas19:28
ajmillerrm_work http://developer.openstack.org/api-ref-networking-v2-ext.html19:30
rm_workk19:31
rm_workthat is what i found too, but no TLS info in there yet19:31
*** bharath has joined #openstack-lbaas19:32
*** numan has quit IRC19:33
fnavalkicking off usage tests19:34
fnavaldamn - wrong window19:34
*** alejandrito has quit IRC19:44
rm_workfnaval: ok go for it19:50
TrevorVjohnsom, you around?19:57
ajmillerTrevorV He's out to lunch..19:59
TrevorVajmiller, any idea how long ago he left so I can talk to him when he gets back?19:59
ajmillerJust under an hour ago.20:00
TrevorVAlright, so relatively soon I should be able to talk with him?20:00
ajmillerI would think so.20:00
rm_work:P20:01
rm_workTrevorV: your impatience rivals even my own :P20:01
fnavalk thanks rm_work20:01
TrevorVajmiller, I only ask because sometimes people have to go to lunch and run errands or have appointments outside of work, or meetings, etc etc that colleagues know about, so I was trying to find an ETA.  Sorry for bothering ya!20:02
TrevorVrm_work, its not impatience, its just we have a meeting in 3020:02
TrevorVAnd I don't want to miss it.20:02
ajmillerNP.20:02
rm_workoh right20:03
rm_workthat think20:03
rm_work*that thing20:03
johnsomTrevorV just got back from lunch20:21
rm_workok cool, script seems to build octavia now20:23
rm_workerr, build devstack with octavia20:23
rm_workso now i just need to test the new thing20:24
TrevorVjohnsom, I'll PM you20:24
*** alejandrito has joined #openstack-lbaas20:28
openstackgerritMerged openstack/neutron-lbaas: Remove ipv6_pd_enabled from subnet data model  https://review.openstack.org/21161520:38
*** sbalukoff has quit IRC20:46
*** woodster_ has quit IRC20:50
*** woodster_ has joined #openstack-lbaas20:54
*** sbalukoff has joined #openstack-lbaas20:58
xgermankfix1111 Octavia will have SSL termination build in21:01
xgermankfox111121:01
xgermanit’s on our list for Liberty: https://etherpad.openstack.org/p/YVR-neutron-octavia21:02
xgermansee topic Prioritized List21:02
johnsomkfox1111 Actually, I don't think client certs for authentication is in scope for Liberty Octavia.  Just one way TLS offload21:10
xgermanyou are right — at least we only tested what you are describing ;-)21:12
johnsomYou can of course still pass the TLS through Octavia as a TCP flow, but we don't have TLS client auth in there yet.21:13
johnsomkfox1111 It would be great for us if you could write up your use case in a bug in our launchpad: https://bugs.launchpad.net/octavia/+filebug21:26
xgermanwell, RfE would be great indeed...21:27
openstackgerritAdam Harwell proposed openstack/octavia: Updating cert_parser for cert loading  https://review.openstack.org/20803521:27
rm_workhad to rebase for testing21:28
xgermanok21:28
johnsomrm_work Did you come up with any ideas on https://review.openstack.org/#/c/211371/21:30
johnsom?21:30
rm_workthat was also stalled on me actually getting devstack set up21:32
rm_workwhich is now working21:32
rm_workand I wanted to ask you what actually comes back there21:33
rm_workwhat does the json request look like21:33
rm_worki have never seen decode("string-escape")21:33
rm_workbut need to know what an example string looks like21:33
johnsomFor what ever reason, it comes back with the "'s \"'d21:34
rm_workwhat is the base string tho21:34
rm_workprior to json decoding at all21:34
johnsomThe other folks impacted on google said to use the string-escape codec.21:35
johnsomWhich blows chunks on the py34 unit test21:35
rm_worki need to figure out how to debug this21:35
rm_workwhich if i had a sample string would be easier21:36
TrevorVYou're a simple strin21:36
TrevorVstring**21:36
johnsomI closed all of those windows.  It will take me a few minutes to setup an image with the string logged for you21:37
*** ajmiller has quit IRC21:37
rm_work'{"a": "Hello world"}'21:37
rm_work^^ that is what JSON is supposed to look like in string form21:37
rm_workand when it includes strings21:37
TrevorVjohnsom, I have to leave for the day.  GOt some stuff at home I have to hurry for.  I'm going to save that etherpad link and then check it later/tomorrow when I can get to it again. okay>?21:37
TrevorVokay?****21:37
johnsomRight.  The stuff coming out of flask on py27 is like (from memory here) '{\"a\": \"Hello world\"}'21:38
rm_workso I wonder what flask is returning21:38
rm_workahh hmm21:38
openstackgerritTrevor Vardeman proposed openstack/octavia: Adding amphora failover flows  https://review.openstack.org/20233621:38
johnsomTrevorV Sounds good!21:38
rm_workI think flask has functions for decoding json internally, maybe those would be a better bet?21:39
johnsomrm_work give me a few minutes (it is pretty quick) and I will setup a test image21:39
rm_workkk21:39
TrevorVblogan, other interested parties:21:39
TrevorVhttps://etherpad.openstack.org/p/Octavia_Amphora_Failover_Steps21:39
crc32johnsom: xgerman is suggesting we ditch the status_sender.json file and inject an oslo formated config. Did you ever write that code to do this. I was under the impression you did this at the mid ycle21:39
*** TrevorV has quit IRC21:39
rm_workflask.request.get_json()21:39
johnsomYeah, they didn't help, tried them.  get_json() and such.  I also ran into some trouble with the flask test methods and the get_json stuff21:40
rm_workhmm21:40
johnsomxgerman already beat me up over that21:40
*** ajmiller has joined #openstack-lbaas21:40
xgermancrc32 the sender was conceived when it wasn’t clear that we would have the whole config file on the amphora via the config drive (if we use the REST agent)21:40
crc32he's beating me up over it now.21:41
johnsomcrc32 I was working on it.  I saw those comment this morning and was going to sync with you.  I will take that on and finish it, no problem.21:41
*** alejandrito has quit IRC21:41
crc32ok. Then I'll write up some mock teses.21:41
xgermanjohnsom thank you21:41
crc32tests21:41
*** madhu_ak has quit IRC21:41
xgermancrc32 also didn’t want to beat — I just noticed the situation has changed with the wider acceptance of the REST agent :-)21:41
johnsomThe xgerman beating was for not using get_json()21:42
rm_workI am trying to set up my own quick test to see if i can replicate it with a standalone flask app21:43
*** madhu_ak has joined #openstack-lbaas21:43
xgermanyeah, the whole thing is bizarre — I suggested to him the .json stuff as well21:43
xgermanand I made him switch from form parameters to json21:43
johnsomYeah, man, the form worked just fine... grin21:45
rm_workheh21:45
johnsomrm_work "{\"subnet_cidr\": \"10.0.0.0/24\", \"gateway\": \"10.0.0.1\"}"21:55
rm_workyeah ok seeing similar21:55
johnsomI wasted a day trying to figure out why and a better way to deal with it.21:56
rm_worksent in this:21:56
rm_work{'a': 1}21:56
rm_work'{\\'a\\': 1}'21:56
rm_workget that21:56
crc32like """{subnet_cidr":"10.0.0.0/24"}"""21:56
crc32oh did you json dump the string twice?21:58
rm_workjohnsom: hmm looks like if i use double-quotes on the sending-side21:58
rm_workjohnsom: then it looks ok21:58
rm_work{"a": "hello"}  ->  '{"a": "hello"}'21:58
rm_workand in this case .get_json() works21:59
johnsomBut I'm giving json.loads a dict....  https://review.openstack.org/#/c/208793/5/octavia/amphorae/drivers/haproxy/rest_api_driver.py22:00
johnsomopps, dumps22:00
rm_workso the "sending side" is directly from the result of json.dumps() ?22:00
johnsomYe[22:01
johnsomyep22:01
rm_workhmm22:01
openstackgerritSherif Abdelwahab proposed openstack/octavia: Amphora Flows and Service Drivers for Active Standby  https://review.openstack.org/20625222:01
crc32json.dumps(json.dumps({"test":0})) -> '"{\\"test\\": 0}"'22:01
rm_workjson.dumps({'a': "hello"}) -> '{"a": "hello"}'22:01
rm_workyeah22:02
rm_workthat looks like a double-dump22:02
* blogan snickers at double-dump22:02
rm_work:P22:02
crc32print json.dumps(json.dumps({'test':0})22:02
rm_workcrc32 is correct tho, it looks like maybe it's being encoded twice on the other end22:02
rm_workwhere is the "other end" of this22:03
rm_workah you already linked it22:03
johnsomhttps://review.openstack.org/#/c/211371/1/octavia/amphorae/backends/agent/api_server/server.py22:03
rm_workah22:04
rm_workuhh22:04
rm_workif that is using requests to post22:04
rm_worki think "json" is supposed to take a dict22:04
rm_worknot a string22:04
rm_workr = requests.post(url, data=json.dumps(payload))22:05
rm_workor22:05
rm_workr = requests.post(url, json=payload)22:05
rm_worki THINK22:05
crc32json.dumps takes a string.22:06
rm_workerr22:06
crc32sorry takes a dict22:06
rm_workyes22:06
rm_worki think you either dumps() the dict and provide it as data22:06
rm_workor just provide the dict directly as "json"22:06
rm_worktrying to find the approproate Requests doc22:07
rm_work*appropriate22:07
rm_workyeah can't find the doc22:08
rm_workbut i tested22:08
rm_workhttp://stackoverflow.com/a/26344315/465571722:09
rm_workyou're double-encoding on the other end22:09
rm_workhttps://review.openstack.org/#/c/208793/5/octavia/amphorae/drivers/haproxy/rest_api_driver.py line 30822:10
rm_workjohnsom: ^^22:10
rm_workthanks for the catch crc3222:10
rm_workjohnsom: sorry I didn't catch it in the original review22:13
johnsomThat's ok.  The requests docs are so clear on this issue: json – (optional) json to send in the body of the Request.22:14
johnsomWhich implies to me it's json encoded.22:14
johnsomSo, riddle is why does it not fail on py3422:14
johnsomI will give this a try22:14
rm_workyeah22:15
rm_workdocs are bad here22:15
rm_worki only know because i use requests *a lot*22:15
rm_workfor personal projects22:15
rm_workand also please switch at the same time to using get_json()22:15
rm_workit really is the best way to do this22:16
rm_workI am guessing the only reason it was failing was due to the double-encode22:16
rm_workbecause i can reproduce that failure here22:16
rm_workerr, locally, in my test flask app22:16
*** jorgem has quit IRC22:20
johnsomrm_work works.  Head slap.  I will fix the patchset now22:22
rm_workkk22:23
*** jorgem has joined #openstack-lbaas22:23
*** vivek-ebay has joined #openstack-lbaas22:26
rm_workxgerman: did you want to +2 the current iteration of https://review.openstack.org/#/c/208035/ ?22:33
rm_workbefore I workflow it, assuming this test works22:34
xgermansure, you still need to +A22:34
johnsomI haven't had a chance to look at that one yet22:35
xgermanit already has three +222:35
xgermanbut the more the merrier22:35
*** vivek-ebay has quit IRC22:46
*** vivek-ebay has joined #openstack-lbaas22:46
bana_kI see couple of examples in lbaas driver where tls info is passed on as 'default_tls_container_id': listener.default_tls_container_id and sni as sni_container_ids in listener dict22:51
bana_kis that all is need for octaiva driver also?22:51
bana_kneeded*22:52
bana_kxgerman blogan johnsom TrevorV22:56
bana_k?22:56
johnsombana_k I am here, but I don't have the details to answer your question. Sorry22:56
bana_koh ok. NP22:57
bloganbana_k: are you working off this review: https://review.openstack.org/#/c/209682/22:57
bana_kno22:58
bloganbana_k: i believe pothole was working on that and discovered octavia did not have sni exposed through the API so he was adding that22:58
*** jorgem has quit IRC22:58
bloganbana_k: https://review.openstack.org/#/c/209684/22:58
bloganbana_k: but if you look there, octavia takes tls_certificate_id, instead of what neutron_lbaas's deafult_tls_container_id22:59
bana_kbut plugin will be passing the container id isn't it?23:00
*** woodster_ has quit IRC23:00
*** abdelwas has quit IRC23:01
openstackgerritMichael Johnson proposed openstack/octavia: Fixes REST driver json encoding  https://review.openstack.org/21137123:02
bloganbana_k: yes23:02
johnsomrm_work ^^23:02
bloganbana_k: are you working on the octavia driver to pass tls info to octavia?23:02
bana_kyes23:02
bloganbana_k: so yeah it should just be as simple as passing what the plugin gives you, and giving it to octavia but octavia accepts it as that other name23:07
rm_workwhich again, pothole had already done in that review blogan linked earlier, no?23:07
bana_koh k . Got it23:07
bloganrm_work: correct23:08
bloganit still needs tests23:08
xgermantests...23:08
rm_workjohnsom: LGTM, +2/+A23:09
rm_workassuming tests pass, it'll go right in23:09
johnsomThanks!23:09
johnsomYeah, I tox'd it up23:09
rm_worknote that I am not afraid of +A pre-jenkins23:09
rm_workbecause if jenkins has a problem it'll override the +A anyway23:09
johnsomHaha23:09
rm_workpeople always question me about that <_<23:09
rm_worki just look at it as efficiency23:09
johnsomQuestion or shame?23:10
rm_workboth :P23:10
johnsomI at least wait for the sonar job because then I know it has passed py2723:10
*** minwang2 has quit IRC23:12
*** minwang2 has joined #openstack-lbaas23:13
rm_workerk, just noticed this stuff is incorrectly instantiating a BarbicanCertManager directly... https://review.openstack.org/#/c/208035/4/octavia/amphorae/drivers/haproxy/ssh_driver.py,cm23:14
rm_worki guess I'll make the fix for that as a followup23:14
rm_workrather than insist pothole fix code in that review that he didn't touch :P23:14
johnsomOr you could update this one, and the rest driver....23:15
rm_workxgerman: i have a question on https://review.openstack.org/#/c/208035/4 which maybe pothole should be answering but possibly you can answer too?23:18
rm_workdoes the rest driver do that too johnsom ?23:18
bana_kyea, so I am kinda confused about what I am supposed to do :D23:18
rm_workbana_k: what was the actual task?23:18
rm_work"fix up the octavia driver for neutron-lbaas"23:19
rm_work?23:19
xgermanmmh, let me check23:20
bana_k"there was some work to do in the LBaaSv2 Octavia driver to finish up TLS"23:20
rm_workah23:20
openstackgerritMerged openstack/octavia: Fixes REST driver json encoding  https://review.openstack.org/21137123:20
rm_workyeah so i think it might just be to finish testing pothole's CR23:20
bana_khmm ok.23:21
xgermanbana_k looks like it23:21
xgermanrm_work no the rest driver hasn’t that code yet23:21
johnsomrm_work It looks like the REST driver borrowed the code from the old ssh driver....23:22
xgermanI am sort of behind what i’s being put into the ssh driver23:22
openstackgerritAdam Harwell proposed openstack/octavia: Fix a typo in the devstack plugin.sh which caused a truncated error  https://review.openstack.org/21283423:22
rm_work^^ trivial23:22
rm_workjust was annoying me last night23:22
rm_workI kept getting "ERROR: The neutron"23:23
rm_workand that was it T_T23:23
johnsomI will be bold on that one and +223:24
rm_workheh23:24
rm_workxgerman: fastest workflow ever, or FASTEST WORKFLOW EVER? :P23:24
rm_workone character change FTW23:24
xgermandone23:25
rm_worklike magic :)23:25
johnsomrm_work People will think you are fishing for ATC....23:25
rm_workhah23:25
xgermanI have seen a couple of those if -> elif23:27
xgermanthere was even somebody who looked like Doug’s wife23:27
rm_workyeah i saw that :P23:27
johnsomHahaha, I am not going to touch that comment23:28
rm_workToo many Wiegleys :P23:28
xgermanrm_work regarding the ssl cert stuff I think pothole also has a patch which refactors that so we can share code better between drivers23:29
davidlenwellhey.. do we have a digital image of the octavia sticker?23:30
davidlenwellI want to put it in a slide for a talk I am giving23:30
xgermanJulian did those — I will see if he is still around23:31
davidlenwellthanks xgerman23:31
openstackgerritMerged openstack/octavia: Fix a typo in the devstack plugin.sh which caused a truncated error  https://review.openstack.org/21283423:36
davidlenwellthanks xgerman!!23:42
xgermangreat — make us proud...23:43
xgermanthough I am hoping sbalukoff is there and heckles :-)23:43
davidlenwellyou will be a small part of my "state of advanced services" portion of my talk23:43
sbalukoffOh, I plan on it.23:44
davidlenwellhopefully I don't get too much heckling from bluebox.. I might have to flip a table over and walk out ;)23:44
davidlenwellyou'll be there tonight sbalukoff?23:44
sbalukoffOh wait! That's tonight? Sorry, I actually won't be there tonight.23:44
davidlenwellthen I can say anything I want about you ;)23:45
rm_workwe usually do that already :P23:45
* rm_work waves at sbalukoff 23:45
sbalukoff(Ended up working from home--  caring for a stupid liar (and sick) kitty)23:45
sbalukoffHaha!23:45
rm_workfixing this issue presently23:46
rm_work^^ using the Barbican stuff directly23:46
rm_workI don't see it being used in the REST driver?23:46
xgermannope23:47
openstackgerritBharath M proposed openstack/octavia: Add Housekeeping to manage spare amphora  https://review.openstack.org/20282923:47
rm_workhmm23:48
rm_workwtf23:48
rm_workcfg.StrOpt('cert_manager',23:48
rm_work               default='barbican_cert_manager',23:48
rm_work               help=_('Name of the cert manager to use')),23:48
rm_workended up in "haproxy_amphora_opts"23:48
rm_workthus config group "haproxy_amphora"23:49
rm_workwhich is weird23:49
rm_workthe certmanager itself registers opts already, and does so in the "certificates" group23:50
*** diogogmt has quit IRC23:51
xgermanmmh23:51
rm_worklooks like you did that xgerman23:51
xgermanyep, I recall23:52
rm_workbut i also don't really understand how this aliasing stuff works23:52
rm_workthe default is "barbican_cert_manager" which i saw defined in some setup config23:52
xgermanthat cert stuff is for generating the cert to talk to the amphora23:52
rm_workto alias the full path name23:52
rm_workhmm23:52
rm_workbut it's for certManager23:52
rm_worknot certGenerator23:52
rm_workO_o23:52
rm_workxgerman: can you collaborate with me on this patchset? I'll submit it with that removed and the fixes to the SSH driver23:53
rm_workand you can pull it down and make a patchset to fix REST to match?23:53
xgermansure, can do23:53
rm_workand fix it to use the alias because i am not sure how you did that23:54
* johnsom ducks23:54
rm_worklol23:54
xgermanyeah, I have to try to remember as well23:54
rm_workjohnsom: do you know how those config aliases work? :P23:54
johnsomI was ducking because I thought xgerman was going to volutell me to take on the REST part.  That said, I have spent some time looking at how the oslo config stuff works.23:55
xgermannah, I will do that myself :-)23:56
xgermanREST — oslo I need to try to remember23:56
rm_workah23:57
rm_workit's that we half-converted it to using Stevedore23:57
rm_workbut only half23:57
rm_workok, I can finish that conversion I guess23:57
johnsomrm_work What is your question?  it's aliased to "haproxy_amphora" below in the register_opts section23:58
rm_workjohnsom: somehow "barbican_cert_manager" is aliased to the full class path23:58
rm_workfor BarbicanCertManager()23:58
rm_workit's a stevedore thing23:58
*** jorgem has joined #openstack-lbaas23:58
rm_worki saw it in a config once23:58
johnsomrm_work Yeah, entry_points in the setup.cfg23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!