openstackgerrit | German Eichberger proposed openstack/octavia: haproxy reference amphora REST API client https://review.openstack.org/171172 | 00:14 |
---|---|---|
*** KunalGandhi has quit IRC | 00:20 | |
openstackgerrit | Madhusudhan Kandadai proposed openstack/neutron-lbaas: WIP: Neutron LBaaS: Load Balancer Basic Scenario Test https://review.openstack.org/158904 | 00:25 |
madhu_ak | blogan, fnaval: as a result of restructuring, I believe I am following correctly by adding the relevant files into the tree | 00:26 |
fnaval | madhu_ak: i'll take a look when i get a chance - thanks for the heads up | 00:27 |
madhu_ak | fnaval: its still in WIP though..kinda almost done..will keep continuing with that patc | 00:28 |
madhu_ak | continuing working with that patch* | 00:29 |
fnaval | kk | 00:29 |
*** mwang2_ has quit IRC | 00:42 | |
*** bharath has quit IRC | 00:45 | |
*** fnaval has quit IRC | 01:09 | |
*** madhu_ak has quit IRC | 01:15 | |
*** KunalGandhi has joined #openstack-lbaas | 01:24 | |
*** Kunal has joined #openstack-lbaas | 01:24 | |
*** fnaval has joined #openstack-lbaas | 01:30 | |
*** KunalGan_ has joined #openstack-lbaas | 01:31 | |
*** Kunal has quit IRC | 01:31 | |
*** KunalGandhi has quit IRC | 01:32 | |
*** ypraveen has joined #openstack-lbaas | 01:36 | |
*** fnaval has quit IRC | 01:38 | |
*** kiran-r has joined #openstack-lbaas | 01:47 | |
ptoohill | Wondering if we should maybe move these refactorings to its own patch and have the actual tests dependant off of that? If not, are we ok with letting the tests in without the refactoring I was hoping for? Im not really ok with it and would like to see the tests refactored before this is accepted. Just thinking aloud since it was brought up. | 02:03 |
*** amotoki has joined #openstack-lbaas | 02:04 | |
*** kiran-r has quit IRC | 02:12 | |
*** amotoki has quit IRC | 02:20 | |
*** ypraveen has quit IRC | 02:29 | |
*** amotoki has joined #openstack-lbaas | 02:31 | |
*** bradjones has quit IRC | 02:35 | |
*** bradjones has joined #openstack-lbaas | 02:35 | |
*** bradjones has quit IRC | 02:35 | |
*** bradjones has joined #openstack-lbaas | 02:35 | |
*** amotoki has quit IRC | 02:39 | |
*** amotoki has joined #openstack-lbaas | 02:39 | |
*** kiran-r has joined #openstack-lbaas | 02:48 | |
*** amotoki has quit IRC | 03:01 | |
*** KunalGan_ has quit IRC | 03:07 | |
*** kiran-r has quit IRC | 03:08 | |
*** KunalGandhi has joined #openstack-lbaas | 03:10 | |
*** Kunal has joined #openstack-lbaas | 03:10 | |
*** KunalGan_ has joined #openstack-lbaas | 03:12 | |
*** kiran-r has joined #openstack-lbaas | 03:12 | |
*** KunalGandhi has quit IRC | 03:15 | |
*** Kunal has quit IRC | 03:15 | |
*** ganeshna has joined #openstack-lbaas | 03:17 | |
*** kiran-r has quit IRC | 03:20 | |
*** amotoki has joined #openstack-lbaas | 03:24 | |
*** bharath has joined #openstack-lbaas | 03:45 | |
*** bharath has quit IRC | 03:50 | |
*** redrobot has quit IRC | 03:55 | |
*** ganeshna has quit IRC | 04:08 | |
*** ganeshna has joined #openstack-lbaas | 04:13 | |
*** ypraveen has joined #openstack-lbaas | 04:35 | |
*** amotoki has quit IRC | 04:59 | |
*** kiran-r has joined #openstack-lbaas | 05:08 | |
*** KunalGan_ has quit IRC | 05:20 | |
*** amotoki has joined #openstack-lbaas | 05:21 | |
*** ganeshna has quit IRC | 05:41 | |
*** ganeshna has joined #openstack-lbaas | 05:45 | |
*** ypraveen has quit IRC | 05:51 | |
*** ganeshna_ has joined #openstack-lbaas | 06:06 | |
*** Kunal has joined #openstack-lbaas | 06:06 | |
*** numan has joined #openstack-lbaas | 06:07 | |
*** ganeshna has quit IRC | 06:09 | |
*** KunalGan_ has joined #openstack-lbaas | 06:10 | |
*** Kunal has quit IRC | 06:11 | |
*** numan has quit IRC | 06:12 | |
*** numan has joined #openstack-lbaas | 06:19 | |
*** ganeshna_ has quit IRC | 06:21 | |
*** KunalGan_ has quit IRC | 06:24 | |
*** ganeshna has joined #openstack-lbaas | 06:25 | |
*** numan has quit IRC | 06:55 | |
*** nmagnezi has joined #openstack-lbaas | 06:58 | |
*** chlong has quit IRC | 07:18 | |
*** woodster_ has quit IRC | 07:21 | |
*** bradjones has quit IRC | 07:30 | |
*** bradjones has joined #openstack-lbaas | 07:36 | |
*** bradjones has quit IRC | 07:36 | |
*** bradjones has joined #openstack-lbaas | 07:36 | |
*** bharath_ has joined #openstack-lbaas | 07:36 | |
*** ganeshna has quit IRC | 07:37 | |
*** Kunal has joined #openstack-lbaas | 07:52 | |
*** KunalGandhi has joined #openstack-lbaas | 07:52 | |
*** ganeshna has joined #openstack-lbaas | 08:07 | |
*** KunalGandhi has quit IRC | 08:25 | |
*** Kunal has quit IRC | 08:29 | |
*** ganeshna has quit IRC | 08:41 | |
*** ganeshna has joined #openstack-lbaas | 08:43 | |
*** bharath_ has quit IRC | 08:49 | |
*** chlong has joined #openstack-lbaas | 08:59 | |
*** ganeshna has quit IRC | 09:02 | |
*** ganeshna has joined #openstack-lbaas | 09:03 | |
*** chlong has quit IRC | 09:07 | |
*** chlong has joined #openstack-lbaas | 09:20 | |
*** kiran-r has quit IRC | 09:50 | |
*** ganeshna has quit IRC | 11:04 | |
*** ganeshna has joined #openstack-lbaas | 11:11 | |
*** ganeshna has quit IRC | 11:12 | |
openstackgerrit | Nir Magnezi proposed openstack/octavia: Fix the devstack octavia plugin for non ubuntu distributions https://review.openstack.org/192153 | 11:24 |
*** kiran-r has joined #openstack-lbaas | 11:41 | |
*** bharath_ has joined #openstack-lbaas | 11:50 | |
*** bharath_ has quit IRC | 11:55 | |
*** ganeshna has joined #openstack-lbaas | 12:02 | |
*** ganeshna has joined #openstack-lbaas | 12:03 | |
*** ganeshna has joined #openstack-lbaas | 12:03 | |
*** kiran-r has quit IRC | 12:17 | |
*** ganeshna has quit IRC | 12:27 | |
*** redrobot has joined #openstack-lbaas | 12:42 | |
*** redrobot is now known as Guest74993 | 12:42 | |
*** Guest74993 is now known as el_robot_rojo | 12:43 | |
*** el_robot_rojo is now known as redrobot | 12:44 | |
*** ganeshna has joined #openstack-lbaas | 12:49 | |
*** amotoki has quit IRC | 12:56 | |
*** kiran-r has joined #openstack-lbaas | 13:03 | |
*** ganeshna has quit IRC | 13:23 | |
*** ganeshna has joined #openstack-lbaas | 13:25 | |
*** ganeshna has quit IRC | 13:36 | |
*** localloop127 has joined #openstack-lbaas | 13:41 | |
*** numan has joined #openstack-lbaas | 13:57 | |
*** mlavalle has joined #openstack-lbaas | 13:58 | |
*** mlavalle has quit IRC | 13:59 | |
*** mlavalle has joined #openstack-lbaas | 13:59 | |
*** amotoki has joined #openstack-lbaas | 14:00 | |
*** ajmiller has joined #openstack-lbaas | 14:05 | |
*** woodster_ has joined #openstack-lbaas | 14:09 | |
nmagnezi | blogan, ping | 14:20 |
*** TrevorV has joined #openstack-lbaas | 14:26 | |
*** kiran-r has quit IRC | 14:29 | |
*** kiran-r has joined #openstack-lbaas | 14:29 | |
*** kiran-r has quit IRC | 14:35 | |
*** fnaval has joined #openstack-lbaas | 14:46 | |
*** TrevorV has quit IRC | 15:03 | |
*** TrevorV has joined #openstack-lbaas | 15:09 | |
*** numan has quit IRC | 15:10 | |
*** ajmiller has quit IRC | 15:27 | |
*** rm_you| has quit IRC | 15:27 | |
*** rm_you| has joined #openstack-lbaas | 15:27 | |
*** ajmiller has joined #openstack-lbaas | 15:27 | |
*** KunalGandhi has joined #openstack-lbaas | 15:33 | |
*** Kunal has joined #openstack-lbaas | 15:33 | |
*** KunalGandhi has quit IRC | 15:35 | |
*** Kunal has quit IRC | 15:35 | |
*** KunalGandhi has joined #openstack-lbaas | 15:36 | |
*** Kunal has joined #openstack-lbaas | 15:36 | |
blogan | magnezi pong | 15:36 |
nmagnezi | blogan, hi there | 15:40 |
nmagnezi | blogan, i have a question about octavia | 15:40 |
blogan | nmagnezi: shoot | 15:40 |
*** Kunal has quit IRC | 15:40 | |
*** KunalGandhi has quit IRC | 15:40 | |
nmagnezi | blogan, i followed the available docs in order to make it work on my devstack | 15:40 |
nmagnezi | blogan, now.. it seems like services are up, but how should i interact with it? | 15:41 |
nmagnezi | i expected it to be configured as a driver in neutron's config files, but it's not | 15:41 |
openstackgerrit | Trevor Vardeman proposed openstack/octavia: Fix the delete listener flow https://review.openstack.org/190269 | 15:41 |
nmagnezi | blogan, oh and btw found a tiny issue with the packages installation https://review.openstack.org/#/c/192153/ | 15:42 |
nmagnezi | blogan, ? | 15:49 |
blogan | sorry nmagnezi had to step away, im back | 15:55 |
blogan | reading scroll back | 15:55 |
blogan | nmagnezi: you'll have to use this review to get it working with neutron | 15:57 |
blogan | https://review.openstack.org/#/c/174114/ | 15:57 |
blogan | so if you pull that review down in neutron-lbaas, you'll be able to make client calls to octavia | 15:57 |
xgerman | yep, that’s what we have been doing | 15:57 |
blogan | nmagnezi: but you can also make API calls to Octavia because it is running its own API server | 15:58 |
xgerman | http://octavia.io/review/master/main/octaviaapi.html | 15:58 |
xgerman | ^ nmagnezi | 15:59 |
blogan | oh xgerman, i've found out that we (rax and other large deployers) can't use subnet_id to create a VIP on our provider networks, so we'll need network_id in that call | 16:01 |
xgerman | ok, neat | 16:02 |
xgerman | so it was right all along? | 16:02 |
blogan | xgerman: i suspect yall might run into the same thing | 16:02 |
xgerman | yep | 16:02 |
blogan | xgerman: well there is a use for subnet_id as well | 16:03 |
blogan | xgerman: so allowing both should be good | 16:03 |
openstackgerrit | Trevor Vardeman proposed openstack/octavia: Fix the delete listener flow https://review.openstack.org/190269 | 16:03 |
xgerman | both is best | 16:03 |
xgerman | we need to figure out how octavia squares with our setup | 16:04 |
blogan | xgerman: will have to add network_id on the member too i believe, but that is going to be quite tricky in the future with how the nova scheduling happens with cells and subnets | 16:04 |
xgerman | mmh | 16:04 |
blogan | xgerman: luckily we got a lab set up internally mimicing our production environments so i've been able to find out all the things we need | 16:04 |
xgerman | that’s our next step | 16:05 |
xgerman | once johnsom finishes with the sonar work ;-) | 16:05 |
blogan | xgerman: do you know if your nova uses cells? | 16:05 |
xgerman | I don’t think so but things are fluid on that end, too | 16:06 |
blogan | xgerman: you might be fine until they start using them | 16:06 |
xgerman | yeah, we are getting our own test cluster later next month | 16:07 |
blogan | sweet | 16:07 |
xgerman | just 10 nodes… but... | 16:07 |
blogan | its something, our lab is just cab, but since we have our own flavor of neutron and nova, its helpful just to find the differences | 16:08 |
xgerman | yeah, I am looking forward to that work, too | 16:08 |
nmagnezi | blogan, xgerman thank you guys.. will take a look into those :) | 16:11 |
*** nmagnezi has quit IRC | 16:15 | |
*** madhu_ak has joined #openstack-lbaas | 16:17 | |
*** amotoki has quit IRC | 16:28 | |
*** kiran-r has joined #openstack-lbaas | 16:35 | |
*** johnsom has quit IRC | 16:41 | |
*** kiran-r has quit IRC | 16:45 | |
*** mwang2 has joined #openstack-lbaas | 16:46 | |
*** mlavalle has quit IRC | 16:54 | |
openstackgerrit | Merged openstack/octavia: Fix the devstack octavia plugin for non ubuntu distributions https://review.openstack.org/192153 | 16:56 |
*** jschwarz has joined #openstack-lbaas | 16:57 | |
*** nmagnezi has joined #openstack-lbaas | 16:58 | |
*** amotoki has joined #openstack-lbaas | 17:11 | |
openstackgerrit | Phillip Toohill proposed openstack/octavia: Hooking TLS together https://review.openstack.org/185540 | 17:12 |
*** bharath has joined #openstack-lbaas | 17:17 | |
*** mwang2 has quit IRC | 17:31 | |
*** ypraveen has joined #openstack-lbaas | 17:40 | |
openstackgerrit | Phillip Toohill proposed openstack/octavia: Hooking TLS together https://review.openstack.org/185540 | 17:41 |
*** jschwarz has quit IRC | 17:55 | |
*** mwang2 has joined #openstack-lbaas | 17:56 | |
*** localloop127 has quit IRC | 18:03 | |
*** localloop127 has joined #openstack-lbaas | 18:06 | |
*** mlavalle has joined #openstack-lbaas | 18:14 | |
*** nmagnezi has quit IRC | 18:17 | |
*** crc32 has joined #openstack-lbaas | 18:24 | |
*** crc32 has quit IRC | 18:29 | |
*** crc32 has joined #openstack-lbaas | 18:43 | |
*** amotoki has quit IRC | 18:49 | |
openstackgerrit | Trevor Vardeman proposed openstack/octavia: Fix the delete health monitor flow https://review.openstack.org/192359 | 19:00 |
*** localloop127 has quit IRC | 19:09 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas: Updated from global requirements https://review.openstack.org/190407 | 19:18 |
openstackgerrit | Trevor Vardeman proposed openstack/octavia: Fix the delete health monitor flow https://review.openstack.org/192359 | 19:22 |
*** harlowja has quit IRC | 19:25 | |
openstackgerrit | Brandon Logan proposed openstack/octavia: Fix for return traffic from VIP blackholing https://review.openstack.org/185244 | 19:26 |
*** localloop127 has joined #openstack-lbaas | 19:39 | |
openstackgerrit | Doug Hellmann proposed openstack/neutron-lbaas: Update version for Liberty https://review.openstack.org/192411 | 19:51 |
*** mwang2 has quit IRC | 20:10 | |
openstackgerrit | Trevor Vardeman proposed openstack/octavia: Update PUT methods to send update through queue https://review.openstack.org/170989 | 20:17 |
openstackgerrit | Trevor Vardeman proposed openstack/octavia: Update PUT methods to send update through queue https://review.openstack.org/170989 | 20:18 |
openstackgerrit | Trevor Vardeman proposed openstack/octavia: Fix the delete health monitor flow https://review.openstack.org/192359 | 20:18 |
*** ajmiller_ has joined #openstack-lbaas | 20:27 | |
*** ajmiller has quit IRC | 20:31 | |
*** mwang2 has joined #openstack-lbaas | 20:37 | |
*** johnsom has joined #openstack-lbaas | 20:44 | |
*** KunalGandhi has joined #openstack-lbaas | 21:02 | |
*** TrevorV has quit IRC | 21:04 | |
*** harlowja has joined #openstack-lbaas | 21:13 | |
*** harlowja has quit IRC | 22:00 | |
*** harlowja has joined #openstack-lbaas | 22:02 | |
madhu_ak | blogan: ping | 22:06 |
blogan | madhu_ak: pong | 22:06 |
madhu_ak | yeah, I saw your comment for https://review.openstack.org/#/c/180019/ | 22:07 |
madhu_ak | I thought about that for a while and am concerned about having new base.py for admin_state_up tests | 22:08 |
blogan | madhu_ak: what are your concerns? | 22:08 |
madhu_ak | right now, we have base.py which is actually being called by all the tests, so, even that base.py for admin_state_up tests, base.py is still being called in. So, Instead of creating a new file, having the relevant methods in the base.py itself makes sense to me | 22:09 |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Tempest tests for Members using testscenarios. https://review.openstack.org/180436 | 22:11 |
*** localloop127 has quit IRC | 22:14 | |
*** apuimedo has joined #openstack-lbaas | 22:16 | |
blogan | madhu_ak: good point, having it as its own class makes sense to me, but putting it in the same module as the base class makes a lot of sense tooo | 22:17 |
blogan | madhu_ak: is that what you're going after? | 22:17 |
mwang2 | i prefer to put it under base.py instead of an indepent file | 22:19 |
madhu_ak | blogan: i think so. because i feel its good to maintain one base.py per folder will be easy for beginners who plan to write the tempest tests in future too | 22:20 |
blogan | madhu_ak, mwang2: i agree, yall want to comment on Aish's review to do that? yall can still chain off that review though | 22:20 |
madhu_ak | sure thing | 22:21 |
mwang2 | blogan: i reviewed madhu_ak's code this morning and he mentioned that you want to reduce one test for updating with admin_state_up, correct | 22:23 |
blogan | mwang2: yeah bc it became redundant | 22:23 |
mwang2 | is that just for loadbalancer or for all | 22:23 |
blogan | mwang2: just specific to those tests | 22:24 |
mwang2 | yeah , i mean is that same for lb, listener ,members, and healthmonitors for tempest | 22:24 |
blogan | mwang2: what do you mean? | 22:29 |
mwang2 | <blogan>: let me confirm again, so when do update method, we only need to test when amdin_state_up = true | 22:29 |
mwang2 | correct? | 22:29 |
mwang2 | https://review.openstack.org/#/c/178827/15/neutron_lbaas/tests/tempest/v2/api/test_admin_state_up_health_monitor.py | 22:29 |
mwang2 | for example, in my code, i have def test_update_health_monitor_state_up_false_with_scenarios and def test_update_health_monitor_state_up_true_with_scenarios | 22:30 |
*** ajmiller_ is now known as ajmiller | 22:30 | |
mwang2 | so now we only need one method, which is def test_update_health_monitor_state_up_true_with_scenari | 22:30 |
blogan | mwang2: ah, so those tests, don't you think that combination will be met with one test uses the self.healthmonitor_flag? | 22:31 |
mwang2 | can you explain | 22:32 |
blogan | without setting it to True and False? as in just doing one update test with testscenarios setting self.healthmonitor_flag will test it with True and False | 22:32 |
mwang2 | I noticed that Aish use a class to handle the update in her patch, what is your comment on that | 22:34 |
mwang2 | https://review.openstack.org/180436 | 22:34 |
blogan | im fine with that, it accomplishes the same thing | 22:36 |
blogan | thats kind of a style choice there | 22:37 |
*** openstackgerrit has quit IRC | 22:38 | |
*** openstackgerrit has joined #openstack-lbaas | 22:39 | |
mwang2 | got it | 22:44 |
*** bharath has quit IRC | 22:49 | |
*** chlong has quit IRC | 23:15 | |
*** mwang2 has quit IRC | 23:24 | |
*** ajmiller has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!