openstackgerrit | min wang proposed openstack/neutron-lbaas: Admin_state_up tempest test for health monitor https://review.openstack.org/178827 | 00:14 |
---|---|---|
*** mlavalle has quit IRC | 00:29 | |
*** amotoki has joined #openstack-lbaas | 00:33 | |
*** amotoki has quit IRC | 00:38 | |
*** kiran-r has joined #openstack-lbaas | 00:44 | |
*** madhu_ak has quit IRC | 01:05 | |
*** chlong has quit IRC | 01:11 | |
*** fnaval has quit IRC | 01:11 | |
*** fnaval has joined #openstack-lbaas | 01:22 | |
*** KunalGandhi has quit IRC | 02:04 | |
*** sbalukoff has quit IRC | 02:11 | |
*** amotoki has joined #openstack-lbaas | 02:21 | |
*** amotoki has quit IRC | 02:40 | |
*** kiran-r has quit IRC | 02:51 | |
*** ganeshna has joined #openstack-lbaas | 02:52 | |
*** ganeshna has quit IRC | 03:02 | |
*** ganeshna has joined #openstack-lbaas | 03:35 | |
*** kiran-r has joined #openstack-lbaas | 03:42 | |
*** amotoki has joined #openstack-lbaas | 03:49 | |
*** kiran-r has quit IRC | 03:57 | |
*** numan has joined #openstack-lbaas | 04:22 | |
*** fnaval has quit IRC | 04:58 | |
*** Santoshsh has joined #openstack-lbaas | 05:05 | |
*** ajmiller_ has quit IRC | 05:05 | |
*** ajmiller has joined #openstack-lbaas | 05:06 | |
*** jschwarz has joined #openstack-lbaas | 05:12 | |
*** kiran-r has joined #openstack-lbaas | 05:15 | |
*** madhu_ak has joined #openstack-lbaas | 05:18 | |
*** Alex_Stef has joined #openstack-lbaas | 05:40 | |
*** Alex_Stef has quit IRC | 05:45 | |
*** woodster_ has quit IRC | 06:11 | |
*** bharath has quit IRC | 06:20 | |
*** SteF has joined #openstack-lbaas | 06:26 | |
*** madhu_ak has quit IRC | 06:35 | |
*** apuimedo has joined #openstack-lbaas | 06:39 | |
*** ganeshna has quit IRC | 06:49 | |
openstackgerrit | Anand Shanmugam proposed openstack/neutron-lbaas: Adding code to prevent vip port deletion from port api https://review.openstack.org/176016 | 06:51 |
*** jschwarz has quit IRC | 06:51 | |
*** sbalukoff has joined #openstack-lbaas | 06:53 | |
*** bradjones has quit IRC | 07:27 | |
*** ganeshna has joined #openstack-lbaas | 07:28 | |
*** bradjones has joined #openstack-lbaas | 07:29 | |
*** bradjones has quit IRC | 07:29 | |
*** bradjones has joined #openstack-lbaas | 07:29 | |
*** ganeshna has quit IRC | 07:33 | |
*** nmagnezi has joined #openstack-lbaas | 07:34 | |
*** nmagnezi has quit IRC | 07:52 | |
*** jschwarz_ has joined #openstack-lbaas | 07:52 | |
*** nmagnezi has joined #openstack-lbaas | 07:55 | |
*** ganeshna has joined #openstack-lbaas | 08:03 | |
*** ganeshna has quit IRC | 08:10 | |
*** ganeshna has joined #openstack-lbaas | 08:13 | |
*** enikanorov_ has quit IRC | 09:06 | |
*** enikanorov has joined #openstack-lbaas | 09:06 | |
*** bharath has joined #openstack-lbaas | 09:20 | |
*** bharath has quit IRC | 09:25 | |
*** kiran-r is now known as kiran-r|afk | 09:46 | |
*** kiran-r|afk is now known as kiran-r | 09:46 | |
*** ganeshna has quit IRC | 10:21 | |
*** ganeshna has joined #openstack-lbaas | 10:26 | |
*** kbyrne has joined #openstack-lbaas | 11:03 | |
*** ganeshna has quit IRC | 11:11 | |
*** openstackgerrit has quit IRC | 11:13 | |
*** openstackgerrit has joined #openstack-lbaas | 11:14 | |
*** ganeshna has joined #openstack-lbaas | 12:08 | |
*** ganeshna has quit IRC | 12:13 | |
*** ajmiller has quit IRC | 12:31 | |
*** fnaval has joined #openstack-lbaas | 12:32 | |
*** ganeshna has joined #openstack-lbaas | 12:36 | |
*** ganeshna_ has joined #openstack-lbaas | 12:39 | |
*** ganeshna has quit IRC | 12:41 | |
*** ganeshna_ has quit IRC | 12:46 | |
*** amotoki has quit IRC | 12:50 | |
*** woodster_ has joined #openstack-lbaas | 12:51 | |
SteF | Hi guys . If I delete a pool, are the members which was attached to this pool deleted automatically? tnx in advance | 12:59 |
*** ganeshna has joined #openstack-lbaas | 13:05 | |
*** ganeshna has quit IRC | 13:12 | |
*** fnaval has quit IRC | 13:58 | |
*** fnaval has joined #openstack-lbaas | 14:11 | |
*** localloop127 has joined #openstack-lbaas | 14:18 | |
*** nmagnezi has quit IRC | 14:33 | |
*** Aish has joined #openstack-lbaas | 14:36 | |
*** kiran-r has quit IRC | 14:44 | |
*** localloo1 has joined #openstack-lbaas | 14:53 | |
*** mlavalle has joined #openstack-lbaas | 14:55 | |
*** localloop127 has quit IRC | 14:56 | |
*** apuimedo has quit IRC | 15:01 | |
*** jschwarz__ has joined #openstack-lbaas | 15:05 | |
*** jorgem has joined #openstack-lbaas | 15:07 | |
*** jschwarz_ has quit IRC | 15:08 | |
*** TrevorV has joined #openstack-lbaas | 15:24 | |
*** numan has quit IRC | 15:30 | |
*** ajmiller has joined #openstack-lbaas | 15:33 | |
*** jorgem has quit IRC | 15:41 | |
*** localloo1 is now known as localloop127 | 15:41 | |
*** Aish has quit IRC | 15:46 | |
*** TrevorV has quit IRC | 15:47 | |
*** jorgem has joined #openstack-lbaas | 15:48 | |
*** jschwarz__ has quit IRC | 15:49 | |
*** TrevorV has joined #openstack-lbaas | 15:50 | |
*** jorgem has quit IRC | 15:52 | |
*** jschwarz__ has joined #openstack-lbaas | 15:59 | |
*** localloop127 has quit IRC | 16:02 | |
*** localloop127 has joined #openstack-lbaas | 16:04 | |
*** KunalGandhi has joined #openstack-lbaas | 16:07 | |
TrevorV | johnsom, you around yet today? | 16:08 |
*** kiran-r has joined #openstack-lbaas | 16:10 | |
johnsom | Yep | 16:12 |
*** SteF has quit IRC | 16:12 | |
TrevorV | Sorry, was sidetracked. I agree with everything using constants on the flows, but I don't think my bug-fix is the right place to put that change. | 16:13 |
TrevorV | Woah... | 16:13 |
TrevorV | Sorry, had a glitch with my hexchat. | 16:13 |
*** Aish has joined #openstack-lbaas | 16:13 | |
johnsom | Ok, I just saw that you changed the listener flow to constants, but not the controller worker and test | 16:15 |
TrevorV | johnsom, I only changed what I touched, if I recall correctly. However, I can do another change review that will clean up all of them, because the inconsistency is something I have noted on my paper right over here ha ha | 16:19 |
*** nmagnezi has joined #openstack-lbaas | 16:20 | |
johnsom | Yeah, I had a discussion with blogan about incremental updates vs. a patch that goes through and updates them all. | 16:20 |
johnsom | I looks like you added a 'load_balancer' store in the controller worker. That is what I was commenting on switching over to constants while you are there | 16:21 |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Tempest tests for Members using testscenarios. https://review.openstack.org/180436 | 16:22 |
*** kiran-r has quit IRC | 16:22 | |
*** ebagdasa has quit IRC | 16:25 | |
*** anand1712 has joined #openstack-lbaas | 16:30 | |
*** anand1712 has quit IRC | 16:35 | |
*** ebagdasa has joined #openstack-lbaas | 16:37 | |
*** anand1712 has joined #openstack-lbaas | 16:38 | |
anand1712 | hi | 16:42 |
*** anand1712 has quit IRC | 16:46 | |
johnsom | Hi anand1712 | 16:52 |
*** ganeshna has joined #openstack-lbaas | 16:57 | |
*** ganeshna has quit IRC | 17:02 | |
*** madhu_ak has joined #openstack-lbaas | 17:05 | |
*** Youcef has joined #openstack-lbaas | 17:07 | |
*** mlavalle has quit IRC | 17:12 | |
*** jschwarz__ has quit IRC | 17:20 | |
*** localloo1 has joined #openstack-lbaas | 17:29 | |
*** localloop127 has quit IRC | 17:31 | |
*** bharath has joined #openstack-lbaas | 17:55 | |
*** SumitNaiksatam has joined #openstack-lbaas | 17:57 | |
*** mlavalle has joined #openstack-lbaas | 18:01 | |
TrevorV | Oh okay johnsom I didn't really take notice there, about the stores. Good call. I'll look into it. However I would only change what I've worked on in that specific bug fix. | 18:07 |
johnsom | TrevorV Yep, agreed | 18:10 |
TrevorV | Cool johnsom. I'm about to work on the pool deletion bug, and then I might have some bandwidth to go through and update all of those to a consistent state. | 18:13 |
johnsom | Ok, yeah, one of us will get to it. There is a bug, so if you start, mark it as assigned to you so Brandon or I don't work on it at the same time | 18:14 |
TrevorV | I've already done that johnsom :) | 18:15 |
johnsom | Cool | 18:17 |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Tempest tests for Listener using testscenarios. https://review.openstack.org/179818 | 18:41 |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete pool flow https://review.openstack.org/190780 | 19:35 |
*** madhu_ak has quit IRC | 19:44 | |
*** madhu_ak has joined #openstack-lbaas | 19:53 | |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete pool flow https://review.openstack.org/190780 | 19:59 |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete listener flow https://review.openstack.org/190269 | 20:09 |
TrevorV | johnsom, I updated for the constants on listener flow, and after I write more unit tests for the load balancer review, I'll make an all new review making ALL the flows in constants. | 20:10 |
johnsom | Yep, cool, already +2'd listeners | 20:10 |
TrevorV | Nice | 20:10 |
johnsom | pool I need to read through again, but looking | 20:11 |
TrevorV | Sure thing. I might not have it ALL as constants, but I can do that if we really want, outside of the major review to change it. | 20:11 |
johnsom | Np | 20:12 |
dougwig | xgerman: how goes use case collecting for fwaas? | 20:15 |
johnsom | TrevorV You lost me on the pool delete update. If you don't delete the pool from the model won't the listerupdate task just push the same config down including the pool? | 20:17 |
openstackgerrit | Merged stackforge/octavia: Updated from global requirements https://review.openstack.org/190414 | 20:18 |
*** nmagnezi has quit IRC | 20:20 | |
TrevorV | johnsom, are you asking about the config for haproxy? | 20:21 |
johnsom | Yeah, this change: https://review.openstack.org/#/c/190780/2/octavia/controller/worker/flows/pool_flows.py | 20:21 |
TrevorV | To be perfectly honest johnsom blogan suggested I remove that. That's not an excuse though, so give me a minute to think about it, yeah? | 20:23 |
blogan | johnsom is right, you'll have to remove that from the pool list | 20:23 |
johnsom | Ok, sure. | 20:23 |
blogan | TrevorV: the model.delete method didn't exist, it just needs to set listener.default_pool to None | 20:24 |
johnsom | Hmm, I thought it did exist in the base class, but maybe not | 20:25 |
blogan | no but those types of methods might be good to add just so its more readable | 20:25 |
xgerman | dougwig - slow | 20:36 |
xgerman | we haven’t heard back from Intel :-( | 20:36 |
xgerman | on the positive IBM offered to help with the redesign | 20:37 |
johnsom | TrevorV I -1'd just to track it. Otherwise it looks good. | 20:37 |
*** Youcef has quit IRC | 20:41 | |
*** Youcef has joined #openstack-lbaas | 20:41 | |
TrevorV | johnsom, I'm about to push a change. | 20:50 |
johnsom | Cool | 20:52 |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete pool flow https://review.openstack.org/190780 | 20:52 |
blogan | johnsom: implemented that object.delete method :) | 20:54 |
johnsom | I see that. Cool | 20:54 |
*** Youcef has quit IRC | 21:02 | |
TrevorV | johnsom, blogan and I were just looking at something interesting in the listener creation steps. | 21:04 |
TrevorV | If you've created a listener say, with protocol HTTP and port 80, and you delete it, you cannot add a listener with those same 2 fields to the load balancer because of DB constraints. | 21:05 |
TrevorV | So I was about to update the flows to actually delete the listener from the DB to avoid that, but that comes with the problem of debug tracking since we won't know what the listener id was after removing it. | 21:05 |
TrevorV | What are your thoughts? Delete from DB is okay? Or change something different alongside the provisioning status, like, removing the port or something. | 21:06 |
TrevorV | ? | 21:06 |
TrevorV | I meant listener deletion steps... well it involves both. | 21:07 |
TrevorV | ha | 21:07 |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete listener flow https://review.openstack.org/190269 | 21:17 |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete pool flow https://review.openstack.org/190780 | 21:26 |
johnsom | I am good with deleting it | 21:26 |
johnsom | I wondered about that on the first pass, but I think deleting is ok | 21:27 |
*** apuimedo has joined #openstack-lbaas | 21:29 | |
blogan | johnsom, TrevorV: i think deleting for now is good and if we need that historical debugging capability we solve it then | 21:29 |
johnsom | That is what the log is for... grin | 21:30 |
*** TrevorV has quit IRC | 21:35 | |
*** TrevorV has joined #openstack-lbaas | 21:37 | |
*** localloo1 has quit IRC | 21:51 | |
*** bharath has quit IRC | 21:59 | |
*** bharath has joined #openstack-lbaas | 21:59 | |
*** apuimedo has quit IRC | 22:04 | |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete listener flow https://review.openstack.org/190269 | 22:05 |
TrevorV | johnsom, added a test. Hope I didn't miss anything ha ha | 22:05 |
madhu_ak | blogan: just a question, if I want to run scenario tests after making changes with imports (for example, fnaval's patch: https://review.openstack.org/#/c/158904/), how to run that test? my understanding is, only apiv2 tests are being run | 22:06 |
johnsom | Grin, sorry to be a stikler | 22:06 |
blogan | madhu_ak: you mean run that test locally? | 22:07 |
blogan | madhu_ak: or run just that single test? | 22:07 |
madhu_ak | exactly | 22:07 |
madhu_ak | that test locally.. | 22:07 |
blogan | tox -e apiv2 | 22:08 |
blogan | that doesn't work? | 22:08 |
blogan | you can get it even more narrow and provide the dotted path to the test module | 22:08 |
madhu_ak | yeah, but that file is in scenario folder, I dont see that will run | 22:08 |
blogan | oh scenario tests! i read that as testscenarios sorry | 22:08 |
madhu_ak | :) | 22:08 |
blogan | doesn't look like tox has a listing for scenario | 22:10 |
blogan | so you'd have to create one :) | 22:11 |
madhu_ak | sure, not a problem | 22:11 |
madhu_ak | will research on it and propose it | 22:11 |
blogan | madhu_ak: look at tox.ini | 22:12 |
madhu_ak | also, if I need dependencies, can I just bring the relevant files into tempest tree? | 22:12 |
madhu_ak | sure | 22:12 |
madhu_ak | I mean, tempest_lib tree | 22:12 |
*** mlavalle has quit IRC | 22:18 | |
blogan | yes but make sure they don't break other tests | 22:25 |
madhu_ak | sure | 22:26 |
blogan | its quite possible you may need updated version of sonething already in tempest/lib | 22:26 |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete loadbalancer flow https://review.openstack.org/187237 | 22:38 |
*** TrevorV has quit IRC | 22:39 | |
openstackgerrit | min wang proposed openstack/neutron-lbaas: Admin_state_up tempest test for health monitor https://review.openstack.org/178827 | 23:15 |
*** chlong has joined #openstack-lbaas | 23:35 | |
openstackgerrit | min wang proposed openstack/neutron-lbaas: Introduced tempest API tests for openstack/neutron-lbaas https://review.openstack.org/168439 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!