| *** hitalia has quit IRC | 00:18 | |
| madhu_ak | xgerman, dougwig: for flavor-framework patch, not sure why there is failure in jenkins, but when I run tox -epy27 in my setup, the tests related to flavor-framework is passing... | 00:28 |
|---|---|---|
| madhu_ak | s/is passing/are passing | 00:28 |
| *** mixos has joined #openstack-lbaas | 00:53 | |
| *** bharath has quit IRC | 00:53 | |
| *** mixos has left #openstack-lbaas | 00:54 | |
| *** SumitNaiksatam has quit IRC | 01:18 | |
| madhu_ak | dougwig, enikanorov_ : sorry guys for spamming your inbox about the CI results related to flavor-framework jenkins failures.. The reason, the failure is not detecting in my local setup, all I am able to see the failures in jenkins..but the errors reported are correct..not sure why the errors didn't pop-up in my setup. Please bear with my patches.. | 01:54 |
| *** kiran-r has joined #openstack-lbaas | 01:55 | |
| *** kongfy has left #openstack-lbaas | 01:58 | |
| *** kongfy has joined #openstack-lbaas | 02:02 | |
| madhu_ak | dougwig, enikanorov_: okay, am able to see that jenkins - unit tests is finally happy with last patch :) hurray! | 02:02 |
| *** kiran-r has quit IRC | 02:17 | |
| *** kiran-r has joined #openstack-lbaas | 02:31 | |
| *** SumitNaiksatam has joined #openstack-lbaas | 02:35 | |
| madhu_ak | xgerman, dougwig: https://review.openstack.org/#/c/139758 | 02:39 |
| *** madhu_ak has quit IRC | 02:46 | |
| *** SumitNaiksatam has quit IRC | 03:08 | |
| *** SumitNaiksatam has joined #openstack-lbaas | 03:09 | |
| *** madhu_ak has joined #openstack-lbaas | 03:16 | |
| *** kiran-r has quit IRC | 03:18 | |
| *** jhova has quit IRC | 03:48 | |
| *** bharath has joined #openstack-lbaas | 03:54 | |
| *** bharath has quit IRC | 03:58 | |
| *** vivek-ebay has joined #openstack-lbaas | 04:07 | |
| *** amotoki_ has joined #openstack-lbaas | 04:35 | |
| *** madhu_ak has quit IRC | 04:50 | |
| *** mixos has joined #openstack-lbaas | 04:55 | |
| *** kiran-r has joined #openstack-lbaas | 05:00 | |
| *** vivek-eb_ has joined #openstack-lbaas | 05:52 | |
| *** vivek-ebay has quit IRC | 05:56 | |
| *** vivek-eb_ has quit IRC | 05:57 | |
| *** SumitNaiksatam has quit IRC | 06:19 | |
| *** SumitNaiksatam has joined #openstack-lbaas | 06:20 | |
| *** nmagnezi has joined #openstack-lbaas | 06:48 | |
| *** Tiancheng has joined #openstack-lbaas | 07:06 | |
| *** jschwarz has joined #openstack-lbaas | 07:10 | |
| *** [1]evgenyf has joined #openstack-lbaas | 07:16 | |
| *** jschwarz_ has joined #openstack-lbaas | 07:21 | |
| *** jschwarz has quit IRC | 07:22 | |
| *** chlong has quit IRC | 07:45 | |
| *** mixos has quit IRC | 08:13 | |
| *** bharath has joined #openstack-lbaas | 08:13 | |
| *** nmagnezi has quit IRC | 08:14 | |
| *** apuimedo|away has joined #openstack-lbaas | 08:22 | |
| *** nmagnezi has joined #openstack-lbaas | 08:27 | |
| *** jschwarz_ has quit IRC | 08:51 | |
| *** amotoki_ has quit IRC | 09:14 | |
| *** amotoki_ has joined #openstack-lbaas | 09:23 | |
| *** amotoki_ has quit IRC | 09:39 | |
| *** vivek-ebay has joined #openstack-lbaas | 09:55 | |
| *** vivek-ebay has quit IRC | 10:00 | |
| *** mmdurrant has quit IRC | 10:09 | |
| *** Tiancheng has quit IRC | 10:57 | |
| openstackgerrit | venkata anil proposed openstack/neutron-lbaas: lbaas fails when adding gw and arping for IPv6 vip addr https://review.openstack.org/185931 | 10:59 |
| *** jhova has joined #openstack-lbaas | 11:12 | |
| *** openstack has joined #openstack-lbaas | 11:37 | |
| *** apuimedo|away has joined #openstack-lbaas | 11:38 | |
| *** mmdurrant has joined #openstack-lbaas | 11:59 | |
| *** amotoki_ has joined #openstack-lbaas | 12:19 | |
| openstackgerrit | venkata anil proposed openstack/neutron-lbaas: lbaas fails when adding gw and arping for IPv6 vip addr https://review.openstack.org/185931 | 12:38 |
| *** [2]evgenyf has joined #openstack-lbaas | 12:54 | |
| *** [1]evgenyf has quit IRC | 12:56 | |
| *** bharath has quit IRC | 13:15 | |
| *** apuimedo|away is now known as apuimedo | 13:44 | |
| *** Tiancheng has joined #openstack-lbaas | 13:46 | |
| *** amotoki_ has quit IRC | 13:54 | |
| *** mixos has joined #openstack-lbaas | 14:04 | |
| *** chlong has joined #openstack-lbaas | 14:04 | |
| *** mixos has quit IRC | 14:13 | |
| *** bharath has joined #openstack-lbaas | 14:15 | |
| *** bharath has quit IRC | 14:20 | |
| *** kiran-r has quit IRC | 14:25 | |
| *** kiran-r has joined #openstack-lbaas | 14:25 | |
| *** Tiancheng has quit IRC | 14:31 | |
| *** kiran-r has quit IRC | 14:32 | |
| *** mestery has quit IRC | 14:33 | |
| *** mestery has joined #openstack-lbaas | 14:34 | |
| *** amotoki_ has joined #openstack-lbaas | 14:55 | |
| *** amotoki_ has quit IRC | 15:00 | |
| *** apuimedo has quit IRC | 15:06 | |
| *** jorgem has joined #openstack-lbaas | 15:08 | |
| *** [2]evgenyf has quit IRC | 15:11 | |
| *** rbrooker_ has joined #openstack-lbaas | 15:25 | |
| *** mixos has joined #openstack-lbaas | 15:32 | |
| *** TrevorV has joined #openstack-lbaas | 15:34 | |
| *** TrevorV has quit IRC | 15:36 | |
| *** vivek-ebay has joined #openstack-lbaas | 15:36 | |
| *** nmagnezi has quit IRC | 15:40 | |
| *** mlavalle has joined #openstack-lbaas | 15:42 | |
| *** vivek-ebay has quit IRC | 15:44 | |
| *** mlavalle has quit IRC | 15:44 | |
| *** mlavalle has joined #openstack-lbaas | 15:44 | |
| *** mlavalle has quit IRC | 15:45 | |
| *** mlavalle has joined #openstack-lbaas | 15:47 | |
| *** bharath has joined #openstack-lbaas | 15:47 | |
| *** bharath has quit IRC | 15:52 | |
| *** barra204 has quit IRC | 15:54 | |
| *** amotoki_ has joined #openstack-lbaas | 15:56 | |
| xgerman | blogan: Updated the agenda with links to our talks and a link to 3rd party CI running Sonar — | 16:00 |
| *** amotoki_ has quit IRC | 16:01 | |
| dougwig | xgerman: do you want that sonar job to report in gerrit? | 16:09 |
| *** madhu_ak has joined #openstack-lbaas | 16:10 | |
| xgerman | I would be happy with 3rd party CI | 16:10 |
| blogan | voting or non-voting? | 16:11 |
| xgerman | either one would be fine | 16:11 |
| xgerman | but we can decide as a group on that | 16:11 |
| blogan | well i'm conflicted on it being voting or non voting | 16:12 |
| xgerman | well, I lean towards voting but I don’t feel like forcing people to obey machines | 16:13 |
| blogan | well we already obey pep8/flake8 | 16:14 |
| blogan | as a counter argument | 16:14 |
| blogan | my conflict is enforcing rules that are more or less subjective and adding that extra overhead for any new contributors for a still immature project | 16:15 |
| blogan | vs we alrady do this for pep8/flake8 | 16:16 |
| xgerman | yeah, we can put that up for a vote in the meeting | 16:17 |
| xgerman | I am happy either way -- | 16:17 |
| *** rbrooker_ has quit IRC | 16:17 | |
| blogan | you'd be happy if we didn't have any job eh? | 16:17 |
| xgerman | no, I like to have the job (and I already have it internally) and I think what Sonar reports is useful | 16:18 |
| xgerman | but as soon as we make it voting we need some sort of process to change the Sonar if we need it more lenient/strict | 16:20 |
| xgerman | so maybe start with non-voting and revisit after a while | 16:21 |
| xgerman | ? | 16:21 |
| blogan | non-voting and it just fails all the time and becomes noise | 16:24 |
| blogan | a la a10-lbaasv2 | 16:24 |
| xgerman | mmh, I haven’t thought about it that way | 16:24 |
| blogan | but, i think as a trial run its good to have it non-voting | 16:24 |
| blogan | and it'll let us know if we hate the extra overhead | 16:25 |
| xgerman | yeah, it will be vocal ;-) | 16:25 |
| xgerman | I am hoping I can get the parameters from our internal one so we can tune it down | 16:26 |
| blogan | teh reason i wanted it as a tox environment/job was beacuse i could run it locally and quickly fix any issues, now i have to push it up and wait for all jobs to see | 16:26 |
| xgerman | it can run locally even inside pycharm somehow | 16:26 |
| blogan | oh no you talkin crazy | 16:29 |
| blogan | but can it run locally with tox -e sonar? | 16:33 |
| xgerman | I think Sonar is Java so there is that… but there probably is a way to call machine from tox | 16:37 |
| xgerman | maven | 16:37 |
| *** mixos has quit IRC | 16:39 | |
| blogan | oh good point | 16:39 |
| blogan | ugh maven | 16:39 |
| blogan | i dont want that on my machine :) | 16:39 |
| xgerman | yep | 16:40 |
| *** mixos has joined #openstack-lbaas | 16:41 | |
| *** vivek-ebay has joined #openstack-lbaas | 16:41 | |
| *** jorgem has quit IRC | 16:45 | |
| madhu_ak | dougwig: hi doug. As the unit tests are passing for flavor-framework (https://review.openstack.org/#/c/139758) after rebasing it to the neutron master, I am gathering th relevant information to implement tempest tests.. | 16:45 |
| xgerman | dougwig: do you want them in the tempest tree or the neutron tree - and if neutron where would they go? | 16:46 |
| openstackgerrit | Sungjin Yook proposed openstack/neutron-lbaas: Add a new lbaas agent Scheduler, LeastPoolAgentScheduler https://review.openstack.org/181609 | 16:46 |
| madhu_ak | yeah, about to ask the same question as xgerman pointed.. +1 | 16:46 |
| dougwig | xgerman, madhu_ak: in tree, talk to marun | 16:51 |
| madhu_ak | dougwig: sure | 16:52 |
| xgerman | cool | 16:53 |
| *** sbalukoff has quit IRC | 16:56 | |
| *** amotoki_ has joined #openstack-lbaas | 16:57 | |
| dougwig | hey, stop making fun of my CI. it's broken all of the time because of broken tests. :) | 16:57 |
| dougwig | that the ref impl is lax and busted is not my fault. | 16:57 |
| *** mwang2 has joined #openstack-lbaas | 16:59 | |
| mixos | I watched summit video. | 16:59 |
| mixos | was cool. | 16:59 |
| mixos | great job all of you . :- ) | 16:59 |
| *** amotoki_ has quit IRC | 17:01 | |
| johnsom | Thanks! | 17:04 |
| *** johnsom has quit IRC | 17:10 | |
| *** mwang2_ has joined #openstack-lbaas | 17:12 | |
| *** mwang2 has quit IRC | 17:15 | |
| *** SumitNaiksatam has quit IRC | 17:18 | |
| *** bharath has joined #openstack-lbaas | 17:24 | |
| *** madhu_ak has quit IRC | 17:42 | |
| *** SumitNaiksatam has joined #openstack-lbaas | 17:44 | |
| *** madhu_ak has joined #openstack-lbaas | 17:44 | |
| *** chlong has quit IRC | 17:53 | |
| *** hitalia has joined #openstack-lbaas | 17:56 | |
| *** jorgem has joined #openstack-lbaas | 18:02 | |
| *** jorgem has quit IRC | 18:20 | |
| *** sbalukoff has joined #openstack-lbaas | 18:42 | |
| *** amotoki_ has joined #openstack-lbaas | 18:46 | |
| *** amotoki_ has quit IRC | 18:51 | |
| mixos | Hi all. a question. | 18:53 |
| mixos | :- ) | 18:53 |
| mixos | very dumb one. | 18:53 |
| mixos | https://review.openstack.org/#/c/181609/ | 18:53 |
| blogan | hi mixos, no such thing as dumb questions, just dumb answers | 18:54 |
| mixos | for lbaas scheduler patch drop. | 18:54 |
| mixos | blogan. I will surprise you. LOL | 18:54 |
| mixos | I got this comment. | 18:54 |
| mixos | This needs unit tests. | 18:54 |
| mixos | but.. I see that there's already test case... | 18:55 |
| mixos | ./neutron_lbaas/tests/unit/test_agent_scheduler.py: | 18:55 |
| mixos | I am wondering what | 18:56 |
| blogan | mixos: you should have tests for the LeastPoolAgentScheduler class and _schedule method | 18:56 |
| mixos | 's my next step here. | 18:56 |
| mixos | ok. | 18:57 |
| mixos | I really want to write one. | 18:57 |
| blogan | mixos: really the unit tests in the lbaas code are not unit tests, and we should make an effort one day to actually clean those up because theya re quit confusing | 18:57 |
| *** nmagnezi has joined #openstack-lbaas | 18:58 | |
| mixos | is there any reference code that I can look and how to execute this unit tests ? I tested on production env. for 4 days with 500 concurrent users. | 18:58 |
| mixos | this would be fun to do. once I have ref code. | 18:58 |
| mixos | I would appreciate if you could give me a pointer .. :- ) | 18:59 |
| mixos | ChanceScheduler was there before my chance... I tried to look up test cases for that.. but failed to find a test case for ChanceScheduler. | 19:00 |
| mixos | chance ==> change | 19:00 |
| blogan | mixos: so it would be in that same module, those tests use the Chancescheduler because that is the default option | 19:00 |
| mixos | let me look again. | 19:01 |
| blogan | mixos: if you override the config value for scheduler to point to your new scheduler then you can write tests for that | 19:01 |
| blogan | mixos: look at line 105, you could do the same thing for the scheduler config | 19:02 |
| blogan | https://github.com/openstack/neutron-lbaas/blob/master/etc/neutron_lbaas.conf#L3-L4 | 19:03 |
| blogan | those would be values you would override, whichever version of lbaas you're using | 19:03 |
| blogan | L3 for V1, L4 for V2 | 19:03 |
| blogan | which I'm sure you already know this if you've deployed it in a production environment | 19:03 |
| *** johnsom has joined #openstack-lbaas | 19:04 | |
| blogan | johnsom: ever get a chacne to try to reproduce those delete errors I was getting? | 19:04 |
| mixos | yes. I modified neutron.conf to test it out. Thanks blogan I will take a look and come back with more dumb questions. :- ) | 19:05 |
| blogan | mixos: the only dumb question is the one not asked :) | 19:05 |
| mixos | :- ) thanks | 19:05 |
| blogan | mixos: always great to get more ppl involved | 19:05 |
| mixos | mixos: look at line 105, you could do the same thing for the scheduler config ==> blogan. which file are you referring to when you mention line 105 ? | 19:13 |
| mixos | nvm. found it. | 19:14 |
| mixos | :- ) | 19:14 |
| mixos | There are two files with same name. the code is slightly different. what's the difference ? | 19:17 |
| mixos | ./neutron_lbaas/tests/unit/services/loadbalancer/test_agent_scheduler.py | 19:17 |
| mixos | ./neutron_lbaas/tests/unit/test_agent_scheduler.py | 19:17 |
| mixos | one outdated and the other one is current (later one) ? | 19:17 |
| *** sballe has joined #openstack-lbaas | 19:56 | |
| blogan | mixos: one is for v1, the other for v2 | 19:58 |
| blogan | v1 is the /services/loadbalancer namespace | 19:58 |
| blogan | mixos: v1 will eventually be removed and it didn't make sense to keep the services/loadbalancer path | 19:58 |
| mixos | I see. | 19:59 |
| mixos | Just one last .. (promise) . | 19:59 |
| *** Aish has joined #openstack-lbaas | 19:59 | |
| mixos | so. I have looked the the file test_agent...py. | 19:59 |
| *** mestery_ has joined #openstack-lbaas | 20:00 | |
| mixos | who/ how these test cases being called ? | 20:00 |
| mixos | eventually I think I need to modify two more files.. one is this unit test (extending it for new scheduler). | 20:01 |
| *** ajmiller_ is now known as ajmiller | 20:01 | |
| mixos | two ... putting sample on neutron_lbaas.conf file to show an example of new scheduler. | 20:01 |
| trevhole | ignore-me | 20:02 |
| *** trevhole is now known as TrevorV | 20:03 | |
| TrevorV | ignore-me | 20:03 |
| *** mestery has quit IRC | 20:03 | |
| *** nmagnezi has quit IRC | 20:04 | |
| *** amotoki_ has joined #openstack-lbaas | 20:34 | |
| *** barra204 has joined #openstack-lbaas | 20:35 | |
| *** amotoki_ has quit IRC | 20:39 | |
| *** vivek-ebay has quit IRC | 20:41 | |
| *** barra204 has quit IRC | 20:50 | |
| openstackgerrit | Doug Wiegley proposed openstack/neutron-lbaas: WIP - try running v2 tests without tox https://review.openstack.org/182757 | 20:53 |
| *** mestery_ is now known as mestery | 21:12 | |
| *** vivek-ebay has joined #openstack-lbaas | 21:54 | |
| blogan | mixos: you can call them through tox -epy27, you can also run them through python's normal unittest mechanism | 22:00 |
| blogan | mixos: tox can ran individual tests as well | 22:00 |
| mixos | blogan: I managed to install tox. so. at least that's ready. | 22:01 |
| mixos | blogan: tox -epy27 <path to py file > ? | 22:02 |
| blogan | mixos: yeah and then you can provide class name and method name | 22:03 |
| mixos | great. !! Thank you blogain. I understand that this one is for v1. Would it be ok to drop v2 change in separate drop ? | 22:04 |
| mixos | or v2 changes all together ? | 22:04 |
| mixos | blogain --> blogan | 22:04 |
| blogan | mixos: i'd put it all in the same review | 22:05 |
| blogan | mixos: do you plan on using v2? | 22:05 |
| *** amotoki_ has joined #openstack-lbaas | 22:05 | |
| mixos | blogan: for the time being using v1 in my env. but... as you said v1 might be deleted soon. ? | 22:06 |
| mixos | blogan: in v2, lbaas agent is still tied to pool (load balabcer). correct ? | 22:06 |
| mixos | blogan: I see that chanceScheduler is being used for v2, so. no reason why LeastPoolAgent would not work... although name might not be quite right. | 22:07 |
| blogan | mixos: not soon, at the earliest 2 cycles after Liberty | 22:08 |
| mixos | blogan: may need to change the name to LeastLBAgent something.. | 22:08 |
| blogan | lbaas agent is tied to load balancer in v2 | 22:08 |
| *** amotoki_ has quit IRC | 22:10 | |
| mixos | blogan: yep summit video was quite clear to explain that relationship between listener and LB . | 22:10 |
| mixos | After reading unit test code.. it would be simple as inherit the LBaaSAgentSchedulerTestCase and overriding serUp() method... for unit test for LeastPoolAgentScheduler. (LeastLBAgentScheduler for v2). | 22:13 |
| mixos | while overriding SetUp(), just supply additional scheduler value to set new scheduler for test. | 22:14 |
| mixos | blogan: Am I on right path ? | 22:14 |
| blogan | mixos: yeah that willw ork but then it will re-run all of those same tests | 22:19 |
| mixos | blogan: new scheduler needs to be tested for all same tests that was done for ChanceSched... is what I thought. | 22:20 |
| mixos | blogan: any suggestion ? | 22:21 |
| blogan | ah i was thinking all of those weren't testing the scheduler, but they are, looked for a second they were testing agent functionality | 22:22 |
| *** vivek-ebay has quit IRC | 22:30 | |
| *** vivek-ebay has joined #openstack-lbaas | 22:30 | |
| mixos | blogan: then it's ok to inherit and supply additional scheduler value in cfg.CONF.set_override to test all. | 22:32 |
| blogan | mixos: yeah i think that'll be fine | 22:32 |
| mixos | and then see what others think at review time ? | 22:32 |
| blogan | mixos: yeah | 22:32 |
| mixos | blogan: Thank you ! : for your time. was very helpful ! | 22:33 |
| blogan | mixos: np anytime | 22:33 |
| openstackgerrit | Michael Durrant proposed openstack/neutron-lbaas: Fixed references to old logging library to make tests pass Change-Id: I54e99e810d9e22336cc292abd53ed9be14159946 https://review.openstack.org/186203 | 22:39 |
| *** mlavalle has quit IRC | 22:51 | |
| *** Aish has left #openstack-lbaas | 22:57 | |
| *** chlong has joined #openstack-lbaas | 23:05 | |
| openstackgerrit | Doug Wiegley proposed openstack/neutron-lbaas: Pull subset of tempest in-tree, during tempest-lib migration https://review.openstack.org/186219 | 23:12 |
| openstackgerrit | Doug Wiegley proposed openstack/neutron-lbaas: Pull lbaasv1 tempest tests in-tree, and run v1/v2 tests directly https://review.openstack.org/186219 | 23:15 |
| openstackgerrit | Doug Wiegley proposed openstack/neutron-lbaas: Pull subset of tempest in-tree, during tempest-lib migration https://review.openstack.org/186219 | 23:26 |
| openstackgerrit | Doug Wiegley proposed openstack/neutron-lbaas: Pull lbaasv1 tempest tests in-tree, and run v1/v2 tests directly https://review.openstack.org/186219 | 23:29 |
| *** hitalia has quit IRC | 23:40 | |
| openstackgerrit | Doug Wiegley proposed openstack/neutron-lbaas: Pull lbaasv1 tempest tests in-tree, and run v1/v2 tests directly https://review.openstack.org/186219 | 23:40 |
| johnsom | Jenkins/gerrit is not your friend is it Doug.... | 23:42 |
| *** ajmiller has quit IRC | 23:42 | |
| *** amotoki_ has joined #openstack-lbaas | 23:51 | |
| *** amotoki_ has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!