*** fnaval has quit IRC | 00:01 | |
*** xgerman has joined #openstack-lbaas | 00:01 | |
*** vivek-ebay has quit IRC | 00:02 | |
*** xgerman has quit IRC | 00:09 | |
*** mlavalle has quit IRC | 01:13 | |
*** mestery_ has joined #openstack-lbaas | 01:31 | |
*** mestery has quit IRC | 01:33 | |
*** mestery_ has quit IRC | 01:34 | |
*** mestery has joined #openstack-lbaas | 01:35 | |
*** sbfox has joined #openstack-lbaas | 01:35 | |
*** sbalukoff has quit IRC | 01:41 | |
*** vivek-ebay has joined #openstack-lbaas | 01:43 | |
*** mlavalle has joined #openstack-lbaas | 02:01 | |
*** fnaval has joined #openstack-lbaas | 02:07 | |
*** sbfox has quit IRC | 02:15 | |
*** vivek-ebay has quit IRC | 02:16 | |
*** mestery_ has joined #openstack-lbaas | 02:26 | |
*** mestery has quit IRC | 02:26 | |
*** mestery_ is now known as mestery | 02:27 | |
*** mlavalle has quit IRC | 02:30 | |
*** mlavalle has joined #openstack-lbaas | 02:32 | |
*** HenryG is now known as HenryG_afk | 03:08 | |
*** woodster__ has quit IRC | 03:35 | |
*** vivek-ebay has joined #openstack-lbaas | 03:50 | |
blogan | oye | 03:52 |
---|---|---|
blogan | anyone on? | 03:52 |
*** vivek-eb_ has joined #openstack-lbaas | 04:03 | |
*** vivek-ebay has quit IRC | 04:06 | |
*** fnaval has quit IRC | 04:28 | |
*** vivek-eb_ has quit IRC | 04:49 | |
*** johnw has quit IRC | 05:33 | |
dougwig | Here | 05:34 |
blogan | hey | 05:45 |
blogan | so i had a feeling passing the sqlalchemy models was goign to bite us in the ass | 05:45 |
dougwig | uh oh | 05:58 |
dougwig | those are not helpful opening words. | 05:59 |
blogan | lol | 05:59 |
dougwig | /helpful/hopeful/ | 05:59 |
blogan | both | 05:59 |
dougwig | what's up? | 06:00 |
blogan | since sqlalchemy keeps the model isntances updated whenever any change happens, the we aren't able to actually get an original model state for updates | 06:01 |
dougwig | pass a dict for 'old'? or there is no clone method or somsuch/ | 06:02 |
dougwig | ? | 06:02 |
blogan | ive looked, there's an expunge method on the session that takes it out of the session so it doesn't get updated, but it destroys all the relationships as well | 06:04 |
dougwig | is it possible to get it, open a transaction, then get a new one for the update? the transaction should keep it look old. that's a totally random guess. | 06:04 |
blogan | that would require a new session, and i believe the plugin hast o use the one passed to it | 06:04 |
blogan | bc that first get will get updated on the new one being updated, if they both share the same session | 06:05 |
blogan | i was planning on making data models anyway, just not so soon but i believe thats what I will have to do | 06:05 |
blogan | already got them written up, just need to add the code to convert SA models to these popos | 06:06 |
dougwig | oy, so much for the code hardening a bit. :) | 06:06 |
blogan | well the first one won't chagne | 06:07 |
blogan | but yeah its a bit of a downer | 06:08 |
blogan | for the 2nd, huge commit which is the main one | 06:08 |
dougwig | the model classes themselves are just a bunch of @property's, with fan out for associations, right? (yeesh, that could get memory messy, not being lazy any longer.) | 06:10 |
blogan | i was going to have to do eager loading anyway | 06:13 |
blogan | but i may have found a solution to my problem with help from people ine #sqlalchemy | 06:14 |
dougwig | nice, then i'll stop reading the sqlalchemy docs. | 06:16 |
blogan | well i need to test it out first | 06:16 |
dougwig | you know, my driver is up to patchset 17. and i've made exactly one edit: adding a comment to a conf file. :) | 06:20 |
blogan | i think we have both learned some valuable lessons in this whole review process | 06:21 |
dougwig | i think there are more to come. :) | 06:25 |
blogan | damnit, it did fix some of it, but not all of it | 06:27 |
dougwig | if you have to go with new model classes for driver calls, you could limit the churn initially by just using them for the 'old' models, and keep using sqa everywhere else (which is 95% of the calls, and 99.99999% of the use cases.) | 06:30 |
blogan | im not sure if that will result in a big difference in churn, all the models would still have to exist and whenever I retrieved hte "old" model i'd have to convert that over and once that work is complete it really shouldn't be too much more effort for everything else | 06:32 |
dougwig | ok, i won't push on reviews until early next week, then, to give things time to settle down. | 06:34 |
blogan | yes time to settle down will be needed | 06:35 |
*** mlavalle has quit IRC | 06:43 | |
rm_work | blogan: >_> | 07:20 |
*** sbalukoff has joined #openstack-lbaas | 08:14 | |
*** HenryG_afk is now known as HenryG | 12:42 | |
*** woodster__ has joined #openstack-lbaas | 12:57 | |
*** fnaval has joined #openstack-lbaas | 13:04 | |
*** rolledback has joined #openstack-lbaas | 13:26 | |
*** fnaval has quit IRC | 13:36 | |
*** rolledback has quit IRC | 13:38 | |
*** markmcclain has joined #openstack-lbaas | 14:09 | |
*** markmcclain has quit IRC | 14:51 | |
*** TrevorV_ has joined #openstack-lbaas | 15:09 | |
*** rolledback has joined #openstack-lbaas | 15:18 | |
*** sbfox has joined #openstack-lbaas | 15:35 | |
*** sbfox1 has joined #openstack-lbaas | 15:38 | |
*** sbfox has quit IRC | 15:39 | |
*** fnaval has joined #openstack-lbaas | 15:42 | |
*** jorgem has joined #openstack-lbaas | 15:47 | |
*** TrevorV_ has quit IRC | 15:51 | |
*** fnaval has quit IRC | 16:05 | |
*** fnaval has joined #openstack-lbaas | 16:06 | |
dougwig | blogan: are the new models in yet? can we start beating on them? | 16:27 |
*** mlavalle has joined #openstack-lbaas | 16:30 | |
*** rolledba_ has joined #openstack-lbaas | 16:32 | |
*** rolledback has quit IRC | 16:32 | |
*** rolledba_ has quit IRC | 16:57 | |
*** fnaval has quit IRC | 16:57 | |
*** rolledback has joined #openstack-lbaas | 17:10 | |
*** crc32 has joined #openstack-lbaas | 17:13 | |
blogan | dougwig: no i gotta get some sleep sometime you robot! | 17:22 |
blogan | dougwig: ive also gotta research this quota thing too that oleg brought up | 17:22 |
*** rolledback has quit IRC | 17:25 | |
dougwig | you can sleep after juno-3. | 17:26 |
dougwig | :) | 17:26 |
dougwig | can someone else help with the quota thing? | 17:26 |
blogan | anyone is welcome to take a stab at it | 17:26 |
*** rolledback has joined #openstack-lbaas | 17:37 | |
*** rolledback has quit IRC | 17:41 | |
*** fnaval has joined #openstack-lbaas | 17:50 | |
blogan | alrigh tfigured the quota issue out | 17:55 |
blogan | one more change to the extension review | 17:59 |
* blogan crosses fingers | 17:59 | |
*** markmcclain has joined #openstack-lbaas | 18:06 | |
*** markmcclain1 has joined #openstack-lbaas | 18:09 | |
*** markmcclain has quit IRC | 18:10 | |
crc32 | Hey stephen have you heard anything about the "common module" being added where I can populate the X509 functionality code at? I haven't heard from evengy. | 18:12 |
crc32 | Hey sbalukoff have you heard anything about the "common module" being added where I can populate the X509 functionality code at? I haven't heard from evengy. | 18:12 |
sbalukoff | crc32: I have not heard anything specific about it, from Evgeny or otherwise. | 18:16 |
crc32 | Do you have a link to the draft your proposing for the paris summit? | 18:17 |
sbalukoff | crc32: Yes... hold on... | 18:18 |
crc32 | sbalukoff: So should I wait for evengy to respond or do you know of a place to place my code? | 18:20 |
sbalukoff | I think my team is planning on submitting this today: https://docs.google.com/document/d/1D6ffKps3ZF6L_-hw849c_UDXVshcwdaeKFBTrg0s5kA/edit?usp=sharing | 18:20 |
sbalukoff | crc32: To be honest, I don't really have a good idea. My suggestion would be to place it somewhere that you think makes sense given the structure of the code repository, but be open to moving it all elsewhere (hopefully) pretty early in the review cycle. | 18:21 |
sbalukoff | That is to say, I don't have a strong opinion on that, but I suspect others might. But let's not wait for them, eh. | 18:22 |
crc32 | yea thats why I'm hesitent to moving it just yet. | 18:23 |
crc32 | I'm pretty much coding it in a "place_this_some_where_module.py" kind of way | 18:24 |
sbalukoff | Makes sense to me. | 18:27 |
sbalukoff | Obviously, if you've got a strong opinion on it, you should feel free to argue for it, eh. :) | 18:27 |
sbalukoff | I would probably back you up. ;) | 18:27 |
blogan | crc32: i can tell you exactly where you should stick that | 18:27 |
TrevorV | Don't say anything about anyone's rear... you jerk face | 18:29 |
crc32 | you were saying blowgun? | 18:29 |
* crc32 slaps blogan around a bit with a large trout | 18:30 | |
* blogan eats that trout | 18:30 | |
crc32 | where do I push/shove/stick my code? | 18:31 |
crc32 | blogan: You know the code base fairly well whats your impression? | 18:32 |
blogan | about where to put the code that calls barbican to retrieve the blob? | 18:33 |
crc32 | no I was gonna let adam decide that. I'm talking more about the X509 mangler. | 18:33 |
blogan | well i would think those two should be in the relative same place | 18:34 |
crc32 | I'll be working with adam on the TLS lbaas/barbican cross talk but I'll let him make the religuous decisions. | 18:34 |
blogan | and i would think that we will probably not be the only advanced services that will want to talk to barbican and do the parsing/mangling | 18:35 |
crc32 | blogan: Are you suggesting dumping the code in oslo? | 18:35 |
blogan | oh no | 18:35 |
blogan | i was thinking in its own module in the services package, or somewhere else in neutron that they may have something similar | 18:36 |
blogan | there is the notifiers package, that nova has a module in | 18:38 |
blogan | i wouldn't exactly consider this only a notifier though | 18:38 |
blogan | but they are setting up the nova client with the urls, usernames and api keys | 18:38 |
blogan | yeah i kinda think the notifiers package would be best, though i'm not too crazy on the name | 18:39 |
blogan | you can bring that up on the neutron ML or in the next neutron meeting and ask people their opinions, in the meantime just put it in its own module somewhere so you can easily just move it around and test it out | 18:40 |
crc32 | speaking of names I was gonna put it in "x509KeyAndCertMangler.py". ;) | 18:40 |
blogan | you should make a class caleld that and put it in a barbican.py or tls.py module | 18:43 |
*** Youcef has quit IRC | 18:48 | |
dougwig | my vote would be neutron/services/common/mymodulewhateveritis.py | 18:55 |
dougwig | i also wouldn't stress the ML so much; people will yell if it's in the wrong place once it's in gerrit. if you pick a semi-reasonable place, it'll be fine. | 18:57 |
*** fnaval has quit IRC | 19:41 | |
*** sbfox1 has quit IRC | 20:39 | |
*** sbfox has joined #openstack-lbaas | 20:40 | |
*** TrevorV_ has joined #openstack-lbaas | 20:59 | |
*** TrevorV_ has left #openstack-lbaas | 21:00 | |
*** sbfox1 has joined #openstack-lbaas | 21:09 | |
*** sbfox has quit IRC | 21:12 | |
*** sbfox1 has quit IRC | 21:14 | |
*** sbfox has joined #openstack-lbaas | 21:15 | |
*** rolledback has joined #openstack-lbaas | 21:30 | |
*** rolledback has joined #openstack-lbaas | 21:36 | |
*** fnaval has joined #openstack-lbaas | 21:46 | |
*** rolledback has quit IRC | 21:50 | |
*** jorgem has quit IRC | 21:58 | |
*** sbfox has quit IRC | 22:05 | |
*** ptoohill_ has joined #openstack-lbaas | 22:20 | |
*** sbfox has joined #openstack-lbaas | 22:39 | |
*** mlavalle has quit IRC | 22:59 | |
*** ptoohill_ has quit IRC | 23:18 | |
*** fnaval has quit IRC | 23:47 | |
*** ptoohill_ has joined #openstack-lbaas | 23:48 | |
*** ptoohill_ has quit IRC | 23:49 | |
*** ptoohill_ has joined #openstack-lbaas | 23:49 | |
*** ptoohill_ has quit IRC | 23:50 | |
*** fnaval_ has joined #openstack-lbaas | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!