| sbalukoff | blogan: Is it worthwhile to review your patches that aren't presently passing CI? | 00:10 |
|---|---|---|
| ptoohill | sbalukoff, the revision is def still a WIP, think we are just trying to get feedback during this process so changes/fixes can happen sooner rather then later. If you checkout the parent review it is in a "working" state but we would like to hear any thoughts, opinions or ideas for the code if possible | 00:29 |
| sbalukoff | ptoohill: Sounds good. | 00:30 |
| *** vivek-ebay has quit IRC | 00:54 | |
| *** fnaval has joined #openstack-lbaas | 01:25 | |
| *** johnw has quit IRC | 01:27 | |
| *** enikanorov__ has quit IRC | 01:27 | |
| *** rohara has quit IRC | 01:27 | |
| *** zz_blogan has quit IRC | 01:27 | |
| *** Youcef has quit IRC | 01:27 | |
| *** TrevorV has quit IRC | 01:27 | |
| *** jkoelker has quit IRC | 01:27 | |
| *** fnaval has quit IRC | 01:27 | |
| *** openstackgerrit has quit IRC | 01:27 | |
| *** sbalukoff has quit IRC | 01:27 | |
| *** dougwig has quit IRC | 01:27 | |
| *** ptoohill has quit IRC | 01:27 | |
| *** VijayB has quit IRC | 01:27 | |
| *** redrobot has quit IRC | 01:27 | |
| *** enikanorov_ has quit IRC | 01:27 | |
| *** enikanorov__ has joined #openstack-lbaas | 01:30 | |
| *** rohara has joined #openstack-lbaas | 01:30 | |
| *** zz_blogan has joined #openstack-lbaas | 01:30 | |
| *** zz_blogan is now known as blogan | 01:41 | |
| *** enikanorov_ has joined #openstack-lbaas | 01:58 | |
| *** redrobot has joined #openstack-lbaas | 01:58 | |
| *** jkoelker has joined #openstack-lbaas | 01:58 | |
| *** TrevorV has joined #openstack-lbaas | 01:58 | |
| *** openstackgerrit has joined #openstack-lbaas | 01:58 | |
| *** fnaval has joined #openstack-lbaas | 01:58 | |
| *** Youcef has joined #openstack-lbaas | 01:58 | |
| blogan | sbalukoff: im not sure why those are failing, they're not failing locally | 02:01 |
| *** VijayB has joined #openstack-lbaas | 02:01 | |
| *** johnw has joined #openstack-lbaas | 02:03 | |
| *** sbalukoff has joined #openstack-lbaas | 02:05 | |
| *** dougwig has joined #openstack-lbaas | 02:05 | |
| *** ptoohill has joined #openstack-lbaas | 02:05 | |
| blogan | there yall are | 02:06 |
| blogan | sbalukoff: im not sure why those are failing, they're not failing locally | 02:06 |
| *** dougwig has left #openstack-lbaas | 02:06 | |
| *** dougwig has joined #openstack-lbaas | 02:06 | |
| blogan | dougwig: ping | 02:06 |
| *** dougwig has left #openstack-lbaas | 02:06 | |
| *** ptoohill has left #openstack-lbaas | 02:06 | |
| *** ptoohill has joined #openstack-lbaas | 02:06 | |
| *** dougwig has joined #openstack-lbaas | 02:07 | |
| *** sballe has joined #openstack-lbaas | 02:07 | |
| blogan | dougwig ping | 02:07 |
| ptoohill | here | 02:07 |
| ptoohill | >< | 02:07 |
| dougwig | hello | 02:08 |
| ptoohill | hi | 02:08 |
| ptoohill | :) | 02:08 |
| ptoohill | that was odd | 02:08 |
| blogan | dougwig: think i should change the stats call to take an object now? | 02:09 |
| blogan | good excuse to repush code to force another jenkins run since it failed for reasons it shouldn't have | 02:09 |
| *** jkoelker has quit IRC | 02:10 | |
| dougwig | got it | 02:10 |
| dougwig | yes, for sure. the tenant scheduling issue is something everyone will have, so the id isn't enough. | 02:11 |
| blogan | do you think you could pull that review down and run those tests to see if they fail for you? | 02:11 |
| dougwig | i can also make the change if you don't want to be distracted. | 02:11 |
| dougwig | which? oslbaas? | 02:12 |
| blogan | no directly from gerrit | 02:12 |
| blogan | https://review.openstack.org/#/c/105609/ | 02:12 |
| *** jkoelker has joined #openstack-lbaas | 02:14 | |
| dougwig | to make sure i understand, you want me to try unit tests on vanilla neutron + 105609, right? | 02:15 |
| blogan | stupid vpn | 02:19 |
| blogan | dougwig did you get my request? | 02:20 |
| dougwig | to make sure i understand, you want me to try unit tests on vanilla neutron + 105609, right? | 02:20 |
| blogan | yeah | 02:21 |
| blogan | just run your noop driver tests | 02:22 |
| blogan | on py26 and py27 | 02:22 |
| blogan | http://logs.openstack.org/09/105609/5/check/gate-neutron-python26/e6a696f/console.html | 02:23 |
| dougwig | sure, np. cloning neutron, pulling in dependent, then 609. standby. | 02:23 |
| *** blogan_ has joined #openstack-lbaas | 02:27 | |
| blogan_ | alright screw the vpn | 02:27 |
| dougwig | haha | 02:27 |
| blogan_ | happen to run those? | 02:28 |
| dougwig | yep, here ya go: | 02:28 |
| dougwig | https://www.irccloud.com/pastebin/6wqDDmjn | 02:28 |
| *** blogan is now known as zz_blogan | 02:30 | |
| blogan_ | hmm | 02:30 |
| dougwig | at least you know jenkins isn't lying | 02:31 |
| blogan_ | jenkins is a liar | 02:32 |
| blogan_ | but not in this case | 02:32 |
| blogan_ | my local box is a liar | 02:32 |
| blogan_ | okay so they renamed the db_base_v2 | 02:32 |
| dougwig | does this help? "/home/dougw/work/openstack/neutron/.tox/py26/lib/python2.6/site-packages/sqlalchemy/ext/declarative/clsregistry.py:160: SAWarning: This declarative base already contains a class with the same class name and module name as neutron.db.loadbalancer.loadbalancer_dbv2.SessionPersistenceV2, and will be replaced in the string-lookup table." | 02:34 |
| blogan_ | thats what i've been seeing as well which i did not understand | 02:34 |
| blogan_ | well not on my local box, but in jenkins | 02:34 |
| dougwig | i have a fast failure case. where/what instrumentation do you want, or i can just dig into it. | 02:34 |
| blogan_ | what was the tox command you ran? | 02:34 |
| dougwig | tox -e py26 | 02:35 |
| blogan_ | lol thats it | 02:35 |
| dougwig | py27 assplodes (which is usually an import error) | 02:35 |
| dougwig | interesting, since py26 passed when it was all one review. | 02:35 |
| blogan_ | ok so then im getting what appears to be older code from the checkout link in gerrit | 02:36 |
| blogan_ | what did you do to checkout the code? | 02:36 |
| *** VijayB has quit IRC | 02:36 | |
| dougwig | https://www.irccloud.com/pastebin/Ga3Hx08Y | 02:37 |
| dougwig | if you haven't in awhile, throw a -r into your tox (recreates vent) | 02:38 |
| dougwig | venv | 02:38 |
| dougwig | hacking changes a lot | 02:38 |
| blogan_ | its the code thats not changing | 02:38 |
| blogan_ | so why doesnt the checkout url in gerrit give me the new code | 02:38 |
| dougwig | you get my paste bin? i just used that script on a virgin linux box and got the same error as jenkins | 02:38 |
| blogan_ | yeah i got it, im just annoyed that the checkout command in gerrit is not giving me the same code | 02:39 |
| blogan_ | i have to be doing something stupid | 02:39 |
| dougwig | master branch in neutron? | 02:40 |
| dougwig | git screwed me over with oslbaas in a similar way a few weeks ago. i finally "fixed" it by blowing away my repo and re-cloning. | 02:41 |
| dougwig | which is a cop out, i'll admit. | 02:41 |
| blogan_ | well even gerrit is showing the same code im pulling down | 02:42 |
| blogan_ | so it seems you cloning the review.openstack repo and pulling the changes down gave you the same code jenkins is testing | 02:44 |
| blogan_ | im so confused and probably shouldn't be spending this much time trying to figure out why gerrit is not showing the right code but i have to know | 02:44 |
| blogan_ | ... | 02:45 |
| blogan_ | i believe im an idiot | 02:46 |
| *** fnaval has quit IRC | 02:48 | |
| dougwig | as long as you believe. | 02:49 |
| blogan_ | i just need to rebase the stupid change request | 02:50 |
| blogan_ | and fix the things that changed | 02:50 |
| dougwig | note to self: when 'git review' spews a bunch of errors on your commit message, it still accepts the review. i unknowingly got myself to patch set 4 on a stupid script change, just trying to get it happy with my git commit message. i hope all those CIs enjoy the churn. | 02:51 |
| blogan_ | lol | 02:51 |
| blogan_ | did you already change the stats? | 02:55 |
| dougwig | no, the last i saw you said you were doing it, and i didn't hear anything else. i can start now. | 02:55 |
| blogan_ | oh wait | 02:55 |
| dougwig | waiting | 02:55 |
| blogan_ | this is because you originally had the object | 02:55 |
| blogan_ | this review doesn't have the change to the id yet | 02:56 |
| blogan_ | its the review that depends on this one that does | 02:56 |
| dougwig | are you still pushing back to oslbaas? if i do the stats change, should i do it there? | 02:56 |
| blogan_ | no im not, | 02:58 |
| blogan_ | you can just do it in gerrit if you want | 02:58 |
| dougwig | is it in more than one gerrit change? i can just send you patches. | 02:58 |
| blogan_ | only one review would need it changed | 02:59 |
| blogan_ | i can do it pretty quickly, it needs to be rebased off this one anyway | 02:59 |
| blogan_ | so im going to have to pull it down and change it anyway | 02:59 |
| johnw | https://twitter.com/obazoud/status/487330014611140608 | 03:00 |
| blogan_ | yo dawgin' it | 03:02 |
| dougwig | ok, let me pull all four, make the stats change, then i'll send you a patch and let you split it? | 03:07 |
| *** sballe has quit IRC | 03:09 | |
| *** fnaval has joined #openstack-lbaas | 03:10 | |
| blogan_ | i already made it | 03:11 |
| dougwig | oh, lol, that would explain why i was starting at what i thought was old code! | 03:13 |
| dougwig | to give you some flavor, this is the first three lines of our icehouse driver stats(): | 03:14 |
| dougwig | https://www.irccloud.com/pastebin/WPHSVdrF | 03:14 |
| dougwig | so that's one more neutron db ref that you just killed. | 03:14 |
| blogan_ | awesome | 03:16 |
| blogan_ | though they could have just called the plugin | 03:16 |
| blogan_ | ah it was you, you could have called the plugin, but its gone now and doesnt matter | 03:17 |
| blogan_ | lol | 03:17 |
| dougwig | i think this is the only one that i haven't gotten rid of... is there a better way? | 03:17 |
| dougwig | https://www.irccloud.com/pastebin/5ok4jejD | 03:17 |
| dougwig | (i inherited both of those snippets.) | 03:18 |
| blogan_ | looking real quick hold on | 03:20 |
| blogan_ | well there'd be another way but it really wouldn't be any better | 03:22 |
| dougwig | at some point, we should just add a method to the lb model to abstract that (i'm not saying you have to do that!) | 03:23 |
| *** sbfox has joined #openstack-lbaas | 03:23 | |
| blogan_ | abstract what? | 03:24 |
| dougwig | load_balancer.ip_address already exists, maybe add a property load_balancer.floating_ip_addresses that returns a list of that internal ip's floats. | 03:25 |
| blogan_ | isn't it vip_address? | 03:26 |
| blogan_ | on loadbalancer | 03:26 |
| dougwig | i'm sure you're right; adjust the example to suit. :) | 03:27 |
| dougwig | err, no. this is on members, not the vip. | 03:27 |
| dougwig | sorry, i meant Member. | 03:27 |
| blogan_ | ah okay | 03:27 |
| dougwig | yeah, you can LB to a float or an internal (the ref doesn't, but there's nothing stopping it.) that's what that snippet is doing. | 03:28 |
| blogan_ | i bet you'll be able to get the fixed ips of a load balancer through the vip_port attribute | 03:28 |
| blogan_ | nvm im stupid | 03:29 |
| blogan_ | you're talking about floating ips | 03:29 |
| dougwig | for members | 03:29 |
| blogan_ | ah, how would that work then? | 03:30 |
| blogan_ | how would a member have a floating ip | 03:30 |
| dougwig | you can plug an LB into your external subnet, talk to members as floats, and the vip is handled directly via hardware. or you can plumb it inside your private network, talk to members with internal, use floats to the hardware vip. or you can have the LB straddle both, talk to members via internal, and export the vip itself directly (the last is best.) | 03:31 |
| dougwig | member is just a nova instance usually; why can't it have a float if you wanted it to? | 03:31 |
| blogan_ | yeah but it doesnt have to be, it can be an ip outside the network, but yeah if it is a nova instance, or any openstack addressable entity, i dont see why not | 03:33 |
| dougwig | let's you do some different things, based on your application. e.g., you can one-arm the first scenario, so outgoing traffic doesn't go through your LB. | 03:33 |
| dougwig | yeah, if the float lookup fails, we just use the ip handed to us, for that case. | 03:33 |
| dougwig | and it's configurable which we look for. | 03:34 |
| blogan_ | yeah | 03:34 |
| blogan_ | sounds like a nice blueprint after all this is done | 03:34 |
| dougwig | yeah, we don't need to feature creep. i'll use the neutron db for now, and abstract it later. | 03:35 |
| blogan_ | good those tests are passing in jenkins now | 03:37 |
| dougwig | when you rebase, i get about one email every 10 seconds, from all the CI's. | 03:37 |
| blogan_ | lol sorry | 03:38 |
| blogan_ | and sometimes i rebase in gerrit, and then pull down and do changes and push back up | 03:38 |
| blogan_ | but yeah im getting a ton as well | 03:38 |
| blogan_ | i was just thinking it'd be nice to get my review folder back under control | 03:39 |
| dougwig | my two biggest pet peeves about gerrit: it forgets all feedback on a new push, and it spams me with CI mail that i do not give a shit about, with no easy way to filter it. | 03:39 |
| dougwig | i care about humans and -1's, period. they're fixing ci usernames, so we'll be able to filter soon. | 03:40 |
| dougwig | alright, i'm going to go find some food... back later. | 03:42 |
| blogan_ | yeah that will be great to filter by usernames | 03:44 |
| *** HenryG has joined #openstack-lbaas | 03:56 | |
| *** sbfox has quit IRC | 04:14 | |
| *** blogan_ has quit IRC | 04:28 | |
| *** sab has joined #openstack-lbaas | 04:28 | |
| *** sbfox has joined #openstack-lbaas | 05:12 | |
| *** sbfox has quit IRC | 05:26 | |
| *** HenryG has quit IRC | 05:28 | |
| *** fnaval has quit IRC | 05:46 | |
| *** openstack has joined #openstack-lbaas | 07:41 | |
| *** sab has quit IRC | 09:29 | |
| *** sab has joined #openstack-lbaas | 09:47 | |
| *** openstackgerrit has quit IRC | 11:16 | |
| *** openstackgerrit has joined #openstack-lbaas | 11:17 | |
| *** sab has quit IRC | 11:59 | |
| *** mestery has joined #openstack-lbaas | 12:42 | |
| *** HenryG has joined #openstack-lbaas | 13:43 | |
| *** markmcclain has joined #openstack-lbaas | 13:50 | |
| *** xgerman has joined #openstack-lbaas | 13:54 | |
| *** xgerman has quit IRC | 14:03 | |
| *** fnaval has joined #openstack-lbaas | 14:08 | |
| *** fnaval has quit IRC | 14:38 | |
| *** vivek-ebay has joined #openstack-lbaas | 15:27 | |
| dougwig | morning | 15:47 |
| *** vivek-ebay has quit IRC | 16:00 | |
| *** sballe has joined #openstack-lbaas | 16:34 | |
| *** dlundquist has joined #openstack-lbaas | 16:53 | |
| *** VijayB_ has joined #openstack-lbaas | 16:58 | |
| *** VijayB_ has quit IRC | 16:58 | |
| *** sbfox has joined #openstack-lbaas | 17:17 | |
| *** VijayB_ has joined #openstack-lbaas | 17:36 | |
| *** markmcclain has quit IRC | 17:44 | |
| *** sab_ has joined #openstack-lbaas | 17:55 | |
| *** sab_ has quit IRC | 18:00 | |
| *** vivek-ebay has joined #openstack-lbaas | 18:00 | |
| *** VijayB_ has quit IRC | 18:32 | |
| *** markmcclain has joined #openstack-lbaas | 18:35 | |
| *** VijayB has joined #openstack-lbaas | 18:58 | |
| *** VijayB has quit IRC | 19:08 | |
| *** vivek-ebay has quit IRC | 19:18 | |
| *** markmcclain has quit IRC | 19:26 | |
| *** vivek-ebay has joined #openstack-lbaas | 19:59 | |
| *** VijayB has joined #openstack-lbaas | 20:00 | |
| *** mestery has quit IRC | 20:12 | |
| *** markmcclain has joined #openstack-lbaas | 20:52 | |
| *** markmcclain1 has joined #openstack-lbaas | 20:53 | |
| *** markmcclain has quit IRC | 20:56 | |
| dougwig | quiet day, or did freenode choke again? | 21:17 |
| *** VijayB_ has joined #openstack-lbaas | 21:25 | |
| *** VijayB_ has quit IRC | 21:25 | |
| *** VijayB_ has joined #openstack-lbaas | 21:26 | |
| *** VijayB has quit IRC | 21:28 | |
| *** VijayB_ has quit IRC | 21:29 | |
| *** VijayB has joined #openstack-lbaas | 21:32 | |
| *** markmcclain1 has quit IRC | 22:02 | |
| *** VijayB has quit IRC | 22:30 | |
| *** vivek-ebay has quit IRC | 22:58 | |
| *** HenryG has quit IRC | 23:22 | |
| *** dlundquist has left #openstack-lbaas | 23:29 | |
| *** sbfox1 has joined #openstack-lbaas | 23:31 | |
| *** sbfox has quit IRC | 23:35 | |
| *** sbfox has joined #openstack-lbaas | 23:36 | |
| *** sbfox1 has quit IRC | 23:36 | |
| *** vivek-ebay has joined #openstack-lbaas | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!