| *** sbfox has quit IRC | 00:09 | |
| *** min has quit IRC | 00:13 | |
| *** markmcclain has quit IRC | 00:24 | |
| *** markmcclain has joined #openstack-lbaas | 00:26 | |
| *** markmcclain has quit IRC | 00:27 | |
| *** markmcclain has joined #openstack-lbaas | 00:27 | |
| *** markmcclain has quit IRC | 00:56 | |
| *** HenryG has quit IRC | 00:57 | |
| *** HenryG has joined #openstack-lbaas | 00:59 | |
| *** xgerman has quit IRC | 01:06 | |
| *** sbfox has joined #openstack-lbaas | 01:09 | |
| *** sbfox has quit IRC | 01:14 | |
| *** HenryG has quit IRC | 01:30 | |
| *** HenryG has joined #openstack-lbaas | 01:30 | |
| *** VijayB_ has quit IRC | 01:49 | |
| *** VijayB has joined #openstack-lbaas | 01:50 | |
| *** fnaval has joined #openstack-lbaas | 01:53 | |
| *** VijayB has quit IRC | 01:54 | |
| *** sbalukoff has quit IRC | 02:02 | |
| *** sbfox has joined #openstack-lbaas | 02:08 | |
| *** sbfox has quit IRC | 02:25 | |
| *** zz_blogan is now known as blogan | 02:29 | |
| *** enikanorov has joined #openstack-lbaas | 02:33 | |
| *** vjay has joined #openstack-lbaas | 02:36 | |
| *** vjay2 has joined #openstack-lbaas | 02:36 | |
| *** enikanorov_ has quit IRC | 02:38 | |
| *** vjay has quit IRC | 02:40 | |
| *** crc32 has quit IRC | 02:47 | |
| *** vjay2 has quit IRC | 02:56 | |
| *** HenryG has quit IRC | 03:17 | |
| *** HenryG has joined #openstack-lbaas | 03:20 | |
| *** sbfox has joined #openstack-lbaas | 03:35 | |
| *** vjay has joined #openstack-lbaas | 03:52 | |
| *** blogan has quit IRC | 04:11 | |
| *** vjay has quit IRC | 04:11 | |
| *** sbfox has quit IRC | 04:14 | |
| *** dlundquist has left #openstack-lbaas | 04:18 | |
| *** vjay has joined #openstack-lbaas | 04:22 | |
| *** blogan has joined #openstack-lbaas | 04:22 | |
| *** vivek-ebay has joined #openstack-lbaas | 04:28 | |
| *** blogan is now known as zz_blogan | 05:37 | |
| *** vivek-ebay has quit IRC | 05:46 | |
| *** fnaval has quit IRC | 06:20 | |
| *** Youcef has joined #openstack-lbaas | 06:30 | |
| *** sbalukoff has joined #openstack-lbaas | 06:44 | |
| *** sballe_ has joined #openstack-lbaas | 06:49 | |
| *** sballe has quit IRC | 06:53 | |
| *** evgenyf has joined #openstack-lbaas | 07:13 | |
| *** evgenyf has quit IRC | 09:23 | |
| *** evgenyf has joined #openstack-lbaas | 09:31 | |
| *** openstack has joined #openstack-lbaas | 10:51 | |
| *** vjay has quit IRC | 11:14 | |
| *** vjay has joined #openstack-lbaas | 12:19 | |
| *** markmcclain has joined #openstack-lbaas | 13:15 | |
| *** fnaval has joined #openstack-lbaas | 13:53 | |
| *** vivek-ebay has joined #openstack-lbaas | 13:58 | |
| *** vivek-ebay has quit IRC | 14:04 | |
| *** mestery has quit IRC | 14:05 | |
| *** mestery has joined #openstack-lbaas | 14:14 | |
| *** rolledback has joined #openstack-lbaas | 14:18 | |
| *** vivek-ebay has joined #openstack-lbaas | 14:30 | |
| *** fnaval has quit IRC | 14:36 | |
| *** xgerman has joined #openstack-lbaas | 14:50 | |
| *** ptoohill_ has joined #openstack-lbaas | 14:54 | |
| *** ptoohill_ has quit IRC | 14:54 | |
| *** vivek-ebay has quit IRC | 15:00 | |
| *** vjay has quit IRC | 15:05 | |
| *** fnaval has joined #openstack-lbaas | 15:11 | |
| *** evgenyf has quit IRC | 15:14 | |
| *** sbalukoff has quit IRC | 15:21 | |
| *** sbalukoff has joined #openstack-lbaas | 15:39 | |
| *** jorgem has joined #openstack-lbaas | 15:44 | |
| *** markmcclain has quit IRC | 15:52 | |
| *** zz_blogan is now known as blogan | 15:57 | |
| *** sbalukoff has quit IRC | 15:57 | |
| *** sbalukoff has joined #openstack-lbaas | 16:01 | |
| blogan | ping mestery | 16:02 |
|---|---|---|
| mestery | blogan: howdy | 16:03 |
| blogan | mestery: so I've been working on unit tests for the load balancer plugin and I've noticed that in the test_loadbalancer_plugin the tests are actually testing the extension, and in the test_loadbalancer_db the tests are actually testing the plugin | 16:04 |
| blogan | is this something that neutron does or is this just something that service plugins? | 16:04 |
| *** sbalukoff has quit IRC | 16:15 | |
| *** sbalukoff has joined #openstack-lbaas | 16:18 | |
| *** sbalukoff has quit IRC | 16:22 | |
| mestery | blogan: That sounds slightly bizzare to me, but perhaps that's the way it works for LBaaS UT | 16:31 |
| blogan | mestery: yes it is quite bizarre, but I dont see vpn doing that, so I think i'm going to fix that for this | 16:35 |
| mestery | Awesome! | 16:36 |
| mestery | Makes sense to me! | 16:36 |
| blogan | mestery: however it appears the service plugin's db tests are testing the plugin (which inherits from the db class) soto me it doesn't seem like an appropriate unit test for the db | 16:40 |
| mestery | blogan: +1 | 16:42 |
| blogan | enikanorov: you have any background information on this? | 16:45 |
| *** rolledback has quit IRC | 16:49 | |
| *** vivek-ebay has joined #openstack-lbaas | 16:53 | |
| *** dlundquist has joined #openstack-lbaas | 16:55 | |
| *** markmcclain has joined #openstack-lbaas | 17:01 | |
| *** markmcclain1 has joined #openstack-lbaas | 17:03 | |
| *** markmcclain has quit IRC | 17:05 | |
| dougwig | mestery: if you've got a minute, what's the usual process for getting something like this (https://review.openstack.org/#/c/101084/) over the hump and in? at this point, we've got 5 +1's, 2 +2's (no +A), and while i'm happy to keep modifying nits until the cows come home, a lot of the comments are coming down to style at this point. is this normal? how | 17:08 |
| dougwig | long can i expect reviews to take normally? | 17:08 |
| mestery | dougwig: I'll +A that now, IMHO it's ready to go. | 17:09 |
| mestery | I wanted to give a bit of time for other cores to review, but I'll push the trigger now. | 17:09 |
| *** VijayB has joined #openstack-lbaas | 17:11 | |
| dougwig | thank you. | 17:12 |
| *** VijayB has quit IRC | 17:12 | |
| *** rolledback has joined #openstack-lbaas | 17:13 | |
| *** VijayB_ has joined #openstack-lbaas | 17:13 | |
| mestery | dougwig: No worries! | 17:14 |
| dougwig | mestery: is there some bit of openstack process knowledge to be learned here? do mildly contentious reviews always just take awhile? (when they take long enough that you have to rebase for jenkins and wipe out all your prior reviews, it gets more and more fun.) was my review just too half-baked and that's a normal level of pain due to that? or other? | 17:20 |
| dougwig | basically, i'm wondering how we go faster in future reviews, or if that's just not in the cards. | 17:20 |
| mestery | dougwig: Sometimes things move slowly, it really depends on core reviewer availability, etc. | 17:22 |
| mestery | dougwig: If you have something which needs to move fast, feel free to reach out to me. | 17:22 |
| dougwig | review by squeaky wheel? :) | 17:23 |
| *** fnaval has quit IRC | 17:41 | |
| *** VijayB has joined #openstack-lbaas | 17:42 | |
| *** rolledback has quit IRC | 17:43 | |
| *** VijayB_ has quit IRC | 17:45 | |
| *** markmcclain1 has quit IRC | 17:53 | |
| *** markmcclain has joined #openstack-lbaas | 17:53 | |
| *** rolledback has joined #openstack-lbaas | 17:57 | |
| *** vivek-ebay has quit IRC | 18:02 | |
| *** vivek-ebay has joined #openstack-lbaas | 18:03 | |
| *** sbalukoff has joined #openstack-lbaas | 18:07 | |
| *** rolledback has quit IRC | 18:08 | |
| *** fnaval has joined #openstack-lbaas | 18:10 | |
| *** vivek-ebay has quit IRC | 18:24 | |
| *** VijayB has quit IRC | 18:24 | |
| *** VijayB has joined #openstack-lbaas | 18:25 | |
| *** fnaval has quit IRC | 18:33 | |
| *** vivek-ebay has joined #openstack-lbaas | 18:39 | |
| *** vivek-eb_ has joined #openstack-lbaas | 18:40 | |
| *** vivek-ebay has quit IRC | 18:44 | |
| *** fnaval has joined #openstack-lbaas | 18:52 | |
| *** fnaval has quit IRC | 19:24 | |
| *** VijayB has quit IRC | 19:29 | |
| *** VijayB has joined #openstack-lbaas | 19:30 | |
| *** VijayB has quit IRC | 19:30 | |
| *** VijayB_ has joined #openstack-lbaas | 19:30 | |
| *** markmcclain has quit IRC | 19:34 | |
| *** VijayB_ has quit IRC | 19:35 | |
| *** rolledback has joined #openstack-lbaas | 19:40 | |
| *** vivek-eb_ has quit IRC | 19:45 | |
| *** mestery has quit IRC | 19:46 | |
| *** mestery has joined #openstack-lbaas | 19:48 | |
| *** dlundquist has quit IRC | 20:04 | |
| *** dlundquist has joined #openstack-lbaas | 20:06 | |
| *** markmcclain has joined #openstack-lbaas | 20:16 | |
| *** vivek-ebay has joined #openstack-lbaas | 20:32 | |
| *** VijayB has joined #openstack-lbaas | 20:32 | |
| *** VijayB_ has joined #openstack-lbaas | 20:33 | |
| *** VijayB has quit IRC | 20:36 | |
| *** fnaval has joined #openstack-lbaas | 20:52 | |
| *** crc32 has joined #openstack-lbaas | 20:56 | |
| *** rolledback has quit IRC | 21:19 | |
| *** jorgem has quit IRC | 21:22 | |
| *** markmcclain has quit IRC | 21:42 | |
| *** vivek-eb_ has joined #openstack-lbaas | 22:46 | |
| *** vivek-ebay has quit IRC | 22:46 | |
| *** vivek-ebay has joined #openstack-lbaas | 23:08 | |
| *** vivek-e__ has joined #openstack-lbaas | 23:09 | |
| *** vivek-ebay has quit IRC | 23:09 | |
| *** vivek-eb_ has quit IRC | 23:11 | |
| *** vivek-e__ has quit IRC | 23:33 | |
| *** dlundquist has left #openstack-lbaas | 23:37 | |
| *** vivek-ebay has joined #openstack-lbaas | 23:38 | |
| *** fnaval has quit IRC | 23:40 | |
| *** vivek-ebay has quit IRC | 23:54 | |
| *** blogan is now known as zz_blogan | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!