| simboja | Hi dulek: Here is how I'm trying to implement the flag. First I iniset the flag here: https://review.opendev.org/c/openstack/kuryr-kubernetes/+/853846/1/devstack/lib/kuryr_kubernetes | 08:37 |
|---|---|---|
| simboja | Then on Master and Yoga, I flip like this: https://review.opendev.org/c/openstack/kuryr-kubernetes/+/853848/1/devstack/lib/kuryr_kubernetes | 08:37 |
| simboja | On the tempest test, I do `if not CONF.kuryr_kubernetes.listener_reconciliation` ... | 08:38 |
| dulek | simboja: You shouldn't need to set the flag to False on stable branches. It should default to False. | 08:39 |
| dulek | simboja: On the kuryr-tempest-plugin side you should either be able to create a new test scenario and decide in `skip_checks()` or raise cls.skipException() on the test itself. | 08:41 |
| simboja | dulek : I think this should take care of it : https://paste.opendev.org/show/bwAjooCV9MXa2y9iFUiF/ | 08:43 |
| dulek | Sure, but I have no idea where you've put it? | 08:44 |
| simboja | Here on the skipException: https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/818701/30/kuryr_tempest_plugin/tests/scenario/test_service.py | 08:47 |
| simboja | So within the skip_checks() I am checking for that configuration and skipping if not enabled | 08:48 |
| dulek | simboja: This will cause no tests to be run when listener_reconciliation is False. And you want `test_loadbalancers_reconcilation` to be running in stable/xena, right? | 08:49 |
| dulek | You got to split it as I described. | 08:49 |
| simboja | Ohh, I see | 08:49 |
| dulek | Either a new scenario (class) or raising skipException in the test itself. | 08:49 |
| simboja | I am going with the second option | 08:49 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: LoadBalancer Members Reconciliation https://review.opendev.org/c/openstack/kuryr-kubernetes/+/845815 | 15:40 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!