| *** pmannidi|AFK is now known as pmannidi | 00:01 | |
| *** pmannidi is now known as pmannidi|brb | 00:38 | |
| *** pmannidi|brb is now known as pmannidi | 01:58 | |
| *** pmannidi is now known as pmannidi|Lunch | 03:14 | |
| *** pmannidi|Lunch is now known as pmannidi | 04:24 | |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-tempest-plugin master: Add Kuryr-tempest-plugin test for LoadBalancer Reconciliation https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/803244 | 08:31 |
|---|---|---|
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-tempest-plugin master: Add Kuryr-tempest-plugin test for LoadBalancer Reconciliation https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/803244 | 08:32 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-tempest-plugin master: Add Kuryr-tempest-plugin test for LoadBalancer Reconciliation https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/803244 | 08:33 |
| digitalsimboja | ltomasbo,maysams please review when you have a moment. Thanks | 09:07 |
| digitalsimboja | Please take a look at this output: | 09:19 |
| digitalsimboja | https://paste.opendev.org/show/808615/ | 09:19 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-tempest-plugin master: Add Kuryr-tempest-plugin test for LoadBalancer Reconciliation https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/803244 | 10:00 |
| digitalsimboja | Hello maysams, ltomasbo: Zuul is happy now! | 15:19 |
| ltomasbo | \o/ | 15:19 |
| maysams | yay! | 15:19 |
| digitalsimboja | wow wow!!! | 15:19 |
| ltomasbo | digitalsimboja, note your test is not being executed | 15:22 |
| ltomasbo | as you have the enable_reconciliation set to false | 15:22 |
| ltomasbo | have you tested it locally? | 15:22 |
| digitalsimboja | yes! | 15:22 |
| digitalsimboja | but got network error | 15:23 |
| digitalsimboja | somehow I am unstacking now | 15:23 |
| digitalsimboja | then test again | 15:23 |
| ltomasbo | you either need to enable it temporarily, or make the kuryr-kubernetes patch to depend on this one so that the test is enabled and tested there | 15:24 |
| digitalsimboja | let me understand, do you mean this: https://review.opendev.org/c/openstack/kuryr-kubernetes/+/805033/8/devstack/lib/kuryr_kubernetes | 15:34 |
| ltomasbo | I mean you either make your tempest patch depending on that one (so that that one includes the test and enables it) | 15:38 |
| ltomasbo | or you temporarly set that config var to default to true, so that it is enabled already (and tested) on the kuryr-tempest-plugin side | 15:38 |
| digitalsimboja | I am presuming that : CONF.kuryr_kubernetes.enable_reconciliation = True | 15:41 |
| digitalsimboja | would fail the tests on legacy branches? | 15:41 |
| ltomasbo | tempest is branch-less | 15:41 |
| ltomasbo | and in kuryr-kubernetes you only enable it on the master branch, not in previous one | 15:42 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-tempest-plugin master: Add Kuryr-tempest-plugin test for LoadBalancer Reconciliation https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/803244 | 16:02 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-tempest-plugin master: Add Kuryr-tempest-plugin test for LoadBalancer Reconciliation https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/803244 | 17:01 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-tempest-plugin master: Add Kuryr-tempest-plugin test for LoadBalancer Reconciliation https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/803244 | 17:02 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!