| *** pmannidi is now known as pmannidi|brb | 00:04 | |
| *** pmannidi|brb is now known as pmannidi | 01:06 | |
| opendevreview | Roman Dobosz proposed openstack/kuryr-kubernetes master: [WIP] Switch gates to OVN by default. https://review.opendev.org/c/openstack/kuryr-kubernetes/+/802999 | 06:32 |
|---|---|---|
| digitalsimboja | Hello! | 06:43 |
| digitalsimboja | Good morning ltomasbo | 06:43 |
| digitalsimboja | Following my conversation with the folks at lbaas | 06:43 |
| digitalsimboja | They advised I propose this change on the main Kuryr repo | 06:44 |
| digitalsimboja | https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 06:44 |
| digitalsimboja | This according them has to go in to resolve the Zuul failure | 06:45 |
| digitalsimboja | Please review | 06:45 |
| ltomasbo | yeah, makes sense | 06:47 |
| ltomasbo | and then you will need to make your change "depends-on" this one | 06:47 |
| ltomasbo | digitalsimboja, ^ | 06:47 |
| ltomasbo | so that you can check if that works for you or not as expected | 06:47 |
| digitalsimboja | Already don | 06:47 |
| digitalsimboja | over herre | 06:48 |
| digitalsimboja | https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/803244 | 06:48 |
| ltomasbo | digitalsimboja, then you need to check what is failing, as all the gates are still red | 06:49 |
| ltomasbo | with the same failure | 06:49 |
| ltomasbo | you added the depends on in not the right format, check https://www.mediawiki.org/wiki/Gerrit/Cross-repo_dependencies | 06:50 |
| digitalsimboja | Ohh! | 06:51 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-tempest-plugin master: Add Kuryr-tempest-plugin test for LoadBalancer Reconciliation https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/803244 | 07:34 |
| *** pmannidi is now known as pmannidi|brb | 07:49 | |
| digitalsimboja | ltomasbo: Zuul still failed after amending as above | 09:31 |
| digitalsimboja | https://zuul.opendev.org/t/openstack/status/#803244 | 09:49 |
| gryf | you don't have octavia-tempest-plugin. | 09:58 |
| gryf | I'll give you a hint in https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527. | 09:59 |
| gryf | hm. ignore me. I'm stupid. it should work. | 10:09 |
| gryf | simboja, here's why: https://docs.openstack.org/devstack/latest/zuul_roles.html#rolevar-write-devstack-local-conf.tempest_plugins | 10:13 |
| simboja | taking a look... | 10:13 |
| digitalsimboja | If a plugin declares a dependency on another plugin (via plugin_requires in the plugin’s settings file), this role will automatically emit enable_plugin lines in the correct order. | 10:33 |
| digitalsimboja | gryf, I read the above ^ | 10:34 |
| gryf | > If the variable already exists, its value is not changed. | 10:34 |
| gryf | but that's weird, since we didn't declare it anywhere. | 10:36 |
| gryf | yet, tempest clearly doesn't pull octavia tempest plugin. | 10:36 |
| gryf | perhaps we need to discard this line, and add tempest_plugin with both: kuryr and octavia tempest plugins? | 10:37 |
| digitalsimboja | remove both entirely on local.conf? | 10:38 |
| digitalsimboja | No sorry! You mean I need to add kuryr-tempest-plugin to the vars I declared on .zuul.d as well? | 10:40 |
| gryf | I'm referring to zuul config. | 10:40 |
| gryf | please, take a look at the commit message: https://opendev.org/openstack/devstack/commit/f0d1896d0acdf0aa9198442f0642e8a7fd3ff422 | 10:40 |
| gryf | and because we do have it declared, at base class, and whatever you add in var.tempest_plugins list, it will be ignored. | 10:42 |
| digitalsimboja | sure I get it now. | 10:44 |
| digitalsimboja | Now either we remove the declaration from the base class so it can access the one declared using vars or we add octavia-tempest-plugin here | 10:46 |
| digitalsimboja | I suggest the second option so it can be captured at base. My thoughts though I could be wrong? | 10:46 |
| gryf | by "here" you mean where? | 10:46 |
| digitalsimboja | I mean on zuul config, I could add the octavia-tempest-plugin as well? | 10:49 |
| digitalsimboja | Could be add as a list | 10:50 |
| digitalsimboja | devstack_localrc: | 10:50 |
| digitalsimboja | Q_AGENT: openvswitch | 10:50 |
| digitalsimboja | Q_ML2_TENANT_NETWORK_TYPE: vxlan | 10:50 |
| digitalsimboja | Q_ML2_PLUGIN_MECHANISM_DRIVERS: openvswitch,linuxbridge | 10:50 |
| digitalsimboja | ML2_L3_PLUGIN: router | 10:50 |
| digitalsimboja | KURYR_K8S_API_PORT: 6443 | 10:50 |
| digitalsimboja | TEMPEST_PLUGINS: '/opt/stack/kuryr-tempest-plugin' | 10:50 |
| digitalsimboja | ? | 10:51 |
| gryf | here's the options: | 10:52 |
| gryf | 1) you could remove https://github.com/openstack/kuryr-kubernetes/blob/master/.zuul.d/base.yaml#L49, add instead vars.tempest_plugins: ['kuryr-tempest-plugin'] | 10:54 |
| gryf | 2) override devstack_localrc.TEMPEST_PLUGINS: '/opt/stack/kuryr-tempest-plugin /opt/stack/octavia-tempest-plugin' (I'm not sure for that one, since we need to clone repo for octavia somehow, perhaps it can be done similar to this: https://github.com/openstack/kuryr-kubernetes/blob/master/.zuul.d/base.yaml#L33) | 10:56 |
| gryf | on the octavia base job. and remove var.tempest_plugins. | 10:57 |
| gryf | I guess, that first option looks cleaner, than manually clone and fill TEMPEST_PLUGINS var. | 10:58 |
| digitalsimboja | first option sure looks cleaner | 11:05 |
| digitalsimboja | so for the first option, I remove L49 | 11:05 |
| digitalsimboja | Then add the Octavia and kuryr tempest plugins within the vars | 11:06 |
| gryf | for option 1, you'll need to remove this aswell https://github.com/openstack/kuryr-kubernetes/blob/master/.zuul.d/base.yaml#L33 | 11:08 |
| digitalsimboja | Okay got it! | 11:10 |
| gryf | something like this: https://paste.opendev.org/show/807902/ | 11:10 |
| gryf | and than we will see in generated local_conf.txt on gates, if that was correct. | 11:11 |
| digitalsimboja | I need to include the octavia-tempest-plugin to the kuryr more like below: | 11:13 |
| digitalsimboja | https://paste.opendev.org/show/807903/ | 11:13 |
| gryf | well, yeah, or just on octavia base job. | 11:14 |
| gryf | and I'd prefer the latter, since it is octavia related. | 11:15 |
| digitalsimboja | perfect | 11:17 |
| digitalsimboja | making the required changes... | 11:18 |
| opendevreview | Roman Dobosz proposed openstack/kuryr-kubernetes master: [WIP] Switch gates to OVN by default. https://review.opendev.org/c/openstack/kuryr-kubernetes/+/802999 | 11:19 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 11:20 |
| digitalsimboja | Here | 12:10 |
| digitalsimboja | https://zuul.opendev.org/t/openstack/build/ed14c621acf74847ad7bfd941a984a0c | 12:10 |
| digitalsimboja | venv-tempest run-test-pre: PYTHONHASHSEED='1306222494' | 12:10 |
| digitalsimboja | venv-tempest run-test: commands[0] | pip install -c /tmp/tempest_u_c_m.9hGP3NvLf8 /opt/stack/octavia-tempest-plugin | 12:10 |
| digitalsimboja | ERROR: Invalid requirement: '/opt/stack/octavia-tempest-plugin' | 12:10 |
| digitalsimboja | Hint: It looks like a path. File '/opt/stack/octavia-tempest-plugin' does not exist. | 12:10 |
| digitalsimboja | ERROR: InvocationError for command /opt/stack/tempest/.tox/tempest/bin/pip install -c /tmp/tempest_u_c_m.9hGP3NvLf8 /opt/stack/octavia-tempest-plugin (exited with code 1) | 12:10 |
| digitalsimboja | its not able to discover octavia-tempest-plugin | 12:12 |
| digitalsimboja | I wonder why | 12:12 |
| digitalsimboja | gryf, we are still getting the zuul failure | 13:59 |
| gryf | looking. | 14:05 |
| digitalsimboja | okay | 14:16 |
| gryf | ok, it crash on octavia tempest not found in opt/stack | 14:22 |
| gryf | digitalsimboja, added comments: https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 14:29 |
| digitalsimboja | looking.. | 14:29 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 15:16 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 15:20 |
| gryf | digitalsimboja, it will still not work, since you reverted whole base.yaml :( | 15:24 |
| digitalsimboja | reverted? | 15:24 |
| gryf | yes. | 15:24 |
| gryf | you've should keep this change: https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527/2..4/.zuul.d/base.yaml and this one: https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527/2..4/.zuul.d/base.yaml#b42 | 15:26 |
| gryf | and currently you reverted whole base.yaml, so TEMPEST_PLUGINS still exists, and still whatever you put in vars.tempest_plugins list in kuryr-kubernetes-tempest job will be ignored. | 15:27 |
| digitalsimboja | checking.. | 15:28 |
| digitalsimboja | so I should remove this TEMPEST_PLUGINS: '/opt/stack/kuryr-tempest-plugin' | 15:32 |
| gryf | yes. | 15:35 |
| gryf | and add tempest_plugins: - kuryr-tempest-plugin instead. | 15:36 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 16:26 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 16:40 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 17:01 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 18:13 |
| digitalsimboja | gryf, please take a look | 18:55 |
| digitalsimboja | https://paste.opendev.org/show/807917/ | 18:55 |
| gryf | triple vars. | 18:57 |
| gryf | do you have an idea how dictionary in python works? | 18:58 |
| digitalsimboja | Key,value | 18:59 |
| digitalsimboja | sure | 18:59 |
| digitalsimboja | I see the error | 18:59 |
| digitalsimboja | sending... new change | 19:00 |
| gryf | wait :) | 19:00 |
| gryf | you don't need lines: 28 and 31. | 19:00 |
| gryf | also. | 19:01 |
| gryf | line 33 is wrong/ | 19:02 |
| digitalsimboja | sure yes | 19:02 |
| gryf | it should be devstack_plugins instead. | 19:02 |
| gryf | *line 32 | 19:03 |
| digitalsimboja | You mean line 32 should be devstack_plugins instead of tempest? | 19:06 |
| digitalsimboja | see.. | 19:07 |
| digitalsimboja | https://paste.opendev.org/show/807919/ | 19:07 |
| digitalsimboja | tempest-plugin has octavia-tempest-plugin | 19:07 |
| digitalsimboja | devstack_plugins has https://opendev.org/openstack/octavia-tempest-plugin.git | 19:08 |
| gryf | yup. | 19:08 |
| digitalsimboja | tempest_plugins is a list | 19:08 |
| digitalsimboja | now contains only the octavia-tempest-plugin | 19:08 |
| gryf | the latest pastebin seems ok. | 19:09 |
| gryf | previous has issues :) | 19:09 |
| digitalsimboja | sure | 19:09 |
| digitalsimboja | but still check line 32 | 19:09 |
| digitalsimboja | looks good? | 19:09 |
| gryf | there is no key there | 19:10 |
| gryf | octavia-tempest-plugin: https… | 19:10 |
| digitalsimboja | My guess | 19:10 |
| digitalsimboja | adding that.. | 19:10 |
| gryf | tempest_plugins looks ok though. | 19:10 |
| gryf | (on line 30) | 19:10 |
| digitalsimboja | https://paste.opendev.org/show/807920/ | 19:11 |
| digitalsimboja | I think we should be fine now | 19:11 |
| gryf | yup. should be good. | 19:13 |
| digitalsimboja | cool | 19:16 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 19:18 |
| digitalsimboja | gryf: Failed again over here | 20:04 |
| digitalsimboja | https://zuul.opendev.org/t/openstack/build/6bb75e16428440c5862d188698907a04 | 20:04 |
| digitalsimboja | venv-tempest run-test: commands[0] | pip install -c /tmp/tempest_u_c_m.oKgoDUMlTC /opt/stack/octavia-tempest-plugin | 20:05 |
| digitalsimboja | ERROR: Invalid requirement: '/opt/stack/octavia-tempest-plugin' | 20:05 |
| digitalsimboja | Hint: It looks like a path. File '/opt/stack/octavia-tempest-plugin' does not exist. | 20:05 |
| digitalsimboja | ERROR: InvocationError for command /opt/stack/tempest/.tox/tempest/bin/pip install -c /tmp/tempest_u_c_m.oKgoDUMlTC /opt/stack/octavia-tempest-plugin (exited with code 1) | 20:05 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 20:11 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!