| *** pmannidi is now known as pmannidi|brb | 01:29 | |
| *** pmannidi|brb is now known as pmannidi | 01:59 | |
| *** pmannidi is now known as pmannidi|AFK | 03:14 | |
| *** pmannidi|AFK is now known as pmannidi | 04:48 | |
| opendevreview | Roman Dobosz proposed openstack/kuryr-kubernetes master: Fix multinode gate. https://review.opendev.org/c/openstack/kuryr-kubernetes/+/801618 | 06:00 |
|---|---|---|
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add the Service Creation Flow Diagram https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798064 | 08:04 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add the Service Creation Flow Diagram https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798064 | 08:44 |
| opendevreview | Roman Dobosz proposed openstack/kuryr-kubernetes master: [WIP] Switch to OVN by default, let's see how that explode. https://review.opendev.org/c/openstack/kuryr-kubernetes/+/802999 | 09:27 |
| *** pmannidi is now known as pmannidi|AFK | 09:29 | |
| digitalsimboja | maysams, gryf, ltomasbo: Just a little clarification. Please take a look at what I am trying to mirror. It involves several module imports | 11:38 |
| digitalsimboja | https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/services/load_balancer/v2/loadbalancer_client.py | 11:38 |
| digitalsimboja | Hope I am on the right track? | 11:39 |
| gryf | digitalsimboja, you want to interact with octavia api directly, instead of using os_admin? | 11:59 |
| digitalsimboja | I want to use os_admin but not finding a way to interact with octavia | 12:00 |
| digitalsimboja | so I am trying to mirror what Octavia has up there to Kuryr | 12:00 |
| digitalsimboja | I need to use the loadbalancer_client to list the loadbalancers specifically | 12:01 |
| gryf | mhm. I don't have working env right now, but I'd expect, that os_admin have some attribute like os_admin.load_balancer or similar. | 12:23 |
| digitalsimboja | https://paste.opendev.org/show/807818/ | 12:49 |
| digitalsimboja | manager is from tempest repo | 12:49 |
| gryf | you probably needs octavia-tempest-plugin for that. | 13:00 |
| digitalsimboja | I guess | 13:07 |
| digitalsimboja | so I have to clone that then, that is add it to my local.conf, unstack and stack again? | 13:08 |
| gryf | i guess, it might be cloned, installed and perhaps reinitialize tempest, although unstack-stack will do all of this for you. | 13:38 |
| ltomasbo | one comment... digitalsimboja you are adding the job to kuryr-tempest-plugin, not sure if adding dependency on octavia-tempest-plugin is a good approach | 13:43 |
| ltomasbo | gryf, ^ | 13:43 |
| ltomasbo | perhaps we need to extend os_admin so that it has a client for octavia too instead | 13:43 |
| digitalsimboja | extending os_admin would require adding octavia component to the existing ones? | 13:44 |
| ltomasbo | would be adding octavia client here in the same way as others where added https://github.com/openstack/tempest/blob/master/tempest/clients.py | 13:45 |
| digitalsimboja | sure | 13:46 |
| ltomasbo | and here they are added https://github.com/openstack/tempest/tree/master/tempest/lib/services | 13:47 |
| ltomasbo | kind of surprise loadbalancer is not yet there... :/ | 13:47 |
| maysams | +1 | 13:47 |
| ltomasbo | maybe there is a reason for this https://github.com/openstack/octavia-tempest-plugin/tree/master/octavia_tempest_plugin/services/load_balancer/v2 not to be on base tempest | 13:48 |
| ltomasbo | digitalsimboja, perhaps worth to ask on the octavia IRC channel | 13:48 |
| ltomasbo | digitalsimboja, it is named openstack-lbaas | 13:49 |
| digitalsimboja | Let me correspond with the guys there then | 13:49 |
| ltomasbo | digitalsimboja, you can probably ping there cgoncalves, gthiemonge or johnson | 13:50 |
| digitalsimboja | cool! | 13:50 |
| gryf | ltomasbo, right, I saw that implementation. also, they used to have it as extension to os_admin object: https://opendev.org/openstack/octavia-tempest-plugin/src/commit/986e3f543c6b3c588b88b1748641680759ed2856/octavia_tempest_plugin/tests/api/v2/test_load_balancer.py#L495 | 13:51 |
| ltomasbo | gryf, and not anymore? | 13:53 |
| gryf | nope. | 13:53 |
| gryf | let me find the commit | 13:53 |
| ltomasbo | ok... then, probably there is a reason for it xD | 13:53 |
| gryf | https://opendev.org/openstack/octavia-tempest-plugin/commit/6006de75a749556a071d23e12ca3a1e7e0ec58c0 | 13:55 |
| gryf | although, here: https://opendev.org/openstack/octavia-tempest-plugin/src/branch/master/octavia_tempest_plugin/tests/act_stdby_scenario/v2/test_active_standby.py#L186 they are using load_balancer_v2 member. | 14:00 |
| gryf | pretty confusing. | 14:00 |
| ltomasbo | perhaps they are extending os_admin object with that somehow on the octavia_tempest_plugin | 14:01 |
| gryf | there was something… but what is more confusing, is the fact, there is no buildin available to tempest ootb. | 14:02 |
| gryf | buildin for octavia api. | 14:02 |
| digitalsimboja | First, does the loadbalancers on octavia get created when a service is created on tempest? | 14:04 |
| ltomasbo | https://github.com/openstack/tempest/commit/7f5dd855c6099a73eb5752ab246303c5aac29ce9 | 14:04 |
| gryf | ltomasbo, https://opendev.org/openstack/octavia-tempest-plugin/src/branch/master/octavia_tempest_plugin/plugin.py here's how they plug it in. | 14:05 |
| ltomasbo | ok | 14:06 |
| gryf | the last method expose the implementation to tempest. | 14:07 |
| gryf | lb_v2_services.__all__ is pointing to the code you mentioned on 15:48:41. | 14:07 |
| ltomasbo | gryf, this is the commit removing os_admin: https://opendev.org/openstack/octavia-tempest-plugin/commit/29d8e61ca27859b70a4350e87022442a78f8fa8c | 14:09 |
| ltomasbo | they are suing it through amphora_client = self.os_admin.load_balancer_v2.AmphoraClient() | 14:09 |
| gryf | ltomasbo, how about this one: https://opendev.org/openstack/octavia-tempest-plugin/src/branch/master/octavia_tempest_plugin/tests/test_base.py#L163-L211 ? | 14:13 |
| gryf | either way, seems like we need to write a proxy to the lb client ourselves. | 14:16 |
| ltomasbo | gryf, Friday + multitasking (in a call at the moment) is not helping me to follow that! xD | 14:16 |
| gryf | yeah, definitely. | 14:16 |
| ltomasbo | yep, we would need to | 14:16 |
| gryf | as an option we could think of using openstacksdk or call the api using requests, although the latter one would be pretty bad in many ways. | 14:17 |
| ltomasbo | depending on what we need, probably just loadbalancer client to remove the lbs, it won't be much (hopefully | 14:17 |
| ltomasbo | digitalsimboja, you only need to remove the loadbalancer, right? we don't need to create/update lbs, pools, listeners, members... so... lets try to keep it simple | 14:18 |
| gryf | oh my. Octavia folks HAS used requests and json to parse the output: https://opendev.org/openstack/octavia-tempest-plugin/src/branch/master/octavia_tempest_plugin/services/load_balancer/v2/base_client.py | 14:21 |
| gryf | so probably an lite version we'd need to implement for lbs. | 14:21 |
| ltomasbo | om | 14:24 |
| gryf | otoh. We don't need to examine api for octavia, right? maybe we can utilize openstacksdk for that purpose. | 14:26 |
| ltomasbo | I think we just need to trigger the cascade loadbalancer deletion and thats it | 14:26 |
| gryf | you mean through api? | 14:27 |
| ltomasbo | the rest can be done by checking dataplane (pinging the service IP) | 14:27 |
| gryf | well, we also need to parse the result of the req, if we talking about hitting the api. | 14:28 |
| gryf | but probably that would be the best approach. | 14:29 |
| ltomasbo | simboja, rejoin the openstack-lbaas | 14:36 |
| simboja | Ohh | 14:36 |
| ltomasbo | simboja, the guy is surprised you ask and are not connected | 14:36 |
| ltomasbo | I told him it is due to the networking issues | 14:36 |
| simboja | sure, never knew i got disconnected | 14:38 |
| simboja | Hi ltomasbo | 14:47 |
| ltomasbo | gryf, so, it seems the process is to move out of tempest...and we would need to load the octavia-tempest-plugin and add it as a dependency | 14:47 |
| simboja | So we shall have to implement the service_client in the kuryr_tempest_plugin | 14:47 |
| digitalsimboja | gryf: based on the messages above, I guess we are to load the octavia-tempest-plugin as a dependency? | 17:58 |
| gryf | right. | 17:59 |
| gryf | it might look like a fat dependency, but actually it's reasonable one. we depend on octavia, so that there is no point to write our own api client - let's re-use the octavia one. | 18:02 |
| *** pmannidi|AFK is now known as pmannidi | 22:05 | |
| *** pmannidi is now known as pmannidi|AFK | 23:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!