| *** pmannidi is now known as pmannidi|brb | 04:28 | |
| *** pmannidi|brb is now known as pmannidi | 05:34 | |
| opendevreview | Roman Dobosz proposed openstack/kuryr-kubernetes master: Fix multinode gate, separate variations for OVN and OVS. https://review.opendev.org/c/openstack/kuryr-kubernetes/+/801618 | 12:55 |
|---|---|---|
| digitalsimboja | @maysams: Quite confusing. I can not see on the implementation where the _reconcile_lbass() is processing list of lists | 17:57 |
| digitalsimboja | https://paste.opendev.org/show/807628/ | 17:58 |
| digitalsimboja | The above is the implementation | 17:58 |
| digitalsimboja | I feel my challenge is on this lines | 18:07 |
| digitalsimboja | crds_to_reconcile_selflink = ['/apis/openstack.org/v1/namespaces/default/kuryrloadbalancers/test', | 18:07 |
| digitalsimboja | '/apis/openstack.org/v1/namespaces/default/kuryrloadbalancers/demo'] | 18:07 |
| digitalsimboja | m_get_res_link.return_value = crds_to_reconcile_selflink | 18:07 |
| digitalsimboja | I doubt if I am getting the return value of the get_res_link(loadbalancer_crd) right? | 18:08 |
| maysams | digitalsimboja: try not mocking get_res_link and see what happens | 18:30 |
| digitalsimboja | trying that | 18:31 |
| maysams | digitalsimboja: the issue might be because get_res_link is called twice due to the loop | 18:32 |
| digitalsimboja | I guess so | 18:32 |
| digitalsimboja | let me see without mocking it | 18:32 |
| maysams | digitalsimboja: so in this case it would need to use has_calls, or side_effect | 18:32 |
| maysams | instead of defining the return_value | 18:32 |
| maysams | but you can try without mocking first and see what happens | 18:33 |
| digitalsimboja | I tried without mocking it and it passed | 18:33 |
| digitalsimboja | check tmux | 18:33 |
| maysams | good | 18:33 |
| *** maysams is now known as maysams-afk | 18:33 | |
| maysams-afk | need to disconnect, see you o/ | 18:34 |
| digitalsimboja | Thanks maysams | 18:34 |
| digitalsimboja | see you | 18:34 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: wip: Loadbalancers reconciliation https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798904 | 18:35 |
| maysams-afk | digitalsimboja: note that there are a couple of assert_calleds that can be performed | 18:37 |
| maysams-afk | and there seems to be some leftovers on the test | 18:37 |
| digitalsimboja | okay I will work on that | 18:39 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!