| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: wip: Loadbalancers reconciliation https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798904 | 06:05 |
|---|---|---|
| digitalsimboja | @maysams, @ltomasbo: I got your reviews on the utility function to retrieve all CRDs from kubernetes, | 06:23 |
| digitalsimboja | I think we need to make it generic? | 06:23 |
| digitalsimboja | irrespective of namespaces? | 06:23 |
| ltomasbo | digitalsimboja, the utils function is ok if it has both options (all CRDs in a namespace, and all in all namespaces), but from the loadbalancer handler you should retrieve all, for all namespaces | 06:47 |
| ltomasbo | digitalsimboja, and, in case you missed my other comment, the code should be merge with the other existing one for the kuryrnetworkpolicy_crds, to avoid code repetition | 06:47 |
| digitalsimboja | okay got it | 06:52 |
| ltomasbo | digitalsimboja, I'm reviewing the new patch at the moment | 06:52 |
| digitalsimboja | the reconciliation timing can be agreed later on, I suggest | 06:53 |
| digitalsimboja | Great! | 06:53 |
| ltomasbo | digitalsimboja, wait a minute and you will see there more comments | 06:53 |
| digitalsimboja | Sure | 06:53 |
| ltomasbo | done | 06:53 |
| digitalsimboja | checking | 06:58 |
| maysams | dulek: gryf: Hello folks, when you have some spare time, it would be great to have your thoughts on the diagrams being proposed here | 10:30 |
| maysams | https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798064 | 10:30 |
| maysams | specially with regards to the watcher, if it makes sense to have in the diagram | 10:31 |
| maysams | ltomasbo: ^ | 10:32 |
| digitalsimboja | Hello! | 11:33 |
| digitalsimboja | @maysams, @ltomasbo: Regarding a situation where there is crds to reconcile? | 11:33 |
| digitalsimboja | I believe I need an if statement to make this check? | 11:34 |
| digitalsimboja | Then I am thinking of using a for loop to reconcile each KuryrLoadBalancer CRD? | 11:36 |
| ltomasbo | right, you need to figure out what CRDs need reconciliation, and reconcile the ones that need it | 11:37 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: wip: Loadbalancers reconciliation https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798904 | 11:45 |
| digitalsimboja | I shall work on the reconciliations now before the utility function | 11:46 |
| maysams | digitalsimboja: one extra thing, please always add the reference to this blueprint in the commit message https://blueprints.launchpad.net/kuryr-kubernetes/+spec/reconcile-openstack-resources-with-k8s | 11:50 |
| maysams | to easily track what patches added support to this feature | 11:51 |
| digitalsimboja | Okay | 12:05 |
| digitalsimboja | Now I have the challenge of getting the CRDs name, I am thinking of the best way to achieve this | 12:27 |
| digitalsimboja | 1. If I get the CRD 'id and the 'name' together | 12:27 |
| digitalsimboja | I could pass only the name for the actual reconciliation | 12:27 |
| digitalsimboja | I don't know if that line of thought is cool @ltomasbo, @maysams? | 12:28 |
| ltomasbo | digitalsimboja, you have the funciont to get all the kuryrloadbalancer_crds... so that includes their names | 12:31 |
| ltomasbo | you just need to retrieve the information from there | 12:32 |
| ltomasbo | you can use a dict, a tuple... depending on how you want to do it | 12:33 |
| digitalsimboja | Got it! | 12:36 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: wip: Loadbalancers reconciliation https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798904 | 15:01 |
| digitalsimboja | @ltomasbo, @maysams: Now I have the crds to be reconciled in a list of tuples | 15:07 |
| digitalsimboja | I would now focus on the reconcilitaion implementation | 15:07 |
| ltomasbo | digitalsimboja, great! | 15:08 |
| maysams | digitalsimboja, cool | 15:21 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: wip: Loadbalancers reconciliation https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798904 | 19:06 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!