| opendevreview | Merged openstack/kuryr-kubernetes master: Minor formatting corrections. https://review.opendev.org/c/openstack/kuryr-kubernetes/+/797869 | 07:07 |
|---|---|---|
| digitalsimboja | Hello! | 09:36 |
| digitalsimboja | I have added a high level service creation flow diagram | 09:36 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Added the Service Creation Flow Diagram https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798064 | 09:36 |
| digitalsimboja | This only shows the ServiceHandler and the EndpointsHandler and how they handle the service creation on Kubernetes | 09:37 |
| digitalsimboja | I wanted to abstract the KuryrLoadBalancerHandler aspect from the next diagram which I intend to submit too | 09:38 |
| digitalsimboja | Please review @ltomasbo, @maysams | 09:38 |
| digitalsimboja | So while you take a look and review this, let me work on the KuryrLoadBalancerHandler side of things? | 09:40 |
| ltomasbo | digitalsimboja, look ok-ish, but I was expecting the other type of diagram, where you see the different components, and how the different handlers interact with k8sAPI, drivers and OpenSTack API | 09:49 |
| digitalsimboja | I suggest we retain this as well while I add that particular one | 09:50 |
| digitalsimboja | The diagram can help a very newbie see how things are tied together | 09:50 |
| ltomasbo | right! | 09:50 |
| digitalsimboja | So I will do the other diagram which would now show all the drivers and handlers etc | 09:51 |
| digitalsimboja | makes sense? | 09:51 |
| ltomasbo | yes, please add it to the same patch set | 09:56 |
| digitalsimboja | Great! | 10:00 |
| maysams | digitalsimboja: I agree with ltomasbo. The sequence diagram fits better what is aimed to achieve with the patch as an example: https://docs.openstack.org/kuryr-kubernetes/latest/devref/kuryr_kubernetes_design.html#communication | 10:02 |
| maysams | digitalsimboja: it will give better indication of what event was triggered first and who/what triggered it | 10:03 |
| digitalsimboja | Perfect! Adding that as we speak | 10:03 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Added the Service Creation Flow Diagram https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798064 | 12:04 |
| digitalsimboja | @maysams, @ltomasbo: Please check | 12:04 |
| maysams | I will check asap | 12:04 |
| digitalsimboja | I am not sure but I guess I woould need to show that LbaasV2 Driver talks to OCTAVIA API? | 12:17 |
| digitalsimboja | But I wait for your comments | 12:17 |
| ltomasbo | digitalsimboja, yes, few comments | 12:20 |
| ltomasbo | 1) perhaps better to put the k8s API server right near to the user | 12:20 |
| ltomasbo | 2) I don't think the watch svc from the user is needed | 12:20 |
| ltomasbo | 3) it is missing an ADd ev (endpoints) from the API to the endpoints handler | 12:21 |
| ltomasbo | the create_svc_spec and create_svc_endpoings, better to rename it to create KuryrLoadBalancer CRD (spec) | 12:21 |
| ltomasbo | and the second one update KuryrLoadBalancer CRD (spec) | 12:22 |
| ltomasbo | then, line between k8s API and KLB Handler, should be similar to the other ones: ADD ev (klb crd) | 12:22 |
| ltomasbo | and yes, you should add OpenStack API and the LBaaV2 Driver calling it | 12:23 |
| ltomasbo | perhaps you can skip the release LB if provider is not OVN... that maybe are details that are not needed | 12:23 |
| ltomasbo | and in general looks good! it shows the right flow! | 12:24 |
| digitalsimboja | Wow! Thanks, I appreciate | 12:25 |
| digitalsimboja | @maysams might have one or two? | 12:25 |
| maysams | ltomasbo, digitalsimboja: +1 to all previous comments. One extra thing... does it makes sense to include the watcher component? that is the one responsible for watching | 13:36 |
| opendevreview | Merged openstack/kuryr-kubernetes master: Fixes for latest changes on Neutron devstack. https://review.opendev.org/c/openstack/kuryr-kubernetes/+/794200 | 13:43 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Added the Service Creation Flow Diagram https://review.opendev.org/c/openstack/kuryr-kubernetes/+/798064 | 13:50 |
| opendevreview | Michał Dulko proposed openstack/kuryr-kubernetes master: gracefully exit daemonserver before registry exit https://review.opendev.org/c/openstack/kuryr-kubernetes/+/698618 | 14:31 |
| opendevreview | Michał Dulko proposed openstack/kuryr-kubernetes master: gracefully exit daemonserver before registry exit https://review.opendev.org/c/openstack/kuryr-kubernetes/+/698618 | 14:38 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!