| *** tabbie_fash has joined #openstack-kuryr | 00:07 | |
| *** tabbie_fash has quit IRC | 00:15 | |
| *** gcheresh has joined #openstack-kuryr | 06:20 | |
| *** ltomasbo has joined #openstack-kuryr | 06:25 | |
| *** gcheresh has quit IRC | 07:32 | |
| *** DjeufackZane has joined #openstack-kuryr | 08:00 | |
| *** DjeufackZane has quit IRC | 09:28 | |
| *** ccamposr__ has joined #openstack-kuryr | 09:45 | |
| *** ccamposr has quit IRC | 09:48 | |
| *** gcheresh has joined #openstack-kuryr | 09:54 | |
| openstackgerrit | Kafilat Adeleke proposed openstack/kuryr-kubernetes master: Removes generate_lbaas_port_specs method https://review.opendev.org/759390 | 09:57 |
|---|---|---|
| *** gcheresh has quit IRC | 10:28 | |
| *** tabbie_fash has joined #openstack-kuryr | 10:33 | |
| *** ccamposr has joined #openstack-kuryr | 11:07 | |
| *** ccamposr__ has quit IRC | 11:09 | |
| *** takamatsu has quit IRC | 11:28 | |
| *** takamatsu has joined #openstack-kuryr | 11:32 | |
| *** takamatsu has quit IRC | 11:34 | |
| *** takamatsu has joined #openstack-kuryr | 11:35 | |
| *** rh-jelabarre has joined #openstack-kuryr | 11:59 | |
| *** gcheresh has joined #openstack-kuryr | 13:28 | |
| *** tabbie_fash has quit IRC | 13:34 | |
| *** gcheresh has quit IRC | 13:47 | |
| openstackgerrit | Kafilat Adeleke proposed openstack/kuryr-kubernetes master: Removes generate_lbaas_port_specs method https://review.opendev.org/759390 | 13:59 |
| *** tabbie_fash has joined #openstack-kuryr | 14:04 | |
| *** aghasaad04 has joined #openstack-kuryr | 14:41 | |
| maysams | Hey dulek, tabbie_fash is taking a look on this task https://bugs.launchpad.net/kuryr-kubernetes/+bug/1764783 | 14:43 |
| openstack | Launchpad bug 1764783 in kuryr-kubernetes "Split kuryr-controller and kuryr-cni ServiceAccounts" [Low,Confirmed] - Assigned to Tabitha Fasoyin (tabbie-fash) | 14:43 |
| maysams | dulek, in the last part of that bug you mentioned only the CNI SA requires root access, this means that only the kuryr-cni pod should run on hostNetwork right? | 14:44 |
| aghasaad04 | maysams can you help me push the changes to gerrit | 14:46 |
| maysams | aghasaad04: of course | 14:47 |
| maysams | aghasaad04: do you already have a gerrit account? | 14:47 |
| aghasaad04 | Yes followed this link https://docs.openstack.org/contributors/common/setup-gerrit.html | 14:48 |
| aghasaad04 | to set up the account | 14:48 |
| dulek | maysams: Uhm… Well, kuryr-controller needs to be on hostNetworking too - otherwise it won't run as there's no CNI yet. | 14:49 |
| dulek | maysams: But it shouldn't need root, but I remember having some troubles without it. We can check if it works or not now. | 14:50 |
| maysams | aghasaad04: excellent. To undo the commit pushed to your repo you could try "git revert HEAD" | 14:50 |
| maysams | aghasaad04: let me know if you now have the changes locally | 14:50 |
| aghasaad04 | Okay | 14:50 |
| dulek | maysams: The bug is mostly about splitting the API access RBAC - i.e. kuryr-cni only needs access to pods, KuryrPorts and probably nodes (SR-IOV stuff). | 14:51 |
| maysams | dulek: yeah, but on the launchpad bug it was mentioned the root privileges were needed only for the cni. | 14:54 |
| maysams | dulek: I wanted to confirm with you if the bug is only about SevicesAccount split | 14:54 |
| aghasaad04 | @may | 14:54 |
| aghasaad04 | maysams: done got those changes back | 14:55 |
| dulek | maysams: Ah, okay. So yes - we don't have OpenShift gates anymore anyway. | 14:55 |
| dulek | And it was because in OpenShift you can specify more in SA's. I think… ;) | 14:55 |
| maysams | dulek: aah ok ok :) Thanks!! | 14:58 |
| maysams | aghasaad04: excellent. Now you can do 'git review -s', if it works then 'git review' | 15:00 |
| tabbie_fash | thanks dulek, thanks maysams ;) | 15:00 |
| aghasaad04 | Uploaded file: https://uploads.kiwiirc.com/files/16ec5da8ff6152a1096f88eb2570ac68/image.png | 15:02 |
| aghasaad04 | maysams: after running git review I am getting this | 15:02 |
| dulek | aghasaad04: You need to `git commit` them first, it seems? You can see what files are hanging using `git status`. | 15:03 |
| aghasaad04 | Okay thanks | 15:03 |
| aghasaad04 | Uploaded file: https://uploads.kiwiirc.com/files/d59b85d3f0e0d1fad2aef24e7ec892d9/image.png | 15:05 |
| aghasaad04 | after reverting the already pushed changes, now I have 2 commits | 15:06 |
| aghasaad04 | Uploaded file: https://uploads.kiwiirc.com/files/f2f9df59a2d086241c5aa78a14b061b9/image.png | 15:08 |
| maysams | aghasaad04: you can try to do: 'git log', get the hash of the first commit you wanted to push, then 'git checkout <hash-of-the-commit>', then git review | 15:10 |
| aghasaad04 | still getting the same error | 15:12 |
| aghasaad04 | I have tried the hints | 15:12 |
| aghasaad04 | and run git review after that, but same results | 15:12 |
| *** takamatsu has quit IRC | 15:15 | |
| maysams | dulek: if I didn't miss any other place only the kuryrports is needed right? https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/cni/daemon/service.py#L199-L200 | 15:27 |
| maysams | dulek: for the CNI Service Account I mean | 15:27 |
| maysams | oh no nodes is needed as well | 15:33 |
| *** tabbie_fash has quit IRC | 15:37 | |
| openstackgerrit | Agha Saad Fraz proposed openstack/kuryr-kubernetes master: removed unused env variable reference https://review.opendev.org/759460 | 15:39 |
| *** DjeufackZane has joined #openstack-kuryr | 15:44 | |
| *** tabbie_fash has joined #openstack-kuryr | 15:46 | |
| *** dmellado has quit IRC | 15:46 | |
| *** dmellado has joined #openstack-kuryr | 15:47 | |
| *** takamatsu has joined #openstack-kuryr | 15:53 | |
| dulek | maysams: Yes, probably nodes due to SR-IOV stuff. | 15:53 |
| dulek | maysams: And pods, isn't it pods too? | 15:53 |
| maysams | dulek: I took a look on the code only found kuryrports and nodes | 16:08 |
| *** aghasaad04 has quit IRC | 16:33 | |
| *** ltomasbo has quit IRC | 16:36 | |
| *** maysams is now known as maysams-afk | 16:36 | |
| *** ccamposr__ has joined #openstack-kuryr | 16:49 | |
| *** DjeufackZane has quit IRC | 16:51 | |
| *** ccamposr has quit IRC | 16:57 | |
| *** tabbie_fash has quit IRC | 17:22 | |
| *** maysams-afk has quit IRC | 18:28 | |
| *** gcheresh has joined #openstack-kuryr | 19:07 | |
| *** gcheresh has quit IRC | 19:19 | |
| openstackgerrit | Merged openstack/kuryr-kubernetes master: Removes generate_lbaas_port_specs method https://review.opendev.org/759390 | 19:59 |
| *** tabbie_fash has joined #openstack-kuryr | 20:03 | |
| *** tabbie_fash has quit IRC | 20:25 | |
| *** maysams has joined #openstack-kuryr | 21:48 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
