| *** hongbin has joined #openstack-kuryr | 01:51 | |
| *** gkadam has joined #openstack-kuryr | 03:31 | |
| *** hongbin has quit IRC | 04:01 | |
| *** janki has joined #openstack-kuryr | 04:13 | |
| *** yboaron_ has joined #openstack-kuryr | 04:34 | |
| openstackgerrit | Yossi Boaron proposed openstack/kuryr-tempest-plugin master: OCP-Router - add support for OCP routes https://review.openstack.org/578310 | 04:49 |
|---|---|---|
| *** itzikb has joined #openstack-kuryr | 05:17 | |
| *** gkadam_ has joined #openstack-kuryr | 05:41 | |
| *** gkadam has quit IRC | 05:43 | |
| *** gkadam__ has joined #openstack-kuryr | 05:45 | |
| *** gkadam_ has quit IRC | 05:47 | |
| *** premsankar has quit IRC | 06:16 | |
| *** pcaruana has joined #openstack-kuryr | 06:25 | |
| openstackgerrit | Danil Golov proposed openstack/kuryr-kubernetes master: Introduce test case document for SRIOV functionality https://review.openstack.org/600022 | 06:26 |
| openstackgerrit | Merged openstack/kuryr-kubernetes master: Ensure ports pool are not duplicated with kuryr-controller HA https://review.openstack.org/593679 | 06:37 |
| openstackgerrit | Danil Golov proposed openstack/kuryr-kubernetes master: Introduce test case document for SRIOV functionality https://review.openstack.org/600022 | 06:54 |
| *** pcaruana has quit IRC | 07:36 | |
| *** pcaruana has joined #openstack-kuryr | 07:48 | |
| *** ccamposr has joined #openstack-kuryr | 08:04 | |
| *** celebdor has joined #openstack-kuryr | 08:05 | |
| *** garyloug has joined #openstack-kuryr | 08:07 | |
| openstackgerrit | Alexey Perevalov proposed openstack/kuryr-kubernetes master: Spec for vhost-user port type https://review.openstack.org/577049 | 08:08 |
| openstackgerrit | Alexey Perevalov proposed openstack/kuryr-kubernetes master: Support DPDK application on bare-metal host https://review.openstack.org/596731 | 08:09 |
| celebdor | dulek: it seems like your py3 fix failed the unit tests :-) | 08:17 |
| dulek | celebdor: Only the Python 3 ones. ;) | 08:17 |
| dulek | celebdor: Right, we're mocking requests and requests returns different stuff depending on Python version… | 08:19 |
| celebdor | dulek: it does? | 08:19 |
| celebdor | you mean bytes vs str? | 08:19 |
| dulek | celebdor: Either str or bytes. | 08:19 |
| dulek | Yup! | 08:19 |
| celebdor | or any other difference? | 08:19 |
| celebdor | ok | 08:19 |
| celebdor | Does it adhere to the standard that if you give it the argument in bytes it returns bytes | 08:20 |
| dulek | celebdor: Nah, I think that's it. | 08:20 |
| celebdor | and if you pass it in str it returns str? | 08:20 |
| celebdor | ah | 08:20 |
| dulek | celebdor: Hm, dunno really. | 08:20 |
| celebdor | I'll check | 08:20 |
| dulek | Maybe there's some testing harness in there, so we won't be mocking lib's behavior… | 08:21 |
| celebdor | dulek: I think it always returns bytes | 08:22 |
| dulek | celebdor: Yay, requests-mock is in global requirements. | 08:22 |
| dulek | celebdor: "AttributeError: 'str' object has no attribute 'decode'"? | 08:22 |
| celebdor | from what I can see in my python3 ipython session, I'm always getting bytes | 08:23 |
| dulek | celebdor: Ah, right. We're mocking this as an str. | 08:25 |
| celebdor | :-) | 08:27 |
| dulek | Awww, I really don't want to do "if six.PY2" in unit tests… | 08:29 |
| openstackgerrit | Alexey Perevalov proposed openstack/kuryr-kubernetes master: Spec for vhost-user port type https://review.openstack.org/577049 | 08:32 |
| danil | hello, folks. Please, review - https://review.openstack.org/#/c/591352/9 | 08:40 |
| dmellado | danil: sure, added it to my today's review queue | 08:49 |
| dmellado | thanks! | 08:49 |
| danil | dmellado: thanks a lot | 08:49 |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: Implement NP SG create/delete actions https://review.openstack.org/583540 | 08:52 |
| openstackgerrit | Michał Dulko proposed openstack/kuryr-kubernetes master: Fix Python 3 compatiblity in K8sClient.watch() https://review.openstack.org/600116 | 09:39 |
| *** garyloug has quit IRC | 10:34 | |
| *** garyloug has joined #openstack-kuryr | 10:34 | |
| *** garyloug has quit IRC | 11:23 | |
| openstackgerrit | Danil Golov proposed openstack/kuryr-kubernetes master: Add HOWTO for SRIOV use case https://review.openstack.org/594125 | 11:31 |
| openstackgerrit | Danil Golov proposed openstack/kuryr-kubernetes master: Introduce test case document for SRIOV functionality https://review.openstack.org/600022 | 11:31 |
| *** rh-jelabarre has joined #openstack-kuryr | 11:38 | |
| dulek | yboaron_: Can you elaborate on your inline comment in https://review.openstack.org/#/c/600142/1/kuryr_kubernetes/watcher.py ? | 11:46 |
| dulek | yboaron_: I don't think I get it. :) | 11:46 |
| yboaron_ | dulek, lemme check it, one sec | 11:47 |
| yboaron_ | dulek, If understood correctly, the root cause was that watched path was in 'self._watching' although watcher is not running anymore, and watcher restarts we didn't run it because of the if statement in line#99, is it correct? | 11:50 |
| yboaron_ | dulek, I thought maybe we should consider also to 'customize' the if statement at line#99, in addition to the fix that you are suggesting, does it make sense? | 11:52 |
| dulek | yboaron_: Uhm, no. It wasn't restarting due to statement in line 124. | 11:52 |
| dulek | yboaron_: Hm, that might make sense if we can reliably check greenlet status. Lemme check this. | 11:53 |
| dulek | yboaron_: Nope, looks like it's impossible: http://eventlet.net/doc/modules/greenthread.html#eventlet.greenthread.GreenThread | 11:54 |
| dulek | yboaron_: So we're unable to tell if GreenThread is running or not. | 11:54 |
| dulek | yboaron_: Basically what I've fixed in the patch is to clean up after killing a GreenThread. | 11:54 |
| dulek | yboaron_: If the GreenThread will die due to exception - finally clause in _watch() will clean up. | 11:55 |
| dulek | yboaron_: So we should be covered. | 11:55 |
| yboaron_ | dulek, so if it's impossible to check thread status, we should stick with this fix. if we could verify also thread status that was more robust | 11:55 |
| dulek | yboaron_: I agree, though I still believe this code needs a rewrite. It's simply awful. | 11:56 |
| yboaron_ | dulek, Yep! , 10x! | 11:56 |
| openstackgerrit | Merged openstack/kuryr-kubernetes master: Add experimental check for NPWG multi-vif driver https://review.openstack.org/593062 | 12:05 |
| openstackgerrit | Itzik Brown proposed openstack/kuryr-tempest-plugin master: Check that kuryr-cni runs as a daemon https://review.openstack.org/596564 | 12:05 |
| openstackgerrit | Michał Dulko proposed openstack/kuryr-kubernetes master: Clean up watch resources after watcher.stop() https://review.openstack.org/600142 | 12:12 |
| *** rh-jelabarre has quit IRC | 12:14 | |
| *** yboaron_ has quit IRC | 12:32 | |
| *** yboaron_ has joined #openstack-kuryr | 12:32 | |
| *** yboaron_ has quit IRC | 13:14 | |
| *** yboaron has joined #openstack-kuryr | 13:15 | |
| *** garyloug has joined #openstack-kuryr | 13:18 | |
| openstackgerrit | Itzik Brown proposed openstack/kuryr-tempest-plugin master: Add test_pod_pod_ping_same_node test https://review.openstack.org/600443 | 13:19 |
| *** garyloug has quit IRC | 13:23 | |
| *** garyloug has joined #openstack-kuryr | 13:24 | |
| *** yboaron_ has joined #openstack-kuryr | 13:49 | |
| *** yboaron has quit IRC | 13:52 | |
| *** rh-jelabarre has joined #openstack-kuryr | 13:53 | |
| openstackgerrit | Itzik Brown proposed openstack/kuryr-tempest-plugin master: Add test_pod_pod_ping_same_node test https://review.openstack.org/600443 | 13:58 |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: Implement NP SG create/delete actions https://review.openstack.org/583540 | 14:10 |
| *** itzikb has quit IRC | 14:29 | |
| *** yboaron_ has quit IRC | 14:43 | |
| *** celebdor has quit IRC | 15:00 | |
| *** janki has quit IRC | 15:04 | |
| *** pcaruana has quit IRC | 15:42 | |
| *** pcaruana has joined #openstack-kuryr | 16:01 | |
| *** ccamposr has quit IRC | 16:51 | |
| *** gkadam__ has quit IRC | 17:09 | |
| *** garyloug_ has joined #openstack-kuryr | 17:16 | |
| *** ChanServ sets mode: -rf | 17:16 | |
| *** garyloug has quit IRC | 17:17 | |
| *** pcaruana has quit IRC | 17:27 | |
| *** irenab has quit IRC | 17:47 | |
| *** irenab has joined #openstack-kuryr | 17:50 | |
| *** pcaruana has joined #openstack-kuryr | 18:02 | |
| *** openstackgerrit has quit IRC | 18:05 | |
| *** pcaruana has quit IRC | 19:35 | |
| *** dims has quit IRC | 20:55 | |
| *** rh-jelabarre has quit IRC | 21:02 | |
| *** dims has joined #openstack-kuryr | 21:11 | |
| *** garyloug_ has quit IRC | 23:06 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!