| *** livelace has quit IRC | 00:30 | |
| *** livelace has joined #openstack-kuryr | 00:30 | |
| *** hongbin has joined #openstack-kuryr | 00:41 | |
| *** rh-jelabarre has quit IRC | 01:53 | |
| *** threestrands has quit IRC | 02:10 | |
| *** phuoc_ has quit IRC | 02:21 | |
| *** phuoc has joined #openstack-kuryr | 02:22 | |
| *** hongbin has quit IRC | 03:17 | |
| *** threestrands has joined #openstack-kuryr | 03:26 | |
| *** threestrands has quit IRC | 03:26 | |
| *** threestrands has joined #openstack-kuryr | 03:26 | |
| *** phuoc has quit IRC | 03:31 | |
| *** phuoc has joined #openstack-kuryr | 03:32 | |
| *** trinaths has joined #openstack-kuryr | 04:05 | |
| *** shadower has quit IRC | 04:06 | |
| *** trinaths has quit IRC | 04:09 | |
| *** phuoc has quit IRC | 04:16 | |
| *** phuoc has joined #openstack-kuryr | 04:17 | |
| *** shadower has joined #openstack-kuryr | 04:21 | |
| *** janki has joined #openstack-kuryr | 04:50 | |
| *** trinaths has joined #openstack-kuryr | 04:55 | |
| *** phuoc has quit IRC | 05:08 | |
| *** phuoc has joined #openstack-kuryr | 05:08 | |
| *** itzikb has joined #openstack-kuryr | 05:34 | |
| *** trinaths has quit IRC | 06:15 | |
| *** trinaths has joined #openstack-kuryr | 06:21 | |
| *** phuoc has quit IRC | 06:26 | |
| *** phuoc has joined #openstack-kuryr | 06:27 | |
| *** phuoc_ has joined #openstack-kuryr | 06:34 | |
| *** pcaruana has joined #openstack-kuryr | 06:37 | |
| *** phuoc has quit IRC | 06:37 | |
| *** gcheresh has joined #openstack-kuryr | 06:45 | |
| *** pmannidi has quit IRC | 07:18 | |
| *** yboaron has joined #openstack-kuryr | 07:32 | |
| *** janki has quit IRC | 07:38 | |
| *** janki has joined #openstack-kuryr | 07:42 | |
| *** threestrands has quit IRC | 07:45 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Ensure isolation between namespaces https://review.openstack.org/579181 | 07:51 |
|---|---|---|
| *** threestrands has joined #openstack-kuryr | 08:00 | |
| *** threestrands has quit IRC | 08:03 | |
| *** garyloug has joined #openstack-kuryr | 08:05 | |
| openstackgerrit | Yossi Boaron proposed openstack/kuryr-tempest-plugin master: OCP-Router - add support for OCP routes https://review.openstack.org/578310 | 09:22 |
| apuimedo | dulek: ping | 09:40 |
| dulek | apuimedo: What's up? | 09:40 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Add namespace isolation for services https://review.openstack.org/581421 | 09:40 |
| apuimedo | dulek: how's the thing with checking the backend pods of a service? | 09:42 |
| dulek | apuimedo: This one https://review.openstack.org/#/c/583200 ? I'm currently looking at it closer. | 09:42 |
| dulek | apuimedo: I wonder why yboaron added timeout there instead of waiting for the pod to be Running. | 09:44 |
| apuimedo | yboaron: thoughts? | 09:44 |
| dulek | apuimedo: Ah, because we're already waiting: https://github.com/openstack/kuryr-tempest-plugin/blob/d7a6bf92e6feebca7da5f419cb70fe9b7055841c/kuryr_tempest_plugin/tests/scenario/base.py#L85-L88 | 09:44 |
| dulek | apuimedo: So IMO the issue is elsewhere. If pod's Running, then it should answer. | 09:44 |
| apuimedo | dulek: and it does not in the gates only? | 09:45 |
| dulek | apuimedo: Never seen this on my env. I'll dig this further. | 09:46 |
| yboaron | apuimedo, there's the pod and the Octavia in the service or ocp-route case | 09:46 |
| apuimedo | yboaron: ? | 09:47 |
| *** trinaths has quit IRC | 09:48 | |
| yboaron | apuimedo, I deleted the delay in https://review.openstack.org/#/c/583200/, just add code that will verify that EP was annotated with Octavia configuration | 09:48 |
| dulek | yboaron: Ah, you mean Pod may be running, but Octavia's slow with creating members. | 09:48 |
| yboaron | apuimedo, means that Octavia also configured withe pool/member atc | 09:49 |
| apuimedo | yboaron: so now with this change it works? | 09:49 |
| yboaron | apuimedo, yes | 09:49 |
| apuimedo | so let's merge this | 09:49 |
| yboaron | apuimedo, service tests are OK | 09:49 |
| apuimedo | it is blocking other tests | 09:49 |
| apuimedo | yboaron: one thing though | 09:50 |
| apuimedo | when are we annotating the service, before or after we have processed the members? | 09:50 |
| yboaron | apuimedo, after | 09:51 |
| *** trinaths has joined #openstack-kuryr | 09:51 | |
| apuimedo | so then it should be enough to check that annotation, shouldn't it? | 09:51 |
| dulek | yboaron: Awww, I was looking at PS7 there! Thanks for noticing! | 09:51 |
| yboaron | apuimedo, I mean for the basic create flow, it won't work for edit service case | 09:51 |
| yboaron | apuimedo, dulek : +1 for merging https://review.openstack.org/#/c/583200/ | 09:52 |
| dulek | dmellado, irenab, can you look at https://review.openstack.org/#/c/583200/. I don't want to approve my own patch, though I agree with yboaron changes there. | 09:53 |
| yboaron | dulek, apuimedo : 10x! | 09:54 |
| *** yboaron has quit IRC | 09:57 | |
| dmellado | dulek: sure, let me take a look | 10:00 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Add namespace isolation for services https://review.openstack.org/581421 | 10:06 |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: [WIP] [DNM] Implement NP driver actions https://review.openstack.org/583540 | 10:06 |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: [WIP] [DNM] Implement NP driver actions https://review.openstack.org/583540 | 10:19 |
| irenab | dulek, done | 10:35 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Ensure isolation between namespaces https://review.openstack.org/579181 | 10:47 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Add namespace isolation for services https://review.openstack.org/581421 | 10:52 |
| *** tzumainn has joined #openstack-kuryr | 10:57 | |
| ltomasbo | dulek, I re-shape https://review.openstack.org/#/c/579181/ based on your comment | 11:00 |
| ltomasbo | dulek, I'm stacking to test if behavior is still the same :D | 11:00 |
| *** garyloug_ has joined #openstack-kuryr | 11:09 | |
| *** garyloug has quit IRC | 11:09 | |
| *** rh-jelabarre has joined #openstack-kuryr | 11:22 | |
| dulek | ltomasbo: Thanks, I'll take a look! | 11:23 |
| ltomasbo | dulek, thanks! | 11:24 |
| openstackgerrit | Peng Liu proposed openstack/kuryr-kubernetes master: Implement multi-vif driver https://review.openstack.org/575629 | 11:29 |
| *** garyloug_ has quit IRC | 11:30 | |
| openstackgerrit | Peng Liu proposed openstack/kuryr-kubernetes master: Implement multi-vif driver https://review.openstack.org/575629 | 11:32 |
| *** apuimedo has quit IRC | 11:42 | |
| openstackgerrit | Merged openstack/kuryr-tempest-plugin master: Get rid of cmp() usage and randomize pod labels https://review.openstack.org/583200 | 11:45 |
| *** garyloug has joined #openstack-kuryr | 11:51 | |
| *** yboaron has joined #openstack-kuryr | 12:01 | |
| *** garyloug has quit IRC | 12:11 | |
| *** trinaths has quit IRC | 12:22 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Add namespace isolation for services https://review.openstack.org/581421 | 12:35 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Ensure isolation between namespaces https://review.openstack.org/579181 | 12:37 |
| *** itzikb has quit IRC | 12:54 | |
| yboaron | celebdor[m], dulek : highly appreciate If u can review https://review.openstack.org/#/c/578310/ | 13:01 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Ensure isolation between namespaces https://review.openstack.org/579181 | 13:05 |
| *** garyloug has joined #openstack-kuryr | 13:06 | |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: [WIP] [DNM] Implement NP driver actions https://review.openstack.org/583540 | 13:08 |
| *** devvesa has joined #openstack-kuryr | 13:15 | |
| *** devvesa has left #openstack-kuryr | 13:16 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Add namespace isolation for services https://review.openstack.org/581421 | 13:20 |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: [WIP] [DNM] Implement NP driver actions https://review.openstack.org/583540 | 13:26 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-tempest-plugin master: Namespace isolation tempest coverage https://review.openstack.org/580678 | 13:41 |
| dmellado | garyloug: pliu folks, I sent an email to the ML TL;DR next week's VC | 14:15 |
| dmellado | so let's talk about the multi-vif patches there ;) | 14:15 |
| *** gcheresh has quit IRC | 14:16 | |
| pliu | dmellado, great | 14:16 |
| *** hongbin_ has joined #openstack-kuryr | 14:18 | |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: [WIP] [DNM] Implement NP driver actions https://review.openstack.org/583540 | 14:38 |
| *** pcaruana has quit IRC | 15:10 | |
| *** trinaths has joined #openstack-kuryr | 15:13 | |
| ltomasbo | yboaron, do you know how common is to modify a svc? for instance to change the ports to listener (that will trigger a creation of a new listener) | 15:15 |
| yboaron | ltomasbo, well it's possible and we need to support it , IMO is should be rarely | 15:17 |
| ltomasbo | yboaron, ok, so I think we have a bug then... | 15:18 |
| ltomasbo | dulek, celebdor[m] ^^ | 15:18 |
| ltomasbo | yboaron, the member is not re-added after modification | 15:18 |
| yboaron | ltomasbo, we had a bug there , with the svc port edit case | 15:18 |
| ltomasbo | yboaron, ahh, yes, that is what I was testing | 15:19 |
| ltomasbo | so, it is already known... | 15:19 |
| ltomasbo | everything seems to be fine, except the member is not added | 15:19 |
| yboaron | ltomasbo, what use case did us run ? | 15:20 |
| ltomasbo | yboaron, what is the bug you referred to? | 15:20 |
| ltomasbo | yboaron, I simple did: oc edit svc demo | 15:20 |
| ltomasbo | and modify the port 80 by 8080 | 15:20 |
| ltomasbo | to change the listener | 15:20 |
| yboaron | ltomasbo, searching for it | 15:20 |
| ltomasbo | yboaron, I thought it was my namespace thing, but it happened to me in an env without the isolation... :D | 15:22 |
| yboaron | ltomasbo, https://bugs.launchpad.net/kuryr-kubernetes/+bug/1684096 | 15:23 |
| openstack | Launchpad bug 1684096 in kuryr-kubernetes "When a service is updated with new listener port a new listener is added to the LB instead of listener update" [Medium,Fix released] - Assigned to Yossi Boaron (yossi-boaron-1234) | 15:23 |
| ltomasbo | yboaron, thanks! | 15:23 |
| yboaron | ltomasbo, I fixed this one | 15:23 |
| ltomasbo | umm | 15:24 |
| ltomasbo | I see that the new listener and pool is there | 15:24 |
| ltomasbo | but the members are not re-added | 15:24 |
| ltomasbo | not sure if it is related | 15:25 |
| yboaron | ltomasbo, could u check it with edit port from 80 to 200 (!= 8080) ? | 15:26 |
| ltomasbo | ok, let me see | 15:26 |
| ltomasbo | yboaron, same result | 15:36 |
| ltomasbo | member is not added | 15:36 |
| yboaron | ltomasbo, OK, 10x! | 15:36 |
| ltomasbo | yboaron, function _add_new_members is not really easy to follow... | 15:37 |
| yboaron | ltomasbo, I"ll try to look at it later before I'm leaving to PTO | 15:37 |
| ltomasbo | yboaron, today is your last day? | 15:37 |
| yboaron | ltomasbo, yep | 15:37 |
| ltomasbo | I can try to take a look! if you have other things to look at, don't worry | 15:37 |
| ltomasbo | (and enjoy your PTO!!!) | 15:38 |
| yboaron | ltomasbo, NP, I"ll give and try and inform u | 15:38 |
| ltomasbo | thanks! | 15:38 |
| *** AlexeyPerevalov has joined #openstack-kuryr | 15:44 | |
| *** trinaths has quit IRC | 16:09 | |
| ltomasbo | yboaron, problem is that members are on current_targets | 16:14 |
| ltomasbo | and therefore the member addition is skip | 16:15 |
| *** garyloug has quit IRC | 17:46 | |
| *** garyloug has joined #openstack-kuryr | 17:47 | |
| openstackgerrit | Yossi Boaron proposed openstack/kuryr-kubernetes master: Services: Fix service connectivity after service port edit procedure https://review.openstack.org/587565 | 17:48 |
| openstackgerrit | Yossi Boaron proposed openstack/kuryr-tempest-plugin master: OCP-Router - add support for OCP routes https://review.openstack.org/578310 | 18:00 |
| *** celebdor has joined #openstack-kuryr | 18:15 | |
| celebdor | 1 | 18:16 |
| celebdor | 1 | 18:16 |
| celebdor | 1 | 18:16 |
| *** celebdor has quit IRC | 18:18 | |
| *** celebdor has joined #openstack-kuryr | 18:19 | |
| *** celebdor has quit IRC | 18:20 | |
| *** celebdor has joined #openstack-kuryr | 18:23 | |
| *** celebdor has quit IRC | 18:28 | |
| *** celebdor has joined #openstack-kuryr | 18:32 | |
| *** janki has quit IRC | 20:51 | |
| *** livelace has quit IRC | 21:03 | |
| *** livelace has joined #openstack-kuryr | 21:04 | |
| *** yboaron has quit IRC | 21:48 | |
| *** garyloug has quit IRC | 22:16 | |
| *** celebdor has quit IRC | 22:27 | |
| *** hongbin_ has quit IRC | 23:00 | |
| *** pmannidi has joined #openstack-kuryr | 23:21 | |
| *** threestrands has joined #openstack-kuryr | 23:24 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!