Tuesday, 2018-07-03

*** threestrands_ has joined #openstack-kuryr00:07
*** threestrands_ has quit IRC00:07
*** threestrands_ has joined #openstack-kuryr00:07
*** threestrands_ has quit IRC00:08
*** threestrands_ has joined #openstack-kuryr00:09
*** threestrands_ has quit IRC00:09
*** threestrands_ has joined #openstack-kuryr00:09
*** threestrands has quit IRC00:10
*** threestrands_ has quit IRC00:10
*** threestrands_ has joined #openstack-kuryr00:10
*** threestrands_ has quit IRC00:11
*** threestrands_ has joined #openstack-kuryr00:12
*** threestrands_ has quit IRC00:13
*** threestrands_ has joined #openstack-kuryr00:13
*** threestrands_ has quit IRC00:13
*** threestrands_ has joined #openstack-kuryr00:13
*** threestrands_ has quit IRC00:14
*** threestrands_ has joined #openstack-kuryr00:15
*** threestrands_ has quit IRC00:15
*** threestrands_ has joined #openstack-kuryr00:15
*** threestrands_ has quit IRC00:16
*** threestrands_ has joined #openstack-kuryr00:16
*** hongbin has joined #openstack-kuryr00:57
*** phuoc_ has joined #openstack-kuryr01:16
*** phuoc has quit IRC01:19
*** hongbin has quit IRC04:07
*** threestrands_ has quit IRC04:25
*** itzikb|afk has joined #openstack-kuryr05:04
*** pmannidi has quit IRC05:37
*** janki has joined #openstack-kuryr05:51
snapiriGood morning. Anyone has an idea if this might still be worth adding? https://review.openstack.org/#/c/552464/05:54
*** vpc has joined #openstack-kuryr06:04
vpchi06:04
vpcguys06:04
vpc?06:04
*** yboaron has joined #openstack-kuryr06:46
*** openstackgerrit has quit IRC06:49
*** AlexeyPerevalov has joined #openstack-kuryr07:04
*** gcheresh_ has joined #openstack-kuryr07:15
*** yboaron has quit IRC07:31
*** irenab has quit IRC07:39
*** oanson has quit IRC07:39
*** lihi has quit IRC07:39
*** irenab has joined #openstack-kuryr07:40
*** oanson has joined #openstack-kuryr07:41
*** lihi has joined #openstack-kuryr07:41
*** celebdor1 has joined #openstack-kuryr07:56
*** vpc has quit IRC08:04
*** garyloug has joined #openstack-kuryr08:15
duleksnapiri: I would love to try it if it's functional. I remember there were issues that Octavia's DevStack plugin wasn't supporting it.08:26
*** celebdor1 has quit IRC08:27
*** celebdor1 has joined #openstack-kuryr08:29
*** openstackgerrit has joined #openstack-kuryr08:31
openstackgerritItzik Brown proposed openstack/kuryr-kubernetes master: Adding kuryr-kubernetes-tempest-containerized-octavia job  https://review.openstack.org/57980808:31
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: devstack support for openshift-dns  https://review.openstack.org/57920308:42
*** yboaron has joined #openstack-kuryr08:43
*** kiennt26 has joined #openstack-kuryr09:03
snapiridulek: I will convert it and see how the gate handles it, that would be the easiest way09:04
duleksnapiri: I totally agree with that, no need to bury through git logs.09:04
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: [WIP] Ensure isolation between namespaces  https://review.openstack.org/57918109:17
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: [WIP] Ensure isolation between namespaces  https://review.openstack.org/57918109:19
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: [WIP] Ensure isolation between namespaces  https://review.openstack.org/57918109:20
celebdor1dulek: any recommended yaml parser for bash?09:23
celebdor1or do you suggest to just sed?09:23
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: devstack support for openshift-dns  https://review.openstack.org/57920309:26
dulekcelebdor1: Ah, okay, you're adding options to the already existing ones.09:27
dulekcelebdor1: But why? Why don't just copy an ordinary precreated file there?09:27
celebdor1dulek: cause I don't want to suppose this file does not change between releases09:29
celebdor1it's an insurance policy against headaches when we bump up the version09:29
celebdor1we'll only have problems if our specific dns settings change09:29
celebdor1otherwise we'll be fine09:29
dulekcelebdor1: Oh, that's editing OpenShift's node config!09:32
celebdor1yes09:32
celebdor1which is written in a quite opaque way in openshift node start09:32
dulekcelebdor1: And you want to edit instead of appending to the file as those options may already be set.09:32
celebdor1exactly09:32
dulekSo IMO sed would be more readable, but as you've said we don't know if file won't change.09:33
dulekSo yeah, I'm fine with that.09:33
celebdor1and we don't know if the options are there or not09:34
celebdor1so I'd have to sed each if they are there09:34
celebdor1or rather, first remove them all, then set them09:34
celebdor1but I think this is more robust09:34
*** garyloug has quit IRC09:35
openstackgerritShachar Snapiri proposed openstack/kuryr-kubernetes master: Replace q-* for neutron-*  https://review.openstack.org/55246409:35
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Move multinode gate to check pipeline  https://review.openstack.org/57982909:38
*** celebdor1 has quit IRC09:48
openstackgerritItzik Brown proposed openstack/kuryr-kubernetes master: [Do not merge] - Running tests in serial  https://review.openstack.org/57983209:54
openstackgerritItzik Brown proposed openstack/kuryr-tempest-plugin master: dummy - DO NOT MERGE Depends-On: I9302d8366a52127bec174ff8efee34a8206356be  https://review.openstack.org/57983309:56
*** garyloug has joined #openstack-kuryr09:59
yboaronltomasbo, FYI : https://review.openstack.org/#/c/579559/ is about to be merged ...10:22
ltomasboyboaron, I was trying to test if that was working...10:22
ltomasboI meant if it fixes the issue10:22
yboaronltomasbo,  me2 , but nmagnezi was fast :-)10:23
ltomasboxD10:23
*** AlexeyPerevalov has quit IRC10:23
dulekyboaron, ltomasbo: Silly one - does this affect stable/queens?10:25
ltomasboyes10:26
yboarondulek, Yep, it should be backported also to Octavia queens, although we didn't change the create/find order in queens10:27
dulekyboaron: Ah, so it's not happening on stable/queens if both Octavia and Kuryr is like that.10:28
yboarondulek, ltomasbo managed to reach to this case with Kuryr-Queens code10:29
dulekyboaron: Okay, noted!10:30
yboarondulek, it should be backported to Octavia queens - take a look at https://storyboard.openstack.org/#!/story/200194410:31
*** celebdor1 has joined #openstack-kuryr10:32
ltomasbodulek, yboaron: regarding this: https://review.openstack.org/#/c/579144/5/kuryr_kubernetes/controller/drivers/lbaasv2.py10:39
ltomasboI don't really get your first comment yossi, get_vip_port_id is already querying neutron for that10:39
*** kiennt26 has quit IRC10:39
ltomasboand regarding the comment about the return none at line 30010:39
ltomasboI see that is what is being done for the previous case when the id or provider info is missing10:40
ltomasboso I just followed the same behavior, but it may be that some case is affected by that, I'm not quite sure10:40
* dulek is just feeling that LBaaS code is a bit spaghetti-like.10:42
dulekAnd so the side effects of changes are pretty hard to understand.10:42
dulekSo if yboaron tells me that code will work, I'll just trust him.10:42
openstackgerritItzik Brown proposed openstack/kuryr-tempest-plugin master: dummy - DO NOT MERGE  https://review.openstack.org/57983310:43
celebdor1ltomasbo: I addressed irenab 's comments to your patch10:45
celebdor1and created a blueprint for it10:45
celebdor1ltomasbo: I would appreciate if you could try https://review.openstack.org/#/c/579203/10:46
yboaronltomasbo, with the previous order, we call _find function when we got the conflict exception --> means LB exist10:46
yboaronltomasbo, after we changed the create/find order  _find function will be called also if LB doesn't exist10:47
ltomasbocelebdor1, what patch? the PoC for sg ones?10:48
celebdor1ltomasbo: your project namespace isolation one10:48
ltomasboyep, I'm stacking to test that one now10:49
celebdor1I addressed irenab's comments there10:49
yboaronltomasbo, but anyhow we can drop this piece of code after Octavia patch will be merged10:49
ltomasboI got some problems with the devstack plugin.sh...10:49
celebdor1and then I referred to my openshift-dns patch10:49
celebdor1that has a +2 from dulek10:49
ltomasbook!10:50
dulekyboaron: We can't drop it until we backport it.10:50
*** rh-jelabarre has quit IRC10:51
yboarondulek, Haaa, Yep , you are correct10:51
yboarondulek, u r right10:52
openstackgerritDaniel Mellado proposed openstack/kuryr-tempest-plugin master: Sync zuul projects with kuryr-kubernetes  https://review.openstack.org/57984110:54
ltomasbocelebdor1, btw, did you have time to take a look at that patch? the namespace isolation one10:59
ltomasbocelebdor1, besides the missing testing and such, do you think it is ok-ish and isolated enough from the rest of the code10:59
openstackgerritItzik Brown proposed openstack/kuryr-tempest-plugin master: dummy - DO NOT MERGE  https://review.openstack.org/57983311:00
celebdor1ltomasbo: I'll look now again11:01
celebdor1ltomasbo: you did it in a way I really did not expect :P11:13
celebdor1but it works out, so far11:14
celebdor1didn't finish the review yet11:14
*** aojea_ has joined #openstack-kuryr11:37
*** itzikb|afk is now known as itzikb11:37
*** yboaron has quit IRC11:43
celebdor1dulek: thanks for pointing the bidning address already in use11:46
celebdor1dmellado: do you know what they may have in the gates that takes port 53?11:46
celebdor1do they already put some dnsmasq there?11:46
dulekcelebdor1: No problem, I love easy debugging.11:52
*** yboaron has joined #openstack-kuryr11:52
dulekcelebdor1: Hm, I don't know but let's try to find out while my lunch cools off to edible temperature. :)11:53
celebdor1well, I can't really imagine anything else than they run dnsmasq or something like that on the nodes11:55
celebdor1cause in my baremetal server I didn't hit this11:56
celebdor1and dnsmasq probably started fine11:56
celebdor1so they are not binding to localhost11:56
dmelladocelebdor1: maybe a dns?11:56
dulekcelebdor1: http://logs.openstack.org/03/579203/12/check/kuryr-kubernetes-tempest-daemon-openshift-octavia/292251a/controller/logs/dpkg-l.txt.gz11:56
dulekcelebdor1: dnsmasq is definitely installed.11:56
dulekcelebdor1: And seems like we have some logs: http://logs.openstack.org/03/579203/12/check/kuryr-kubernetes-tempest-daemon-openshift-octavia/292251a/controller/logs/listen53.txt.gz11:57
*** yboaron has quit IRC11:57
celebdor1dulek: it is unbound11:58
celebdor1most likely11:58
celebdor1dnsmasq I install11:58
celebdor1udp    UNCONN     0      0      127.0.0.1:53                    *:*                   users:(("unbound",pid=3270,fd=5))11:58
dulekcelebdor1: http://logs.openstack.org/03/579203/12/check/kuryr-kubernetes-tempest-daemon-openshift-octavia/292251a/controller/logs/unbound_log.txt - here's unbound logs. Whatever that is. :P11:59
dulekcelebdor1: http://logs.openstack.org/03/579203/12/check/kuryr-kubernetes-tempest-daemon-openshift-octavia/292251a/controller/logs/devstacklog.txt.gz#_2018-07-03_10_24_56_676 - this lists dnsmasq-base being installed by DevStack, but that shouldn't include the server, right?12:00
*** aojea_ has quit IRC12:00
celebdor1dulek: unbound is a simpler alternative to bind12:00
celebdor1I use it at home12:00
celebdor1dulek: dnsmasq is installed by both neutron and kuryr12:00
celebdor1for serving12:00
celebdor1neutron in namespaces12:01
dulekcelebdor1: Yup, that's what I see.12:01
dulekhttp://logs.openstack.org/03/579203/12/check/kuryr-kubernetes-tempest-daemon-openshift-octavia/292251a/controller/logs/devstacklog.txt.gz#_2018-07-03_10_37_37_99312:01
celebdor1kuryr in any address except the loopback one12:01
dulekIt even looks like DevStack is assuming it is running.12:01
celebdor1what I would like to know is why the fuck12:01
celebdor1do they use unbound on loopback12:01
* dulek checks if lunch is edible now.12:01
celebdor1fuck it12:04
celebdor1I'll use 127.0.0.212:04
celebdor1sorry12:04
celebdor1127.0.0.1112:05
*** janki has quit IRC12:06
snapiridulek: I need help here, not sure I understand where this issue comes from. Would appreciate if you could take a look: http://logs.openstack.org/64/552464/9/check/kuryr-kubernetes-tempest-daemon-containerized-ovn/2b8152c/job-output.txt.gz#_2018-07-03_11_00_03_16612612:06
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: devstack support for openshift-dns  https://review.openstack.org/57920312:15
openstackgerritItzik Brown proposed openstack/kuryr-kubernetes master: [Do not merge] - Running tests in serial  https://review.openstack.org/57983212:22
openstackgerritShachar Snapiri proposed openstack/kuryr-kubernetes master: Replace q-* for neutron-*  https://review.openstack.org/55246412:23
snapiridulek: I found the issue, but I doubt if my fix is correct. do you have a minute for consulting? :)12:30
duleksnapiri: Yeah, though I'm in different IRC meeting, so responses can be delayed.12:30
duleksnapiri: Isn't it some extension missing?12:30
snapiriyes it is. the missing extension is 'router'12:31
snapiridulek: so I added back the neutron-l3, I am not sure it is correct12:32
*** aojea has joined #openstack-kuryr12:32
snapiridulek: as the 'router' extension does not exist, the router is not created and thus we do not find it.12:32
*** maysamacedos has joined #openstack-kuryr12:33
*** yamamoto_ has quit IRC12:37
duleksnapiri: Hm, had you checked that adding neutron-l3 will enable it?12:39
* dulek checks…12:39
duleksnapiri: https://github.com/openstack-dev/devstack/search?q=%22is_service_enabled+neutron-l3%22&unscoped_q=%22is_service_enabled+neutron-l3%22 - not much depending on that.12:39
*** yboaron has joined #openstack-kuryr12:49
snapiridulek: have not checked... hope for the best12:50
duleksnapiri: Okay, looks like it'll help: https://github.com/openstack-dev/devstack/blob/e63859362487856f1f53c173909cb8aa3bb55bab/lib/neutron#L25412:51
duleksnapiri: But is that correct with OVN? ltomasbo?12:52
openstackgerritEmilio Garcia proposed openstack/kuryr-kubernetes master: Test Objects Module  https://review.openstack.org/57985712:53
*** itzikb has quit IRC12:53
*** yamamoto has joined #openstack-kuryr12:53
snapiriltomasbo, dulek: this was my doubt, if it is the correct solution for this case. If it is not, we can wrap the failing code with the same condition, but I fear it will have major consequences...12:54
*** yboaron has quit IRC12:55
ltomasboperhaps you need to check what they enable on the ovn gates12:56
ltomasboI don't think we should use neutron-l3, but the ovn provided one, right?12:56
ltomasbo(but that error sounds familiar)12:56
*** yamamoto has quit IRC12:58
*** celebdor1 has quit IRC13:00
duleksnapiri: I guess it would be better to add "router" to service_plugins manually.13:03
*** janki has joined #openstack-kuryr13:03
*** aojea has quit IRC13:06
openstackgerritMerged openstack/kuryr-tempest-plugin master: Sync zuul projects with kuryr-kubernetes  https://review.openstack.org/57984113:08
*** yamamoto has joined #openstack-kuryr13:08
snapiridulek: any way to do that via the zuul configuration or should I add it to the plugin.sh?13:10
duleksnapiri: I'm afraid it's impossible to do in Zuul, but let's ask dmellado as I think he was fighting with that once.13:11
dmelladodmellado in a meeting, wha'ts up?13:12
dulekdmellado: Let's discuss it after the meeting.13:12
*** yamamoto has quit IRC13:13
openstackgerritEmilio Garcia proposed openstack/kuryr-kubernetes master: Test Objects Module  https://review.openstack.org/57985713:21
*** rh-jelabarre has joined #openstack-kuryr13:21
*** yamamoto has joined #openstack-kuryr13:23
*** hongbin has joined #openstack-kuryr13:25
*** janki has quit IRC13:26
*** yamamoto has quit IRC13:28
*** yamamoto has joined #openstack-kuryr13:41
*** yamamoto has quit IRC13:41
snapiridulek: I see it can be done in the override-defaults phase, but I am not sure what the condition for enabling the plugin should be...13:42
*** janki has joined #openstack-kuryr13:46
duleksnapiri: is_service_enabled ovn-controller?13:49
dulekdmellado: The issue we have is that with non-legacy Neutron DevStack plugin we don't get router service_plugin enabled automatically in Neutron.13:50
dulekdmellado: It gets enabled only with neutron-l3 service, which we disable on ovn gates.13:50
dmelladoIIRC there was some issues on devstack/neutron-legacy stuff not having been fully migrated to devstack/neutron13:50
dulekdmellado: So the question is - how do I overwrite this in .zuul.yaml?13:51
dmelladoso you mean adding router service_plugin?13:52
dmelladoyou'd need to go and modify that on neutron devstack plugin13:52
dmelladoAFAIK that's not something within zuul config13:52
dmelladoanyways, brb, going to grab something for lunch, I didn't had time due to meetings today! xD13:54
snapiridmellado, dulek: I am not sure that the neutron devstack plugin is the right place to change it... IMHO their condition for enabling the service is correct: neutron-l3 enabled13:57
snapiridmellado, dulek: I think I can create override-defaults file that will add that service_plugin in case we have (as dulek suggests) the ovn-controller enabled13:58
snapiridmellado, dulek: this is easy, but as I am not familiar enough with the details, I will need your blessing13:59
duleksnapiri: How about just doing `neutron_service_plugin_class_add router` in kuryr-kubernetes plugin post-config?14:00
snapiridulek: I can do it, do you think it is the correct place? I want this to stand out, as it is kind of a patch...14:01
duleksnapiri: IMO the "most" correct way would be to change the Neutron plugin to have an option to enable router service_plugin unconditionally.14:02
snapiridulek: can do. not sure that they will be happy to accept it as they will ask for a concrete reason, will the fact that we need it and it fails our gate suffice?14:07
duleksnapiri: I'm convinced it will, if not I hope they'll direct us to their "most" correct way of doing it. :)14:08
duleksnapiri: BTW let me check out how ovn plugin does that…14:08
duleksnapiri: Oh, that's fun!14:10
duleksnapiri: So seems like we're supposed to use this one: service_plugins = networking_ovn.l3.l3_ovn.OVNL3RouterPlugin14:10
dulekAnd they're doing that through override-defaults: https://github.com/openstack/networking-ovn/blob/f6a0abf0530fae2326fe43eeed9963272e3c93bc/devstack/override-defaults#L714:11
snapiridulek: :)14:11
*** atoth has joined #openstack-kuryr14:11
duleksnapiri: Maybe that'll work?14:11
snapiridulek: so I will create override-defaults file, add this line to it with the condition you specified above?14:12
openstackgerritGenadi Chereshnya proposed openstack/kuryr-tempest-plugin master: Test restart of CNI and Controller kuryr pods  https://review.openstack.org/55249814:14
snapiridulek: and remove the neutron-trunk service?14:15
* snapiri will give it a shot...14:16
duleksnapiri: Not really sure about neutron-trunk. But maybe…14:17
snapiridulek: let's try, I do not see neutron-trunk in the ovn zuul files14:18
openstackgerritEmilio Garcia proposed openstack/kuryr-kubernetes master: Test Objects Module  https://review.openstack.org/57985714:19
*** celebdor1 has joined #openstack-kuryr14:19
openstackgerritShachar Snapiri proposed openstack/kuryr-kubernetes master: Replace q-* for neutron-*  https://review.openstack.org/55246414:19
*** celebdor1 has quit IRC14:30
openstackgerritChuck Short proposed openstack/kuryr-kubernetes master: Switch to using stestr  https://review.openstack.org/57925314:31
openstackgerritEmilio Garcia proposed openstack/kuryr-kubernetes master: Test Objects Module  https://review.openstack.org/57919614:34
*** aojea_ has joined #openstack-kuryr14:39
*** aojea_ has quit IRC14:45
*** yamamoto has joined #openstack-kuryr14:50
*** gcheresh_ has quit IRC14:50
dmelladosnapiri: you can try to go on the override-defaults but that usually is a step on the devstack plugin14:54
*** yamamoto has quit IRC14:58
*** maysamacedos has quit IRC15:34
*** aojea has joined #openstack-kuryr16:27
*** aojea has quit IRC16:32
ltomasbocelebdor, I just discovered something about the namespaces by playing with the PoC about the security group...16:37
ltomasbocelebdor, seems I forgot to include the project id when creating the resources, so ports belong to a different project id than namespace resources... I'll file a bug about it...16:37
*** yamamoto has joined #openstack-kuryr16:50
*** yamamoto has quit IRC16:55
*** janki has quit IRC16:59
*** maysamacedos has joined #openstack-kuryr17:23
*** gcheresh_ has joined #openstack-kuryr17:23
*** gcheresh_ has quit IRC17:31
*** gcheresh_ has joined #openstack-kuryr17:37
*** yamamoto has joined #openstack-kuryr17:51
*** yamamoto has quit IRC17:56
*** garyloug has quit IRC17:58
*** maysamacedos has quit IRC18:04
*** maysamacedos has joined #openstack-kuryr18:07
*** maysamacedos has quit IRC18:11
*** maysamacedos has joined #openstack-kuryr18:11
*** maysamacedos has quit IRC18:13
*** kzaitsev_pi has quit IRC18:26
*** kzaitsev_pi has joined #openstack-kuryr18:27
*** yamamoto has joined #openstack-kuryr18:52
*** yamamoto has quit IRC18:58
*** rh-jelabarre has quit IRC19:39
*** yamamoto has joined #openstack-kuryr19:54
*** yamamoto has quit IRC20:00
*** aojea has joined #openstack-kuryr20:21
*** gcheresh_ has quit IRC20:36
*** yamamoto has joined #openstack-kuryr20:56
*** yamamoto has quit IRC21:00
*** aojea has quit IRC21:10
*** yamamoto has joined #openstack-kuryr21:57
*** yamamoto has quit IRC22:01
*** hongbin has quit IRC22:25
*** yamamoto has joined #openstack-kuryr22:57
*** yamamoto has quit IRC23:02
*** pmannidi has joined #openstack-kuryr23:40
*** yamamoto has joined #openstack-kuryr23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!