Thursday, 2018-04-12

*** fkautz_ has joined #openstack-kuryr00:37
*** fkautz_ is now known as fkautz00:38
*** fkautz has quit IRC00:38
*** fkautz has joined #openstack-kuryr00:38
*** yamamoto has joined #openstack-kuryr00:47
*** yamamoto has quit IRC00:52
*** salv-orlando has joined #openstack-kuryr00:59
*** salv-orlando has quit IRC01:03
*** salv-orlando has joined #openstack-kuryr02:00
*** salv-orlando has quit IRC02:04
*** hongbin has joined #openstack-kuryr02:32
*** janki has joined #openstack-kuryr02:35
*** salv-orlando has joined #openstack-kuryr03:00
*** maysamacedos has quit IRC03:02
*** salv-orlando has quit IRC03:05
*** jchhatbar has joined #openstack-kuryr03:19
*** janki has quit IRC03:22
*** salv-orlando has joined #openstack-kuryr04:01
*** salv-orlando has quit IRC04:05
*** gcheresh has joined #openstack-kuryr04:37
*** hongbin has quit IRC04:38
*** hongbin has joined #openstack-kuryr04:46
*** hongbin has quit IRC04:51
*** salv-orlando has joined #openstack-kuryr05:02
*** salv-orlando has quit IRC05:05
*** salv-orlando has joined #openstack-kuryr05:05
*** janonymous has joined #openstack-kuryr05:13
*** yboaron has joined #openstack-kuryr05:20
*** openstackgerrit has quit IRC05:48
*** caowei has quit IRC05:56
*** caowei has joined #openstack-kuryr05:58
*** caowei has quit IRC06:02
*** threestrands has joined #openstack-kuryr06:05
*** threestrands has quit IRC06:05
*** threestrands has joined #openstack-kuryr06:05
*** salv-orlando has quit IRC06:35
*** salv-orlando has joined #openstack-kuryr06:35
*** salv-orlando has quit IRC06:39
*** salv-orlando has joined #openstack-kuryr06:42
*** yamamoto has joined #openstack-kuryr07:05
*** yboaron has quit IRC07:14
*** pliu has joined #openstack-kuryr07:14
pliuI got error "No 'kuryr_kubernetes.vif_translators' driver found" from kuryr-controller. Did I miss anything in the config file?07:16
*** gcheresh has quit IRC07:17
celebdorltomasbo: ^^07:19
ltomasbocelebdor, pliu: any more context?07:21
dmelladocelebdor: your patch is in worse shape than cifuentes future in polytics07:21
dmelladocould you take a look07:21
ltomasbowhat driver are you trying to use, lbaas or octavia, kubernetes or openshift, ...07:21
dmelladomaybe he can just share his local.conf07:21
celebdoryes, yes. I'm aware. It's just that I started doing the ansible part and everytime I touch ansible I get side tracked07:21
* celebdor does not like coding for deployment tools07:22
pliultomasbo, I haven't install octavia yet. Just trying to start a pod. Can kuryr-kubernetes work without octavia if I don't use service?07:23
ltomasbopliu, yes, are you trying with devstack? with the default local.conf?07:25
ltomasbopliu, also need to know if you run it containerized or not, daemonized or not, ...07:25
pliultomasbo, I'm trying to get it work on with RDO. The kuryr_kubernetes runs as a daemon on controller nodes07:26
dmelladopliu: you'd need either lbassv2 or octavia07:27
ltomasboso, probably you are missing information at kuryr.conf, regarding the drivers you want to use07:28
pliultomasbo, so even without using k8s's service, I still need to setup lbassv2 or octavia?07:29
dulekpliu: Is it possible you simply don't have os-vif library installed?07:29
ltomasbopliu, depend on how you configure it, you may not need any lbaas driver07:29
dmelladoltomasbo: yeah, that could be as well07:30
dmelladobut that'd be the default usecase07:30
pliudulek, I have os-vif installed.07:31
pliuwhich config parameter I should set to choose the vif translator dirver?07:32
dulekpliu: None. :D07:32
dulekpliu: It's chosen based on VIF provided by VIF driver.07:32
dulekpliu: So let's check what you have set as pod_vif_driver in [DEFAULT] section.07:33
dulekpliu: Oh sorry, it's [kubernetes] section.07:33
* dulek needs more coffee.07:33
pliudulek, pod_vif_driver = neutron-vif07:36
dmelladopliu: that's ok07:37
dulekpliu: Can you list neutron ports and give us `openstack port show` of the one created by Kuryr?07:39
pliu+-----------------------+-------------------------------------------------------------------------------------+07:42
pliu| Field                 | Value                                                                               |07:42
pliu+-----------------------+-------------------------------------------------------------------------------------+07:42
pliu| admin_state_up        | True                                                                                |07:42
pliu| allowed_address_pairs |                                                                                     |07:42
pliu| binding:host_id       | overcloud-novacompute-1                                                             |07:42
pliu| binding:profile       | {}                                                                                  |07:42
pliu| binding:vif_details   | {}                                                                                  |07:42
pliu| binding:vif_type      | binding_failed                                                                      |07:42
pliu| binding:vnic_type     | normal                                                                              |07:42
pliu| created_at            | 2018-04-12T06:38:56Z                                                                |07:42
*** openstackgerrit has joined #openstack-kuryr07:42
openstackgerritLuis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Run OVN job containerized and daemonized  https://review.openstack.org/54928907:42
pliu| description           |                                                                                     |07:42
pliu| device_id             | cf23f36a-3e0a-11e8-aca7-52540049ded8                                                |07:42
pliu| device_owner          | compute:kuryr                                                                       |07:42
pliu| extra_dhcp_opts       |                                                                                     |07:42
pliu| fixed_ips             | {"subnet_id": "c6ac3c89-97ce-4ca8-b393-67bbae2ac58a", "ip_address": "192.168.0.41"} |07:42
pliu| id                    | aa3b06d8-6114-4fee-91c7-709c47be462d                                                |07:42
pliu| mac_address           | fa:16:3e:18:89:c2                                                                   |07:42
pliu| name                  | kuryr-poc                                                                           |07:42
pliu| network_id            | 7f5819b7-f75c-4e1b-9cef-cfebe28e7409                                                |07:42
pliu| port_security_enabled | True                                                                                |07:42
pliu| project_id            | dc5ec8f33a2f4e17b8f964ae8c7bc9e1                                                    |07:42
pliu| qos_policy_id         |                                                                                     |07:42
pliu| revision_number       | 7                                                                                   |07:42
pliu| security_groups       | 16e7131e-7b80-494a-97ab-6e2963badb00                                                |07:42
pliu| status                | DOWN                                                                                |07:42
pliu| tags                  |                                                                                     |07:42
pliu| tenant_id             | dc5ec8f33a2f4e17b8f964ae8c7bc9e1                                                    |07:42
pliu| updated_at            | 2018-04-12T06:38:57Z                                                                |07:42
pliu+-----------------------+-------------------------------------------------------------------------------------+07:43
pliuI'm doing the container on baremetal scenario07:43
dulekpliu: Well, we cannot really do much with "binding_failed" VIF type. :P07:46
dulekpliu: Check out Neutron logs, there must have been a failure there.07:46
dulekpliu: https://github.com/openstack/neutron/blob/a51271d760b3a00f7648374d85fafb3d122a4985/doc/source/contributor/internals/live_migration.rst#potential-error-cases-related-to-networking-207:47
dulekI'm not sure if this is related.07:47
dulekcelebdor, ltomasbo, dmellado, irenab: How do we handle that issue? Should we catch VIF_TYPE_BINDING_FAILED before translating and raise more specific exception?07:49
*** gcheresh has joined #openstack-kuryr07:50
dulekpliu: Can you file a bug on Launchpad? Even though it's not Kuryr's fault we should handle this better.07:50
dmelladodulek: probably yeah07:50
dmellado+107:50
celebdordulek: we should handle it somehow, yes07:51
irenabdulek, what is the issue?07:51
pliu2018-04-12 06:38:57.626 28 ERROR neutron.plugins.ml2.managers [req-650281cd-f905-45ac-ae3e-3d570c74ad22 365c237b49634df9a6e0e49d5dc28d53 dc5ec8f33a2f4e17b8f964ae8c7bc9e1 - default default] Failed to bind port aa3b06d8-6114-4fee-91c7-709c47be462d on host overcloud-novacompute-1 for vnic_type normal using segments [{'network_id': '7f5819b7-f75c-4e1b-9cef-cfebe28e7409', 'segmentation_id': 27, 'physical_network': None, 'id': '717be8a3-7978-07:51
pliu4e2e-88b6-5ba407a2b58a', 'network_type': u'vxlan'}]07:51
pliu2018-04-12 06:38:57.627 28 INFO neutron.plugins.ml2.plugin [req-650281cd-f905-45ac-ae3e-3d570c74ad22 365c237b49634df9a6e0e49d5dc28d53 dc5ec8f33a2f4e17b8f964ae8c7bc9e1 - default default] Attempt 2 to bind port aa3b06d8-6114-4fee-91c7-709c47be462d07:51
pliuI get this from neutron server log07:52
dulekirenab: Neutron can signal an issue with the binding of created port by setting its type to VIF_TYPE_BINDING_FAILED. Then in Kuryr we get the exception mentioned originally by pliu.07:52
irenabdulek, pliu I think the log on kuryr side can bebetter to reflect the issue of unsupported binding type (failed is just case of the unsupported), the rest should come from the neutron.07:54
dulekpliu: Sorry, I have no idea what causes that. But I guess more specific failure can be found in L2 agent logs.07:54
pliudulek, I am not sure if it is bug. I install and config kuryr-kubernetes manually. Maybe just a config error by me?07:55
irenabpliu, it looks like there is a segmented network on the neutron side. Is this what you wanted?07:55
dulekpliu: It's definitely Neutron failure.07:55
dulekpliu: Or Neutron misconfiguration. But it doesn't look like Kuryr's fault.07:55
dulekirenab: Yep, I was just thinking of logging that this issue most likely comes from Neutron, not Kuryr.07:56
irenabAgree with dulek . Since there is no valid vif-type returned from neutron, there is no much kuryr can do07:56
pliuirenab, the network I'm using for kuryr is a vxlan network which create by me. Is that the issue?07:57
irenabpliu, I was curious about 'using segments' in the log message you posted07:57
irenabanything in the l2_agent log?07:58
*** gcheresh_ has joined #openstack-kuryr07:59
pliu+---------------------------+--------------------------------------+| Field                     | Value                                |07:59
pliu+---------------------------+--------------------------------------+07:59
pliu| admin_state_up            | True                                 |07:59
pliu| availability_zone_hints   |                                      |07:59
pliu| availability_zones        | nova                                 |07:59
pliu| created_at                | 2018-04-04T15:38:55Z                 |07:59
pliu| description               |                                      |07:59
dmelladopliu: do you have an answers file from packsack around?07:59
pliu| id                        | 7f5819b7-f75c-4e1b-9cef-cfebe28e7409 |07:59
pliu| ipv4_address_scope        |                                      |07:59
pliu| ipv6_address_scope        |                                      |07:59
dmelladoalso, please do use pastebin07:59
pliu| mtu                       | 1450                                 |07:59
pliu| name                      | internal                             |07:59
pliu| port_security_enabled     | True                                 |07:59
pliu| project_id                | dc5ec8f33a2f4e17b8f964ae8c7bc9e1     |07:59
pliu| provider:network_type     | vxlan                                |07:59
pliu| provider:physical_network |                                      |07:59
dmelladootherwise it's just flood on the channel07:59
*** gcheresh has quit IRC07:59
pliu| provider:segmentation_id  | 27                                   |07:59
pliu| qos_policy_id             |                                      |07:59
pliu| revision_number           | 4                                    |07:59
pliu| router:external           | False                                |07:59
pliu| shared                    | False                                |07:59
pliu| status                    | ACTIVE                               |07:59
pliu| subnets                   | c6ac3c89-97ce-4ca8-b393-67bbae2ac58a |07:59
pliu| tags                      |                                      |07:59
pliu| tenant_id                 | dc5ec8f33a2f4e17b8f964ae8c7bc9e1     |08:00
dmelladopliu: http://paste.openstack.org/08:00
pliu| updated_at                | 2018-04-04T15:39:15Z                 |08:00
pliu+---------------------------+--------------------------------------+08:00
pliuthis is the network info08:00
pliuhttps://pastebin.com/Qvqzprek08:00
irenabpliu, network seems fine. Try to check the l2 agent logs, maybe some mappings are missing08:02
ltomasbopliu, how did you created that port? was kuryr creating it for you?08:05
pliuI didn't find any error in ovs agent log on compute node08:06
pliuYes, that port was created by kuryr08:06
ltomasbook, celebdor did you remember for the defconf demo, we had to do some workaround because the port was going to binding failure?08:07
pliuI tried to boot a vm on that compute node, it works as expect.08:07
dulekpliu: Hm, had you checked the logs of kubelet? Maybe for some reason it's Kuryr-CNI breaking something?08:07
ltomasbothat was because the agent was down, right?08:07
ltomasbopliu, can you check the status of the neutron agents?08:07
pliuin kubelet log, I can see the kuryr-cni get timeout when trying to bind if08:08
*** yboaron has joined #openstack-kuryr08:10
ltomasbopliu, can you do 'openstack network agent list'?08:10
pliuhttps://pastebin.com/GR3JhJ1c all work are on overcloud-novacompute-1.08:12
*** pcaruana has joined #openstack-kuryr08:12
*** celebdor1 has joined #openstack-kuryr08:13
*** celebdor1 is now known as apuimedo08:13
apuimedoI had gnome broken08:13
ltomasboyep, I see ovs is down on overcoud-novacompute-008:13
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Add tarballed amphora.  https://review.openstack.org/56031308:13
apuimedoI've had to move to cinnamon temporarily :/08:13
apuimedodmellado: is this patch for real?!08:14
ltomasbopliu, perhaps a restart of the agent on overcloud-novacompute-1 will help08:14
dmelladoapuimedo: fixing botched jobs from octavia, but yeah08:14
dmelladoxD08:14
dmelladoso we'd be able to skip the dib bits08:14
apuimedodmellado: dib?08:15
dmelladodisk image builder08:16
pliultomasbo, I think the ovs-agent is ok. Since I just boot a nova vm on that compute. It works, and port is attached08:16
*** yamamoto has quit IRC08:17
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Add tarballed amphora.  https://review.openstack.org/56031308:23
apuimedoah08:24
*** salv-orlando has quit IRC08:30
*** salv-orlando has joined #openstack-kuryr08:31
*** yamamoto has joined #openstack-kuryr08:32
*** salv-orlando has quit IRC08:35
*** yamamoto has quit IRC08:36
*** shadower has quit IRC08:41
*** shadower has joined #openstack-kuryr08:41
*** garyloug has joined #openstack-kuryr08:45
*** natanbro has joined #openstack-kuryr09:25
*** salv-orlando has joined #openstack-kuryr09:31
*** salv-orlando has quit IRC09:37
*** salv-orlando has joined #openstack-kuryr09:39
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Add tarballed amphora.  https://review.openstack.org/56031309:43
*** yamamoto has joined #openstack-kuryr09:46
*** yamamoto has quit IRC09:48
*** yamamoto has joined #openstack-kuryr09:49
*** yamamoto has quit IRC09:52
*** yamamoto has joined #openstack-kuryr09:54
apuimedoI just fixed the unit test for the octavia client fix09:55
apuimedoI'm adding one extra to cover the new code09:55
*** yamamoto has quit IRC10:00
*** yamamoto has joined #openstack-kuryr10:01
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: lbaasv2: Fix for deployments missing the proxy  https://review.openstack.org/56043310:11
apuimedodmellado: dulek: ltomasbo: yboaron: irenab: ^^10:15
irenabapuimedo, checking10:16
irenabapuimedo, I do not understadnwhat the comment https://review.openstack.org/#/c/560433/3/kuryr_kubernetes/clients.py line 56 means10:17
*** threestrands has quit IRC10:24
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: lbaasv2: Fix for deployments missing the proxy  https://review.openstack.org/56043310:32
apuimedoirenab: it means that since the APIs are compatible, we just use neutronclient to talk to it10:32
apuimedobut since neutronclient can only have one endpoint, we create an extra instance10:33
apuimedoso we have one instance to talk to neutron and one to talk to lbaas10:33
* apuimedo going to cook rice10:33
dmelladoapuimedo: I left also some comments there10:33
dmelladoplease check an address PS3 ones10:35
dmelladoand *not* playstation xD10:35
irenabapuimedo, got it, now it is clear, maybe worth to clarify the comment in the code.10:37
irenabdmellado :-)10:38
dmellado;)10:39
dmelladobtw irenab I got multinode gates working, pending on a dependency on devstack to merge10:40
dmelladoonce that you fix DF issues I'll also add a multinode gate for it10:40
irenabdmellado, the DF issue seems to be a bit fundamental change. I wonder if we can split the tests for pod to Vm connectivity and temporary disable failing test for DF10:44
dmelladoirenab: yeah, that won't be an issue, we can just add a blacklist for DF10:44
dmelladoirenab: I'll put an example on how to do this and add you as reviewer so you can take it over and hande this as you might want10:45
dmelladohande/handle10:45
irenabdmellado, thanks10:45
*** yamamoto has quit IRC10:56
*** yamamoto has joined #openstack-kuryr11:02
*** yamamoto has quit IRC11:03
*** yamamoto has joined #openstack-kuryr11:08
*** yamamoto has quit IRC11:11
*** yamamoto has joined #openstack-kuryr11:11
dulekapuimedo: lbaasv2 job failed.11:21
dulekapuimedo: I'm investigating.11:21
dulekapuimedo, dmellado: http://logs.openstack.org/33/560433/4/check/kuryr-kubernetes-tempest-daemon-lbaasv2/080db9a/job-output.txt.gz#_2018-04-12_11_00_57_47329811:22
dulekThat's quite odd.11:22
dulekAww, crap. K8s client update broke us again?11:25
dulekYep, they've just released. AWESOME!11:26
dulekI'm capping it.11:28
*** yamamoto has quit IRC11:33
openstackgerritMichał Dulko proposed openstack/kuryr-tempest-plugin master: Cap kubernetes Python package to <6.0.0  https://review.openstack.org/56086711:36
dulekapuimedo, dmellado, irenab: Let's see if that solves the issue and merge it to unblock.11:36
dulekI've capped instead of fixing it as I'm not sure how this will behave on stable branch.11:36
dulekAnd global-requirements has >=4.0.0, so 5.0.0 fits.11:38
*** maysamacedos has joined #openstack-kuryr11:52
dmelladodulek: I'm so happy with your performance xD11:54
dmelladoI noticed that and I was about to tackle that after lunch11:54
dmelladobut I come back from it and it got solved xD xD xD11:55
dulekdmellado: Frustration tends to fuel me sometimes. Like why every release of that client breaks up?!11:55
duleks/up/us11:56
apuimedodulek: because it's trendy11:58
apuimedotrendiness is very strongly correlated with not giving a fuck about bc11:59
*** yboaron_ has joined #openstack-kuryr12:00
*** yboaron has quit IRC12:04
*** atoth has joined #openstack-kuryr12:05
*** yamamoto has joined #openstack-kuryr12:30
*** yamamoto has quit IRC12:35
openstackgerritMichał Dulko proposed openstack/kuryr-tempest-plugin master: Add V1DeleteOptions when deleting Service  https://review.openstack.org/56086712:39
openstackgerritDaniel Mellado proposed openstack/kuryr-tempest-plugin master: Apply cap from upper reqs  https://review.openstack.org/56088512:43
dmelladodulek: celebdor ltomasbo https://review.openstack.org/56088512:43
dmelladoplease let's get this merged asap to unlock the gates12:43
dulekdmellado: Oh, nice!12:43
dmelladooddly it wasn't applying the upper req limits12:44
dulekdmellado: Good idea, but once upper-requirements.txt are changed we're broken again…12:45
dmelladonot really12:45
dmelladoupper reqs is mapped to 512:45
dmelladoand I'm pretty sure they'll skip the version12:45
dmelladoif that changes it in that way12:45
dulekdmellado: Yes, but uc might be raised.12:45
dmelladodulek: when that comes, we'll address that either in our reqs or we fix the change12:46
dmelladouc will in any case just be raised for the release12:46
dmelladowhich we'll address as well12:46
dulekdmellado: Okay. Then I'm -W on  https://review.openstack.org/560867.12:46
dmelladodulek: great, thanks!12:47
*** yamamoto has joined #openstack-kuryr12:47
*** yamamoto has quit IRC12:49
garylougHi folks, I've posted some comments on this binding driver https://review.openstack.org/#/c/559363/1/kuryr_kubernetes/cni/binding/dpdk.py If you have time I'd like to get some input on what you think is the best way to do this.12:51
irenabdmellado, dulek maybe worth to raise the broken BC to the attention of the k8s client team?12:52
dulekirenab: They'll probably say that they're changing major version, so that's expected.12:53
dmelladodulek: irenab even worse, IIRC they're beta12:53
dulekBut the only releases they do are raising major.12:53
dulek:D12:53
dmelladoso they advise that something like that might happen12:53
dulekOh my.12:53
dmelladoin any case, and that said12:53
dmelladothe change looked minimal12:53
dmelladolike def(foo, bar) to def(foo, bar, oh_my)12:54
dmelladobut let's keep the uc constraints for now to unlock the gate and I'll take a look afterwards12:54
*** maysamacedos has quit IRC12:54
dulekThey're autogenerating that based on Swagger, I think.12:54
dmelladoyeah, exactly12:54
irenabnever though that autogenerating comes with 'do not bother to keep bc' ...12:55
dmelladoheh, lol12:55
*** yamamoto has joined #openstack-kuryr13:01
*** yamamoto has quit IRC13:01
apuimedothanks garyloug13:02
apuimedoI'll take a look13:02
*** yamamoto has joined #openstack-kuryr13:05
*** jchhatbar is now known as janki13:07
*** yamamoto has quit IRC13:09
dmelladoyep, me too13:18
dmelladoyboaron_: ping, could you please also check https://review.openstack.org/55936313:18
dmellado?13:18
yboaron_dmellado, sure , in few minutes13:18
dmelladoyboaron_: whenever you've some time, no worries ;)13:19
*** yamamoto has joined #openstack-kuryr13:21
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Add tarballed amphora.  https://review.openstack.org/56031313:24
*** yamamoto has quit IRC13:24
*** janonymous has quit IRC13:25
*** yboaron_ has quit IRC13:30
*** yboaron_ has joined #openstack-kuryr13:31
*** yamamoto has joined #openstack-kuryr13:43
garylougThanks guys13:44
*** yamamoto has quit IRC13:44
*** dangtrinhnt has quit IRC13:45
*** dangtrinhnt has joined #openstack-kuryr13:46
*** yamamoto has joined #openstack-kuryr13:48
*** yamamoto has quit IRC13:49
*** yamamoto has joined #openstack-kuryr13:49
*** hongbin has joined #openstack-kuryr14:13
dulekdmellado: Your fix is red in the gate, seems like wrong package is still installed.14:17
*** yboaron_ has quit IRC14:22
openstackgerritGenadi Chereshnya proposed openstack/kuryr-tempest-plugin master: Testing connectivity from VM to service and vice versa  https://review.openstack.org/56092614:26
dmelladodulek:14:29
dmelladoI've just seen it14:29
dmelladooddly14:29
dmelladoit's on kubernetes 5 *inside* the tox env14:29
dmelladobut kubernetes 6 outside14:29
dmelladomakes totally no sense and I'm not being able to get a match on the pip freeze14:30
dmelladoxD14:30
dulekdmellado: Well, it doesn't ring a bell for me. :(14:30
dmelladoI'm tempted to just fix the issue on the kubernetes library, tbh14:30
dulekdmellado: I'm rechecking my patch - Octavia timed out but that's probably unrelated.14:30
dmelladohm, I think I'm starting to know what's going on14:31
dulekdmellado: You would need a release of it, easier to fix it on our side.14:31
dmelladolet me check a second14:31
dmelladodulek: I mean14:31
dmelladofix our code onthe tempest plugin to match kuberntes 614:31
dulekdmellado: https://review.openstack.org/#/c/560867/ - that's done here. :D14:31
dulekI'm just rechecking it as Octavia timed out - seems it's unrelated.14:32
*** garyloug has quit IRC14:32
*** garyloug has joined #openstack-kuryr14:32
dmelladodulek: -1 on that patch14:32
dmelladoyou're not fixing the callback14:32
dmelladoxD14:32
dulekCallback?14:33
dmelladoyep14:33
dmelladolet me comment it there14:33
dmelladoit would work but that's not the best ever possible approach14:33
dulekdmellado: Okay, please comment with explanation and I'll upload a new one.14:34
dulekgcheresh_: Just in case - gate is pretty much broken due to kubernetes lib release.14:34
dulekgcheresh_: We're working on that.14:35
dmelladodulek: see my comments there14:36
dmelladoif you've any doubt let me know14:36
dmelladomy patch works inside the venv but thare's some odd thing being done there14:37
dmelladoso, when they trigger the plugins they do a tox -eall-plugin which installs a system-wide venv14:37
dmelladoso the outside kubernetes 6 takes over the one inside the plugin14:38
dmelladoodd in any case14:38
dulekdmellado: Wait, what?14:38
dulekdmellado: It's delete body.14:38
dulekdmellado: Not a service.14:38
dulekdmellado: V1DeleteOptions, not V1Service.14:38
* dmellado facepalms14:38
dmelladonvm14:38
dmelladoI was thinking about service body14:39
dulekdmellado: Yeah, me too until I've looked into the code.14:39
dmelladodo rebase the tox thing in any case and i'll approve it14:39
dulekdmellado: Pretty odd choice of a name for delete options.14:39
gcheresh_dulek: dmellado The patch I uploaded has problems so if you can take a look what am I missing it will be great14:40
dmelladodulek: in any case14:40
dmelladothere's something odd on the infra side14:40
dmelladoas whatever installs kubernetes python should also match upper reqs14:41
dulekgcheresh_: You're referring to my messages from 16:34?14:41
dulekdmellado: It's Tempest. Maybe it's not using them.14:41
gcheresh_dulek: No I think there is some problems on connectivity in devstack as I can reach from VM the pods of the service but can't reach the service itself14:42
dulekdmellado: You want me to add the body parameter to delete_service()? I can do it but not sure if it's too useful. If anyone needs it he'll just extend delete_service().14:42
dmelladodulek: no, it actually should14:43
dmelladoI've just checked their tox.ini14:43
dmelladodulek: nope, no need if it's another body14:43
dmelladodisregard that14:43
dmelladojust rebase the tox upper reqs for future usage14:43
dulekgcheresh_: Okay, I'll take a look a bit later on or tomorrow.14:43
openstackgerritMichał Dulko proposed openstack/kuryr-tempest-plugin master: Apply cap from upper reqs  https://review.openstack.org/56088514:44
dulekdmellado: Okay, let's see how this will work in the gate.14:44
* dulek leaves for ~30 minutes.14:44
dmelladodulek: ack, I'll be leaving in around that time too14:45
dmelladoso I'll leave some comments on the patch14:45
*** gcheresh_ has quit IRC14:47
dmelladodulek: that kubernetes 6 is around makes no sense at all14:52
* dmellado sighs14:52
dmelladodulek: in any case we need to be way on this14:55
dmelladoas if we fix this in the proper way the gate would fail again with yout patch14:55
*** natanbro has quit IRC15:00
*** gcheresh_ has joined #openstack-kuryr15:16
dulekdmellado: It'll not, I'm passing this `body` as kwarg and there's **kwargs in definiton.15:21
dmelladodulek: in any case I don't think that's a proper fix15:23
dmelladoI commented on your patch15:23
dmelladoimagine that python kubernetes release 7 tomorrow15:23
dmelladoand they add a madatory tuple parameter15:23
dmelladolike (apuimedo , lazy)15:24
dmelladowe'd get broken at that same moment15:24
dmelladowe need to dig out why the version over the reqs is being installed15:24
dmelladoeven if eventually accept that patch as a partial fix15:24
dulekdmellado: Okay, can you point me to gate results which install wrong version?15:25
dulekdmellado: I can look were it's getting installed.15:25
dmelladodulek: I couldn't fetch that upstream but I'm redeploying and it's the only thing that make sense to me15:26
dmelladoI'll be asking infra to freeze the machine if get the same results on my patch15:26
dmelladolike, we know that by upper reqs we're installing 5 and that requires no change on the method15:26
dmelladoeven with that, it complains15:26
dmelladoand I've seen on my machine, now being redeployed that15:26
dulekDamn, we've probably lost it due to my rebase. Awww…15:27
dmelladoit installed kubernetes 6 on the system-site15:27
dmelladoyeah, I'm waiting for those15:27
dmelladobut 5 inside the tox env15:27
dmelladoso weird15:27
dulekOkay, found it - http://logs.openstack.org/85/560885/1/check/kuryr-kubernetes-tempest-daemon-lbaasv2/3bc2f26/15:27
dulekNow let's just see where it was installed.15:27
dmelladolol, I was being overly optimistic and thought you had found the place where it was installed15:28
dmelladoxD15:28
dulekdmellado: There's 6.0.0 in venv as well.15:28
dulekhttp://logs.openstack.org/85/560885/1/check/kuryr-kubernetes-tempest-daemon-lbaasv2/3bc2f26/job-output.txt.gz#_2018-04-12_13_11_12_36039915:28
dmelladodulek: where did you find it?15:29
dmelladomakes no sense15:29
dulekdmellado: It does make sense.15:30
dulekdmellado: http://logs.openstack.org/85/560885/1/check/kuryr-kubernetes-tempest-daemon-lbaasv2/3bc2f26/job-output.txt.gz#_2018-04-12_13_11_07_88425615:30
dulekdmellado: It's installing kuryr-tempest-plugin into the venv.15:30
dulekdmellado: And that's going without upper-constraints. At least it looks like it.15:30
dulekdmellado: pip install ../kuryr-tempest-plugin15:30
dulekThat's it.15:30
dmellado2018-04-12 13:11:00.250597 | controller | ++ lib/tempest:install_tempest_plugins:649  :   tox -evenv-tempest -- pip install /opt/stack/kuryr-tempest-plugin15:31
dmelladoyep15:31
dmelladothat's a bug15:31
dmelladoin the tempest code15:31
dmelladoawesome15:31
dmelladoI wonder how anyone didn't notice15:31
dulekdmellado: https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L645-L65415:32
dulekdmellado: In DevStack.15:32
dulekdmellado: Fancy for a DevStack commit? ;)15:38
dmelladodulek: lol15:38
dulekdmellado: Looks like it's a trivial one. I can do it if you want.15:40
dmelladono worries, I'll just push it15:40
dmelladototally trivial15:40
dmelladojust -c $REQUIREMENTS_DIR/upper15:40
dmelladoon the install tempest plugins15:40
dmellado-        tox -evenv-tempest -- pip install $TEMPEST_PLUGINS15:42
dmellado+        tox -evenv-tempest -- pip install -c $REQUIREMENTS_DIR/upper-constraints.txt TEMPEST_PLUGINS15:42
dmelladotadaaa15:42
dmelladoxD15:42
dmellado$TEMPEST_PLUGINS15:43
dmelladoxD15:43
dmelladodulek: if you're around later could you pls watch the change in case it needs something more?15:43
dulekdmellado: Yup. Might be worth creating a Kuryr-kubernetes dummy commit with Depends-On on it.15:43
dmelladodulek: https://review.openstack.org/56094615:44
* dmellado flees away xD15:44
dulekdmellado: I'll add that change. ;)15:44
dulekdmellado: But you're missing bug link!15:44
*** gcheresh_ has quit IRC15:46
dmelladodulek: I know :P15:46
dmelladoamend it, pls xD15:46
dmelladowe'll assign next one to juriarte and gcheresh15:47
openstackgerritMichał Dulko proposed openstack/kuryr-kubernetes master: Do not merge, testing DevStack fix  https://review.openstack.org/56095115:50
dulekapuimedo: Seen my comment on your patch? The Octavia gates are failing in a weird way.16:02
dulekapuimedo: It's worth trying to switch order of post-config and LIBS_FROM_GIT in the definition.16:03
*** gcheresh_ has joined #openstack-kuryr16:15
dulekapuimedo, ltomasbo: Do you think we can cleanup https://hub.docker.com/r/kuryr/cni/tags/ ?16:19
ltomasbodulek, perhaps not all of them16:20
ltomasbodulek, is latest already fixing the problem with os_vif and the pleg mitigation?16:21
ltomasboI guess multipools, multipool-no-rivsep can be deleted16:21
ltomasbonot sure what a50bf74d is16:22
dulekltomasbo: Uh… Definitely it's fixing os_vif (docker exec based CNI execution solves that).16:22
dulekltomasbo: I don't remember PLEG mitigation?16:22
ltomasboI believe the pleg thing was fixed upstream kubernetes, but perhaps apuimedo remembers that better16:22
ltomasboif that so, I guess you can clean them all16:22
dulekltomasbo: Okay. Meanwhile I want to push latest master.16:25
dulekltomasbo: And it'll need this: https://github.com/openshift/openshift-ansible/pull/788916:26
dulekshadower: Can you take a look on this: https://github.com/openshift/openshift-ansible/pull/7889 ?16:26
ltomasbodulek, we don't need the lock_path anymore?16:27
ltomasboi thought it was needed for the cni to properly work16:27
dulekltomasbo: https://github.com/openstack/kuryr-kubernetes/blob/206c158d37060142d7d80d1be0564be10af576e7/cni.Dockerfile#L2616:27
dulekltomasbo: Not with this.16:27
ltomasboahh, ok, you fix it on the other side16:28
ltomasbook then16:28
ltomasboit is a bit of a pain to have to do that twice (kuryr-kubernetes and openshift-ansible)16:28
dulekYup.16:29
*** garyloug has quit IRC16:34
*** gcheresh_ has quit IRC16:46
*** yamamoto has quit IRC16:47
*** yamamoto has joined #openstack-kuryr16:58
*** yamamoto has quit IRC17:03
*** janki has quit IRC17:09
*** russellb has quit IRC17:13
*** leifmadsen has quit IRC17:13
apuimedoltomasbo: it should be17:14
ltomasboapuimedo, great! thanks!17:15
apuimedoltomasbo: but the fix IIRC was in Docker so...17:16
apuimedoit depends on the distro if we get it or not17:17
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: lbaasv2: Fix for deployments missing the proxy  https://review.openstack.org/56043317:17
*** juriarte has quit IRC17:18
*** juriarte has joined #openstack-kuryr17:18
*** leifmadsen has joined #openstack-kuryr17:21
*** russellb has joined #openstack-kuryr17:21
*** gcheresh_ has joined #openstack-kuryr17:33
*** yamamoto has joined #openstack-kuryr18:04
*** pcaruana has quit IRC18:09
*** openstackgerrit has quit IRC18:19
*** gcheresh_ has quit IRC18:20
*** salv-orlando has quit IRC19:04
*** salv-orlando has joined #openstack-kuryr19:04
*** salv-orlando has quit IRC19:09
*** apuimedo has quit IRC19:09
*** yboaron_ has joined #openstack-kuryr19:17
*** aojea has joined #openstack-kuryr19:41
*** apuimedo has joined #openstack-kuryr20:03
*** lihi has quit IRC20:03
*** irenab has quit IRC20:04
*** snapiri has quit IRC20:04
*** oanson has quit IRC20:05
*** salv-orlando has joined #openstack-kuryr20:05
*** atoth has quit IRC20:06
*** salv-orlando has quit IRC20:09
*** salv-orlando has joined #openstack-kuryr20:09
*** snapiri has joined #openstack-kuryr20:11
*** irenab has joined #openstack-kuryr20:11
*** oanson has joined #openstack-kuryr20:12
*** lihi has joined #openstack-kuryr20:12
*** yamamoto has quit IRC20:21
*** yamamoto has joined #openstack-kuryr20:22
*** salv-orlando has quit IRC20:47
*** salv-orlando has joined #openstack-kuryr20:48
*** openstackgerrit has joined #openstack-kuryr21:19
openstackgerritYossi Boaron proposed openstack/kuryr-kubernetes master: [WIP] Make handlers pluggable  https://review.openstack.org/55573521:19
*** aojea has quit IRC21:26
*** aojea has joined #openstack-kuryr21:26
*** yboaron_ has quit IRC21:26
*** openstack has joined #openstack-kuryr21:28
*** ChanServ sets mode: +o openstack21:28
*** aojea has quit IRC21:56
*** salv-orlando has quit IRC22:18
*** salv-orlando has joined #openstack-kuryr22:19
*** salv-orlando has quit IRC22:23
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes master: lbaasv2: Fix for deployments missing the proxy  https://review.openstack.org/56043322:24
*** hongbin has quit IRC22:58
*** ripdogPJ0R9A has joined #openstack-kuryr23:40
*** ripdogPJ0R9A has quit IRC23:42

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!