| *** yamamoto has joined #openstack-kuryr | 00:08 | |
| *** hongbin has quit IRC | 00:48 | |
| *** kiennt26 has joined #openstack-kuryr | 01:12 | |
| *** hongbin has joined #openstack-kuryr | 02:24 | |
| *** janonymous has joined #openstack-kuryr | 03:24 | |
| *** caowei has joined #openstack-kuryr | 03:46 | |
| *** caowei has quit IRC | 04:25 | |
| *** caowei has joined #openstack-kuryr | 04:25 | |
| *** caowei has quit IRC | 04:55 | |
| *** yboaron has joined #openstack-kuryr | 05:03 | |
| *** hongbin has quit IRC | 05:09 | |
| *** hongbin has joined #openstack-kuryr | 05:12 | |
| *** sylviamittal has joined #openstack-kuryr | 05:12 | |
| sylviamittal | apuimedo : Hi, I am new here and want to contribute. So, can you help me where to start with keeping in mind the tentative projects for Outreachy Round 16. Thanks! | 05:17 |
|---|---|---|
| *** hongbin has quit IRC | 05:30 | |
| *** sylviamittal has quit IRC | 05:31 | |
| *** caowei has joined #openstack-kuryr | 05:34 | |
| *** caowei has quit IRC | 05:59 | |
| *** caowei has joined #openstack-kuryr | 06:01 | |
| *** caowei has quit IRC | 06:03 | |
| *** pmannidi has quit IRC | 06:16 | |
| *** janki has joined #openstack-kuryr | 06:20 | |
| *** gcheresh has joined #openstack-kuryr | 06:27 | |
| *** caowei has joined #openstack-kuryr | 06:32 | |
| *** pmannidi has joined #openstack-kuryr | 06:33 | |
| *** pmannidi has quit IRC | 06:38 | |
| *** pmannidi has joined #openstack-kuryr | 06:50 | |
| *** caowei has quit IRC | 07:17 | |
| *** threestrands_ has quit IRC | 07:20 | |
| *** caowei has joined #openstack-kuryr | 07:21 | |
| *** caowei has quit IRC | 07:25 | |
| *** pcaruana has joined #openstack-kuryr | 07:48 | |
| *** pcaruana has quit IRC | 07:55 | |
| *** pcaruana has joined #openstack-kuryr | 07:55 | |
| *** caowei has joined #openstack-kuryr | 08:28 | |
| *** juriarte has joined #openstack-kuryr | 08:35 | |
| *** caowei has quit IRC | 08:39 | |
| *** pmannidi has quit IRC | 08:41 | |
| *** caowei has joined #openstack-kuryr | 08:50 | |
| dulek | apuimedo: Is there a reason to do `COPY /opt/kuryr-kubernetes .` before all the yum operations? | 08:53 |
| dulek | apuimedo: That way every rebuild with minor code change triggers yum install, which takes a lot of time. | 08:53 |
| apuimedo | dulek: link to github | 08:54 |
| dulek | apuimedo: I'm talking about cni and controller Dockerfiles. | 08:54 |
| apuimedo | please? | 08:54 |
| apuimedo | :P | 08:54 |
| dulek | apuimedo: https://github.com/openstack/kuryr-kubernetes/blob/master/controller.Dockerfile#L4 | 08:54 |
| dulek | apuimedo: I might not be aware of some Dockerfile writing good practice, so that's why I'm asking. | 08:55 |
| apuimedo | dulek: swap it | 08:55 |
| apuimedo | it's not good | 08:55 |
| dulek | apuimedo: Okay, thanks! | 08:56 |
| apuimedo | thanks to you for noticing. It escaped me in the original review | 08:56 |
| *** danil has joined #openstack-kuryr | 08:56 | |
| dulek | apuimedo: It's hard not to notice if you're debugging code by building containers. :) | 08:56 |
| apuimedo | dulek: Well, I used to try it disabling caching | 08:57 |
| apuimedo | so it made no difference to me | 08:57 |
| dulek | apuimedo: Okay, so here's a fun issue I've hit with containerized mode, privsep and venv. | 09:05 |
| apuimedo | dulek: oh. I love those | 09:05 |
| apuimedo | come at me | 09:06 |
| dulek | apuimedo: Addressing your comment about "ovs_mod.linux_net.privsep.priv_context.Method.FORK" being impossible to inject, I've removed it and just installed sudo on the container. | 09:06 |
| apuimedo | dulek: I guess that didn't work :P | 09:06 |
| dulek | apuimedo: Now os-vif runs `sudo privsep-helper`. Which is fine normally. | 09:06 |
| *** openstackgerrit has joined #openstack-kuryr | 09:06 | |
| openstackgerrit | Deepak Mourya proposed openstack/fuxi master: trivial: Fix the misspelling of "default" https://review.openstack.org/531662 | 09:06 |
| dulek | apuimedo: But when kuryr-daemon is run from a venv, running sudo changes PYTHONPATH. | 09:07 |
| apuimedo | of course | 09:07 |
| apuimedo | :-) | 09:07 |
| dulek | apuimedo: So `privsep-helper` is run from the system Python environment. Where it's missing. | 09:07 |
| apuimedo | that's a very funny issue | 09:07 |
| dulek | apuimedo: I can try to make sudo pass PYTHONPATH, but that would be a system-specific thing. | 09:08 |
| apuimedo | if it used full path this would not happen | 09:08 |
| dulek | apuimedo: I can *probably* change `sudo` to `sudo -E` by using https://github.com/openstack/oslo.privsep/blob/master/oslo_privsep/priv_context.py#L51-L58 | 09:09 |
| dulek | apuimedo: I can also get back to installing kuryr-kubernetes on the system in the container and run it from there. | 09:10 |
| apuimedo | try the config way | 09:10 |
| apuimedo | and fallback to installing kuryr-k8s on the system if that does not help | 09:10 |
| dulek | apuimedo: Oh, I can also just install oslo.privsep on the system. But that feels like a hack to me. | 09:11 |
| apuimedo | dulek: agreed | 09:11 |
| dulek | apuimedo: Okay, let's see how those configs work… :) | 09:12 |
| apuimedo | ;-) | 09:12 |
| *** caowei has quit IRC | 09:20 | |
| *** caowei has joined #openstack-kuryr | 09:21 | |
| *** garyloug has joined #openstack-kuryr | 09:31 | |
| *** yamamoto has quit IRC | 09:49 | |
| *** yamamoto has joined #openstack-kuryr | 09:57 | |
| *** caowei has quit IRC | 10:01 | |
| *** yamamoto has quit IRC | 10:31 | |
| *** yamamoto has joined #openstack-kuryr | 10:31 | |
| *** yamamoto has quit IRC | 10:31 | |
| *** dims has quit IRC | 10:57 | |
| *** dims has joined #openstack-kuryr | 10:58 | |
| *** yboaron_ has joined #openstack-kuryr | 11:00 | |
| *** yboaron has quit IRC | 11:03 | |
| dulek | apuimedo: [vif_plug_ovs_privileged] | 11:05 |
| dulek | helper_command = privsep-helper | 11:05 |
| dulek | [vif_plug_linux_bridge_privileged] | 11:05 |
| dulek | helper_command = privsep-helper | 11:05 |
| dulek | apuimedo: :) | 11:05 |
| apuimedo | dulek: did it work? | 11:07 |
| dulek | apuimedo: Yes. So now it just runs "privsep-helper", without sudo or anything. :) | 11:08 |
| dulek | apuimedo: Just the config section name suck. | 11:08 |
| apuimedo | yup | 11:09 |
| *** janki has quit IRC | 11:13 | |
| *** yamamoto has joined #openstack-kuryr | 11:32 | |
| *** yamamoto has quit IRC | 11:32 | |
| *** yamamoto has joined #openstack-kuryr | 11:32 | |
| *** yboaron_ has quit IRC | 11:52 | |
| danil | hello, folks. Please, if you have an access to sriov devises, check my patches: (https://review.openstack.org/#/q/topic:bp/kuryr-kubernetes-sriov-support-refactor+(status:open+OR+status:merged)). If you need any instruction to setup installation, please, ping me | 11:57 |
| apuimedo | danil: I don't think I'll be able to test in the next week and a half | 12:01 |
| apuimedo | but I'll try to get somebody to it | 12:01 |
| *** maysamacedos has joined #openstack-kuryr | 12:16 | |
| irenab | danil, zuul does not pass on your patches | 12:44 |
| *** kiennt26_ has joined #openstack-kuryr | 12:48 | |
| *** janki has joined #openstack-kuryr | 12:54 | |
| *** yboaron_ has joined #openstack-kuryr | 12:55 | |
| *** danil has quit IRC | 12:58 | |
| *** danil has joined #openstack-kuryr | 12:58 | |
| *** pmannidi has joined #openstack-kuryr | 13:04 | |
| *** janonymous has quit IRC | 13:13 | |
| *** kiennt26 has quit IRC | 13:30 | |
| *** danil has quit IRC | 13:34 | |
| dulek | apuimedo: From ttx ML post: | 13:35 |
| dulek | NB: We are still working on the room / day / track assignment based on | 13:35 |
| dulek | each team's requirements and hope to be able to publish a strawman | 13:35 |
| dulek | proposal by the end of the week. | 13:35 |
| dulek | apuimedo: Do we have some requirements already? | 13:35 |
| *** kiennt26_ has quit IRC | 13:46 | |
| *** pmannidi has quit IRC | 13:46 | |
| *** maysamacedos has quit IRC | 13:53 | |
| *** maysamacedos has joined #openstack-kuryr | 13:54 | |
| apuimedo | dulek: I don't remember | 14:01 |
| apuimedo | will have to send | 14:01 |
| *** aojea_ has joined #openstack-kuryr | 14:02 | |
| *** kiennt26 has joined #openstack-kuryr | 14:16 | |
| *** kaliya has joined #openstack-kuryr | 14:17 | |
| *** yboaron_ has quit IRC | 14:51 | |
| *** gianpietro has joined #openstack-kuryr | 15:08 | |
| *** hongbin has joined #openstack-kuryr | 15:29 | |
| *** yamamoto has quit IRC | 15:31 | |
| *** maysamacedos has quit IRC | 15:36 | |
| *** lihi has quit IRC | 15:42 | |
| *** lihi has joined #openstack-kuryr | 15:43 | |
| *** maysamacedos has joined #openstack-kuryr | 15:44 | |
| *** yamamoto has joined #openstack-kuryr | 15:46 | |
| *** gcheresh has quit IRC | 15:51 | |
| *** yamamoto has quit IRC | 15:51 | |
| *** kiennt26 has quit IRC | 15:56 | |
| *** premsankar has joined #openstack-kuryr | 15:59 | |
| *** gianpietro has quit IRC | 16:00 | |
| *** gianpietro has joined #openstack-kuryr | 16:00 | |
| *** gianpietro has quit IRC | 16:02 | |
| *** yamamoto has joined #openstack-kuryr | 16:04 | |
| *** gianpietro has joined #openstack-kuryr | 16:04 | |
| *** lihi has quit IRC | 16:04 | |
| *** yamamoto has quit IRC | 16:08 | |
| *** lihi has joined #openstack-kuryr | 16:08 | |
| *** atoth has joined #openstack-kuryr | 16:08 | |
| *** apuimedo has quit IRC | 16:08 | |
| openstackgerrit | Michał Dulko proposed openstack/kuryr-kubernetes master: Use virtualenv to build kuryr-cni Docker image https://review.openstack.org/534253 | 16:11 |
| openstackgerrit | Michał Dulko proposed openstack/kuryr-kubernetes master: Add experimental containerized jobs https://review.openstack.org/534827 | 16:11 |
| *** janki has quit IRC | 16:12 | |
| *** apuimedo has joined #openstack-kuryr | 16:12 | |
| *** aojea_ has quit IRC | 16:17 | |
| *** aojea_ has joined #openstack-kuryr | 16:17 | |
| *** aojea_ has quit IRC | 16:22 | |
| *** gianpietro has quit IRC | 16:38 | |
| *** gianpietro has joined #openstack-kuryr | 16:38 | |
| *** gianpietro has quit IRC | 16:43 | |
| *** gianpietro has joined #openstack-kuryr | 16:44 | |
| *** pcaruana has quit IRC | 16:46 | |
| *** yamamoto has joined #openstack-kuryr | 17:08 | |
| *** yamamoto has quit IRC | 17:17 | |
| *** maysamacedos has quit IRC | 17:49 | |
| *** aojea has joined #openstack-kuryr | 17:50 | |
| *** maysamacedos has joined #openstack-kuryr | 17:51 | |
| *** aojea_ has joined #openstack-kuryr | 17:55 | |
| *** aojea has quit IRC | 17:58 | |
| *** aojea has joined #openstack-kuryr | 18:01 | |
| *** gianpietro has quit IRC | 18:02 | |
| *** gianpietro has joined #openstack-kuryr | 18:03 | |
| *** aojea_ has quit IRC | 18:03 | |
| dulek | FYI - we have os-vif 1.9.0 released, no more workarounds should be needed. | 18:04 |
| *** aojea_ has joined #openstack-kuryr | 18:05 | |
| *** gianpietro has quit IRC | 18:08 | |
| *** aojea has quit IRC | 18:08 | |
| *** aojea has joined #openstack-kuryr | 18:11 | |
| *** aojea_ has quit IRC | 18:13 | |
| apuimedo | dulek: I thought Christmas was last month | 18:14 |
| *** aojea_ has joined #openstack-kuryr | 18:15 | |
| *** aojea has quit IRC | 18:19 | |
| *** aojea has joined #openstack-kuryr | 18:21 | |
| *** dulek_mobile has joined #openstack-kuryr | 18:21 | |
| dulek | apuimedo: It's for Chinese New Year maybe? | 18:22 |
| *** aojea_ has quit IRC | 18:23 | |
| *** aojea_ has joined #openstack-kuryr | 18:25 | |
| *** aojea has quit IRC | 18:28 | |
| apuimedo | :-) | 18:30 |
| *** aojea has joined #openstack-kuryr | 18:31 | |
| *** aojea_ has quit IRC | 18:34 | |
| *** kaliya has quit IRC | 18:34 | |
| *** aojea has quit IRC | 18:39 | |
| *** yboaron_ has joined #openstack-kuryr | 18:55 | |
| *** atoth has quit IRC | 19:12 | |
| *** gianpietro has joined #openstack-kuryr | 19:13 | |
| *** gianpietro has quit IRC | 19:17 | |
| *** juriarte has quit IRC | 19:55 | |
| *** gianpietro has joined #openstack-kuryr | 20:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-libnetwork master: Updated from global requirements https://review.openstack.org/523740 | 20:38 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-kubernetes master: Updated from global requirements https://review.openstack.org/509781 | 20:38 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-tempest-plugin master: Updated from global requirements https://review.openstack.org/530688 | 20:38 |
| *** garyloug has quit IRC | 20:46 | |
| *** gianpietro has quit IRC | 20:46 | |
| *** gianpietro has joined #openstack-kuryr | 20:46 | |
| *** gianpietro has quit IRC | 20:46 | |
| *** gianpietro has joined #openstack-kuryr | 20:47 | |
| *** dulek_mobile_ has joined #openstack-kuryr | 20:57 | |
| apuimedo | maysamacedos: do you have some environment with the health manager running? | 20:58 |
| maysamacedos | yes | 20:58 |
| *** aojea has joined #openstack-kuryr | 21:00 | |
| apuimedo | is it internet reachable? | 21:00 |
| *** dulek_mobile has quit IRC | 21:00 | |
| *** phuoc has quit IRC | 21:00 | |
| *** phuoc has joined #openstack-kuryr | 21:01 | |
| apuimedo | maysamacedos: just posted the review | 21:02 |
| apuimedo | let me know what you think about the suggestion | 21:02 |
| maysamacedos | I'm running with vagrant, probably would need to configure something | 21:02 |
| apuimedo | maysamacedos: ah, no worries. I'll trigger it in my machine then | 21:03 |
| *** aojea_ has joined #openstack-kuryr | 21:05 | |
| *** aojea has quit IRC | 21:08 | |
| *** aojea has joined #openstack-kuryr | 21:09 | |
| *** dulek_mobile_ has quit IRC | 21:13 | |
| *** aojea_ has quit IRC | 21:13 | |
| *** aojea_ has joined #openstack-kuryr | 21:15 | |
| *** aojea has quit IRC | 21:18 | |
| *** aojea has joined #openstack-kuryr | 21:21 | |
| *** aojea_ has quit IRC | 21:23 | |
| *** aojea_ has joined #openstack-kuryr | 21:25 | |
| *** aojea has quit IRC | 21:28 | |
| *** aojea has joined #openstack-kuryr | 21:30 | |
| *** aojea_ has quit IRC | 21:33 | |
| *** aojea_ has joined #openstack-kuryr | 21:35 | |
| maysamacedos | apuimedo: ping | 21:37 |
| *** aojea has quit IRC | 21:38 | |
| *** aojea has joined #openstack-kuryr | 21:41 | |
| *** threestrands_ has joined #openstack-kuryr | 21:44 | |
| *** aojea_ has quit IRC | 21:44 | |
| *** threestrands_ has quit IRC | 21:45 | |
| *** threestrands_ has joined #openstack-kuryr | 21:45 | |
| *** threestrands_ has quit IRC | 21:45 | |
| *** threestrands_ has joined #openstack-kuryr | 21:45 | |
| *** aojea_ has joined #openstack-kuryr | 21:45 | |
| *** aojea has quit IRC | 21:48 | |
| apuimedo | maysamacedos: pong | 21:50 |
| maysamacedos | apuimedo: I was trying to figure out a more proper way to relate the manager with the watcher and pipeline/retry, since they have a directly relation with the manager when probably should be the other way around. What do you think? | 21:55 |
| apuimedo | mmm | 21:56 |
| apuimedo | maysamacedos: you mean that the manager should hold references to the watcher/pipeline/retry instead? | 21:58 |
| maysamacedos | yep | 21:58 |
| apuimedo | as a model it does sound better | 21:58 |
| apuimedo | the challenge is though, how does the manager use the reference to get the health? | 21:59 |
| apuimedo | In time A a handler has an exception | 21:59 |
| apuimedo | in time A' the manager receives a GET for the /alive enpoint | 21:59 |
| apuimedo | maysamacedos: can you propose some interaction through the references? | 22:00 |
| apuimedo | that the manager would hold | 22:00 |
| apuimedo | ? | 22:00 |
| maysamacedos | I thought about adding a reference in each instance of watcher/handler indicating whether its healthy or not | 22:01 |
| maysamacedos | the manager will have a reference to this intances | 22:01 |
| maysamacedos | and then load when the probe calls | 22:02 |
| maysamacedos | each time the probe calls* | 22:02 |
| maysamacedos | for the time, I think it could be set in the probe a smaller interval of checks | 22:03 |
| apuimedo | maysamacedos: you mean that teh manager would be polling the instances? | 22:04 |
| maysamacedos | apuimedo: the only trick part would be for the pipeline/retry | 22:04 |
| maysamacedos | apuimedo: yes | 22:04 |
| *** gianpietro has quit IRC | 22:04 | |
| maysamacedos | it initiates with references to the instances that it should check | 22:05 |
| maysamacedos | and then check the existente reference of health in each instance | 22:06 |
| apuimedo | if we want to poll, what's the point of doing it with more frequency? | 22:06 |
| apuimedo | it should just be done when we receive the GET | 22:06 |
| apuimedo | shouldn't it? | 22:06 |
| maysamacedos | yes | 22:07 |
| maysamacedos | I though it would be good to recover faster, but It might not makee a big difference | 22:07 |
| *** gianpietro has joined #openstack-kuryr | 22:07 | |
| apuimedo | the difference would hardly justify having a thread polling | 22:08 |
| apuimedo | :-) | 22:08 |
| maysamacedos | apuimedo: I will verify if this approach (of adding references to the manager) works as expected | 22:12 |
| apuimedo | maysamacedos: you're going to store the failures in the instances or figure out a way to see if the instances are in order in some other way? | 22:13 |
| maysamacedos | store the failure in the instances | 22:13 |
| apuimedo | maysamacedos: I wonder if then it makes sense to make the new version depend on the retry patch that you pointed out to me the other day | 22:15 |
| apuimedo | (with limited retries) | 22:15 |
| maysamacedos | apuimedo: Yes, I think it does | 22:16 |
| maysamacedos | since the failure will be only registered when the amount of retries exceeds | 22:17 |
| maysamacedos | registered I mean by only a variable that points whether its unhealthy | 22:19 |
| apuimedo | good | 22:20 |
| maysamacedos | this sounds better? | 22:20 |
| apuimedo | maysamacedos: remember to have it with a leading underscore '_' | 22:20 |
| apuimedo | :-) | 22:20 |
| apuimedo | I think it's worthy to have as a separate patch and let all the reviewers weigh in | 22:21 |
| maysamacedos | apuimedo: ok | 22:24 |
| apuimedo | thanks maysamacedos :-) | 22:25 |
| maysamacedos | I will open another one when I have this implemented | 22:25 |
| apuimedo | perfect! | 22:25 |
| maysamacedos | apuimedo: thank you | 22:25 |
| apuimedo | maysamacedos: is there anything else I can help with? | 22:26 |
| maysamacedos | apuimedo: nop | 22:26 |
| maysamacedos | thanks again | 22:26 |
| maysamacedos | have a great night | 22:26 |
| apuimedo | Thanks! | 22:26 |
| apuimedo | You too! | 22:26 |
| *** gianpietro has quit IRC | 22:39 | |
| *** maysamacedos has quit IRC | 23:05 | |
| *** hongbin has quit IRC | 23:06 | |
| *** maysamacedos has joined #openstack-kuryr | 23:44 | |
| *** pmannidi has joined #openstack-kuryr | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!