| *** pmannidi has quit IRC | 00:11 | |
| *** pmannidi has joined #openstack-kuryr | 00:31 | |
| *** yamamoto_ has joined #openstack-kuryr | 00:38 | |
| *** yamamoto_ has quit IRC | 00:44 | |
| *** xiangxinyong has quit IRC | 00:59 | |
| *** atoth has quit IRC | 01:34 | |
| *** yedongcan has joined #openstack-kuryr | 01:36 | |
| *** yamamoto_ has joined #openstack-kuryr | 01:40 | |
| *** yamamoto_ has quit IRC | 01:45 | |
| *** mattmceuen has joined #openstack-kuryr | 01:51 | |
| *** vikasc has quit IRC | 01:53 | |
| *** salv-orlando has joined #openstack-kuryr | 02:05 | |
| *** salv-orl_ has quit IRC | 02:08 | |
| *** edisonxiang has joined #openstack-kuryr | 02:09 | |
| *** yamamoto_ has joined #openstack-kuryr | 02:16 | |
| *** aojea has joined #openstack-kuryr | 03:04 | |
| *** aojea has quit IRC | 03:08 | |
| *** hongbin has joined #openstack-kuryr | 03:20 | |
| *** edisonxiang has quit IRC | 03:45 | |
| *** edisonxiang has joined #openstack-kuryr | 03:46 | |
| *** pmannidi has quit IRC | 04:12 | |
| *** pmannidi has joined #openstack-kuryr | 04:29 | |
| *** janki has joined #openstack-kuryr | 04:31 | |
| *** yamamoto_ has quit IRC | 04:44 | |
| *** hongbin has quit IRC | 04:47 | |
| *** pmannidi has quit IRC | 04:54 | |
| *** pcaruana has joined #openstack-kuryr | 04:56 | |
| *** aojea has joined #openstack-kuryr | 05:02 | |
| *** dims has quit IRC | 05:09 | |
| *** pmannidi has joined #openstack-kuryr | 05:12 | |
| *** pcaruana has quit IRC | 05:14 | |
| *** yamamoto has joined #openstack-kuryr | 05:31 | |
| *** dims has joined #openstack-kuryr | 05:41 | |
| *** aojea has quit IRC | 06:06 | |
| *** salv-orlando has quit IRC | 06:25 | |
| *** ltomasbo|away is now known as ltomasbo | 06:30 | |
| irenab | good morning | 06:49 |
|---|---|---|
| irenab | apuimedo, alive? | 06:49 |
| ltomasbo | good morning irenab | 06:55 |
| ltomasbo | thanks for reviewing the patches! | 06:55 |
| irenab | ltomasbo, trying my best. Sorry if not raised some questions earlier | 06:56 |
| ltomasbo | just one more (https://review.openstack.org/#/c/436894/) and I'll start with modifications! | 06:56 |
| ltomasbo | based on your suggestions! | 06:56 |
| ltomasbo | irenab, no problem! | 06:56 |
| ltomasbo | they make sense and does not seems to be huge changes (without counting unittesting...) | 06:57 |
| irenab | I think that the comments on the last patch, I actually posted on the dependant patch | 06:57 |
| ltomasbo | irenab, ahh, ok, then I can start working on them! | 07:02 |
| *** pcaruana has joined #openstack-kuryr | 07:03 | |
| apuimedo | I am alive! | 07:08 |
| irenab | apuimedo, hope your fligth back was ok | 07:09 |
| apuimedo | delayed as usual | 07:09 |
| apuimedo | but ok | 07:09 |
| *** salv-orlando has joined #openstack-kuryr | 07:09 | |
| *** limao has quit IRC | 07:10 | |
| *** limao has joined #openstack-kuryr | 07:11 | |
| *** roeyc has joined #openstack-kuryr | 07:13 | |
| irenab | ltomasbo, added few comments on the last patch | 07:16 |
| ltomasbo | irenab, great! thanks! | 07:19 |
| *** aojea has joined #openstack-kuryr | 07:22 | |
| *** aojea has joined #openstack-kuryr | 07:23 | |
| ltomasbo | ping irenab | 07:26 |
| irenab | ltomasbo, pong | 07:26 |
| ltomasbo | regarding your last comments on https://review.openstack.org/#/c/436894/19/kuryr_kubernetes/controller/drivers/nested_vlan_vif.py | 07:26 |
| ltomasbo | both kind of related | 07:26 |
| ltomasbo | for the first one, I'll add the doc-string | 07:27 |
| ltomasbo | but based on previous comment | 07:27 |
| ltomasbo | it is not atomic (either all or none) | 07:27 |
| ltomasbo | but it creates as many as possible up to num_ports | 07:27 |
| ltomasbo | so, if num_ports is 10, but only 5 vlan_ids are available, it will create 5 | 07:27 |
| irenab | what lines 95-96 serve for? | 07:27 |
| ltomasbo | that is a different story... | 07:28 |
| *** limao has quit IRC | 07:28 | |
| ltomasbo | once we select the vlan_ids available | 07:28 |
| ltomasbo | lets say we requested 10, but only 5 are available | 07:28 |
| ltomasbo | it may happen that some other entity requested them (manually or any other method not using kuryr) | 07:29 |
| *** limao has joined #openstack-kuryr | 07:29 | |
| ltomasbo | and there may be a collission | 07:29 |
| ltomasbo | in that case, the add_subports will fail | 07:29 |
| ltomasbo | but yes, I should add that to the docstring so that is clear | 07:30 |
| ltomasbo | and I need to check the current behavior of add_subports (just in case they have changed from all or nothing to all that do not conflict) | 07:31 |
| irenab | yes, these methods are related, but seems each one deals with its own corner cases. I just was confused since it looked as they are not aligned | 07:32 |
| ltomasbo | and the comment in line 153 is somehow related, the break ensures that the current obtained information is the one used | 07:32 |
| *** salv-orl_ has joined #openstack-kuryr | 07:32 | |
| ltomasbo | i.e., if only 5 where available, we return those 5 and create the ports/subports based on that information | 07:32 |
| ltomasbo | well, one part is to get enough vlans to attach the subports (L138 method) | 07:33 |
| ltomasbo | and the other one is to actually attach the subports using the returned vlans | 07:33 |
| irenab | the port here is for trunk port, right? | 07:33 |
| ltomasbo | irenab, the port where? | 07:34 |
| irenab | line 145 | 07:34 |
| ltomasbo | this is the port request information | 07:34 |
| ltomasbo | used to create all the subports | 07:34 |
| irenab | to be used for the subport in the caller method? | 07:34 |
| irenab | maybe rename for subport will impove the method readability | 07:35 |
| ltomasbo | basically, method at L138 returns all the information needed to create the subports | 07:35 |
| ltomasbo | 1.- create the port | 07:35 |
| ltomasbo | 2.- the vlans where they are going to be attached | 07:35 |
| ltomasbo | 3.- attach the subports in the proper vlans | 07:35 |
| ltomasbo | perhaps have it as port_rq (as in the mapped variable at L72) | 07:36 |
| *** salv-orlando has quit IRC | 07:37 | |
| irenab | another queston, why both vlan_ids and subport_ifo (that contains vlans) | 07:38 |
| irenab | are needed , line 160 | 07:38 |
| ltomasbo | umm, let me see | 07:39 |
| ltomasbo | to be honest, for commodity at requests_vifs method | 07:40 |
| *** foutatoro has joined #openstack-kuryr | 07:40 | |
| ltomasbo | I check its length to see how many subports to create (which I can do by measuring subports_info len too | 07:41 |
| ltomasbo | and then at line 105 | 07:41 |
| ltomasbo | but you are right, I can do the same without that | 07:42 |
| *** egonzalez has joined #openstack-kuryr | 07:45 | |
| *** roeyc has quit IRC | 07:54 | |
| *** kzaitsev_ws has joined #openstack-kuryr | 07:54 | |
| *** pmannidi has quit IRC | 08:02 | |
| irenab | ltomasbo, sorry, too many interupts ... Yes, it just seemed redundant | 08:05 |
| ltomasbo | irenab, sure, I'll removed | 08:06 |
| ltomasbo | irenab, btw, as the patches are dependent on each other | 08:06 |
| irenab | cross? | 08:06 |
| ltomasbo | I will leave the generic one without having a base-clase | 08:06 |
| irenab | ok | 08:06 |
| ltomasbo | and then, create the base clase at the first nested patch | 08:06 |
| ltomasbo | just in case the merge at different time | 08:07 |
| ltomasbo | irenab, ok, great! | 08:07 |
| irenab | good | 08:07 |
| *** aojea has quit IRC | 08:28 | |
| *** aojea has joined #openstack-kuryr | 08:33 | |
| *** roeyc has joined #openstack-kuryr | 08:34 | |
| *** foutatoro has quit IRC | 08:36 | |
| *** neil__ has joined #openstack-kuryr | 08:44 | |
| *** limao has quit IRC | 08:45 | |
| *** limao has joined #openstack-kuryr | 08:45 | |
| *** neil__ has quit IRC | 09:09 | |
| *** garyloug has joined #openstack-kuryr | 09:20 | |
| qwebirc89498 | kzaitsev_ws: hi , thank you for your help ,I figured out the root cause for yesterday's issue ,it was my mistake, i forgot to configure the --service-cluster-ip-range | 09:21 |
| qwebirc89498 | and yes we don't need to set the annotations for the Service | 09:21 |
| *** limao has quit IRC | 09:29 | |
| *** foutatoto has joined #openstack-kuryr | 09:30 | |
| *** foutatoto has quit IRC | 09:34 | |
| *** neil__ has joined #openstack-kuryr | 09:38 | |
| *** limao has joined #openstack-kuryr | 09:43 | |
| *** limao has quit IRC | 09:47 | |
| kzaitsev_ws | qwebirc89498: glad you figured it out =) | 09:48 |
| kzaitsev_ws | irenab: apuimedo: would it be a good idea to start a FAQ/troubleshooting page in the docs to collect things like ^^^ | 09:51 |
| apuimedo | kzaitsev_ws: no it wouldn't | 09:52 |
| apuimedo | It would be an excellent idea! | 09:52 |
| kzaitsev_ws | also how was the OpenStack Day Israel? | 09:53 |
| irenab | kzaitsev_ws, +1 | 09:56 |
| irenab | OpenStack day was good, apuimedo is like a real showman. There was great k8s-openstack panel he participated | 09:56 |
| apuimedo | irenab: thanks irenab :-) | 09:57 |
| apuimedo | irenab: kzaitsev_ws: I wish we'd had 40min instead of 30 for the presentation though | 09:57 |
| apuimedo | also. I think that our presentation would benefit from a slide I have for openshift integration | 09:58 |
| apuimedo | that shows which components go out of the window (like kube-proxy) | 09:58 |
| kzaitsev_ws | (= | 09:58 |
| irenab | indeed. We mention it, but its not clear from the slides | 09:59 |
| irenab | Do you have the reference to your OpenShift slide? | 09:59 |
| apuimedo | let me find it | 09:59 |
| apuimedo | irenab: it's the contrast between slides 7 and 9 of https://docs.google.com/presentation/d/1ZpafVTNHHFswEPd-CA8oNQhtoUn19eVGY2WtY3G9ccs/edit?usp=sharing | 10:00 |
| irenab | nice | 10:01 |
| apuimedo | irenab: let's have it for next time | 10:02 |
| apuimedo | (whenever that may be) | 10:02 |
| irenab | for our next presentation, lets add it :-) | 10:02 |
| kzaitsev_ws | love the platypus going through the ring at the demo slide =) | 10:02 |
| apuimedo | :P | 10:03 |
| apuimedo | kzaitsev_ws: I'm a master of crappy design | 10:03 |
| apuimedo | :-) | 10:03 |
| *** foutatoro has joined #openstack-kuryr | 10:03 | |
| apuimedo | ltomasbo: can you respin https://review.openstack.org/#/c/436876/15 with the addressed Done so we can merge it? | 10:05 |
| ltomasbo | apuimedo, working on the unittest of the 436877 | 10:06 |
| ltomasbo | and I'll submit both | 10:06 |
| apuimedo | perfect | 10:06 |
| ltomasbo | wait a few minutes | 10:06 |
| apuimedo | mchiappero: ping | 10:06 |
| apuimedo | ltomasbo: I'll try | 10:06 |
| ltomasbo | :D | 10:06 |
| apuimedo | you should take advantage that I woke up merge-happy | 10:07 |
| apuimedo | :-) | 10:07 |
| foutatoro | hi all, I would like to know is there possible to attach container created with magnum and VM to in the same tenant network ? | 10:10 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Generic vif pool driver extension to precreate reusable ports https://review.openstack.org/436877 | 10:13 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Generic vif driver extension to enable ports reuse https://review.openstack.org/436876 | 10:13 |
| ltomasbo | apuimedo, done | 10:14 |
| ltomasbo | going to work on the nested ones, that will have a little bit more of work | 10:14 |
| apuimedo | cool | 10:14 |
| openstackgerrit | Merged openstack/kuryr-kubernetes master: Refactor the class hierarchy of controller drivers https://review.openstack.org/469828 | 10:17 |
| kzaitsev_ws | foutatoro: afaik magnum uses flannel for networking | 10:17 |
| ltomasbo | umm that one got merged? | 10:18 |
| ltomasbo | that will be more re-shaping... | 10:18 |
| kzaitsev_ws | ltomasbo: yeah =) I'm preparing for some merge conflicts too =) | 10:19 |
| ltomasbo | ;( | 10:19 |
| apuimedo | ltomasbo: sorry about that | 10:19 |
| kzaitsev_ws | foutatoro: I think there is some work happening, but the support is not there yet | 10:20 |
| ltomasbo | apuimedo, I think that patch also needed to fix the setup.cfg... | 10:22 |
| foutatoro | kzaitsev_ws: thanks for your repy | 10:22 |
| ltomasbo | pointing to neutron_vif instead of generic_vif... | 10:22 |
| ltomasbo | didn't have time to do the review... | 10:23 |
| apuimedo | ltomasbo: will check | 10:24 |
| apuimedo | ltomasbo: you're right | 10:24 |
| apuimedo | meh... We really miss functional tests | 10:24 |
| ltomasbo | yep | 10:27 |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: Add MACVLAN based interfaces for nested containers https://review.openstack.org/440669 | 10:34 |
| *** edisonxiang has quit IRC | 10:43 | |
| *** edisonxiang has joined #openstack-kuryr | 10:43 | |
| apuimedo | irenab: please review ^^ | 10:44 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Generic vif pool driver extension to precreate reusable ports https://review.openstack.org/436877 | 10:46 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Generic vif driver extension to enable ports reuse https://review.openstack.org/436876 | 10:46 |
| ltomasbo | apuimedo, I've resubmited the generic pool patches | 10:46 |
| apuimedo | great | 10:48 |
| kzaitsev_ws | I still failed to test the macvlan patch =( trunk port docs are a bit cryptic. wish there was a clear example with a couple of commands to spawn things up | 10:51 |
| openstackgerrit | Kirill Zaitsev proposed openstack/kuryr-kubernetes master: Add kuryr-sriov spec proposal https://review.openstack.org/465661 | 11:01 |
| openstackgerrit | Kirill Zaitsev proposed openstack/kuryr-kubernetes master: Allow passing multiple VIFs to CNI https://review.openstack.org/471012 | 11:03 |
| apuimedo | kzaitsev_ws: that's doable actually | 11:03 |
| apuimedo | I'm thinking something like devstack-heat | 11:03 |
| kzaitsev_ws | while you all are around. I've implemented a minimum patch for passing multi-vifs to the CNI. ^^ Did it a bit differently than the bp proposes, e.g. used dict instead of a list of vifs (think ivc_ proposed that on a meeting) | 11:10 |
| *** yamamoto has quit IRC | 11:10 | |
| kzaitsev_ws | there are some rough edges in there, but the approach worked for my case just fine. | 11:12 |
| kzaitsev_ws | also it greatly simplified my CNI patch +) | 11:12 |
| kzaitsev_ws | so would be happy to get any feedback there ) | 11:13 |
| openstackgerrit | Kirill Zaitsev proposed openstack/kuryr-kubernetes master: [WIP] Add SRIOV binding driver to CNI https://review.openstack.org/462456 | 11:13 |
| openstackgerrit | Kirill Zaitsev proposed openstack/kuryr-kubernetes master: [WIP] Add SRIOV capabilities to VIF handler https://review.openstack.org/462455 | 11:13 |
| *** aojea has quit IRC | 11:16 | |
| *** ashishb_ has joined #openstack-kuryr | 11:30 | |
| *** oanson has quit IRC | 11:40 | |
| *** oanson has joined #openstack-kuryr | 11:42 | |
| *** irenab has quit IRC | 11:42 | |
| *** irenab has joined #openstack-kuryr | 11:44 | |
| *** atoth has joined #openstack-kuryr | 11:50 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-kubernetes master: Updated from global requirements https://review.openstack.org/469489 | 11:51 |
| dmellado | apuimedo: meeting | 12:01 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Nested vif driver extension to enable ports reuse https://review.openstack.org/436893 | 12:13 |
| *** mattmceuen has quit IRC | 12:34 | |
| *** yamamoto has joined #openstack-kuryr | 12:36 | |
| *** yamamoto has quit IRC | 12:47 | |
| *** salv-orl_ has quit IRC | 12:49 | |
| *** salv-orlando has joined #openstack-kuryr | 12:50 | |
| *** salv-orlando has quit IRC | 12:54 | |
| openstackgerrit | Kirill Zaitsev proposed openstack/kuryr-kubernetes master: [WIP] Add SRIOV capabilities to VIF handler https://review.openstack.org/462455 | 12:56 |
| openstackgerrit | Kirill Zaitsev proposed openstack/kuryr-kubernetes master: [WIP] Add SRIOV binding driver to CNI https://review.openstack.org/462456 | 12:57 |
| *** yamamoto has joined #openstack-kuryr | 13:08 | |
| *** yedongcan has left #openstack-kuryr | 13:08 | |
| *** aojea has joined #openstack-kuryr | 13:23 | |
| *** yamamoto has quit IRC | 14:03 | |
| *** yamamoto has joined #openstack-kuryr | 14:03 | |
| *** yamamoto has quit IRC | 14:08 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Nested vlan vif pool driver extension to precreate reusable subports https://review.openstack.org/436894 | 14:11 |
| ltomasbo | apuimedo, I updated all the ports pool patches | 14:12 |
| ltomasbo | I hope you are still on the merge-happy mood! xD | 14:12 |
| *** janki has quit IRC | 14:16 | |
| apuimedo | I am! | 14:21 |
| *** limao has joined #openstack-kuryr | 14:36 | |
| *** aojea has quit IRC | 14:37 | |
| *** limao_ has joined #openstack-kuryr | 14:40 | |
| *** limao has quit IRC | 14:40 | |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: controller: Upd. remaining refs to generic vif https://review.openstack.org/471806 | 14:44 |
| apuimedo | ltomasbo: kzaitsev_ws: irenab: ^^ | 14:45 |
| ltomasbo | apuimedo, going to take a look | 14:46 |
| apuimedo | thanks | 14:46 |
| *** hongbin has joined #openstack-kuryr | 14:50 | |
| *** roeyc has quit IRC | 14:58 | |
| *** salv-orlando has joined #openstack-kuryr | 15:22 | |
| *** aojea has joined #openstack-kuryr | 15:45 | |
| *** aojea has quit IRC | 15:50 | |
| *** limao_ has quit IRC | 16:32 | |
| *** salv-orlando has quit IRC | 16:51 | |
| *** egonzalez has quit IRC | 16:55 | |
| *** ltomasbo is now known as ltomasbo|away | 16:56 | |
| *** yamamoto has joined #openstack-kuryr | 17:06 | |
| *** yamamoto has quit IRC | 17:11 | |
| *** salv-orlando has joined #openstack-kuryr | 17:14 | |
| openstackgerrit | Hongbin Lu proposed openstack/kuryr-libnetwork master: Ensure the returned pool has a matched cidr https://review.openstack.org/470773 | 17:38 |
| openstackgerrit | Hongbin Lu proposed openstack/kuryr-libnetwork master: Refactor subnetpool creation code into a method https://review.openstack.org/470772 | 17:38 |
| *** aojea has joined #openstack-kuryr | 17:42 | |
| *** kzaitsev_ws has quit IRC | 17:49 | |
| *** garyloug has quit IRC | 18:02 | |
| *** tonanhngo has joined #openstack-kuryr | 18:20 | |
| *** aojea has quit IRC | 18:20 | |
| *** salv-orlando has quit IRC | 18:21 | |
| *** salv-orlando has joined #openstack-kuryr | 18:21 | |
| *** salv-orlando has quit IRC | 18:25 | |
| *** egonzalez has joined #openstack-kuryr | 19:07 | |
| *** yamamoto has joined #openstack-kuryr | 19:08 | |
| *** yamamoto has quit IRC | 19:12 | |
| *** aojea has joined #openstack-kuryr | 19:17 | |
| *** salv-orlando has joined #openstack-kuryr | 19:26 | |
| *** rwallner has joined #openstack-kuryr | 19:59 | |
| *** rwallner has quit IRC | 20:03 | |
| *** dougbtv_ has joined #openstack-kuryr | 20:34 | |
| *** dougbtv has quit IRC | 20:38 | |
| *** salv-orl_ has joined #openstack-kuryr | 20:43 | |
| *** atoth has quit IRC | 20:44 | |
| *** salv-orlando has quit IRC | 20:46 | |
| *** pcaruana has quit IRC | 20:53 | |
| *** pcaruana has joined #openstack-kuryr | 20:53 | |
| *** pcaruana has quit IRC | 21:16 | |
| *** jgriffith has quit IRC | 21:29 | |
| *** jgriffith_ has joined #openstack-kuryr | 21:29 | |
| *** hongbin has quit IRC | 21:47 | |
| *** hongbin has joined #openstack-kuryr | 21:51 | |
| *** aojea has quit IRC | 22:18 | |
| *** egonzalez has quit IRC | 22:19 | |
| *** salv-orl_ has quit IRC | 22:37 | |
| *** salv-orlando has joined #openstack-kuryr | 22:37 | |
| *** salv-orlando has quit IRC | 22:41 | |
| *** yamamoto_ has joined #openstack-kuryr | 23:11 | |
| *** openstack has joined #openstack-kuryr | 23:12 | |
| *** yamamoto_ has quit IRC | 23:16 | |
| *** rwallner has joined #openstack-kuryr | 23:27 | |
| *** pmannidi has joined #openstack-kuryr | 23:30 | |
| *** yamamoto_ has joined #openstack-kuryr | 23:47 | |
| *** rwallner has quit IRC | 23:52 | |
| *** tonanhngo has quit IRC | 23:54 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!