| *** yuanying has quit IRC | 00:00 | |
| *** yuanying has joined #openstack-kuryr | 00:01 | |
| *** salv-orlando has joined #openstack-kuryr | 00:15 | |
| *** salv-orlando has quit IRC | 00:19 | |
| *** hongbin has quit IRC | 00:27 | |
| *** yamamoto_ has joined #openstack-kuryr | 01:19 | |
| *** salv-orlando has joined #openstack-kuryr | 02:16 | |
| *** salv-orlando has quit IRC | 02:22 | |
| *** hongbin has joined #openstack-kuryr | 02:54 | |
| *** yamamoto_ has quit IRC | 03:06 | |
| *** gouthamr has quit IRC | 03:07 | |
| *** hongbin has quit IRC | 03:27 | |
| *** janki has joined #openstack-kuryr | 03:38 | |
| *** yamamoto_ has joined #openstack-kuryr | 03:58 | |
| *** aojea has joined #openstack-kuryr | 03:59 | |
| *** aojea has quit IRC | 04:04 | |
| *** salv-orlando has joined #openstack-kuryr | 04:19 | |
| *** salv-orlando has quit IRC | 04:23 | |
| *** salv-orlando has joined #openstack-kuryr | 04:39 | |
| *** ltomasbo|away is now known as ltomasbo | 05:37 | |
| *** aojea has joined #openstack-kuryr | 05:39 | |
| *** aojea has quit IRC | 05:54 | |
| *** aojea has joined #openstack-kuryr | 05:54 | |
| *** aojea has quit IRC | 05:58 | |
| *** salv-orlando has quit IRC | 06:19 | |
| janonymous | ivc_: ping | 06:42 |
|---|---|---|
| janonymous | ivc_: In current k8s watcher implementation to stop watching we directly kill the thread? | 06:43 |
| janonymous | ivc_: (using ?watch ) | 06:43 |
| kzaitsev_ws | docker_manager.go:372] NetworkPlugin cni failed on the status hook for pod 'pod_name_here' - Unexpected command output Device "eth0" does not exist. | 06:51 |
| kzaitsev_ws | has anyone seen this behaviour | 06:51 |
| kzaitsev_ws | i'm on k8s 1.5.4 for testing reasons | 06:52 |
| *** neiljerram has joined #openstack-kuryr | 07:01 | |
| kzaitsev_ws | looks like k8s containers start without eth0, but that feels correct | 07:06 |
| kzaitsev_ws | I guess CNI should configure it | 07:06 |
| *** salv-orlando has joined #openstack-kuryr | 07:11 | |
| janonymous | kzaitsev_ws: what's the output of sudo journalctl -u kube* | 07:12 |
| kzaitsev_ws | let me get a clean example | 07:15 |
| janonymous | https://github.com/kubernetes/kubernetes/blob/release-1.5/pkg/kubelet/dockertools/docker_manager.go#L368 | 07:17 |
| kzaitsev_ws | meanwhile - here's output from kuryr-k8s | 07:17 |
| kzaitsev_ws | http://paste.openstack.org/show/610925/ | 07:17 |
| kzaitsev_ws | janonymous: yeah, I've looked through it. it checks IP of eth0 | 07:18 |
| kzaitsev_ws | probably it's not the reason of my errors though | 07:19 |
| janonymous | yes, what is dm.networkPlugin.Name() | 07:19 |
| janonymous | NetworkPlugin cni failed on the status hook for pod( 'pod_name_here' -- dm.networkPlugin.Name()) | 07:20 |
| janonymous | ops i read it wrong, cni only | 07:22 |
| janonymous | In paste above it shows: NoMatches: No 'kuryr_kubernetes.vif_translators' driver found, looking for u'binding_failed' | 07:23 |
| janonymous | have you checked binding directory in kuryr.conf and scripts at locations | 07:23 |
| kzaitsev_ws | janonymous: yeah, seems that I messed with it in a wrong way =/ | 07:24 |
| janonymous | :D , roll back :D | 07:24 |
| *** salv-orl_ has joined #openstack-kuryr | 07:27 | |
| *** salv-orlando has quit IRC | 07:30 | |
| *** aojea has joined #openstack-kuryr | 07:31 | |
| *** pcaruana has joined #openstack-kuryr | 07:33 | |
| *** pcaruana has quit IRC | 07:39 | |
| *** pcaruana has joined #openstack-kuryr | 07:39 | |
| *** ltomasbo is now known as ltomasbo|away | 07:42 | |
| *** neiljerram has quit IRC | 07:44 | |
| *** egonzalez has joined #openstack-kuryr | 07:47 | |
| kzaitsev_ws | ugh. I really don't remember changing those | 07:48 |
| kzaitsev_ws | janonymous: what should it be? | 07:52 |
| *** garyloug has joined #openstack-kuryr | 08:01 | |
| janonymous | kzaitsev_ws: This might give an idea: https://github.com/openstack/kuryr-kubernetes/blob/master/devstack/plugin.sh#L410 | 08:03 |
| kzaitsev_ws | that's for cni configuration, not kuryr.conf | 08:05 |
| kzaitsev_ws | but yeah, I get the idea | 08:05 |
| *** neiljerram has joined #openstack-kuryr | 08:17 | |
| *** openstackgerrit has quit IRC | 08:18 | |
| kzaitsev_ws | oh, I think I found my patch that I used to create services without pods %) | 08:35 |
| *** ltomasbo|away is now known as ltomasbo | 08:41 | |
| kzaitsev_ws | k, looks like a cleanup helped | 09:03 |
| kzaitsev_ws | ok, I suspect rabbit was the culprit | 09:15 |
| kzaitsev_ws | although seems like I restored my lab back to being operational | 09:18 |
| janonymous | Great! | 09:18 |
| *** dimak_ has joined #openstack-kuryr | 09:24 | |
| *** egonzalez has quit IRC | 09:27 | |
| *** vikasc has quit IRC | 09:27 | |
| *** mchiappero has quit IRC | 09:27 | |
| *** huats has quit IRC | 09:27 | |
| *** huats has joined #openstack-kuryr | 09:32 | |
| *** dimak_ has quit IRC | 10:01 | |
| ivc_ | janonymous why do you need to stop watch? | 10:06 |
| *** dimak_ has joined #openstack-kuryr | 10:07 | |
| ivc_ | janonymous here is the 'kill': https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/watcher.py#L133 | 10:09 |
| ivc_ | janonymous but it is only used in https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/service.py#L62 | 10:10 |
| janonymous | ivc_: yup saw those, was thinking about graceful stop , but nothing to do with code was a generic question to know | 10:11 |
| janonymous | ivc_: i have some questions regarding watcher | 10:11 |
| ivc_ | janonymous in general yes, we just kill the thread (tho if it restarts it will pick up the queued events i think) | 10:12 |
| janonymous | ivc_:So while migrating to k8s client they use https://github.com/kubernetes-incubator/client-python#example instead of full urls which we used in https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/cni/main.py#L67 | 10:13 |
| *** egonzalez has joined #openstack-kuryr | 10:13 | |
| *** vikasc has joined #openstack-kuryr | 10:13 | |
| *** mchiappero has joined #openstack-kuryr | 10:13 | |
| janonymous | List is defined in : https://raw.githubusercontent.com/kubernetes-incubator/client-python/master/kubernetes/client/apis/core_v1_api.py | 10:13 |
| ivc_ | janonymous so the difference is that they watch per namespace and we watch all namespaces then? | 10:14 |
| janonymous | So i could directly change url to api object because a disctionary of resources is maintained in watcher with key as path(string) | 10:14 |
| *** dimak_ has quit IRC | 10:14 | |
| ivc_ | janonymous do they have an API to watch all pods from all namespaces similar to how we do it? | 10:14 |
| ivc_ | janonymous ah i guess its 'list_pod_for_all_namespaces' | 10:15 |
| janonymous | ivc_ : they provide watch query parameter | 10:15 |
| janonymous | ivc_: second example: https://github.com/kubernetes-incubator/client-python#example | 10:15 |
| janonymous | yes | 10:15 |
| *** dims has quit IRC | 10:15 | |
| janonymous | i have found names corresponding to our queries in code | 10:15 |
| janonymous | but the problem is mapping of resources maintained in watcher | 10:16 |
| janonymous | once solution is to not change anything and pass keyword arguments | 10:16 |
| janonymous | In https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/cni/main.py#L67 and extract params apart from url in https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/watcher.py#L135 | 10:17 |
| *** dimak_ has joined #openstack-kuryr | 10:17 | |
| ivc_ | janonymous alsos note the cni code you linked uses fieldSelector, but that will not be used once once we move to daemon/exec cni | 10:18 |
| janonymous | yes | 10:18 |
| *** dims has joined #openstack-kuryr | 10:18 | |
| janonymous | i found out we can pass it as: w.stream(v1.list_namespaced_pod, params.args.K8S_POD_NAMESPACE, fieldSelector='metadata.name=%(pod)s' % {'pod': params.args.K8S_POD_NAME}): | 10:18 |
| janonymous | ivc_: how do you suggest to proceed? | 10:19 |
| janonymous | addtionaly kwargs or other approach.. | 10:20 |
| ivc_ | janonymous i don't quite see the problem here, could you explain in more detail? | 10:21 |
| janonymous | yes | 10:21 |
| *** dimak_ has quit IRC | 10:23 | |
| janonymous | ivc: So If we pass Path(string) in https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/cni/main.py#L67 --> then https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/watcher.py#L86 maintains a resource list with key as path | 10:24 |
| janonymous | Which finally calls : https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/watcher.py#L138 | 10:24 |
| janonymous | ivc_: But in Client we will something like: v1.list_namespaced_pod(params.args.K8S_POD_NAMESPACE, fieldSelector='metadata.name=%(pod)s' % {'pod': params.args.K8S_POD_NAME}) instead of path | 10:26 |
| janonymous | *we will add | 10:26 |
| janonymous | here: https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/cni/main.py#L67 | 10:27 |
| ivc_ | janonymous shouldn't it be w.stream(v1. list_namespaced_pod, ...)? from https://github.com/kubernetes-incubator/client-python/blob/master/examples/example2.py | 10:27 |
| janonymous | yes i ommitted to create less confusion :D | 10:28 |
| janonymous | it will that only | 10:28 |
| janonymous | *It will be like that only | 10:28 |
| janonymous | Or i guess i should upload semi completed patch for better understanding, but i might have to go in few more mins | 10:30 |
| ivc_ | janonymous well one way to do it would be to kuryr_watcher.add(target='list_namespaced_pod', **kwargs) i think (and use target + kwargs converted to tuple as key instead of our 'path') | 10:31 |
| *** yamamoto_ has quit IRC | 10:31 | |
| ivc_ | janonymous and we can have that 'list_namespaced_pod' as WATCH_NS_POD constant | 10:32 |
| janonymous | there are 4 places where these are used | 10:33 |
| ivc_ | janonymous then you'd do k8s_watch.stream(v1.getattr(target), **kwargs) | 10:33 |
| janonymous | https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/service.py#L44 | 10:34 |
| ivc_ | janonymous yes, instead of that list you'd have [WATCH_ALL_PODS, WATCH_ALL_SERVICES, WATCH_ALL_ENDPOINTS] i guess | 10:34 |
| ivc_ | janonymous or just ALL_PODS, etc. without WATCH_ prefix maybe | 10:35 |
| janonymous | and that about resource dictionary? https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/watcher.py#L86 | 10:35 |
| ivc_ | janonymous as i said, "use target + kwargs converted to tuple as key instead of our 'path'" | 10:36 |
| janonymous | yeah that would do | 10:37 |
| janonymous | thanks i will make changes and would discuss if i get stuck somewhere :) | 10:37 |
| ivc_ | janonymous you could also introduce some WatchTarget (or some better name) type instead those ALL_PODS, but that imo would be an overkill | 10:37 |
| janonymous | yup | 10:38 |
| ivc_ | janonymous also this list https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/service.py#L44 was supposed to come from kuryr.conf initially, but then we discussed 'profiles' which will setup the watcher, so there's no need for a watcher to be kuryr.conf-friendly | 10:41 |
| janonymous | ivc_: oh ohkay, thanks! | 10:43 |
| janonymous | ivc_: i will add you for review | 10:43 |
| ivc_ | janonymous sure | 10:43 |
| ivc_ | janonymous here's your key=tuple([target] + sorted(tuple(kwargs.items()))) | 10:55 |
| ivc_ | janonymous ah that second 'tuple' is redundant :), so key=tuple([target] + sorted(d.items())) | 10:56 |
| *** dims has quit IRC | 11:05 | |
| *** janki has quit IRC | 11:06 | |
| *** janki has joined #openstack-kuryr | 11:07 | |
| *** dims has joined #openstack-kuryr | 11:11 | |
| *** yamamoto has joined #openstack-kuryr | 11:12 | |
| *** aojea has quit IRC | 11:49 | |
| *** janki has quit IRC | 12:06 | |
| *** atoth has quit IRC | 12:23 | |
| *** mestery has quit IRC | 12:24 | |
| *** mestery has joined #openstack-kuryr | 12:27 | |
| *** atoth has joined #openstack-kuryr | 12:38 | |
| *** atoth has quit IRC | 12:39 | |
| *** atoth has joined #openstack-kuryr | 12:40 | |
| *** openstackgerrit has joined #openstack-kuryr | 12:42 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Generic vif driver extension to enable ports reuse https://review.openstack.org/436876 | 12:42 |
| *** garyloug_ has joined #openstack-kuryr | 12:57 | |
| *** garyloug has quit IRC | 12:57 | |
| *** gouthamr has joined #openstack-kuryr | 13:25 | |
| *** salv-orlando has joined #openstack-kuryr | 13:27 | |
| *** salv-orl_ has quit IRC | 13:30 | |
| *** aojea has joined #openstack-kuryr | 13:43 | |
| *** salv-orlando has quit IRC | 14:02 | |
| *** gouthamr has quit IRC | 14:20 | |
| *** gouthamr has joined #openstack-kuryr | 14:23 | |
| *** hongbin has joined #openstack-kuryr | 14:48 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Generic vif pool driver extension to precreate reusable ports https://review.openstack.org/436877 | 15:14 |
| *** kzaitsev_ws has quit IRC | 15:21 | |
| *** yamamoto has quit IRC | 15:28 | |
| *** yamamoto has joined #openstack-kuryr | 15:28 | |
| *** yamamoto has quit IRC | 15:33 | |
| *** aojea has quit IRC | 15:58 | |
| *** aojea has joined #openstack-kuryr | 15:59 | |
| *** tonanhngo has joined #openstack-kuryr | 16:00 | |
| *** aojea has quit IRC | 16:03 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Nested vif driver extension to enable ports reuse https://review.openstack.org/436893 | 16:05 |
| *** egonzalez has quit IRC | 16:09 | |
| *** salv-orlando has joined #openstack-kuryr | 16:29 | |
| *** yamamoto has joined #openstack-kuryr | 16:35 | |
| *** tonanhngo has quit IRC | 16:36 | |
| *** rwallner has joined #openstack-kuryr | 16:38 | |
| *** pcaruana has quit IRC | 16:43 | |
| *** ltomasbo is now known as ltomasbo|away | 16:44 | |
| *** yamamoto has quit IRC | 16:47 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Nested vlan vif pool driver extension to precreate reusable subports https://review.openstack.org/436894 | 16:52 |
| *** rwallner has quit IRC | 17:22 | |
| *** rwallner has joined #openstack-kuryr | 17:25 | |
| *** neiljerram has quit IRC | 17:28 | |
| *** egonzalez has joined #openstack-kuryr | 17:50 | |
| *** yamamoto has joined #openstack-kuryr | 17:53 | |
| *** aojea has joined #openstack-kuryr | 17:53 | |
| *** tonanhngo has joined #openstack-kuryr | 18:29 | |
| *** neiljerram has joined #openstack-kuryr | 18:30 | |
| *** vikasc has quit IRC | 18:44 | |
| *** vikasc has joined #openstack-kuryr | 18:45 | |
| *** neiljerram has quit IRC | 18:46 | |
| *** neiljerram has joined #openstack-kuryr | 18:47 | |
| *** yamamoto has quit IRC | 19:00 | |
| *** yamamoto has joined #openstack-kuryr | 19:05 | |
| *** dimak_ has joined #openstack-kuryr | 19:10 | |
| *** neiljerram has quit IRC | 19:20 | |
| *** yamamoto has quit IRC | 19:25 | |
| *** salv-orl_ has joined #openstack-kuryr | 19:27 | |
| *** salv-orlando has quit IRC | 19:30 | |
| *** neiljerram has joined #openstack-kuryr | 19:36 | |
| *** egonzalez has quit IRC | 20:00 | |
| *** yamamoto has joined #openstack-kuryr | 20:26 | |
| *** Guest63352 has joined #openstack-kuryr | 20:27 | |
| *** Guest63352 is now known as ryanender | 20:33 | |
| *** yamamoto has quit IRC | 20:34 | |
| *** rwallner has quit IRC | 20:48 | |
| *** rwallner has joined #openstack-kuryr | 20:48 | |
| *** atoth has quit IRC | 20:50 | |
| *** rwallner has quit IRC | 20:52 | |
| *** ryanender has quit IRC | 20:59 | |
| *** atoth has joined #openstack-kuryr | 21:02 | |
| *** mridu has joined #openstack-kuryr | 21:12 | |
| *** mridu has quit IRC | 21:13 | |
| *** aojea has quit IRC | 21:17 | |
| *** dimak_ has quit IRC | 21:17 | |
| *** salv-orl_ has quit IRC | 21:50 | |
| *** salv-orlando has joined #openstack-kuryr | 21:50 | |
| *** salv-orlando has quit IRC | 21:54 | |
| *** dougbtv has quit IRC | 22:07 | |
| *** gouthamr has quit IRC | 22:13 | |
| *** gouthamr has joined #openstack-kuryr | 22:15 | |
| *** tonanhngo has quit IRC | 22:55 | |
| *** gouthamr has quit IRC | 22:59 | |
| *** gouthamr has joined #openstack-kuryr | 23:00 | |
| *** gouthamr has quit IRC | 23:02 | |
| *** gouthamr has joined #openstack-kuryr | 23:03 | |
| *** tonanhngo has joined #openstack-kuryr | 23:04 | |
| *** tonanhngo has quit IRC | 23:08 | |
| *** garyloug_ has quit IRC | 23:10 | |
| openstackgerrit | Frederick F. Kautz IV proposed openstack/kuryr-kubernetes master: Add support for USE_SCREEN and default to screen if USE_SYSTEMD is not set https://review.openstack.org/469280 | 23:14 |
| *** dougbtv has joined #openstack-kuryr | 23:14 | |
| *** tonanhngo has joined #openstack-kuryr | 23:16 | |
| *** tonanhngo has quit IRC | 23:21 | |
| *** gouthamr has quit IRC | 23:50 | |
| *** gouthamr_ has joined #openstack-kuryr | 23:50 | |
| *** gouthamr_ has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!